From patchwork Sat Feb 3 04:10:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136353 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4530743A57; Sat, 3 Feb 2024 05:11:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E20C3402DC; Sat, 3 Feb 2024 05:11:38 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 98B574027E for ; Sat, 3 Feb 2024 05:11:37 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d934c8f8f7so25252565ad.2 for ; Fri, 02 Feb 2024 20:11:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933496; x=1707538296; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=; b=M2dCtsXBcezO0j0r9vmSMmXXj7xpyV3KMQHBSx4cbk2aNEsrluFd6X1smQ0K8aQKwO v0wxJMmaGgIg8QnYEbyxUaBxUHGwRsVsb/mOxcXYcwpEdJBmOJbGjI7awctDMpkQDJ3r GoqvRiy0fivYIVC4YrVuZOBoVJd4LYZcUH0F1aTKLSy4sF8Jjo3yRatwzufbBfXA5JYu 4nZZsgEkuoH8Whv8mpUaomIgWpJ4M9gLPS38YvMDURhfc//AUP3z8DZ/1RzY/uerHfrE Q7yKfcXtUsSoWQ0PJcsM/iPp9wc4Szz9daK9R+PWq4vFocI0pcIA41qZ2mimOEp+mD8d MJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933496; x=1707538296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=; b=d6oQ6tdoN7dEd9Fmwi4VBlZZW8gsZsL5msE+W4uEynFaAa91bYJHvgKbAnmRhGxevs 7tqTmSShnoZZhRO5ZYRdeoPFmLhRo2YVszCgFjf8b39jZjqn0WDoWKwFbgxrux4fdFaj WSnrvQ5GphCtSdRyxBYG0op8gF1rWpnkTvlnKx/Z/E4psaDtV6xgiqZNEt47qWPsoH4p BqbNtvuXBN6AkeOxsEIs3pJ4orrxN/EDkw338hm8rraX3NFRFk8GPO9xG2rkmgttSBc1 vTkyNHEhYR6M7eVdDTII8q6JUIKxev/Je1hYz8vipf9frFc7QLPkRqG92+YIEcqgwEqw rz8w== X-Gm-Message-State: AOJu0YzxYe/XckgmQ1JCKPjQD0Bo2aQikUYkdCT5SSpta0cRUVbhjV8S 9oGswetNtZ+N75Yz0G5YK8PspPFy6BR8H3YxnsV4SUe5M/ffTd3OYFF+9BcrPuB6KbDG5Qc+C5r Lbc0= X-Google-Smtp-Source: AGHT+IHhDlYft9rJ62SAyyI6Moa3jX/yPcuGQImcTqoBTQM8/WXTxBucEUCDJDC7z4AojieqidDYNQ== X-Received: by 2002:a17:902:8602:b0:1d3:45c8:bc0f with SMTP id f2-20020a170902860200b001d345c8bc0fmr7134309plo.46.1706933496552; Fri, 02 Feb 2024 20:11:36 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCV55oR7FYTfcynQzp7MvsXcAKoJSqDNXPLw2dQHTuYia2JGydho0xG7X5syVTY/1D7OfT35cVj4LF4gYOPpBJfH5c/3uy1DgIzIahQM7A== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id lq13-20020a170903144d00b001d95d47cce4sm2354386plb.138.2024.02.02.20.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:11:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Subject: [PATCH v7 01/19] common/sfc_efx: remove use of PMD logtype Date: Fri, 2 Feb 2024 20:10:06 -0800 Message-ID: <20240203041125.285232-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041125.285232-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041125.285232-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++--------- drivers/common/sfc_efx/sfc_efx_log.h | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c index 2dc5545760b8..5eeffb065b0d 100644 --- a/drivers/common/sfc_efx/sfc_efx.c +++ b/drivers/common/sfc_efx/sfc_efx.c @@ -15,7 +15,7 @@ #include "sfc_efx_log.h" #include "sfc_efx.h" -uint32_t sfc_efx_logtype; +int sfc_efx_logtype; static int sfc_efx_kvarg_dev_class_handler(__rte_unused const char *key, @@ -117,11 +117,4 @@ sfc_efx_family(struct rte_pci_device *pci_dev, return rc; } -RTE_INIT(sfc_efx_register_logtype) -{ - int ret; - - ret = rte_log_register_type_and_pick_level("pmd.common.sfc_efx", - RTE_LOG_NOTICE); - sfc_efx_logtype = (ret < 0) ? RTE_LOGTYPE_PMD : ret; -} +RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE); diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h index 694455c1b14e..1519ebdc175f 100644 --- a/drivers/common/sfc_efx/sfc_efx_log.h +++ b/drivers/common/sfc_efx/sfc_efx_log.h @@ -11,7 +11,7 @@ #define _SFC_EFX_LOG_H_ /** Generic driver log type */ -extern uint32_t sfc_efx_logtype; +extern int sfc_efx_logtype; /** Log message, add a prefix and a line break */ #define SFC_EFX_LOG(level, ...) \ From patchwork Sat Feb 3 04:10:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136354 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D14A943A57; Sat, 3 Feb 2024 05:11:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F84B4064E; Sat, 3 Feb 2024 05:11:40 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 4F3574029C for ; Sat, 3 Feb 2024 05:11:38 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5d8b519e438so2691725a12.1 for ; Fri, 02 Feb 2024 20:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933497; x=1707538297; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nv8FTd4nIOkDpIrFZS5XqniknFq2wcwUf8nwWdOzVQw=; b=AToLUmDmISyiLkJ8qb+lpSjNqa7HJT3yQQRLUjyAymwnYhRtm0QD9KRfNEM5uITSnU 0I3jtPMtKxwHfgXojTVKxiZkPPOrzVFLPKR9uqIaDNAykAVhR/UhwIiKptZrCj074ZA0 W0RUp6J7LiKzg632t6WSWUQwMJBTileOCSYGoBrAyXSkiR7U7hSX6/9fHNljLOej8kIY 6hMVDvXwpAg4K1O6oHruDoshdbiwNB3HHm5JLU7xCt+95A0XhttsHVRcWj/YFTkUCUVy Cde8i7SzUi42DhNFMWHD99uqkRqBPpnfxP1sF1ZFL2toiE4zOvEDV9bdap28eK2NAANp 3Fog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933497; x=1707538297; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nv8FTd4nIOkDpIrFZS5XqniknFq2wcwUf8nwWdOzVQw=; b=t41nmJlswWKxBJvDSYYbo37/1kNEtkFjjgy71iYW0iylOr+gJxbP9i9C4FflqnQf90 MSKRgltg+SXBu1udpozi+A3Pi+TcLmyiNse6Wg84Riqu5S6yQGjWlp7BpHlQ5mIez5Ht fHFwUT+PesQ7xmDldSC3J1l+OnJlKRnEkVMfBx6GfXYVmQ+mUsrr1JucrkAjUnsMStmw SGRet0jj+Egjbaqcgt/CixNs2FRDVW+4H+1K8VS32Vz9zYYQ3NFHkkYVulz+jqvxnOWO V6/TJpKwP21P8wF6kPSyLaSu8nOcfb7LccDDCnUEKhgBcAIVRGaDIGz9D3XTPW9Fit6i dhEA== X-Gm-Message-State: AOJu0YxtqPibO3K8CQaC4bVn2JgS/YmY8PTFfflhoEbc519ZhOEIMaRi aWxyV2e1sQcfPdCCEqoVHuQGphmVHTkPIfi6+lYe4tphJ/HKckT3ZYr6dT6VhscXw6xbAgv3xA/ FbaI= X-Google-Smtp-Source: AGHT+IG8F1jyuymDCPJhzhpe7/QFoUASkFHrf0eeRX5fHiquLhSpPycu0wRviMby3bezcSoz3Gnpbg== X-Received: by 2002:a05:6a20:d807:b0:19e:48e9:5052 with SMTP id iv7-20020a056a20d80700b0019e48e95052mr5212242pzb.22.1706933497396; Fri, 02 Feb 2024 20:11:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUqvtcZn2jCPjIs7RtiEnBPJGRzzRbXhhQeXB6VmglRiUeFiU1ObNDrBWzueHK9TWebglOnXjPXisH6LpmHItqGYAT1DaOS2987sc6r7IHaVgJ62GXi/A/LOUCugTqYDbSFh+QOu7O+OdNdp1gQbgLHD98tjIqdGlHW3IYfMBrJdWfc8CGwyyvwauU= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id lq13-20020a170903144d00b001d95d47cce4sm2354386plb.138.2024.02.02.20.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:11:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Shreyansh Jain , Nipun Gupta Subject: [PATCH v7 02/19] mempool/dpaa2: use driver logtype not PMD Date: Fri, 2 Feb 2024 20:10:07 -0800 Message-ID: <20240203041125.285232-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041125.285232-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041125.285232-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 84371d5d1abb..4c9245cb814c 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -293,7 +293,7 @@ rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp) bp_info = mempool_to_bpinfo(mp); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); + DPAA2_MEMPOOL_ERR("DPAA2 buffer pool not configured"); return -ENOMEM; } @@ -307,7 +307,7 @@ rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr) bp_info = mempool_to_bpinfo(mp); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); + DPAA2_MEMPOOL_ERR("DPAA2 buffer pool not configured"); return NULL; } From patchwork Sat Feb 3 04:10:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136355 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70D8C43A57; Sat, 3 Feb 2024 05:11:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 492F042DE8; Sat, 3 Feb 2024 05:11:41 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 08577402F1 for ; Sat, 3 Feb 2024 05:11:39 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d93b525959so24893405ad.0 for ; Fri, 02 Feb 2024 20:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933498; x=1707538298; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GTucNmFfel9Scf8V63ReMufh9ptwWoYEP/RBAwAFyUU=; b=CxfYk8ejTvLl608leT2Kp13ZAAmQJCMVi3B5VKNJYTLXKd7nqP6os34eu/gZkVmquq umcW0mcMW9wfaZeE+0xw2mveLJ7j0F2Br6/oDjuOBO2DkT0nydyuNSHxobf7fHywCiuu oOCvFdZxWI6j88yD/iD41u3HOuntbWJdr9Qzm8/4NbntlhhL6p/TmY0z9ZHB0Uv8HpmA H32qk6dbV3dtVriO23+l+CSAaU3J7ZVcNmMgZCcS1govx8TMM+QmP5sMv+2JDtzUpfo8 PKtun/LgofbohLRHz/MPvnDxbjI0/8dkg2mJNuzvYeQZq3drYCMiuP/QwOoyx6gFRfSx Ks1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933498; x=1707538298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GTucNmFfel9Scf8V63ReMufh9ptwWoYEP/RBAwAFyUU=; b=TWjVCrm7fvzTwwnG/TKl63eXH3jZdFMn5z++CthUvFHXVU/As29ARdcdmv6KK/KeAH FCRRD/pumJO2b+s4HPoyrMTyM3u3hOK6/ssRvO8rtBDmu7i2eeOLmoEdwhLIffaaDT7A ISI6RV7y6qSe5nq0nNlFW+R+5hE6RuHewSZTxYuZ3Oty8gQlPlXrFNmseV/CAeCRqxcV njrrM/nI/MihJmGLAFLaKFerJwDjV6/F7ciS1gpkOn7SgTJoASjxdWKVbkX4nPVFCj0a 85SZAXizs8jv/7wv5VyNNEC3Rddc00bDBfCKuhyTR1Q/TGwtkJSQSPL7/TVgvs92dcky 1ggw== X-Gm-Message-State: AOJu0YxItoPrjMjEaTPWaC5vVDIMc/XrbiWBHK5WDy83Z5LuZ+ZckMtL KrMm1KJia2K4+KF1zWESXWPxcfxB2bZuYUH9VVqe+k6FVFoLa3dFso2odSZrrbSls0alzKk10D1 Qy/Y= X-Google-Smtp-Source: AGHT+IE+kTodm6S5rOJZ0tuNVdh0akMngsOtdr9GmWrtmV/N4J564Cuk51aKUCv47rn90XIXYJxVEA== X-Received: by 2002:a17:90b:242:b0:296:1667:e879 with SMTP id fz2-20020a17090b024200b002961667e879mr759641pjb.23.1706933498280; Fri, 02 Feb 2024 20:11:38 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXoDC79BAfPlpNVa9xzLNCEihDta7nZ/Yjhe7/VSpTVO/RzuJ778OU0jQMNxOr9uLLIKeKkIi6eqdjS9PSOprvsmA3Id+EFa9D6q6GaE6NMqwhbLo1Q/UKmUMgiA8BG3yZV0TA30kEjAREBolNZy1PuYPpQIcRXXtsjmM3iPn/OnhuBPsUoYSzpmokz1PsBjFjzJwO6g4UIkQMg1dmsh2sb0oTHbhY= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id lq13-20020a170903144d00b001d95d47cce4sm2354386plb.138.2024.02.02.20.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:11:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Nipun Gupta , Ferruh Yigit , Aman Singh Subject: [PATCH v7 03/19] net/dpaa: use dedicated logtype not PMD Date: Fri, 2 Feb 2024 20:10:08 -0800 Message-ID: <20240203041125.285232-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041125.285232-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041125.285232-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver already has a logtype, but was not used in couple places. Fixes: 6b10d1f7bdea ("net/dpaa: update process specific device info") Fixes: c2c4f87b1259 ("net: add macro for MAC address print") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ef4c06db6a4d..bb2de5de801c 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -2096,8 +2096,8 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) /* copy the primary mac address */ rte_ether_addr_copy(&fman_intf->mac_addr, ð_dev->data->mac_addrs[0]); - RTE_LOG(INFO, PMD, "net: dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT "\n", - dpaa_device->name, RTE_ETHER_ADDR_BYTES(&fman_intf->mac_addr)); + DPAA_PMD_INFO("net: dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT, + dpaa_device->name, RTE_ETHER_ADDR_BYTES(&fman_intf->mac_addr)); if (!fman_intf->is_shared_mac) { /* Configure error packet handling */ @@ -2166,7 +2166,7 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, ret = dpaa_dev_init_secondary(eth_dev); if (ret != 0) { - RTE_LOG(ERR, PMD, "secondary dev init failed\n"); + DPAA_PMD_ERR("secondary dev init failed"); return ret; }