From patchwork Thu Dec 14 10:24:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 135190 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7D23436EE; Thu, 14 Dec 2023 11:24:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F119342FEB; Thu, 14 Dec 2023 11:24:52 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2128.outbound.protection.outlook.com [40.107.237.128]) by mails.dpdk.org (Postfix) with ESMTP id 57612402E6; Thu, 14 Dec 2023 11:24:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIg3+udWcpTr8VMmBlmN1wPadpApVKVxFI4fjbmBuEqrVgmvPqE8JsCYiPMBRIeeTkLOBO8pKZqE66F/0zJCMa1nDvmjW7ziKpPpt8QU7cz8hhOk2iXI5gsfaQ6sceXOM82M4hdFzmaQUQ8XZ8hYaSJz1bh0iALUcLgM49+aGLnVJOekhFvuXyJ0jaxlsfNiTaFWvgkRhCseX+b66sbEKuh85fKoIiSk+lQgI7nZRxVOZ/f7bnUzffwuJ+e40ZFlxrBfaPMjL66CT4/VrHi7FGmNk5byaW2npvlG65bo9CJx8cL81xt6hUl4ZNQRxCS8bTDPO1zXOY3l3JBce/EA5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GCBCJyidjBy0kT+SAgHprVwSalEeuB2kIniVGLMPyxg=; b=SytmrF1j2t5qlPVoQIa5DW6v9IWVqok2OpObuJG2UsWzA4n379XKO41md4il21Vjt8AAkxq7y36bCA2s69RYYtieq++CLPGpNjJRIWMD5z1sSIxRwBK17MQOewA6ZEMXdW8X9RKlMoLdc26KO2fM4JEbjQjWdw5AeFmqbH0JjSKdpDFz4y+AztAlStH0e4KQe0M9L4jwsJR5gcKEtgeESNSQ/bNsn/LfmtLI9H3i+llCc4JuTPv4HMocOiK4vok+9QbkIT7ow/69natoVyuU2EI6L+h2WRs3JNQsYRq8rsTVVgHySTo5EDZsTAFTVZtCI8flHAVIsTV5PgwKbxpjLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GCBCJyidjBy0kT+SAgHprVwSalEeuB2kIniVGLMPyxg=; b=Yxq4XjyWjTnhtrTzmMYNYNqD9Wb+uBCpjF1p0eHn5nFzVxIySB5s2lBWO9ybeJr9hN8YHmQJL+WfJWkBKk1qQcK15ZKqDsA7XpBmoiR25gdAeh1QK0s12ksc1AzLW92iHqj7dHVM/ttEkgFoI2F3hdS4aPxYIhh9wF0d0dd4JCM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW4PR13MB5460.namprd13.prod.outlook.com (2603:10b6:303:183::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 10:24:49 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 10:24:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , chaoyong.he@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH 1/3] net/nfp: fix close representor problem Date: Thu, 14 Dec 2023 18:24:29 +0800 Message-Id: <20231214102431.2091608-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231214102431.2091608-1-chaoyong.he@corigine.com> References: <20231214102431.2091608-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SJ0PR03CA0273.namprd03.prod.outlook.com (2603:10b6:a03:39e::8) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MW4PR13MB5460:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ebb79ea-582b-46ae-b0d7-08dbfc8ee70d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /TuIpcNdN+Ljec170UmBIB2DFbmbtTalkc3vQjPfcv6d2lBz2oaIQ5hP2N6eNj+jlv2t22G45W7XvkMSAVHbKQPk9yFrtrYRGTyMK/xZJ3tsPgR0N6uD6U9Y1cjSaAFmVIykIR39faNFgjXYosrb9F9+OWNe452jrzeHFVYDyDQCkZ2+13wxr2FNFZMmBtoT9QHvqxsvmOkSJKzJn2p7inylIw60vvsQIGAdBc1dVSYBT+3Y3p9x6o60Y3MQsJU6GYJVRa1EbepRoAHcTmrMqOfF0qK/JqzjV/jH/VrNs+HnlGIN4iY+py70Pd1+g5ZElXFajT+imu7GFxPR8hDjrXdwE2NZdukoPoJW4EzrrLu/vssKTeLVCOunSpk/CDboWyGOlz6EhnIBSfGJqSYSiVzVZpbC5tXroYFhBDOPesuCZeOyT0/08Klb6OGVPkwLqNcSR6rHkBfaEGqlpdTYsKMzMfl82/XNY0Ef464CNXx3xz2nQWz2aqZVsKwwSSb6kEGmrs4CgeZz21YLaKaBn2a2H+4qmal5Y7ouRUfmvSfYRlvN7YS5nis/T91t5JebUpAgjn6IbbVvTSKiuGMMsTUzVLU+WXvmTgnxfOjbPhn9ety0M1yxigv4H385vyxXJKo9zvwK8R4BmckDdbyIr+f+0goMxotaQYwJAHlLuiA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(376002)(366004)(396003)(346002)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(2616005)(1076003)(107886003)(6486002)(478600001)(86362001)(41300700001)(6506007)(6666004)(26005)(52116002)(6512007)(66556008)(66476007)(66946007)(83380400001)(54906003)(6916009)(316002)(38100700002)(450100002)(4326008)(8676002)(8936002)(5660300002)(2906002)(44832011)(38350700005)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hrgXrvP/i2ASx4+qARZ1PB+R4rOoKzjAd4A48BJk8UUBbKDAPFfwsL7vsG7oaQpOoqlHL9QbirtiqioA0nhhuukzmVwlqxjdPbKF1KrE8oXUGB/l6Bry2Z4pJzH1x6pyK+Mg9dX3LawWrL4EDyPj5lAHncOD1qOWcQPy59OtI/vcFOVzWU8xKhFtyVo7yLmm3moy2wJmDGR4jJfg1mR5jWS7YNYzUk2yKeb90EqpX6FW5zPGt/9+6qcl++K8YsXvMNjwFyqNHDHufscW7YC8f1qn9HPS5jMblAy+EYplshitLpSVeA409XqxxdrOyNtTMOog6Zxys1ydwbYoRnizXNIN0Fq08xIGDx7s7txTAIiZLlOlAc2quVF98XIMBcDHQJMO1AUpxsRe2Xo664JMidIXbfQgLxIRqHUUNxBvGrvwF3aMePiTNE6N7p3Wcg4cHR6W7zDcKMQ7y2vfxh8+yOo9nSnfBi7es+3/JKELom/faBxKXfyRBxAGBeBRWNzguNhR9+Is9NWwtHPRbRS2KC5l4wW3Ro5cBsAaXtjFTxtJetO8/YaKC3+DalnKNJIV8/aASfFcKAf6IpyqSRN61cqXYE5hPcUoXHxrlwBJfUoPSisrnjH9gZPbIV0gmPAijbNLaPacfgltAg0r0/h3K9YNQmN2oW63tFol9d1gNMXpMD0XgWGxveumjy+l8z+etSmWj0WY7c/Cxob4uv8yuj0qBf2rETc/fhB/QVylDHYY7SHlSLXBdZY1rzBCcpKjKaKsBB0UmFFb/xAmbPF0YYo8RW+JCbADftDHxzci5+WHN9pYFOqH7EOkgUjirn4OOgx7Z4C2g1epbXVoq+TWb43t7BoY2ttnYjdKzb/lyt9pRaVCPiipnHrqiFkbgvebepmwf96168lkHUvgL30mxQWODHdtDfdAWMMX5o4pkDisjO9arLMiAAvZw6ZY/8SPnukp5FjTDTe0b+emsableMSYe0h33KW7JoopUjJmthuIVU/xbEtZQKGQP8qBh5cfNfIu1lKy21wRvWDMMrA9mESf9iZIogPAicPo8hSNBgsh2c57epClrevEUPPu+2MXF0SW0WvQiON3cGX2u3RsI72HWdrVM7ZWhDYJNVm19ymqmHkT1QpHaP6TKV13Qlc/difV3pwfyQHda1NU/d5XcEDIS65IbsYW3MjHdGblI/6L8qc1K0pRdpZflSay32cgNPA8uxkXMDCXuEsmCoB8rALDOHSF2i9fXhN7nK9CKSdpLHidhp8qGu8WonCB98ZTl1bf1emZNjkz6qkRUr230TByOCNYwjcfIF2rnKUbTEcLohP/9amLjhCwPEHF1dHJPKfZGTyrjl+2B/xw+EFuCMXdJEmzLft00j6LUf/8sNt8SnXgWcsTmQKsYU0XqIeHvlrxIm9uVZVpZSXwrpaAmcZE/fP+fbk3DKh690b168t/sJ2fahI9g3oz8rxWOQTQhhC0QHPq/AfOB2tIw9+JdigBWvBKUPXvdwTO7HrPDo01bz4L/9ba42XwmJk5CBCVjsUvENwtuaiA1e3aLHRZOIDuVISs7OP8lSgyHCPyzDpCJpul7PuJCa3X/4QzjDyAUyua4yXMgSSqKK/fNgTwhQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ebb79ea-582b-46ae-b0d7-08dbfc8ee70d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 10:24:49.7715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tYpcCMTgi/mdWODKIDIf/0wuCbDi7UyXK7iaIKLEIqDv5WoK831z2fKtBzsRzVcPyRUw8eSBHfFJ8JSM+IAGhSPTPenB2qzypE27NLBWrdo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5460 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu Close interface use "rte_eth_dev_destroy()" to destroy representor. The "rte_eth_dev_destroy()" will call "rte_eth_dev_release_port()" but the "rte_eth_dev_close()" also calls "rte_eth_dev_release_port()". This will cause Segmentation fault. Remove the "rte_eth_dev_destroy()" in nfp representor close interface. Fixes: a135bc1644d6 ("net/nfp: fix resource leak for flower firmware") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_representor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 7d8c055b80..27ea3891bd 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -314,13 +314,13 @@ nfp_flower_repr_free(struct nfp_flower_representor *repr, { switch (repr_type) { case NFP_REPR_TYPE_PHYS_PORT: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit); + nfp_flower_repr_uninit(repr->eth_dev); break; case NFP_REPR_TYPE_PF: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_pf_repr_uninit); + nfp_flower_pf_repr_uninit(repr->eth_dev); break; case NFP_REPR_TYPE_VF: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit); + nfp_flower_repr_uninit(repr->eth_dev); break; default: PMD_DRV_LOG(ERR, "Unsupported repr port type."); From patchwork Thu Dec 14 10:24:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 135191 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5DD4436EE; Thu, 14 Dec 2023 11:25:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8163343036; Thu, 14 Dec 2023 11:24:55 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2126.outbound.protection.outlook.com [40.107.237.126]) by mails.dpdk.org (Postfix) with ESMTP id 3910F42FF3; Thu, 14 Dec 2023 11:24:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGT8IhSlyi06l16HTsqEWWJcLcaePj1q5c/uZgdtY4GsV686oPF0bTV00i5hqPvlSpOBoYFRmJcYhmdjx+wPA5lYqFDlD3YKB64GVQsebneBW2+RpexdDLL+FyGN/6QLDrTL1doUg6R109xjqKlw9C83u/CHs5Mbf3lDQvvGUGtsL4CDJsOaHHQgzb4oy7GA+1lHJBLd+OT/N9jApZZUQlCwrbedDTJ2KSnf1o93qfs4VjCTEcLEwt16fstTsTfcNJNzuXfAZslLBywwf2+eI7f35nldJaetLqJTx0p2bzFd25D93TohrHdDmt+kBHJ9tbv8R4gwngxBvOhnOmU3MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9v9nJC4U9iope8zCbMRuFO1Ks1FBK7rlk8nUM8P4zY8=; b=DUWi+5F5ymfacqFRjpZOA5xXbuBxLncIxCl3WHfjLWJVYDzZ3j14j1Kydnc0v9D+Ml6khgvo1F6gOQiO/FSFOVXknkNk6Kl385noCb3aPuqmh4IyRpO6Y+t1Zba52PcPyzMGyqt9uNS0UoCjvjPeNNOEok6obBqHwiA67N78GncoSDp6Z7YeIHZQ/EkCN8QZ7iPh1EPvHbNqjlAPzIck4XyajMPL7AGIfgkNu0NACnyqiS3dsEIF6T06+k74oFicwEKosPl6laYQNX+APqSIq8zX3GuTIj7NRQ61+nAi1gOFj5A96lGDtZe+Ebh/TqGMpWpQ+GmPbefBgRdp7XNL2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9v9nJC4U9iope8zCbMRuFO1Ks1FBK7rlk8nUM8P4zY8=; b=KtXqUFpTyWdvY7Cnxhr2dTFxuvob6q6/IP2UwrsYE0n6KI1RKyQfj01lFB9ilQBYXah+vnwuWKdt4SEGww4ghmRjIfR1EyhYhjzKZnUUdcK2AwlRuZIiRv3oj3E32x7iOlZxRTnu4jPbN6vQpXJqQDsfVkxowTdux64m4nei4QY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW4PR13MB5460.namprd13.prod.outlook.com (2603:10b6:303:183::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 10:24:51 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 10:24:51 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , chaoyong.he@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH 2/3] net/nfp: fix free resource problem Date: Thu, 14 Dec 2023 18:24:30 +0800 Message-Id: <20231214102431.2091608-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231214102431.2091608-1-chaoyong.he@corigine.com> References: <20231214102431.2091608-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SJ0PR03CA0273.namprd03.prod.outlook.com (2603:10b6:a03:39e::8) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MW4PR13MB5460:EE_ X-MS-Office365-Filtering-Correlation-Id: e13aac0d-5e08-4283-b873-08dbfc8ee818 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wt4RCrdsQfvTb8V/zPDHs86r16yz+Es5UfDah917ybbvZQaK2nPgJghRnRuqJXfWRmS7+yMmhhHmI+45M/YLVvj4cTn6VrKwomzNa6+mRizZPy/1PgpCemhA3Ti3Ilm98VwzSN2+kS9snaPp7IcU6MFEW9VLHiwbKH/RHDCfwVLFOW33UllLfkBzXOZ1mEAEu6hGmwokq9z3qRgovnGLsHvo/J1EORWA6LCjMqzruMjJZDKjKccQio1ujUHoBYsZ1y9rUNF16r59r3987nDq71lJzaptuBzBrgFkHfoxlxTjossPOYAkZ+T6JVfLudDQQlELoBufR8au7SxRLJoOQMDalSMGbaTjps1ldNaQ5ODpxqwvnO2Jkp0K7svoGeSbItpr86nLmJajkcT91YPzSU/LCTM1QJoKmcQbWacjX+xnFgCcThEDsPyPcHkdQEp/MhTzOZ5c3RNxOT7YW4VNJgnf4Y8GIu7CAlXfq8yXHlrnGRm7RDZ5YqT5j7D5xPd9I2hB2x+ZoxCBWiGWZcMijalJCUGHrAqeSqtLhREnDfmgvVgOi9fnklttscmdEH4lvIKaASrECFKasor1H42SQwLCTU2uc2YClvCtcWy1H131G6JnNy7LYHJv3YxXWQPKIkJPTBTSLFHY5/ev0QOH9jWkMFe+Wvra+JfhS1IKP8U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(376002)(366004)(396003)(346002)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(2616005)(1076003)(107886003)(6486002)(478600001)(86362001)(41300700001)(6506007)(6666004)(26005)(52116002)(6512007)(66556008)(66476007)(66946007)(83380400001)(54906003)(6916009)(316002)(38100700002)(450100002)(4326008)(8676002)(8936002)(5660300002)(2906002)(44832011)(38350700005)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2ErAGYkSPtm4DvEG8Eha+SIH4P5z1ggb/A3EOW96+0Aut4U44nhxZ4RiBoJURIekfadT51oCfvwqoyjmTy4eWKiq7t+0m9hpI8QhfvYZM2ANA2oMktOIWTGETEgpeO26QCEARCqshjUuSKW2d8pVMLYYwLo2UhMXmpwGHVslk2w22BiQxN9Z3jm4GumitvfBFh6LoxsF49h8rfY6jXU8Y0e8D2Fi1u9VG4Oku3zugI8r9g6/LryXhTuUyhFlBnWwqWHHsU5d1yhCpRVDvoN31nlNV1wrVt7IIF/JaERUjp6jbfNAytkXEvJsdvD6KcIgAjHhvePffritC0DtUvlQohIVzfRE29N6Xa2zKD1wKzQFrs8UlB6gzRhPPDtkab2CTx3S6VJGyabxFoXXBZym0B64Np/aasRqPWb6XnJw4TLMFdEWjPhRt4njdWLYJ9//41gc6cW6syaTKcSJ4M8pRISfsyEBtvLOXhMWKvXCRuo0UOEYQE+iysPY+3lL4oEaquQq31MFQWex7iauH2+8TYojkBPBLAiIJCFJZv5PSQEMOPv1XpC5TFZan46p+iHAfNilq3vfoEt2sbZSX7GwPD3/xGU6LLibOuo2sQdPULNzHVjraeyZBSwN57MSSbe2+VzAjpEeHfJsyH52JGUV9QJ7L2STnyc04ZvVhjNrxJnskLHDDMFEwmzh92dplUz87RIDLqhD/j2cTzYEEtriOBDEtoUEUVQWJyvPeNpVMlGHnzVGV0/+RJzoy3wjq8DwiDBqVrD1MG9pRcmrUXQTtLkwHcPsBx7hkiePV+xzzwSOzRjgcxR6xhz96l1JcRXONadUiSenYiNCSKECl+X9z+SjMmNL9EniVZWBOMLF5m1pGQkASIcj+MHMyx2vcpPQKM3DBrV1hJrVzDHoAQFcEsD2LtxUKI14DAUvmf7zWjP4ahQUZgHHed/oRh72Cnr4iF/Wu/5ILwYys679fUcUimFGtZK2a9Q0v9pE06ZGhpBTlv9If3vxXBumzbBbRNiTkN7XwSnLEU0fZ5WIvmz2MdiT5Vaf5H+zi1JnlKug33NJO4MW+Vl5VcDAu74hekIJsOsn3+hZ2chkBGnDr6akaQtuamB+/EUggA3t6IRDoceBsQ4VzDbxFf+W3UIfX0tqM5kHlnG3MZISl66OM59KXUS3yQxtCYQG4LjQpS7BYMOyD+N0kJ0jYGEzXu8r2eLt+3k6E4lfQmcKiREHe6r/qST5LgUU/Nlj/6+DQPzgWZRNRcs4buP8MCgFkPAI7lLMVaU0czU5zzTDQagMh1RqfAGffYaE5r7/ikcbvl3B0ASN3d/0KA2QXGKg2VZkraPZyXz/xXUfgJFEulGhgiaEsKnD/0uStFJ1Qu6AsfunfH4/RtFDD+kIxqzt3gMNjz9h/AByXaiAWCtZQ3553QotDyezd9ujBT+AtSpR2/wLTSV+LwbIcJzbMGdsUAcQyaaBnImGmlHLVS4snBClTFoPhMwqRDI+AjtOaN7VEOAaaqV0H159Rp+/Zy66oFWBqehjof/Ra2FuPQ8riCBEPixq7FD7QtmbLArrY7AvJgIaj8+BwcUFej6XiyqNNoSQAwKl0Z4qgjD1Mzjuz3oZmXKZgQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: e13aac0d-5e08-4283-b873-08dbfc8ee818 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 10:24:51.5101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AElUnp3ZCFBpo83LlDtPMY8jD/c+CbhAqTKrJPgkK6asWmxecM4LrhpKUOenTmDrRyrEwH9CN9EcHU9l1H3eThx50eIP3NuW/hM4nOr7psU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5460 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu Set the representor array to NULL to avoid that close interface does not free some resource. Fixes: a135bc1644d6 ("net/nfp: fix resource leak for flower firmware") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_representor.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 27ea3891bd..5f7c1fa737 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -294,17 +294,30 @@ nfp_flower_repr_tx_burst(void *tx_queue, static int nfp_flower_repr_uninit(struct rte_eth_dev *eth_dev) { + uint16_t index; struct nfp_flower_representor *repr; repr = eth_dev->data->dev_private; rte_ring_free(repr->ring); + if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) { + index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr->port_id); + repr->app_fw_flower->phy_reprs[index] = NULL; + } else { + index = repr->vf_id; + repr->app_fw_flower->vf_reprs[index] = NULL; + } + return 0; } static int -nfp_flower_pf_repr_uninit(__rte_unused struct rte_eth_dev *eth_dev) +nfp_flower_pf_repr_uninit(struct rte_eth_dev *eth_dev) { + struct nfp_flower_representor *repr = eth_dev->data->dev_private; + + repr->app_fw_flower->pf_repr = NULL; + return 0; } From patchwork Thu Dec 14 10:24:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 135192 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A21E436EE; Thu, 14 Dec 2023 11:25:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B77F043245; Thu, 14 Dec 2023 11:24:56 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2094.outbound.protection.outlook.com [40.107.237.94]) by mails.dpdk.org (Postfix) with ESMTP id 30FE342FCB; Thu, 14 Dec 2023 11:24:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hzWEJjimyUrjdIIJGpEgnrKlGroQEcU5oUPZ0xy1ZO/udrttVZmXM+L5uXyc199qLiuaSVSnAYEL/3DspTIECvoxC+QAMp8tpsKr/EQUCb0Smx+ronsN/dVmWy2Lpwu9zrfwa0aqAz3LUFl5H+bd3gDbvsW3qbQlKVjzuxtIsgSxT3mrlneCCLKxaIpf155njFIsLReA4wvpRKnk4w0FqQ4lV7MMlBa/mOGgzU5bdEv9G39U6rKnNOXeXmd4RmoupJSKHUGWMmq+djGyQBGf99vJPGcv+cHeQ2GrfBzAifmvExAoAaxU8dmCQo+gN9c7sNqjSOGOBzNxY+XfGf39ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yRnMfZ/1MhatZqgbZj8V2+Pg8IEVY54xqkIDvkIwmnI=; b=MAeX69R3m2wQHWYXxWsmKz6Jtm9BYOaUmzbtyJyoULCH+gRqqD9ruSJb991Ay8ChEr667OvHEB2H3xyqDIZKH8cm4QjzmHZBrvPoSf8Is1urgwR/nI31VlcJ8iBXSSXBK5+eY5vZ7XiuZY/K0eczcurLzcG8swG28Q+7KCmTeaAIZKnlMPWlKzZWXBl950XXCeoJU7/YbcPpTxh8jDk9xJ1caCzfKOjbLdbvYSQUL1vpQjxm6DepR5/cDtRkO/ms90U+58J/ykAB4CfX6nr4oeXcTJjn8/TjxvSSmn4XSVkfp8pwKmfCuUCIUIbylt4YyNfIDYSuJsPpfOu3h64Ztw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRnMfZ/1MhatZqgbZj8V2+Pg8IEVY54xqkIDvkIwmnI=; b=XcXOn502q2MjMnr9BZUQ30yWaLNDmlr9KCgz66yQ3PifNBQXFvOkXaKbcsCavwYUzwbQbrpkwqATO4W8V87O8eGAVjtDhNZm1k4tvATntXHFo0uisksHnnseetW+lSn/KFuad0oSRg3ugribE1b0ct1/rZybidqHDuAypVgj+zs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW4PR13MB5460.namprd13.prod.outlook.com (2603:10b6:303:183::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 10:24:53 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 10:24:53 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , chaoyong.he@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH 3/3] net/nfp: free domain ID in close interface Date: Thu, 14 Dec 2023 18:24:31 +0800 Message-Id: <20231214102431.2091608-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231214102431.2091608-1-chaoyong.he@corigine.com> References: <20231214102431.2091608-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SJ0PR03CA0273.namprd03.prod.outlook.com (2603:10b6:a03:39e::8) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MW4PR13MB5460:EE_ X-MS-Office365-Filtering-Correlation-Id: 025ede89-2c08-48d4-abda-08dbfc8ee92f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zmA91WMvGnlYXoiDta+11NoysuV5bOwYLsrWoIUEu6DfOZJcu4qZQ0AEfg98j8WPoLSVXstzrYc9FXv0GwXKD8pajSA67nRa11dfdORromyScsjiPV9T2jePmetMNPkRKTZ116qxbqGDwN7Yu/3diS0iIsa/VIkrTx8S1i+LeQ/ujSiiQXbSUOgGsRqXRnYYh7UgbmntiHtGPM0iirnTSwNQmUGju4wVrg0v60MhIcRRiSWj5ozQS2AQOGuXvgbt+zoVJJ9d6D5cup32PtbMzeLeh6wRqEM8xtFh+ImKGPqDmHk7dPS6Ui9Y1bozMDpa6IPfOmk0YMIajlFW2fUEhZxzVeZcWx0uHQZ5tSXs0b22YYeoWTHQqRdURC6h01ZQCCKQJJ+6eDBY6rgFWIDRXV6kW74KWLYc6RLrcskbkpb+SOyMNg8q/4OT3utDRn6bP+AvWgYTyZmaJzQK/JFofu663Uvf8Y5IS4kaWc9lL9WFcg34S6kWtFshXa6ZfprxAKWiu/2FJr/9FlTzmTTtcPlpwtRydxktUL8AXG/NNmWoMZdbD8GpC6C4flxPdFyWzzqzfiBZLOOHB6rC4Ap6igJ5fNovnVfOucxjPozFNzdQ/dcJ8JshtiCsadJZT3ztaMCj1RUFePLHhViwQKZ8uS67VujxMiQTKFPcMHYePZ0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(376002)(366004)(396003)(346002)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(2616005)(1076003)(107886003)(6486002)(478600001)(86362001)(41300700001)(6506007)(6666004)(26005)(52116002)(6512007)(66556008)(66476007)(66946007)(83380400001)(54906003)(6916009)(316002)(38100700002)(450100002)(4326008)(8676002)(8936002)(5660300002)(4744005)(2906002)(44832011)(38350700005)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g3lws3XvHV/6xNyIQQ4BIMQn+Q4A7SNW9IsYDlxkZZveVfjNDspXmEwZ8iF6fWdkmGIVp2tQ8Owc4+k84OnG9nv63QNKvy+stZZCtdhUgYO8wHDbo1DPhcWIPv0KBuIOl0TU++jDzKwI2JKxeFcwnw613+uL6t9t+5+jHLA5KdAnxI3c7wjaVIzBw+qRirkTs4gL6WBv3/N42Z0cLthUzTGINMvhaJGMUQgSinMZFXkhrzq2BV14f2Lwwzos2LXc7i7GFh5mhYeVdJ7/JG9FapIZlX2BR/nKUN/z77uJ7JKMjKT5+vIPd03bK7j1kTOLqIYArlDbKBGLLmJI8djKO77awTfsAUj2g5oVOPnKGj70RyK6hJ6O7hXRk5oR42rAeBn2130ZYscX85TDf7Xh/kE53pdvSHCKTKmXNgxHLx7UoIbHHHSCdkUy1w1yXRW3QnJOzR5usDJXqBGBQCRmUBLBYdDLiA3aXCCS3RMlglD8RgIJX73rNmlw5ZmH0KHdFUxHK+It7P866ciwirGu2njdYotcMP4/a2F1pcB8IYCU4Qffx57qba1rYq6IYhIDqUmWMij+iHUbFtkH+WP3lCG0+SqaY+KYtgpD9iA63aaI4Bi80xIEJdzYwhNg0c+sVMuXVESYAC/EFeDHAc5GTFVlDEFkXdW6w7s2/5kU/JBS0v3n0j73NptiDS7dKJQuuyBG2vidkcuoZlIvS7ioLkHgf5eq3C8LmwMIrhtUxy6KKeNy+EYerTxDj9ET03Hd2fZK7HOGNlr/ch35XIWeH4hmpfMf/fswud4voBvxP/txg+WbH+35N6rNQUZZOfPc+gEl56YfLzQtQG1eOBH5hWZfLi7sCO2glyu7S7fUpF513cyg11gMoqdLTMWMrmeaKgLJQx0pM0GdTXYO3Cxw1M2HkmVMXzCtRCo3PEJdqPYGdlEnU6yVfGnVeLbV46ldsXEspuGelB6O4Eqoq1mZwLmn+k5R5yu2/azfwnDZaBOq7jGBISmYIjrGYHNcSII9nocOjfOFyPppN4EaJuof8m5ZsSQojzTgOZlAXb2fGQ84d/DvV8vk1RTGpM2bkfHLWYcf7cWkNl38uQhpFLYh5ZTDtR4npr+UX9cIEENznU8Z/qcQlZJp/r1hm93v/dS8vWobkZYBVoHcd680zZms8Dq6ObO+CgOslrMCBSIf8jAP87hlmSlyVHut89l41hBOD4dNkbXLkj6lNIifpfVkAMMwWWpABUge24S0anPFGyaLStDQnUq0aoZoZB2EuLGtjgfrxD/aasOs9sLMiPNKkq7L0gA8YRqo3u3AyPqOZdSTstVdmDE3AVwYETFNQ1H3DlPqxo+B1ny+o230sY07+C3KkDJtQJ+i6iiVFWO6mdf9GDx9c8KZU7lNvOjTCgEDrAJpAt1iBdBd1FYUHKhPUnMHZ7cSNX2yahxBkum1fPivhmH8qjeRmTGBVWOBXzYH+sqBtXX+Gy5IGFsUUgFYXNs95UNCDhVtXjE3s+g/sZRUdsJjuqbvL5LgNp8epEDX3ZtDL9DIC+hzYwpjn+vrvnQRHdF2e8hgkhhcLzjkJspb/6QHSU0tMOW4Xv/220i0d7TJBtNjDHyTcEthD/Qt6A== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 025ede89-2c08-48d4-abda-08dbfc8ee92f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 10:24:53.3300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +PS5t5rCdoUnvdvwtA7/ZrVWCPt/ZmK9SJ/HFoY4aRA0ANZlhZvRNccUy8c1kd+PDLV0FvhnZ6PwSdrTHz0bmOXC4vGdWKZRNXw3vMGUwTQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5460 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu Free domain id in close interface. Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c index 94b50611f0..88a1b061e1 100644 --- a/drivers/net/nfp/flower/nfp_flower.c +++ b/drivers/net/nfp/flower/nfp_flower.c @@ -814,6 +814,7 @@ nfp_uninit_app_fw_flower(struct nfp_pf_dev *pf_dev) rte_free(app_fw_flower->pf_hw); nfp_mtr_priv_uninit(pf_dev); nfp_flow_priv_uninit(pf_dev); + rte_eth_switch_domain_free(app_fw_flower->switch_domain_id); rte_free(app_fw_flower); }