From patchwork Wed Dec 13 16:35:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135136 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34E35436E3; Wed, 13 Dec 2023 17:38:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD61140698; Wed, 13 Dec 2023 17:38:34 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 0BBB34021D for ; Wed, 13 Dec 2023 17:38:33 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d351848c9fso2955185ad.0 for ; Wed, 13 Dec 2023 08:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485512; x=1703090312; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qh7w7JyMBWxmjAOGCO3J9F0Cj0B6Z0Hk17f2ja+E1lU=; b=Gg/lnIsaJatEDuYh02BN57+HjIpUK2h9rQp4Y17YlwE+9fosjaD0vPILu54D+YU60S Qfb8gG9Rrz/PrhHBf2TOqBVCUB5ItQXhNdok6DQETvj8Acag2SOhH5/H5GCB7CVqrUvw TGNU4IFy0W2U78fH28dVKbHLNU5sI26WfB2BKFsNNUwGZ35cTmYCYcQAvywzSyN3Ng+J JxbScYWWx0aRNi/oDzzCHJh7maZVu2nKuZq827NVXNU8RnI9LhAf1L4qwbrR9oNo6sJP OOn9k1j2nK3WE//saUDZCz3+SUN9IuRanEdNGGEZ6ohWg7+GhTlx4SaxTiej1RI5gkOF /U3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485512; x=1703090312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qh7w7JyMBWxmjAOGCO3J9F0Cj0B6Z0Hk17f2ja+E1lU=; b=Kg6im3eP1CNZ5N91C+GyewmalVaP1fW6vaREOa8r5mcdCEzT/+3UWmDm3124LkS+RP +LyvkXnbeKvkXPhrG/hVc9Na57VBZxvMG4NnNlrJkgDGfrRHC8vF1xZX4gkT5kWL7dqQ Eo6XfVQcIOT/0NQF3GpRmCOT3IeD8FHvsROeDSkwR0xqQyrKp/R+q7MFDKDCT3Eg+QJh WlMxp3W8bPLEA77aSmduyIPoolJeDKZWfqzvlbQsmdEuQZWz2nG8noyDlepDXeZNn1UH AMIpQ3DACPGj73T1uFkxrQE+7grTBjJWBguvTN8eR9WocOMBlwG2nPzZgcUVPkFe4dwG yg1w== X-Gm-Message-State: AOJu0YyEGbKb8Adx+Cj0U9JN0df2UXQ6rqZWqnh4vUodAGd5oLMYGsQy PYNHmgZ0vEPj1QfdY5yB+gIdB4bGtMuLrkreyMQ= X-Google-Smtp-Source: AGHT+IE6jD/t6inmTadUMIhjwoqQ8FOKNuY6Iyy1ICsy+2vYM+2qLn9DErgrr79RbKVlSnRfW4U3AA== X-Received: by 2002:a17:902:988e:b0:1d0:6ffd:836a with SMTP id s14-20020a170902988e00b001d06ffd836amr3266779plp.117.1702485512291; Wed, 13 Dec 2023 08:38:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz Subject: [PATCH v3 01/37] log: fix doc comment for RTE_LOG_DP() Date: Wed, 13 Dec 2023 08:35:35 -0800 Message-ID: <20231213163820.894987-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The macro does not return a numeric status, only void. Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time") Signed-off-by: Stephen Hemminger --- lib/log/rte_log.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h index 4d207b8da2cd..bbbb051c20e2 100644 --- a/lib/log/rte_log.h +++ b/lib/log/rte_log.h @@ -348,9 +348,6 @@ int rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap) * @param ... * The fmt string, as in printf(3), followed by the variable arguments * required by the format. - * @return - * - 0: Success. - * - Negative on error. */ #define RTE_LOG_DP(l, t, ...) \ (void)((RTE_LOG_ ## l <= RTE_LOG_DP_LEVEL) ? \ From patchwork Wed Dec 13 16:35:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135137 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 745F1436E3; Wed, 13 Dec 2023 17:38:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2ED640DC9; Wed, 13 Dec 2023 17:38:35 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id B2EB94021D for ; Wed, 13 Dec 2023 17:38:33 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d347b4d676so13508815ad.2 for ; Wed, 13 Dec 2023 08:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485513; x=1703090313; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IJYE7atiLluhYup6T/i2BqkSgYaYiS9xlAetOnk0lBM=; b=SdMSAUNtswu7bc03vNYgF/Hnd2zSlh8fYqaeklzCpT0hc74vy3P6lV5GhW1Lr9Y2pr oRLga1HVKzb5Ue1/XNTzn3sFU48XDsd7CCotNcfYZHWSIhMburxtSj8CQWku35tH/HaD Wt/puZmjBzbrJ9tl1fAn2A0hZ3CfR+o7+9P7MSHfuFbjHgapjHynvqudkRCVWN6YqAzL /HxnmVqtLBZbYHfGdRR6FWQFrnjlOV0rQS47VWiJuzzM+SDQhWFPwhSbmtcUlx/uuNIp 6bp+p2Cxp+C3uzQ4osT5ii/11bbV0f8ES7DlRyoEHYUJU4CJ1+am0XLJaQ/sX4eVOuXr +RQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485513; x=1703090313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IJYE7atiLluhYup6T/i2BqkSgYaYiS9xlAetOnk0lBM=; b=cl5b3tPzsxEE+OamnabbpglMrNaxevBKMz9t7VE2No7GKPtiOhJuoPuIHKXdopN9s6 NBqFXzhypDB6w7nlI5osqOkiGBxPJZYg8j3nJ7KE0vB3qWGzcQKTdI6NR5NHZPCGUM+e GGx+DS+d36VZFSe6yLXR0506VpjK61Tr7SprVQMFmjqg43mVlTaNdaKqpGwKlNgcWmXF dNj8FE2AORgnkkc9aJnM2J9f27IPEPhClJFl2K/uDV8Wwhl9C77V8vTadAhyXe8h2Eqh mRXUIX6rTeGMqHZjp2F+1Ta4RWwdtHoFMAaAO/RN04jh7WvwItUqkgwCwT3UyksRCvo3 r7mA== X-Gm-Message-State: AOJu0YxVaDEuBQxCBagRtkRIOahUt8it92xpIUtenz3rVV95HzX9ZOUn LvtznXHBpaWWIwAdhf6u3LCDq3nzmQab0jFt9UQ= X-Google-Smtp-Source: AGHT+IE7GgoEdOR/TAREEDv4mh4JBOX+q9IvuTtHKSgfOJgytrovSzj7saFxU/Gfhk4ZmvNgm6/3sg== X-Received: by 2002:a17:902:7ec1:b0:1d0:7d0b:555c with SMTP id p1-20020a1709027ec100b001d07d0b555cmr7071792plb.10.1702485512965; Wed, 13 Dec 2023 08:38:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v3 02/37] log: add rte_log_dp() Date: Wed, 13 Dec 2023 08:35:36 -0800 Message-ID: <20231213163820.894987-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add a new macro for logging in datapath using a logtype. The existing macro RTE_LOG_DP() takes log type suffix (i.e. PMD) like RTE_LOG(). This macro allows using a dynamic type. Ideally, rte_log_dp() could be an always_inline function but GCC and Clang will not inline a function with variable number of arguments. Therefore it has to be a macro. Signed-off-by: Stephen Hemminger --- lib/log/rte_log.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h index bbbb051c20e2..4f69c05db91d 100644 --- a/lib/log/rte_log.h +++ b/lib/log/rte_log.h @@ -355,6 +355,27 @@ int rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap) RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) : \ 0) +/** + * Generates a log message for data path. + * + * Similar to rte_log(), except that it gets optimized away + * if the RTE_LOG_DP_LEVEL configuration option is lower than the log + * level argument. + * + * @param l + * Log level. A value between RTE_LOG_EMERG (1) and RTE_LOG_DEBUG (8). + * @param t + * The log type, for example, RTE_LOGTYPE_EAL. + * @param ... + * The format string, as in printf(3), followed by the variable arguments + * required by the format. + */ +#define rte_log_dp(l, t, ...) \ + do { \ + if ((l) <= RTE_LOG_DP_LEVEL) \ + rte_log(l, t, __VA_ARGS__); \ + } while (0) + #define RTE_LOG_REGISTER_IMPL(type, name, level) \ int type; \ RTE_INIT(__##type) \ From patchwork Wed Dec 13 16:35:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135138 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9474436E3; Wed, 13 Dec 2023 17:38:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E7AC40E25; Wed, 13 Dec 2023 17:38:37 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 89223402EC for ; Wed, 13 Dec 2023 17:38:34 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d075392ff6so56521765ad.1 for ; Wed, 13 Dec 2023 08:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485514; x=1703090314; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4MZYhyN/pIOSVy12e6edY9kwPy5Go/pM5wBt5I4Zz8I=; b=KJSyKXHDJ75pw2cFFS6EyU8d9+Xk6SllVa28+SbIhkzGMp/k67iavJ4wPeKTRdLNgq hy+5J75HjuhRI5gCcYQLTsh66VrRAR3wb6fMzcwt+GcpYL6LU/W3WUKyTWXi9tzF9srW jSjJb48WDlRSTfUDQGooFaXvAKRmfaVnhmOQVm/Lqaln24TYHYU/E/xcxnK6CP6ZCof7 uzLfg8h1NwE2Lw0MaZGOzpuqT6pYBYq6lG+JhiKDJa6nHuO1XjheIVQBCGJoFdRSeAf6 5ll3pm1qlkVORWwQf6+M2wWbYxGzRWhNxnmhbjTZs5ZS9s/DEWzmh9FHjhUz3Sw4e49X 6BoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485514; x=1703090314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4MZYhyN/pIOSVy12e6edY9kwPy5Go/pM5wBt5I4Zz8I=; b=oV2MyGK7HrIc8V5pOXngVnngZLi/PFy1ssnZHtYvD7B0niAbxhBSsfr6vffocrFRxi X838AmRJrQlpfmVhmELsjlM82I2bA6YlUBXv+tVT9zTseVXQbm/iBZmC9olzbCIaaqe/ qdUMITlb5QJC9qZ+o2ZQH5YB8ilgRBNsyqAepcvz8BT16tyStkbrNH8mgIifLckm3Cv2 utomU53IOEatlL94y53csssTxF7a1IqUo3Fb5RIwv18UW28wbTYMbfhlJQIRZ/UL4TNv TU9EKbaxhk8CfIB7hWSXzkdOUwLqlaOTupW1729QFt/JkNKruwGWZ2rFMLOJyWmV3LaH WQlw== X-Gm-Message-State: AOJu0YwqPiEM+SIkDEasOch2g6GPElOfuF1cp6A1G2YQXNkJCK1mj54f 2zonXidh5WRNsvI0BRf7A1YXs56Dq2aCUNbjJeY= X-Google-Smtp-Source: AGHT+IEql4A4UEUNiwY7SsMwf/ByrUCzBUCzoxpfeThbqdjytxxOcLOMekYkQf7VZCUJOZuI//hIew== X-Received: by 2002:a17:902:db09:b0:1d3:3f3c:c237 with SMTP id m9-20020a170902db0900b001d33f3cc237mr3514899plx.32.1702485513750; Wed, 13 Dec 2023 08:38:33 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Igor Russkikh Subject: [PATCH v3 03/37] net/atlantic: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:37 -0800 Message-ID: <20231213163820.894987-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/atlantic/atl_logs.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h index e3dba334fe92..c2a3a6320c58 100644 --- a/drivers/net/atlantic/atl_logs.h +++ b/drivers/net/atlantic/atl_logs.h @@ -14,18 +14,19 @@ extern int atl_logtype_init; #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") -#define PMD_RX_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, "%s(): " fmt "\n", __func__, ## args) - -#define PMD_TX_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, "%s(): " fmt "\n", __func__, ## args) - extern int atl_logtype_driver; #define PMD_DRV_LOG_RAW(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, atl_logtype_driver, "%s(): " fmt, \ __func__, ## args) #define PMD_DRV_LOG(level, fmt, args...) \ - PMD_DRV_LOG_RAW(level, fmt "\n", ## args) + rte_log_dp(RTE_LOG_ ## level, atl_logtype_driver, fmt "\n", \ + ## args) + +#define PMD_RX_LOG(level, fmt, args...) \ + PMD_DRV_LOG(level, fmt, ## args) + +#define PMD_TX_LOG(level, fmt, args...) \ + PMD_DRV_LOG(level, fmt, ## args) #endif From patchwork Wed Dec 13 16:35:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135139 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 953B1436E3; Wed, 13 Dec 2023 17:39:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2373F42E9D; Wed, 13 Dec 2023 17:38:38 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id A161840E03 for ; Wed, 13 Dec 2023 17:38:36 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d0aaa979f0so41819425ad.0 for ; Wed, 13 Dec 2023 08:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485516; x=1703090316; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZJaRP3fCp+tUoUY+2uYtQzC9iRlKr6Usvyn8+6OKraI=; b=nkWUV9uiTXvOd9LnDOePMwSHxYj+mOSFfO39kOyJ8e6sXbknmPPvZcoW5CICzHZK9b CIAww88RMllcGItrOjescuLWjbN39fggiSJi6YM7A2bxhMT8BB9R+eOUW8Ed6/7pjIz9 5EgUafgO6fquwDl6ewCp6OE7CB+6tQLy2g962hO4V7CjX6dWTGrVCw/ikIWLanJolUR2 LJbdmkI/tGS0HHViO5RAieBc0zJ+jShaB6N4cGDh+fDEFMsFxQP97HOfrhEfzjVRIEC9 6TT5pFApprwN46MiRNiDuF80omUrV4g1mOeq70QpbtrsAGAdwHqsX7dAUlBgfcL3d9EI eatQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485516; x=1703090316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZJaRP3fCp+tUoUY+2uYtQzC9iRlKr6Usvyn8+6OKraI=; b=UEnWKbIFi7jEkAvKy7HfEKAGkTE4eYLzqnHjxLOWSAC8Ea8wbGdxYA28mTEPfaSKRE Tx1F4OmPBjq/xcXMIoRytr3Cxaf4xs6Nk2Rb6XXBGmnPGkjSeJqUg0N+xIWCdM8JsDo2 RtyK561WQJDd/bwn082a2mT7Tcma05rfNezbvLpe84qwE3xb5u3Na0iHY2aeQ2uchruh kgtoXfR/hZlUJFM007YLSzgkJATckD19SqFeDyQylTHLYzYGlgGVWFJ3zZiryALrv9Vw 3dKmENMgADX+wvO9LnEVxxbgsZnz4sAMHNlWr8LguOoS1qfNa+VqJi0ilEm3uymU79eQ SMEA== X-Gm-Message-State: AOJu0YwSJdztmxS9vcqIU9iuRmnOAVPCTzDCv5qh5+ERk0g1jWkceZjO wFfVS5RZCia35ee6QKDTlACkEQfKYb1Io8xKMoM= X-Google-Smtp-Source: AGHT+IG1KnaXDUE1FDEFa7P779FYwJ3d4uZe1fFGXntHPERwS+/2WHo4NxEvTIuKBAem5nQJTcxItQ== X-Received: by 2002:a17:902:e543:b0:1d0:6ffd:adfe with SMTP id n3-20020a170902e54300b001d06ffdadfemr4810632plf.101.1702485515765; Wed, 13 Dec 2023 08:38:35 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Steven Webster , Matt Peters Subject: [PATCH v3 04/37] net/avp: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:38 -0800 Message-ID: <20231213163820.894987-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_logs.h | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h index 6e297c7a4a81..0ae95a7685c5 100644 --- a/drivers/net/avp/avp_logs.h +++ b/drivers/net/avp/avp_logs.h @@ -7,24 +7,26 @@ #include + +extern int avp_logtype_driver; + +#define PMD_DRV_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, avp_logtype_driver, \ + "%s(): " fmt, __func__, ## args) + #ifdef RTE_LIBRTE_AVP_DEBUG_RX #define PMD_RX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s() rx: " fmt, __func__, ## args) + rte_log(RTE_LOG_ ## level, avp_logtype_driver, \ + "%s() rx: " fmt, __func__, ## args) #else #define PMD_RX_LOG(level, fmt, args...) do { } while (0) #endif #ifdef RTE_LIBRTE_AVP_DEBUG_TX #define PMD_TX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s() tx: " fmt, __func__, ## args) + rte_log(RTE_LOG_ ## level, avp_logtype_driver, \ + "%s() tx: " fmt, __func__, ## args) #else #define PMD_TX_LOG(level, fmt, args...) do { } while (0) #endif - -extern int avp_logtype_driver; - -#define PMD_DRV_LOG(level, fmt, args...) \ - rte_log(RTE_LOG_ ## level, avp_logtype_driver, \ - "%s(): " fmt, __func__, ## args) - #endif /* _AVP_LOGS_H_ */ From patchwork Wed Dec 13 16:35:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135140 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B8F6436E3; Wed, 13 Dec 2023 17:39:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 347B042EFF; Wed, 13 Dec 2023 17:38:39 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 63CD640E7C for ; Wed, 13 Dec 2023 17:38:37 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5c664652339so4023707a12.1 for ; Wed, 13 Dec 2023 08:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485516; x=1703090316; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yYBnLMQSIKwMPIS9f0brTmRTm8/hcJUIZ3wWUMpYIR8=; b=1HuSSx2lWFVVE3kgHxcho8VUVUBWz97aYNt168sjeQn7/ntFv4tWp9aersouJ6/oML kThPejNVVbl4tuDfNX1J8LZfPuEYtLeTUiaQ2y8k8xLlI7uGfEUg9muDdDS6qWXfsdca cdze3RC5vB9XA2NA+QcX7DeLfXzGSPUTftEbqQ5Uq704o86TWoGAqd1Nwz5G4yinY1Iw ZhBs79+PEALS2oCHS1QgmOM22akRknbmjPVBDIqK74vVee48wIuMFISbbpTP91gPFtbj 4uJMzrCY0Xh8DvEngUcXOrxur2YEf8zWUj7J5RBj08emrSxZCgfnrDK4ZFA/PXTKhx97 KRbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485516; x=1703090316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yYBnLMQSIKwMPIS9f0brTmRTm8/hcJUIZ3wWUMpYIR8=; b=UKMoTkjPYCXdCXEOYVOfv9xqumAs9c70ZVvcb1Gzj3pIma28sORS5vSiFoSo9eK37c 6MbSznB1XIUEkRBeUFtJubdE2yQrHWwGSV4s3FltGmSZmPHbEya/kr2p60/yx4H7zfeX W1k8YMLtCAndl3m7LmLvLshvSAARI6c9DnpusM9YD1jATRWIwzASAElS+iAkDOz6VUE0 P/xDrfpcn1D6EWZ8uXMACGizhwgOaH4nQkrvaZDroKbBuEVxdlWMT1xzOAhp3ikVhvN9 bc8oaucCoH/L3jYjfSukieeIPJAMXtTczv/HcmMOwJ3PXhrU5MWotgxV0g0AnQR5JQAY zyvg== X-Gm-Message-State: AOJu0Yx8ZrUK30M0c64rn6Z6lVLP8BvlWe5QbQ/dw7nUQ/GgZBoEHlML cpGDwhmMf2XXf48jfDYkzRJG6PeA705xRPI9dOc= X-Google-Smtp-Source: AGHT+IEBPb/xsSvySjAGcv1XrWZxl+TkH+WpCgrlpG34uanoESaZDlGxBFGy6pKC0YgRl7YboPszaA== X-Received: by 2002:a17:903:264b:b0:1d0:a9fa:592d with SMTP id je11-20020a170903264b00b001d0a9fa592dmr4125397plb.118.1702485516591; Wed, 13 Dec 2023 08:38:36 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Somnath Kotur , Ajit Khaparde , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev Subject: [PATCH v3 05/37] net/bnxt: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:39 -0800 Message-ID: <20231213163820.894987-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h | 5 +++++ drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +-- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +-- drivers/net/bnxt/bnxt_txr.c | 4 +--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 0e01b1d4baea..3aa9213a12f9 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -1058,6 +1058,11 @@ extern int bnxt_logtype_driver; #define PMD_DRV_LOG(level, fmt, args...) \ PMD_DRV_LOG_RAW(level, fmt, ## args) +#define PMD_DRV_LOG_DP(level, fmt, args...) \ + rte_log_dp(RTE_LOG_ ## level, bnxt_logtype_driver, \ + fmt, ## args) + + extern const struct rte_flow_ops bnxt_ulp_rte_flow_ops; int32_t bnxt_ulp_port_init(struct bnxt *bp); void bnxt_ulp_port_deinit(struct bnxt *bp); diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c index aa1b1ab8bb7e..64c1dfac47d9 100644 --- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c +++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c @@ -357,8 +357,7 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq) if (likely(CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2)) nb_tx_pkts += txcmp->opaque; else - RTE_LOG_DP(ERR, PMD, - "Unhandled CMP type %02x\n", + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", CMP_TYPE(txcmp)); raw_cons = NEXT_RAW_CMP(raw_cons); } while (nb_tx_pkts < ring_mask); diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c index e99a547f5857..572b21a00837 100644 --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c @@ -326,8 +326,7 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq) if (likely(CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2)) nb_tx_pkts += txcmp->opaque; else - RTE_LOG_DP(ERR, PMD, - "Unhandled CMP type %02x\n", + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", CMP_TYPE(txcmp)); raw_cons = NEXT_RAW_CMP(raw_cons); } while (nb_tx_pkts < ring_mask); diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 899986764f93..bd0a75653ab3 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -542,9 +542,7 @@ static int bnxt_handle_tx_cp(struct bnxt_tx_queue *txq) if (CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2) nb_tx_pkts += opaque; else - RTE_LOG_DP(ERR, PMD, - "Unhandled CMP type %02x\n", - CMP_TYPE(txcmp)); + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", CMP_TYPE(txcmp)); raw_cons = NEXT_RAW_CMP(raw_cons); } while (nb_tx_pkts < ring_mask); From patchwork Wed Dec 13 16:35:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135141 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1958436E3; Wed, 13 Dec 2023 17:39:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E56342F07; Wed, 13 Dec 2023 17:38:40 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 169E8410D0 for ; Wed, 13 Dec 2023 17:38:38 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d08a924fcfso66489835ad.2 for ; Wed, 13 Dec 2023 08:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485517; x=1703090317; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/400DIMw+D49S0TEDvyT7cB5r8Xrx+n4umzAtIquzcQ=; b=IB/QSLU3eaM9idW+kPrg8ljUYoCF5ISHy7fGLAiLci2R3P+ZsRlkHDQ1JXEn0tv4kg iKxGIr1ubIu+rp6t/ecwP6Z65eW3uo+CvUv5eKm8MJhIb/4vi+WsCHOlcaJ0PmHQ8/PD DL5oEeJ7Y1XVXUgrVCfc5aV8XSFXgBGMO7Y8ok03poXOw2XhJ5Uv15IvF49/z5phKW31 Cpun087fHnChvPJAtEJ4083phXelhqco1VXTtVeul/B1LMSdrzGAy/gq5BxYKwFxeoSK sBOyRMCYtchL9GH0SdYXIgmZAKeLPN2l1N2jZFp6kbiTKVltLIbJv17NwZfjl+9SpOq+ FYSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485517; x=1703090317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/400DIMw+D49S0TEDvyT7cB5r8Xrx+n4umzAtIquzcQ=; b=N8NwaS1ruIPi/KCjoIrerCn+I8kyGY0wszmrljH52IczKQEXeARl7Aqp94AgyGKp1b UHh7C8SOua00I07pwvpzmQ1nYKtJZtAMYSktT5RN1KpHv86fdlreYAZH/+6UNXDPz2Eh F6EhuU5Jt6BCKpvIJnL5Sh7YcMTW6PCZCEj7ITPeMCyciU1Sfwb7LtSKbIVi7l0Y2ulx uYZFScSg4XMBgMC4rY6UiOHDSqxiCvLdSjquvHwCDKxDdUSvFXN0LrT1606AvGFiSyzs dRbabFULqKjhaqaSOCGa80SNr+N3DunJmoW8/C7KalgmIkRqNs0JNLEqR3REZmJ/r2sk JtMw== X-Gm-Message-State: AOJu0YyowT5b76XJwbWzAzi1jaqhUeSWj+O0mSX96UqklqvMmJ1KZCbl B0TGsYP+tdp/6x8ioexV/lCRHANFw9wmH5JEgYM= X-Google-Smtp-Source: AGHT+IHkF5ojWSvItT6BrlLLjz9h/qjZ/vx0GDPj9YIaUcKnaODkp3SF2tB939cjImLdqgjzt3QIFg== X-Received: by 2002:a17:902:e88a:b0:1cc:43af:f568 with SMTP id w10-20020a170902e88a00b001cc43aff568mr9016163plg.6.1702485517303; Wed, 13 Dec 2023 08:38:37 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v3 06/37] net/dpaa: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:40 -0800 Message-ID: <20231213163820.894987-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- drivers/net/dpaa/dpaa_ethdev.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ef4c06db6a4d..0d0d493f3a6d 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -2096,7 +2096,7 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) /* copy the primary mac address */ rte_ether_addr_copy(&fman_intf->mac_addr, ð_dev->data->mac_addrs[0]); - RTE_LOG(INFO, PMD, "net: dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT "\n", + DPAA_PMD_INFO("dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT, dpaa_device->name, RTE_ETHER_ADDR_BYTES(&fman_intf->mac_addr)); if (!fman_intf->is_shared_mac) { @@ -2166,7 +2166,7 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, ret = dpaa_dev_init_secondary(eth_dev); if (ret != 0) { - RTE_LOG(ERR, PMD, "secondary dev init failed\n"); + DPAA_PMD_ERR("secondary dev init failed"); return ret; } diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h index 5b6802ece8f0..ced3e5f8ff98 100644 --- a/drivers/net/dpaa/dpaa_ethdev.h +++ b/drivers/net/dpaa/dpaa_ethdev.h @@ -232,6 +232,6 @@ extern int dpaa_logtype_pmd; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa_logtype_pmd, fmt, ## args) #endif From patchwork Wed Dec 13 16:35:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135142 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13611436E3; Wed, 13 Dec 2023 17:39:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B680C42F1D; Wed, 13 Dec 2023 17:38:41 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id C23A442EFD for ; Wed, 13 Dec 2023 17:38:38 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d336760e72so19224795ad.3 for ; Wed, 13 Dec 2023 08:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485518; x=1703090318; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LRNt4cMC7ekeRVFATIIXIKTlf44Ax5phZ7jkwQ7JGaU=; b=Fap8Gb2S3lnEFJaIj7K4Jo8gCc9FRR8icn7dO6N+uWBQhY9/tMrWccAMyY+rmE5e88 CjrwKUmOxM8Fb/P68mH0QFbVKsYGalGZTsAcOQ3HbltE4TbrMo95TMAjGi/AbSEa3/Ul xzzXKBoAuZmprnDRN7bxuYEk0jXKFkx4/bEypw8iKbbbiGlWvRi8aAqKrV94uIMm3K8Z Z9T89b7GpRzrEVW/F88h5zm2d7eUsewjf7bOr7+ThZRduGmvKYb1g7G8vdldDEppRT59 IHHpIBBrIVfJSP4vyzX6p03zseOqLRLKOfydzaSNzr38BBEM/6i3rSNLL98bmAeF2QHr qdTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485518; x=1703090318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LRNt4cMC7ekeRVFATIIXIKTlf44Ax5phZ7jkwQ7JGaU=; b=SCRlOZ+WYJEXBwaTBNIfDyJVzSHtWcj0B8VOqE0TdHBU1jTCrLlZRMwIFvD1Laj8zk 0yiaIdEE7jVc9Z9d4mKoWxVKKIm2E/4tHIlMkBvbxTc9bsMa/cof1gIMaHuOB9i7ii2J ElL/qR+MfeqbgfYDzqCVNkBkXNgRltGxY76tZOMRAnDOBnwkyKYnPt49NQPyU6Hly0q3 ANn2oalcaCp3Z5An5OvSOZnlZ57g3CW2RMb/FLPkgrObc23f30xM1g7XAOtJlPX8T0yI kiOkvbMljc03hcCieyA1DpCsIw2FA6Hs2eukP8OgJUlGpAKXvxHrhsBUns2cmqxBDNrH K8Rg== X-Gm-Message-State: AOJu0YyMZ9JFgSVkxDcTy/YKFZH8V+1jt16TUkQ3RbuN5rbMXrdj8WtN sW8qA7OLh11Fx1dOv8DTUzlmkKmA9HDG9uoiEBs= X-Google-Smtp-Source: AGHT+IFn3af8a31UK6ui22zj1Yif22z3zj0J8SIudNCPgDvK1GpklsfRxpFFJrvBen3AjVxgq+otKw== X-Received: by 2002:a17:902:e88f:b0:1c9:c6f4:e0c3 with SMTP id w15-20020a170902e88f00b001c9c6f4e0c3mr10179517plg.62.1702485518051; Wed, 13 Dec 2023 08:38:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v3 07/37] net/dpaa2: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:41 -0800 Message-ID: <20231213163820.894987-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +- drivers/net/dpaa2/dpaa2_sparser.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 8e610b6bba30..71d57ab26062 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -2851,7 +2851,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev) return ret; } } - RTE_LOG(INFO, PMD, "%s: netdev created, connected to %s\n", + DPAA2_PMD_INFO("%s: netdev created, connected to %s\n", eth_dev->data->name, dpaa2_dev->ep_name); return 0; diff --git a/drivers/net/dpaa2/dpaa2_pmd_logs.h b/drivers/net/dpaa2/dpaa2_pmd_logs.h index c47ba8e10bfc..89bffc684e50 100644 --- a/drivers/net/dpaa2/dpaa2_pmd_logs.h +++ b/drivers/net/dpaa2/dpaa2_pmd_logs.h @@ -28,7 +28,7 @@ extern int dpaa2_logtype_pmd; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_PMD_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa2_logtype_pmd, fmt, ## args) #define DPAA2_PMD_DP_DEBUG(fmt, args...) \ DPAA2_PMD_DP_LOG(DEBUG, fmt, ## args) diff --git a/drivers/net/dpaa2/dpaa2_sparser.c b/drivers/net/dpaa2/dpaa2_sparser.c index 63463c4fbfd6..202996c5d05d 100644 --- a/drivers/net/dpaa2/dpaa2_sparser.c +++ b/drivers/net/dpaa2/dpaa2_sparser.c @@ -181,7 +181,7 @@ int dpaa2_eth_load_wriop_soft_parser(struct dpaa2_dev_priv *priv, priv->ss_iova = (uint64_t)(DPAA2_VADDR_TO_IOVA(addr)); priv->ss_offset += sp_param.size; - RTE_LOG(INFO, PMD, "Soft parser loaded for dpni@%d\n", priv->hw_id); + DPAA2_PMD_INFO("Soft parser loaded for dpni@%d\n", priv->hw_id); rte_free(addr); return 0; @@ -234,6 +234,6 @@ int dpaa2_eth_enable_wriop_soft_parser(struct dpaa2_dev_priv *priv, } rte_free(param_addr); - RTE_LOG(INFO, PMD, "Soft parser enabled for dpni@%d\n", priv->hw_id); + DPAA2_PMD_INFO("Soft parser enabled for dpni@%d\n", priv->hw_id); return 0; } From patchwork Wed Dec 13 16:35:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135143 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABFF1436E3; Wed, 13 Dec 2023 17:39:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE04742F2B; Wed, 13 Dec 2023 17:38:42 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 895BB42F04 for ; Wed, 13 Dec 2023 17:38:39 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d08a924fcfso66490035ad.2 for ; Wed, 13 Dec 2023 08:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485519; x=1703090319; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9CaTUhujiCpPiPurkn+zc7fTiPTFh/8DEbU0wQ5edro=; b=wWl7T0ube0Z+zaJQCDp+t2k8YNThXo3jGaK1UqmDbLV4X1ZKqPybvdkBYYzqn8nVRb u6pdzjL47/ktaxKvm7vXcZWJM9NZkj66C9TMiQIj69zwt1FOD1jWnxMPZh3u16Dv0Fsx dSrP2yqMCVcOZdtG4tzaGwbXkltogf/nslRBpGjxowWYZVuoNdZ6InuNEEseAb1ixLAL BFAj+VCh6e07hTeU5+ffJphudKz/IxSXex1m91UdLj1TGeNHDIwDdk8rd25GjR66NRrc 8aPumGIyvH4HX0G2m8pxdhozp4rOJT5CuW04//CswyamBwDxZ7dgN9jvjRg/WoEO55QD 4zxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485519; x=1703090319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9CaTUhujiCpPiPurkn+zc7fTiPTFh/8DEbU0wQ5edro=; b=cH0JmBvN3X+L7sWYwokQJ17rJH4Hshv3cs91ZVXvebyhjbeLiV6QYpbg1k+SWdQ7WO PCoFKPJeF63PFJq9plERp9q138Hb64jMj3DcRFyA9OGYMR75O8yPWBJ1geLHFOqP/iKN nVYecNv0K31o9RrwZq7CZH05/IkO9xpxEsrs/lyUN9GjgwHhSwiWSUXK1ONboPMfziHO ETtbttVe/+Xgy6mcaNmq5GUOh9Zg4iEu/O1fS5XJgJNV5k9slfCqPXZnRYRpEj/aWA3J XDSNdWtljyKTvBafUwJVUsboqvGSS9YAzo3T8dV0ZmhYsmHZ/2m48ykXTmCths+NsGWP 9YCA== X-Gm-Message-State: AOJu0Yy4IzwJBdpMI2d4yYQ+L5XbGCbOqBwzpZjflsXTAs5sXalpL2// FD60ihd4rG6QIUVCJbMefPoNgQj6O++9QeQE9EQ= X-Google-Smtp-Source: AGHT+IG36JUOr5oWObRR6VRemrE285wXO6bzWW8/giGeQdku0QHa2fUVYwp1i1aYWGFRosmigBfkmg== X-Received: by 2002:a17:902:d2d1:b0:1d3:417e:ddc4 with SMTP id n17-20020a170902d2d100b001d3417eddc4mr2982836plc.14.1702485518840; Wed, 13 Dec 2023 08:38:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Sachin Saxena , Apeksha Gupta Subject: [PATCH v3 08/37] net/enetc, net/enetfec: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:42 -0800 Message-ID: <20231213163820.894987-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/enetc/enetc_logs.h | 2 +- drivers/net/enetfec/enet_pmd_logs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/enetc/enetc_logs.h b/drivers/net/enetc/enetc_logs.h index 0976d42debd7..05a540f16490 100644 --- a/drivers/net/enetc/enetc_logs.h +++ b/drivers/net/enetc/enetc_logs.h @@ -30,7 +30,7 @@ extern int enetc_logtype_pmd; /* DP Logs, toggled out at compile time if level lower than current level */ #define ENETC_PMD_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, enetc_logtype_pmd, fmt, ## args) #define ENETC_PMD_DP_DEBUG(fmt, args...) \ ENETC_PMD_DP_LOG(DEBUG, fmt, ## args) diff --git a/drivers/net/enetfec/enet_pmd_logs.h b/drivers/net/enetfec/enet_pmd_logs.h index 72d1cb61c598..c0a226284c53 100644 --- a/drivers/net/enetfec/enet_pmd_logs.h +++ b/drivers/net/enetfec/enet_pmd_logs.h @@ -28,6 +28,6 @@ extern int enetfec_logtype_pmd; /* DP Logs, toggled out at compile time if level lower than current level */ #define ENETFEC_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, enetfec_logtype_pmd, fmt, ## args) #endif /* _ENETFEC_LOGS_H_ */ From patchwork Wed Dec 13 16:35:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135144 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8E42436E3; Wed, 13 Dec 2023 17:39:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 102BD42F39; Wed, 13 Dec 2023 17:38:44 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 46E3742F08 for ; Wed, 13 Dec 2023 17:38:40 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d3470496e2so14188145ad.1 for ; Wed, 13 Dec 2023 08:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485519; x=1703090319; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/DPSVVK2jSEmyArt2/1jZcc4tuBUSzU5dmJR3gwnmQE=; b=b/gKKytbA47rgfCRjIMLutnR8yNElkjFfhWTJ9yaJGVP2aprqlFL2RGB/D7yBBFDRn efJHr8yRoXsycGj2P1orVnD8gmdG6aSl69v6e50+LsUzltgy2V5VHt44RcnsF9LZP/Ke uIFMNv+FPyzsUqfkFIXvmuCdkzcY24YDxAKXyVHvha9gQnKCDYkoKaF10K2e37NafiCg A1QnLcrs7tDRS1hqfwfIcsv9O0vL3IUY0VDMGuMXqTFsRg8fb/PkmsMGn24jf5/5OIma u/gtRD0JNnvpgp/pfo0DsrU2nZ1Ha4rf8ZbaGRe38aOhqbI+KPoKWWJuE2m30cImA73K 0alg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485519; x=1703090319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/DPSVVK2jSEmyArt2/1jZcc4tuBUSzU5dmJR3gwnmQE=; b=N02gaUDDED8cEMOJvNpBpJEFD4jo05/aDPt1TcnHHBiReOzrm61pmKNxoym0zRMYti gAFvux6mR1SLsWi8R6gRiO6UZXB5HJizPI6CBaPKYPdbN6+W8EolaI5YNXUqe/ztJbHV jSY9CIEEN/yhiumQKEmbSuyouzFWv/mozdcMGD5K/4FbXS/cPnorEq7HC836XP/+xXCE 2/V488X9o8C248D78OVdE1AT/QhF/A257+lRhMsEq1t0iuaN1LleTt7F4jHMiXy7LBjY ja9Ehw88ARf9PusYSei735wWnEszUPl1VGWu3NI9iuI/MVlesiNTNaC6rRBDTXqiL4dd Vlcw== X-Gm-Message-State: AOJu0YySPSNbDGZaed3MOmGJSIs9qNKSRI3ancEKY+kpAUkbw1G1JnB0 DyT5aA7EqqFJKZqyzPzkyhBPvlUMRXOYKbREvKk= X-Google-Smtp-Source: AGHT+IGSHfHWin9z9uE7SGp/53DdYP+L4+79TMjw17G0z5b/shzAykFQgHH0GupE00KYeg9+8Qyr5Q== X-Received: by 2002:a17:903:1105:b0:1d0:afea:78a8 with SMTP id n5-20020a170903110500b001d0afea78a8mr9891733plh.106.1702485519574; Wed, 13 Dec 2023 08:38:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Junfeng Guo , Simei Su Subject: [PATCH v3 09/37] net/igc: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:43 -0800 Message-ID: <20231213163820.894987-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Junfeng Guo --- drivers/net/igc/igc_logs.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_logs.h b/drivers/net/igc/igc_logs.h index 11071a32b542..ffa1981bae32 100644 --- a/drivers/net/igc/igc_logs.h +++ b/drivers/net/igc/igc_logs.h @@ -21,15 +21,17 @@ extern int igc_logtype_driver; #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") #ifdef RTE_ETHDEV_DEBUG_RX -#define PMD_RX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) +#define PMD_RX_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, igc_logtype_driver, \ + "%s(): " fmt "\n", __func__, ## args) #else #define PMD_RX_LOG(level, fmt, args...) do { } while (0) #endif #ifdef RTE_ETHDEV_DEBUG_TX -#define PMD_TX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) +#define PMD_TX_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, igc_logtype_driver, \ + "%s(): " fmt "\n", __func__, ## args) #else #define PMD_TX_LOG(level, fmt, args...) do { } while (0) #endif From patchwork Wed Dec 13 16:35:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135145 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 434EE436E3; Wed, 13 Dec 2023 17:39:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3775142F43; Wed, 13 Dec 2023 17:38:45 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id E8E5042F0D for ; Wed, 13 Dec 2023 17:38:40 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d098b87eeeso63383105ad.0 for ; Wed, 13 Dec 2023 08:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485520; x=1703090320; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HvleY8wKOkRkFVRC6mJ7WcUQOwz0Fw82bM6bnygqtgI=; b=ZdQVi/lTyt684IMp5xzWUKn1lOE45GqpDLwSL4E8OM2dvGN3YWKBFNP9TbOH/Nw9gC e08x/BQAULyjZ1qJig9s0Sbzgx76PMa/c3GMNjBzUEgA8Tz4x3Vp29zqYd1Qy4x+cD3t 0jFH6y/30D/wK4yvjYPn7dCM00NBXiRHWC+oSru+QdMwiI+hbE7TAPs+yFwlOwLKD7cN ZcfLwzVnGndiMVteMs3NE1drTrveCw+chV5XgFOjszs/K2+vHqYY6Q7KiyDH7EDKDxSN Nwn56iN1jwD73wd+OWqhEPhMuCiLbv2meW5JZPYig9PwC/yWjgJ3E8g6mBnxpnsny4xV uwDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485520; x=1703090320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HvleY8wKOkRkFVRC6mJ7WcUQOwz0Fw82bM6bnygqtgI=; b=jw5GK2hs/PS7cYbBQ05EQfI4kjxbtldtaacpkeGuRqXV+hzN/5Jk//f+jz0g8eIgfe RQCW9OeubDV+PWfsJNHGugxFF+Kkj2RBCtH///niOMJju+87YDGOpfrjQDDrCld58VZe CooGAGjKG1bh71ZiHmlv6cxAtiWcuMyJUhub2Mwi2n/lewVKXsMDQvph3EVs4BIFH7Ue vn23C+3yEGl5qBnSadXwGnbvB3BV8eQFSO/Zs1vjezEGpkczDlT0+SsZmmCkOib/OOGb NSOgaKl+XxIo9SvZdlLXD9hAV/3OP/qSZggh3n9E8O9JN/jwNJaYrLDhKumpLPhJj4CM W9Cg== X-Gm-Message-State: AOJu0Yyh131hbU/UXYhnrvYOf9Hj9gE1c+VJaa5Z1DEMTObYIokQdjW0 A6V+SXvRkQGwgBw4+8zf6/UbRhq5hwqG3CitCiQ= X-Google-Smtp-Source: AGHT+IGwzzWRns7WBKYmzqsuFWJgwYV8sY0RL1nuMI45x0N8aZenZJRkmcY6Uy2IUCtVm0JsA4IHjw== X-Received: by 2002:a17:902:d511:b0:1d0:6ffd:9e13 with SMTP id b17-20020a170902d51100b001d06ffd9e13mr9000449plg.101.1702485520214; Wed, 13 Dec 2023 08:38:40 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Long Li Subject: [PATCH v3 10/37] net/mana: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:44 -0800 Message-ID: <20231213163820.894987-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Long Li --- drivers/net/mana/mana.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index 6836872dc257..8d60f9172d44 100644 --- a/drivers/net/mana/mana.h +++ b/drivers/net/mana/mana.h @@ -467,7 +467,7 @@ extern int mana_logtype_init; __func__, ## args) #define DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt "\n", ## args) + rte_log_dp(RTE_LOG_ ## level, mana_logtype_driver, fmt "\n", ## args) #define PMD_INIT_LOG(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, mana_logtype_init, "%s(): " fmt "\n",\ From patchwork Wed Dec 13 16:35:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135146 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FAF3436E3; Wed, 13 Dec 2023 17:40:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07AB040698; Wed, 13 Dec 2023 17:40:07 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id B7EA14025E for ; Wed, 13 Dec 2023 17:40:05 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d35dc7e1bbso3773655ad.1 for ; Wed, 13 Dec 2023 08:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485605; x=1703090405; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1PuRGVarocmL1IUnh12sriLkQomOmBjWYQIUsCmsBeI=; b=XK2um/z9uizBETrIEK/noZbNrSa0yuthg0MSukvwioGxwg/UN0O5lYa8mg1tV81BS7 p6mCdH7sb+xSk6bgDz5nQLxRwDPxnk/9ZSCV0XfHJea29uZslRPEP/WTDgH3tc8Bi6i6 rq0gFTMbiJrcqR3ZqA1pjrwPipg2G8gHYzNsdR6vEbFLI3V+rk8Xm04MAQgc0G4D7BNV XvH/rtLNztrPwXNVKdSSESdpMA0rxr1jR/DjeCkmvOvCIvMIa7GyRVs4txF3+btZ3HRP V9q4Zn3ME1dhINpixUWVM82HG29ltFJ+C7NT0iButptOO6qx8esEGDimRyYr10z8/5Ka ic4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485605; x=1703090405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1PuRGVarocmL1IUnh12sriLkQomOmBjWYQIUsCmsBeI=; b=LBO4cZZGmQkvyKGT+dW0kdiLyCV6Go5kygv3TLRbcDHTx8T1vv0h51KFKA1rIfa+Hy vmG85PFvSD0legqtggjgWFFtxBBB8NRe0OCTjIRYtsXvDyn/qyK3L6i8L+22mXA0rts+ PjV//SaDZ6zXDJI9IBk0Y8tg/pGhP5XSqHS0/QEHPxZ47JskaKW6JdlejYreTa80uAix IF84qK8086LQzCM7JpuxdFu5AJOxvUs6CgtjontDhOCC76+5UDbcrJ2a2AxcUOejChfG AyevRy3qdemxtrPOZc6zp4Nh13jGr2ZXkR6F2CW/C0dTemSyJo5c4epJWFXxAWHStykY asyQ== X-Gm-Message-State: AOJu0Yw6cjzCoqyM1OKibcnTGU/RV3lH02H7Asd9ZEzkEHTcwR4x6ZN9 eUMAwNjpS9R1PhEGrZP+xxFbH4nRSZj6u6fc8V0= X-Google-Smtp-Source: AGHT+IG7dbwcYXicDlvsqu5MTO7WE5paIoqQ0CEFk+zTrqr3/F6vlGW+v+BuDDYHIn9Mqln2GjH7aw== X-Received: by 2002:a17:902:f686:b0:1cf:cf34:d4fa with SMTP id l6-20020a170902f68600b001cfcf34d4famr7905928plg.28.1702485604852; Wed, 13 Dec 2023 08:40:04 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi , Natalie Samsonov , Yelena Krivosheev Subject: [PATCH v3 11/37] net/mvpp2: do not use PMD logtype Date: Wed, 13 Dec 2023 08:35:45 -0800 Message-ID: <20231213163820.894987-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver already has a logtype but it was not being used in one place. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index c12364941d62..9a9279a8783a 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -415,10 +415,10 @@ mrvl_set_tx_function(struct rte_eth_dev *dev) /* Use a simple Tx queue (no offloads, no multi segs) if possible */ if (priv->multiseg) { - RTE_LOG(INFO, PMD, "Using multi-segment tx callback\n"); + MRVL_LOG(INFO, "Using multi-segment tx callback"); dev->tx_pkt_burst = mrvl_tx_sg_pkt_burst; } else { - RTE_LOG(INFO, PMD, "Using single-segment tx callback\n"); + MRVL_LOG(INFO, "Using single-segment tx callback"); dev->tx_pkt_burst = mrvl_tx_pkt_burst; } } From patchwork Wed Dec 13 16:35:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135147 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B50B436E3; Wed, 13 Dec 2023 17:40:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46A4C40E25; Wed, 13 Dec 2023 17:40:08 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 9B67C4025E for ; Wed, 13 Dec 2023 17:40:06 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d0b2752dc6so63275435ad.3 for ; Wed, 13 Dec 2023 08:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485606; x=1703090406; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ftBcpZJRVGhRB4SHFaON+c7hHKmPr6GTRlDBEQ4iANE=; b=IrKXd4gQox/ZDHNyS3NQ1BZ+RnLtMj/obdzYUMHA6IbOUMsK3/DtCHSM8c8BPe6dQ5 BWMUiZlAua24B66kK6H/5JMjjbnrA32cU7X46LE4x+0AdJbqXePTwKhgbRZ30wL8m6CX SBLV4B57o12PR7UGJaATnL97Orbt/ZErmKq4q9NJqw34xAtN1u9ru+v+IMCnf9Bn0dGs dbbYHxNoPtQ5FLSd56jbzEwqwvHbA27RqzwXS8MJBAvwWqXzYixS9vFVEmh3Wz1JeBs1 K7PSmHNmZtBV/FptRWXkeIm8nRIiOHei233qj1DAQgnjvUhYhXAPuqB8TtJDjjvgnKjN fWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485606; x=1703090406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ftBcpZJRVGhRB4SHFaON+c7hHKmPr6GTRlDBEQ4iANE=; b=gqCTz4rN7l/zBMQRhenGTkB1Q6a9ZRyQ2H3FUAOxdOZFN+c5xgqzq82gdxi7BIP3Li P/KfBYcXy2xwlSAhdb1wd1mUlSJ1PzYUlVlaqt8EYuQdlQcLfrO4ZfEG2lnPheoGgFJE DMBx8y8mzUk1wqp9ISTcOZRiirNVLDgTtjDsRktT8jbSDr+iEbYKc/2FCcT8I/ot369+ NlVNh9y5H8dX4vn9jcx8LdP1M7mueiPED3by2JcmtEwlZ21j/nCNojkwylcHyACBKjG7 ybH/vydX2d1psab+Fjwl1Zma+A7iVDiLl720M0RonPUkRFwrGWQyoEICzb+5CTPntOoD sefw== X-Gm-Message-State: AOJu0YwDdHiNpq9k16br1sTvh9ktwsB/JeCxXi7PYesvPQGipwuUAjB6 /EQOItILlhPHMSlFbPG2B37fsFPymAgH99Atn68= X-Google-Smtp-Source: AGHT+IE/bDtNXufMqWbUYtnVEU68YIySU2LDZ14Jp0MzDyeSgqz1gD6M+dPHG9DeOLS5G4shoUYqfg== X-Received: by 2002:a17:903:24c:b0:1d0:6638:b9de with SMTP id j12-20020a170903024c00b001d06638b9demr9588677plh.10.1702485605887; Wed, 13 Dec 2023 08:40:05 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Vamsi Attunuru Subject: [PATCH v3 12/37] net/octeon_ep: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:46 -0800 Message-ID: <20231213163820.894987-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeon_ep/otx_ep_common.h | 7 +++++++ drivers/net/octeon_ep/otx_ep_rxtx.c | 5 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octeon_ep/otx_ep_common.h index 82e57520d38d..5fb63d051ac8 100644 --- a/drivers/net/octeon_ep/otx_ep_common.h +++ b/drivers/net/octeon_ep/otx_ep_common.h @@ -81,6 +81,13 @@ "%s():%u " fmt "\n", \ __func__, __LINE__, ##args) +#define otx_ep_log_dp(level, fmt, args...) \ + rte_log_dp(RTE_LOG_ ## level, otx_net_ep_logtype, \ + "%s():%u " fmt "\n", \ + __func__, __LINE__, ##args) + + + /* IO Access */ #define oct_ep_read64(addr) rte_read64_relaxed((void *)(addr)) #define oct_ep_write64(val, addr) rte_write64_relaxed((val), (void *)(addr)) diff --git a/drivers/net/octeon_ep/otx_ep_rxtx.c b/drivers/net/octeon_ep/otx_ep_rxtx.c index c421ef0a1c04..fe8885be54ff 100644 --- a/drivers/net/octeon_ep/otx_ep_rxtx.c +++ b/drivers/net/octeon_ep/otx_ep_rxtx.c @@ -884,9 +884,8 @@ otx_ep_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) next_fetch = (pkts == new_pkts - 1) ? 0 : 1; oq_pkt = otx_ep_droq_read_packet(otx_ep, droq, next_fetch); if (!oq_pkt) { - RTE_LOG_DP(ERR, PMD, - "DROQ read pkt failed pending %" PRIu64 - "last_pkt_count %" PRIu64 "new_pkts %d.\n", + otx_ep_log_dp(ERR, "DROQ read pkt failed pending %" PRIu64 + "last_pkt_count %" PRIu64 "new_pkts %d.", droq->pkts_pending, droq->last_pkt_count, new_pkts); droq->stats.rx_err++; From patchwork Wed Dec 13 16:35:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135148 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB501436E3; Wed, 13 Dec 2023 17:40:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 945F742EFE; Wed, 13 Dec 2023 17:40:09 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 56B0D4064C for ; Wed, 13 Dec 2023 17:40:07 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d05199f34dso41056755ad.3 for ; Wed, 13 Dec 2023 08:40:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485606; x=1703090406; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iI6jEEynaN6L9m63UX7MdwvcC55IS4coLOmuaNgBEA0=; b=2rlniB5iBE2KliFqRVhe0rfYByHRpqW/AK3ZKQ374h/Gz1cBvrvSpMgbfT8K+AQ8cv dkpmaRqg7sX92XvGUPiT0+rpMghg6hXEOiIZrhU4GMEdzAOCJuRqKuHqvydKAcTywtWn 9D13BedI2t78Z/p/rhn2KTe0M10Br0aHDNuPT+F4xPEQBHP9sNWJndV9QRMvPxt6n5Ql r5nyYvG4G1kOh+HWsbEH5iE5dH6T5cadapqHSnnRjayRGWduLMI2lfz7svcNchEosAbc 2zyOLry8QmyXOg8Jp16gHsAEywWxeUeal5taMl5KEKpEsoHUpDzgEPjyzN5LEXxfrd74 t0Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485606; x=1703090406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iI6jEEynaN6L9m63UX7MdwvcC55IS4coLOmuaNgBEA0=; b=xDLrhzVvMSVBESZ/ltw2q+BZw+iEdYk5EgmXUxjs2Q4AWAEJnzt4iLehidzG9KwaYd ZQNzSOKeW6JKdgi5WAQC4qP2NhPqLDRLDlyBmTt81dChbwtUIXJQcxJk0DZPxUsndXs8 0aEBqhweQP8Hl+kwf8jO8fxotuta1ZI7RQ9N0hFvs96fHtNnxjZ5b1hQbmhXGT3q+gUs XV3eHn713hFN2TUzQdoXx1Z8VTnIBdRgfrWcK/oLpVYu7L50twsmJZ5+aIspwbyAXmW9 PxGtaII02RDo+v1p4lKB6kjg0fFSjw1BOy2yzSDaV3GW14kZNY+J1htvvzQMwkdrJU2m Nt8Q== X-Gm-Message-State: AOJu0Yy/Yew0+RBI7yvgqHbwjHkEBmoDel5H3vORki/lSiuWtbCz2LbU wkqtw5w/D+h7YK/1plXtLbNBa6cEx3XZUjVZAH4= X-Google-Smtp-Source: AGHT+IEWvHt/TcKNSi3GCezLfADz4SD9t9R5q6BIXkS4QAwgwgsEaU03dfWAD2aU7v86HUl3+/nTGg== X-Received: by 2002:a17:903:2288:b0:1d0:1e49:3f60 with SMTP id b8-20020a170903228800b001d01e493f60mr4678748plh.27.1702485606598; Wed, 13 Dec 2023 08:40:06 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Harman Kalra , Gagandeep Singh Subject: [PATCH v3 13/37] net/pfe: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:47 -0800 Message-ID: <20231213163820.894987-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_logs.h | 3 +-- drivers/net/pfe/pfe_logs.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_logs.h b/drivers/net/octeontx/octeontx_logs.h index dec8042c67ba..cec5346d5a8b 100644 --- a/drivers/net/octeontx/octeontx_logs.h +++ b/drivers/net/octeontx/octeontx_logs.h @@ -19,11 +19,10 @@ rte_log(RTE_LOG_ ## level, otx_net_logtype_mbox, \ "%s(): " fmt "\n", __func__, ## args) -#define octeontx_log_info(fmt, args...) \ - RTE_LOG(INFO, PMD, fmt "\n", ## args) #define octeontx_log_err(s, ...) PMD_INIT_LOG(ERR, s, ##__VA_ARGS__) #define octeontx_log_dbg(s, ...) PMD_DRV_LOG(DEBUG, s, ##__VA_ARGS__) +#define octeontx_log_info(s, ...) PMD_DRV_LOG(INFO, s, ##__VA_ARGS__) #define octeontx_mbox_log(s, ...) PMD_MBOX_LOG(DEBUG, s, ##__VA_ARGS__) #define PMD_RX_LOG PMD_DRV_LOG diff --git a/drivers/net/pfe/pfe_logs.h b/drivers/net/pfe/pfe_logs.h index 58d5e8e7cff1..306bfc22ea54 100644 --- a/drivers/net/pfe/pfe_logs.h +++ b/drivers/net/pfe/pfe_logs.h @@ -26,6 +26,6 @@ extern int pfe_logtype_pmd; /* DP Logs, toggled out at compile time if level lower than current level */ #define PFE_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ##level, pfe_logtype_pmd, fmt, ## args) #endif /* _PFE_LOGS_H_ */ From patchwork Wed Dec 13 16:35:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135149 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E716436E3; Wed, 13 Dec 2023 17:40:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDD7142F07; Wed, 13 Dec 2023 17:40:10 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 4B61F410DD for ; Wed, 13 Dec 2023 17:40:08 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d0bcc0c313so38676135ad.3 for ; Wed, 13 Dec 2023 08:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485607; x=1703090407; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nP188/uJXTVly2BuP95gWp+P53SBcg9sy8o3XGKfi5E=; b=0lymsX65qGKBPND86GpPGhGAR/sk+u4rUm7vQ/0sYEcHCuZtQ3ty0eGjFn6Ut6sBIL wKLsT0ohlaRD0AEwVan30eRI99m34mRwooa+pW86DZwI1ZnCFWh0rFUDUZ6uXM9AM2is prfnYDVp6MOxztnYc1PItKUZeSq62FXgMskg/aggXgiPqhBXxi6CZplrYMUy5c7oEVfA J3xI7ka8hPiUYeEGgKDpfvWCrYwesYUFRpUultD4sivTkxxxJHmJB3xqorB0ld2qQEGF YDa1M2P5QMICvTl13PYlNs8BVwKxm4gkkAo5K9YPtmNgH0y6mjhwid6l0O2naIgLpBoq z5Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485607; x=1703090407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nP188/uJXTVly2BuP95gWp+P53SBcg9sy8o3XGKfi5E=; b=DWQlkydeSv7/vMncc8a1CZZZjY9DrqE3DRNKr87FeyOJg5gXtMh9AvoCZVGdXungvt k5oUejZtL0Pg/0k0fGMVoxg5P/WWP2yyNTQ0w9Nq/NM4Jzk1fLU0XIsiXD2mXxouzFz6 hqgbjgqWpOOrpFmik4vTV7nooDW5ZiXSVCNlVxHi4f9V1PGJUd5aQnzEisX/EDqHkC3V g5hVFFRmjMeM98U8k+zu0yKkcFWk/iIqtnWI4mK1cQ2nTql5GnmI9PIPsOi6DNrC4l4q msae4wn/Qhk+Ry0Ravn27n1BywlFnRFAqaNcuWKFdVu72QPZD6K5RHo9dhzuhsPqbOa2 kp+Q== X-Gm-Message-State: AOJu0YzMZGet0Lx0btkPX44KUJjjm3vVxaHjLkdb4DBzh2FfYRQjmP6k 65JZ8rFHMfH1hYzm5JHBkZOeaBUbzjWXhfGF6WA= X-Google-Smtp-Source: AGHT+IHwJ2BcfghMvyZ2OPrEYql7mAPu/gfpIcFb+3n9KEh8aGKBrbvD7FnXXz0mo5eZGblLXKFulw== X-Received: by 2002:a17:903:41cd:b0:1d0:7490:4ab8 with SMTP id u13-20020a17090341cd00b001d074904ab8mr3818705ple.7.1702485607289; Wed, 13 Dec 2023 08:40:07 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Devendra Singh Rawat , Alok Prasad Subject: [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:48 -0800 Message-ID: <20231213163820.894987-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Devendra Singh Rawat --- drivers/net/qede/qede_logs.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 3187d97bb7b0..f7aa14df7e3b 100644 --- a/drivers/net/qede/qede_logs.h +++ b/drivers/net/qede/qede_logs.h @@ -58,16 +58,18 @@ extern int qede_logtype_init; #define PMD_INIT_FUNC_TRACE(edev) PMD_INIT_LOG(DEBUG, edev, " >>") #ifdef RTE_LIBRTE_QEDE_DEBUG_TX -#define PMD_TX_LOG(level, q, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): port=%u queue=%u " fmt "\n", \ +#define PMD_TX_LOG(level, q, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qede_logtype_driver, \ + "%s(): port=%u queue=%u " fmt "\n", \ __func__, q->port_id, q->queue_id, ## args) #else #define PMD_TX_LOG(level, fmt, args...) do { } while (0) #endif #ifdef RTE_LIBRTE_QEDE_DEBUG_RX -#define PMD_RX_LOG(level, q, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): port=%u queue=%u " fmt "\n", \ +#define PMD_RX_LOG(level, q, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qede_logtype_driver, \ + "%s(): port=%u queue=%u " fmt "\n", \ __func__, q->port_id, q->queue_id, ## args) #else #define PMD_RX_LOG(level, q, fmt, args...) do { } while (0) From patchwork Wed Dec 13 16:35:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135150 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D3D1436E3; Wed, 13 Dec 2023 17:40:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EFD442F11; Wed, 13 Dec 2023 17:40:12 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id BCB4E410DD for ; Wed, 13 Dec 2023 17:40:08 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1d3536cd414so6013185ad.2 for ; Wed, 13 Dec 2023 08:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485608; x=1703090408; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=10T0oz6eXkQc098ZKBoKnfmVijWAQJM22pUknc6OZE4=; b=nm/wX2xarQg0MLIMFUrxahgQ0ku/fXUqSbiRO/6IMDY13fZNdZw73eLcqe+W3LKZMW 6yyJDrnR5UaJ0ey48dcC3eAFsum6kxB2gnU9k0Dcy435N5wkISxI3ZlNT94MyvbkJiVO T1WFZ95w51VDKjnVJiNXoGTFmqTNEmefMbu7fUMgcFEwqwERuoqZL7mIOTU6giTHdNpN MXm3go4Y8h9VGZsog8HZa63rQlARQPMTTesPmYOTh6Qo775nC3s4mjiqldPaHvyDiHS9 mEG24YLRNCyY+sjIfn+cumfD1AHIn6921vrdeeDcIhn5xk31JFP+almgicwmG0beIA1w ND6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485608; x=1703090408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=10T0oz6eXkQc098ZKBoKnfmVijWAQJM22pUknc6OZE4=; b=Zh53F9eGq65np0dHyITelUS38ZNUqNRR16MY4mlASxClDv9Kvkiu6Wx8mKcrzvwSWL +HgZNITFm1uO4VXcN1Tc1C+eaYM7SpCAp89aGUTbyWQzY55LEVDu7S/BQB9iTHjiIJTU 75W5Uo/RweP0+UYHfFfGLeO8A2RtrU5NhuxFcuct5KF+rHfE5YqZb4GAt6uYO5zFWPFw BjTxM3uLIceuRm95h0a95YW4r24RSRqetElUJQTdSUxqus4VoiRHN9fPK8eDWoV/STHq ZhbzVUoautHPqurRuyU2eGiP9VgYF/l2AWzTuk78vsHj35OAc0AtKU+cNUH19A85SYbS AcEw== X-Gm-Message-State: AOJu0YwpjUrKqfWt4CRbIriHCQtnqMChrxRgQBQVSXO6v9Y+rJkclPPn Fkiml6LsM5HuR/oT2M1au3m/TxKhJy2lTsk4qSs= X-Google-Smtp-Source: AGHT+IELDVmwhzDxMjLjgHNboyYI2ypEZTl47z5EervbOZG1wKyZ4AM+E4a3sXDjBq1fV3PvJQXUJg== X-Received: by 2002:a17:902:8682:b0:1d0:cd9e:424b with SMTP id g2-20020a170902868200b001d0cd9e424bmr7829890plo.43.1702485608000; Wed, 13 Dec 2023 08:40:08 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH v3 15/37] net/virtio: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:49 -0800 Message-ID: <20231213163820.894987-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_logs.h | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h index 9b1b1defc5a6..0447ee961fb6 100644 --- a/drivers/net/virtio/virtio_logs.h +++ b/drivers/net/virtio/virtio_logs.h @@ -14,23 +14,25 @@ extern int virtio_logtype_init; #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") +extern int virtio_logtype_driver; +#define PMD_DRV_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, virtio_logtype_driver, \ + "%s(): " fmt "\n", __func__, ## args) + #ifdef RTE_LIBRTE_VIRTIO_DEBUG_RX #define PMD_RX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, virtio_logtype_driver, \ + "%s() rx: " fmt "\n", __func__, ## args) #else #define PMD_RX_LOG(level, fmt, args...) do { } while(0) #endif #ifdef RTE_LIBRTE_VIRTIO_DEBUG_TX #define PMD_TX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, virtio_logtype_driver, \ + "%s() tx: " fmt "\n", __func__, ## args) #else #define PMD_TX_LOG(level, fmt, args...) do { } while(0) #endif -extern int virtio_logtype_driver; -#define PMD_DRV_LOG(level, fmt, args...) \ - rte_log(RTE_LOG_ ## level, virtio_logtype_driver, \ - "%s(): " fmt "\n", __func__, ## args) - #endif /* _VIRTIO_LOGS_H_ */ From patchwork Wed Dec 13 16:35:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135151 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A8CB436E3; Wed, 13 Dec 2023 17:40:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4751242F1D; Wed, 13 Dec 2023 17:40:13 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id A3DF942F04 for ; Wed, 13 Dec 2023 17:40:09 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d30141d108so19257515ad.2 for ; Wed, 13 Dec 2023 08:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485609; x=1703090409; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=49CSqXbalqG7YAhFsQRKAnA4ZuMuOwHyVx1FhtAxaF4=; b=z/TMaG6O8r7DgirFAkdMhgY9p3GA3DApRmUOgiKy/j35mpXIYecqZsBA+3JSNfPj1a VEb8pqq3aRsRJlayXvDLxI0zG0TJMUiSnMGgKTuK0a7ajKhfMzw8qAERhP3sOzV+/ORx sm2nsA4WwCV8LVr2LBCd81xaNF3L1OGZK3mi/w3ur+QUFk9pKyAqde9Ctt4oW14QxIU2 +ytS/AsolF9RKGOdiO5zV8yO7Y/N5CrriaqMnQlU9gPlAx5Qe1+G3gy7YhFI56nfZ12O KsDdtKCs6uA+1JY3IGeTcRCnIoI5ApLu0nD5L6dNAof/A6gwIwQKZR8aIm83Psgdtpw3 K8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485609; x=1703090409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=49CSqXbalqG7YAhFsQRKAnA4ZuMuOwHyVx1FhtAxaF4=; b=tlq+iFQLF3Zr4quiw8aSdNtOs3WI+puJsRu6wYcOv6pr9N3b/fDtuqxEfsg6lztdSo BRSksrkld8kv6+mbB6AyHn31fRQe5iimApEYDc2wAI7Zqu2m8ogslxrezRRN/prx6Tbw mWUWdSsCOMEJpC2S7U3vPm3K3MafjV8ZW4zulrvpM0lX9HikKGiXnd/E3y1+TLL/b0hc whrIhWhT+gu2BGFAIeHLoAqmRzgf3acmKS1mcJnpRz/EblPR4zCh8GbzAiajz0nzVCw6 wTdGw4tXkvpCSluDCNv4pI3EFqC67V02amSOFiF6q1UFnp97SqK4S0YQ84LTZrD4CCQO /seA== X-Gm-Message-State: AOJu0Yzj/nfPfdB/MK49AmHMbPR9u99ag/xKVRYrJuORlFDIV+bqj4Hi Ezi75Khh4mSp9zMGeT1oKrGIoQdcJk4kYbIIFks= X-Google-Smtp-Source: AGHT+IHitC7eqq2hKdus7W9dDEN3BJxQgSjlQe3JteFlb+HoXqjQxTnIkEt4vCBtX4bLFMDMJjQrgQ== X-Received: by 2002:a17:902:a383:b0:1d0:84f1:6fb8 with SMTP id x3-20020a170902a38300b001d084f16fb8mr3302910pla.68.1702485608921; Wed, 13 Dec 2023 08:40:08 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jochen Behrens Subject: [PATCH v3 16/37] net/vmxnet3: do not use PMD logtype Date: Wed, 13 Dec 2023 08:35:50 -0800 Message-ID: <20231213163820.894987-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver used a slightly different (and older) format for datapath logs. Remove PMD logtype here. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- drivers/net/vmxnet3/vmxnet3_logs.h | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index e49191718aea..4fd704045fc4 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1919,7 +1919,7 @@ vmxnet3_interrupt_handler(void *param) if (events == 0) goto done; - RTE_LOG(DEBUG, PMD, "Reading events: 0x%X", events); + PMD_DRV_LOG(DEBUG, "Reading events: 0x%X", events); vmxnet3_process_events(dev); done: vmxnet3_enable_intr(hw, *eventIntrIdx); diff --git a/drivers/net/vmxnet3/vmxnet3_logs.h b/drivers/net/vmxnet3/vmxnet3_logs.h index 74154e3a1a6d..058d704f82c9 100644 --- a/drivers/net/vmxnet3/vmxnet3_logs.h +++ b/drivers/net/vmxnet3/vmxnet3_logs.h @@ -11,28 +11,32 @@ extern int vmxnet3_logtype_init; "%s(): " fmt "\n", __func__, ## args) #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") +extern int vmxnet3_logtype_driver; + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_RX #define PMD_RX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, vmxnet3_logtype_driver, \ + "%s(): " fmt "\n", __func__, ## args) #else #define PMD_RX_LOG(level, fmt, args...) do { } while(0) #endif #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX #define PMD_TX_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, vmxnet3_logtype_driver, \ + "%s(): " fmt "\n", __func__, ## args) #else #define PMD_TX_LOG(level, fmt, args...) do { } while(0) #endif #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX_FREE #define PMD_TX_FREE_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, vmxnet3_logtype_driver, \ + "%s(): " fmt "\n", __func__, ## args) #else #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while(0) #endif -extern int vmxnet3_logtype_driver; #define PMD_DRV_LOG(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, vmxnet3_logtype_driver, \ "%s(): " fmt "\n", __func__, ## args) From patchwork Wed Dec 13 16:35:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135152 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F11F436E3; Wed, 13 Dec 2023 17:40:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F90142F63; Wed, 13 Dec 2023 17:40:15 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 871BF42F04 for ; Wed, 13 Dec 2023 17:40:10 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d06d42a58aso66566715ad.0 for ; Wed, 13 Dec 2023 08:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485610; x=1703090410; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TFco7o1FJMnx1yCq0brlp2BMzPyjFA1RTumvD/FNmTY=; b=nfG6qZZwKIsan34G3PfrQM+aYOBwwyEuxqsTzqzbdwYiG1AQJvRSUGrHR13exuQio7 WUGphauZqjySVNpbu7yh+qrjdJ7vasI2L6XJxcVoYCBtuJThA4P/328kMgUaL+MNSWB9 tOCMtiZM0dbdfwtxYUCgKDKxqgqhUvlcWZnCgWaplZ2C2V/zQLkG4VcmvSnQ5HZ80rdN BVoR+UY1ZBj0UHAFXsUOAU4umHg1k96VCOH2I/Is8bwpNwIorDmc+SLHdPmo6mmHGgtS 0WxDXXEKsHPnqUWkZZz0HjTDH8fj2352zTK5mu8LFH6bWMZTLRQ7w6w/jMam9X/c4+oH 1HDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485610; x=1703090410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TFco7o1FJMnx1yCq0brlp2BMzPyjFA1RTumvD/FNmTY=; b=S2LFplth19WPah4RrfbpTAWXnmLXFcNr5KJroXQ5zek9qvUAyEm1ebrA3mFISymWuo QIqCmEiEv6uyftvqm2vhOYxfIT/7QMGK9O7IF1nhpQI/6cHCZjRAYvz3VB58BJSE0qPA OG8G3aBcIUMOyb9LDHYWu7fLLTTYAKDUxcTPRfU7sYCsLd1lYdq+rCbT8p+WT0vzfbpM TvkSkDF+sSL53Drr0QGw6USWp9u7b4YcR8LBvzCzvthQqnTsqazfxH/PFWjV5yfe5APr CZLEXp6J2XsYvpuQO1cS1Krni6GrwRFF6HBMD0bVxifmPKbyVbn5sPwQEbFHMRa/swbo c99A== X-Gm-Message-State: AOJu0YyQ8nVt39N/xkG1bXOa8bJgCgvKOZXa5gLpGBzAv/jKyK7HjJEe nj4WrkmdxIvF3jh7sCxReYa2E9acanUGJY+kyqw= X-Google-Smtp-Source: AGHT+IERFmoMVxDWDNT6Kg+8oE+4Cxq3aLvRY11dwjq043RbWn6MvnE8nndh03dWRbglFnxqABbKnQ== X-Received: by 2002:a17:902:784a:b0:1d3:49ba:501a with SMTP id e10-20020a170902784a00b001d349ba501amr1616406pln.12.1702485609752; Wed, 13 Dec 2023 08:40:09 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v3 17/37] common/cnxk: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:51 -0800 Message-ID: <20231213163820.894987-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h index ba23b2e0d79e..9461f6e93304 100644 --- a/drivers/common/cnxk/roc_platform.h +++ b/drivers/common/cnxk/roc_platform.h @@ -265,11 +265,13 @@ extern int cnxk_logtype_tm; extern int cnxk_logtype_ree; extern int cnxk_logtype_dpi; -#define plt_err(fmt, args...) \ - RTE_LOG(ERR, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) -#define plt_info(fmt, args...) RTE_LOG(INFO, PMD, fmt "\n", ##args) -#define plt_warn(fmt, args...) RTE_LOG(WARNING, PMD, fmt "\n", ##args) -#define plt_print(fmt, args...) RTE_LOG(INFO, PMD, fmt "\n", ##args) +#define plt_log(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, cnxk_logtype_base, \ + "%s():%u " fmt "\n", __func__, __LINE__, ##args) +#define plt_err(fmt, ...) plt_log(ERR, fmt, ##__VA_ARGS__) +#define plt_info(fmt, ...) plt_log(INFO, fmt, ##__VA_ARGS__) +#define plt_warn(fmt, ...) plt_log(WARNING, fmt, ##__VA_ARGS__) +#define plt_print(fmt, ...) plt_log(INFO, fmt, ##__VA_ARGS__) #define plt_dump(fmt, ...) fprintf(stderr, fmt "\n", ##__VA_ARGS__) #define plt_dump_no_nl(fmt, ...) fprintf(stderr, fmt, ##__VA_ARGS__) @@ -278,8 +280,7 @@ extern int cnxk_logtype_dpi; */ #define plt_dbg(subsystem, fmt, args...) \ rte_log(RTE_LOG_DEBUG, cnxk_logtype_##subsystem, \ - "[%s] %s():%u " fmt "\n", #subsystem, __func__, __LINE__, \ -##args) + "[%s] %s():%u " fmt "\n", #subsystem, __func__, __LINE__, ##args) #define plt_base_dbg(fmt, ...) plt_dbg(base, fmt, ##__VA_ARGS__) #define plt_cpt_dbg(fmt, ...) plt_dbg(cpt, fmt, ##__VA_ARGS__) @@ -295,12 +296,13 @@ extern int cnxk_logtype_dpi; #define plt_dpi_dbg(fmt, ...) plt_dbg(dpi, fmt, ##__VA_ARGS__) /* Datapath logs */ -#define plt_dp_err(fmt, args...) \ - RTE_LOG_DP(ERR, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) -#define plt_dp_info(fmt, args...) \ - RTE_LOG_DP(INFO, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) -#define plt_dp_dbg(fmt, args...) \ - RTE_LOG_DP(DEBUG, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) +#define plt_dp_log(level, fmt, args...) \ + rte_log_dp(RTE_LOG_ ## level, cnxk_logtype_base, \ + "%s():%u " fmt "\n", __func__, __LINE__, ## args) + +#define plt_dp_err(fmt, ...) plt_dp_log(ERR, fmt, ##__VA_ARGS__) +#define plt_dp_info(fmt, ...) plt_dp_log(INFO, fmt, ##__VA_ARGS__) +#define plt_dp_dbg(fmt, ...) plt_dp_log(DEBUG, fmt, ##__VA_ARGS__) #ifdef __cplusplus #define CNXK_PCI_ID(subsystem_dev, dev) \ From patchwork Wed Dec 13 16:35:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135153 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C203436E3; Wed, 13 Dec 2023 17:40:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A4FA42F35; Wed, 13 Dec 2023 17:40:16 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 40CEF42F08 for ; Wed, 13 Dec 2023 17:40:11 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d045097b4cso41843495ad.0 for ; Wed, 13 Dec 2023 08:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485610; x=1703090410; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BA2FfLkWUPQIbr1OCO+cp1ahlWVd9ZHDkLCJVnmBTqM=; b=F4Xc780OBhqEbenNsZyy5B3lLnWWiY1gs5XD+8aMoESBR0SEo+76IQROhE0dgvx2J4 +RI3MLv5O4/x9ku8Ote13Q4XN12qQowvusDAhcEFqT72a9ne0ceJkacpYlLJJRgz7ie/ Oyfi4x6cymXy94pVhP0h4m4i4JbFsTtcFT9hfAicz0k6r0pCdE1+8q2XgKUg+7jZ665S o9zkspOnYn8tNwtI+vukLTnIqsnziKKUqCM4JwQ+ql4pKOmVpGjmeYVuPdAjVYMvM/oH FXTkqIG54+pAkWSrcUSbpZi12JzkunaD/9fJNs64GfYwCiBZcY9gs6L6b0MNdPjszPiM jpWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485610; x=1703090410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BA2FfLkWUPQIbr1OCO+cp1ahlWVd9ZHDkLCJVnmBTqM=; b=firab6kp0HP+zNjiZc++WbF+okdbSCKHsrgiqBzO33iv3JgQD6zaqGaERmtHK3dVt6 Y+pz7b0PkQWoC7F/VEb75jtX3I8PtU1A5a/pgCKGmn+4NE308sdWKAxzWSSq/2hfPeWO yTA5E4DNishs5fLpjmw9rrL8NcARWDNA3AMOpfL5UZctxbSC3jMBlVbbuTt/rJ71RalC JmSXHYo3gFl1FqaNo/p4iVvJh6yjrXRKJsC6P+gGJ1Fu9ab3b8UT81jaiNNBAeK94z/B bnIwrwHDDEzxdopxSIDvkZEZ30BOWbYyuVla0Sc0QiqWySr9T8/Dk/eKU0a5LiKRbNk3 xNJw== X-Gm-Message-State: AOJu0YxTJ511R3qnQE3uHJrrq95Q4LCarZGk6A16g6WkE/JK2gzSWJ76 siAZj6bFP3A1A1fZ1caupmP2006kDS9WxDj5Pjw= X-Google-Smtp-Source: AGHT+IHLXzOROIrzti2x7VvyvDI4RhVD294nuMFPSG5V/qu4EELjWFPhRkqbbHqqthWCO4z9YA1NrA== X-Received: by 2002:a17:902:c408:b0:1d1:c96a:c72 with SMTP id k8-20020a170902c40800b001d1c96a0c72mr6107497plk.49.1702485610497; Wed, 13 Dec 2023 08:40:10 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph Subject: [PATCH v3 18/37] common/cpt: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:52 -0800 Message-ID: <20231213163820.894987-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/cpt_pmd_logs.h b/drivers/common/cpt/cpt_pmd_logs.h index 174326c6ce38..6b78fcb6b6fc 100644 --- a/drivers/common/cpt/cpt_pmd_logs.h +++ b/drivers/common/cpt/cpt_pmd_logs.h @@ -34,7 +34,7 @@ * level of 'pmd' has to be used. */ #define CPT_LOG_DP(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt "\n", ## args) + rte_log_dp(RTE_LOG_ ## level, CPT_LOGTYPE, fmt "\n", ## args) #define CPT_LOG_DP_DEBUG(fmt, args...) \ CPT_LOG_DP(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:35:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135154 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E553C436E3; Wed, 13 Dec 2023 17:41:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F6A742F76; Wed, 13 Dec 2023 17:40:17 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 40B3442F19 for ; Wed, 13 Dec 2023 17:40:12 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d08a924fcfso66508995ad.2 for ; Wed, 13 Dec 2023 08:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485611; x=1703090411; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=; b=ZJc5XJwm+0GHKncaIENkbodbzpryHVSPi3cVrMPYs4hjGXWGIs4XCF/X3YmiP+EsVe +/mMrgR47vktA/z0nx2p5aZpAeCJaboneHLZfq+x/eSs24A8MVkBSCe0SYD8jLbKNPUu L82RCmJAeobswFgfVR8LCGIQ0UR5b+nW2DWsml4SKqeJZXiaLB3S26jegcuxgmUf0Ddg B+wzD6nd0KaNsBB85KaIlayowFK9DGSs6FLbvPBL/gUG2PZbZY6cbxHOnqiQg86ymhsm 7taSX0rfRuJ3D+Gkc6zPllpfmYTMApJMIw/BFX73NF71RfTvj7qJMyiznIOfUkLvXej0 Fzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485611; x=1703090411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=; b=CjRVXw71rAW+nmxYd0iqBR0v8RZT9K8nwUcGjqthlVqW3rvu/jvus8DDPnqPXKpBPQ 5vY4i2JKzfM9cxLty9aEEyO/f9LIXZqRCrVeTfaJi4jJUvOE3RTVhOVE8kAxpMP4vIDj 1Y5R/YW1D6CcALJqHEF1sB5MDJiW9YYMpRytA4jY2lNyAATXZZG8g75vnoW1kLCfIVc6 KNPGcfuSM12yf8dDXdoUS5WJMBpZmHr6TOeqp6feC9Vld0RyOWh88iIe53L0z6Ez1t+H cGZ9SWAOptSX6VvDm0ClPYqsG0z5//SFEOIRyzvytcw1A4NMFRA4Zirk+BsyJaRXpU8O XShw== X-Gm-Message-State: AOJu0YxrZ4HMIKCD6f+g2nUDGEtd8bdHpaQ2rH9Ho+sVfuGZ5/3h9bWV iXEeaHJrs6yYJm8Rz4f1E/+1QSXLHIQBTpg4UY0= X-Google-Smtp-Source: AGHT+IGYM2EKzmOzn+sLjuhwgSNdZvMVjPD4xz2pR8EpYZqvpCqR5KueSfNrWbYffnSQpMmfGZpvPA== X-Received: by 2002:a17:903:24e:b0:1d0:6ffd:e2e8 with SMTP id j14-20020a170903024e00b001d06ffde2e8mr9548743plh.130.1702485611474; Wed, 13 Dec 2023 08:40:11 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Subject: [PATCH v3 19/37] common/sfc_efx: remove use of PMD logtype Date: Wed, 13 Dec 2023 08:35:53 -0800 Message-ID: <20231213163820.894987-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++--------- drivers/common/sfc_efx/sfc_efx_log.h | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c index 2dc5545760b8..5eeffb065b0d 100644 --- a/drivers/common/sfc_efx/sfc_efx.c +++ b/drivers/common/sfc_efx/sfc_efx.c @@ -15,7 +15,7 @@ #include "sfc_efx_log.h" #include "sfc_efx.h" -uint32_t sfc_efx_logtype; +int sfc_efx_logtype; static int sfc_efx_kvarg_dev_class_handler(__rte_unused const char *key, @@ -117,11 +117,4 @@ sfc_efx_family(struct rte_pci_device *pci_dev, return rc; } -RTE_INIT(sfc_efx_register_logtype) -{ - int ret; - - ret = rte_log_register_type_and_pick_level("pmd.common.sfc_efx", - RTE_LOG_NOTICE); - sfc_efx_logtype = (ret < 0) ? RTE_LOGTYPE_PMD : ret; -} +RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE); diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h index 694455c1b14e..1519ebdc175f 100644 --- a/drivers/common/sfc_efx/sfc_efx_log.h +++ b/drivers/common/sfc_efx/sfc_efx_log.h @@ -11,7 +11,7 @@ #define _SFC_EFX_LOG_H_ /** Generic driver log type */ -extern uint32_t sfc_efx_logtype; +extern int sfc_efx_logtype; /** Log message, add a prefix and a line break */ #define SFC_EFX_LOG(level, ...) \ From patchwork Wed Dec 13 16:35:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135155 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D3E8436E3; Wed, 13 Dec 2023 17:41:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BA9642F7A; Wed, 13 Dec 2023 17:40:18 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id F409E42F1D for ; Wed, 13 Dec 2023 17:40:12 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d076ebf79cso41853455ad.1 for ; Wed, 13 Dec 2023 08:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485612; x=1703090412; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7nMm0M6rDFCtvM1w1fp0hwQRpMRypsEUoKyilyTJRmQ=; b=RCOxzV96o9hnigwxwQwXRqstc5TCcb0qMSXQrUCLwDzNCjLSYS7Dlif4tapYanIhfQ nqgjU/E8Rb0Xg2msO7s6kcQOHcV8g75jbQbNwKKp7T1s14ZJc1NCTnnkbQ4xFC+/rS4B inDGS/PDFQ+P+0q6BhFwW67x2sKiFqFNXqSjdTk5fausXiJKQH9HqPUYEojh6QGqHMj5 T90yhtEbaCnulNaZyYBF1uzvm2ACovOQ56aCNHDB9MHPcjelIX/Qm16jjhx/Ld61aJsQ rMyeChgHxwTrXGtKaPykbKDELbDu9EatHCZdyQns3LKelJUO9m+Fev+0MdqqRqqGopuS fcTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485612; x=1703090412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nMm0M6rDFCtvM1w1fp0hwQRpMRypsEUoKyilyTJRmQ=; b=Aezmgm2lBid1B+C+W6ucnXpIXdxmMx4+h8fE6EOrqx+F+a/dF9NLfnld+ERs6ryyWD 0nh5uPdYCQyQvFBD0mIzixEiLNGaUYEUIvMc2F/ycpfDQjDXKduRHhWIHaksww3isLBd E7eK7gatorg/Q7FyEeJ+YWZ5gBEs1FLmXI70jHTPC0k/9nr73ZSh9gbkcyiHc9JnolY5 //3L9Ck2uRjuu6OIkoyLMbF4AjLAIw8GcBB1P/8QfdpVf6Ec57h7Pn1Q5gSc3GIQf+2S mqCumYEi2QPU8I/aV86wP9x/H2RSB3dF0uwF+SflTKpWoI7QX/ID99G/8WtD3TgC9icb IYDg== X-Gm-Message-State: AOJu0YyxyyP6S6mkbnBT8QU0qyw+N8DTiwAdQPg2wZLtX1LjwYrRoIsa f0QR7RwVnE1SJMdH79b+IF4409qDDbn9f9yoFfs= X-Google-Smtp-Source: AGHT+IH9kAA4RMZia34SOR0+YKPKuOs1DfOCofQKJGWFgs5xDho7ymjq0U7YP44CHXECBn5SSU8Apg== X-Received: by 2002:a17:902:704c:b0:1d0:ab0e:9157 with SMTP id h12-20020a170902704c00b001d0ab0e9157mr4403726plt.128.1702485612210; Wed, 13 Dec 2023 08:40:12 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v3 20/37] common/dpaax: do not use PMD logtype Date: Wed, 13 Dec 2023 08:35:54 -0800 Message-ID: <20231213163820.894987-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use existing dpaax_logger log type instead of PMD. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/common/dpaax/caamflib/compat.h | 5 ++++- drivers/common/dpaax/dpaax_logs.h | 2 +- drivers/common/dpaax/version.map | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/common/dpaax/caamflib/compat.h b/drivers/common/dpaax/caamflib/compat.h index 9776eed437ad..64ccdca95058 100644 --- a/drivers/common/dpaax/caamflib/compat.h +++ b/drivers/common/dpaax/caamflib/compat.h @@ -40,11 +40,14 @@ #define __maybe_unused __rte_unused #endif +extern int dpaax_logger; + #if defined(SUPPRESS_PRINTS) #define pr_msg(l, fmt, ...) do { } while (0) #else #define pr_msg(l, fmt, ...) \ - RTE_LOG(l, PMD, "%s(): " fmt "\n", __func__, ##__VA_ARGS__) + rte_log(RTE_LOG_ ## l, dpaax_logger, "%s(): " fmt "\n", \ + __func__, ##__VA_ARGS__) #endif #if !defined(pr_debug) diff --git a/drivers/common/dpaax/dpaax_logs.h b/drivers/common/dpaax/dpaax_logs.h index 180476f6757c..cec99a674056 100644 --- a/drivers/common/dpaax/dpaax_logs.h +++ b/drivers/common/dpaax/dpaax_logs.h @@ -37,7 +37,7 @@ extern int dpaax_logger; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAAX_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaax_logger, fmt, ## args) #define DPAAX_DP_DEBUG(fmt, args...) \ DPAAX_DP_LOG(DEBUG, fmt, ## args) diff --git a/drivers/common/dpaax/version.map b/drivers/common/dpaax/version.map index ee1ca6801c81..d48a6b6f37ee 100644 --- a/drivers/common/dpaax/version.map +++ b/drivers/common/dpaax/version.map @@ -6,6 +6,7 @@ INTERNAL { dpaax_iova_table_p; dpaax_iova_table_populate; dpaax_iova_table_update; + dpaax_logger; of_device_is_available; of_device_is_compatible; of_find_compatible_node; From patchwork Wed Dec 13 16:35:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135156 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 405ED436E3; Wed, 13 Dec 2023 17:41:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BC9F42F51; Wed, 13 Dec 2023 17:40:19 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 9BF1F42F33 for ; Wed, 13 Dec 2023 17:40:13 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d30141d108so19258445ad.2 for ; Wed, 13 Dec 2023 08:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485613; x=1703090413; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uFLC1YO9VGRJYwuCy1kfDo4mjHA+SztV29PYYmxPQjE=; b=xTAH5HLlqb6UUdk+vahK2pJMd0IiyPsLGDYeED/XVCGwqwz4jdmMG7cWaD0m5tDnol uKIEpeY6c1oRgKX9Hx+lVpHizksxXZ50mHx3Nn+uPIVcmUSLfqNm0EEoJjQa5WuIo0ps FdQxTriX5PvelWkIeQH1viWNp9moY6eON4SNYLrBGLfhfj5FSx/5w4hLjzQJFamHyAVQ td5vLHfWUtPytQifaQ20JxIdG1uh6HFbk3yZMSGfToyDFRRbjd+3soWRRtI2d7m6erbN rFNOvFvgIOhCKkglYI2u+OKCcHD4CrqBnEELBWueCFGG6VLnCJUa3jf7VCbU6Zf0Rleu sGxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485613; x=1703090413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uFLC1YO9VGRJYwuCy1kfDo4mjHA+SztV29PYYmxPQjE=; b=OUAydtibkNGEOxMgbyauRGUitN4AwD0L6c1sFQUEZ97A0LvYSY61d/tmHvBt7g4G+L H+kc0InxyWgF+UcAzMemxSJKUcC5gRyxYmdINKk1QbwCa7IhMGuzEc2BWL32eHZIfiK5 R+mp/QHVdISGavVRx61CiaQTm+LxjOaSQdEMRahsUlUwRJ+DD/u4FN21Q1Ik4BapMVEU AsEotZe5MV24ljMbc+Tjgy0iAWVBHkZSkz8ksR3yT1GjQm7mjeNQrlJScPHiKq3M1cbL XQ17S3QVliZsYmTcb0w7zb8xTftjhjbJoeSqtnjJpcKgtuV1kF7tw8dg0255o6i/buRi kZXA== X-Gm-Message-State: AOJu0YxQANb1UVnnasxHpiRf7FZj5Ci6lJ1k2YFOxb4w05vC08dophDH G6YolV3a8V+7K+BCgMUx7dyjdTPDVDPx3xpOS+c= X-Google-Smtp-Source: AGHT+IGvA/8VR2jSJsn+MjmByX8+esTF1rYGuyY8JS8P0SHlp3CXLtxijw+eWqI5+50aCOA+Rh56iA== X-Received: by 2002:a17:902:dac6:b0:1d3:4cb1:73b9 with SMTP id q6-20020a170902dac600b001d34cb173b9mr653298plx.48.1702485612926; Wed, 13 Dec 2023 08:40:12 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH v3 21/37] basband/la12xx: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:55 -0800 Message-ID: <20231213163820.894987-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h b/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h index 452435ccb942..922eb601c61c 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h +++ b/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h @@ -23,6 +23,6 @@ extern int bbdev_la12xx_logtype; /* DP Logs, toggled out at compile time if level lower than current level */ #define rte_bbdev_dp_log(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, bbdev_la12xx_logtype, fmt, ## args) #endif /* _BBDEV_LA12XX_PMD_LOGS_H_ */ From patchwork Wed Dec 13 16:35:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135157 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E149C436E3; Wed, 13 Dec 2023 17:41:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D3B842F85; Wed, 13 Dec 2023 17:40:20 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 798D942F4D for ; Wed, 13 Dec 2023 17:40:14 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d06d42a58aso66567705ad.0 for ; Wed, 13 Dec 2023 08:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485614; x=1703090414; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YPerP6snJvhhCTK5sfPtiDgVGA/TBfvrj/n4xK6/JDI=; b=DXHE3WX3Y9GZyeL/TeDzRgmdQi6DkwjEvfVCUk6YY2cyM7RAvd+jNGfzTWEHpD8U4a vVpsTrx1Z7G6ILt4A1ZyDheoNra3mY3Zp1Op+C/3Aec2eMKU9N3VVpttj+EwnlKklkC+ cRDqgdVhxvXGqkEcZzjM8RzlUDQbnUBzz4CMsRF1t+FthFFDPOM4loHl4hMjnxBEGwmH do8G3u0z4i16+mfpvx/meSIMwRuyeo9iRGW+fbyfvBi4MCcDWFZjETsfbvspxuCTU5rh LLnRiNblUlVre8mEhBs2Q/o9fPmVMhNVVAbKank0Z/ZUkGUODh/qpZQXDNiHSqRq06QG DFkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485614; x=1703090414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YPerP6snJvhhCTK5sfPtiDgVGA/TBfvrj/n4xK6/JDI=; b=tYI6hZOxjZ20R8mlpz6c28Tx6aSjQzx4sFQnaQIeDQQ0x+y65OfLCoOtdCJahdX3xa 6DzQyITucHqp1JKdzrsRkuDx3FOm1qJHcXbuuAQl08Mf9twIkE1/p7kc1MRTC3AhpjPS OSoXPsUsaGt/up00LhSu1zvcrHFFsuKYVz+rV/nYCM0c7Ptl4/O0GH6ehxjJypVfuha/ f+nIytzPticbz97b7nMUrqPN9pxDxBtpwH/aW5dyXqoVYT1h50S7ewm7ef+NjmN+3+8E U9INzcVpma2jnvESNZhBC6wrtEgEqfoqlcob61IrZK0kvMOra5oMMhDmBm2luYBd7g7z A4GA== X-Gm-Message-State: AOJu0YzRWz7BhzIYAZ18Zkq7ujiEA6peFmoLz4/Yb8WX/hLw8YWJGeJg /MqPkzYg3ceMdKfYHMlt5jZT3cRriuiTLy9W9jQ= X-Google-Smtp-Source: AGHT+IF5dmLEJyAc2rW7Gmkx4ScZ4zzx4LtKv5gHPjbJDZ0KvC6K3S6HCgign/lEJpZg3MAPqOFJuw== X-Received: by 2002:a17:902:e88f:b0:1d0:6ffd:e2da with SMTP id w15-20020a170902e88f00b001d06ffde2damr9564055plg.116.1702485613711; Wed, 13 Dec 2023 08:40:13 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:13 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nipun Gupta , Nikhil Agarwal Subject: [PATCH v3 22/37] bus/cdx: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:56 -0800 Message-ID: <20231213163820.894987-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/cdx/cdx_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/cdx/cdx_logs.h b/drivers/bus/cdx/cdx_logs.h index a1046ce544a6..e432fae00e4d 100644 --- a/drivers/bus/cdx/cdx_logs.h +++ b/drivers/bus/cdx/cdx_logs.h @@ -25,7 +25,7 @@ extern int cdx_logtype_bus; /* DP Logs, toggled out at compile time if level lower than current level */ #define CDX_BUS_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + RTE_LOG_DP(level, cdx_logtype_bus, fmt, ## args) #define CDX_BUS_DP_DEBUG(fmt, args...) \ CDX_BUS_DP_LOG(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:35:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135158 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD65C436E3; Wed, 13 Dec 2023 17:41:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8A9942F8F; Wed, 13 Dec 2023 17:40:21 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 35B8442F6B for ; Wed, 13 Dec 2023 17:40:15 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d04c097e34so56730375ad.0 for ; Wed, 13 Dec 2023 08:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485614; x=1703090414; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xPEblhQb9M4Oi32obLBBF+BdzSVziM9yWLWPzWVXy8U=; b=BBZxWcHU/dg7OM9PMtGHdZYCxC/aKS9VnTyWPkCj89zlXkEWnqBpvrsJ282QXJPeXb YWMkj+/hRdIzu9ANBVBrC3txlSUkhq/Nvfv1P27XhWzBv795Q3nXBvqIB242oeUAMaQJ zhbMuFaFUX/j60D7/BvjvOrFUfIwt652vs0slCani9cTlEWmn25IDYUNvCl9zER8KKec nt6GpTilphZz9Z4rBQgK1cZ+XAJAtg4icIfOR5LOLLnjAfxGOf7qnI1dYvwBEWMWh2th R5Oq1ll2pHRSaNH1lNamrgzrP9LaxEj6syMW8jj4io5gKf1F/IToOE69Mdm8jYbE0Tbw mtlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485614; x=1703090414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xPEblhQb9M4Oi32obLBBF+BdzSVziM9yWLWPzWVXy8U=; b=nuxyosgMA/PdpWMyJIcgKps+SYwUXz0Vjl3YVtXNkx+KxxIi1M2tIhSin+4m6mwfk5 dWO4rc1uuhJNxg1eNc5d+A+J9TM+N8c7yijqy+lsNtzgRCdSSkEh4aEdLni6ehcv+VHv FhRPP4ciRXJfm4aZ9FjAG6wBgo9dRc4RS06KunIoWylXO9uNwU5sLQKUXHG5sc4i7Nzt YOUw5TI3Gay0u+VpyC/bczwql4d5Uw1K2PaI78t9QCxiI+iiw1j+WEzHbk9E2yOne22Z 9WudsCrIBgwfqJf+6lTdGusQZjkuDv2Ozoi35W8W54zoHX3fF9j20m4NUFgqybbrpCJe UBhw== X-Gm-Message-State: AOJu0YwMS6NVW9oPu8BiSVK/85Wa9gzDv0imeBp+xi0Dj/YsvQAezY6C z5S1jUpB7qFQ6hh/Gc9ynZT2ejuw4pzDPIGSxG0= X-Google-Smtp-Source: AGHT+IEEmsXO9H+jZu0lbdx4CBN9MbF/vcbi0NOYhWdzODcB1VdfmejpI1bHd4nie5F6WRS/eGAEyQ== X-Received: by 2002:a17:902:a511:b0:1d0:6ffd:6112 with SMTP id s17-20020a170902a51100b001d06ffd6112mr7607730plq.52.1702485614479; Wed, 13 Dec 2023 08:40:14 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v3 23/37] bus/fslmc: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:57 -0800 Message-ID: <20231213163820.894987-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index a1e14dd84e9a..edd74af04d7c 100644 --- a/drivers/bus/fslmc/fslmc_logs.h +++ b/drivers/bus/fslmc/fslmc_logs.h @@ -27,7 +27,7 @@ extern int dpaa2_logtype_bus; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_BUS_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + RTE_LOG_DP(level, dpaa2_logtype_bus, fmt, ## args) #define DPAA2_BUS_DP_DEBUG(fmt, args...) \ DPAA2_BUS_DP_LOG(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:35:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135159 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65A1A436E3; Wed, 13 Dec 2023 17:41:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C40542F99; Wed, 13 Dec 2023 17:40:23 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 0654342F35 for ; Wed, 13 Dec 2023 17:40:16 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d2eb06ab11so31326485ad.1 for ; Wed, 13 Dec 2023 08:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485615; x=1703090415; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jm6n/Nl4TEEqxqEX4TXEaP4f/5o/8ZaN/h0MBwErqpw=; b=JOMSD77pgu5qQQbs0Yy4dp0Vg0/X4uMi0qpvtLWdZ7SvbZ/tEk7hgcZiiC/qQiNyCj MBGQMawLwrppPKgkegXD0i8L5LFZj0fZEbk9o/Zt+GTJOMKKgwFGB5URpIeGF5b7MuNn a4JEaSSpTNI2R95PBLGLOhwL0GKXedZzRfppxhuKClSlVzE2S7otF69elsASs4cn36nM DpCSnCkhoVwaKwfXVzTCGU6jFWaWZ5S7icwJ9UB5zWFOUkEaHsIiE95iwdymZGkgRyQj a3lsTugoLmuAHeIZmnlqjzz1z0sxVk7rM9g0lNCa29YuwLFjrhSBQC0lcxtqzIC4E7ro 4kzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485615; x=1703090415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jm6n/Nl4TEEqxqEX4TXEaP4f/5o/8ZaN/h0MBwErqpw=; b=haeHagcLg3NCDyJFbPrqVG2buoueCtw/5zItV3/jDFdjxSUQwAJ6WFztzKD1blo15n //JsxMryIPVpd6DyMwmlViU83ejQIXF3pRV/K0eCDwSkrWjBusNM75tRNjK1g6X3uKHX bZLOTuJILA1G2Z0NZPnpJRER5khvM1xKK4LbluVYMbugkxp6V8HW5+urwNFaCJeBqWXr 6gQzynBkIz4Y8vjlqPr5VH/0AkfLKmIg/6u23qNOrI6W2avDgh7epwEYoHvFvyewzx8h Zrt0yJXZmy6U/GxwRSRpszdZHmvQQTNxwFP3Xu8xhyLmh50rlM3UmTU74IaIEmh83GDj gNtg== X-Gm-Message-State: AOJu0Yy6a9EsHNYw6kIPYPFikWPF0xJyb/GFe0iT8hhKOSBxsdW8wkGW YP7FKdy9GIC5gpYAiNOtEq2IuaibxZFehXh53KA= X-Google-Smtp-Source: AGHT+IH0S68EXiHBo4woLagey1PMR6Kmc8Pd3g/8LRebtiv0j/wlH1ZdXx7iVGR5+7BIWhw4oq6Azg== X-Received: by 2002:a17:902:e5c7:b0:1d1:cd8b:8bb4 with SMTP id u7-20020a170902e5c700b001d1cd8b8bb4mr5078659plf.50.1702485615277; Wed, 13 Dec 2023 08:40:15 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Sachin Saxena , Hemant Agrawal Subject: [PATCH v3 24/37] dma/dpaa, dma/dpaa2: replace RTE_LOG_DP with rte_log_dp Date: Wed, 13 Dec 2023 08:35:58 -0800 Message-ID: <20231213163820.894987-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/dma/dpaa/dpaa_qdma_logs.h | 5 +++-- drivers/dma/dpaa2/dpaa2_qdma_logs.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma_logs.h b/drivers/dma/dpaa/dpaa_qdma_logs.h index 762598f8f72f..169fbf364265 100644 --- a/drivers/dma/dpaa/dpaa_qdma_logs.h +++ b/drivers/dma/dpaa/dpaa_qdma_logs.h @@ -25,8 +25,9 @@ extern int dpaa_qdma_logtype; DPAA_QDMA_LOG(WARNING, fmt, ## args) /* DP Logs, toggled out at compile time if level lower than current level */ -#define DPAA_QDMA_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, "dpaa_qdma: " fmt "\n", ## args) +#define DPAA_QDMA_DP_LOG(level, fmt, args...) \ + rte_log_dp(RTE_LOG_ ## level, dpaa_qdma_logtype, \ + "dpaa_qdma: " fmt "\n", ## args) #define DPAA_QDMA_DP_DEBUG(fmt, args...) \ DPAA_QDMA_DP_LOG(DEBUG, fmt, ## args) diff --git a/drivers/dma/dpaa2/dpaa2_qdma_logs.h b/drivers/dma/dpaa2/dpaa2_qdma_logs.h index a46b8f24b5a7..52514c2dcc91 100644 --- a/drivers/dma/dpaa2/dpaa2_qdma_logs.h +++ b/drivers/dma/dpaa2/dpaa2_qdma_logs.h @@ -30,7 +30,8 @@ extern int dpaa2_qdma_logtype; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_QDMA_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, "dpaa2_qdma: " fmt "\n", ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa2_qdma_logtype, \ + "dpaa2_qdma: " fmt "\n", ## args) #define DPAA2_QDMA_DP_DEBUG(fmt, args...) \ DPAA2_QDMA_DP_LOG(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:35:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135160 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8802C436E3; Wed, 13 Dec 2023 17:41:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 727B842FA9; Wed, 13 Dec 2023 17:40:24 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id B0E2E42F73 for ; Wed, 13 Dec 2023 17:40:16 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d3470496e2so14204175ad.1 for ; Wed, 13 Dec 2023 08:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485616; x=1703090416; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LJu1xzr5/YTKSJkQWaC4l9kNWloTeFCEaesv/sU/wk0=; b=lq6AzIREcTGHjMPzcey25jtaT1Rs6sbmNy+KOs4evtrx91INiBtUSbAKHOH4BSeyQi 10fWyDaVIifQfQ/ZzN09W9BIFUV42BAKOUh6bF43webC5HIz+Mi6rI/1d7CNmMrOBuFz ene8mBxzb1rZEsywg3GtHJ+Gr/vLElDqa3HnqlLyuQFHsTYdFghIWQGMWxDnKdBy7d4Q WAWoOzSVU4pyq51UKttUSqFVF8OpS2iY2YdcNh+HXtBzqN7HxO+jYX2p8cXuEP/o0ruM T1JyZVKumSkxm76uiL+zZqzmsIPIz4uKoLqxiBF46FfPK58m1lr2skP1JEVCz7udby3G 1g6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485616; x=1703090416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LJu1xzr5/YTKSJkQWaC4l9kNWloTeFCEaesv/sU/wk0=; b=LooKbI1wUYZ5iRB4gqYxpCznmIGpb949ncGlZ99GwSUfMy4XKJDr74zwuqg4Oy6qFX 7S0MRGM+f3pIwEH+SzjsmTaHCXkCjg9OnUJlFLlVtFOmTvl8787IEgBZcJeOSFjQZ8nQ AFuOp/zaY/ReZiARTtHtDKHwIdpdPfawG8DrWMM39d18YiKIApQxdm8IU3OYH1lsYpeZ Xhqr1IUasXs/alo7zPsUGBH1hwMBeNs5oEreZ72ogDxDw91OClEk3XNA5v+bIc3tczwe 8W8BJGrQKAJRHuJNLg5I6c961JqRfMnz+dewS7mk5KJVVZHATSPPqQnSlPgOqt0GpUVm mMtg== X-Gm-Message-State: AOJu0Yy6EgkgfGx0hr5FPFqtmTaTupvLxbBx2OaMaq8TnTlwchZHqv/L WXj2Z+z4Hyfyn1BJXmC5g+vdWgMJ3E2xHSV5iuA= X-Google-Smtp-Source: AGHT+IFCkQyFo8rr9EX9P0spudHWKRpevKUcpySZvuuMhnXC3qAqJSLPSD20JXKELlSOQW0tcrnrNg== X-Received: by 2002:a17:903:22c7:b0:1d0:7965:f530 with SMTP id y7-20020a17090322c700b001d07965f530mr8407094plg.88.1702485616000; Wed, 13 Dec 2023 08:40:16 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:15 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v3 25/37] mempool/dpaa, mempool/dpaa2: do not use logtype PMD Date: Wed, 13 Dec 2023 08:35:59 -0800 Message-ID: <20231213163820.894987-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver already has a logtype, just not consistently used. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.h | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.h b/drivers/mempool/dpaa/dpaa_mempool.h index 3f0eafa7dd7b..ca97da46910c 100644 --- a/drivers/mempool/dpaa/dpaa_mempool.h +++ b/drivers/mempool/dpaa/dpaa_mempool.h @@ -67,7 +67,7 @@ extern struct dpaa_bp_info *rte_dpaa_bpid_info; #define MEMPOOL_INIT_FUNC_TRACE() DPAA_MEMPOOL_LOG(DEBUG, " >>") #define DPAA_MEMPOOL_DPDEBUG(fmt, args...) \ - RTE_LOG_DP(DEBUG, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_DEBUG, dpaa_logtype_mempool, fmt, ## args) #define DPAA_MEMPOOL_DEBUG(fmt, args...) \ DPAA_MEMPOOL_LOG(DEBUG, fmt, ## args) #define DPAA_MEMPOOL_ERR(fmt, args...) \ diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 84371d5d1abb..e3983d34c25c 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -293,7 +293,7 @@ rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp) bp_info = mempool_to_bpinfo(mp); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); + DPAA2_MEMPOOL_LOG(ERR, "DPAA2 buffer pool not configured\n"); return -ENOMEM; } @@ -307,7 +307,7 @@ rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr) bp_info = mempool_to_bpinfo(mp); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); + DPAA2_MEMPOOL_LOG(ERR, "DPAA2 buffer pool not configured"); return NULL; } diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h b/drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h index 986264319623..2f4fe0ba4209 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h @@ -25,7 +25,7 @@ extern int dpaa2_logtype_mempool; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_MEMPOOL_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa2_logtype_mempool, fmt, ## args) #define DPAA2_MEMPOOL_DP_DEBUG(fmt, args...) \ DPAA2_MEMPOOL_DP_LOG(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:36:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135161 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDD6F436E3; Wed, 13 Dec 2023 17:41:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DD5842FAD; Wed, 13 Dec 2023 17:40:25 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 782B842F79 for ; Wed, 13 Dec 2023 17:40:17 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d345b187bbso14961415ad.0 for ; Wed, 13 Dec 2023 08:40:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485616; x=1703090416; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a+EUxTi++V2AI8QEzuBAtt/lqNXDgxcYRnbREuTh0RQ=; b=CRbpUPxPa5uveZQAMzmpNiojfKe0PK3bf+tR9YXS408pBjDSug9G0ja3BpvD2AJ4ig 2Oh4jJ6kWvorFlQhn+QAKq0ufN7Wpg08YOAggoRoEs64XEgL7DoIid+4pss9iOmI/kFg zCeiDCyPKDLaklePMyG5TORxvhaJl5TS4RF390gCp2J5RQZHfNqyeB/uIf/8TVKvGLpi juWXvLY2cTbgRwA/NNStCMaFvfp/4L3YPvo6bWSjaRUnRbuQRM5rT2EVBJDQ8S4NpfJU FdjvXZyM2LWGOW7zvsUhd2Nf7nEbX/vCk2qzUQ+nCyqhNRPUB4og0b7nc7MIaxcsjO/y I8mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485616; x=1703090416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a+EUxTi++V2AI8QEzuBAtt/lqNXDgxcYRnbREuTh0RQ=; b=S4ozbsR7GvfiJ5S/VZVHHFk0fDmUj1kgmjH8su1F+2RT5XJiGnxbpyNcE2/EeI51/h 3x9LnmjQwt4I9IQpdreU88wPdOQAGw52qkFEO3J+PWUUA86ZiVR9C5H+TrEGhhAU1aKh MgZkoUOPR0vpKtoUWgaT2Yom7AQXKIZ56dWVVgMmRQJWDYTHQ+VxALcQovx5gZGqjfai Mzhrnb1vke5rnaNz9GS166I4E/fIDNAaWNRI6rT1RY8842dXpcgkpEgxR81O0qsWkfsO /MlykbPIKsLlUIBMYJST9d2DNfOEQX06yoEdOG+5vmTTw0P/DRBLHS4nNUXtw+R+o0aR 59Og== X-Gm-Message-State: AOJu0YztpWYs/niDvDxayA9tU+zL3UkU01/Hbu3iBVxnLcZnhYkW/xgP z23Da8B8UaRzV83EneHUt7XD8zf+ej6rNPXugkI= X-Google-Smtp-Source: AGHT+IGV/tZ+vuoicu4V2lmZemGTVGtY5RF/CTUfHbW2CV7BJBGfGUf9GUIeVUIOdVwMApPvQBnt9g== X-Received: by 2002:a17:903:32c8:b0:1d0:5806:f45d with SMTP id i8-20020a17090332c800b001d05806f45dmr9023938plr.42.1702485616679; Wed, 13 Dec 2023 08:40:16 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Xiao Wang Subject: [PATCH v3 26/37] vdpa/ifc: replace use of RTE_LOGTYPE_PMD Date: Wed, 13 Dec 2023 08:36:00 -0800 Message-ID: <20231213163820.894987-27-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This driver is using RTE_LOGTYPE_PMD, fix to have a dynamic type. Signed-off-by: Stephen Hemminger --- drivers/vdpa/ifc/base/ifcvf.c | 14 +++++++------- drivers/vdpa/ifc/base/ifcvf_osdep.h | 9 +++++++-- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c index 53e982a52e9d..d8c1595cdb02 100644 --- a/drivers/vdpa/ifc/base/ifcvf.c +++ b/drivers/vdpa/ifc/base/ifcvf.c @@ -224,11 +224,10 @@ ifcvf_enable_mq(struct ifcvf_hw *hw) if (mq_cfg) { if (hw->device_type == IFCVF_BLK) { *(u32 *)mq_cfg = nr_queue; - RTE_LOG(INFO, PMD, "%d queues are enabled\n", nr_queue); + IFCVF_LOG(INFO, "%d queues are enabled", nr_queue); } else { *(u32 *)mq_cfg = nr_queue / 2; - RTE_LOG(INFO, PMD, "%d queue pairs are enabled\n", - nr_queue / 2); + IFCVF_LOG(INFO, "%d queue pairs are enabled", nr_queue / 2); } } } @@ -246,7 +245,7 @@ ifcvf_enable_vring_hw(struct ifcvf_hw *hw, int i) cfg = hw->common_cfg; if (!cfg) { - RTE_LOG(ERR, PMD, "common_cfg in HW is NULL.\n"); + IFCVF_LOG(ERR, "common_cfg in HW is NULL."); return -1; } @@ -258,8 +257,7 @@ ifcvf_enable_vring_hw(struct ifcvf_hw *hw, int i) IFCVF_WRITE_REG16(i + 1, &cfg->queue_msix_vector); msix_vector = IFCVF_READ_REG16(&cfg->queue_msix_vector); if (msix_vector == IFCVF_MSI_NO_VECTOR) { - RTE_LOG(ERR, PMD, "queue %d, msix vec alloc failed\n", - i); + IFCVF_LOG(ERR, "queue %d, msix vec alloc failed", i); return -1; } } @@ -307,7 +305,7 @@ ifcvf_disable_vring_hw(struct ifcvf_hw *hw, int i) cfg = hw->common_cfg; if (!cfg) { - RTE_LOG(ERR, PMD, "common_cfg in HW is NULL.\n"); + IFCVF_LOG(ERR, "common_cfg in HW is NULL."); return; } @@ -531,3 +529,5 @@ ifcvf_get_queue_notify_off(struct ifcvf_hw *hw, int qid) return (u8 *)hw->notify_addr[qid] - (u8 *)hw->mem_resource[hw->notify_region].addr; } + +RTE_LOG_REGISTER_DEFAULT(ifcvf_logtype, INFO); diff --git a/drivers/vdpa/ifc/base/ifcvf_osdep.h b/drivers/vdpa/ifc/base/ifcvf_osdep.h index dd2ff08f77cc..7100a8b968a4 100644 --- a/drivers/vdpa/ifc/base/ifcvf_osdep.h +++ b/drivers/vdpa/ifc/base/ifcvf_osdep.h @@ -13,8 +13,13 @@ #include #include -#define WARNINGOUT(S, args...) RTE_LOG(WARNING, PMD, S, ##args) -#define DEBUGOUT(S, args...) RTE_LOG(DEBUG, PMD, S, ##args) +extern int ifcvf_logtype; + +#define IFCVF_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, ifcvf_logtype, fmt "\n", ## args) + +#define WARNINGOUT(S, args...) IFCVF_LOG(WARNING, S, ##args) +#define DEBUGOUT(S, args...) IFCVF_LOG(DEBUG, S, ##args) #define STATIC static #define msec_delay(x) rte_delay_us_sleep(1000 * (x)) From patchwork Wed Dec 13 16:36:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135162 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF3CE436E3; Wed, 13 Dec 2023 17:41:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9276342FB7; Wed, 13 Dec 2023 17:40:26 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 2F1D842F79 for ; Wed, 13 Dec 2023 17:40:18 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d331f12f45so14817325ad.2 for ; Wed, 13 Dec 2023 08:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485617; x=1703090417; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oazGRehyaV7lEhIuAA2jjOuXmN7/tVDcDYpfuj/uPes=; b=QAv7XduiRjLCV2LiLXMWaxabhRZUlTJUkx0pFo+Os76xrD3XV/3zm7usDlmPo1ibtq wNAilkmPtEHgj6SLF7zJvuT/cIbkXd0VTpO/S7ebm5KLHdD4JeHgoqocmHL6eRTAGjpf QHmlxeuBB7yzNliY93WVADzbEIIbvDItzB+mCnyMHNJkTt2dAwfhf3TxU15adGnviR2z 7hX7jS/9/aAK5++7GBM1NIrSMT2qPAvdB139+0qhinyUxiR+up/uU1ir5XcvrfgYNj5d q19I6eT2HRhFIi3D1OD4DcUV5NTZg4EqimP2TJaTomEyQ72TGN5rM7svTk1Xcn8nXkIw 1bwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485617; x=1703090417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oazGRehyaV7lEhIuAA2jjOuXmN7/tVDcDYpfuj/uPes=; b=un/jaOKSt4hrjiQIAIl+2sdCBYO4j+A+RsTwpNBE2OP9CdDxAr7DmolzFPtKslpNA4 up9wSFBTA5urVFQzxoUg1d6vApQCM6QTG+MylPGK/UdgSvqqGNjoNEvrHuCHfTWd0MjC lp0u9uKY02WasF4tmswV/OburKRsxZgvAoOjuow1yPUqDkuYi30NWJvZh78qVlp7PKK8 Xv6+KWCMCcbuzT0bJ7tumCeVpWRbjPJqh1gwx/TEhVjrNVYqzgKnXu01Z/PLgDdjLViP d4qRJUsprqajDZK31EpBHdD990d5xbp2kQ2+NcnQ10wxKuKfY3mPWqoy8Emv/Idctu0C RZ2w== X-Gm-Message-State: AOJu0YxxzTx3jD9rPPlXsGNzHzATT9YeTtf77mKu4k933RniTTAeIiPs eszK7DoPBBVxLS7hq1BTjxoujn4aPvDTYpBqmeM= X-Google-Smtp-Source: AGHT+IGgjjIeWtp6g9Dfmo0RhkeILn8ICgSqTstWsnr3yfZq8GAzlnkz40dzJ4Tp6V57TuETCX/yQQ== X-Received: by 2002:a17:903:40c8:b0:1d3:49fc:b780 with SMTP id t8-20020a17090340c800b001d349fcb780mr949512pld.78.1702485617422; Wed, 13 Dec 2023 08:40:17 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Palider , Tomasz Duszynski Subject: [PATCH v3 27/37] raw/cnxk_bphy: replace PMD logtype with dynamic type Date: Wed, 13 Dec 2023 08:36:01 -0800 Message-ID: <20231213163820.894987-28-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 31 +++++++++++----------- drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 5 ++++ 4 files changed, 23 insertions(+), 18 deletions(-) diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c index 15dbc4c1a637..f1c14125d5c5 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c @@ -251,7 +251,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev, /* get rid of last response if any */ if (qp->rsp) { - RTE_LOG(WARNING, PMD, "Previous response got overwritten\n"); + BPHY_LOG(WARNING, "Previous response got overwritten"); rte_free(qp->rsp); } qp->rsp = rsp; @@ -410,3 +410,4 @@ static struct rte_pci_driver cnxk_bphy_rawdev_pmd = { RTE_PMD_REGISTER_PCI(bphy_rawdev_pci_driver, cnxk_bphy_rawdev_pmd); RTE_PMD_REGISTER_PCI_TABLE(bphy_rawdev_pci_driver, pci_bphy_map); RTE_PMD_REGISTER_KMOD_DEP(bphy_rawdev_pci_driver, "vfio-pci"); +RTE_LOG_REGISTER_DEFAULT(bphy_logtype, INFO); diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c index 2d8466ef918b..b2e8fc0e5c6f 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c @@ -189,7 +189,7 @@ cnxk_bphy_cgx_process_buf(struct cnxk_bphy_cgx *cgx, unsigned int queue, /* get rid of last response if any */ if (qp->rsp) { - RTE_LOG(WARNING, PMD, "Previous response got overwritten\n"); + BPHY_LOG(WARNING, "Previous response got overwritten"); rte_free(qp->rsp); } qp->rsp = rsp; diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c index a3021b4bb7db..148ee551ead1 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c @@ -57,62 +57,61 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id) if (ret) break; if (descs != 1) { - RTE_LOG(ERR, PMD, "Wrong number of descs reported\n"); + BPHY_LOG(ERR, "Wrong number of descs reported"); ret = -ENODEV; break; } - RTE_LOG(INFO, PMD, "Testing queue %d\n", i); + BPHY_LOG(INFO, "Testing queue %d", i); ret = rte_pmd_bphy_cgx_stop_rxtx(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to stop rx/tx\n"); + BPHY_LOG(ERR, "Failed to stop rx/tx"); break; } ret = rte_pmd_bphy_cgx_start_rxtx(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to start rx/tx\n"); + BPHY_LOG(ERR, "Failed to start rx/tx"); break; } ret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, false); if (ret) { - RTE_LOG(ERR, PMD, "Failed to set link down\n"); + BPHY_LOG(ERR, "Failed to set link down"); break; } ret = cnxk_bphy_cgx_link_cond(dev_id, i, 0); if (ret != 0) - RTE_LOG(ERR, PMD, - "Timed out waiting for a link down\n"); + BPHY_LOG(ERR, "Timed out waiting for a link down"); ret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, true); if (ret) { - RTE_LOG(ERR, PMD, "Failed to set link up\n"); + BPHY_LOG(ERR, "Failed to set link up"); break; } ret = cnxk_bphy_cgx_link_cond(dev_id, i, 1); if (ret != 1) - RTE_LOG(ERR, PMD, "Timed out waiting for a link up\n"); + BPHY_LOG(ERR, "Timed out waiting for a link up"); ret = rte_pmd_bphy_cgx_intlbk_enable(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to enable internal lbk\n"); + BPHY_LOG(ERR, "Failed to enable internal lbk"); break; } ret = rte_pmd_bphy_cgx_intlbk_disable(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to disable internal lbk\n"); + BPHY_LOG(ERR, "Failed to disable internal lbk"); break; } ret = rte_pmd_bphy_cgx_ptp_rx_enable(dev_id, i); /* ptp not available on RPM */ if (ret < 0 && ret != -ENOTSUP) { - RTE_LOG(ERR, PMD, "Failed to enable ptp\n"); + BPHY_LOG(ERR, "Failed to enable ptp"); break; } ret = 0; @@ -120,27 +119,27 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id) ret = rte_pmd_bphy_cgx_ptp_rx_disable(dev_id, i); /* ptp not available on RPM */ if (ret < 0 && ret != -ENOTSUP) { - RTE_LOG(ERR, PMD, "Failed to disable ptp\n"); + BPHY_LOG(ERR, "Failed to disable ptp"); break; } ret = 0; ret = rte_pmd_bphy_cgx_get_supported_fec(dev_id, i, &fec); if (ret) { - RTE_LOG(ERR, PMD, "Failed to get supported FEC\n"); + BPHY_LOG(ERR, "Failed to get supported FEC"); break; } ret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec); if (ret) { - RTE_LOG(ERR, PMD, "Failed to set FEC to %d\n", fec); + BPHY_LOG(ERR, "Failed to set FEC to %d", fec); break; } fec = CNXK_BPHY_CGX_ETH_LINK_FEC_NONE; ret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec); if (ret) { - RTE_LOG(ERR, PMD, "Failed to disable FEC\n"); + BPHY_LOG(ERR, "Failed to disable FEC"); break; } } diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h index 9d8d0285581b..5926adbcece9 100644 --- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h +++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h @@ -26,6 +26,11 @@ extern "C" { #endif +extern int bphy_logtype; + +#define BPHY_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, bphy_logtype, "%s(): " fmt "\n", __func__, ## args) + /** Available message types */ enum cnxk_bphy_cgx_msg_type { /** Type used to obtain link information */ From patchwork Wed Dec 13 16:36:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135163 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 872AD436E3; Wed, 13 Dec 2023 17:42:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D95842FBF; Wed, 13 Dec 2023 17:40:27 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id DFB9A42F7D for ; Wed, 13 Dec 2023 17:40:18 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d076ebf79cso41854975ad.1 for ; Wed, 13 Dec 2023 08:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485618; x=1703090418; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xWe82NsCmGM0jd1Tll4EYjvas5G07jqX7o50Jj2ljFo=; b=v6PxAEhy6DxqgQn31BRQFAIB/st8Ta9PvJK4IRcc/nf/GasywhlXToQfO8mRmSnmt5 031txFBex35OcT8zuYDkMQTVSQj0t0ZvctXri1OXVmOFUuwJxAvTzVxp1dRavdJ6lM6a eig4l66psbirXhOxz75PJc8oMhwANw5tXipAmIjV55iFtDDXYL8pKdBrD0sFNIguzg3l o72iK6Ru5rxhSBJAbPPTvJye0U0Ix8hTOsnKRbhQ8SSY1VXna3KD2Xx7Y0rvE5w5HcvB D62LINDzSpKmqkZ7sM69OEEi9kuQ2he/Tgql/Ho2S9rGOzwukBWyFiQoKojFmdEUhPsM m4lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485618; x=1703090418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xWe82NsCmGM0jd1Tll4EYjvas5G07jqX7o50Jj2ljFo=; b=bZU4DQ2Vq6X20TAkjNcLdW5ft50yHqYxuS+lh8u8eio/fljYqdlXNtp5smMflrYB0k +OzE9EwxjzbErPLdycqHX5WwCB54tkC5eZmFCn50sJBhaoQ+JwX9JK1jUgpMIPmKYVVf 2OOOxgKOpzPoQ8qYumtOMaULgSMRoUTa7waiSObSgq+nn+L3yq9JVybv8dNGPumChgAV 1kjmgnoUvl7XTRfFzSt+Pe8shJhjOfN+ohY9qQb7Qhs/h1LoSKsJdWItQ3lpm3nKelXq aHWB5GRR/pz5vWKZ/7FR/X9CLkrdZdL01Gwri3RJqVxnTIdY0JM11jnwnD8HH1uGwn5G VxHw== X-Gm-Message-State: AOJu0YwQnLH4R9ms46hG+h4dVDXmFeF4nG82guHDDOdD1DUjzCCNbWsq lvSEHfZOEmG0bO01Qn8sfmTVDuYk0931CRmqOxU= X-Google-Smtp-Source: AGHT+IHmMm2EvMe3NWOxXcuhYRVcFJlrBT4usZqU/pNLSVWj2WIq1toiTkKEsEMVMaHRfcGq80+Dzw== X-Received: by 2002:a17:903:2290:b0:1d0:3f5e:d4c8 with SMTP id b16-20020a170903229000b001d03f5ed4c8mr5934629plh.30.1702485618179; Wed, 13 Dec 2023 08:40:18 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Palider , Tomasz Duszynski Subject: [PATCH v3 28/37] raw/cnxk_gpio: replace PMD logtype with dynamic type Date: Wed, 13 Dec 2023 08:36:02 -0800 Message-ID: <20231213163820.894987-29-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 22 ++++++++------- drivers/raw/cnxk_gpio/cnxk_gpio.h | 4 +++ drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 31 +++++++++++----------- 3 files changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 3c4d79e4810e..0ec1b869b805 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio.c +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c @@ -8,6 +8,7 @@ #include #include +#include #include #include #include @@ -215,13 +216,13 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist) errno = 0; val = strtol(token, NULL, 10); if (errno) { - RTE_LOG(ERR, PMD, "failed to parse %s\n", token); + CNXK_LOG(ERR, "failed to parse %s", token); ret = -errno; goto out; } if (val < 0 || val >= gpiochip->num_gpios) { - RTE_LOG(ERR, PMD, "gpio%d out of 0-%d range\n", val, + CNXK_LOG(ERR, "gpio%d out of 0-%d range", val, gpiochip->num_gpios - 1); ret = -EINVAL; goto out; @@ -231,7 +232,7 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist) if (list[i] != val) continue; - RTE_LOG(WARNING, PMD, "gpio%d already allowed\n", val); + CNXK_LOG(WARNING, "gpio%d already allowed", val); break; } if (i == queue) @@ -398,7 +399,7 @@ cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t queue_id, return ret; } } else { - RTE_LOG(WARNING, PMD, "using existing gpio%d\n", gpio->num); + CNXK_LOG(WARNING, "using existing gpio%u", gpio->num); } gpiochip->gpios[num] = gpio; @@ -647,7 +648,7 @@ cnxk_gpio_process_buf(struct cnxk_gpio *gpio, struct rte_rawdev_buf *rbuf) /* get rid of last response if any */ if (gpio->rsp) { - RTE_LOG(WARNING, PMD, "previous response got overwritten\n"); + CNXK_LOG(WARNING, "previous response got overwritten"); rte_free(gpio->rsp); } gpio->rsp = rsp; @@ -741,7 +742,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) cnxk_gpio_format_name(name, sizeof(name)); rawdev = rte_rawdev_pmd_allocate(name, sizeof(*gpiochip), rte_socket_id()); if (!rawdev) { - RTE_LOG(ERR, PMD, "failed to allocate %s rawdev\n", name); + CNXK_LOG(ERR, "failed to allocate %s rawdev", name); return -ENOMEM; } @@ -770,7 +771,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) snprintf(buf, sizeof(buf), "%s/gpiochip%d/base", CNXK_GPIO_CLASS_PATH, gpiochip->num); ret = cnxk_gpio_read_attr_int(buf, &gpiochip->base); if (ret) { - RTE_LOG(ERR, PMD, "failed to read %s\n", buf); + CNXK_LOG(ERR, "failed to read %s", buf); goto out; } @@ -778,20 +779,20 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) snprintf(buf, sizeof(buf), "%s/gpiochip%d/ngpio", CNXK_GPIO_CLASS_PATH, gpiochip->num); ret = cnxk_gpio_read_attr_int(buf, &gpiochip->num_gpios); if (ret) { - RTE_LOG(ERR, PMD, "failed to read %s\n", buf); + CNXK_LOG(ERR, "failed to read %s", buf); goto out; } gpiochip->num_queues = gpiochip->num_gpios; ret = cnxk_gpio_parse_allowlist(gpiochip, params->allowlist); if (ret) { - RTE_LOG(ERR, PMD, "failed to parse allowed gpios\n"); + CNXK_LOG(ERR, "failed to parse allowed gpios"); goto out; } gpiochip->gpios = rte_calloc(NULL, gpiochip->num_gpios, sizeof(struct cnxk_gpio *), 0); if (!gpiochip->gpios) { - RTE_LOG(ERR, PMD, "failed to allocate gpios memory\n"); + CNXK_LOG(ERR, "failed to allocate gpios memory"); ret = -ENOMEM; goto out; } @@ -851,3 +852,4 @@ RTE_PMD_REGISTER_VDEV(cnxk_gpio, cnxk_gpio_drv); RTE_PMD_REGISTER_PARAM_STRING(cnxk_gpio, "gpiochip= " "allowlist="); +RTE_LOG_REGISTER_DEFAULT(cnxk_logtype, INFO); diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.h b/drivers/raw/cnxk_gpio/cnxk_gpio.h index e62f78a7604a..d9058c364068 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio.h +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.h @@ -5,6 +5,10 @@ #ifndef _CNXK_GPIO_H_ #define _CNXK_GPIO_H_ +extern int cnxk_logtype; +#define CNXK_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, cnxk_logtype, fmt "\n", ## args) + struct cnxk_gpiochip; struct cnxk_gpio { diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c index 10742b5dc48a..e3ec85990c92 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c +++ b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c @@ -54,12 +54,14 @@ cnxk_gpio_read_attr(char *attr, char *val) return 0; } -#define CNXK_GPIO_ERR_STR(err, str, ...) do { \ - if (err) { \ - RTE_LOG(ERR, PMD, "%s:%d: " str " (%d)\n", __func__, __LINE__, \ - ##__VA_ARGS__, err); \ - goto out; \ - } \ + + +#define CNXK_GPIO_ERR_STR(err, str, ...) do { \ + if (err) { \ + CNXK_LOG(ERR, "%s:%d: " str " (%d)",__func__, __LINE__, \ + ##__VA_ARGS__, err); \ + goto out; \ + } \ } while (0) static int @@ -330,30 +332,28 @@ cnxk_gpio_selftest(uint16_t dev_id) for (i = 0; i < queues; i++) { ret = rte_rawdev_queue_conf_get(dev_id, i, &conf, sizeof(conf)); if (ret) { - RTE_LOG(ERR, PMD, - "failed to read queue configuration (%d)\n", - ret); + CNXK_LOG(ERR, "failed to read queue configuration (%d)n", ret); goto out; } - RTE_LOG(INFO, PMD, "testing queue%d (gpio%d)\n", i, conf.gpio); + CNXK_LOG(INFO, "testing queue%u (gpio%u)", i, conf.gpio); if (conf.size != 1) { - RTE_LOG(ERR, PMD, "wrong queue size received\n"); + CNXK_LOG(ERR, "wrong queue size received: %u", conf.size); ret = -EIO; goto out; } ret = rte_rawdev_queue_setup(dev_id, i, NULL, 0); if (ret) { - RTE_LOG(ERR, PMD, "failed to setup queue (%d)\n", ret); + CNXK_LOG(ERR, "failed to setup queue%u (%d)", i, ret); goto out; } gpio = gpiochip->gpios[conf.gpio]; snprintf(buf, sizeof(buf), CNXK_GPIO_PATH_FMT, gpio->num); if (!cnxk_gpio_attr_exists(buf)) { - RTE_LOG(ERR, PMD, "%s does not exist\n", buf); + CNXK_LOG(ERR, "%s does not exist", buf); ret = -ENOENT; goto release; } @@ -371,13 +371,12 @@ cnxk_gpio_selftest(uint16_t dev_id) ret2 = ret; ret = rte_rawdev_queue_release(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "failed to release queue (%d)\n", - ret); + CNXK_LOG(ERR, "failed to release queue%u (%d)", i, ret); break; } if (cnxk_gpio_attr_exists(buf)) { - RTE_LOG(ERR, PMD, "%s still exists\n", buf); + CNXK_LOG(ERR, "%s still exists", buf); ret = -EIO; break; } From patchwork Wed Dec 13 16:36:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135164 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 325EE436E3; Wed, 13 Dec 2023 17:42:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9602A42FC7; Wed, 13 Dec 2023 17:40:28 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 95A6142F7F for ; Wed, 13 Dec 2023 17:40:19 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d345b187bbso14961735ad.0 for ; Wed, 13 Dec 2023 08:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485619; x=1703090419; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IGbOuMxxr8q4OKl2iOxQRNuLpE1RpKhvWgXADRIf1C0=; b=oPrwhIKkv8QJ1qrkv2GfgBVJpkXUPT41UwMS5ZDY2B/kpaCtXlYLi+QV5atEjUR9Jx 29GfDY7+zmknJLR+jiaHyvEzKjsHnLzRb2ZTW9ThJpf1xYqQ1AAQTEwFBZqVm1Q/PzmG mG/mFBPn33kP+d/NVU7NcTttrEXbXdZYw6fwSxP3HMxivXueGaB4eecOPrss4CD37lAJ l0XNhbCtdHi+Ab5ZVcElQqx6CfvSka9csqdVwaBrx+BhahfcHNLPdZe2irJVmNPNr5Dt LPvFCygq/l0d69R7TvP5W+t+PXoGPSZ2I9h9M4mZik1xuLLSw6FnCdjtTLiHXKxLIykL /mWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485619; x=1703090419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IGbOuMxxr8q4OKl2iOxQRNuLpE1RpKhvWgXADRIf1C0=; b=iIpYS4pYTMU/MqxCmKDN1T+asCe/mLlLIJeDH5orPRuDAbKoxGdtCc//ezGvwBg4QB nmwzvL/0S+YvohYUQ9KiGxFr2wrMvJefTezon0k3df8xGj5xP+QUG2VWx2NJPDj7L9B6 By4/mVsjTCMFyzPfoiV1e8Xl3IW/1L2NlJi5JBqqjTIWnKKTzsRsZKv0msTqY2XPjZkQ f57gz8s5/vnDl79AzwblnpEVFyhGUw0OnMVRLDPLEVFyogBoHwzEV0lBLV83bctSFLsH 2WrTMbNpdEWsArV/DZuEFwfgf2vGgfC+qrW5aF9ne3sqrx0FeHBe1kNpe+quOdYMVfQv tOMg== X-Gm-Message-State: AOJu0YxRrejxnMZA+Ll7Br3JgD5b2qyTym0G40+EG/d2EZAawEnkLJN0 a9AVCNffOkhH1CNmioO831ZnhfJSgp4A8OJZJLs= X-Google-Smtp-Source: AGHT+IHun3XgE7govJiqyoWo3hLUq+EE0AljTLUI46fI7Il3zBOSeHaVGs+FRCAt4kx1ksqQzfn0uw== X-Received: by 2002:a17:902:7e8f:b0:1d3:5712:7b04 with SMTP id z15-20020a1709027e8f00b001d357127b04mr674149pla.60.1702485618860; Wed, 13 Dec 2023 08:40:18 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:18 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh Subject: [PATCH v3 29/37] raw/dpaa2_cmdif: replace PMD logtype with rte_log_dp Date: Wed, 13 Dec 2023 08:36:03 -0800 Message-ID: <20231213163820.894987-30-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use local logtype for datapath logs. Signed-off-by: Stephen Hemminger --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h index 8991e8327d68..7cb423c7a57b 100644 --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h @@ -30,7 +30,8 @@ extern int dpaa2_cmdif_logtype; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_CMDIF_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, "dpaa2_cmdif: " fmt "\n", ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa2_cmdif_logtype, \ + "dpaa2_cmdif: " fmt "\n", ## args) #define DPAA2_CMDIF_DP_DEBUG(fmt, args...) \ DPAA2_CMDIF_DP_LOG(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:36:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135165 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7F90436E3; Wed, 13 Dec 2023 17:42:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C483642FCF; Wed, 13 Dec 2023 17:40:29 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 458F942F83 for ; Wed, 13 Dec 2023 17:40:20 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d069b1d127so42300795ad.0 for ; Wed, 13 Dec 2023 08:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485619; x=1703090419; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lHdRS0EID0uD2cl70V3Q3vPOpZ9b5yBc2/0Fxu93p2U=; b=Nf1+97dda2jdj2c9U71Q4/2mGbKcKHRJeAXKChmgr7Arzb9a29SwlrZUvpyKz/y0oH Y01USsYha5QB1pnCOEdXZN3ZIque2PTiNsRaXg3tbzAzqUJYIfGx88KDxsxKjhWgn1LH R5cqPdVZM5mIOSQrCvgW+JLhSEBIIy7gai9S1bNDILxv+QxhMhMk39qR+yB1pD+cBldS kxpuc4qtWRIlMrhG1bMDEas8SqNrRs89fy+oWIyehrOnRwfK44vo2AI82s7O4tVGy/KD RU12sxBrqaQmpkJBvcwgZ1gxY+4ajmRf9BWxlpKn7evGb1oECj1gpwz6PLrlpIk9UG8s jTIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485619; x=1703090419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lHdRS0EID0uD2cl70V3Q3vPOpZ9b5yBc2/0Fxu93p2U=; b=jDwcIY7JZLJYUMaVTx9S1phiIpKEAz+mxT2v2x0gleP1+FaPwDNES/6YA1kXSyiIOn VxkgoI4ZzZa1v3GRF6q2MqPkxcpPzoc41Q8PB/AV5SL7rBH5RULtjsKi22tRSPlez2AK 17cKKTSkLus5Qk3BQzgh7oqG3qLpIYA9KUx/EW3/Di6ENjkPSy4rJMwh7PiVF3q/dz2L 4Z+Yvzr88fA+1jnlkof6GUT5/OMwSkpggeN6pV2NlVHjZvVJf2RZrlXkSeWEMa0Xv8YM F62lat2boiyDNANqGnIhk++woSCaNXw/dVf/wJvXPqHuI+0ey9xTbKPph4aqcsd4vEHy VeDw== X-Gm-Message-State: AOJu0YywbjJKv7HhnwCc2Jf2tIZ8TstcpnKo1qlfO8eAI3xohWbq3EOs W4Daf31+FHndIT26IGNDe4w8AzHHmQMndgv4FKQ= X-Google-Smtp-Source: AGHT+IHySWAmVFgEsXMXz2Q0AWGt4uycasQKfa7V5BNU6vQIjZS/o3OxaHN3X4msM2e4m3K4Q1dweA== X-Received: by 2002:a17:902:e74e:b0:1cf:6453:b268 with SMTP id p14-20020a170902e74e00b001cf6453b268mr4904412plf.53.1702485619535; Wed, 13 Dec 2023 08:40:19 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu , Tianfei Zhang Subject: [PATCH v3 30/37] raw/ifpga: replace PMD logtype with dynamic type Date: Wed, 13 Dec 2023 08:36:04 -0800 Message-ID: <20231213163820.894987-31-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger Reviewed-by: Rosen Xu --- drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h index 33041c907e19..ad885107ab7d 100644 --- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h +++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h @@ -16,8 +16,10 @@ #include #include +extern int ifpga_rawdev_logtype; + #define dev_printf(level, fmt, args...) \ - RTE_LOG(level, PMD, "osdep_rte: " fmt, ## args) + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "osdep_rte: " fmt, ## args) #define osdep_panic(...) rte_panic(...) From patchwork Wed Dec 13 16:36:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135166 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DBA1436E3; Wed, 13 Dec 2023 17:42:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E7A642FD9; Wed, 13 Dec 2023 17:40:31 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id EF19242F89 for ; Wed, 13 Dec 2023 17:40:20 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d359f04514so2964215ad.2 for ; Wed, 13 Dec 2023 08:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485620; x=1703090420; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vPJfbFK+D25WjpXSAjnshU76FStxLv81t02JBUf1vQI=; b=yn/JVhwbTc2mGg4Uiw8mVBy1Ksm0eVP3Ki2Kl6ePYANM1n85tLpPIe3HcDU2h6wom8 bev/go1pWES2MumGF/MN5W8KTPW5XT5KLP6/58fyMXfB8Z3e0Xlg0yD32FIweFOEfX84 c0YSJ4kakpzBQX0IuhjqcwrQpX3uq30Pgk8EUYfJInPRg6hkQeA5wQgCJVceaIInUH9/ 1atX3MZDo4ixJvXdpiO7Zx5rXDSeyGMDADVa2W4VdMyrDfmfBzR9qB5gpsdC8kOpRyzn nJA2XLHeKVt8+8rD/unICphBGLFImBC7FRghjMDZFNeWAOq1gJVQWfSzl20ISq1GnRyp BVHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485620; x=1703090420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vPJfbFK+D25WjpXSAjnshU76FStxLv81t02JBUf1vQI=; b=pNWoTlRcsPt/k6bWOGOTKey9CoS62vaFZ4st2Rhd36/X/UkYRFYx/HwkPXJCg3iRcB ZW6+wU1hxJZnV4//zW3TMviEuHkVzNNcPScqrnC6cXLG6HQFGcp15yEldfNL1M9ZSTyZ iVpshu8UVwn5+PscC4lyS5BmNBQPVO2kl5IeAxhcF1O0Sc70SrOP4paMLJRe/+DuosDN b6XpZ/FC/zyI98/d1fwuRRtD3ipXEgF281cTFZ3sDPUde3tWNqabB9cb8QGOLAHMo/oH xQTf1ll4Tb2auBSIWY9QLRmSQuPjXj4NcIhfP7JebGD+i9qfQ4xv39EutmCfduPoTIRZ 9+8w== X-Gm-Message-State: AOJu0YzAK1lJ02ZFrCveKtbxvKrMdK6tEogXkf3tuZ23H3jxyLgZXqUg ZOpuptXWbHGpGrxZnOqua3EySbLpoIzuBxn4cLs= X-Google-Smtp-Source: AGHT+IGWWytaZ1nIvm+LZ8/PmnIfyOpsWorFRcw9wZ/mJu0zlqJI5SmdEDmPoyl2lGvJnKzNPROzqw== X-Received: by 2002:a17:902:e549:b0:1d0:8ac1:1b89 with SMTP id n9-20020a170902e54900b001d08ac11b89mr4897697plf.34.1702485620248; Wed, 13 Dec 2023 08:40:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Abdullah Sevincer Subject: [PATCH v3 31/37] event/dlb2: replace logtype PMD with rte_log_dp Date: Wed, 13 Dec 2023 08:36:05 -0800 Message-ID: <20231213163820.894987-32-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use local logtype for all log messages. Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 5 ++--- drivers/event/dlb2/dlb2_log.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 050ace0904b4..5a16123f0af9 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -4741,9 +4741,8 @@ dlb2_parse_params(const char *params, struct rte_kvargs *kvlist = rte_kvargs_parse(params, args); if (kvlist == NULL) { - RTE_LOG(INFO, PMD, - "Ignoring unsupported parameters when creating device '%s'\n", - name); + DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'\n", + name); } else { int ret = rte_kvargs_process(kvlist, NUMA_NODE_ARG, set_numa_node, diff --git a/drivers/event/dlb2/dlb2_log.h b/drivers/event/dlb2/dlb2_log.h index dc1481ef870c..3d4e1879350d 100644 --- a/drivers/event/dlb2/dlb2_log.h +++ b/drivers/event/dlb2/dlb2_log.h @@ -20,6 +20,6 @@ extern int eventdev_dlb2_log_level; /* remove debug logs at compile time unless actually debugging */ #define DLB2_LOG_DBG(fmt, args...) \ - RTE_LOG_DP(DEBUG, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_DEBUG, eventdev_dlb2_log_level, fmt, ## args) #endif /* _DLB2_EVDEV_LOG_H_ */ From patchwork Wed Dec 13 16:36:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135167 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0E22436E3; Wed, 13 Dec 2023 17:42:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A6A942FED; Wed, 13 Dec 2023 17:40:32 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id BA8A142F89 for ; Wed, 13 Dec 2023 17:40:21 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d04dba2781so42895615ad.3 for ; Wed, 13 Dec 2023 08:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485621; x=1703090421; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I3NHvtzTxrcTTRz067EYuF7Fq0/fx6bWGa0pTT+tCuk=; b=jsFa5OmVxMB2BZAxooG1XG/qrW0JRix+S/xkKIGpVH1rxN/5AJ9nN/Tje8h+AmJ2X4 2hl3RpAEiesi8vA1L5PXbKIv4eEgdfI5Cgwi3+4jLE2IgBnBeJVBsSrpy6gpb25LSlYV hoI5GYNHw1LdaAe22uBIH4BJfkfAjlsvfbMBUp9p6g7CiVCK6bgkwRQZUggjW/effR29 wdmLdFh9XjQ1uNDkyuSAyoeO1mKfcdGbQXG+Otk8+rMQtGXrEZ00JLzjpaeNKluccRU9 e4XoIfTE0xiF/ZecIgE3x3l1plBm6EuBu7LgUNnBm5xVAoV+7NyBGG/x2oq4Q8QJrUAa 3/Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485621; x=1703090421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I3NHvtzTxrcTTRz067EYuF7Fq0/fx6bWGa0pTT+tCuk=; b=w2RN4rhOO8yCGhGpFvEXSUvfNW8sj+J28g3hlkIGo6DWxokcBW5zV/xe4kNRsmgtdK R3WYYDSVT9TTikTF6AnP6go4WGVIvQ7uYuroMvJ55PUEJc07+VP+tbeK5BZaiiHDqx/e 9KREB/M9F2EGzfAZgwVFiGKgZlnhtzEYdUUJEDSDrh57EhCMng8o/nJHu1oG/+S12feZ vdhFUmlVD/7dRMQn0s+j5QsxZVwU9nJ0bpcqsVOfLVFkOot/ZczcX8sf3tiwY+bM6amK xQ/JvHzciJf48BtbjS6U/bds7VxA9lH40lKtWRvw/MM7udSrJNQZcTGvrgRBcaJwX86r fj0Q== X-Gm-Message-State: AOJu0Yx6387LJ1cER88woZ2SeCA6Lx0SMsxmwVmzkJfP9+YU4n3rgf9w ZaDBqJR6nOY0wyTxpXenu4BTql8A3i94apJL9M8= X-Google-Smtp-Source: AGHT+IECsJqWKWVndCIPBU7rNeQpGXhvhp5YADRtiCLpFN8quChNjgdhEWpBQI5vxMP3RTewTAS0BA== X-Received: by 2002:a17:902:bd98:b0:1d0:cda5:d05f with SMTP id q24-20020a170902bd9800b001d0cda5d05fmr4552978pls.83.1702485620979; Wed, 13 Dec 2023 08:40:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v3 32/37] event/dpaa, event/dpaa2: use local logtype Date: Wed, 13 Dec 2023 08:36:06 -0800 Message-ID: <20231213163820.894987-33-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver has macros to use local logtype, but some changes added PMD log messages. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 2 +- drivers/event/dpaa2/dpaa2_eventdev.c | 4 ++-- drivers/event/dpaa2/dpaa2_eventdev_logs.h | 2 +- drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index 46a9b88c73ae..a8e5c3421df1 100644 --- a/drivers/event/dpaa/dpaa_eventdev.c +++ b/drivers/event/dpaa/dpaa_eventdev.c @@ -1025,7 +1025,7 @@ dpaa_event_dev_create(const char *name, const char *params, struct rte_vdev_devi eventdev->txa_enqueue = dpaa_eventdev_txa_enqueue; eventdev->txa_enqueue_same_dest = dpaa_eventdev_txa_enqueue_same_dest; - RTE_LOG(INFO, PMD, "%s eventdev added", name); + DPAA_EVENTDEV_INFO("%s eventdev added", name); /* For secondary processes, the primary has done all the work */ if (rte_eal_process_type() != RTE_PROC_PRIMARY) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index dd4e64395fe5..85c2dbd998dd 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -1141,7 +1141,7 @@ dpaa2_eventdev_create(const char *name, struct rte_vdev_device *vdev) priv->max_event_queues++; } while (dpcon_dev && dpci_dev); - RTE_LOG(INFO, PMD, "%s eventdev created\n", name); + DPAA2_EVENTDEV_INFO("%s eventdev created", name); done: event_dev_probing_finish(eventdev); @@ -1178,7 +1178,7 @@ dpaa2_eventdev_destroy(const char *name) } priv->max_event_queues = 0; - RTE_LOG(INFO, PMD, "%s eventdev cleaned\n", name); + DPAA2_EVENTDEV_INFO("%s eventdev cleaned", name); return 0; } diff --git a/drivers/event/dpaa2/dpaa2_eventdev_logs.h b/drivers/event/dpaa2/dpaa2_eventdev_logs.h index 66c8c772740d..69aebf569fa5 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev_logs.h +++ b/drivers/event/dpaa2/dpaa2_eventdev_logs.h @@ -26,7 +26,7 @@ extern int dpaa2_logtype_event; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_EVENTDEV_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa2_logtype_event, fmt, ## args) #define DPAA2_EVENTDEV_DP_DEBUG(fmt, args...) \ DPAA2_EVENTDEV_DP_LOG(DEBUG, fmt, ## args) diff --git a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c index 427aff4b1111..9d4938efe6aa 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c +++ b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c @@ -774,15 +774,15 @@ static void dpaa2_test_run(int (*setup)(void), void (*tdown)(void), int (*test)(void), const char *name) { if (setup() < 0) { - RTE_LOG(INFO, PMD, "Error setting up test %s", name); + DPAA2_EVENTDEV_INFO("Error setting up test %s", name); unsupported++; } else { if (test() < 0) { failed++; - RTE_LOG(INFO, PMD, "%s Failed\n", name); + DPAA2_EVENTDEV_INFO("%s Failed", name); } else { passed++; - RTE_LOG(INFO, PMD, "%s Passed", name); + DPAA2_EVENTDEV_INFO("%s Passed", name); } } From patchwork Wed Dec 13 16:36:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135168 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5F8E436E3; Wed, 13 Dec 2023 17:42:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91DF442FF7; Wed, 13 Dec 2023 17:40:33 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 8BDA242F93 for ; Wed, 13 Dec 2023 17:40:22 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d06819a9cbso41707055ad.1 for ; Wed, 13 Dec 2023 08:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485622; x=1703090422; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IfEBZNx5o1grAD5H8WxbgdgKmhV0o98XWrLO5UjgMBA=; b=UXZZZhmZi59FKolswzK7zv15sIexBCTjOmcL5lrxmnj/oyxAMjoUDKKpv3lKWX58yd WaF0zrAGycTUgq/MlqBUJyMA5zuEIWPmxgh0rDa+wCauFUoFISV7mbeBso4h1yA9qzba QrMSIGUbPY7FgfMJ2uCLtHUSvCuD0rztRH5/oIE3/N8bLvuX+mRHUzjIzcqXHiElhHcl u0JOeItNc3fG9Z4l4rMSt5KNX3/CSt5KIJ53hCFjtx0G43F1gfYWL2gDBqIIFjYK+nG7 CNLLwMnBu1QMGv+X7VrhR5xdqRroN9/izDrHjlklMMEL/wTKtTmYjncS9dyAb0bqIsW+ W4pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485622; x=1703090422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IfEBZNx5o1grAD5H8WxbgdgKmhV0o98XWrLO5UjgMBA=; b=Z4K/GdA+IjMJg2p90iGea52Wl2iNQFni1AO1WVAIQ8lFB+zwdIK1GRcv/F8QDWLdVB ewZTszJ0xPdlltek+gYEuBzzGL/fA0uQUdkdq/mUkrcLYxHr9fp5yF8Enze8Lbsa4edF VKxC3vBArImVvUCogNdGgSCZYBFyyPb6wDeupQcVXUXCSIy5aCg1W2Z4gQ0Sab8C7Vnh VqRb8RkrF5QMzX2BQ8GnuTLRDgrdbHUHqukHBvE68JP4uzHznMlz6IckOGIXDAF9VQ8f /iW4DejwKzmlWGhkaTMfFRXMnC5i+lWAMkVmPLM6UYGKAhVpuQf/xxaMJ8pnJM5Y76GD ALfQ== X-Gm-Message-State: AOJu0Yx4vmz9VAjPQes8Kx5FmHjCiJaPgfUGEzCRt7FEhiB4ZJxaE/Zx vR8gApVJx5XvxHk8YvalYYC2RYfuVrzscnsuF5o= X-Google-Smtp-Source: AGHT+IGifu8FlMR4k+Ptfv1u9v6sOWsKDB92dF4e4Uffuh+OZIqsZhyxWCcpc7bQvUWMW7Lo3FTeGg== X-Received: by 2002:a17:902:f690:b0:1d0:a663:20fe with SMTP id l16-20020a170902f69000b001d0a66320femr4217823plg.80.1702485621810; Wed, 13 Dec 2023 08:40:21 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob Subject: [PATCH v3 33/37] event/skeleton: replace logtype PMD with dynamic type Date: Wed, 13 Dec 2023 08:36:07 -0800 Message-ID: <20231213163820.894987-34-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 3 ++- drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index 7df032b7daa1..df50d2e4e4ff 100644 --- a/drivers/event/skeleton/skeleton_eventdev.c +++ b/drivers/event/skeleton/skeleton_eventdev.c @@ -457,7 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev) const char *name; name = rte_vdev_device_name(vdev); - RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name, + PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d\n", name, rte_socket_id()); return skeleton_eventdev_create(name, rte_socket_id(), vdev); } @@ -479,3 +479,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = { }; RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd); +RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO); diff --git a/drivers/event/skeleton/skeleton_eventdev.h b/drivers/event/skeleton/skeleton_eventdev.h index 9193f45f4782..9c1ed4ec5755 100644 --- a/drivers/event/skeleton/skeleton_eventdev.h +++ b/drivers/event/skeleton/skeleton_eventdev.h @@ -8,9 +8,12 @@ #include #include +extern int skeleton_eventdev_logtype; + #ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG #define PMD_DRV_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \ + "%s(): " fmt "\n", __func__, ## args) #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, ">>") #else #define PMD_DRV_LOG(level, fmt, args...) do { } while (0) @@ -18,7 +21,8 @@ #endif #define PMD_DRV_ERR(fmt, args...) \ - RTE_LOG(ERR, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \ + "%s(): " fmt "\n", __func__, ## args) struct skeleton_eventdev { uintptr_t reg_base; From patchwork Wed Dec 13 16:36:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135169 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3A66436E3; Wed, 13 Dec 2023 17:42:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3F0842FFF; Wed, 13 Dec 2023 17:40:34 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 42E8242F9D for ; Wed, 13 Dec 2023 17:40:23 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d2f1cecf89so25830675ad.1 for ; Wed, 13 Dec 2023 08:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485622; x=1703090422; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fKZ5fkLDaaxlNlp7bcbqKdX5Lwq94Qjyi3Uo27OSXHA=; b=irkG+g8Bnwi+YRX7fgsI+pPBSUSENqgza8GbAwXpcIR8b9NngwmNkuPREXcSC8B+8F VvcfES5yhczC1xVFL+oJ6hci4FkI+wUWrqwZ7FyLsIvL4NDuOfglQZd7WMnxhfLAyKo5 UjPfkkJmvyUcLzRQBtWPUubrKNVGcnbZJ/31XzIKmEjA3OPWFVNwRqLmuCu6SDoNi10S Sgy3iY3VIr5cK/dJ4gIehkpICkZ7gg24gd1d2lZLmWRCI8KavhvZYPhmAgpRsPlJR+TT DSpmwg1O72rRcucf4IEk40Yv1a5N9Fahkxheav+GLWLlZkqBxT1HpWYtNMmwdqFBgcWC F4uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485622; x=1703090422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fKZ5fkLDaaxlNlp7bcbqKdX5Lwq94Qjyi3Uo27OSXHA=; b=mmyQm5NMfsI7Z6KySEi1y+OP1WzkfwC+VoP88Pt/jTx+mGCJuNhGWo3tYpv3aZBXWq XoXUCo6G4Nvs6BskPkYn5kxG5qcdCXH+iLmPD5NDWn0OAYW3u0N13Dhk4Jdk7F2jK/xQ NrJ8SsOAo0JsZvQpDdR7+392G0wB7BscAXKvAsGn4oUoJzMo+132Nm8JCdzq6UJ1O1ZZ cCHTw6lTv68CQR+/W3yGBdSkpKUIICK6Uva3C/RVqFNicpLf5VMBNs+d6ZDyVfZh7va1 ViLik0FRCq2O7Z3PpgG9YPdMw7NxbWwosHoVU+w8h3W5NDyuQ37BNz7ASdYVI5Eto1bm kQwg== X-Gm-Message-State: AOJu0YxbxfjZyUwU3iqRfCvG/r5rXG6FIIdOplmqZNLLyo87ScmKRORJ ER4gtn0rscx3VYvr+E2zP0ss9cTwZ7WNvE+Vp7E= X-Google-Smtp-Source: AGHT+IF/B1XsQX1Vd+0HJagOvKq2kYs0fku8Ykh5AtqUjS3xe+F+hTcRO22h/Cg1YGcNJ4/ECSNkCw== X-Received: by 2002:a17:902:c946:b0:1d0:c14b:dd0d with SMTP id i6-20020a170902c94600b001d0c14bdd0dmr4385304pla.54.1702485622526; Wed, 13 Dec 2023 08:40:22 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH v3 34/37] crypto/caam_jr: replace logtype PMD Date: Wed, 13 Dec 2023 08:36:08 -0800 Message-ID: <20231213163820.894987-35-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver has macros for logging, they just weren't used everywhere. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 8 +++----- drivers/crypto/caam_jr/caam_jr_log.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c index b55258689b49..9c713d4e8133 100644 --- a/drivers/crypto/caam_jr/caam_jr.c +++ b/drivers/crypto/caam_jr/caam_jr.c @@ -2346,7 +2346,7 @@ caam_jr_dev_init(const char *name, rte_cryptodev_pmd_probing_finish(dev); - RTE_LOG(INFO, PMD, "%s cryptodev init\n", dev->data->name); + CAAM_JR_INFO("%s cryptodev init\n", dev->data->name); return 0; @@ -2386,8 +2386,7 @@ cryptodev_caam_jr_probe(struct rte_vdev_device *vdev) ret = of_init(); if (ret) { - RTE_LOG(ERR, PMD, - "of_init failed\n"); + CAAM_JR_ERR("of_init failed\n"); return -EINVAL; } /* if sec device version is not configured */ @@ -2407,8 +2406,7 @@ cryptodev_caam_jr_probe(struct rte_vdev_device *vdev) } #ifdef RTE_LIBRTE_PMD_CAAM_JR_BE if (rta_get_sec_era() > RTA_SEC_ERA_8) { - RTE_LOG(ERR, PMD, - "CAAM is compiled in BE mode for device with sec era > 8???\n"); + CAAM_JR_ERR("CAAM is compiled in BE mode for device with sec era > 8???\n"); return -EINVAL; } #endif diff --git a/drivers/crypto/caam_jr/caam_jr_log.h b/drivers/crypto/caam_jr/caam_jr_log.h index 106ff07a70fe..2dded646dbdc 100644 --- a/drivers/crypto/caam_jr/caam_jr_log.h +++ b/drivers/crypto/caam_jr/caam_jr_log.h @@ -28,7 +28,7 @@ extern int caam_jr_logtype; /* DP Logs, toggled out at compile time if level lower than current level */ #define CAAM_JR_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt "\n", ## args) + rte_log_dp(RTE_LOG_ ## level, caam_jr_logtype, fmt "\n", ## args) #define CAAM_JR_DP_DEBUG(fmt, args...) \ CAAM_JR_DP_LOG(DEBUG, fmt, ## args) From patchwork Wed Dec 13 16:36:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135170 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62767436E3; Wed, 13 Dec 2023 17:42:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EE4C43252; Wed, 13 Dec 2023 17:40:36 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 1DCE042F9F for ; Wed, 13 Dec 2023 17:40:24 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-28ac6ecb9bdso1578549a91.1 for ; Wed, 13 Dec 2023 08:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485623; x=1703090423; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5DFqFzsaRdJASZzwcyvtGPWWuOUL4czYfaLuijsZvIw=; b=zbBxT6z93zstnvt8HLchFgw6jidE/GXnRpA9LPYRghBDpqZYomRFknx8EmHfoVrwdn ugqqBhk0ZBB6UdK6ZdGmurxbcMJQNze0Xd4ZZDSS2O1zcZdiGrpQtijCnaSgAniZWPqA ANPxcYsaYt48g9CVpudwmlCM5CKmhs5qTkKO4dwEcBI7frjkO/ytRF+2xZbM7Fa2f6hy AZUkNo4toPDnq4f1lVcVk4IyaHwhLxeCYJFbEB3F8Vd7VgJmZrCiJzlp9ztsOTZIicTA /1PclZAfRq2HtzL9jOOdgoYgOr8MM6/tnmtivBRTcV8OJMyOPUljg3djcUg6JWnwVDem N6Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485623; x=1703090423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5DFqFzsaRdJASZzwcyvtGPWWuOUL4czYfaLuijsZvIw=; b=BiNv5omSPqKt16r1PyBbWLmjpOsBc4qIh8ASuopotj1mUq1zfWrlEY7jxrkUaoE30+ wMHTjIPnm/Xw9GK7p80YpGqE/11Nw3rJn/dLRhZX/LbuxYbSfnes7Z0ufoE2txwdf5SZ YGrDw97XNfhk/EOWBiPYkJVtaqj89NELo+5TrhZhOFhMLtV5mW9YuIytLQVbVyTzDxZI Zs/DQaVvys6SFZY8/W8jsCaj7+3QjMJO4oaLZC8Z1xUd2xuiwoC7PAuh/ybznC6YMI4E Nb7mPo1VNG0mVKQaRszatYIdznGdxRP17wE9ixqhVzCPE3MByUFxsKYQXxb3cFEvMuVX HO8A== X-Gm-Message-State: AOJu0YzZu/mTnqVmjpKqRoUvzFWsuKf/DOAsNvwFVmNRg9u9zehU2lRv 8yE1pTPTfE0g7tNrtwT5ESeD0TohbOMKSVJTYuo= X-Google-Smtp-Source: AGHT+IF9Aqvk7tXGcbjNJdzsSVmg888oLtiqsDWcbFy3C8D7mkkh7QD0hbdR4ZVs70poNjctntm6gA== X-Received: by 2002:a17:90a:cc14:b0:28b:48:bf46 with SMTP id b20-20020a17090acc1400b0028b0048bf46mr161666pju.16.1702485623299; Wed, 13 Dec 2023 08:40:23 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Uttarwar , Ravi Kumar Subject: [PATCH v3 35/37] crypto/ccp: do not use PMD logtype Date: Wed, 13 Dec 2023 08:36:09 -0800 Message-ID: <20231213163820.894987-36-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This driver has logging macros but not used consistently. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/rte_ccp_pmd.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index a5271d72273d..46a9275e3743 100644 --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -194,8 +194,7 @@ cryptodev_ccp_remove(struct rte_pci_device *pci_dev) ccp_pmd_init_done = 0; - RTE_LOG(INFO, PMD, "Closing ccp device %s on numa socket %u\n", - name, rte_socket_id()); + CCP_LOG_INFO("Closing ccp device %s on numa socket %u", name, rte_socket_id()); return rte_cryptodev_pmd_destroy(dev); } @@ -228,7 +227,7 @@ cryptodev_ccp_create(const char *name, } cryptodev_cnt++; - CCP_LOG_DBG("CCP : Crypto device count = %d\n", cryptodev_cnt); + CCP_LOG_DBG("CCP : Crypto device count = %d", cryptodev_cnt); dev->device = &pci_dev->device; dev->device->driver = &pci_drv->driver; dev->driver_id = ccp_cryptodev_driver_id; @@ -279,7 +278,7 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv __rte_unused, }; if (ccp_pmd_init_done) { - RTE_LOG(INFO, PMD, "CCP PMD already initialized\n"); + CCP_LOG_INFO("CCP PMD already initialized"); return -EFAULT; } rte_pci_device_name(&pci_dev->addr, name, sizeof(name)); @@ -288,11 +287,11 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv __rte_unused, init_params.def_p.max_nb_queue_pairs = CCP_PMD_MAX_QUEUE_PAIRS; - RTE_LOG(INFO, PMD, "Initialising %s on NUMA node %d\n", name, + CCP_LOG_INFO("Initialising %s on NUMA node %d", name, init_params.def_p.socket_id); - RTE_LOG(INFO, PMD, "Max number of queue pairs = %d\n", + CCP_LOG_INFO("Max number of queue pairs = %d", init_params.def_p.max_nb_queue_pairs); - RTE_LOG(INFO, PMD, "Authentication offload to %s\n", + CCP_LOG_INFO("Authentication offload to %s", ((init_params.auth_opt == 0) ? "CCP" : "CPU")); rte_pci_device_name(&pci_dev->addr, name, sizeof(name)); From patchwork Wed Dec 13 16:36:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135171 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77EEF436E3; Wed, 13 Dec 2023 17:42:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2522043262; Wed, 13 Dec 2023 17:40:37 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id BBE5442FAD for ; Wed, 13 Dec 2023 17:40:24 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d05199f34dso41060015ad.3 for ; Wed, 13 Dec 2023 08:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485624; x=1703090424; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=88ZbJBoD4XtnzuZ+N1nJEVABLyhW3zqfw6LEMcKImgk=; b=iP2NDGiMEuQwxa6of2Qn6MnPAlsRffarRaCc40mOveBa2glhsnSoDnm4AE9edkNzQi seOUPzFkmDcixkKM0qc9ABBOIDjgO9l/tHHp05DALM0QVNd3PdD0xBHAyJWXDBGVXSwP 7i0LkkCXzVzq0+AtMqAVdvPbdvRnMWklBTUZ/yE/e+p1MJyvM2UaPxEJBufWbNqHOBGF vSzLgjN4WFkN1w/v9QyMQ50LjOMn/RyRItkG0ftXrvQLL8JZ5Vd/BogCuumBgcyYg683 s0wDDw/47AXJQcRTWtPvuZJPpuRL5zbxcWVzbCuo39DrtxUxGdP+506YaJ71A+nP76SY RAxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485624; x=1703090424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=88ZbJBoD4XtnzuZ+N1nJEVABLyhW3zqfw6LEMcKImgk=; b=GKsgKfoknhUL+RSSslRQpGAV6NsnYDwoetSbEGzK2bdDMjUtzGoa4d1UHZgm26FMvV 3QzIks/ccyqakMJUslp7o2hyDqC5XnGXDod+qyLwHqk0+8D4spKT7w2fRr5djkoTHK0I w8+GL8hi24K5EMmAXceaHwC3lr13LKPzBA9xadksqjqOHnmRGQ6eiqSWYSXfijh9msUx fNBfx7ZX+RTR20/9BLSfYfVge6kO1FEyCkR5OIjw7BQG8Ty2yh7+KvuPS8zBwvvjyQMM tzABbeVTDDfz6B1kE67S5uFTiWP//GqhO4BE+SG6/QreGRFFM02FM9IxwNErQpgh0kja TcoQ== X-Gm-Message-State: AOJu0Ywc743ECNKtdnldP4xGezhVtDWSZPQfg8Qb9Mqbh9laoOKxz0Aq wPpOUnQnjjuYw9Xtx/c2J+yB5xZgaesJuds54Ps= X-Google-Smtp-Source: AGHT+IHWSicpnjfT8ywjcSubXMWelvICHAMpa02+BFYFVn5A4w/of+79KlvFJMCEsRTEaoPVrD8XJQ== X-Received: by 2002:a17:902:a388:b0:1d3:6346:3bbd with SMTP id x8-20020a170902a38800b001d363463bbdmr13486pla.132.1702485624010; Wed, 13 Dec 2023 08:40:24 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Fan Zhang Subject: [PATCH v3 36/37] crypto/scheduler: replace use of logtype PMD Date: Wed, 13 Dec 2023 08:36:10 -0800 Message-ID: <20231213163820.894987-37-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver has logging macro but not used everywhere. Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold parameter") Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index 589d092d7457..aaf2dcdb57ec 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -197,8 +197,8 @@ cryptodev_scheduler_create(const char *name, return -EINVAL; } - RTE_LOG(INFO, PMD, " Sched mode param (%s = %s)\n", - param_name, param_val); + CR_SCHED_LOG(INFO, " Sched mode param (%s = %s)\n", + param_name, param_val); } } From patchwork Wed Dec 13 16:36:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 135172 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8135436E3; Wed, 13 Dec 2023 17:43:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 263E543067; Wed, 13 Dec 2023 17:40:38 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 75AAA42FB2 for ; Wed, 13 Dec 2023 17:40:25 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d348653591so11449435ad.1 for ; Wed, 13 Dec 2023 08:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485625; x=1703090425; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Esw4OYy1qcg9HbXfER7PoV0yNwzzxZAy7JsjWuYzt08=; b=X5Zm42FtzfBppTPK2TMw/QKDNq1k3jZJtpsirQq2Fa+7/SJD4oBtwi3RxJOT0JbrxP sCmwu5QDD1TUEi9vO1OSK7Qg4zW2dH/riT+asghOqVxafNrqO6c2YqGUy4wCJxJYdMv3 pBU7Bm1G53oUtwH8rimiMIbNKDbeBmi+ooPy/Oenxxmux9ky1BK7qxHuxCkZJEF9kAcu P05IN+ZL2hDbrts1gkvIMyLM02QLHrJ88iEKyz56Uql+I8quldOEe+77b7Kjgrb277T0 LtEz00qbU6fAQNgaHaqg2OsouZQxUP8aUPcIEaCtREYHnGOP1/hiKch0yOk/GtAbenIa O1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485625; x=1703090425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Esw4OYy1qcg9HbXfER7PoV0yNwzzxZAy7JsjWuYzt08=; b=cV4LYZxs48MAXkTM3fD88O2JxHVYBQcQZsEVAdY5A2zBhp6xm45YVowUSDhkyP3YV5 fQ4RikZOFjOJxrlGd6aYs+P/vVaUzGcMTFRFi3RTvzJ1W4+/0VgrfSJ+z7bTYPTFqq8D H9wsKbryY6lwPBLWNVnt8un4/GvxNfuJCNcntaM7i5LWjBFfH7o8E0krkto0Ai8lTE4i 4RdbH9C0Ruw/ZN6vvHcB1KXE0y1QgWxItWbpRu/H9Gn6Wn2sn/ZGIfZBsjT22zN5bRW/ H/mrR9saOrfRJcDQbzYL2toCffXM5GhhBXulKKfGROJTUWN4womVPXpNhJv0W0LMdKz7 Oovw== X-Gm-Message-State: AOJu0YwFQefBET85NVIM4NXK4v/1eSp2w3mAVVZ0bvzLR/hSN/uwS5eP 6Pdijhqh0YwQsnSVGftPhB+U0dg2k2HmctXZMTA= X-Google-Smtp-Source: AGHT+IHFpVwfx1Q2IkniJCPE3rU6YY5t4Vsdbc30IRpIsBC8A7AMBAyV7gCWPY4IRpsiJEag1l+miw== X-Received: by 2002:a17:902:e810:b0:1d3:610e:c00f with SMTP id u16-20020a170902e81000b001d3610ec00fmr410894plg.37.1702485624764; Wed, 13 Dec 2023 08:40:24 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:40:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH v3 37/37] crypto/dpaa_sec, crypto/dpaa2_sec: replace use of PMD logtype Date: Wed, 13 Dec 2023 08:36:11 -0800 Message-ID: <20231213163820.894987-38-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213163820.894987-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use macro consistently for all logs and rte_log_dp() for datapath. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 +++--- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 4 ++-- drivers/crypto/dpaa_sec/dpaa_sec.c | 4 ++-- drivers/crypto/dpaa_sec/dpaa_sec_log.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index bb5a2c629e53..1cae6c45059e 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -4153,7 +4153,7 @@ dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev, ret = dpseci_set_opr(dpseci, CMD_PRI_LOW, priv->token, qp_id, OPR_OPT_CREATE, &ocfg); if (ret) { - RTE_LOG(ERR, PMD, "Error setting opr: ret: %d\n", ret); + DPAA2_SEC_ERR("Error setting opr: ret: %d", ret); return ret; } qp->tx_vq.cb_eqresp_free = dpaa2_sec_free_eqresp_buf; @@ -4163,7 +4163,7 @@ dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev, ret = dpseci_set_rx_queue(dpseci, CMD_PRI_LOW, priv->token, qp_id, &cfg); if (ret) { - RTE_LOG(ERR, PMD, "Error in dpseci_set_queue: ret: %d\n", ret); + DPAA2_SEC_ERR("Error in dpseci_set_queue: ret: %d", ret); return ret; } @@ -4188,7 +4188,7 @@ dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev, ret = dpseci_set_rx_queue(dpseci, CMD_PRI_LOW, priv->token, qp_id, &cfg); if (ret) - RTE_LOG(ERR, PMD, "Error in dpseci_set_queue: ret: %d\n", ret); + DPAA2_SEC_ERR("Error in dpseci_set_queue: ret: %d", ret); return ret; } diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h index c2e11f9516f9..cd47225f4720 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h @@ -29,7 +29,7 @@ extern int dpaa2_logtype_sec; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA2_SEC_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa2_logtype_sec, fmt, ## args) #define DPAA2_SEC_DP_DEBUG(fmt, args...) \ DPAA2_SEC_DP_LOG(DEBUG, fmt, ## args) @@ -38,7 +38,7 @@ extern int dpaa2_logtype_sec; #define DPAA2_SEC_DP_WARN(fmt, args...) \ DPAA2_SEC_DP_LOG(WARNING, fmt, ## args) #define DPAA2_SEC_DP_ERR(fmt, args...) \ - DPAA2_SEC_DP_LOG(ERR, fmt, ## args) + DPAA2_SEC_DP_LOG(ERR, fmt, ## args) #endif /* _DPAA2_SEC_LOGS_H_ */ diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index a301e8edb2a4..3008ca4dc2f7 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -3518,7 +3518,7 @@ dpaa_sec_eventq_detach(const struct rte_cryptodev *dev, qman_oos_fq(&qp->outq); ret = qman_init_fq(&qp->outq, 0, &opts); if (ret) - RTE_LOG(ERR, PMD, "Error in qman_init_fq: ret: %d\n", ret); + DPAA_SEC_ERR("Error in qman_init_fq: ret: %d\n", ret); qp->outq.cb.dqrr = NULL; return ret; @@ -3709,7 +3709,7 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev) dpaa_sec_get_devargs(cryptodev->device->devargs, DRIVER_DUMP_MODE); - RTE_LOG(INFO, PMD, "%s cryptodev init\n", cryptodev->data->name); + DPAA_SEC_INFO("%s cryptodev init\n", cryptodev->data->name); return 0; init_error: diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_log.h b/drivers/crypto/dpaa_sec/dpaa_sec_log.h index fb895a8bc67f..936a61c2c18f 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec_log.h +++ b/drivers/crypto/dpaa_sec/dpaa_sec_log.h @@ -29,7 +29,7 @@ extern int dpaa_logtype_sec; /* DP Logs, toggled out at compile time if level lower than current level */ #define DPAA_SEC_DP_LOG(level, fmt, args...) \ - RTE_LOG_DP(level, PMD, fmt, ## args) + rte_log_dp(RTE_LOG_ ## level, dpaa_logtype_sec, fmt, ## args) #define DPAA_SEC_DP_DEBUG(fmt, args...) \ DPAA_SEC_DP_LOG(DEBUG, fmt, ## args)