From patchwork Wed Nov 29 17:25:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134703 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E88243403; Wed, 29 Nov 2023 18:31:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46F6642E5E; Wed, 29 Nov 2023 18:31:37 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id E69D2409FA for ; Wed, 29 Nov 2023 18:31:35 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6cb55001124so883997b3a.0 for ; Wed, 29 Nov 2023 09:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279094; x=1701883894; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/I36y5OdvRzH2d2wWWZtQ4f8zYV6uL/WhtMkfcQ3MtE=; b=c51zWGY8mnjmI6XxO0/4NnPGmzQkw6RQyq+Th5OBow5/7pU3xtpq3d8094PnfHmHz+ xcJ4EmkoMstGImUZKl8/NaKaKVnwQIC5WW0iLaeWy2EUdAo98i2z6PPYRASJWWXLy2RQ +EKBVDsgNN8W3s12byXzjv1OOL/n2+IMEXKybELDUoRu0lk1Aaq24qOuobbXRQLlYANR 3KJSXdv6hAedmi6hgiLUNMmmelaNAuX35zDCVgYSONWBBLlsp2CRvyacJti2tP0Q1Ohb 7LDi598leClxB5ms2CLI2imeyEqVAs2xD1Qs29PRME5pvKqiZj0F+us78u1XZTCnFOUv feAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279094; x=1701883894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/I36y5OdvRzH2d2wWWZtQ4f8zYV6uL/WhtMkfcQ3MtE=; b=r1iEWSKdJJJQkBI8DJroakPmXCkiExrvEnyk0ZWLznZDSU787TBqAU2BX4zu2fmFA9 NDHEbf7eqgFBZeFd8oBsKGY7ejFlO5MJ+7n2cxmtCsxBZAcFuRvQpeDStovq7+XSoAVq 4FARNkoUmINuVPj7uKMqVQu7sjWaBZNoM1b9kjArAmsp5+hNExw2wfk1HyMe5bmd5eoi E0kMWPPL+fqkOnrXSUbzpf0QVKkWVX9jcKzgdciCkW1CxZSEqhcuj6GUDLmv4zgb/vSR YiDpdiu7cmEpRigYRNq0I4B4VfG9L72Ygaaigfw1uZsELvqUtqYbMzAZDddadnGwi+rv q/VA== X-Gm-Message-State: AOJu0YyriBOMvD17CnQ3sfww0FEszcAg9C98OpIyetw3dQ6AkctCzbqi Ft3WEfznRpvW3rrC4MxyDR3rPU6DMMIuiwtPSc8= X-Google-Smtp-Source: AGHT+IFgaBj0zoB7myFjL6bJzh2d2CGfQ5ELNKe1tcO5SLnig+umG4Jg6jdHH6qzNSHslHAcRMK1nQ== X-Received: by 2002:a05:6a20:3944:b0:18b:b858:17a5 with SMTP id r4-20020a056a20394400b0018bb85817a5mr25387543pzg.28.1701279094395; Wed, 29 Nov 2023 09:31:34 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko , =?utf-8?q?Morten_Br=C3=B8?= =?utf-8?q?rup?= , Steven Webster , Matt Peters Subject: [PATCH v5 01/19] mbuf: replace term sanity check Date: Wed, 29 Nov 2023 09:25:55 -0800 Message-ID: <20231129173122.126895-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace rte_mbuf_sanity_check() with rte_mbuf_verify() to match the similar macro RTE_VERIFY() in rte_debug.h The term sanity check is on the Tier 2 list of words that should be replaced. Note: the rte_mbuf_verify() function is added without the experimental tag since it is intended as direct replacement for old function name. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko Acked-by: Morten Brørup --- app/test/test_mbuf.c | 28 +++++------ doc/guides/prog_guide/mbuf_lib.rst | 4 +- doc/guides/rel_notes/deprecation.rst | 3 ++ drivers/net/avp/avp_ethdev.c | 18 +++---- drivers/net/sfc/sfc_ef100_rx.c | 6 +-- drivers/net/sfc/sfc_ef10_essb_rx.c | 4 +- drivers/net/sfc/sfc_ef10_rx.c | 4 +- drivers/net/sfc/sfc_rx.c | 2 +- examples/ipv4_multicast/main.c | 2 +- lib/mbuf/rte_mbuf.c | 23 +++++---- lib/mbuf/rte_mbuf.h | 71 +++++++++++++++------------- lib/mbuf/version.map | 1 + 12 files changed, 90 insertions(+), 76 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index d7393df7eb5d..261c6e5d71e9 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -261,8 +261,8 @@ test_one_pktmbuf(struct rte_mempool *pktmbuf_pool) GOTO_FAIL("Buffer should be continuous"); memset(hdr, 0x55, MBUF_TEST_HDR2_LEN); - rte_mbuf_sanity_check(m, 1); - rte_mbuf_sanity_check(m, 0); + rte_mbuf_verify(m, 1); + rte_mbuf_verify(m, 0); rte_pktmbuf_dump(stdout, m, 0); /* this prepend should fail */ @@ -1161,7 +1161,7 @@ test_refcnt_mbuf(void) #ifdef RTE_EXEC_ENV_WINDOWS static int -test_failing_mbuf_sanity_check(struct rte_mempool *pktmbuf_pool) +test_failing_mbuf_verify(struct rte_mempool *pktmbuf_pool) { RTE_SET_USED(pktmbuf_pool); return TEST_SKIPPED; @@ -1180,12 +1180,12 @@ mbuf_check_pass(struct rte_mbuf *buf) } static int -test_failing_mbuf_sanity_check(struct rte_mempool *pktmbuf_pool) +test_failing_mbuf_verify(struct rte_mempool *pktmbuf_pool) { struct rte_mbuf *buf; struct rte_mbuf badbuf; - printf("Checking rte_mbuf_sanity_check for failure conditions\n"); + printf("Checking rte_mbuf_verify for failure conditions\n"); /* get a good mbuf to use to make copies */ buf = rte_pktmbuf_alloc(pktmbuf_pool); @@ -1707,7 +1707,7 @@ test_mbuf_validate_tx_offload(const char *test_name, GOTO_FAIL("%s: mbuf allocation failed!\n", __func__); if (rte_pktmbuf_pkt_len(m) != 0) GOTO_FAIL("%s: Bad packet length\n", __func__); - rte_mbuf_sanity_check(m, 0); + rte_mbuf_verify(m, 0); m->ol_flags = ol_flags; m->tso_segsz = segsize; ret = rte_validate_tx_offload(m); @@ -1914,7 +1914,7 @@ test_pktmbuf_read(struct rte_mempool *pktmbuf_pool) GOTO_FAIL("%s: mbuf allocation failed!\n", __func__); if (rte_pktmbuf_pkt_len(m) != 0) GOTO_FAIL("%s: Bad packet length\n", __func__); - rte_mbuf_sanity_check(m, 0); + rte_mbuf_verify(m, 0); data = rte_pktmbuf_append(m, MBUF_TEST_DATA_LEN2); if (data == NULL) @@ -1963,7 +1963,7 @@ test_pktmbuf_read_from_offset(struct rte_mempool *pktmbuf_pool) if (rte_pktmbuf_pkt_len(m) != 0) GOTO_FAIL("%s: Bad packet length\n", __func__); - rte_mbuf_sanity_check(m, 0); + rte_mbuf_verify(m, 0); /* prepend an ethernet header */ hdr = (struct ether_hdr *)rte_pktmbuf_prepend(m, hdr_len); @@ -2108,7 +2108,7 @@ create_packet(struct rte_mempool *pktmbuf_pool, GOTO_FAIL("%s: mbuf allocation failed!\n", __func__); if (rte_pktmbuf_pkt_len(pkt_seg) != 0) GOTO_FAIL("%s: Bad packet length\n", __func__); - rte_mbuf_sanity_check(pkt_seg, 0); + rte_mbuf_verify(pkt_seg, 0); /* Add header only for the first segment */ if (test_data->flags == MBUF_HEADER && seg == 0) { hdr_len = sizeof(struct rte_ether_hdr); @@ -2320,7 +2320,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool) GOTO_FAIL("%s: mbuf allocation failed!\n", __func__); if (rte_pktmbuf_pkt_len(m) != 0) GOTO_FAIL("%s: Bad packet length\n", __func__); - rte_mbuf_sanity_check(m, 0); + rte_mbuf_verify(m, 0); ext_buf_addr = rte_malloc("External buffer", buf_len, RTE_CACHE_LINE_SIZE); @@ -2484,8 +2484,8 @@ test_pktmbuf_ext_pinned_buffer(struct rte_mempool *std_pool) GOTO_FAIL("%s: test_pktmbuf_copy(pinned) failed\n", __func__); - if (test_failing_mbuf_sanity_check(pinned_pool) < 0) - GOTO_FAIL("%s: test_failing_mbuf_sanity_check(pinned)" + if (test_failing_mbuf_verify(pinned_pool) < 0) + GOTO_FAIL("%s: test_failing_mbuf_verify(pinned)" " failed\n", __func__); if (test_mbuf_linearize_check(pinned_pool) < 0) @@ -2859,8 +2859,8 @@ test_mbuf(void) goto err; } - if (test_failing_mbuf_sanity_check(pktmbuf_pool) < 0) { - printf("test_failing_mbuf_sanity_check() failed\n"); + if (test_failing_mbuf_verify(pktmbuf_pool) < 0) { + printf("test_failing_mbuf_verify() failed\n"); goto err; } diff --git a/doc/guides/prog_guide/mbuf_lib.rst b/doc/guides/prog_guide/mbuf_lib.rst index 049357c75563..0accb51a98c7 100644 --- a/doc/guides/prog_guide/mbuf_lib.rst +++ b/doc/guides/prog_guide/mbuf_lib.rst @@ -266,8 +266,8 @@ can be found in several of the sample applications, for example, the IPv4 Multic Debug ----- -In debug mode, the functions of the mbuf library perform sanity checks before any operation (such as, buffer corruption, -bad type, and so on). +In debug mode, the functions of the mbuf library perform consistency checks +before any operation (such as, buffer corruption, bad type, and so on). Use Cases --------- diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 81b93515cbd9..1e1544b5b644 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -146,3 +146,6 @@ Deprecation Notices will be deprecated and subsequently removed in DPDK 24.11 release. Before this, the new port library API (functions rte_swx_port_*) will gradually transition from experimental to stable status. + +* mbuf: The function ``rte_mbuf_sanity_check`` is deprecated. + Use the new function ``rte_mbuf_verify`` instead. diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index 53d9e38c939b..ae76fad84948 100644 --- a/drivers/net/avp/avp_ethdev.c +++ b/drivers/net/avp/avp_ethdev.c @@ -1231,7 +1231,7 @@ _avp_mac_filter(struct avp_dev *avp, struct rte_mbuf *m) #ifdef RTE_LIBRTE_AVP_DEBUG_BUFFERS static inline void -__avp_dev_buffer_sanity_check(struct avp_dev *avp, struct rte_avp_desc *buf) +__avp_dev_buffer_check(struct avp_dev *avp, struct rte_avp_desc *buf) { struct rte_avp_desc *first_buf; struct rte_avp_desc *pkt_buf; @@ -1272,12 +1272,12 @@ __avp_dev_buffer_sanity_check(struct avp_dev *avp, struct rte_avp_desc *buf) first_buf->pkt_len, pkt_len); } -#define avp_dev_buffer_sanity_check(a, b) \ - __avp_dev_buffer_sanity_check((a), (b)) +#define avp_dev_buffer_check(a, b) \ + __avp_dev_buffer_check((a), (b)) #else /* RTE_LIBRTE_AVP_DEBUG_BUFFERS */ -#define avp_dev_buffer_sanity_check(a, b) do {} while (0) +#define avp_dev_buffer_check(a, b) do {} while (0) #endif @@ -1302,7 +1302,7 @@ avp_dev_copy_from_buffers(struct avp_dev *avp, void *pkt_data; unsigned int i; - avp_dev_buffer_sanity_check(avp, buf); + avp_dev_buffer_check(avp, buf); /* setup the first source buffer */ pkt_buf = avp_dev_translate_buffer(avp, buf); @@ -1370,7 +1370,7 @@ avp_dev_copy_from_buffers(struct avp_dev *avp, rte_pktmbuf_pkt_len(m) = total_length; m->vlan_tci = vlan_tci; - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); return m; } @@ -1614,7 +1614,7 @@ avp_dev_copy_to_buffers(struct avp_dev *avp, char *pkt_data; unsigned int i; - __rte_mbuf_sanity_check(mbuf, 1); + __rte_mbuf_verify(mbuf, 1); m = mbuf; src_offset = 0; @@ -1680,7 +1680,7 @@ avp_dev_copy_to_buffers(struct avp_dev *avp, first_buf->vlan_tci = mbuf->vlan_tci; } - avp_dev_buffer_sanity_check(avp, buffers[0]); + avp_dev_buffer_check(avp, buffers[0]); return total_length; } @@ -1798,7 +1798,7 @@ avp_xmit_scattered_pkts(void *tx_queue, #ifdef RTE_LIBRTE_AVP_DEBUG_BUFFERS for (i = 0; i < nb_pkts; i++) - avp_dev_buffer_sanity_check(avp, tx_bufs[i]); + avp_dev_buffer_check(avp, tx_bufs[i]); #endif /* send the packets */ diff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c index 2677003da326..8199b56f2740 100644 --- a/drivers/net/sfc/sfc_ef100_rx.c +++ b/drivers/net/sfc/sfc_ef100_rx.c @@ -179,7 +179,7 @@ sfc_ef100_rx_qrefill(struct sfc_ef100_rxq *rxq) struct sfc_ef100_rx_sw_desc *rxd; rte_iova_t dma_addr; - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); dma_addr = rte_mbuf_data_iova_default(m); if (rxq->flags & SFC_EF100_RXQ_NIC_DMA_MAP) { @@ -551,7 +551,7 @@ sfc_ef100_rx_process_ready_pkts(struct sfc_ef100_rxq *rxq, rxq->ready_pkts--; pkt = sfc_ef100_rx_next_mbuf(rxq); - __rte_mbuf_raw_sanity_check(pkt); + __rte_mbuf_raw_verify(pkt); RTE_BUILD_BUG_ON(sizeof(pkt->rearm_data[0]) != sizeof(rxq->rearm_data)); @@ -575,7 +575,7 @@ sfc_ef100_rx_process_ready_pkts(struct sfc_ef100_rxq *rxq, struct rte_mbuf *seg; seg = sfc_ef100_rx_next_mbuf(rxq); - __rte_mbuf_raw_sanity_check(seg); + __rte_mbuf_raw_verify(seg); seg->data_off = RTE_PKTMBUF_HEADROOM; diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c index 78bd430363b1..74647e2792b1 100644 --- a/drivers/net/sfc/sfc_ef10_essb_rx.c +++ b/drivers/net/sfc/sfc_ef10_essb_rx.c @@ -125,7 +125,7 @@ sfc_ef10_essb_next_mbuf(const struct sfc_ef10_essb_rxq *rxq, struct rte_mbuf *m; m = (struct rte_mbuf *)((uintptr_t)mbuf + rxq->buf_stride); - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); return m; } @@ -136,7 +136,7 @@ sfc_ef10_essb_mbuf_by_index(const struct sfc_ef10_essb_rxq *rxq, struct rte_mbuf *m; m = (struct rte_mbuf *)((uintptr_t)mbuf + idx * rxq->buf_stride); - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); return m; } diff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c index 30a320d0791c..72b03b3bba7a 100644 --- a/drivers/net/sfc/sfc_ef10_rx.c +++ b/drivers/net/sfc/sfc_ef10_rx.c @@ -148,7 +148,7 @@ sfc_ef10_rx_qrefill(struct sfc_ef10_rxq *rxq) struct sfc_ef10_rx_sw_desc *rxd; rte_iova_t phys_addr; - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); SFC_ASSERT((id & ~ptr_mask) == 0); rxd = &rxq->sw_ring[id]; @@ -297,7 +297,7 @@ sfc_ef10_rx_process_event(struct sfc_ef10_rxq *rxq, efx_qword_t rx_ev, rxd = &rxq->sw_ring[pending++ & ptr_mask]; m = rxd->mbuf; - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); m->data_off = RTE_PKTMBUF_HEADROOM; rte_pktmbuf_data_len(m) = seg_len; diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 1dde2c111001..645c8643d1c1 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -120,7 +120,7 @@ sfc_efx_rx_qrefill(struct sfc_efx_rxq *rxq) ++i, id = (id + 1) & rxq->ptr_mask) { m = objs[i]; - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); rxd = &rxq->sw_desc[id]; rxd->mbuf = m; diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 6d0a8501eff5..f39658f4e249 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -258,7 +258,7 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone) hdr->pkt_len = (uint16_t)(hdr->data_len + pkt->pkt_len); hdr->nb_segs = pkt->nb_segs + 1; - __rte_mbuf_sanity_check(hdr, 1); + __rte_mbuf_verify(hdr, 1); return hdr; } /* >8 End of mcast_out_kt. */ diff --git a/lib/mbuf/rte_mbuf.c b/lib/mbuf/rte_mbuf.c index 686e797c80c4..91cb2f84f6a1 100644 --- a/lib/mbuf/rte_mbuf.c +++ b/lib/mbuf/rte_mbuf.c @@ -363,9 +363,9 @@ rte_pktmbuf_pool_create_extbuf(const char *name, unsigned int n, return mp; } -/* do some sanity checks on a mbuf: panic if it fails */ +/* do some checks on a mbuf: panic if it fails */ void -rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header) +rte_mbuf_verify(const struct rte_mbuf *m, int is_header) { const char *reason; @@ -373,6 +373,13 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header) rte_panic("%s\n", reason); } +/* For ABI compatibility, to be removed in next release */ +void +rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header) +{ + rte_mbuf_verify(m, is_header); +} + int rte_mbuf_check(const struct rte_mbuf *m, int is_header, const char **reason) { @@ -492,7 +499,7 @@ void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned int count) if (unlikely(m == NULL)) continue; - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); do { m_next = m->next; @@ -542,7 +549,7 @@ rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp) return NULL; } - __rte_mbuf_sanity_check(mc, 1); + __rte_mbuf_verify(mc, 1); return mc; } @@ -592,7 +599,7 @@ rte_pktmbuf_copy(const struct rte_mbuf *m, struct rte_mempool *mp, struct rte_mbuf *mc, *m_last, **prev; /* garbage in check */ - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); /* check for request to copy at offset past end of mbuf */ if (unlikely(off >= m->pkt_len)) @@ -656,7 +663,7 @@ rte_pktmbuf_copy(const struct rte_mbuf *m, struct rte_mempool *mp, } /* garbage out check */ - __rte_mbuf_sanity_check(mc, 1); + __rte_mbuf_verify(mc, 1); return mc; } @@ -667,7 +674,7 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len) unsigned int len; unsigned int nb_segs; - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); fprintf(f, "dump mbuf at %p, iova=%#" PRIx64 ", buf_len=%u\n", m, rte_mbuf_iova_get(m), m->buf_len); @@ -685,7 +692,7 @@ rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len) nb_segs = m->nb_segs; while (m && nb_segs != 0) { - __rte_mbuf_sanity_check(m, 0); + __rte_mbuf_verify(m, 0); fprintf(f, " segment at %p, data=%p, len=%u, off=%u, refcnt=%u\n", m, rte_pktmbuf_mtod(m, void *), diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h index 286b32b788a5..380663a0893b 100644 --- a/lib/mbuf/rte_mbuf.h +++ b/lib/mbuf/rte_mbuf.h @@ -339,13 +339,13 @@ rte_pktmbuf_priv_flags(struct rte_mempool *mp) #ifdef RTE_LIBRTE_MBUF_DEBUG -/** check mbuf type in debug mode */ -#define __rte_mbuf_sanity_check(m, is_h) rte_mbuf_sanity_check(m, is_h) +/** do mbuf type in debug mode */ +#define __rte_mbuf_verify(m, is_h) rte_mbuf_verify(m, is_h) #else /* RTE_LIBRTE_MBUF_DEBUG */ -/** check mbuf type in debug mode */ -#define __rte_mbuf_sanity_check(m, is_h) do { } while (0) +/** ignore mbuf checks if not in debug mode */ +#define __rte_mbuf_verify(m, is_h) do { } while (0) #endif /* RTE_LIBRTE_MBUF_DEBUG */ @@ -514,10 +514,9 @@ rte_mbuf_ext_refcnt_update(struct rte_mbuf_ext_shared_info *shinfo, /** - * Sanity checks on an mbuf. + * Check that the mbuf is valid and panic if corrupted. * - * Check the consistency of the given mbuf. The function will cause a - * panic if corruption is detected. + * Acts assertion that mbuf is consistent. If not it calls rte_panic(). * * @param m * The mbuf to be checked. @@ -526,13 +525,17 @@ rte_mbuf_ext_refcnt_update(struct rte_mbuf_ext_shared_info *shinfo, * of a packet (in this case, some fields like nb_segs are not checked) */ void +rte_mbuf_verify(const struct rte_mbuf *m, int is_header); + +/* Older deprecated name for rte_mbuf_verify() */ +void __rte_deprecated rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header); /** - * Sanity checks on a mbuf. + * Do consistency checks on a mbuf. * - * Almost like rte_mbuf_sanity_check(), but this function gives the reason - * if corruption is detected rather than panic. + * Check the consistency of the given mbuf and if not valid + * return the reason. * * @param m * The mbuf to be checked. @@ -551,7 +554,7 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header, const char **reason); /** - * Sanity checks on a reinitialized mbuf in debug mode. + * Do checks on a reinitialized mbuf in debug mode. * * Check the consistency of the given reinitialized mbuf. * The function will cause a panic if corruption is detected. @@ -563,16 +566,16 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header, * The mbuf to be checked. */ static __rte_always_inline void -__rte_mbuf_raw_sanity_check(__rte_unused const struct rte_mbuf *m) +__rte_mbuf_raw_verify(__rte_unused const struct rte_mbuf *m) { RTE_ASSERT(rte_mbuf_refcnt_read(m) == 1); RTE_ASSERT(m->next == NULL); RTE_ASSERT(m->nb_segs == 1); - __rte_mbuf_sanity_check(m, 0); + __rte_mbuf_verify(m, 0); } /** For backwards compatibility. */ -#define MBUF_RAW_ALLOC_CHECK(m) __rte_mbuf_raw_sanity_check(m) +#define MBUF_RAW_ALLOC_CHECK(m) __rte_mbuf_raw_verify(m) /** * Allocate an uninitialized mbuf from mempool *mp*. @@ -599,7 +602,7 @@ static inline struct rte_mbuf *rte_mbuf_raw_alloc(struct rte_mempool *mp) if (rte_mempool_get(mp, (void **)&m) < 0) return NULL; - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); return m; } @@ -622,7 +625,7 @@ rte_mbuf_raw_free(struct rte_mbuf *m) { RTE_ASSERT(!RTE_MBUF_CLONED(m) && (!RTE_MBUF_HAS_EXTBUF(m) || RTE_MBUF_HAS_PINNED_EXTBUF(m))); - __rte_mbuf_raw_sanity_check(m); + __rte_mbuf_raw_verify(m); rte_mempool_put(m->pool, m); } @@ -885,7 +888,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf *m) rte_pktmbuf_reset_headroom(m); m->data_len = 0; - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); } /** @@ -941,22 +944,22 @@ static inline int rte_pktmbuf_alloc_bulk(struct rte_mempool *pool, switch (count % 4) { case 0: while (idx != count) { - __rte_mbuf_raw_sanity_check(mbufs[idx]); + __rte_mbuf_raw_verify(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ case 3: - __rte_mbuf_raw_sanity_check(mbufs[idx]); + __rte_mbuf_raw_verify(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ case 2: - __rte_mbuf_raw_sanity_check(mbufs[idx]); + __rte_mbuf_raw_verify(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ case 1: - __rte_mbuf_raw_sanity_check(mbufs[idx]); + __rte_mbuf_raw_verify(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]); idx++; /* fall-through */ @@ -1184,8 +1187,8 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m) mi->pkt_len = mi->data_len; mi->nb_segs = 1; - __rte_mbuf_sanity_check(mi, 1); - __rte_mbuf_sanity_check(m, 0); + __rte_mbuf_verify(mi, 1); + __rte_mbuf_verify(m, 0); } /** @@ -1340,7 +1343,7 @@ static inline int __rte_pktmbuf_pinned_extbuf_decref(struct rte_mbuf *m) static __rte_always_inline struct rte_mbuf * rte_pktmbuf_prefree_seg(struct rte_mbuf *m) { - __rte_mbuf_sanity_check(m, 0); + __rte_mbuf_verify(m, 0); if (likely(rte_mbuf_refcnt_read(m) == 1)) { @@ -1411,7 +1414,7 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m) struct rte_mbuf *m_next; if (m != NULL) - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); while (m != NULL) { m_next = m->next; @@ -1492,7 +1495,7 @@ rte_pktmbuf_copy(const struct rte_mbuf *m, struct rte_mempool *mp, */ static inline void rte_pktmbuf_refcnt_update(struct rte_mbuf *m, int16_t v) { - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); do { rte_mbuf_refcnt_update(m, v); @@ -1509,7 +1512,7 @@ static inline void rte_pktmbuf_refcnt_update(struct rte_mbuf *m, int16_t v) */ static inline uint16_t rte_pktmbuf_headroom(const struct rte_mbuf *m) { - __rte_mbuf_sanity_check(m, 0); + __rte_mbuf_verify(m, 0); return m->data_off; } @@ -1523,7 +1526,7 @@ static inline uint16_t rte_pktmbuf_headroom(const struct rte_mbuf *m) */ static inline uint16_t rte_pktmbuf_tailroom(const struct rte_mbuf *m) { - __rte_mbuf_sanity_check(m, 0); + __rte_mbuf_verify(m, 0); return (uint16_t)(m->buf_len - rte_pktmbuf_headroom(m) - m->data_len); } @@ -1538,7 +1541,7 @@ static inline uint16_t rte_pktmbuf_tailroom(const struct rte_mbuf *m) */ static inline struct rte_mbuf *rte_pktmbuf_lastseg(struct rte_mbuf *m) { - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); while (m->next != NULL) m = m->next; return m; @@ -1582,7 +1585,7 @@ static inline struct rte_mbuf *rte_pktmbuf_lastseg(struct rte_mbuf *m) static inline char *rte_pktmbuf_prepend(struct rte_mbuf *m, uint16_t len) { - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); if (unlikely(len > rte_pktmbuf_headroom(m))) return NULL; @@ -1617,7 +1620,7 @@ static inline char *rte_pktmbuf_append(struct rte_mbuf *m, uint16_t len) void *tail; struct rte_mbuf *m_last; - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); m_last = rte_pktmbuf_lastseg(m); if (unlikely(len > rte_pktmbuf_tailroom(m_last))) @@ -1645,7 +1648,7 @@ static inline char *rte_pktmbuf_append(struct rte_mbuf *m, uint16_t len) */ static inline char *rte_pktmbuf_adj(struct rte_mbuf *m, uint16_t len) { - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); if (unlikely(len > m->data_len)) return NULL; @@ -1677,7 +1680,7 @@ static inline int rte_pktmbuf_trim(struct rte_mbuf *m, uint16_t len) { struct rte_mbuf *m_last; - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); m_last = rte_pktmbuf_lastseg(m); if (unlikely(len > m_last->data_len)) @@ -1699,7 +1702,7 @@ static inline int rte_pktmbuf_trim(struct rte_mbuf *m, uint16_t len) */ static inline int rte_pktmbuf_is_contiguous(const struct rte_mbuf *m) { - __rte_mbuf_sanity_check(m, 1); + __rte_mbuf_verify(m, 1); return m->nb_segs == 1; } diff --git a/lib/mbuf/version.map b/lib/mbuf/version.map index daa65e2bbdb2..c85370e430b2 100644 --- a/lib/mbuf/version.map +++ b/lib/mbuf/version.map @@ -31,6 +31,7 @@ DPDK_24 { rte_mbuf_set_platform_mempool_ops; rte_mbuf_set_user_mempool_ops; rte_mbuf_user_mempool_ops; + rte_mbuf_verify; rte_pktmbuf_clone; rte_pktmbuf_copy; rte_pktmbuf_dump; From patchwork Wed Nov 29 17:25:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134704 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F33D43403; Wed, 29 Nov 2023 18:31:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BB7842E61; Wed, 29 Nov 2023 18:31:39 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 0CF7742E59 for ; Wed, 29 Nov 2023 18:31:37 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6cdcd790f42so1109428b3a.3 for ; Wed, 29 Nov 2023 09:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279096; x=1701883896; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ksJmSbQRBda6mJczmSnP7sVMOFk/rLpepAambJjB4gY=; b=bFBnyepNZ+7PFyu+EB95hN+rB4CgW+Sx62lFzBwyMkr38lK4qdEvR+GVSAH9QZjaHp AftdSrY+paafyxkgvehxfss9VBF5P9lV/REtlnxXj7YvVXZ600mPYHGWMjJ7zBh1BhZy 1aBYtwXjZJQX9LcE7RLGB9Z66Fx5RRX2puDr91Fa8/3UcbLF3JFMD0GCpo0l9DQ6hwpX kg5ONaGztjEP7yywAoVYszkgShiDuRtxdTN2xy9aPbFzLedvVOTvZae+tDW+PJq/WzJS vCXitowOEaIt+/NsXUpsvqsdzsYqY57fvUzxLrhs+Pg7arwjYFFF/5ulJVe+Fy9c7WI8 kNKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279096; x=1701883896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ksJmSbQRBda6mJczmSnP7sVMOFk/rLpepAambJjB4gY=; b=EvuZ6MvuWgR3DAxQao9GDj7OTjfsPx8ygQwOOBIVk4RjnhEIeGa2ltndrFUmVL7MVy l7UuBbc9921zfSOmljIILT36eKJ3iGSBfB4opxp8AWC/v6ZVT9t0Ixc+cEUJTOseqoV1 lg8NyRSe/g+SAuZ+AT9i8AyeW/PILU0PwdpGX3AwNxFyCwTxe0NJOIQft1M4pIvuGUIW kIa/b3EtIlu0lLB7qdpvwX566C4KUQjB4/Xk0yA2WzZsB60WLrEE8m5orXmhauKdRjDV KHZlp+2Knn1B/RegHPDzGkhS+RLnZNTz/8SBrVu3lkjtCYIVVQ0DPgDtpe8nPHN7HgdD 1Mvw== X-Gm-Message-State: AOJu0Yw+un90kEGQtyl7YyYf6Qx79Fv/5s+zujHDnMMx3rJMinLPKDPE WPJCiN8DYEHdGLQ1qcugiv22WXcFfxP9HEAnB0I= X-Google-Smtp-Source: AGHT+IGvKcNghDbjFQScRKM+FsdmTFPs8ojcjcHyhpEcmGGuRm6fmN0EWBWxEtAzsdjUVbZTdCdSMw== X-Received: by 2002:a05:6a21:a591:b0:18c:138e:f268 with SMTP id gd17-20020a056a21a59100b0018c138ef268mr20181276pzc.21.1701279095987; Wed, 29 Nov 2023 09:31:35 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anatoly Burakov , Jerin Jacob , Sunil Kumar Kori , Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: [PATCH v5 02/19] eal: replace use of sanity check in comments and messages Date: Wed, 29 Nov 2023 09:25:56 -0800 Message-ID: <20231129173122.126895-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/common/eal_common_memory.c | 2 +- lib/eal/common/eal_common_proc.c | 3 ++- lib/eal/common/eal_common_trace.c | 2 +- lib/eal/common/eal_memcfg.h | 2 +- lib/eal/common/rte_malloc.c | 2 +- lib/eal/freebsd/eal.c | 2 +- lib/eal/linux/eal.c | 2 +- lib/eal/windows/eal.c | 2 +- 8 files changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c index d9433db62345..27adaf51e5ab 100644 --- a/lib/eal/common/eal_common_memory.c +++ b/lib/eal/common/eal_common_memory.c @@ -562,7 +562,7 @@ check_dma_mask(uint8_t maskbits, bool thread_unsafe) uint64_t mask; int ret; - /* Sanity check. We only check width can be managed with 64 bits + /* We only check width can be managed with 64 bits * variables. Indeed any higher value is likely wrong. */ if (maskbits > MAX_DMA_MASK_BITS) { RTE_LOG(ERR, EAL, "wrong dma mask size %u (Max: %u)\n", diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c index 728815c4a968..9f43c3199577 100644 --- a/lib/eal/common/eal_common_proc.c +++ b/lib/eal/common/eal_common_proc.c @@ -309,7 +309,8 @@ read_msg(int fd, struct mp_msg_internal *m, struct sockaddr_un *s) break; } } - /* sanity-check the response */ + + /* Check that the response is valid */ if (m->msg.num_fds < 0 || m->msg.num_fds > RTE_MP_MAX_FD_NUM) { RTE_LOG(ERR, EAL, "invalid number of fd's received\n"); return -1; diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c index 6ad87fc0df5d..b2bab5c45f1e 100644 --- a/lib/eal/common/eal_common_trace.c +++ b/lib/eal/common/eal_common_trace.c @@ -468,7 +468,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name, struct trace_point *tp; uint16_t sz; - /* Sanity checks of arguments */ + /* Check arguments */ if (name == NULL || register_fn == NULL || handle == NULL) { trace_err("invalid arguments"); rte_errno = EINVAL; diff --git a/lib/eal/common/eal_memcfg.h b/lib/eal/common/eal_memcfg.h index 60e2089797a2..e8a85df35585 100644 --- a/lib/eal/common/eal_memcfg.h +++ b/lib/eal/common/eal_memcfg.h @@ -18,7 +18,7 @@ * Memory configuration shared across multiple processes. */ struct rte_mem_config { - volatile uint32_t magic; /**< Magic number - sanity check. */ + volatile uint32_t magic; /**< Magic number check. */ uint32_t version; /**< Prevent secondary processes using different DPDK versions. */ diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c index 9db0c399aef0..153f8c8364cd 100644 --- a/lib/eal/common/rte_malloc.c +++ b/lib/eal/common/rte_malloc.c @@ -654,7 +654,7 @@ rte_malloc_heap_destroy(const char *heap_name) ret = -1; goto unlock; } - /* sanity checks done, now we can destroy the heap */ + /* checks done, now we can destroy the heap */ rte_spinlock_lock(&heap->lock); ret = malloc_heap_destroy(heap); rte_spinlock_unlock(&heap->lock); diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 568e06e9ed91..aa71e4e08422 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -501,7 +501,7 @@ eal_parse_args(int argc, char **argv) goto out; } - /* sanity checks */ + /* options checks */ if (eal_check_common_options(internal_conf) != 0) { eal_usage(prgname); ret = -1; diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 57da058cec60..14fd3ce4ec20 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -803,7 +803,7 @@ eal_parse_args(int argc, char **argv) goto out; } - /* sanity checks */ + /* options checks */ if (eal_check_common_options(internal_conf) != 0) { eal_usage(prgname); ret = -1; diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index 7ec215221158..3fb1e26f92b8 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -194,7 +194,7 @@ eal_parse_args(int argc, char **argv) if (eal_adjust_config(internal_conf) != 0) return -1; - /* sanity checks */ + /* options checks */ if (eal_check_common_options(internal_conf) != 0) { eal_usage(prgname); return -1; From patchwork Wed Nov 29 17:25:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134705 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13CC543403; Wed, 29 Nov 2023 18:31:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B458C42E66; Wed, 29 Nov 2023 18:31:40 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 7C52942E61 for ; Wed, 29 Nov 2023 18:31:38 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6cdcef8b400so1043503b3a.1 for ; Wed, 29 Nov 2023 09:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279097; x=1701883897; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=si5soSGbFiZu4C7ClAbfoYhyIncaCCZyhLKKmqRFX8o=; b=mmO7V/HEmNkNZ2Fyv1GCFaC5PH/PO2sAF4qWpkcFWwpE83V3TudSXDztiH+ct4O5+I Z92/ryilpe6JuAUNGZd7TUa1yI5qPRPktnV0ANkPvhhKTGskX3fx2EsB0XnlVBYQNaGj O0UBJ9fPkFa7TQkxZB4ttykGDCDOP/20Hjb5Gfw5pdT8ZP3mESsmWf/cAxR+ehzV1tWD U1IwM6Koc867GVAittcysqkXA074L2QXht8Hf3GcaZQqu2sE1MIq90XOQdu/qzEBr1se rANSTwNUp/JOE/EFEeZ+FUgdDr4YYJycaGIa0Hqr+yRjYqLR0D/AWNdhExcaYyOBq4kP mgug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279097; x=1701883897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=si5soSGbFiZu4C7ClAbfoYhyIncaCCZyhLKKmqRFX8o=; b=HecnFQH+8outTqJw4njfyNz9vJ6i41gufe+ZlLHa+DOhJPZS2/jAyQkyncCl5xFu9U 2dZjmCHvh9RN44c0O/PAlJQ5hx6AzTI5RVXg3VW7Cnr7SAPqopr+j80MWvbJHZHtcwYp DUKXd9dZ94alDrqU/y0keDPDDHZsXrjz2BUXHsayqyX5ii0peAQZB1D6YBl02bsYRREi +DaJZNQiS0WhvSt1vexYLB35K03nP9QhWP1TeWPWfRWerP7d1SIH7ff8nhBeTfV0+A6d whkvhz2WF3LGxUKbTOiGixYA0duurRbUjAgmacyV49J24/daihRCYPrtBLT/TocyLKrC 0UEw== X-Gm-Message-State: AOJu0YzEP9wLiYkz2ZHikM2EbH2HR6vik6kHW5sbW1R+LNsFagJ/q66x KMeXj8nG7c+XMEdxJj95WZJdaVBochjWJoeKmJY= X-Google-Smtp-Source: AGHT+IE2TG5SW60dVKijFCNQcaappmE6UhNSuiuYVd1UYhSTwI8iX/+h1mxdDZc00D1Kb2a5eUM4EA== X-Received: by 2002:a05:6a20:7493:b0:18b:9031:81a4 with SMTP id p19-20020a056a20749300b0018b903181a4mr19321106pzd.47.1701279097146; Wed, 29 Nov 2023 09:31:37 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu , Konstantin Ananyev , David Hunt , Chengwen Feng , Kevin Laatz , Bruce Richardson , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Harman Kalra , Chas Williams , "Min Hu (Connor)" , Sachin Saxena , Hemant Agrawal , Erik Gabriel Carrillo Subject: [PATCH v5 03/19] test: replace use word sanity Date: Wed, 29 Nov 2023 09:25:57 -0800 Message-ID: <20231129173122.126895-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The word "sanity" is on the not-allowed inclusive naming list. Replace the unnecessary usage in tests. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/test/test_bitmap.c | 4 +-- app/test/test_bpf.c | 6 ++-- app/test/test_common.c | 2 +- app/test/test_distributor.c | 46 +++++++++++++++--------------- app/test/test_dmadev.c | 2 +- app/test/test_eal_flags.c | 20 ++++++------- app/test/test_hash.c | 2 +- app/test/test_interrupts.c | 9 +++--- app/test/test_link_bonding_mode4.c | 2 +- app/test/test_mbuf.c | 2 +- app/test/test_rawdev.c | 2 +- app/test/test_timer.c | 10 +++---- 12 files changed, 54 insertions(+), 53 deletions(-) diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c index bab11812c767..a074b64f2e98 100644 --- a/app/test/test_bitmap.c +++ b/app/test/test_bitmap.c @@ -33,7 +33,7 @@ test_bitmap_scan_operations(struct rte_bitmap *bmp) } if (slab1_magic != out_slab) { - printf("Scan operation sanity failed.\n"); + printf("Scan operation magic number check failed.\n"); return TEST_FAILED; } @@ -43,7 +43,7 @@ test_bitmap_scan_operations(struct rte_bitmap *bmp) } if (slab2_magic != out_slab) { - printf("Scan operation sanity failed.\n"); + printf("Scan operation magic number check failed.\n"); return TEST_FAILED; } diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index f83e72a9adfd..ffadcece2212 100644 --- a/app/test/test_bpf.c +++ b/app/test/test_bpf.c @@ -3329,9 +3329,9 @@ test_bpf_match(pcap_t *pcap, const char *str, return ret; } -/* Basic sanity test can we match a IP packet */ +/* Basic test can we match a IP packet */ static int -test_bpf_filter_sanity(pcap_t *pcap) +test_bpf_filter_match(pcap_t *pcap) { const uint32_t plen = 100; struct rte_mbuf mb, *m; @@ -3463,7 +3463,7 @@ test_bpf_convert(void) return -1; } - rc = test_bpf_filter_sanity(pcap); + rc = test_bpf_filter_match(pcap); for (i = 0; i < RTE_DIM(sample_filters); i++) rc |= test_bpf_filter(pcap, sample_filters[i]); diff --git a/app/test/test_common.c b/app/test/test_common.c index 21eb2285e1b2..784cdaf3d640 100644 --- a/app/test/test_common.c +++ b/app/test/test_common.c @@ -19,7 +19,7 @@ {printf(x "() test failed!\n");\ return -1;} -/* this is really a sanity check */ +/* this is really a consistency check */ static int test_macros(int __rte_unused unused_parm) { diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 6cb27f4de111..915de3027bd0 100644 --- a/app/test/test_distributor.c +++ b/app/test/test_distributor.c @@ -80,7 +80,7 @@ clear_packet_count(void) __ATOMIC_RELAXED); } -/* this is the basic worker function for sanity test +/* this is the basic worker function * it does nothing but return packets and count them. */ static int @@ -105,7 +105,7 @@ handle_work(void *arg) return 0; } -/* do basic sanity testing of the distributor. This test tests the following: +/* do basic testing of the distributor. This test tests the following: * - send 32 packets through distributor with the same tag and ensure they * all go to the one worker * - send 32 packets through the distributor with two different tags and @@ -117,7 +117,7 @@ handle_work(void *arg) * not necessarily in the same order (as different flows). */ static int -sanity_test(struct worker_params *wp, struct rte_mempool *p) +basic_test(struct worker_params *wp, struct rte_mempool *p) { struct rte_distributor *db = wp->dist; struct rte_mbuf *bufs[BURST]; @@ -126,7 +126,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p) unsigned int retries; unsigned int processed; - printf("=== Basic distributor sanity tests ===\n"); + printf("=== Basic distributor tests ===\n"); clear_packet_count(); if (rte_mempool_get_bulk(p, (void *)bufs, BURST) != 0) { printf("line %d: Error getting mbufs from pool\n", __LINE__); @@ -163,7 +163,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p) printf("Worker %u handled %u packets\n", i, __atomic_load_n(&worker_stats[i].handled_packets, __ATOMIC_RELAXED)); - printf("Sanity test with all zero hashes done.\n"); + printf("Test with all zero hashes done.\n"); /* pick two flows and check they go correctly */ if (rte_lcore_count() >= 3) { @@ -191,7 +191,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p) __atomic_load_n( &worker_stats[i].handled_packets, __ATOMIC_RELAXED)); - printf("Sanity test with two hash values done\n"); + printf("Test with two hash values done\n"); } /* give a different hash value to each packet, @@ -219,11 +219,11 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p) printf("Worker %u handled %u packets\n", i, __atomic_load_n(&worker_stats[i].handled_packets, __ATOMIC_RELAXED)); - printf("Sanity test with non-zero hashes done\n"); + printf("Test with non-zero hashes done\n"); rte_mempool_put_bulk(p, (void *)bufs, BURST); - /* sanity test with BIG_BATCH packets to ensure they all arrived back + /* test with BIG_BATCH packets to ensure they all arrived back * from the returned packets function */ clear_packet_count(); struct rte_mbuf *many_bufs[BIG_BATCH], *return_bufs[BIG_BATCH]; @@ -288,7 +288,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p) return -1; } } - printf("Sanity test of returned packets done\n"); + printf("Test of returned packets done\n"); rte_mempool_put_bulk(p, (void *)many_bufs, BIG_BATCH); @@ -326,20 +326,20 @@ handle_work_with_free_mbufs(void *arg) return 0; } -/* Perform a sanity test of the distributor with a large number of packets, +/* Perform a test of the distributor with a large number of packets, * where we allocate a new set of mbufs for each burst. The workers then * free the mbufs. This ensures that we don't have any packet leaks in the * library. */ static int -sanity_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p) +basic_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p) { struct rte_distributor *d = wp->dist; unsigned i; struct rte_mbuf *bufs[BURST]; unsigned int processed; - printf("=== Sanity test with mbuf alloc/free (%s) ===\n", wp->name); + printf("=== Test with mbuf alloc/free (%s) ===\n", wp->name); clear_packet_count(); for (i = 0; i < ((1<dist; @@ -449,7 +449,7 @@ sanity_test_with_worker_shutdown(struct worker_params *wp, unsigned int failed = 0; unsigned int processed = 0; - printf("=== Sanity test of worker shutdown ===\n"); + printf("=== Test of worker shutdown ===\n"); clear_packet_count(); @@ -515,7 +515,7 @@ sanity_test_with_worker_shutdown(struct worker_params *wp, if (failed) return -1; - printf("Sanity test with worker shutdown passed\n\n"); + printf("Test with worker shutdown passed\n\n"); return 0; } @@ -611,13 +611,13 @@ handle_and_mark_work(void *arg) return 0; } -/* sanity_mark_test sends packets to workers which mark them. +/* mark_test sends packets to workers which mark them. * Every packet has also encoded sequence number. * The returned packets are sorted and verified if they were handled * by proper workers. */ static int -sanity_mark_test(struct worker_params *wp, struct rte_mempool *p) +mark_test(struct worker_params *wp, struct rte_mempool *p) { const unsigned int buf_count = 24; const unsigned int burst = 8; @@ -898,13 +898,13 @@ test_distributor(void) rte_eal_mp_remote_launch(handle_work, &worker_params, SKIP_MAIN); - if (sanity_test(&worker_params, p) < 0) + if (basic_test(&worker_params, p) < 0) goto err; quit_workers(&worker_params, p); rte_eal_mp_remote_launch(handle_work_with_free_mbufs, &worker_params, SKIP_MAIN); - if (sanity_test_with_mbuf_alloc(&worker_params, p) < 0) + if (basic_test_with_mbuf_alloc(&worker_params, p) < 0) goto err; quit_workers(&worker_params, p); @@ -912,7 +912,7 @@ test_distributor(void) rte_eal_mp_remote_launch(handle_work_for_shutdown_test, &worker_params, SKIP_MAIN); - if (sanity_test_with_worker_shutdown(&worker_params, + if (basic_test_with_worker_shutdown(&worker_params, p) < 0) goto err; quit_workers(&worker_params, p); @@ -927,7 +927,7 @@ test_distributor(void) rte_eal_mp_remote_launch(handle_and_mark_work, &worker_params, SKIP_MAIN); - if (sanity_mark_test(&worker_params, p) < 0) + if (mark_test(&worker_params, p) < 0) goto err; quit_workers(&worker_params, p); diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index 7581fc2b4cb0..899786b345ed 100644 --- a/app/test/test_dmadev.c +++ b/app/test/test_dmadev.c @@ -1087,7 +1087,7 @@ test_dma(void) parse_dma_env_var(); - /* basic sanity on dmadev infrastructure */ + /* basic validation on dmadev infrastructure */ if (test_apis() < 0) ERR_RETURN("Error performing API tests\n"); diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 6cb4b0675730..9c082ff91496 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -314,7 +314,7 @@ get_number_of_sockets(void) /* * Test that the app doesn't run with invalid allow option. - * Final tests ensures it does run with valid options as sanity check (one + * Final tests ensures it does run with valid options as basic test (one * test for with Domain+BDF, second for just with BDF) */ static int @@ -382,7 +382,7 @@ test_allow_flag(void) /* * Test that the app doesn't run with invalid blocklist option. - * Final test ensures it does run with valid options as sanity check + * Final test ensures it does run with valid options as basic check. */ static int test_invalid_b_flag(void) @@ -429,7 +429,7 @@ test_invalid_b_flag(void) /* * Test that the app doesn't run with invalid vdev option. - * Final test ensures it does run with valid options as sanity check + * Final test ensures it does run with valid options basic check. */ static int test_invalid_vdev_flag(void) @@ -554,7 +554,7 @@ test_missing_c_flag(void) /* bad coremask value */ const char *argv3[] = { prgname, prefix, mp_flag, "-c", "error" }; - /* sanity check of tests - valid coremask value */ + /* check of tests - valid coremask value */ const char *argv4[] = { prgname, prefix, mp_flag, "-c", "1" }; /* -l flag but no corelist value */ @@ -581,7 +581,7 @@ test_missing_c_flag(void) "-l", RTE_STR(RTE_MAX_LCORE) }; const char * const argv14[] = { prgname, prefix, mp_flag, "-l", "1-"RTE_STR(RTE_MAX_LCORE) }; - /* sanity check test - valid corelist value */ + /* check test - valid corelist value */ const char * const argv15[] = { prgname, prefix, mp_flag, "-l", "1-2,3" }; @@ -613,7 +613,7 @@ test_missing_c_flag(void) "--lcores", "(4-7)=(1,3)" }; const char * const argv28[] = { prgname, prefix, mp_flag, "--lcores", "[4-7]@(1,3)" }; - /* sanity check of tests - valid lcores value */ + /* more complex valid lcores value */ const char * const argv29[] = { prgname, prefix, mp_flag, "--lcores", "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"}; @@ -744,7 +744,7 @@ test_main_lcore_flag(void) /* * Test that the app doesn't run with invalid -n flag option. - * Final test ensures it does run with valid options as sanity check + * Final test ensures it does run with valid options as basic check. * Since -n is not compulsory for MP, we instead use --no-huge and --no-shconf * flags. */ @@ -772,10 +772,10 @@ test_invalid_n_flag(void) /* zero is invalid */ const char *argv3[] = { prgname, prefix, no_huge, no_shconf, "-n", "0" }; - /* sanity test - check with good value */ + /* check with good value */ const char *argv4[] = { prgname, prefix, no_huge, no_shconf, "-n", "2" }; - /* sanity test - check with no -n flag */ + /* check with no -n flag */ const char *argv5[] = { prgname, prefix, no_huge, no_shconf}; if (launch_proc(argv1) == 0 @@ -977,7 +977,7 @@ test_misc_flags(void) * All cases, apart from the first, app should run. * No further testing of output done. */ - /* sanity check - failure with invalid option */ + /* failure with invalid option */ const char *argv0[] = {prgname, prefix, mp_flag, "--invalid-opt"}; /* With --no-pci */ diff --git a/app/test/test_hash.c b/app/test/test_hash.c index d586878a2244..54e751b5eede 100644 --- a/app/test/test_hash.c +++ b/app/test/test_hash.c @@ -1088,7 +1088,7 @@ fbk_hash_unit_test(void) .socket_id = 0, }; - /* this is a sanity check for "same name" test + /* this is a check for "same name" test * creating this hash will check if we are actually able to create * multiple hashes with different names (instead of having just one). */ diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c index 3952f9685fd9..42b830e9368a 100644 --- a/app/test/test_interrupts.c +++ b/app/test/test_interrupts.c @@ -48,7 +48,7 @@ static union intr_pipefds pfds; * Check if the interrupt handle is valid. */ static inline int -test_interrupt_handle_sanity_check(struct rte_intr_handle *intr_handle) +test_interrupt_handle_check(struct rte_intr_handle *intr_handle) { if (!intr_handle || rte_intr_fd_get(intr_handle) < 0) return -1; @@ -164,7 +164,7 @@ test_interrupt_handle_compare(struct rte_intr_handle *intr_handle_l, #else /* to be implemented for bsd later */ static inline int -test_interrupt_handle_sanity_check(struct rte_intr_handle *intr_handle) +test_interrupt_handle_check(struct rte_intr_handle *intr_handle) { RTE_SET_USED(intr_handle); @@ -215,7 +215,7 @@ test_interrupt_callback(void *arg) return; } - if (test_interrupt_handle_sanity_check(intr_handle) < 0) { + if (test_interrupt_handle_check(intr_handle) < 0) { printf("null or invalid intr_handle for %s\n", __func__); flag = -1; return; @@ -241,7 +241,8 @@ static void test_interrupt_callback_1(void *arg) { struct rte_intr_handle *intr_handle = arg; - if (test_interrupt_handle_sanity_check(intr_handle) < 0) { + + if (test_interrupt_handle_check(intr_handle) < 0) { printf("null or invalid intr_handle for %s\n", __func__); flag = -1; return; diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index ff13dbed93f3..299b89f669ee 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -224,7 +224,7 @@ add_member(struct member_conf *member, uint8_t start) struct rte_ether_addr addr, addr_check; int retval; - /* Some sanity check */ + /* Some basic tests. */ RTE_VERIFY(test_params.member_ports <= member && member - test_params.member_ports < (int)RTE_DIM(test_params.member_ports)); RTE_VERIFY(member->bonding == 0); diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 261c6e5d71e9..7c73880090d4 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -1701,7 +1701,7 @@ test_mbuf_validate_tx_offload(const char *test_name, struct rte_mbuf *m = NULL; int ret = 0; - /* alloc a mbuf and do sanity check */ + /* alloc a mbuf and do some basic checks */ m = rte_pktmbuf_alloc(pktmbuf_pool); if (m == NULL) GOTO_FAIL("%s: mbuf allocation failed!\n", __func__); diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c index d34691dacf5f..0d4f0ce1fa17 100644 --- a/app/test/test_rawdev.c +++ b/app/test/test_rawdev.c @@ -47,7 +47,7 @@ test_rawdev_selftests(void) int ret = 0; int i; - /* basic sanity on rawdev infrastructure */ + /* basic check on rawdev infrastructure */ if (test_rawdev_selftest_skeleton() < 0) return -1; diff --git a/app/test/test_timer.c b/app/test/test_timer.c index cac8fc01149c..a23b5d8f2cb4 100644 --- a/app/test/test_timer.c +++ b/app/test/test_timer.c @@ -491,11 +491,11 @@ timer_basic_main_loop(__rte_unused void *arg) } static int -timer_sanity_check(void) +timer_check(void) { #ifdef RTE_LIBEAL_USE_HPET if (eal_timer_source != EAL_TIMER_HPET) { - printf("Not using HPET, can't sanity check timer sources\n"); + printf("Not using HPET, can't check timer sources\n"); return 0; } @@ -539,9 +539,9 @@ test_timer(void) return TEST_SKIPPED; } - /* sanity check our timer sources and timer config values */ - if (timer_sanity_check() < 0) { - printf("Timer sanity checks failed\n"); + /* check our timer sources and timer config values */ + if (timer_check() < 0) { + printf("Timer checks failed\n"); return TEST_FAILED; } From patchwork Wed Nov 29 17:25:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134706 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F319B43403; Wed, 29 Nov 2023 18:32:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C84042E71; Wed, 29 Nov 2023 18:31:43 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 0F0CC42E64 for ; Wed, 29 Nov 2023 18:31:40 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6cdd405ca77so770914b3a.0 for ; Wed, 29 Nov 2023 09:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279099; x=1701883899; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lpcMsnO9ztQN3kUBHOaBUp9eMNHuxn8APmUpSuSWxVA=; b=qgaj9gE5RbgrUCOYyx06bJoxxYg1FRCWBPXjbHkVI3/JW4uLAZzJ1Bw6+abeR9a+8v QjGJRYOiHRs5KSRFOgkyXS2DiIPyzc0a692EOftqhUYhBbu27atzV01TtGXN1gEoe7gV d4zCXM1XKfeTYH3L68emf7Qgl6kXrH/w8tmTnBuY5fPltJPWfAJe2xVp0A6wP0jZfZ7d UHtApA5ZdSmhdiUH1uJ/rU1tm+F7UyGLmXgQXWULzMzLqtr+493w82U/O43Y/OUmjNhl artaEJ1Y6qF1fOLT8gnUPkeWP3bLc72WEb0YpoWIgZxvvHbGAO44zGfU8eu7EEI9Jm9J t7WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279099; x=1701883899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lpcMsnO9ztQN3kUBHOaBUp9eMNHuxn8APmUpSuSWxVA=; b=ROs7oJoz+8vXHswbscPBJDD9d6G5YCaQllKfpjuWNYdq1gkM/45x4D1gqEuwEeWTuO kX7G+haRhNsuShE0/rkb585UoOn24F4NlrD6MLgCcxg5NVTQ+p2wSaxc7JM86QaBhTB4 Eyly2u8yA50fu1nxrmN0YHdkqsd9vd/ZYCy2LG8UJbH2tdC/IMwXmvpzXMHzOl0Pfn/R cGgt/ez6PQfMtK58uVbH/EGInGiD/fC6AGBeAwxm2T5YtsZ1R0NK5eF+WTjNEktO93Jv waUul8zgXVmAh0Ki5/O0LRqVje7/B5mzpmRdaBpk7zlERDo26Alqcgh8bgSmKUni91UA QerQ== X-Gm-Message-State: AOJu0YyV39f1xITmDxfS+KgPVjzq0r99DF/Gt7acQTDymN2j+mh7ohzu p1+aZeN1WByIMG8baNrJ0dxxACTecxiqXFaACzk= X-Google-Smtp-Source: AGHT+IEXJboIEpsbuI2LCtmxURdRshFtL/O3mXnzqoHhh7kF/zC41UVmbQbFoeyu3h5bxywEESyYTw== X-Received: by 2002:a05:6a00:e0f:b0:6cb:a653:d927 with SMTP id bq15-20020a056a000e0f00b006cba653d927mr17665425pfb.3.1701279098739; Wed, 29 Nov 2023 09:31:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Radu Nicolau , Akhil Goyal , Cristian Dumitrescu Subject: [PATCH v5 04/19] examples: remove term sanity Date: Wed, 29 Nov 2023 09:25:58 -0800 Message-ID: <20231129173122.126895-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 2 +- examples/qos_sched/args.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c index 89fb7e62a5a3..f595b4fe01dc 100644 --- a/examples/ipsec-secgw/event_helper.c +++ b/examples/ipsec-secgw/event_helper.c @@ -2100,7 +2100,7 @@ eh_launch_worker(struct eh_conf *conf, struct eh_app_worker_params *app_wrkr, goto clean_and_exit; } - /* Verify sanity of the matched worker */ + /* Verify validity of the matched worker */ if (eh_verify_match_worker(match_wrkr) != 1) { EH_LOG_ERR("Failed to validate the matched worker"); goto clean_and_exit; diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index e97273152aa7..1d8ba9522586 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -384,7 +384,7 @@ app_parse_args(int argc, char **argv) return -1; } - /* sanity check for cores assignment */ + /* check for cores assignment */ for(i = 0; i < nb_pfc; i++) { if (qos_conf[i].rx_core >= RTE_MAX_LCORE) { RTE_LOG(ERR, APP, "pfc %u: invalid RX lcore index %u\n", i + 1, From patchwork Wed Nov 29 17:25:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134707 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CA3B43403; Wed, 29 Nov 2023 18:32:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF24042E76; Wed, 29 Nov 2023 18:31:44 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 1FC4E42E68 for ; Wed, 29 Nov 2023 18:31:41 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6cde11fb647so236719b3a.1 for ; Wed, 29 Nov 2023 09:31:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279100; x=1701883900; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Lfvt3k3DtrG+364NbbTqMP3mwZnb3mqaculuXN6OnA=; b=qesf+9pKC6UFqCoi3psonF2qUwqv2J3JtnL9SrpzZtuft117qKHAqdScPr2tm0gXMB A4BvZqPNuO4TcVuWeU265eu5iQ+lNlLdVzlExsc/eTyvlGx8aUs9kyG6BDf5kRDkjn8o D6gZIWnU9g1qLL12c6q3wNANV25INbw91phCc/RAIKbQjtOUHqxpE4vFA08WOelOGFUI DFAi546gWiHhRx+otfscCHEYZkccDqDOzZ1ZIXMvMXhh6th/V+qUpbhQqxjO8k97R5Z0 M+9GcJuLgWKKM4Uzljb8l8exYQebUnq8VE+UgEKdgtjwXPnt9X1KLzmgV0mlSn0ZoxFf X+TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279100; x=1701883900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Lfvt3k3DtrG+364NbbTqMP3mwZnb3mqaculuXN6OnA=; b=pvTANlYG7N9q57FJYaOZDCwF7ZOMFbdViPVYpgrZy9935ItR3iZCBcwOA2G7Vw0PHP Q4MYyaw+tsZi409fRM8ME2k+oDtF7wkTFd178ACXZbaQ6r8jTL4Mjk/hcGXDRrgxBGfa QDBNTPW3e1JKzfm8LBFTqxieSYV5BnNzUnkPaYsxZ64IrH6B2QSMmBjsjcTsWilb5CO6 tS8VvFvnrW0tuEewqn1DR+6/TSsZ+Xk0RePVTLRPflCiwLLOEXeNqzYaFcFkwemjlwOw 5SYnuBkRE/75bAVy44459DxU5XFsATsFBoacVhVCRGr3bQ2xXfRclPhA2rs7JQ6cUGyQ dCOw== X-Gm-Message-State: AOJu0Yz6zoEf+U9ZhwLLrsd5gs9JWSOjaqtdlHUpdLUM3OAv5XTD3kgB JSPcbChWotT8D8JQ7UnXVaNqDscQC/JCgFGgsTs= X-Google-Smtp-Source: AGHT+IG7jGUbCz5lnNdlgvFKPFPWp8GrkjisvLe/l248z8B4uStgHayJBeDUhua3j2IJfuQ8r2OOCw== X-Received: by 2002:a05:6a20:3941:b0:18d:d16:e86 with SMTP id r1-20020a056a20394100b0018d0d160e86mr2453928pzg.59.1701279100014; Wed, 29 Nov 2023 09:31:40 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Reshma Pattan Subject: [PATCH v5 05/19] lib: replace use of sanity check in comments and messages Date: Wed, 29 Nov 2023 09:25:59 -0800 Message-ID: <20231129173122.126895-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c | 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib/pcapng/rte_pcapng.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/graph/graph.c b/lib/graph/graph.c index 26f0968a978d..e51dcc30568e 100644 --- a/lib/graph/graph.c +++ b/lib/graph/graph.c @@ -344,7 +344,7 @@ rte_graph_create(const char *name, struct rte_graph_param *prm) graph_spinlock_lock(); - /* Check arguments sanity */ + /* Check argument validity */ if (prm == NULL) SET_ERR_JMP(EINVAL, fail, "Param should not be NULL"); diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index cc32245c0593..cfb30ae07497 100644 --- a/lib/graph/graph_stats.c +++ b/lib/graph/graph_stats.c @@ -317,7 +317,7 @@ rte_graph_cluster_stats_create(const struct rte_graph_cluster_stats_param *prm) const char *pattern; rte_graph_t i; - /* Sanity checks */ + /* Validate arguments */ if (!rte_graph_has_stats_feature()) SET_ERR_JMP(EINVAL, fail, "Stats feature is not enabled"); diff --git a/lib/graph/node.c b/lib/graph/node.c index 99a962277964..c238d140ed31 100644 --- a/lib/graph/node.c +++ b/lib/graph/node.c @@ -68,7 +68,7 @@ __rte_node_register(const struct rte_node_register *reg) graph_spinlock_lock(); - /* Check sanity */ + /* Check argument validity */ if (reg == NULL || reg->process == NULL) { rte_errno = EINVAL; goto fail; diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index af565a14eaf3..1c4b280c952a 100644 --- a/lib/jobstats/rte_jobstats.c +++ b/lib/jobstats/rte_jobstats.c @@ -124,7 +124,7 @@ rte_jobstats_start(struct rte_jobstats_context *ctx, struct rte_jobstats *job) { uint64_t now; - /* Some sanity check. */ + /* Check validity of arguments. */ if (unlikely(ctx == NULL || job == NULL || job->context != NULL)) return -EINVAL; @@ -144,7 +144,7 @@ rte_jobstats_abort(struct rte_jobstats *job) struct rte_jobstats_context *ctx; uint64_t now, exec_time; - /* Some sanity check. */ + /* Check that arguments are valid */ if (unlikely(job == NULL || job->context == NULL)) return -EINVAL; @@ -165,7 +165,7 @@ rte_jobstats_finish(struct rte_jobstats *job, int64_t job_value) uint64_t now, exec_time; int need_update; - /* Some sanity check. */ + /* Check arguments */ if (unlikely(job == NULL || job->context == NULL)) return -EINVAL; diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index 0ccdbabc04eb..f60d4f3f6e25 100644 --- a/lib/metrics/rte_metrics.c +++ b/lib/metrics/rte_metrics.c @@ -120,7 +120,7 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names) uint16_t idx_name; uint16_t idx_base; - /* Some sanity checks */ + /* Some consistency checks */ if (cnt_names < 1 || names == NULL) return -EINVAL; for (idx_name = 0; idx_name < cnt_names; idx_name++) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index f74ec939a9f8..0de0a231693e 100644 --- a/lib/pcapng/rte_pcapng.c +++ b/lib/pcapng/rte_pcapng.c @@ -619,7 +619,7 @@ rte_pcapng_write_packets(rte_pcapng_t *self, struct pcapng_enhance_packet_block *epb; uint64_t cycles, timestamp; - /* sanity check that is really a pcapng mbuf */ + /* Check that is really a pcapng mbuf */ epb = rte_pktmbuf_mtod(m, struct pcapng_enhance_packet_block *); if (unlikely(epb->block_type != PCAPNG_ENHANCED_PACKET_BLOCK || epb->block_length != rte_pktmbuf_data_len(m))) { From patchwork Wed Nov 29 17:26:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134708 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 893DB43403; Wed, 29 Nov 2023 18:32:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A43C42E82; Wed, 29 Nov 2023 18:31:46 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 4207742E6A for ; Wed, 29 Nov 2023 18:31:42 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6cbbfdf72ecso6720943b3a.2 for ; Wed, 29 Nov 2023 09:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279101; x=1701883901; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G1DMWIoEKRqhkJ6G2NH8CwL1Di7HryQQs6/nhfsbnx8=; b=n46EdrRkd/vlwn4BmBlo0iFjFgFCSbYQkEv1OnHCPb5bNpiWvO5xMCZOgsc9jn3jhV r98cfaplP6zCQJUEUHJGyZR2MbnoEwcTOYQWcEvV0rqKb0h6oGFFIG5ddeNFEt2Q3i+u pPwiHVxU9i3f6+jBRNap83f96VkDo+ohVt/45HrhMvKOVgLvSMLcv9sZkUXOj5DpjwZw w+hcgTrCVDn+X0mpz7GWZq0Qiqa0klZrk6+Zrgyeq0of6+Nr1DuHAMJt3NUKSngDz8MS oB+3hVQqGkjj4s0qMq6D2vuuLcHMitz/B29x+POWQEka1nPopMmuP2txO+eBR9lKB+6d Vkmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279101; x=1701883901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G1DMWIoEKRqhkJ6G2NH8CwL1Di7HryQQs6/nhfsbnx8=; b=fCfDEy5myn+Anqshl67+M/9tDzvEHHjuuCFd8Rz/VoX/zGce5C1+2VRARPnJYM5CP7 /NDh0YP0ye/P32t1t+6j9CgYZ6M/poynQG5m2DYfPVfY1RrVXmnNg3IR5QcElfU9gPnl S5M3dsygnZV4nhLnkwfi4DRdR0pr4PjEFjgt8XyvpnmYOX4qJLtFuDqWqPpjmQ2tl1Ee MN8TNp67TzQBkz0ur29B+/vN/RQx1K4q2pOxa06wiYMgC48t/TzJ9ZVEepJXcaDGTGSN C5w/kjrE1zy7NvWcWhgr9eSAP+cEQrqpvMXEnHAOs5PyzOBeM6vT2uoM+sTq9z1Z6U9I 5Dhw== X-Gm-Message-State: AOJu0Ywvv2X6YPL7LgNtZHzWhoQfsjbZjYb6CoTESjRgMv0fpJt0J+lu te7HyVMNVXHWoZBcG2a5uksqYj6HqX7E3UifR+8= X-Google-Smtp-Source: AGHT+IF1QDQ10p27npW5EaiAO6tBgeHrA9Byu/THAkgVVVsyr8qIfeY5rURq+18z0ifCXSxN86s3Zw== X-Received: by 2002:a05:6a20:8f1c:b0:18c:f42c:d558 with SMTP id b28-20020a056a208f1c00b0018cf42cd558mr5785847pzk.28.1701279101307; Wed, 29 Nov 2023 09:31:41 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Elena Agostini , Harry van Haaren , Nicolas Chautru Subject: [PATCH v5 06/19] doc/eventdev_pipeline: remove sanity Date: Wed, 29 Nov 2023 09:26:00 -0800 Message-ID: <20231129173122.126895-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The word sanity check is unnecessary here. Signed-off-by: Stephen Hemminger --- doc/guides/gpus/cuda.rst | 2 +- doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +- doc/guides/tools/testbbdev.rst | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/guides/gpus/cuda.rst b/doc/guides/gpus/cuda.rst index 6520c17c3ea4..c523da1f3e9d 100644 --- a/doc/guides/gpus/cuda.rst +++ b/doc/guides/gpus/cuda.rst @@ -80,7 +80,7 @@ Similarly to CUDA shared library, if the **libgdrapi.so** shared library is not installed in default locations (e.g. /usr/local/lib), you can use the variable ``GDRCOPY_PATH_L``. -As an example, to enable the CPU map feature sanity check, +As an example, to enable the CPU map feature check, run the ``app/test-gpudev`` application with: .. code-block:: console diff --git a/doc/guides/sample_app_ug/eventdev_pipeline.rst b/doc/guides/sample_app_ug/eventdev_pipeline.rst index 19ff53803ede..e7787fb26609 100644 --- a/doc/guides/sample_app_ug/eventdev_pipeline.rst +++ b/doc/guides/sample_app_ug/eventdev_pipeline.rst @@ -50,7 +50,7 @@ these settings is shown below: .//examples/dpdk-eventdev_pipeline -l 0,2,8-15 --vdev event_sw0 \ -- -r1 -t1 -e4 -w FF00 -s4 -n0 -c32 -W1000 -D -The application has some sanity checking built-in, so if there is a function +The application has some internal validation, so if there is a function (e.g.; the RX core) which doesn't have a cpu core mask assigned, the application will print an error message: diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.rst index ddb8d787be6f..baaf9d115dda 100644 --- a/doc/guides/tools/testbbdev.rst +++ b/doc/guides/tools/testbbdev.rst @@ -9,7 +9,7 @@ dpdk-test-bbdev Application The ``dpdk-test-bbdev`` tool is a Data Plane Development Kit (DPDK) utility that allows measuring performance parameters of PMDs available in the bbdev framework. Tests available for execution are: latency, throughput, validation, -bler and sanity tests. Execution of tests can be customized using various +bler and basic functionality. Execution of tests can be customized using various parameters passed to a python running script. @@ -97,8 +97,8 @@ Test Cases There are 7 main test cases that can be executed using testbbdev tool: -* Sanity checks [-c unittest] - - Performs sanity checks on BBDEV interface, validating basic functionality +* Functional checks [-c unittest] + - Performs checks on BBDEV interface, validating basic functionality * Validation tests [-c validation] - Performs full operation of enqueue and dequeue @@ -232,7 +232,7 @@ vector name refer more explicitly processing specificity such as is purely read/written for external DDR, lbrm when limited buffer rate matching is expected, or crc_fail when a CRC failure is expected. They are chosen to have a good coverage across sizes and processing -parameters while still keeping their number limited as part of sanity +parameters while still keeping their number limited as part of functional regression. Shortened tree of isg_cid-wireless_dpdk_ae with dpdk compiled and output From patchwork Wed Nov 29 17:26:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134709 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA47943403; Wed, 29 Nov 2023 18:32:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2ABF42E84; Wed, 29 Nov 2023 18:31:47 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 1B60042E6C for ; Wed, 29 Nov 2023 18:31:43 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6cbd24d9557so5019b3a.1 for ; Wed, 29 Nov 2023 09:31:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279102; x=1701883902; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eEJq66fEafoO7Z8FgI8tlsen8St50kybHKD46NzA7+I=; b=X9UXH0vOni0xyNUH0u4WHf4X5N1TEtuQ3wDQYMbBLzV/yJBdex+jgqvRTAhI2am6xm 3fwhMPdMI4sBeT4DSdVmavIhNyHCRQpvBF5eTGIKbKZ2/jkCmRERRT34iu0G5g9dVcVz nhhNKAlJFpavqwD7YA3hAdhBI9984w5xxcr1hWNq4F8m3dAux9QseeXq+PaAEYgG2KOh p6UArRwn9tVJM9Vm+lBisWUIeMextyzeOOhVm9MH73JecGCa/vmMVMX+AmPJrRj7s63u bz964FGa1xALT23WKF8IB0IhTsQVFXd/aOLTJzlETx5Z9vFQ7clvxhxhyv/G75b0BTaC M3Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279102; x=1701883902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eEJq66fEafoO7Z8FgI8tlsen8St50kybHKD46NzA7+I=; b=boC6WKobar5u1f0kWShIny6DDdlrVpgyFbejh+/tfYcLJbhpxw3+Ht8tZ8ijjChgUr IpX8YqLrVwZ7cbp7Btzw+Czfzx1RIZfAYF7qDPLvVV7rPHuqWVfivUg+HgGtThkIy2W+ khQbMdvY9XgpyYMhCHasGyphXMlYDDfnfNq6X73z9eNYOYAplQy0pnGFmm+Q4a3MpWZp Y1NKJgfh51giOE/ZZjxjMqZiYOS0y1EToPrhLuTWTy/uczqL7vx0+hPlI8QCqOdFtGUK wkfNF5GK6UFEv6h6y564yBGCWMaT4M9ntvSuhe5SNF+vhb9RFz9QdAqD0sChK1vhnCM7 JFTA== X-Gm-Message-State: AOJu0YzQ82tc0iMK/zq5hl68PYBS4EFtTz3fQvdOTbaZ+lyJgzWGwCxW XrnPaxpPxOxrpqYEMbYAmqaG2C/5qJ5CetgX34w= X-Google-Smtp-Source: AGHT+IGnvRPSV3Q313pM2uEs7SgP2DZuAPBEvf6XvCdAzfz9OTKMqvuDKjXu4+vzsrqYFTf0z6CxnA== X-Received: by 2002:a05:6a00:17a1:b0:6cd:dc48:1fff with SMTP id s33-20020a056a0017a100b006cddc481fffmr2159112pfg.0.1701279102108; Wed, 29 Nov 2023 09:31:42 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v5 07/19] net/ring: replace use of sanity Date: Wed, 29 Nov 2023 09:26:01 -0800 Message-ID: <20231129173122.126895-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Don't use term sanity check Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 48953dd7a059..710fd9ebe526 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -34,7 +34,7 @@ struct ring_internal_args { struct rte_ring * const *tx_queues; const unsigned int nb_tx_queues; const unsigned int numa_node; - void *addr; /* self addr for sanity check */ + void *addr; /* self addr for verification */ }; enum dev_action { @@ -606,10 +606,7 @@ static int parse_kvlist(const char *key __rte_unused, *action = '\0'; action++; - /* - * Need to do some sanity checking here - */ - + /* Check the command argument is valid action */ if (strcmp(action, ETH_RING_ACTION_ATTACH) == 0) info->list[info->count].action = DEV_ATTACH; else if (strcmp(action, ETH_RING_ACTION_CREATE) == 0) From patchwork Wed Nov 29 17:26:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134710 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0905A43403; Wed, 29 Nov 2023 18:32:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8B6F42E87; Wed, 29 Nov 2023 18:31:48 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 39AB642E74 for ; Wed, 29 Nov 2023 18:31:44 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6cdd405ca77so771019b3a.0 for ; Wed, 29 Nov 2023 09:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279103; x=1701883903; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uxzqi3Ttw66KFa+NRBUaaeEWM0wPDaO0ETmcAD43CLY=; b=H5dacleHdXqD1tY/PkvzULXz5ihDpwcEPPdi+gywABdJ9FhdYifspYSXzaTxdCYYwi 6q19XRZbT1gBTmZh+zYX4jgH0NFshlSQfDojT1j3kAXDU9voos1VyGIQaPzAgZdC+S9C XcEHNIZ97wIpqTry6rvjBNzj2gmduLYO7DH38Xil7z2i5NZ+nIDS4zeFYEYjuX5kSeoe mxKcQS+EOU58zyTFReHTOGoyC/Uu9YEtiMSfwD22R6rsI3Qus1xNzkFIBaIGRnifm9ZS +z7lEchiCzq+StEnATU0ozwk6wGJI2cgh/5psPnf2Npm8I9C+nILpdJhMhQoFHvIi/wr LqrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279103; x=1701883903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uxzqi3Ttw66KFa+NRBUaaeEWM0wPDaO0ETmcAD43CLY=; b=rTfyLnZGR5cJHwcqfFt9a8SKDkyVnWmOBwlwUy4Qs1QKSByPtd2F2RpWoOFMUhGzKj eXp8xslD1pepOcdPpp47O2CpsvnV8vxO2KUIggZZ7sN6V6DlQyOg5L/5t7I5zn3n4lIF HMa3Dlyn/KUwA6A6Y6nz/hajFNW+W04NLjJYp6/zXknsumRXtCcH9y1+4/VWx0pADqeq aFVw5KfFiIeZD5nWXy5D2YqQnBSuekj5HFs19UmCyu3eNd7QvVU6AgXBFxaGO7svjRZf hVrTwwNGIhgqVDCxWXqChZki4KmdNPUbzluaGhSD+LNFKzLp5tjqvMXYI3z6se2NUTRX bmjQ== X-Gm-Message-State: AOJu0YyF95Deez12F11ahwC4nq+G/GPrSY9F0aWN01LK0Wv79Vxolxsn Reyh/Kvqoy8cnmp8wwTkPsi+XBVQZZ9fnyHTUHc= X-Google-Smtp-Source: AGHT+IEOxJtQeqcmoMuiy+5o5yAMlWunjRY2SiEYECii16KK96mkYIZzrMl7mwEuxXzF2oHdLZGyjw== X-Received: by 2002:a05:6a00:15cb:b0:6cd:85a4:bbbc with SMTP id o11-20020a056a0015cb00b006cd85a4bbbcmr14319146pfu.9.1701279103187; Wed, 29 Nov 2023 09:31:43 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Qi Zhang , Xiao Wang , Qiming Yang , Wenjun Wu Subject: [PATCH v5 08/19] net/fm10k, net/ixgbe: remove word sanity Date: Wed, 29 Nov 2023 09:26:02 -0800 Message-ID: <20231129173122.126895-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 4d3c4c10cfa4..894cf8c8a6b5 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1757,7 +1757,7 @@ mempool_element_size_valid(struct rte_mempool *mp) /* account for up to 512B of alignment */ min_size -= FM10K_RX_DATABUF_ALIGN; - /* sanity check for overflow */ + /* check for overflow */ if (min_size > mp->elt_size) return 0; diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c index c0841ab8cb34..94345299b22a 100644 --- a/drivers/net/fm10k/fm10k_rxtx.c +++ b/drivers/net/fm10k/fm10k_rxtx.c @@ -647,7 +647,7 @@ fm10k_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, if (q->nb_free < mb->nb_segs) break; - /* sanity check to make sure the mbuf is valid */ + /* check to make sure the mbuf is valid */ if ((mb->nb_segs == 0) || ((mb->nb_segs > 1) && (mb->next == NULL))) break; diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c index 06d6e2126de5..51bbf577e3fe 100644 --- a/drivers/net/ixgbe/ixgbe_fdir.c +++ b/drivers/net/ixgbe/ixgbe_fdir.c @@ -1130,7 +1130,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev, return -ENOTSUP; /* - * Sanity check for x550. + * Check for x550. * When adding a new filter with flow type set to IPv4, * the flow director mask should be configed before, * and the L4 protocol and ports are masked. diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index d3313085560d..d4aa3e9ede8e 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@ -615,7 +615,7 @@ ixgbe_crypto_enable_ipsec(struct rte_eth_dev *dev) rx_offloads = dev->data->dev_conf.rxmode.offloads; tx_offloads = dev->data->dev_conf.txmode.offloads; - /* sanity checks */ + /* input validation */ if (rx_offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) { PMD_DRV_LOG(ERR, "RSC and IPsec not supported"); return -1; diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 90b0a7004f50..0e53b8a73a18 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -4983,7 +4983,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) uint32_t rdrxctl; uint32_t rfctl; - /* Sanity check */ + /* Offload check */ dev->dev_ops->dev_infos_get(dev, &dev_info); if (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_TCP_LRO) rsc_capable = true; From patchwork Wed Nov 29 17:26:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134711 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D287A43403; Wed, 29 Nov 2023 18:32:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20BC842E8B; Wed, 29 Nov 2023 18:31:50 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 92CF342E79 for ; Wed, 29 Nov 2023 18:31:45 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6cd89f2af9dso3833409b3a.1 for ; Wed, 29 Nov 2023 09:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279104; x=1701883904; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SozmnMQ+/COanvlxBS4cZTKyNTWwgjsp8i2+BJb8MQU=; b=EUpVSmDz02BLGCiGgFdE2qcoOjtWkOeb63Oth9iZrXvkk0ag58CZqkYJou0IDSw1Vm hs82MYBtS6kmudSsL2t6aadu/sr0OD93mEax0y1QcKF9G1tgDPq2bJMLb8A5XuwdKT4w C9pC4xs+RXeRg+mrxXURvezdrwViYNaqp8Qxg+VlfSuN0hnTEmv8sjvJiz54JDemkK9y 79sdGmAYfhMHrh/SRjvWaeg8I1M1h0pqwLm2GjWKCiRf27vVMFLLMG6e18rwny7HlLLd PMpHn68xNy7TKK+C9mcOLdTA3FdRbIImRc0Y+4B98DcH4vTm8OCARHFs1SHsBKrpcxZe tyTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279104; x=1701883904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SozmnMQ+/COanvlxBS4cZTKyNTWwgjsp8i2+BJb8MQU=; b=uFa1h/4tyWOVpz7vf4bjkbZe7O9SiwJvxgVjjbYFk6DuMgddYMxkPHOU1+jpo9WiYr cmZg0OXPLHU7TZWP22V4SowgwVbn3mQx2sbIhMfAU6HlSXxJvtjliGNkja0UICj++SHC gy4LavFYI3xqvJYAtxSUucsNp1NAFZxs6Hf3Zp4FV835J0lTlLwwS2+z8BCx6xNqphNU EzeQhEQLc2TUEBVgJ3FJ/N+AJtsaJk0pG2ZBiTTTf67WlzRugP356gmgEPLBjinfvVPD /dZQ4IDoG+rRcTWYgQz4Yr2qnmG2DpaWrnZ5IbfN2tmDXn0wGA/zHLILJiDCVJ/8QNr7 XFtw== X-Gm-Message-State: AOJu0Yz25IiH9l5iwVsUFvrU5tOG4R7EaKEkrhs9IajiIqbmx1kYUBQq zcb73/2H3Iw+W5FRNXwZRbGd5cFeUQQ02EUvoKyXgQ== X-Google-Smtp-Source: AGHT+IEdL8+hpT1Kg5SIS3DtgB2NQOw5oPnB5jIrVLZCM9Z/cu9g2pAEqhVs8JzuPFwTe15nnN1dWg== X-Received: by 2002:a05:6a20:4420:b0:18c:28e8:d55f with SMTP id ce32-20020a056a20442000b0018c28e8d55fmr23306929pzb.8.1701279104398; Wed, 29 Nov 2023 09:31:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v5 09/19] net/mlx[45]: remove word sanity Date: Wed, 29 Nov 2023 09:26:03 -0800 Message-ID: <20231129173122.126895-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The term "sanity" is on non-inclusive naming list. Remove it from the Nvidia drivers. Signed-off-by: Stephen Hemminger Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/net/mlx4/mlx4.c | 2 +- drivers/net/mlx4/mlx4_flow.c | 6 +++--- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 ++---- drivers/net/mlx5/mlx5_rxq.c | 2 +- drivers/net/mlx5/mlx5_rxtx_vec.h | 2 +- 7 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c index 41345e1597a4..2caa1a1da0b6 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.c +++ b/drivers/common/mlx5/linux/mlx5_common_os.c @@ -235,7 +235,7 @@ mlx5_get_ifname_sysfs(const char *ibdev_path, char *ifname) /** * Suffix RTE_EAL_PMD_PATH with "-glue". * - * This function performs a sanity check on RTE_EAL_PMD_PATH before + * This function performs a check on RTE_EAL_PMD_PATH before * suffixing its last component. * * @param buf[out] diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index a1a7e9328848..c167d7f90f97 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -1216,7 +1216,7 @@ static struct rte_pci_driver mlx4_driver = { /** * Suffix RTE_EAL_PMD_PATH with "-glue". * - * This function performs a sanity check on RTE_EAL_PMD_PATH before + * This function performs a check on RTE_EAL_PMD_PATH before * suffixing its last component. * * @param buf[out] diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 8ef9fd2db44e..25b185d8710c 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -514,7 +514,7 @@ mlx4_flow_merge_tcp(struct rte_flow *flow, } /** - * Perform basic sanity checks on a pattern item. + * Perform basic checks on a pattern item. * * @param[in] item * Item specification. @@ -730,7 +730,7 @@ mlx4_flow_prepare(struct mlx4_priv *priv, goto exit_item_not_supported; proc = next; /* - * Perform basic sanity checks only once, while handle is + * Perform basic checks only once, while handle is * not allocated. */ if (flow == &temp) { @@ -799,7 +799,7 @@ mlx4_flow_prepare(struct mlx4_priv *priv, rss_key = mlx4_rss_hash_key_default; rss_key_len = MLX4_RSS_HASH_KEY_SIZE; } - /* Sanity checks. */ + /* Input checks. */ for (i = 0; i < rss->queue_num; ++i) if (rss->queue[i] >= ETH_DEV(priv)->data->nb_rx_queues) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 115d7303172d..254dc521c78e 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -8820,7 +8820,7 @@ flow_dv_prepare(struct rte_eth_dev *dev, #ifdef RTE_LIBRTE_MLX5_DEBUG /** - * Sanity check for match mask and value. Similar to check_valid_spec() in + * Check for match mask and value. Similar to check_valid_spec() in * kernel driver. If unmasked bit is present in value, it returns failure. * * @param match_mask diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index da873ae2e243..69bf3c51f886 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7453,11 +7453,10 @@ flow_hw_tx_tag_regc_mask(struct rte_eth_dev *dev) struct mlx5_priv *priv = dev->data->dev_private; uint32_t mask = priv->sh->dv_regc0_mask; - /* Mask is verified during device initialization. Sanity checking here. */ + /* Mask is verified during device initialization. */ MLX5_ASSERT(mask != 0); /* * Availability of sufficient number of bits in REG_C_0 is verified on initialization. - * Sanity checking here. */ MLX5_ASSERT(rte_popcount32(mask) >= rte_popcount32(priv->vport_meta_mask)); return mask; @@ -7469,12 +7468,11 @@ flow_hw_tx_tag_regc_value(struct rte_eth_dev *dev) struct mlx5_priv *priv = dev->data->dev_private; uint32_t tag; - /* Mask is verified during device initialization. Sanity checking here. */ + /* Mask is verified during device initialization. */ MLX5_ASSERT(priv->vport_meta_mask != 0); tag = priv->vport_meta_tag >> (rte_bsf32(priv->vport_meta_mask)); /* * Availability of sufficient number of bits in REG_C_0 is verified on initialization. - * Sanity checking here. */ MLX5_ASSERT((tag & priv->sh->dv_regc0_mask) == tag); return tag; diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 1bb036afebb3..fbe5cfd30201 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1442,7 +1442,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev) desc *= 4; obj_num = desc + MLX5_MPRQ_MP_CACHE_SZ * n_ibv; /* - * rte_mempool_create_empty() has sanity check to refuse large cache + * rte_mempool_create_empty() has basic check to refuse large cache * size compared to the number of elements. * CACHE_FLUSHTHRESH_MULTIPLIER is defined in a C file, so using a * constant number 2 instead. diff --git a/drivers/net/mlx5/mlx5_rxtx_vec.h b/drivers/net/mlx5/mlx5_rxtx_vec.h index 77c3f4efa019..f8376f2b55b4 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec.h +++ b/drivers/net/mlx5/mlx5_rxtx_vec.h @@ -21,7 +21,7 @@ RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) /* - * Compile time sanity check for vectorized functions. + * Compile time checks for vectorized functions. */ #define S_ASSERT_RTE_MBUF(s) \ From patchwork Wed Nov 29 17:26:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134712 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7CCA43403; Wed, 29 Nov 2023 18:32:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C7EA42E8F; Wed, 29 Nov 2023 18:31:51 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id DF3FD42E84 for ; Wed, 29 Nov 2023 18:31:46 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6cddc59e731so468530b3a.1 for ; Wed, 29 Nov 2023 09:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279106; x=1701883906; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UBLntP9o6xl3gmjrYVPBTAd938lQ1p4270FJzkP4c94=; b=Un1tKXlC1hM+arHTPUKBGAhyzRvz9CSKtkzdgLRWmSMbtDj256h0+JBH3EKTXACg3o 959JccbpqMLjOwAzDhMiLVT3WzjO4N4eTjh39CiXovT2c+jm+FJWhzPkmyVvCTJ/NeC7 ZTosh9PaURdsVMtDjQjtXXU9x+kuSe/9QyPGDmc68o2eLuZrfZeU1jXwjktxAXHXHaKS Vm2wYfONy/N3Uf2/mc/QV41G4VF/KXGn6vSdNJuQFCHdEre8gWXs5Q2SsVgGwo+cfda3 +Cfhj5tVPRFHK3AzgvDShcKphcH2GThSgL2cDcpdF43AvPdpRaXJVSrJ7N5XKy3XFv9+ gQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279106; x=1701883906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UBLntP9o6xl3gmjrYVPBTAd938lQ1p4270FJzkP4c94=; b=OoAdlcGUw1mmIdKetylt13rf0+ShSVkCSrmwaOiErvoyyFT6WVo3zR6M4jwv5vOr0w EDrUTahdXxygmEslF8OlgKjQforX0xAnRhBkx+RipdKvRF9MXvxsTJkvSL3aPx8ZtY9M UYMJDhH0GwrKRQcaPxsgq4jn5vi2HeVlhymgrEWWYB48FZdfC1HYcOBYX0XULD9Buwm8 9sN1bPLZb/5euEXusuXsZlMhhh92J1hjRS+n8lS1ShCce9pdWJMQZQ45manfZe0ql+y/ PNZY++jz/d34ZDfuLxuJrM5pTzzfwhf5615mp0kFWSUjX2s3kWa47sB6w9yEBYLeo4Lr ceww== X-Gm-Message-State: AOJu0Yxr5LNWHtVc6m8VgvRMnez/tlBNh1izYBHRCo5K/LrZ1NsMeVg1 skRUH8kBkRUXOyrH3gyyIp/ItY5rMJzUNW3tId4= X-Google-Smtp-Source: AGHT+IEo3cSOY8ifJBR3Q3N6tD4mOhJIZastmqHFpO0Uv161BLgBahkesfAAnKXqMrh5qwSQBtD4Og== X-Received: by 2002:a05:6a21:2711:b0:18b:1f3c:eeb9 with SMTP id rm17-20020a056a21271100b0018b1f3ceeb9mr17570650pzb.36.1701279105605; Wed, 29 Nov 2023 09:31:45 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Subject: [PATCH v5 10/19] net/sfc: remove term "sanity check" Date: Wed, 29 Nov 2023 09:26:04 -0800 Message-ID: <20231129173122.126895-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove term sanity check in comment. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h index 9f9bf2898881..dfb4fb98844b 100644 --- a/drivers/net/sfc/sfc_dp_rx.h +++ b/drivers/net/sfc/sfc_dp_rx.h @@ -59,7 +59,7 @@ struct sfc_dp_rx_qcreate_info { /** * Maximum number of Rx descriptors completed in one Rx event. - * Just for sanity checks if datapath would like to do. + * Checks if datapath would like to do. */ unsigned int batch_max; From patchwork Wed Nov 29 17:26:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134713 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6294643403; Wed, 29 Nov 2023 18:33:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9578142E95; Wed, 29 Nov 2023 18:31:52 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id EC13E42E87 for ; Wed, 29 Nov 2023 18:31:47 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6cdce15f0a3so861867b3a.1 for ; Wed, 29 Nov 2023 09:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279107; x=1701883907; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GrvBG2IEYTGJhjwiY8/08dW3Foe/XTeIhmc67CAplqE=; b=WV9XSQHZm5AYJYskR1kYsGsNMJr21FtUKRpuYe9WE1ETQHrfUmrAvhnNWuHDsxOV62 CUt5n/lt5B6dVcFVkbTj6swoKH58qk15aUgK4G/v8nW6nunr8rep0B4eB/XgwhihCtgR e5PTKykr7gkvtCaETb+FFUNTFltGdoh0+Ay6LkHAQ20tSniBI3YL1WsmNzIKot6p/i0I LmfzENeeR3/jRi89UHC53zSQ7iUSJEjmyvee/tyf6UcA1gHymg0AUUcylAM01pLZdUIQ cYFSm3emZDJ88IUHz0FRy01XArR7t19z3cci1jnBwbmLdvaSBouh47bdqvSttxQmox5I uS/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279107; x=1701883907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GrvBG2IEYTGJhjwiY8/08dW3Foe/XTeIhmc67CAplqE=; b=ARe0E4lOnD2yKp6AqtkvdK5M2qYpJk/Er3+VDth8C+jiIjR+F5k6DrQpqSkhefA/cK Z+Nee9in0XOj86x67eu2eGSX6hjcFOpUC06fXIUxCYldDSDhtHhtwhjaVbu2PI+WXCsw KFLiyYgBIMg7lAeddPBzqTsCKpStjkznwBliZ65GLnYDZt8Xsk3qrKyeCqwuWsB7cfcD GV3/pJu+SsZpquKjwn5Oyi7JlceqsTvY1JDdBE+TVGHxefzpGxGB3yum4adKzqSdu9SS TT+jgGVsuWJ+kbC0dbQ0Rg+LUk3t6SCxL238hGNH/C0LQOP9Y0/ag5Hn60w4xzNsfAXB aXAg== X-Gm-Message-State: AOJu0YxFtxP6IJHukQB++9Q0eU+8S5KoYQW+q3F8bBbnMAKlHSzo6ZyC sYsmByxNKLDdef55W33Q9TEt/Q6pWu7Rz8iP8AAZkA== X-Google-Smtp-Source: AGHT+IHrjtM7Ra+K45ZAMSQLydNvdNA8/tkPx54pk7piD6+PS6l0THbWvTYkEKwj8t7KzGYpygeFag== X-Received: by 2002:a05:6a20:2449:b0:187:5db4:168c with SMTP id t9-20020a056a20244900b001875db4168cmr24726318pzc.31.1701279106850; Wed, 29 Nov 2023 09:31:46 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Shepard Siegel , Ed Czeck , John Miller Subject: [PATCH v5 11/19] net/ark: replace use of term sanity Date: Wed, 29 Nov 2023 09:26:05 -0800 Message-ID: <20231129173122.126895-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/ark/ark_ethdev.c | 8 ++++---- drivers/net/ark/ark_ethdev_rx.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index 0ffd4b9e9e4a..68edb542db43 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -346,10 +346,10 @@ eth_ark_dev_init(struct rte_eth_dev *dev) ARK_PMD_LOG(NOTICE, "Arkville HW Commit_ID: %08x\n", rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4])); - /* If HW sanity test fails, return an error */ + /* If HW test fails, return an error */ if (ark->sysctrl.t32[4] != 0xcafef00d) { ARK_PMD_LOG(ERR, - "HW Sanity test has failed, expected constant" + "HW test has failed, expected constant" " 0x%x, read 0x%x (%s)\n", 0xcafef00d, ark->sysctrl.t32[4], __func__); @@ -357,7 +357,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) } ARK_PMD_LOG(DEBUG, - "HW Sanity test has PASSED, expected constant" + "HW test has PASSED, expected constant" " 0x%x, read 0x%x (%s)\n", 0xcafef00d, ark->sysctrl.t32[4], __func__); @@ -587,7 +587,7 @@ eth_ark_dev_start(struct rte_eth_dev *dev) rte_thread_t thread; /* Delay packet generator start allow the hardware to be ready - * This is only used for sanity checking with internal generator + * This is only used for checking with internal generator */ char tname[RTE_THREAD_INTERNAL_NAME_SIZE]; snprintf(tname, sizeof(tname), "ark-pg%d", dev->data->port_id); diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c index 24f1c65690eb..8ac9d904e795 100644 --- a/drivers/net/ark/ark_ethdev_rx.c +++ b/drivers/net/ark/ark_ethdev_rx.c @@ -283,7 +283,7 @@ eth_ark_recv_pkts(void *rx_queue, mbuf->pkt_len = meta->pkt_len; mbuf->data_len = meta->pkt_len; - if (ARK_DEBUG_CORE) { /* debug sanity checks */ + if (ARK_DEBUG_CORE) { /* debug checks */ if ((meta->pkt_len > (1024 * 16)) || (meta->pkt_len == 0)) { From patchwork Wed Nov 29 17:26:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134714 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33EE743403; Wed, 29 Nov 2023 18:33:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBF5942E99; Wed, 29 Nov 2023 18:31:53 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 06A8542E89 for ; Wed, 29 Nov 2023 18:31:49 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6cddb35ef8bso533138b3a.2 for ; Wed, 29 Nov 2023 09:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279108; x=1701883908; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lVTOVkIXOaV/wVpW9KepCdaKp0UqOrxVq/AdfhOkl8=; b=yU+wQ1V0I918B5u10AJlGK0VTYhQpt84IRib1lBiVSAMDoLJpN5p0FfB1gnuCmcR+j zx8yudLMFcMLYjB0mLMKvCQtaRuk18bzgU2oX3iSn+BSuM6o/QX8tr29NVA8piXmEYft P8UZH9yQdWN4JsviNwgKIheetb/U1OMm1mn/+eu4K2cdMsI19ELONdLXdGeVXY50Ybe4 F0R4/wRynSBsIPY6Kc40gie/6uMcNSr9nnIcuQQ/KSIy5no7w6PoAYIE3w3F2a16tG9R yndrdv4lk8EUOqchFgmsaHwY10oMyS/oz6BBgfgPrVfqXeoGi62+SXb4AFJzLpHOi5pU yTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279108; x=1701883908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lVTOVkIXOaV/wVpW9KepCdaKp0UqOrxVq/AdfhOkl8=; b=P3a+O7VYaSJe16mAYS/TxYPO44swPJsT2BcMr88RndODSLeOnekpWddaBXPnqrvAOu C4nUrpIPYqUPH+srSe7lkcaj7okx2+cr6DUFvNFtNYcumwg6ofo9x8TLMNjdY9uZoBmS 0Qp9meEjRU12TTKU7CPI/tsbC8wPYIYdrT+NpvaVkMe5VdcQ63tUx1d5X2dVlIAyPvcc IUy3LZDpqzqV609b6CXXqRKLaBskG0mkjc/7vKE6JEMYnY/Weix9AVQSfUVHrBx2+E90 Z6fLUE6Rf6wC0qHVTg3KWHNT8W3bUXhrBjnySGf1HQjODcS13L2ZubyZ44iSFpWMy0Du gWEg== X-Gm-Message-State: AOJu0YzJ1GNpHTt1cr4qg6q6zfaUqFkESCqTgDon0tcvJjoF/S7KWOoT uk+K/17mVtUeYS5ybJE36odKMkRjH1NCXuGAy9VVTQ== X-Google-Smtp-Source: AGHT+IFYmxBRCf6QoioLMNuH8pakOtESYxbmzgbMPTpdV/XawgFyIVPNx1TVGqBCv7ORAEZRXrx9sg== X-Received: by 2002:a05:6a21:3514:b0:188:1df7:9afe with SMTP id zc20-20020a056a21351400b001881df79afemr21782540pzb.30.1701279107876; Wed, 29 Nov 2023 09:31:47 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH v5 12/19] net/bnxt: replace use of term sanity Date: Wed, 29 Nov 2023 09:26:06 -0800 Message-ID: <20231129173122.126895-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- drivers/net/bnxt/hsi_struct_def_dpdk.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 06f196760fa8..e1254375b650 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -262,7 +262,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, done = bnxt_check_cq_hwrm_done(cpr, is_tx, is_rx, i == timeout - 1); - /* Sanity check on the resp->resp_len */ + /* Input check on the resp->resp_len */ rte_io_rmb(); if (resp->resp_len && resp->resp_len <= bp->max_resp_len) { /* Last byte of resp contains the valid key */ diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bnxt/hsi_struct_def_dpdk.h index 9afdd056ce7a..a8076a6fc223 100644 --- a/drivers/net/bnxt/hsi_struct_def_dpdk.h +++ b/drivers/net/bnxt/hsi_struct_def_dpdk.h @@ -55482,7 +55482,7 @@ struct hwrm_tfc_ident_alloc_output { * Requests the firmware to free a TFC resource identifier. * A resource subtype and session id are passed in. * An identifier (previously allocated) corresponding to all these is - * freed, only after various sanity checks are completed. + * freed, only after various checks are completed. */ /* hwrm_tfc_ident_free_input (size:192b/24B) */ struct hwrm_tfc_ident_free_input { From patchwork Wed Nov 29 17:26:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134715 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96E9943403; Wed, 29 Nov 2023 18:33:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FB7242E75; Wed, 29 Nov 2023 18:31:55 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 153CC42E8A for ; Wed, 29 Nov 2023 18:31:50 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6cbd24d9557so5121b3a.1 for ; Wed, 29 Nov 2023 09:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279109; x=1701883909; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2BRWx5O95zlaiPh7i2kS5M8xLSk8a7cvqGAMKkSSxW4=; b=zPfZ+5vxnCgjyf1AwatdNZQLsxaDuwjBwI/9+cLKfQ5Z5q5F3ItmilC6dvETIdY1uf 5tSfhA7qPHw92DCM63dDyJHm56rC6u+QW2VTeuu+ZhCWozkMNQ4kJ6/A6cWXMlvXn3QA 3dEtrhL2PJulOTte+fkNlSWO+BUhzLbrKH1D1eV7wDP7rSwb0OLU9wlGqfUJiFs+Uo9O 1ycqyZz+SbsfbRvqsaDX8Hk+sSofJ0z2iLu0uiTJE+5VT1Mym+Wk/l+rKEsmfsqCmBkJ dkLo2pS94nlGWaAtAW2qB4sTYqZCKHWcxh7ylNYh++XNPrfTywRMCeFNUTsx8I1DJtvu Tw8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279109; x=1701883909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2BRWx5O95zlaiPh7i2kS5M8xLSk8a7cvqGAMKkSSxW4=; b=DQV1/B9HTDOC8sexPKzZNJTkS0NQMvYuJ5q5AKd1A44OWd3bueqdRCMqeGq3bU/G8G PP9Z/bDaZKXrjOZHrT7G9Je2QLTI6KicyGH7sqd4XL7BnMOjZ7+6CwDgbhyuc8LnmC8P KWHEKY0eJmzfNNADfZgk3IKyN4ZSios5P52j+tPStmn/bWjKCY73V2+m42cG0EvyP7Gg tqoYRBhuM5S02EUhA9Ao1GUHBe26FYRcofutPKXxIjxbEhU315/Pb4BVVR66DCxGnVY5 XgEiDAVNAl5KQOAlWPJoeQr1K8n12m23R4Ly6u0vXwShTRJd41yQroGPmYRV4lV/dpFw 8t9w== X-Gm-Message-State: AOJu0YxpovFKjXRWGZhAv5VkTdPII2CDDv8AKNATRRP1Srjd9FHdzWmX BifUpdkVmT+HnBfQ7dQON3TSf8ARLYn+bVDAdlVUlw== X-Google-Smtp-Source: AGHT+IG4hEvoDMqpN8WUP/DDK8/0OuyN6LrK5H0QE3n9cWrfodvvWH+bD2FnHum308nhZpuUHWpF/A== X-Received: by 2002:a05:6a00:658a:b0:6cb:ba8d:96a7 with SMTP id hd10-20020a056a00658a00b006cbba8d96a7mr27442842pfb.14.1701279109005; Wed, 29 Nov 2023 09:31:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube Subject: [PATCH v5 13/19] net/bnx2x: remove reference to sanity Date: Wed, 29 Nov 2023 09:26:07 -0800 Message-ID: <20231129173122.126895-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 ++++---- drivers/net/bnx2x/ecore_sp.c | 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index c3283c94f38f..e345f293f25c 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -7820,7 +7820,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc) uint32_t ovlan2; uint8_t i, j; - /* various MF mode sanity checks... */ + /* various MF mode checks... */ if (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) { PMD_DRV_LOG(NOTICE, sc, diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index c07b01510a06..86d90679ac0a 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc) */ return; } - /* sanity */ + /* input valid? */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc) uint32_t mac_addr; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->link_vars.link_up || !sc->port.pmf) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc) struct dmae_command *dmae = &sc->stats_dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->func_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc) struct dmae_command *dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c index c6c3857778f7..158205266f62 100644 --- a/drivers/net/bnx2x/ecore_sp.c +++ b/drivers/net/bnx2x/ecore_sp.c @@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc, break; } - /* Sanity check */ + /* Argument check */ if (!cur_len) return ECORE_SUCCESS; diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 2c81f85b9605..6ebd47d927f8 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drivers/net/bnx2x/elink.c @@ -1088,7 +1088,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin, { uint32_t epio_mask, gp_oenable; *en = 0; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to get", epio_pin); return; @@ -1105,7 +1105,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e { uint32_t epio_mask, gp_output, gp_oenable; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to set", epio_pin); return; From patchwork Wed Nov 29 17:26:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134716 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6221A43403; Wed, 29 Nov 2023 18:33:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C309D42EA7; Wed, 29 Nov 2023 18:31:56 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 0761D42E65 for ; Wed, 29 Nov 2023 18:31:51 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6c320a821c4so6119695b3a.2 for ; Wed, 29 Nov 2023 09:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279110; x=1701883910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0yfk9EAU7Jewthnsdnd1bGnHGmAnJUoyhDSPGUAzKZA=; b=HrHPp88O6fqrzSwfHxM0iIEYc5kyqfOjeIaHoLXKIrYao4Zo5OctojrSwJDi20qB+U cc3CvhSK0ziYPQn6sG6TBRFqYUlMNCa1xRyrDKUClwucTLjsR111SxzusIzSu2Xdpm0a WBbHzmdb9MhAocJcAi3b6AalYFFxWqT6/JkYiH9ka3h2QKYvr1fzAqRXZSDmYZc0nKb/ 07wR2StNpZ8p3+baI0US6MTuCpFAf84VnuCHfeBI3BvPEfJWozIApnixHsqOotfOhmGM PCg73Zodgny27Sdl+rL6QL2Ng0lBGviwf+tSiUKQZ26n4gWIvW/i/tgx6fELZ495m9Tp WYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279110; x=1701883910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0yfk9EAU7Jewthnsdnd1bGnHGmAnJUoyhDSPGUAzKZA=; b=vuY8jzPs4Kbzws5L64/I6GpNziFHogjeGlrdFhkbfkVm4taPLBxkY6wEz9ZsTWPnwb HMaixuLtzxYPainDxHyeTrlDGHPQqMzOAcqM3cfQUTue/+LFeewfKrxjsTzU09afhPGe oHUPtj12J2VybW+P+i7YjNRqkew24m2iCPBQWWsnL6vOBSpB/Ycetnb1qeTPfr/cQlbq 6zzU8kv2USjpfpWf8GPBSxJV0MMQg2wv/53yhDFhbPWOVTGuseidHzuzV829DAix6Jdj ejqnK1n/qVc6hUZs5JUC2CpzhrLMVIpIJE2Jz9rUcSbNmc38D78JGm2ErToPMGvFQzky SwNA== X-Gm-Message-State: AOJu0YzlEy/KoalL8bH3LMySYgjJzYuRC/FkGmndtRqoNmZuaoUucVCm SgkcssY53BV354ceFhyDjBoYxlwTmRvdtSZ9Y6LPJg== X-Google-Smtp-Source: AGHT+IH3/MU/DnD+QOoMJMzC2hLqFDyVWsTZhyFjZnqr7OFfljtEaQ9lpU5IEjSU2/hRxn590m7O6g== X-Received: by 2002:a05:6a00:93a4:b0:6cb:d28f:7a91 with SMTP id ka36-20020a056a0093a400b006cbd28f7a91mr21448567pfb.9.1701279109910; Wed, 29 Nov 2023 09:31:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v5 14/19] cnxk: replace term sanity Date: Wed, 29 Nov 2023 09:26:08 -0800 Message-ID: <20231129173122.126895-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c | 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index e1cef7a670b6..6060dba0d799 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -527,7 +527,7 @@ roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix) node->flags &= ~NIX_TM_NODE_ENABLED; } - /* Verify sanity of all tx queues */ + /* Verify all tx queues */ for (i = 0; i < sq_cnt; i++) { sq = nix->sqs[i]; if (!sq) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 6c14c499019a..5e38ecf0414e 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -458,7 +458,7 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size, char name[PLT_MEMZONE_NAMESIZE]; const struct plt_memzone *mz; - /* Sanity check */ + /* argument checks */ if (!lf || !block_size || !block_count || !pool || !aura || !aura_handle) return NPA_ERR_PARAM; @@ -1096,7 +1096,7 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) uint8_t aura_sz; int rc; - /* Sanity checks */ + /* Input checks */ if (!lf || !base || !mbox) return NPA_ERR_PARAM; diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 5e11bbb017ea..798567592efe 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -636,7 +636,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid, struct rte_mempool *lpb_pool = mp; struct rte_mempool *spb_pool = NULL; - /* Sanity checks */ + /* input checks */ if (rx_conf->rx_deferred_start == 1) { plt_err("Deferred Rx start is not supported"); goto fail; @@ -1205,7 +1205,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) rc = -EINVAL; - /* Sanity checks */ + /* baseline checks */ if (rte_eal_has_hugepages() == 0) { plt_err("Huge page is not configured"); goto fail_configure; From patchwork Wed Nov 29 17:26:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134717 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C07D643403; Wed, 29 Nov 2023 18:33:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1318E42EAA; Wed, 29 Nov 2023 18:31:58 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id DFC8B42E91 for ; Wed, 29 Nov 2023 18:31:51 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6cc02e77a9cso4366900b3a.0 for ; Wed, 29 Nov 2023 09:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279111; x=1701883911; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dAR563prZendT153HlOqUb8ceiYgUxGxxDPFKdyhcdg=; b=QEXmj3ucp/bN1oqnkiFHI8O41r193ex8UuhDq6REkD5YGRlQFh6VvTdfrLOYBHgs5O xzTnQelO+WdUlJhyFUqzCfiJpPGXn5rcu1blIJrwPI7RCcLxIg9RvqWOmNVk6ECmKJ5Y xwWMk6rKUu2SR2Z323tkgQ4EIqd9Uq/wudGi5h3M8ysE+qxvLcNbeN2dh3IDKkuVpyM3 rydm4t7PMjBUtaTmCFxLHiojlnzavQQFMASyo4Cmub4Y7pHsX6s5reSygsWLkQsOUyqC sMnmMTBkrQj9B++WAPH428pAnb2/YxaCIJRq7CU2SujgX2W46HNzY+khavGfLdWvTNM4 83lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279111; x=1701883911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dAR563prZendT153HlOqUb8ceiYgUxGxxDPFKdyhcdg=; b=ui1WQf7PRg3r4ITrzfy8rZGmPAUH0/0wFr5gJqZ5vhER+OCQZouhnYN9/f9B4Bb7RI +b5/sEVP9ZC6uSRoi9QJvhKh6KXQv2SRdzQCYFIcI3linWWCDiIw4djG2djgX6KYjmgx +BczE5PopGSbiLyXPoqSDUMuI90843bU18CICcjSZ7j8CsfTAbBEOjdd6Qpg5fo4R+5S Pmsvj10E5jC40E925uRn1y8+coIhvQwPF0AN3sCj0RLKR0XfkGiOioJ2IQ4kPEY4x5an QEfWWR9euUdjMOW08zGLR1bAcmDQgV7y8cnDgaV5eSzpJ2z/MwabUFftv1vGxUV5EPh9 k/rg== X-Gm-Message-State: AOJu0Ywt1YW4Dcpy2yx3aXYkwt9PARrm4sOzK7GdJ5NG4omGmfxnMd5t oXYNx1tzBAzmI4n6vs2gz8CdcJ0LslEpHNe3hlboYw== X-Google-Smtp-Source: AGHT+IHTJxy1KXE1gnYhie4hrxRCwVOwmlyFJ8lbasQHcw9OvZvDzPIu5KDDBWIvhRzqirgnXiNL7g== X-Received: by 2002:a05:6a20:da91:b0:18a:e86f:f246 with SMTP id iy17-20020a056a20da9100b0018ae86ff246mr21727911pzb.10.1701279110976; Wed, 29 Nov 2023 09:31:50 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liang Ma , Peter Mccarthy Subject: [PATCH v5 15/19] event/opdl: remove term sanity Date: Wed, 29 Nov 2023 09:26:09 -0800 Message-ID: <20231129173122.126895-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Don't use non-inclusive term. Signed-off-by: Stephen Hemminger --- drivers/event/opdl/opdl_evdev.c | 2 +- drivers/event/opdl/opdl_evdev_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 0cccaf7e9731..39cd87b8f944 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.c @@ -241,7 +241,7 @@ opdl_queue_setup(struct rte_eventdev *dev, struct opdl_evdev *device = opdl_pmd_priv(dev); - /* Extra sanity check, probably not needed */ + /* Extra check, probably not needed */ if (queue_id == OPDL_INVALID_QID) { PMD_DRV_LOG(ERR, "DEV_ID:[%02d] : " "Invalid queue id %u requested\n", diff --git a/drivers/event/opdl/opdl_evdev_init.c b/drivers/event/opdl/opdl_evdev_init.c index be3437fc2f40..12eb2695f5de 100644 --- a/drivers/event/opdl/opdl_evdev_init.c +++ b/drivers/event/opdl/opdl_evdev_init.c @@ -300,7 +300,7 @@ static int opdl_add_deps(struct opdl_evdev *device, struct opdl_queue *queue_deps = &device->queue[deps_q_id]; struct opdl_stage *dep_stages[OPDL_PORTS_MAX]; - /* sanity check that all stages are for same opdl ring */ + /* check that all stages are for same opdl ring */ for (i = 0; i < queue->nb_ports; i++) { struct opdl_ring *r = opdl_stage_get_opdl_ring(stage_for_port(queue, i)); From patchwork Wed Nov 29 17:26:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134718 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8500443403; Wed, 29 Nov 2023 18:33:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62E3342EAE; Wed, 29 Nov 2023 18:31:59 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id C980042E97 for ; Wed, 29 Nov 2023 18:31:52 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6cc2027f7a2so4014442b3a.2 for ; Wed, 29 Nov 2023 09:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279112; x=1701883912; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qb7+8Iya9ZI8RjLLuGm0BRoU49bj6ugCn9hlkjRse4g=; b=VL1Hx+Uk3a2mjyzTbsThTy0ch3JqouT+mZslmop+Lxs5FunHvBmwc+fhpkHMnk+QRB /eRFQgndLgVed55LkS7uXGM0bB0TQ4ZE9aTujMCOnzs34R/zDV7IGNVSveMTi++qXBoK 0v2ZrHl2boXyfZExGKnwDkoD1SDqB1Zo+yacyNDhwZESh6AoXRTYjms5t67x0ZR2tqUi ISsCeec6bpXABrBQjZV5h4wqHCTNIONfI2/e+Gy1vROa0N5xyjvoS8mhjBCZ0IWBjg6E anbmIhebbvaTv8UfOQLWEMJ3kng5Ro9qC3UhsB+QAsLMiY1fAGjO5u5qxgZgH58NR0W7 Wtng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279112; x=1701883912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qb7+8Iya9ZI8RjLLuGm0BRoU49bj6ugCn9hlkjRse4g=; b=cf34hb7ANFJxbSqPYipYl67YtfZQETvKNshRYbp95MKvCyiQKwhiUhz4DpJN39bB75 c+V8zDfsP1PMFrbpiJY7etxqSBVdjwGuWINxu5cKxCUi5Jp62SXOqXNGnknUgYVwsei3 6nVQUVpCApS39sAowL66ACJLtNxUQOiJfwEugV8C928hVZkw23nMjNuElpN1f1n4aqlr S+CrJpfdofCLdNgFljW1IY/VG8xonBKxmCzGcq4SEGWGN996awwXhBxcSlyzhecQVYie F98rt28zFttDhfgmvG7VNL+rlUmXPxE6m2PfaJIQViDvmXQLjl8ki3aELJXEq0o2xB1R 3Vyg== X-Gm-Message-State: AOJu0YwpcCjdBp3PP2NltNDN3bTlUV8pdekjipV/sR4FeSx/PTVOPvSo WLIOL/4P6rzE9m6rFH18q+aHbf9fYi28ckWp44mx9g== X-Google-Smtp-Source: AGHT+IEEVeFO4BOAtNt/7l0IrOefxRjhn4pS03R9b//2YEwoqaYBwwqpDm0Cd0Hipdv5Crv26elPqw== X-Received: by 2002:a05:6a00:244c:b0:6b7:18c1:c09a with SMTP id d12-20020a056a00244c00b006b718c1c09amr18944679pfj.5.1701279111806; Wed, 29 Nov 2023 09:31:51 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:51 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH v5 16/19] net/txgbe: replace term sanity Date: Wed, 29 Nov 2023 09:26:10 -0800 Message-ID: <20231129173122.126895-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Don't use term sanity. Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ipsec.c | 2 +- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..cadb0943c82d 100644 --- a/drivers/net/txgbe/txgbe_ipsec.c +++ b/drivers/net/txgbe/txgbe_ipsec.c @@ -595,7 +595,7 @@ txgbe_crypto_enable_ipsec(struct rte_eth_dev *dev) rx_offloads = dev->data->dev_conf.rxmode.offloads; tx_offloads = dev->data->dev_conf.txmode.offloads; - /* sanity checks */ + /* offload checks */ if (rx_offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) { PMD_DRV_LOG(ERR, "RSC and IPsec not supported"); return -1; diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index 1cd4b25965b5..5d45d8763dc9 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -4115,7 +4115,7 @@ txgbe_set_rsc(struct rte_eth_dev *dev) uint32_t rdrxctl; uint32_t rfctl; - /* Sanity check */ + /* Offload check */ dev->dev_ops->dev_infos_get(dev, &dev_info); if (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_TCP_LRO) rsc_capable = true; From patchwork Wed Nov 29 17:26:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134719 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E9AE43403; Wed, 29 Nov 2023 18:33:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A460542EB4; Wed, 29 Nov 2023 18:32:00 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id AD8D742E97 for ; Wed, 29 Nov 2023 18:31:53 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6cd89f2af9dso3833582b3a.1 for ; Wed, 29 Nov 2023 09:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279112; x=1701883912; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7YCB8gC+yvziIgpan71CixglVLlLEKZdS46a004TGyc=; b=kNomn3Ap4OjdAhDdZ+NTNej0OHWzzar6TmFYVgN5il4SgdhtRkM/EPFG7Dnc9ChxJ7 k7v/RpPQhjp/uO2JlOBau/L12XENwKbAcVFdpLa0c/x0GwGNgkjmshIGN1SWI4Kmheen EvHzGyeUA97RqxUKrQXTok+yHpeFDXbEe7sBxseEcFT6VL/s/NJz9rguLqnjO2/CFaQy FodAgpssQHfrc6BfzzVal6NuMpdAmW6are9txnwPCdsuAuGdBL7/CJuUF9r3AmsmKCCd W2J6/YHho5TPuxkR0QnaSrhvfTT+jEKPXcZHF4IjEWGWoHmXzbjbHzHYiAO9VIznLTTt eFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279112; x=1701883912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7YCB8gC+yvziIgpan71CixglVLlLEKZdS46a004TGyc=; b=mh58+StFKmP7YYUFv8Cft8llOrq24i9ck9PjnbsuaZdPr0GocrNADg+tyG6HkEFvXc ancOrfsNReoghiOa3Yk4sdxsJKP8XOMa0jdfUrpFwXlMBD24E/zlIId5GyxlQ5+neNGd P/Y9cPlqdQax42sEWpVVSzX0KQfud3N0ahvSVAF0H4/uv9n7OInWgOsPwksE5/Q3805I ooahL0oc+YJuPXVYgiTKg/1ZaGO/UjdM/SACtNboXt9EiALh4ujpUUQXQkQKRANN1hui 5jQXTLFk14LmPnXGh9qfiZFrquiP0svjyiKCOesCgcED1G8HWNF4khQ/AodaBOwFuQM8 cqwg== X-Gm-Message-State: AOJu0Yza3XQwKLTMQFHWsGAJRBdByq4in/PwcaU6Q5csGJ3hwg6zYGYq JCZOfUE08TwhYpEH71QjNS2Dcjy+0Ky60B+WS945cg== X-Google-Smtp-Source: AGHT+IHlz/wxE3SXtm2MroltjrT7vhRBzwJClLQTJi29ypcBf7Hn9YVGGAH1JYqTrzr6E861zAmqjA== X-Received: by 2002:a05:6a20:8f0f:b0:188:2b6:316b with SMTP id b15-20020a056a208f0f00b0018802b6316bmr27079864pzk.38.1701279112688; Wed, 29 Nov 2023 09:31:52 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rahul Lakkireddy Subject: [PATCH v5 17/19] net/cxgbe: remove use of term sanity Date: Wed, 29 Nov 2023 09:26:11 -0800 Message-ID: <20231129173122.126895-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove non-inclusive terminolgy. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++-------- drivers/net/cxgbe/cxgbevf_main.c | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index 8cc3d9f257a0..c7c745fee495 100644 --- a/drivers/net/cxgbe/cxgbe_ethdev.c +++ b/drivers/net/cxgbe/cxgbe_ethdev.c @@ -524,10 +524,7 @@ int cxgbe_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, eth_dev->data->tx_queues[queue_idx] = (void *)txq; - /* Sanity Checking - * - * nb_desc should be > 1023 and <= CXGBE_MAX_RING_DESC_SIZE - */ + /* nb_desc should be > 1023 and <= CXGBE_MAX_RING_DESC_SIZE */ temp_nb_desc = nb_desc; if (nb_desc < CXGBE_MIN_RING_DESC_SIZE) { dev_warn(adapter, "%s: number of descriptors must be >= %d. Using default [%d]\n", @@ -648,10 +645,7 @@ int cxgbe_dev_rx_queue_setup(struct rte_eth_dev *eth_dev, eth_dev->data->rx_queues[queue_idx] = (void *)rxq; - /* Sanity Checking - * - * nb_desc should be > 0 and <= CXGBE_MAX_RING_DESC_SIZE - */ + /* nb_desc should be > 0 and <= CXGBE_MAX_RING_DESC_SIZE */ temp_nb_desc = nb_desc; if (nb_desc < CXGBE_MIN_RING_DESC_SIZE) { dev_warn(adapter, "%s: number of descriptors must be >= %d. Using default [%d]\n", diff --git a/drivers/net/cxgbe/cxgbevf_main.c b/drivers/net/cxgbe/cxgbevf_main.c index d0c93f8ac3a5..dfb12b4ed5c9 100644 --- a/drivers/net/cxgbe/cxgbevf_main.c +++ b/drivers/net/cxgbe/cxgbevf_main.c @@ -137,7 +137,7 @@ static int adap_init0vf(struct adapter *adapter) /* * Grab our Virtual Interface resource allocation, extract the - * features that we're interested in and do a bit of sanity testing on + * features that we're interested in and do a bit of testing on * what we discover. */ err = t4vf_get_vfres(adapter); @@ -148,7 +148,7 @@ static int adap_init0vf(struct adapter *adapter) } /* - * Check for various parameter sanity issues. + * Check for various parameter issues. */ if (adapter->params.vfres.pmask == 0) { dev_err(adapter->pdev_dev, "no port access configured\n" From patchwork Wed Nov 29 17:26:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134720 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7337C43403; Wed, 29 Nov 2023 18:33:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5176E42EBE; Wed, 29 Nov 2023 18:32:02 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 4015E42EA1 for ; Wed, 29 Nov 2023 18:31:55 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6cdd9c53282so570457b3a.3 for ; Wed, 29 Nov 2023 09:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279114; x=1701883914; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1GzHnmFG3wRrq+VIHCEAA1OkREheRL5Hz3Zzi1g3aUc=; b=fpRrLI2FeEw/47ZunzwXFJyXLhzQy4W8iY3tEEC7fKsr0JbDlJYHhurtK4qunfvX+4 THUKazTfXwSqoI0S9m/AipOoA/i0pIhUNjm5sYwQYLcKc+9tCM/DcxMTFe8tdwHRZYR2 WFZuu7doIDOM2B/EjWwIsj4eZmYtz9stibG+6KHzEx/nq5v1mlbEzJgHcDCyDEFhXEkX fK+W/OkuTkHbhZ2bHbU9QAQHoiG3SsztcTIEUF8wTMaZTVE9/EDAQXE4O1nxGiHQy5X2 wbTsY53ni0BUD1eRRLQyBRZV+v8Aur7wLYvYmxRxcqZqJZwek35ruXrNa4SGdoE53R60 rj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279114; x=1701883914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1GzHnmFG3wRrq+VIHCEAA1OkREheRL5Hz3Zzi1g3aUc=; b=gHjhgBTb0FK2v0y3hc/p9RzbN8H1ucDLpFVQ3BqjuDCz0PUeX3bzMTUOvovaYY9V0N dQ2a7l5VtdhyiLl9/GJM6A0TzMvbXxUGUgQPTobABHDl9DEBtpUkzzgN3cdGJ/I+VwHA XPFwJ9qI9rtH0jcL9E2oWf8lD4ECBqg4zYzwfRf79Kr8t8Ofan7GIzCWZsDVfI57wmvN ia2Lk03wlli9cmcooq61SsLF1hj7QmF01+6MN5ZL248Ub54MJ7UedQwLRmL2AlE32qxk AEs+h7NPIjTPrHBVu9WbF4gCFtsS9n+uwX5PaeohyTJk3oODNwc+MrlmbV77Kb4VDg7g iF/A== X-Gm-Message-State: AOJu0YyjFHaoXvVkOYPxtTytO/bAKGsaMbtiFpuU/AILlk/s/AtgaJpk rkT/QW3cupboACbhM3rLcQPGQSyBmq8jbFmYyhgjnQ== X-Google-Smtp-Source: AGHT+IE+1znz4pdb8nFA81LwZi8o9fqY+PHEMu8IzS6hEkd0H3n1sxMi5arVOrDwsBwND/9dt4YifQ== X-Received: by 2002:a05:6a20:158b:b0:18b:985e:8035 with SMTP id h11-20020a056a20158b00b0018b985e8035mr21102153pzj.12.1701279114158; Wed, 29 Nov 2023 09:31:54 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta Subject: [PATCH v5 18/19] crypto/bcmfs: replace term sanity check Date: Wed, 29 Nov 2023 09:26:12 -0800 Message-ID: <20231129173122.126895-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming here. Signed-off-by: Stephen Hemminger --- drivers/crypto/bcmfs/hw/bcmfs4_rm.c | 6 +++--- drivers/crypto/bcmfs/hw/bcmfs5_rm.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c b/drivers/crypto/bcmfs/hw/bcmfs4_rm.c index 9a30c654dab8..051bbea9cc81 100644 --- a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c +++ b/drivers/crypto/bcmfs/hw/bcmfs4_rm.c @@ -317,7 +317,7 @@ bcmfs4_mdst_desc(uint64_t addr, unsigned int length_div_16) } static bool -bcmfs4_sanity_check(struct bcmfs_qp_message *msg) +bcmfs4_message_check(struct bcmfs_qp_message *msg) { unsigned int i = 0; @@ -458,8 +458,8 @@ bcmfs4_enqueue_single_request_qp(struct bcmfs_qp *qp, void *op) struct bcmfs_queue *txq = &qp->tx_q; struct bcmfs_qp_message *msg = (struct bcmfs_qp_message *)op; - /* Do sanity check on message */ - if (!bcmfs4_sanity_check(msg)) { + /* Do check on message */ + if (!bcmfs4_message_check(msg)) { BCMFS_DP_LOG(ERR, "Invalid msg on queue %d", qp->qpair_id); return -EIO; } diff --git a/drivers/crypto/bcmfs/hw/bcmfs5_rm.c b/drivers/crypto/bcmfs/hw/bcmfs5_rm.c index cbfe42cb4713..2df10a302841 100644 --- a/drivers/crypto/bcmfs/hw/bcmfs5_rm.c +++ b/drivers/crypto/bcmfs/hw/bcmfs5_rm.c @@ -293,7 +293,7 @@ bcmfs5_mdst_desc(uint64_t addr, unsigned int len_div_16) } static bool -bcmfs5_sanity_check(struct bcmfs_qp_message *msg) +bcmfs5_message_check(struct bcmfs_qp_message *msg) { unsigned int i = 0; @@ -389,8 +389,8 @@ bcmfs5_enqueue_single_request_qp(struct bcmfs_qp *qp, void *op) struct bcmfs_queue *txq = &qp->tx_q; struct bcmfs_qp_message *msg = (struct bcmfs_qp_message *)op; - /* Do sanity check on message */ - if (!bcmfs5_sanity_check(msg)) { + /* Do check on message */ + if (!bcmfs5_message_check(msg)) { BCMFS_DP_LOG(ERR, "Invalid msg on queue %d", qp->qpair_id); return -EIO; } From patchwork Wed Nov 29 17:26:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134721 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FDF443403; Wed, 29 Nov 2023 18:33:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89C5042EC4; Wed, 29 Nov 2023 18:32:03 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 6462642E9B for ; Wed, 29 Nov 2023 18:31:56 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6cdd13c586fso864674b3a.0 for ; Wed, 29 Nov 2023 09:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279115; x=1701883915; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OCTbkeoht8w5+Q3z4/gvPqUvK01HM3Jpu/F+E5mYsmc=; b=qQSOki4KlwmVMO7gsEb/gH3MNjYCZ1/H72uF38v/JyzadcFllkwieCcgbhxK4X1ubh T0K2VHwF/UahyFbZjZEj6klA/xdwTSWnZJ1u0vmm5D3EEmw8YRcPFL1C7CdnpqCVvNoB uMCxSZnvVCPhem5iDhOXKHznkT9/kcUwoK2lBplHRVgkHEmjMjXnwOhcZl9pMUDnBpcb 5MoGRu0BQRs3He/om5PTc+3N7Ybk+uVBiS6Bk2hUhiUM9Rsahghb4RakMFYgxQHL7dCx gAqSWpAwZ1kSfBoT6mSjA0llPbAqHE3i3l+f5UPA7VvnJNUiuFyLUnqyvOvJb9LgvVrY jNaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279115; x=1701883915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OCTbkeoht8w5+Q3z4/gvPqUvK01HM3Jpu/F+E5mYsmc=; b=Zd1AiGe0IIN35zfNQtNvw8ek98JgV5A/B784LI/tj9tZA9RYkPOFsBfBmwC9EhQ7GC pnEk/ZhTf1QkxYe6UXZ2YBalxzL5gfrFB1S+6l5URRX4JpC3RBk5kpFlXUpIVa4pBc+z hgN3ZtRtEIQHijFFhVaSv+zWB42IVJtYx48KoArVe52TIt3ySxEIlSO/Ogv4za/WdkyE MyTnXQjdyZ0I+CKQCdjCzfLYUw6/KnhmVWxc03eF9iGxTTotx4N/pBffyWL0ipuXTsk1 wroV5cJmsy14+dp9ue0tDfIyjTflx2ugPAtYi+CNYNQHBDnzlc4n4YZVYsryR7frAbp6 wsyA== X-Gm-Message-State: AOJu0YwWaAvbN6YUGaX626Xh1GoB7YeRd3xD6LchuJF4/wMBYh/xacjA IfQ4za+l62XIFUO1ZntPc80TrfBIrec9RFN/2XgbVg== X-Google-Smtp-Source: AGHT+IHbB5ZqM/D2balPsuoEElFI26MQ2xg+ONZlRKfZuNWi45kYLJPA7d5hDRLIyq5R0aczyhGcDw== X-Received: by 2002:a05:6a20:12d3:b0:187:ce9f:e198 with SMTP id v19-20020a056a2012d300b00187ce9fe198mr20186976pzg.5.1701279115361; Wed, 29 Nov 2023 09:31:55 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Andrew Rybchenko , Bruce Richardson , Kevin Laatz , Chas Williams , "Min Hu (Connor)" , Liron Himi , Chaoyong He , Devendra Singh Rawat , Alok Prasad Subject: [PATCH v5 19/19] drivers: remove use of term sanity check Date: Wed, 29 Nov 2023 09:26:13 -0800 Message-ID: <20231129173122.126895-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace non-inclusive language with better comments. Covers multiple drivers Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal Acked-by: Chaoyong He Acked-by: Devendra Singh Rawat Acked-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/cnxk/roc_npa.c | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/common/sfc_efx/base/ef10_nvram.c | 4 ++-- drivers/common/sfc_efx/base/efx_rx.c | 2 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- drivers/net/mvpp2/mrvl_qos.c | 2 +- drivers/net/nfp/nfp_flow.c | 2 +- drivers/net/qede/qede_rxtx.c | 6 +++--- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h index caaae417773c..2b6162d0ceaf 100644 --- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h +++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h @@ -9,7 +9,7 @@ #include #include -/* Sanity check */ +/* Byte order check */ #if (__BYTE_ORDER__ != __ORDER_BIG_ENDIAN__) && \ (__BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__) #error "Unknown endianness!" diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 5e38ecf0414e..bd8ab1b39584 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -622,7 +622,7 @@ npa_aura_alloc(struct npa_lf *lf, const uint32_t block_count, int pool_id, { int rc, aura_id; - /* Sanity check */ + /* parameter check */ if (!lf || !aura || !aura_handle) return NPA_ERR_PARAM; diff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/caamflib/desc.h index 4a1285c4d488..37c87eebd5b4 100644 --- a/drivers/common/dpaax/caamflib/desc.h +++ b/drivers/common/dpaax/caamflib/desc.h @@ -107,7 +107,7 @@ extern enum rta_sec_era rta_sec_era; /* * ONE - should always be set. Combination of ONE (always - * set) and ZRO (always clear) forms an endianness sanity check + * set) and ZRO (always clear) forms an endianness check */ #define HDR_ONE BIT(23) #define HDR_ZRO BIT(15) diff --git a/drivers/common/sfc_efx/base/ef10_nvram.c b/drivers/common/sfc_efx/base/ef10_nvram.c index ce8357fa94ce..fad9f0f507f3 100644 --- a/drivers/common/sfc_efx/base/ef10_nvram.c +++ b/drivers/common/sfc_efx/base/ef10_nvram.c @@ -595,13 +595,13 @@ tlv_update_partition_len_and_cks( /* * We just modified the partition, so the total length may not be - * valid. Don't use tlv_find(), which performs some sanity checks + * valid. Don't use tlv_find(), which performs some checks * that may fail here. */ partition.data = cursor->block; memcpy(&partition.tlv_cursor, cursor, sizeof (*cursor)); header = (struct tlv_partition_header *)partition.data; - /* Sanity check. */ + /* Header check */ if (__LE_TO_CPU_32(header->tag) != TLV_TAG_PARTITION_HEADER) { rc = EFAULT; goto fail1; diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c index dce9ada55d28..28676c5a5b99 100644 --- a/drivers/common/sfc_efx/base/efx_rx.c +++ b/drivers/common/sfc_efx/base/efx_rx.c @@ -930,7 +930,7 @@ efx_rx_qcreate_internal( ndescs, id, flags, eep, erp)) != 0) goto fail4; - /* Sanity check queue creation result */ + /* Check queue creation result */ if (flags & EFX_RXQ_FLAG_RSS_HASH) { const efx_rx_prefix_layout_t *erplp = &erp->er_prefix_layout; const efx_rx_prefix_field_info_t *rss_hash_field; diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index a78889a7efa0..ba36a96f085d 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -204,7 +204,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, goto err; } - /* sanity check device status */ + /* check device status */ if (pci->regs->gensts & GENSTS_DEV_STATE_MASK) { /* need function-level-reset (FLR) or is enabled */ IDXD_PMD_ERR("Device status is not disabled, cannot init"); diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 79f1b3f1a0f2..57a67bd029ed 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1476,7 +1476,7 @@ bond_8023ad_setup_validate(uint16_t port_id, return -EINVAL; if (conf != NULL) { - /* Basic sanity check */ + /* Basic input check */ if (conf->slow_periodic_ms == 0 || conf->fast_periodic_ms >= conf->slow_periodic_ms || conf->long_timeout_ms == 0 || diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index f43217bc589c..db5052a9ab6f 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -260,7 +260,7 @@ get_entry_values(const char *entry, uint8_t *tab, if (nb_rng_tokens != 2) return -3; - /* Range and sanity checks. */ + /* Range and input checks. */ if (get_val_securely(rng_tokens[0], &token_val) < 0) return -4; beg = (char)token_val; diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index f832b52d8996..c867697e05c9 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2071,7 +2071,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr, break; } - /* Perform basic sanity checks */ + /* Perform basic checks */ ret = nfp_flow_item_check(item, proc); if (ret != 0) { PMD_DRV_LOG(ERR, "nfp flow item %d check failed", item->type); diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index c35585f5fdd6..8b89841e03b1 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -1383,7 +1383,7 @@ qede_rx_process_tpa_end_cqe(struct qede_dev *qdev, cqe->len_list[0]); /* Update total length and frags based on end TPA */ rx_mb = rxq->tpa_info[cqe->tpa_agg_index].tpa_head; - /* TODO: Add Sanity Checks */ + /* TODO: Add more checks */ rx_mb->nb_segs = cqe->num_of_bds; rx_mb->pkt_len = cqe->total_packet_len; @@ -2211,7 +2211,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts, #ifdef RTE_LIBRTE_QEDE_DEBUG_TX static inline void -qede_mpls_tunn_tx_sanity_check(struct rte_mbuf *mbuf, +qede_mpls_tunn_tx_basic_check(struct rte_mbuf *mbuf, struct qede_tx_queue *txq) { if (((mbuf->outer_l2_len + mbuf->outer_l3_len) / 2) > 0xff) @@ -2473,7 +2473,7 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) RTE_MBUF_F_TX_TUNNEL_MPLSINUDP) { mplsoudp_flg = true; #ifdef RTE_LIBRTE_QEDE_DEBUG_TX - qede_mpls_tunn_tx_sanity_check(mbuf, txq); + qede_mpls_tunn_tx_basic_check(mbuf, txq); #endif /* Outer L4 offset in two byte words */ tunn_l4_hdr_start_offset =