From patchwork Wed Nov 15 03:23:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 134367 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA51B43332; Wed, 15 Nov 2023 04:23:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFB73402C7; Wed, 15 Nov 2023 04:23:38 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2119.outbound.protection.outlook.com [40.107.223.119]) by mails.dpdk.org (Postfix) with ESMTP id 67E92402C7; Wed, 15 Nov 2023 04:23:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8eN1ctsVkboZEph2uM2ILo9b+mVaHsT1wglELG8DjxwqGT65KWMZiFZrapSkt1WuLPph42zEk3P4N+C+kOMZY+8WIT3PgYFflxITuuwd3xG4bJlKqHDNgWZ5Ws1Gc1kLlTdre+iQLlkddOB2dlC5MwZ6ITnncbGZqxnkOtDl17QBhd5p8UHZDbkyBU6iM3PkA6UNbbIWPJW9N5T1mzj0ipVyrH6I8LJDroCk9udl1wxfWZnoQirA1oGPArG7delE0Lc2HCLiaUvLiNotoyq25fBl4Z45RWU3GY/7NaQQXJqCKO4FkvUCmV/2sMJ42F51u7tDRwk65EAKokc5PBORg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xoiamL15Fd0u/AjhiH9kE9kNXnweJx4B/ErFKfoumN8=; b=ivbGSddOZ9WXxt/ol1TfS4/yov2rwwxH9+lEoAb8iXDmJo9jJwVTdx/tNLwx0nFMGWg8MQAWzKixLi8zgEEkJ2yd3Cdvw3prx2OFghfBplO1MfqVtWoV1D/DL0ATWXtp1QcCijsVW+3+g5P33vQQBtF8V4HKGK0M8V/KOSgZ9+naxNB2q34SEvZUhZDqPSKTNjd4BNjdGgaJb4SKcWiUYUO1K2TEWe5GHWS63I0jENWaupupAFSaoP5ibndlWX4NWrAZBN/1laQVppSLrg3Uye7kMQXJSv0l0dcUMBYCrEnrfFf3Xu+3D5lxXg1tXr3e3iCXQMpnNZ2jhhMnEqTxPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xoiamL15Fd0u/AjhiH9kE9kNXnweJx4B/ErFKfoumN8=; b=p4bFtnkWUNTwtPfmz4XtM+zkE2h7tUIp5lUq5i8vCzZhnPbltcCHiHZzJwTPszKqytQokRfEYmHIMG35Y6Fh/NjzjshIotHYgtcDnfnaFFSlXg4tOCpYb3u2udT/diSp8pTodB/OoqbYx+MRKsLgmbIKNtF68jACnGMvXkhdhiU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5719.namprd13.prod.outlook.com (2603:10b6:303:171::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:23:33 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 03:23:33 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 1/5] vdpa/nfp: fix checking return value Date: Wed, 15 Nov 2023 11:23:06 +0800 Message-Id: <20231115032310.756221-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR10CA0023.namprd10.prod.outlook.com (2603:10b6:510:23d::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: a0e0ac49-b445-409e-6a6c-08dbe58a3f43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ty+Pk7ODKjv+xCETVkNq2Ds4c+mHe6PeF5BUTc5vljelfEy1fZWzeRzBEa0DIAEdb2WGxRI0owNjU4hrAwNlIOcHYBXJOoL4tyiTN8IbQ6gt4lf1qK1wSJDEtY6bJQs/w7bC5zcE0Of7ljmwuYdRXDZ26BVsWt2a0s2z5T/VndeYvkMfTN+Daz3OHQ0mEMWdTuJw5WFqkdnW55wJiFIiuly8V+92ZEIsz7KWNgqjDGUzs58/q6lT74x6Nqkvj8zE/72VQVMXeInNTmqohLCC/PFxqJ0TL0IeI6i4ySVaF+Hn1IZ3V1BWTFmHGkOBI5Tkhx2bvALzXMNwlYLE2qXBPUUqlcnuwaR1k3ZcF6VxsN7LrgyjuSdtGz8HyaoK+ArOQpG5evK4JzTITCUMwrLyboTTchL0hfcLsdLD6DJMoLrp/gFKx4tKCzMYqqh0sMDd9E4jT+/QqGk4pIg7bzQY3JETub9lI6OCF4Rvx13y9rqkq3KlcpnE7dsUQK5+hINAqeJQehnRYWImkXs5kNovn6JHa0SWXHqjMc0Yf7kdljO9OQ5GYaCkQx0KYU615JeWaOQjt1pPzpZ1MVsVhjHDWeUfwTQNy8jB0kJ4xmIPQp/JQEH+m93mexf8hkis0taFw29asBqnKNEluUa1ehzPTQ/rxjuO2dIsbmia+rUEGyU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39830400003)(366004)(346002)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(6512007)(1076003)(107886003)(26005)(6486002)(478600001)(36756003)(44832011)(450100002)(8936002)(86362001)(4326008)(8676002)(5660300002)(41300700001)(2906002)(66556008)(54906003)(66476007)(66946007)(6916009)(316002)(38350700005)(6506007)(52116002)(6666004)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /lvft5ix+AoStn9KmVxxkEO4XlHWQmshbr8w5osZFY0Vi9EmYAE3/025azdnT2gxChMtDTrXfcLICPRvlu3eS5ddPfmFI1sTg/D8dNq+ObKOWkpEOMi2+tY3WhMl81f1+DDm7d+fgc90O7PQa2WlxVwLruKUzu+kBtBCNu+PHsJVb0pjuaA2euExnY3MrXMt4U8tbl+z1JThfAn2KdeHKX0x8igsfz4fyzqGSfVo0BHibtSmpXS8qeCfSwP6roS+WIxL9OldhXmo/J5H71cFQjPHCFGPRCJBZtbaWk5w5gS619aTzUVwugFdqnWODCQ4dBUkz2HwZVdMmdjEjfNOZXzjrNJ+WFnMHxcZm1IYkYRsyMdFjxF86hkpwWX5dp9J+hDwPCK2Zt6R1xS5BAs5Y3L1Q7XfZwsoz0IaHgD82Enzsq8rfkeu7vJHtIcu80vk21lpcKddbFZtbdX+KH6wY+KVzinQIUcqYNnSPpojNSHvd68kSmd0rmB9v05MBF8b3qpwhsHaMp9xjPn2U7Ri6CKHsw4LWdYh68OJPU6bqovQKQlANNioLsr6cHC3kqRwkn7EwJIeZNZjPsqTMP+EhwaffSzu0Tfq4qF+MJj+hmnjf3cwmdqwyq7c+u/DIMRfohh7NwhT7UFv6qigmwA+FlNF39UyHXU9pKY9QsYus9CTsjBJGYmtfrEtB4uepwxBfH1+6xlD3J5Tr69fJ9cww9kUQdF+8ILw827BzihBt6H2+P6J/svOGwJhqs9Jxn4sKQxHVJhLVASITB6v8Zna/yxIcaGLmDmP8gn4fTyq+6/RGHFRJsy6URWcGF7+3Nazo2A8AA8ufbecUaNrHW0KHR/h6zUGiVpKEbQKLveRBF8uwjUsSIR95ux/oyyWWuFuLxWJTAkxSfk7ijtmf6Ei529XKoiAc2SmAmxjDcDzf9blUDkQucl2FiLOqGoruh4NnmjJ9UjS9zq32wwNm7IXYDNaZoPn2fvDzuDC+LtlYFB14F+4RufepcodlmPWCFZXPgCfFwx6ViSgxcfxrKXTnLVpsom2GP/m4/EUy1TPrdHiC17G04lisBdkvJLzzCaCpK6VakUFmkuMZ8qSdWte+vyueDl9vNJkJ8h0grVojbV2jeHptE60dkJGOb2gpSD8X/K8cZQ1zWfnh2U67n4G7qr0VirG9ICQ2nIzhMpU4eDRv3DBUS2I+vp1AmcZ2J8IhQruo4H9lzMSSpostHB4ONzw1gsxcQsEjX31nDKd3d+C7y1TGQ6+cny0eURhP3b2sn8oOehVBtNsueLOidxcqf1X/+eXBypQgFPilMl3+WNNUAMUhg9UK5mv1MhDNUjJFslhu1/G1WzU3aTCEpyEDuGJX5ExnprDau2CC3q6HSUQu4x8lyI3iChCjXvVjvRE8fWNh8WcSy3RJ+5asQrFEQrN+3KxboshhNrXmEj6u4pfbZzK92CQxatrwf9hWwrlwDl0JeK6PsGXCRHT5VTWoOchH6qzvLayafTDog4Wz+VXGiXRs/2YVVZAC3uMau7CQegw3fAuUCC6T2Km/EOxF002sKOaFrJ8wifmkBgqOgxq6tMN4NHtAhjGwIUkFkL+OFXdhmVIKGK2IICXG55Ihw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0e0ac49-b445-409e-6a6c-08dbe58a3f43 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:23:33.6469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ss4rqFC6iCzdXexVOod3BZcR1EJCDzvxvXdqpss9nnAVn7hTuVEdWfTi3m72py+8ZNJGmUl0UyPpAltgvPnVgBaDBTYy1T81y5c73DgUstU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found calling 'rte_vfio_get_group_num()' without checking return value. Coverity issue: 405356 Fixes: 7b2a1228c59d ("vdpa/nfp: add remap PCI memory") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/nfp/nfp_vdpa.c b/drivers/vdpa/nfp/nfp_vdpa.c index a1d1dc4f73..cef80b5476 100644 --- a/drivers/vdpa/nfp/nfp_vdpa.c +++ b/drivers/vdpa/nfp/nfp_vdpa.c @@ -113,8 +113,10 @@ nfp_vdpa_vfio_setup(struct nfp_vdpa_dev *device) rte_pci_unmap_device(pci_dev); rte_pci_device_name(&pci_dev->addr, dev_name, RTE_DEV_NAME_MAX_LEN); - rte_vfio_get_group_num(rte_pci_get_sysfs_path(), dev_name, + ret = rte_vfio_get_group_num(rte_pci_get_sysfs_path(), dev_name, &device->iommu_group); + if (ret <= 0) + return -1; device->vfio_container_fd = rte_vfio_container_create(); if (device->vfio_container_fd < 0) From patchwork Wed Nov 15 03:23:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 134368 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BD8543332; Wed, 15 Nov 2023 04:23:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1011740648; Wed, 15 Nov 2023 04:23:40 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2127.outbound.protection.outlook.com [40.107.223.127]) by mails.dpdk.org (Postfix) with ESMTP id 19C2F402E4; Wed, 15 Nov 2023 04:23:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqVKgSrqobS6bDwz4LYVgkwDtRqcHVm+WQqtevNhbPKw8ThhO64NsXG7oyUjmwAmFwIixhdSW8pQT36QOayF4fRdxGbH/BrrX8Cudvs6a8xPXN43sMk+eJ4OZnrWpSf2oAA7IXkF9xmhQ2jKCZnnRaG1QxRXZsfCUqjCSuBhMwqED9hLBI3iv0JXoq3wE7uJsmoLTXAjACD++OXC6IHhg6N0fTmdIEEPcUtgmAimhZKLA+JyybrTzAYUz1x1Q9yHKCdIhwNDWcJ5CNsGV379KdAh2Yd/09iOEVm42hVOuH7ObZ5wG/BXBJkSt5HVt0AzIwlBWCQdMB2fIh6PrxUbLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EawV/gPecj1heWN8y308GF+yr/8oInUXYwvwhUvsTZA=; b=cog1f/pxn4VmbMvRbfqPEe4Xp+jcmOvqGyRwuMx5b8iuxCnPaBHS71sRc2gLJVhFMyksy1wPRt6VI1jrXq2vMCOPL5bjeHKcdT7FwLPA6ZHK/rvlcPQEcoYmcWmC+MZ04QLGPYgnPSCT+4yviH5GrxTi2YhUTTv6J0SbcvfeO72hnzlFqZwjMhuuNB6uF+GMcjRvHt51KQOjC0O6dsQFJsd3KbPCG3toY98hM/fjTLG5TpV/n697tJ3FgulgthVY8xwvtLvyto7d8xJXHUnhth7VtFBHh0HtKzb4xWY0xhaWOva2AznYgWKe9YdUITt1y50P3iRG5rP8vzgVSwA4ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EawV/gPecj1heWN8y308GF+yr/8oInUXYwvwhUvsTZA=; b=cP3XVmSx6JI0qhcZG19DSXUY6MN28+G5FYPoejixQjsPEYIGxp5EwZgSf3gdlTjca5QOuwhGz6Tuo9U5x7fut3x70QM3ASY4u1vMe27E/VjMVXxVDnmQ92KGJLps10ZX6yE/JaDbuv5c1LA/ck0pD+bLg+6uixCyzbAQB5dQQuU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5719.namprd13.prod.outlook.com (2603:10b6:303:171::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:23:36 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 03:23:36 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 2/5] vdpa/nfp: fix integer handling issues Date: Wed, 15 Nov 2023 11:23:07 +0800 Message-Id: <20231115032310.756221-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR10CA0023.namprd10.prod.outlook.com (2603:10b6:510:23d::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: 8138cc26-1dbe-4c2f-b7e8-08dbe58a4116 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5tmLIZSejjntX7+PMY+p00t9bRb/2fhVRRyiK2iPIg6eixrhl+gD9RtcYfam8rEeGHE0oJTYMo9a1BJqt8pUFh8kduIvZmbawZ8WYG8IcKxVV7tf2Jm3RtvEiBg07PDWOCwzZUEhGMtc0G2a2Lb6U7YvfOQ2AvbgJHIzYDRig+FYVMBLeH4DPESo3eOiAlumQ8QUP7Mvfc05DiwUuPMFZbnttE7kXAWYaGpw+g2BfO/pp8Mzjz4lVUPTzkU2pGk6KAkcS5fI0h9ZhDbUA+L8NO/HpvRFzxVntABtOWe+FgpG9mpZUERg8HuOH68GYpThBiX66XUelzdKfAgDIP6QBQxILctjht78vYTUfvIrEUAj3gDUwxaFnxByxPAfUF2OTcCDRs+LdvzrCivNRBksAmy9EfzSgYNc86Pi80ffkjQpZXSY8q3TFo5xTFIbNstjRWOhzyz+FEOoemKbTdzljXlErxbDeL0ZCXw4nAgPu55q+lIcdfBbXqFYECvqQFVpeyD9c0pdLD7hNOZ2QKImfNlDiaBVRVNkQU2Kc04YZBoW13kf+yb964694DPogUoj9757QFo68RYJD03CCrMTCc7RbHuC+h8dgIPrUbwPXIT0b6K7XvMH4bLefqfLbozZnD0xgCUQvWKJW2XFZcMwJqoerabAyFdOmns9udWiXy0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39830400003)(366004)(346002)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(6512007)(1076003)(107886003)(26005)(6486002)(478600001)(36756003)(44832011)(450100002)(8936002)(86362001)(4326008)(8676002)(5660300002)(41300700001)(4744005)(2906002)(66556008)(54906003)(66476007)(66946007)(6916009)(316002)(38350700005)(6506007)(52116002)(6666004)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qz+wrckqC3RcGzF4mEkOlYqAnTXgRombYfkPTm9XVX/99PL40dD3BNib/XlFBW3jaFHYF27hBdslWdqpq8LgPynsN0Jz+fnQAArFciEHfMwsyOHqa378q2AmZMciuhFet9TmFnOQqGBUOskEpkhtPN/s28lkWCXrtqUd23vVtGOtsNileH99eF7S30tcTWkcBoaMkxOtSlgpZo4r/aHdHxZPadgD14omofc2FMorJQXlRwGAjRrz8+Y8vLwkVxDA8LsetMLXKP8RMLGllo/3dNfHJEzPFXmHQ1a2hUACFdZRJYatLaV59wIg4u8iy5KPqNgh2KP3+x26MMQ78FSXuc8Sdbkm5KfQKUQ/kMXv7w49ZdAvgMIA3XX+l/tI8DmrmyhVfva4nEyBRsSFccRfl0xmIG5xFqwp5+QZbFOTdJPDq2TQPiapFxqwy8izXuGfgvFQScgg9Z8xGOp6KKC9pxDUpFGBtf2PpHPMe3gMAjqHfAmzsVU82YVEpJDp2DciNq2W6hfefdIAmrM+G+6g3FrEv6QGp1LZdwlS2hyEzPptXmXbiRZZ4SHRzutxG9wxkKwdSyF06oS8c788Y0OkMP4xMCGTIESILL/kHlHMfS2hjcN4zAosOtNuIW2+S2IoVVrPdKuSAUa1xPrNd7EDh+hjWBxoVSZtW5qGlKrYlFCR0SvN6ynI829Tqjj7OggjXSYp610Bfmq5naTQQbwMHBSK30b7AlqdKCiiRYw1GB52+3I/HJcP97O6w0kAC1RnIhejhVbe3dmqlIh0N0iSKwsuLyaO8fVgDDaXDSyud19daDnGgPHZW83Xn836zI2KTHJEvW7tu3cPy6D3gUO+1YCuK52hqRbBifAbnVyWFpk3W76f7C4eusBY75mZpEKVKOoBhHvUE6unB+nRT2L7xWh78O7y5jn1/v30koIEBz1lNwyc/4TJwPnI7Rzn9cNqwqaxlBjLG0gdIhBGeONO3CdMcYp8KWoa3Np+Fot5JhGhnpSVXn3chmVyuMfzxVYfQqFNOCfi5ZEqjBwQSHqToafyvuoxdUq6NOn/crH77JIKJiesITJ25KkEAmbKcLo0lEafEudPQWDwLg6daR6cuuDOWDX7MF9yicZn4deDZCkBmTfNQW0hDHDOhVT6Sg4gIYlB1Oi49MN9oVQxr32cqqGYqX2NmHr1UEHWBkF9HaYhrZ29BElWaZi7Tkv4ES+eOshYrnDbXe2GhD9vid6DuNr4jIPPgrTfEo7uX1cRxX0U7W1hHwIkuXDuwG+GV1ryx5RyAr+B6bzU4c1AJYfrs5GyXgBgVM4S8UcM7gFuqtlkhBPwrBMixBS8Cz59Ifq34Ga1mRyIwGDW6Amobk082lpai4NziVWmCQ/G/CUEfm6L4gpXk5czlpdx8LTKKhdUr8vP1oswrUTTSKdJUTu34bop6j43bQ25MAeMiDn4VLVYHtCkDbSB+H4d4JjFOZdXdlV0y920dtNgpColi0uaAdrEe+BIY7bzG3VtfDlc8Ae/L5q8GIhp9jT14iNVROzzu8bROCh4uWdu/Fx3SfSsDRro9bXTSFcuW+dlJrStX5iAw3GgNwK5dVVMbtQNj+bQgMWRzZiNh6QrSDt0VFAzJw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8138cc26-1dbe-4c2f-b7e8-08dbe58a4116 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:23:36.6929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LEJDVhtDAB30mZ5IhIw1UJ5410vdVSwxHlhTj1N+PSF9kvnMzLyswryI7Ai83VdICeGg3XeoTsL9488Lv+h7bQpNRRfIT87tFbzeOGBZP2o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found integer handling issues, overflow before widen. Coverity issue: 405352 Fixes: 76ea5ebef08e ("vdpa/nfp: add notify related logic") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/nfp/nfp_vdpa_core.c b/drivers/vdpa/nfp/nfp_vdpa_core.c index e2a6253ae5..7b877605e4 100644 --- a/drivers/vdpa/nfp/nfp_vdpa_core.c +++ b/drivers/vdpa/nfp/nfp_vdpa_core.c @@ -176,7 +176,7 @@ uint64_t nfp_vdpa_get_queue_notify_offset(struct nfp_vdpa_hw *vdpa_hw __rte_unused, int qid) { - return NFP_VDPA_NOTIFY_ADDR_BASE + (qid * NFP_VDPA_NOTIFY_ADDR_INTERVAL); + return NFP_VDPA_NOTIFY_ADDR_BASE + ((uint64_t)qid * NFP_VDPA_NOTIFY_ADDR_INTERVAL); } /* From patchwork Wed Nov 15 03:23:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 134369 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABFEA43332; Wed, 15 Nov 2023 04:23:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1452D406B4; Wed, 15 Nov 2023 04:23:42 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2098.outbound.protection.outlook.com [40.107.223.98]) by mails.dpdk.org (Postfix) with ESMTP id 6D7D44067D; Wed, 15 Nov 2023 04:23:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WsGEBR97Zc5KvHbsNgI7p06roQ1/+ObXuelhfII/7MhItupQulKIw1t3HgekoW8g6aXT2tBQI5vJWsokKH78feCm0tkh9LQDw5Z/ouy8mrb9D8dKLlqxoJIbksLxEUZIZsHVVOBUzrUNsG2EEmy1e6s4c4h/wAHOytkdiXdGeBdWd6qes0OC4UBVjGL3JM+eJKaXwVdbfr/XTEmrW4c4bG5IE12eWetFgRGd1i1kyQQES6Ke+YjZ1hClWTdCfJeJiRjBM4jXIj+tKh2rVn2URG8odwlpLFeXEBj073VJ0nqlIO+aBfCl4L3KGYJJUHwztiuln93/IYOVUYku2vYnZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ig/lst82FvwA2dEx51O0PSSWNp7QKl0AZXi4TFf9B0=; b=WWuQT7vYHSUZ+g/btXLFFB1J85oIubxfeSbcKz+RGS4xDGB3TcFZEpq+N/mqySrAUQZFZrQ2kafaFa+hUXGQY5Jfpd/nnVE6IZv/11CbkfoiVvvqamSjIuNbzvTdafp8RqSMb4TClriql76ZQ3xlHKn2fqAV0W8CEgEdrTNDjvQmrHdQgoQeY+dnXRtNY1S+yQH4wBgTkS6hQVpz88od26W3VavbC8BgmhQ6vdBk6Aq/1xuG9QG0w44EkbFFE/ZVXHJQHO7KygjbzKcPQ6z01LlH8VxsWCBgA0mpieLszaL+woKOhu0z4C8C0eL23E7ECQx5xXx68hg+KUPjzd9QwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ig/lst82FvwA2dEx51O0PSSWNp7QKl0AZXi4TFf9B0=; b=I2r4bqOql32FL7QJqTabGJ6kSrdB8LkWTsRpcKVxiq9j2h73R7VecN1hgdv8yJuF3VUUwJ2Cvx7RNi9Ar65T127PUl1Jkr5wM0xInuMhHeWQnAYtaoNH98ekJ/jEiwmpAU1wF4bhr/beXGuROGe+bt8P1rQKd6hm/unASniJ4Mo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5719.namprd13.prod.outlook.com (2603:10b6:303:171::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:23:39 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 03:23:39 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 3/5] common/nfp: fix integer handling issues Date: Wed, 15 Nov 2023 11:23:08 +0800 Message-Id: <20231115032310.756221-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR10CA0023.namprd10.prod.outlook.com (2603:10b6:510:23d::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: 18a150e1-c6d4-405e-4085-08dbe58a42e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W0BiX0e/EOCms8dzFzGpnrwC6MlSL/V/7SshA5X6dAB+uz0Po2QDMAHYRVKv3AEPNNF9O3JMTPyMZ/G8/QvJkbAXdrQ+5Gd/PleFp2jz3VJlFP2iH8mJwWXGxhlNdGoNnYG0q3VUoyNpil9d9aNzh1FmbEvWp0X/mPTFiicdN1XTVNEZwGtO+Y1vIzBM6iTlV4brEAE0+cHIctX+avGs9MgWDFdJQOk/hxJ7Ei82k8ymmVt21Wc2O7EOW3SPXOIwjKvqsitUd4yO+NduuX9REup0FM5SnWelSdGL0aGLvgs+D4x5Hy7pOXBPqM0cs2NYoybISc9vrUdKEy1v4JIBKEfxL42swWqAD+eBghGrbjnaLjXE1JLkX/bV16RQQknIz6azr5KIQzK1Wf37hxp9OgtDixKz74uo0q5/aWK5peeOOP8rDE1RClNRVbp0sqt2dmijHwYLFshcX5MNzST3TRlJDiUsVX1UAqRADVbS+m9qvXRprZ1yt1NOxhVoMqPv0fmodnA74ZnaTANTlgOsj05noEIbpWZ/LrPXzS6h6cdkp5iFRg2DYA6Oh3Hl3CNYd44q0qJyNFqUjscqpjTUH7nXXkh0TihDphfcIwg/eUqt1Oi/769qvUNbLvsL3rhWNZveBMv0L45UAFMTJtgvBAx40RGGg+5sa2HTDDLfO9I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39830400003)(366004)(346002)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(6512007)(1076003)(107886003)(26005)(6486002)(478600001)(36756003)(44832011)(450100002)(8936002)(86362001)(4326008)(8676002)(5660300002)(41300700001)(2906002)(66556008)(54906003)(66476007)(66946007)(6916009)(316002)(38350700005)(6506007)(52116002)(6666004)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t4ltDQIj8gy/EIIDAML4C2WKBBZy8NF3bvr4EHlcnMKX7tsdZiZWm53CeT0iKWQN72mK+BkdDoq0VUDqBB6FtxxbTJXB2zAWfve62pwHfFSzuLbtIw6+q4r3oE2aN+igUjWFM45oU5+KftpJPo96z+L+n0/LDYJ5aIZ/2zV+9F2R8gMFa8vyVolr3iyiHAoL87bl2z7WRLUn6uYEHFkUaufTUun7la1t6KEtKN2uGtS71gaB7ob167dpccTM/uW948kV2AropzBhblxnyefBS5+QUj8gTr5VM089YkVuGCvwXK6JDuAeF2jsma4MCNPAKWjMtZDIj94lNGDu87y8dzaKu+BPfOl2rBbzwCdRAu2p6fcFyFbP93ohUeEFcppyfwskp2lS2368mukMaCU0BPLBteCoMdd73H+mnzGD42/Vk5SxHxLzqR1C/Nipk0PlmFqzz2bSwSetlLLq0KSkL4w+xN7PybaeWS+JR0Q91cKmI9okM8e9N17RuW68WkN0auLNXdV4JoLQc0JLpElzIMCGblgtQxLA8vVaHe9gATTmlrZmZm23kZaKFDlHpfZsUWaBUoM91rForlaDPMaQ6PpfCjDBzIpVaj1rP+vf/j4FLPWYjsw607GbtuaoAHF1ZL9jYWlwBZx5MEvnF+/ImJj5z6W2PDJQ8hIOIPi0Dzg8URH4U5WhkwFZAOzfoMlNRj7qpdXTu9gV/e1pDbIAcTcxRmQw5M7x5QBoYPo59Fp8k6csp440t/sp76iNJYJz4SFsRQ1bEF5/zOBH6Zdn7XchfRsfXWy+YbIIi0AcfiWE46MfRN8lLTF0abpCW8eWD0zrwMMADmPpNgNObscHfcAAOL5/zCfcdr49rxHxyoA7lD0AGz/OxDJn+iKB8vvwNSl+myDEWmkJLG/lnXAmFBJeGhfRGyPjwTvE4tcVOIeQhG7DBlkhgvLvTKIa3FADO+7RfGSkapWTSHwayGhvvOEFd2PJ27d3jNY+hxWxJPLXXRqcO06uTdSEP5+c1/KE2k87a2AP9SrRqiiMRm6wNqF4bdvUKN6ioKEy2Cgg0ywaVQDbZ/y/h2Ep4/JWQmnKRJiI+XJ6nKMdDWQnfOyRajzlAaMPyz+TbC5F9e9F8WVXvbXWJIGNDpnm3j5DThE9giaHF3KYa7KzFLo3hu2jLE2noqjKidlZM3FwcplZGYcivb3BS21c1M5B55srhpLT+ZLIZ9xO6XPmqESbLxx/VTWJqKM9Uto82IS0TSNA6H7rgLbvycJ/vhDY0vOiYLOk6AX34UDj8L0jzndvYGAL8HxaOlGRnulDdYVc3uKRqMJmSxqdpegofeyODNO8sN7FvF7l/6+faYsrFTbBajQWLxgPTTW8WB4MKICrNeMfOJlrmht6xRjg2dxvavAnNyOzuapcNvh0aJctEYyft348kBfkjJZZd9XHb/nsCh/4a0kmrXWOT4rRLtQ6V3q9tPxDYQhkmLNFg6osgasVAa+F/1A5UX97yZ7+FcYBkJ234vJDujSBk81g91DNWGa/GCwkx8xsWxRrmIUsDLiN1uLUCJ+XR0xV5EsaG6cbn/H42icdlriKfNsd/+yvGVrhxUqeHpn1b8Q6ydr9wYyLxcYfUA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a150e1-c6d4-405e-4085-08dbe58a42e5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:23:39.7322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dypgOY8hoqdpmDX0MDwDpA7sDhAhca1copqtSsf98sVEDF8nMbMmu+yO0ASeMOOoT6r3Gbu0K8izUYWMculAYP4UAGcyoqxtx1rHP6mIo+8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found integer handling issues, overflow before widen. Coverity issue: 405351 Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/nfp/nfp_common.c b/drivers/common/nfp/nfp_common.c index 4c94c9d59a..40e1620c2e 100644 --- a/drivers/common/nfp/nfp_common.c +++ b/drivers/common/nfp/nfp_common.c @@ -187,14 +187,14 @@ nfp_enable_queues(struct nfp_hw *hw, /* Enabling the required TX queues in the device */ enabled_queues = 0; for (i = 0; i < nb_tx_queues; i++) - enabled_queues |= (1 << i); + enabled_queues |= (1ULL << i); nn_cfg_writeq(hw, NFP_NET_CFG_TXRS_ENABLE, enabled_queues); /* Enabling the required RX queues in the device */ enabled_queues = 0; for (i = 0; i < nb_rx_queues; i++) - enabled_queues |= (1 << i); + enabled_queues |= (1ULL << i); nn_cfg_writeq(hw, NFP_NET_CFG_RXRS_ENABLE, enabled_queues); } From patchwork Wed Nov 15 03:23:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 134370 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 334B043332; Wed, 15 Nov 2023 04:24:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8887D406BA; Wed, 15 Nov 2023 04:23:46 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2133.outbound.protection.outlook.com [40.107.244.133]) by mails.dpdk.org (Postfix) with ESMTP id CB12C40697; Wed, 15 Nov 2023 04:23:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fQei6wPwxhaupUBrd/wzeERY1y0epo8zT6DCvwm8nA8hjYKEcAtjQkReTc9HAOGB28XcPNlg3AJuqcEP3VaSoQVggXqo0Ku8ZJ+vwcwuEciJkllnnDgj5eF47ZjKAr2PMwHgdjlsy2d2rUmPMFkdqy2B8Kg4AUX0hXkqetryu/7kG0BYG2/q0us8UsP7pnkOhqMwLYuWs/CNa/NrA8QcXEmT+AI4HrezobyJlpUthuKwguysBIfd9Pon2fniuZj7Oe50GjqT8lxjCYbFr0xnkEWu4DJquNaUdNQsy1+rO4u7jRgqvWEJIwQmzzmu06srQNHmUSv/AeMIXXn42ezA+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zxlbl7MQL+54dCTH9FsvWp/4Y+HtSZZi0BrIzPlPtNU=; b=mvQJBe1oTlNum8mdAtjPoL4OJPPx1lPI6CRlGfL8ykwY3+65lmEkDOjKHWE71zirsiRJ1jrpLaqX2duAHQylEbaqTC/hWRznTdjl8B/KVROkPkPR3ovBI+kMvE5i7MTKIc/YzWTJbnGGm/b/LlhwvM9wwQf1RnEEYL1+W8pwd2y6qDLN/3NHZUpBB+BtSfDhp10oNTCAltRjYaFHIFJXI81ADBbPYachrZmJaTrjMaiQ7/mb0nERiHo6RlXYyllJygIlc8HLBdvp2YXGTPKW+LpP7GRSaduzyRpQ0a+f9c7rORn/QKCXpwCODJ6Uk4fKEyPiXAFN/6EF22FJqIN7cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zxlbl7MQL+54dCTH9FsvWp/4Y+HtSZZi0BrIzPlPtNU=; b=ky3Z+WA16cY0PCEBLVFuFzHjmTWJ1SB7AMr4KXy6RhzXYLgwUTLLpSmLolC1umRVTfK5jLoMI/FsOEEGT6G0EXunKZ3KPHR685QXvDDvjvHyItMJbjAgQv2eHOro0Pn0hsEhpkhcx1cUK8QzBMCAKgMl1qlQRXl777149e7bVQs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5719.namprd13.prod.outlook.com (2603:10b6:303:171::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:23:42 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 03:23:42 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 4/5] net/nfp: fix integer shift problem Date: Wed, 15 Nov 2023 11:23:09 +0800 Message-Id: <20231115032310.756221-5-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR10CA0023.namprd10.prod.outlook.com (2603:10b6:510:23d::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e098a6e-90e8-4ecf-c93d-08dbe58a44b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ctL/OaTqBzTB7Wq0Fs2EQnO49+zH8O/xdckyt/7usw89+QcIUfXqo+6maUt090pKj98JQgDnzZ6+EZn1nYJbelC8nERRGzhsPRkm/HcySP5tcaFc2dJknxnkhnd/t+0kaRoYNNZLdQSnlJCv5UgG9oOaZfX8uGL6bgjhp92eNGl1wfrhZwycHwSg4qQf9U73V83E28BN2b1uzCb9E85j82VVEgtkCA70shJQ0Ur7VhFb1TZwmL+4j0PUWQueHM8+2jkXO/cPJQrxBo5XT/aSux5zxgntVHyLh2fgloTIU55TyM6JKwT2JsaGqHNRhYY4E1efAgputhdKV/ZATQCOSIrO9JyTD42kWcnpQH6ruxApTJisg5W3njKWxJ4hF7/KPUO3K5JpcyBYqq2wNr2T/AuFESy+QxiWdtUiBuv6TORSRkr5HXhNN9qDioxpyBnCMnEdmfluHm95X2AWvju09917VP96sDuQRUxRXZZtLV0AjHHLIK7b0vI3n0ASoFiUekpPzcSgRKzIcZ/PP0FzK6Ulv6NWv2mlXHk3I7A1iiz46YihCxpY7vFm7OZVOrq48XLWbw2SiMIpNtC+Ls7o4e+TQOEp5N4jzKaAA6tChG57TYN7PTIwB1IQn4S5wtZgCVEi3nhsfcyhXBBqcyGMWP5F+3RNp2sV6zkXYcu8k2U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39830400003)(366004)(346002)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(6512007)(1076003)(107886003)(26005)(6486002)(478600001)(36756003)(44832011)(450100002)(8936002)(86362001)(4326008)(8676002)(5660300002)(41300700001)(4744005)(2906002)(66556008)(54906003)(66476007)(66946007)(6916009)(316002)(38350700005)(6506007)(52116002)(6666004)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7LNBxhpkniCQCCAPTjaxyf0Ddxofl229YqLcH3y2dDBLk+EknjZlyS/mejzPRWlk0/DQkGhF98gBxqK5WROrgo52FdFnq0r6DTxHjSRTbE7rlBtaYX+aWet0iSqB/6Wv0RxGeS26Tm9A4m9taye+C0ZDG4V6aiTj3uBKiFQ7Uu1okiCGpxbTE3Tx/H7KdyrX48dr23P+uIRTHu3nlH/9ft9H5MBAAaCwrLAdfmpk8yvnwglpmhzKySFqnjHKEFb8GRPL0PfVujXVm+3N5pHbnV+/4OTXXq84qVmVSoUvPy5ITVB5yhtIjSQUHj/K1DPirj5UKDuCq8LOMgZnGG09HswBEyPCJs0jQgryHfCIaUtYeI8cyR+St/6vV+zwWC1B8BqqCnP9mKCjNi4XmexlImDJqZMLUNE5GW/Y2efWjzMDyAKw5Vs5DBt7FwH98cKTJsqpVMDixXV8ADVgfpj4uuPGOMfRToPGyU8V0unUOVt1e4WNw5mq9Q1gXHJxYSW0G91aXliG7BYdgHqK/FucehDo4oHrrWlYHzurNGGrtogqzyyyzQVORRYPUevE7us1cA7Cil1YqgJZkTF0rt2N4nbd/vyXFnOQ7LjenelhitAwU9fcMQ0IX6d2yMdSb7BQflUH1TnVUuvGG86EzDw1QEDmqbpH/FxT4/qzLtuJPAG8Iqn4CySnAmAvB7wMXxyBHtv+7JNLVdiJDdNSBSlk3k27+R3T7WucLhixrcQHDklLj+Vnv0ET7IGyIUdV4QhcE1CSN3zaMsj9QW6AAwhmE6TVCNMt5IRXGLjPKD3y3TXDjPmbSvlykTSB82id1syBgEFDtuQL6Yokiam18aieDkZrzDllkomjDWltSXXevDbni6ISZ0FlZrSLGOsT/YHkKkCfhT02fgGm45L1LXzfsCPSa8y4snogJVvnoEbxVKC1VvPd/AiiN68oEgzNYKejjEQriW37gC1jy+K0ZDiM1qyNhMKxi6vPVHZ9CRJhfxUe3uqKyAzzWokvxZzPyP2JsxcPiu9QTWwrYAW8vCcco03V/X/Y+BYA95t+tiv+oiovUB+J/uVIzz+C4rDI43rtbz0j1lCkTTJPRAgCDrtjEO3t6Z2VWkeK+NXbCQufCLIT849LaPiaZcpA0UCrSGBiRDFTGkps7Md9foxN0YosF96AY0j9diZL7eUE6EWtqCx2VR5pmuj8Np7kkuYrffz9Pp4hXz3o4d0bkRb12d2rngngV6WduNuATjxtppwlXofqQp58r5G7NPd3vr6jPH+Bwgq2lgmmxFHW7R9Kf1HREGS0OykwxlFAF9tCKOR8nIkSnUp6rh5jReGLF9LyU3NDqh8Po+3CzC4+pvUwEcUDqzavxRwalvl49kKiGvuAd0zey7hDG1EYDWyWepoOxCVxJDj5UXr0gvloIdx8C/hWjfgI48WNa3ux2pwoxc5YTW6mZpB5DQaXkY5gObxyScNEfLDrkRlDOEVlrOZ83uP5F7sfP38QbkIBhxpT2Y8SMA31+sUbEVyguMqbYFC8h6c5ienU7y5yCozN7Wewiz14Lqm2YZxjCoSkI8IaZ8cOE90uhX5oq/S9q18I9TLmpzLP7Lbm9N+HRV9j8xbiHIMSxg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e098a6e-90e8-4ecf-c93d-08dbe58a44b3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:23:42.7484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZaETX6IEuDKjyOkji9wY1mJehFCz0fSSuFheC8WL/XTMKwm1y0h/Zdg702jhxNZfQ5g7okWTmXWMgOoWiBOR5eNqU2CgNi2Lkmg8iovV6l8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found integer handling issues, bad shift. Coverity issue: 385412 Fixes: e6858e7e7cd3 ("net/nfp: move shared target logic to own file") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_target.c b/drivers/net/nfp/nfpcore/nfp_target.c index ecb45f7928..ea5b39a4b9 100644 --- a/drivers/net/nfp/nfpcore/nfp_target.c +++ b/drivers/net/nfp/nfpcore/nfp_target.c @@ -528,7 +528,7 @@ nfp_mask64(int msb, return 0; width = msb - lsb + 1; - if (width < 0) + if (width <= 0) return 0; if (width == 64) From patchwork Wed Nov 15 03:23:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 134371 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E067D43332; Wed, 15 Nov 2023 04:24:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C224A40A4B; Wed, 15 Nov 2023 04:23:48 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2101.outbound.protection.outlook.com [40.107.223.101]) by mails.dpdk.org (Postfix) with ESMTP id 71450406FF; Wed, 15 Nov 2023 04:23:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8Gn7zr5MqqMthrVls/ExAvFfxUGZSds1uLURuB1BOm6Asc53KdZdsXnY6n5biGM62/ZS5pfVf/Vu3W9OWO8mtXIr+PC9O1Hj6fg8A9fRXF0/m49dMP8Xln9c4BbIGofDH7drbHUqSt6Ru+OgSyg/t80pqM5vR07WiN5zgm0GqDd9l9qs62hQ1H7q/klW6LSYIyDicJSgOtYPvxH92WxnpepcA5sdd9nd0Vj3UIOskqZR4luCCJEhNzq78KKSo8/n+jdbYgEgdRZjFpMPE+IGH4aHuXXxdOiPRmJpavns2wzQXTBun0F2NxbpOt+238EbwTzpo5RLVWsCKBybJ6R1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qhl7R/kU3jJXBVPCCun4URCZAXmWN/FqSG5EvetkE+o=; b=L40NBccc3KbJpXCxSq/K4FQQiXorgq+mo4nRDBWQ6AIXrj0qzwfmbcrGrynXEFsAAPfuYg5z1nG4JUjr8KVOfaaP/Nc2tF6M+A634JOpxh7PcqZtPLaPM9ZvoHFSeUZhuuOnEMg0rwoU6VklejiDJvkpOT64bxKX0T7Cbt1qkD7daMvDOpEYRQn5LLmZPm+VYHD5aCoOxmYsbakKUXtcPkiG26TWLCJYRxm5tPdVjpt28f6TjAKTuHqu3P1rJLaIgw6way88dmOC8XTFrPigr6oQYRHrj56QHLPX7FY/XazsjnbadKELsGQhJ2Z28Dbc24mmYAFILZaOu1dq7aDhkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qhl7R/kU3jJXBVPCCun4URCZAXmWN/FqSG5EvetkE+o=; b=iFirj0EX3hEoKZArxmuVRlnXZ+7DhEbdj9KSkdSY7hDwt1ckeBNeraVJ8bWuut/GAaqD/Vuv8vtmZjq+qc27LMg5ZY16Aao95FXZyVA5aRnR8xvUliPpDSG7k7LE42dhF8RhtOA9EsqjDEXnnx6UAvz9ePa9vmyOr7IVKsrarbk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5719.namprd13.prod.outlook.com (2603:10b6:303:171::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 03:23:45 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 03:23:45 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH 5/5] net/nfp: fix null pointer dereferences Date: Wed, 15 Nov 2023 11:23:10 +0800 Message-Id: <20231115032310.756221-6-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR10CA0023.namprd10.prod.outlook.com (2603:10b6:510:23d::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: fc0f0b59-a1e8-459f-51d5-08dbe58a4682 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N816OUp7bDvGFnSrSNfzjxBcey3Bq7f8OI/YqANFC801tvmADTaje2TbbgKbf446m4AsTMPGCmT3y9oTLZ9+TBRNCdAdpHabii1m3kuqptSbnKVDB9cvzMxWRBLDyg4Pk6U90S48gx8IG6ZfykV5dzbieYDiykGXVNnolTfICjcW3fGaLbEmFSArlpxefSzM9hGCWYUiQcbUoN3SkrE2TyqUhBT3k768aKSaa5OdV7of8iDs3lz1p3oW/a7R9Lt6OgwuP3yGStvLMUHMidw4pm6GH2pQKXGtij4O+UHjWLFk3eYQ4M56okHnoY7uavf4mIGIZc28GWALkyX3lwv7uRxpeMqPS2Js01r+m7v/Op3is6kiWHWCmJUqNDWsBuZDiqIuGBQE0ynhCMVURhBmDHoTXepSvvYiThU93h8tAix0x5N1YXrzTdKG68sFZ0YZP3FRptT1dAaIKFPL/hlX7+Nv1P+AJwuCA1t65TIzIhP1mkqAZy7C6ebOrpmjRKQ2fKRxRxBviIJsuFayoscX6cg/hK6qnKnjM/IOa01TvuwkkQj83yxFB8seAxdCvQXeZs3fRnzYSkuBKaIrrAqLMj5JhFlPO3T+90bMv8SAcPa6q9KfvVTKkos5ePkeV6Kmbq/DDC+QKj7SnmLFrPnMCix67SgxnFQLRZzVfhYenkc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39830400003)(366004)(346002)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(6512007)(1076003)(107886003)(26005)(6486002)(478600001)(36756003)(44832011)(450100002)(8936002)(86362001)(4326008)(8676002)(5660300002)(41300700001)(4744005)(2906002)(66556008)(54906003)(66476007)(66946007)(6916009)(316002)(38350700005)(6506007)(52116002)(6666004)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: w3dRDlDcHzGm+74uCg36ah26yG5IsPcuJDRWalPYI4Eoy2onDL7OsskcTYw3e7Gy3GjFlvdL8WBvl767r102yspv5MGduwUyDv7qWMiwZisNCBAPyhJiehwr5n3kcSj3qVL1vq0MXaTAxmNKMex1O7YzQ5tVTx4Y8HSec3WtfY+2YiOkdHlGTTSruH9h9v1kIiFGVhQI8N2oiKfyezR95SbGWIhKoHgKdDkkUZ5xBgzeJF1So5x+PR8wAVs07a7cNxasA9edxY2rguk8FnRGxj9JDvdLr8rK9d0EhGf3a1fzHGsdinaxXWHcx9A30TB2tELCXqPqCstAehpw51FGFoEhQfAWKVuLP0WcIjIqqKSMUWae8w0zXPJbHbce9Wp1PUXjj71MAj9wqvCWQ6CQGHqRlpppBhtJP5fJ2/3oWWjg/DBwydcT2jAFXC8i6s1r5l6lYJ/eFDsbXuuUYPXc6RE3f09+KAKpjfGZnpjFtGMDAupzBK804uAMiblhUkIm5ksjUVanI+SjQzqkGRNTeJNXsX7VAymfJYFjr0scNkqknylGRLgMuSjWal/Rn30An/4jrZQFXZaDmFCvseH/6oD64XQgwV9wsP/Pi58Pry3+S4ooGdDPtgGA17StS0z7iz4ahhVzhMa7kmmNst+R8f1dy29fkXuo59ZUyX3B6ld7kYe3o3E0p/4dw/MekPOe4WPoL2OhdWQ84cpDQOZO8LI83qQv5rFj3JbxRzCrwJ0ucVX8rkG0ynMa03G8IBIAj8gwwJc7w77zGnb9hszkP+XBmB7hb/Ur/gng8LkMb39Pi+VnKPB4tWTwV/1l6cE71WE3Soyz/Oi9IaooDuNj8HDLYeHbNPhmN3IuyoeMWo3t6vOtASzhMd3NiKrujx05kQvjjTRcVB2y42DhzQewvyy1A67oanWWep+DdwqpOswTwuXzvtGRVMat2S4rY8xMjEOe1WK+hGycrlJS/xMAvjKQzLWkdlZk47sHuofmQKQm5UResC10ga+WICn75wtRD7JgpwQ3BMdWqzmgBRjvm0YZNcDjJNWIwChTakux/WuvC7sSwQUWMFCp8lKfa2VVSWlJ0A4LgF8690igy9PSw+EcbPXy5VOY7MA3Ha/nCqtLKNuJFDfaRG+BISXizv7gcRGHxID4hENCskydgclg3HXaqixt6PAx3liAIJy9B9hW+6r1ezdtbLN+VjTHiwAH0VSdh0hl9pu7y+YQd+GBmyO+Z7FvDhAzyDZ/AfY+8MsitVK4E2KkrwflkOC1EueAOqo+i9NZS0wDaepgLrQY3+3w3Llqqe4KY4EDQ5MLbQNnTjo5Q48MPa3/SPlAz9ThJZgpnW7KdL6NRnJL+oLeNhIPM+o61HSh4pkM4Y5j9uUXLAs/nk+xCS1XXgXePglmu1YzLzJBW9/cHkWhTwueXV93wTgpyj2WEvGfcTZGVo2ebcZfN50d0kmFtj0zPUbtYkvjkxlET+u8JirpHl3bwLx0rFdYcD9ikxCUkZJPVlFBVlsO9xIc3zn7YNxlGICLnhPNky2qdqoc2ygvpuNvn4s6Tmtn5A02fcloUnlueWyYxl7BiGyUYdZl1ByylmPiHvOpxDr+HuYoEtL4ju3f3w== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc0f0b59-a1e8-459f-51d5-08dbe58a4682 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 03:23:45.7680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZxfjuyxLTFG64/6FmuT10DhltXdEVU1Nec/dH0xDy/NDBoUlCYJsrMP4tFfE6U6r7baPEgQtmZArbvz3zqkkF2ZO0obB/muokAwtrZeeLc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found null pointer dereferences problem. Coverity issue: 385406 Fixes: d7f6d9b21ffa ("net/nfp: adjust coding style for NFDk") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/nfdk/nfp_nfdk_dp.c b/drivers/net/nfp/nfdk/nfp_nfdk_dp.c index 1f330b7bb6..0141fbcc8f 100644 --- a/drivers/net/nfp/nfdk/nfp_nfdk_dp.c +++ b/drivers/net/nfp/nfdk/nfp_nfdk_dp.c @@ -301,6 +301,9 @@ nfp_net_nfdk_xmit_pkts_common(void *tx_queue, uint64_t metadata = 0; pkt = *(tx_pkts + npkts); + if (pkt == NULL) + goto xmit_end; + nop_descs = nfp_net_nfdk_tx_maybe_close_block(txq, pkt); if (nop_descs < 0) goto xmit_end;