From patchwork Tue Oct 24 17:51:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133269 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 355504316B; Tue, 24 Oct 2023 19:52:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 954AE40E8A; Tue, 24 Oct 2023 19:52:21 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by mails.dpdk.org (Postfix) with ESMTP id 773B840E68 for ; Tue, 24 Oct 2023 19:52:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W15pOU17mR/s49Wj+QdDVa5EB5EqcX0LTu4tj8tzNPhTy1SDzwi4zJTeAFAiJB2LnixAY1LxM5s/pDAYVLtlBz/dgtePdMjJpujS5M8A3/l4qA5J8ekeIQrfol6hZiGnw4+TK81QrExrmBFa9kvW01T5UmK1XuEN0cKj2uC4Fbz8kZ6anhvNVmWehksCzjkNOO+FYN2pTwEF8IdXvpgsDrMS3C18R8G8C2t2OpErBqNUqiXYNTO0F7nQ3B+F3l+1t19WUnTxvDZVC6dvCMJRO8TiF0GdoPrBYFZXnpUSnh/5MQpzoPIo/jknbH/y9g6ibHiX8l65T9oqkMRosRIz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oY3wDpVC4OeSi242//C7ku/duAh8cWLqgIdzSJlkXXw=; b=KnlN7X35O5zJee+LgFv3UkoJO/NoIuSM9NWeqdGHCS3g8AGfUYAOgY0wKq+w6k/CND3tSnU5IV18yrnzUB+bZgq6k2XAG5epTn7UF3gtaQubVZ1yZJaNxs0NGDdRwS/MxezXLzkJVnxbvOUnOWJsLwMR63pC6nCVJVtSMCg5cCUnKYyQ8PQEFb7EojDAhwZKu2IrrzhGU9hKsMLTrSYH2Q7ky9OJAxnyGJy3pXzP0pWYiSMZiswiG9eGqXbV//U7fsblsEOanbDt8uN3CiZvT8kmnNDdzE6SJrkopiVTtdBEh6e0p9Wf4vpYxhpGiJve3vGgOVUb6pUM7g6y+eq8pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oY3wDpVC4OeSi242//C7ku/duAh8cWLqgIdzSJlkXXw=; b=N6NpAJwKnCIi0zmIhgmti4xhqfAEaqT7vuIqhLpD7sxpLPk4q3hlcav4Wn9Xjc0S5NlClXH7X0stEw1XkF15bxFtVHy60cBJbdxzuC6VadW+tsf44jxspoArRjRYMqe+1+cV80mnqiMT0XZtMCakaPBlC3meU3EUwNoRvpXZ80SgC89c+QXLBlHHkpFBcE3GvXVt98jdqf67a0+9e1sAhSxp7Sq8lx4yTlTp7+RXaAQrM8u1Wa0Bq74Lcut8LQL7hm+Z4J7Nb2gSOITMUSOfiX6vDDUTYJrT3sEHNpP9vh7bLR4S8xNiFEse9k3lPdGvpTLkX/YO5g9lWRy7is24hw== Received: from DM6PR07CA0092.namprd07.prod.outlook.com (2603:10b6:5:337::25) by PH8PR12MB7109.namprd12.prod.outlook.com (2603:10b6:510:22f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.24; Tue, 24 Oct 2023 17:52:18 +0000 Received: from DS1PEPF00017097.namprd05.prod.outlook.com (2603:10b6:5:337:cafe::a4) by DM6PR07CA0092.outlook.office365.com (2603:10b6:5:337::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Tue, 24 Oct 2023 17:52:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF00017097.mail.protection.outlook.com (10.167.18.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Tue, 24 Oct 2023 17:52:18 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:04 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:01 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 1/7] ethdev: fix ESP packet type description Date: Tue, 24 Oct 2023 20:51:26 +0300 Message-ID: <20231024175132.1435553-2-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017097:EE_|PH8PR12MB7109:EE_ X-MS-Office365-Filtering-Correlation-Id: c3e04e83-3b44-441f-3e0c-08dbd4b9f70c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JePgUrJ2SVI5gR81V+Exk+JriA8nQ9dAhxSsyiX5dj3tNhe1OrqDIuIdSPxji9taVSpXA5iVkgYH4U8wn2ndPB7BHWt6rblvVqvBp3xN15TsPZ2OxaqzxxquYO9W8hxbQa9Dehhx2JdaODahXiyPTOELH39enI2hgVk0bj9GpHFzCZVzDy+V/DSB8YgpiVnyM/sHOSEd8qIrNNYYgfVD7pNMrOJ+2xby8y2WoNRJ6PLYXzzPyiMlpkK1IPXUDpF0uEvosDL6oQFo2g2n8qWorg15mDHtNbbh9aB/H6/uKPFNRpulVUK+BG0FlJuUUzlkcq3quLrlSqaias4ZXAg/AN6RqNJPqiUAYrmaSd6XfOrMfkpA4bcHZsouavcDD6U+r9gyKMbtYnFcsziXh2e8AxT6Ac5LmYL6RCxEJRE4ZAvkU4jaFL8lZO+DmmrGHOKcywjSMjo2EfBPRA30Y9RslgtVY0O7ZxuZ4BSnBizwCL1V+siS/wjEF21VoH+3mwufZzQD195XtMhYSZwBXVgA3zJu0hEVYao/e5oD4gyoUp0/qMfYL/SqM0AbKFXnx5/+aQejxZeZmEsUkxIGayTWUqqRXMe+V8Zx6otN7nSW8YGpfR2HkbGupo7jpK1vze3MSm3GOTy0bGpXP+PBmBGfyLeDOxHvfXooTojZlKUbw/ltNsELViCRN7G5RbMNdGJVmJl8iluFITRV9qPv492adFNaf3wzF2icL6qrKKoRHZYW3nOrHsMsOYAyM63H/bV/ X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(186009)(64100799003)(1800799009)(82310400011)(451199024)(46966006)(40470700004)(36840700001)(4326008)(41300700001)(36860700001)(5660300002)(478600001)(8676002)(8936002)(47076005)(2906002)(40460700003)(6666004)(4744005)(70206006)(6916009)(82740400003)(70586007)(54906003)(26005)(336012)(426003)(40480700001)(356005)(86362001)(83380400001)(36756003)(7636003)(107886003)(1076003)(16526019)(2616005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:18.0463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c3e04e83-3b44-441f-3e0c-08dbd4b9f70c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017097.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7109 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The correct protocol number for ESP (IP Encapsulating Security Payload) packet type is 50. 51 is IPSec AH (Authentication Header). Fixes: 1e84afd3906b ("mbuf: add security crypto flags and fields") Signed-off-by: Alexander Kozyrev --- lib/mbuf/rte_mbuf_ptype.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mbuf/rte_mbuf_ptype.h b/lib/mbuf/rte_mbuf_ptype.h index 17a2dd3576..f2276e2909 100644 --- a/lib/mbuf/rte_mbuf_ptype.h +++ b/lib/mbuf/rte_mbuf_ptype.h @@ -419,10 +419,10 @@ extern "C" { * * Packet format: * <'ether type'=0x0800 - * | 'version'=4, 'protocol'=51> + * | 'version'=4, 'protocol'=50> * or, * <'ether type'=0x86DD - * | 'version'=6, 'next header'=51> + * | 'version'=6, 'next header'=50> */ #define RTE_PTYPE_TUNNEL_ESP 0x00009000 /** From patchwork Tue Oct 24 17:51:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133271 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D15074316B; Tue, 24 Oct 2023 19:52:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D639440EE4; Tue, 24 Oct 2023 19:52:26 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2043.outbound.protection.outlook.com [40.107.95.43]) by mails.dpdk.org (Postfix) with ESMTP id 4BC0640EE2 for ; Tue, 24 Oct 2023 19:52:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wkz4zcZuUn3WCITPBt9E++j967sEdxlUW8e2FjaJgOzWt0qDdzrI1VbA027YaXmXes1HN1ZjK8VzfxDaSsOEQirwoh9P+4GRWh0fWvCSnqZUhq47ija8oqVxHFkDDoyn66SwAyiWB8LTuprTfoxWBQlML3yhKQGp/zctvJ19OU0GcxcBqCnNa/GIXswUu9OFPAwDo+HU17EczC2neE7DFTc/FLgRh7ozNjeuau4mtioqZL+Uq7RU3J8tNETGQZSjsv6Q21wQM0eU13rOErlHHXmh/yvtSjpgxVH/xR2/nysv1OQZtB6h7Mq9U+AveTpHtgzaTxdkv3pIzhR9p76lvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MDSMEtx8cwTo/YaFlXvvAv2yBlSW3e8H6UC/YYKAILA=; b=F6RdywJ2z0OykehWCcuqvl983j7EF9k7O18wJI/YY1RT+ZqI08g/s9WrmcUSem+LY/DwvXwStBOM5RKqBNJJoA5o/VYOH17EQ4m6HkFh0JtJSnddmfQ0Ir8rV0DKMaO5JWOlFZZu72ZIWhRSbL+UQ2eFNvShT0Ju3EtcfbolD1EIJfRb66+srUaaihFtvjjdc6wl4PJTI9gITg/+kbLOAUFGzH/xRfJAMrqeAQgrp90ZBPQOd7peRDm2w6cd3gfBxIoGyb+OcN34es5op4Sy/9uhNUSR1uC9WotRSW280wRJhwuRcMk7E/xEEqn880Ra1NQjd95KHbRTea6Ytse7iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDSMEtx8cwTo/YaFlXvvAv2yBlSW3e8H6UC/YYKAILA=; b=OHYqPM3D6x6NC7uvLp2PmaeWgjjrKeDBl63S/nasha2dZiZWpffws1Tj3GZ//bjTDOxqoHNotHlre2a5o7zJs8wcMhQsdObS1jx4D/ipMIsDkmH+wc8cYW5wT21JUAJF2gwj0pVJceUojuzxch3QN29pWTH/q2bGKra3wrN2Hl1YdrQM9UMcGYix59nW7VY/4xq2kdJIrWVlxaPCs2Ijs+0fIUYYFeeTf960vtKY3rUGjKCgOvDv3sR3XGyKeVY3wiwSpe1TqZoZMuiMMgFPYmrpD2hsp4zYYSJ+1IYtqfiHq5ZfjiEcRYTEZivIohG1H1llp8IRgYUFQRvunf+BPg== Received: from DM6PR03CA0058.namprd03.prod.outlook.com (2603:10b6:5:100::35) by PH0PR12MB7959.namprd12.prod.outlook.com (2603:10b6:510:282::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Tue, 24 Oct 2023 17:52:21 +0000 Received: from DS3PEPF000099DA.namprd04.prod.outlook.com (2603:10b6:5:100:cafe::fe) by DM6PR03CA0058.outlook.office365.com (2603:10b6:5:100::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Tue, 24 Oct 2023 17:52:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099DA.mail.protection.outlook.com (10.167.17.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Tue, 24 Oct 2023 17:52:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:06 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:04 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 2/7] net/mlx5: add support for ptype match in hardware steering Date: Tue, 24 Oct 2023 20:51:27 +0300 Message-ID: <20231024175132.1435553-3-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DA:EE_|PH0PR12MB7959:EE_ X-MS-Office365-Filtering-Correlation-Id: 28601704-9696-497f-3b40-08dbd4b9f8ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WQflzg6cMYqgH2MMLaziL0MG9OFoNWclz8bGW7qEjtujN+s+brO5qJ2zjCqYwGwvClgyPoZRJ5qBp0szZ8jfmmzDpqE9oWWpVFqf1Cjdugnll8M2CAKeIf10N7xgvks7YoHi82vfC6HFIKd31iktrpQG8hkDtximdWLumVLOCpobHq6wzGML1NkIwhc14mlzfVz1he01WKRZkOkMTrQ2hivvJ4tnhObh8VBYl3gxhp/b8W6YdrxqLsoFcsbOx7TrEvwrYBdxRbl9ZzulsG7Tp1Xr/kBp3W5+uRWuG8ObR8xQQ8CDN1OLZ6MqWQJUTUynNUPcP1V+wZyF+0DrXr8WuHdk1fOy80oSy8hCkgjOZalVLvtJyh9tch7g5mnkDE7byCV2kRC1SH6EgFpk9ygu4EkQqyo4OKfEcWnYJ1NRn5TqxSYn/qqqChM44pvmHSLYWgeX5DQfevpRUb4deGXuF2FV5lTzOiZ6lKCKb7drwW6lZTPPWvI8EGQlNCkqY+OgbVyg/zq+B8ZUue2Ti8Cd+MHTRB+QGyfajDhYnGhF9zxlsUxAl33yCz/3FHkg4W3U5x5whOmaopyUh060Dl4UOBEC9oajm/1+gBZWM6pWPrC6cq9OTE4VRut/Rf6mY28w3JJmykEra6ntepuAvgsXHxlG0IXb3B5YX7CgMieqg8hLY/Ay22s0BTYxPtX/9PmZckclKRgoGriotn5jBip+LrTuJg90sFSKYNKTLnYeK3zDE8niTZYJf8hskItx2dI9 X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(376002)(346002)(136003)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(82310400011)(36840700001)(40470700004)(46966006)(40460700003)(41300700001)(2906002)(54906003)(6666004)(70206006)(82740400003)(316002)(70586007)(107886003)(6916009)(1076003)(7636003)(16526019)(40480700001)(336012)(47076005)(426003)(83380400001)(36860700001)(86362001)(5660300002)(4326008)(2616005)(478600001)(36756003)(8936002)(8676002)(356005)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:20.9535 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28601704-9696-497f-3b40-08dbd4b9f8ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7959 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The packet type matching provides quick way of finding out L2/L3/L4 protocols in a given packet. That helps with optimized flow rules matching, eliminating the need of stacking all the packet headers in the matching criteria. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_definer.c | 161 ++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_definer.h | 7 ++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c | 1 + 4 files changed, 172 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 95b5d4b70e..8d846984e7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -16,11 +16,15 @@ #define STE_NO_VLAN 0x0 #define STE_SVLAN 0x1 #define STE_CVLAN 0x2 +#define STE_NO_L3 0x0 #define STE_IPV4 0x1 #define STE_IPV6 0x2 +#define STE_NO_L4 0x0 #define STE_TCP 0x1 #define STE_UDP 0x2 #define STE_ICMP 0x3 +#define STE_NO_TUN 0x0 +#define STE_ESP 0x3 #define MLX5DR_DEFINER_QUOTA_BLOCK 0 #define MLX5DR_DEFINER_QUOTA_PASS 2 @@ -277,6 +281,82 @@ mlx5dr_definer_conntrack_tag(struct mlx5dr_definer_fc *fc, DR_SET(tag, reg_value, fc->byte_off, fc->bit_off, fc->bit_mask); } +static void +mlx5dr_definer_ptype_l2_set(struct mlx5dr_definer_fc *fc, + const void *item_spec, + uint8_t *tag) +{ + bool inner = (fc->fname == MLX5DR_DEFINER_FNAME_PTYPE_L2_I); + const struct rte_flow_item_ptype *v = item_spec; + uint32_t packet_type = v->packet_type & + (inner ? RTE_PTYPE_INNER_L2_MASK : RTE_PTYPE_L2_MASK); + uint8_t l2_type = STE_NO_VLAN; + + if (packet_type == (inner ? RTE_PTYPE_INNER_L2_ETHER : RTE_PTYPE_L2_ETHER)) + l2_type = STE_NO_VLAN; + else if (packet_type == (inner ? RTE_PTYPE_INNER_L2_ETHER_VLAN : RTE_PTYPE_L2_ETHER_VLAN)) + l2_type = STE_CVLAN; + else if (packet_type == (inner ? RTE_PTYPE_INNER_L2_ETHER_QINQ : RTE_PTYPE_L2_ETHER_QINQ)) + l2_type = STE_SVLAN; + + DR_SET(tag, l2_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_l3_set(struct mlx5dr_definer_fc *fc, + const void *item_spec, + uint8_t *tag) +{ + bool inner = (fc->fname == MLX5DR_DEFINER_FNAME_PTYPE_L3_I); + const struct rte_flow_item_ptype *v = item_spec; + uint32_t packet_type = v->packet_type & + (inner ? RTE_PTYPE_INNER_L3_MASK : RTE_PTYPE_L3_MASK); + uint8_t l3_type = STE_NO_L3; + + if (packet_type == (inner ? RTE_PTYPE_INNER_L3_IPV4 : RTE_PTYPE_L3_IPV4)) + l3_type = STE_IPV4; + else if (packet_type == (inner ? RTE_PTYPE_INNER_L3_IPV6 : RTE_PTYPE_L3_IPV6)) + l3_type = STE_IPV6; + + DR_SET(tag, l3_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_l4_set(struct mlx5dr_definer_fc *fc, + const void *item_spec, + uint8_t *tag) +{ + bool inner = (fc->fname == MLX5DR_DEFINER_FNAME_PTYPE_L4_I); + const struct rte_flow_item_ptype *v = item_spec; + uint32_t packet_type = v->packet_type & + (inner ? RTE_PTYPE_INNER_L4_MASK : RTE_PTYPE_L4_MASK); + uint8_t l4_type = STE_NO_L4; + + if (packet_type == (inner ? RTE_PTYPE_INNER_L4_TCP : RTE_PTYPE_L4_TCP)) + l4_type = STE_TCP; + else if (packet_type == (inner ? RTE_PTYPE_INNER_L4_UDP : RTE_PTYPE_L4_UDP)) + l4_type = STE_UDP; + else if (packet_type == (inner ? RTE_PTYPE_INNER_L4_ICMP : RTE_PTYPE_L4_ICMP)) + l4_type = STE_ICMP; + + DR_SET(tag, l4_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_tunnel_set(struct mlx5dr_definer_fc *fc, + const void *item_spec, + uint8_t *tag) +{ + const struct rte_flow_item_ptype *v = item_spec; + uint32_t packet_type = v->packet_type & RTE_PTYPE_TUNNEL_MASK; + uint8_t tun_type = STE_NO_TUN; + + if (packet_type == RTE_PTYPE_TUNNEL_ESP) + tun_type = STE_ESP; + + DR_SET(tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + static void mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, const void *item_spec, @@ -1709,6 +1789,83 @@ mlx5dr_definer_conv_item_gre_key(struct mlx5dr_definer_conv_data *cd, return 0; } +static int +mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd, + struct rte_flow_item *item, + int item_idx) +{ + const struct rte_flow_item_ptype *m = item->mask; + struct mlx5dr_definer_fc *fc; + + if (!m) + return 0; + + if (!(m->packet_type & + (RTE_PTYPE_L2_MASK | RTE_PTYPE_L3_MASK | RTE_PTYPE_L4_MASK | RTE_PTYPE_TUNNEL_MASK | + RTE_PTYPE_INNER_L2_MASK | RTE_PTYPE_INNER_L3_MASK | RTE_PTYPE_INNER_L4_MASK))) { + rte_errno = ENOTSUP; + return rte_errno; + } + + if (m->packet_type & RTE_PTYPE_L2_MASK) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L2, false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l2_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, first_vlan_qualifier, false); + } + + if (m->packet_type & RTE_PTYPE_INNER_L2_MASK) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L2, true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l2_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, first_vlan_qualifier, true); + } + + if (m->packet_type & RTE_PTYPE_L3_MASK) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L3, false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l3_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l3_type, false); + } + + if (m->packet_type & RTE_PTYPE_INNER_L3_MASK) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L3, true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l3_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l3_type, true); + } + + if (m->packet_type & RTE_PTYPE_L4_MASK) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l4_type, false); + } + + if (m->packet_type & RTE_PTYPE_INNER_L4_MASK) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l4_type, true); + } + + if (m->packet_type & RTE_PTYPE_TUNNEL_MASK) { + fc = &cd->fc[MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_tunnel_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l4_type_bwc, false); + } + + return 0; +} + static int mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, struct rte_flow_item *item, @@ -2332,6 +2489,10 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, ret = mlx5dr_definer_conv_item_ib_l4(&cd, items, i); item_flags |= MLX5_FLOW_ITEM_IB_BTH; break; + case RTE_FLOW_ITEM_TYPE_PTYPE: + ret = mlx5dr_definer_conv_item_ptype(&cd, items, i); + item_flags |= MLX5_FLOW_ITEM_PTYPE; + break; default: DR_LOG(ERR, "Unsupported item type %d", items->type); rte_errno = ENOTSUP; diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.h b/drivers/net/mlx5/hws/mlx5dr_definer.h index f5a541bc17..ea07f55d52 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.h +++ b/drivers/net/mlx5/hws/mlx5dr_definer.h @@ -141,6 +141,13 @@ enum mlx5dr_definer_fname { MLX5DR_DEFINER_FNAME_IB_L4_OPCODE, MLX5DR_DEFINER_FNAME_IB_L4_QPN, MLX5DR_DEFINER_FNAME_IB_L4_A, + MLX5DR_DEFINER_FNAME_PTYPE_L2_O, + MLX5DR_DEFINER_FNAME_PTYPE_L2_I, + MLX5DR_DEFINER_FNAME_PTYPE_L3_O, + MLX5DR_DEFINER_FNAME_PTYPE_L3_I, + MLX5DR_DEFINER_FNAME_PTYPE_L4_O, + MLX5DR_DEFINER_FNAME_PTYPE_L4_I, + MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL, MLX5DR_DEFINER_FNAME_MAX, }; diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index 903ff66d72..98b267245c 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -233,6 +233,9 @@ enum mlx5_feature_name { /* IB BTH ITEM. */ #define MLX5_FLOW_ITEM_IB_BTH (1ull << 51) +/* PTYPE ITEM */ +#define MLX5_FLOW_ITEM_PTYPE (1ull << 52) + /* NSH ITEM */ #define MLX5_FLOW_ITEM_NSH (1ull << 53) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 6fcf654e4a..34b3c9e6ad 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -5382,6 +5382,7 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev, case RTE_FLOW_ITEM_TYPE_ESP: case RTE_FLOW_ITEM_TYPE_FLEX: case RTE_FLOW_ITEM_TYPE_IB_BTH: + case RTE_FLOW_ITEM_TYPE_PTYPE: break; case RTE_FLOW_ITEM_TYPE_INTEGRITY: /* From patchwork Tue Oct 24 17:51:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133270 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54BA94316B; Tue, 24 Oct 2023 19:52:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A350940ED3; Tue, 24 Oct 2023 19:52:23 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2041.outbound.protection.outlook.com [40.107.92.41]) by mails.dpdk.org (Postfix) with ESMTP id 9FD1440ED3 for ; Tue, 24 Oct 2023 19:52:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkSh0uSant1K1TZ8L1s2dt47oNsQA8auvJqqO5DlPtBgrJ09ajeyifYVetSVjJoPxuQ30V2W01uc8fm7pRSrCzkQYQKY9RsNwpmzCgrXOiiQnheAvKJB2WCOrw9hdYsNLOBSrdA6c/vqs3GOUL2J5EUB/RQJ/6XLCTcmIZaoTfgyFSe6sPCdV9aCYbNRbXdrYNepwCRIQ6uiUeGzXvVVwahiOP2+HCvFLhvZK2pwI/MiamugKDqkHNMSgX7Y7ldFhezhqFfOmVSi4wn0PrPNGlBvhKQmWuZ0xJBCnC3RPSJmZ8dUxovmyWoyGaII+yTqx9ZLCX7z6DA8xWc/3dvw0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jmIl1o0cdVmiLP0K82vCc2JgG86RVuNsHuig2NIiKFA=; b=nD/r6YeMsIk+iDvrTlEvB6LNDF+pzRNG85OewVmhfFgx+c5rA7e9BwPM8G4ccWkbpbJU1coNTVGojFgNrmdQBp2UoUaelGZYHebUX04PBEIpZLLzLtkQ/W/VnaD8MSgZBnFBZxGtxp6LedJj42VoT04fmGSycRTVPNNxTdf5+ZJI87LcCBuryzo3g1cCtJuWpzXAloqC/7xH4Dd505Q9H9iOQuXU0azwFq7J/lmZjEQhCndbQmwZhalTNmPEtwcyi8mz3BUprWbxs5aj3Y2yBOhMUt4jVPYc3LejtBRzH0/TAp4HxlGHmcc3HhHKoV2xokhKiUxKxlzKA1E0RDWw2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jmIl1o0cdVmiLP0K82vCc2JgG86RVuNsHuig2NIiKFA=; b=EhKgRu73EZeFTkcnLegU1H39qpFgnsA7e+w6XlKRyQSht7x4Jrf4UBsAI2/xr7R4BKbLMhp8OgK3/ZXPhNe7UJRQ0b8IextWH0uWpC4MzOAJWFSwBwh+O6rIOFPBdIu5IqZ+FJWTfPQ6gZyHVjY4JglL3RxD3QbxYUZIsFU1cgFvXMAHC6374QVjI59kxpnw7qHNThIn2SqKBYDyFNloWtji/mvpn/MfKguGFAjlDgowioxLdZSqdpOYVPp1l50/xOTCd+AgM4MQRMefHPDJFeCEu0g1OKOclB39rWJ4oeBye+xQc6BxnYOkid3ki5Zaoxh93M1rHBwhw7xI05HDEg== Received: from DS7PR03CA0313.namprd03.prod.outlook.com (2603:10b6:8:2b::18) by PH8PR12MB6964.namprd12.prod.outlook.com (2603:10b6:510:1bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 17:52:20 +0000 Received: from DS1PEPF00017098.namprd05.prod.outlook.com (2603:10b6:8:2b:cafe::4d) by DS7PR03CA0313.outlook.office365.com (2603:10b6:8:2b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19 via Frontend Transport; Tue, 24 Oct 2023 17:52:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF00017098.mail.protection.outlook.com (10.167.18.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Tue, 24 Oct 2023 17:52:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:08 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:06 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 3/7] net/mlx5/hws: add support for fragmented ptype match Date: Tue, 24 Oct 2023 20:51:28 +0300 Message-ID: <20231024175132.1435553-4-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017098:EE_|PH8PR12MB6964:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b11230a-b89c-4466-21bb-08dbd4b9f890 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5aVW8+8JB6bajsdmOAPfquNu+jmRD4+4kgw4c86v43HbB17sMem/ONyjRrnF1i9VIQeXR0cJOuTHuPKsAzkjCfP5CwJOGLV29NwWW2QqPinyUPnd3By/NscXnU0Mr/orkeBtWKO8W/tjl1q7n9S6sK1FCvgXF+2p2eja2ZaEZv3H7+IjpKU/7N74KJGRFuLIX8tHWGOU9XI4YEiqDpZGT6lrT9PiHu7uok9jlXycPqIkGOtkWyO/Svyvxi5be1MYuNPKuwrf9LAuoNeZo3HS7bUm8D6wYf0wKRFUsfHKli12LAuUOaQy5kpqUB8b1XmtzNm1d8PSQmaKYSvgfod0RWwNJygH9E0gC08Nhie0QBfDlwMObJlOTmoPotkxRRRZbrGEdYpomee+Wjlyd9OVdh6yWLH8XibKP0DLRE2jS3zEatwpUZEixpSIZZZaHoKpYOnXKtvIj3zcXeWCbLhU9XpRVdhLfsz0uxY3kkxD2wn018I6ZtHgLO97QaL9QO7Kl9WTofJDYhOjssUCdYEp3ROK4k7p2gIdfX0pOGdHJZHYEzUM4mtu8v+rrR3v01gcv95qNl4xR3H/+rgr89f+sEPkjMGlFVjh73l3yKbuQ65Qn4QFqnVdkheDf6XV8OKl26xUJLs1VinBwrIZRXixRUeZ2KnA/EJFgziOAYhafnqq/oP+pSW9Ne+rhaOVWTXDShiylXo3hwK+gG4kwcI9yuch4wD64nBvmPD8F2Fei8Ymc9tHDQkeKL885ojOUhJDITkjHgzFCze2IKr+O/86Nw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(346002)(376002)(39860400002)(230922051799003)(82310400011)(451199024)(1800799009)(186009)(64100799003)(36840700001)(40470700004)(46966006)(40460700003)(2906002)(316002)(6916009)(86362001)(36860700001)(2616005)(70586007)(7636003)(356005)(6666004)(70206006)(83380400001)(82740400003)(478600001)(426003)(40480700001)(4326008)(336012)(16526019)(1076003)(26005)(5660300002)(107886003)(47076005)(66574015)(36756003)(41300700001)(8676002)(8936002)(54906003)(309714004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:20.5728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b11230a-b89c-4466-21bb-08dbd4b9f890 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017098.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6964 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Expand packet type matching with support of the Fragmented IP (Internet Protocol) packet type. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_definer.c | 54 ++++++++++++++++++++++----- drivers/net/mlx5/hws/mlx5dr_definer.h | 2 + 2 files changed, 46 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 8d846984e7..0e1035c6bd 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -357,6 +357,19 @@ mlx5dr_definer_ptype_tunnel_set(struct mlx5dr_definer_fc *fc, DR_SET(tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask); } +static void +mlx5dr_definer_ptype_frag_set(struct mlx5dr_definer_fc *fc, + const void *item_spec, + uint8_t *tag) +{ + bool inner = (fc->fname == MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I); + const struct rte_flow_item_ptype *v = item_spec; + uint32_t packet_type = v->packet_type & + (inner ? RTE_PTYPE_INNER_L4_FRAG : RTE_PTYPE_L4_FRAG); + + DR_SET(tag, !!packet_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + static void mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, const void *item_spec, @@ -1840,19 +1853,40 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd, } if (m->packet_type & RTE_PTYPE_L4_MASK) { - fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, false)]; - fc->item_idx = item_idx; - fc->tag_set = &mlx5dr_definer_ptype_l4_set; - fc->tag_mask_set = &mlx5dr_definer_ones_set; - DR_CALC_SET(fc, eth_l2, l4_type, false); + /* + * Fragmented IP (Internet Protocol) packet type. + * Cannot be combined with Layer 4 Types (TCP/UDP). + * The exact value must be specified in the mask. + */ + if (m->packet_type == RTE_PTYPE_L4_FRAG) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_FRAG, false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_frag_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, ip_fragmented, false); + } else { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l4_type, false); + } } if (m->packet_type & RTE_PTYPE_INNER_L4_MASK) { - fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, true)]; - fc->item_idx = item_idx; - fc->tag_set = &mlx5dr_definer_ptype_l4_set; - fc->tag_mask_set = &mlx5dr_definer_ones_set; - DR_CALC_SET(fc, eth_l2, l4_type, true); + if (m->packet_type == RTE_PTYPE_INNER_L4_FRAG) { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_FRAG, true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_frag_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, ip_fragmented, true); + } else { + fc = &cd->fc[DR_CALC_FNAME(PTYPE_L4, true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; + DR_CALC_SET(fc, eth_l2, l4_type, true); + } } if (m->packet_type & RTE_PTYPE_TUNNEL_MASK) { diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.h b/drivers/net/mlx5/hws/mlx5dr_definer.h index ea07f55d52..791154a7dc 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.h +++ b/drivers/net/mlx5/hws/mlx5dr_definer.h @@ -148,6 +148,8 @@ enum mlx5dr_definer_fname { MLX5DR_DEFINER_FNAME_PTYPE_L4_O, MLX5DR_DEFINER_FNAME_PTYPE_L4_I, MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL, + MLX5DR_DEFINER_FNAME_PTYPE_FRAG_O, + MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I, MLX5DR_DEFINER_FNAME_MAX, }; From patchwork Tue Oct 24 17:51:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133274 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FF484316B; Tue, 24 Oct 2023 19:53:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AB8B427DF; Tue, 24 Oct 2023 19:52:33 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2049.outbound.protection.outlook.com [40.107.95.49]) by mails.dpdk.org (Postfix) with ESMTP id 2000C427DE for ; Tue, 24 Oct 2023 19:52:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1WVfk7TxIm4j6JqYnKYWM0I6eEF5Jsj618NIU/iTdTWN/zDl1ynXw5l5TVsqkCPWDitbuzFqO2DGlH7caUtY6/dDFGROJUdrqzVrC++GcZ5SruHT+qBWR3R58En4/f6D4NLxOywGujYWvOEO8m+Ct6CK3ddMyOBuisoznX/Zd1ZILhUvCm0PF0Q3k/SMIdOhMTui70Ysp7FftkPyVS9r4KiasWDh8MSEHMk2Gwm2Ek/QF7+gYUONXLmkDWBAfPp+ql8iJFv2Luk4kf2dfiC8X7TOa3mzGn6cOtexv+d2sPMeE7/tEv6gB73L6ZvlAq3mdpD+5tswjGIu46khRGzkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8TS19FG+xNIdh17zLJhKW53LhjpJY3+bvkrsFiZL3M=; b=AukqgD/ORKLFOpnhKoww2N6fFBwpbdQmaXArHw+fsdcNE6i3Kn2yXuOJOE5UkfouCdl7PZBY3YyG1UxpKiFEv7z0nNuq5vaQT4REJDbZHVKDFPK2M3j9Awu5heJfdjY99IiUXP5Xt+GEd2aiCJ56aIFmBLGRV/WvPnuDmUZ0YGZeCdviGbVpxmxlCN3Ee7AruZjK/5N1R+4aH2BJ3iQ/PytlFmNQY0TwejNRzLvVaLgI3D4kNdcPVNGKbo/Zg/Me0d3/yX4jJq8NijH4eBZKs2NFi1UWUP0bRCUFThuY6eMK2n/jQYvSbimRXcX9t93IEw/kYyVHoSPCNmh0LPDAqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8TS19FG+xNIdh17zLJhKW53LhjpJY3+bvkrsFiZL3M=; b=Cx/4jey/xNuYBX10FP1r3YZdKbW8Ls7/qXUnHlD+47xrwochiVz4x+GKmgEun7dtfKnkIF36A1jB8rRJxJZ9vTBEXAi988qqdXiq+M5SrripI1gXxsUVL9j9NtfCyXoI4t3pijSus8+74MoB0H6y7NJHt0OXVBZI81KoUyY2T018C5csAqW5aN/WrwCFuyZt0qF6uXcDhJ4tb5bXf7fp7J9Sbj/Cjl0F9f1sMKkakxjus752FeuqlKBW9PJUQgHRnNwtIHFOFQ3zXhP4q8s/SLLbdo7Tvr5Rsiw61WvawbtjgwwJyJDb2DNE89B948fhGCSaITKhwU7NvRshux79hg== Received: from DM6PR03CA0054.namprd03.prod.outlook.com (2603:10b6:5:100::31) by DS0PR12MB8246.namprd12.prod.outlook.com (2603:10b6:8:de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 17:52:31 +0000 Received: from DS3PEPF000099DA.namprd04.prod.outlook.com (2603:10b6:5:100:cafe::2) by DM6PR03CA0054.outlook.office365.com (2603:10b6:5:100::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.35 via Frontend Transport; Tue, 24 Oct 2023 17:52:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099DA.mail.protection.outlook.com (10.167.17.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Tue, 24 Oct 2023 17:52:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:11 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:09 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 4/7] doc: add PMD ptype item limitations Date: Tue, 24 Oct 2023 20:51:29 +0300 Message-ID: <20231024175132.1435553-5-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DA:EE_|DS0PR12MB8246:EE_ X-MS-Office365-Filtering-Correlation-Id: 44b19673-3219-4bf3-eab9-08dbd4b9fe0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XuzyATz0X7lWJtYU3xYHKkIlpT8G93JzkGVlhGPjGEK62CvIyuETdjVswaFFFLX+6t5aKuKu4L46X8lAFIZ7f+R/YX49QNVkdG15d7y1dbcier11wG2msywYnqNiAz3YmGN9kELQwZUKEDGqkLvTpWTAMb/moPNwBvWoWXdHdzFO6sABrpHyKLKZ+FR3ICylWHATyMHyUQpR/IdctaFCvVXUqry9aVpE271FlC6X2tbil4aMx9TomtC6XyLIezYWXLVkZxW1wDS4bxBO89C+ECnnD6W8bVuzT0Gsz4k/CidV8VzbXajDBsI1e2ZkBJDzhDU9Cbv/PV7LMWgsqVW1LsX7qxJbkMnOMlud0n6KAQJxKF99XEArz0+qt7+WYoPd5WiGRuVwjWbvc1Rkkye/GI2rv+ayi9TM6bGel8sktCs/R64Gg+9a13SEVvxJ7NeUa6qbKxj619egnYTTT18DKIFu5TcelVOCwp9RSatPXe8uV35uC7pv9zJ29fJ+gTIdCs88aLCxYQ6AQ/yGsRCqxZOukStVkdVqtk6wXI+mNYizfvTyFLCJGSgDLa5404MYGCA4BYA2tXpNOX5lsPazN2/Vy5NX5HymUBaeka2pDQuOcbN0GS2HgzNfwezJ0SCW7+DMZHF82N1X/DDJo/Y5vuOnuHBxm5qXZMBDY/iK5rn1n8q7buHzBO2W7pJRbR2Qwz42IXFAAcDrpoxlvi48fATbk+f7btXN8KPh5YJUpIHnmCyAZJGmfgXmfwOICuGL X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(376002)(39860400002)(136003)(230922051799003)(451199024)(186009)(82310400011)(1800799009)(64100799003)(40470700004)(46966006)(36840700001)(26005)(40480700001)(36756003)(40460700003)(7636003)(6916009)(54906003)(70586007)(86362001)(316002)(356005)(82740400003)(36860700001)(83380400001)(2616005)(426003)(16526019)(1076003)(107886003)(336012)(6666004)(478600001)(70206006)(47076005)(41300700001)(5660300002)(4326008)(8676002)(8936002)(2906002)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:28.9380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44b19673-3219-4bf3-eab9-08dbd4b9fe0a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8246 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Michael Baum Add limitations for ptype item support in "mlx5.rst" file. Signed-off-by: Michael Baum --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 +++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini index fc67415c6c..e3927ab4df 100644 --- a/doc/guides/nics/features/mlx5.ini +++ b/doc/guides/nics/features/mlx5.ini @@ -86,6 +86,7 @@ nsh = Y nvgre = Y port_id = Y port_representor = Y +ptype = Y quota = Y tag = Y tcp = Y diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 7086f3d1d4..c9e74948cc 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -646,6 +646,21 @@ Limitations - When using HWS flow engine (``dv_flow_en`` = 2), only meter mark action is supported. +- Ptype: + + - Only supports HW steering (``dv_flow_en=2``). + - The supported values are: + L2: ``RTE_PTYPE_L2_ETHER``, ``RTE_PTYPE_L2_ETHER_VLAN``, ``RTE_PTYPE_L2_ETHER_QINQ`` + L3: ``RTE_PTYPE_L3_IPV4``, ``RTE_PTYPE_L3_IPV6`` + L4: ``RTE_PTYPE_L4_TCP``, ``RTE_PTYPE_L4_UDP``, ``RTE_PTYPE_L4_ICMP`` + and their ``RTE_PTYPE_INNER_XXX`` counterparts as well as ``RTE_PTYPE_TUNNEL_ESP``. + Any other values are not supported. Using them as a value will cause unexpected behavior. + - Matching on both outer and inner IP fragmented is supported using ``RTE_PTYPE_L4_FRAG`` and + ``RTE_PTYPE_INNER_L4_FRAG`` values. They are not part of L4 types, so they should be provided + explicitly as a mask value during pattern template creation. Providing ``RTE_PTYPE_L4_MASK`` + during pattern template creation and ``RTE_PTYPE_L4_FRAG`` during flow rule creation + will cause unexpected behavior. + - Integrity: - Integrity offload is enabled starting from **ConnectX-6 Dx**. From patchwork Tue Oct 24 17:51:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133272 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43CF94316B; Tue, 24 Oct 2023 19:52:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 605934111C; Tue, 24 Oct 2023 19:52:30 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2044.outbound.protection.outlook.com [40.107.102.44]) by mails.dpdk.org (Postfix) with ESMTP id 8FFC6410D5 for ; Tue, 24 Oct 2023 19:52:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGfUvPq+MLFFmyaoDfAXG5Xg76WYe/PxFM1pfIYgYFWm73W/4uwB4A53qrZmYWj0s+s2hIQdVgchA60cxG61ZYkMJjo4IJZNHCtMDTuiZXhtMdmZHqQzwRmF2LriWbbzxUCdfF+aH48Nb04N1HOr6EwBCUxCd1ws4/Xg/O/Huqjl42lkCOY1D369GOwtOKctmX7JBElJJvXBWRlwalE2VSL6MDp6PAmdBUmXjidqNGNRqaMTfNvFbBIV3HGkzZkAocz3JRcEs0ZeX2k665WsituToU4sqHGNTQRSDBZOGL72ceXXZtTzxLYOk25OrS6oBydYq7//2vZm87M1eUxaTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLaZDmkCVlB4l8Szhe7vxSNLlo64LHaklsIW/NJMoiY=; b=XqwA8hhi7AG3S3EMV4yqTivnYX7HYVAWkY72cGGZ9Rl3rQE2iEHXHSE6NZ4odUjw2J9CXsFJ2KZO2zFXpHNDQV2otEBajNNCef8Hu0hoA19t/2GziyO0SEkRLjNNMQbdF1wEj5Trw/KP2hPklRsV9GWFxlANV/VuQknUgj8UVu8b9zrXQUUnk3e6St4J+1LX7g3xWSyzGZqHUac6qIYWtcpccs8efImcqv39vwWHU+0+SPINHe9AxjmALdZQaEbfQ8uX87lTlpone5FY8bhD7ss187yVJsPrAq4X2eX5xcGdI3BCGBGCUlScGe35DNusdeaHTyLyhygFG8QkiXkarg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eLaZDmkCVlB4l8Szhe7vxSNLlo64LHaklsIW/NJMoiY=; b=c2T2Q/v5gsINx795D2mJaertzRb+NenDP0ELiS4Lcl4yYicKjmKPXHVy8WwirKH0lwFzjjbWc2QQgvWOo1yowahV4pHhuiiXiAZEQ8Z0mMOjl2IWDp6nfu6Yl/B0HIpW3123V4sQPnzSfgDQMj3y8+uyVIpFnnSoj9l8tPMS99zf+9l8kvzPmBtR/SWtXzvXFaQKGux1LjXhpswFJrX4bo3wnePuoM0o9XtdXuUiRRtGJO3pGHYCFSaAww+0VPLe4WqxGTAxgTgRd7S3Z0OM5nnH/uMaJOjgf0H+lTpp1gh4YFOga5uny2MF3iHsxKDe1AA2sz7yW0TvD9nuJmriEw== Received: from DS7PR03CA0175.namprd03.prod.outlook.com (2603:10b6:5:3b2::30) by PH7PR12MB5711.namprd12.prod.outlook.com (2603:10b6:510:1e2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 17:52:26 +0000 Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:5:3b2:cafe::88) by DS7PR03CA0175.outlook.office365.com (2603:10b6:5:3b2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.35 via Frontend Transport; Tue, 24 Oct 2023 17:52:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Tue, 24 Oct 2023 17:52:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:13 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:11 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 5/7] doc: add packet type matching item to release notes Date: Tue, 24 Oct 2023 20:51:30 +0300 Message-ID: <20231024175132.1435553-6-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|PH7PR12MB5711:EE_ X-MS-Office365-Filtering-Correlation-Id: 553e9ebd-6c9c-4650-f88d-08dbd4b9fbab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1VG6zISI3VPFOL1UuCBIsF7/s+KFih5rrqhgMMJmVFq4pUCNwWlivHu/KZXGa8W+nnPNMSM4Vb6OUw3Iz0Wq1comGOfUaDKaaIBNaujqm6H8+pNd9btgA/2VY4f6xclYVuYYzcUw8XAkg35Im6KkbmEW1Xpj4jCAeJzStoMnkT6GLA35pGwH4kkSAgqXgp3I3ufPtHuNXYJ2jtnHB6GO5iUU15JPf5rrPaCul3OSV5ophMjJSJCBHN6Nau9aN8uB1zTe2aCx/MVL1PqxuOCh91BtGOEQzhu9GSwzw/dbTS5G9vxfsUFzwDo/JXi5oA/J1YRy77AYqICAKmfLe4mEbMjYmU+r3Y/LuANqWogW+ZFPt2S7Z8GQofLrFhkJzMNeUmlKhV12lPuY5THzt0xyuAmQbPuYx8GOy80TwfkWIoFuU7xOd8pEteIy1kT3UtTxIFZss1011Lpgo9ejYYAYQxFbnk7pvfYHQx8SJRBr0flJr5zgKp4cf5Lc6AY/CSA1ZS6OexSssffGIp52xxQSzheYShBvB4zJnPkFS4Owt0/ePJL33k7v8ucIueynNlfkBsRZvM0mEJuEi+rUQaN4KX3C7GEywaJ6fZxxmWTYtLosWf9UQtwAmQFOla/M5Hfolr00EARIdFLR+OreU7C31GLS6c58SrWj4KTQbvqqHn7HHaautTLPgNBeWI6UGrzRCM2YkGnms/CW9NfCmEPP+nUKEESgEFoso59GX1gksu4= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(39860400002)(346002)(396003)(136003)(230922051799003)(64100799003)(82310400011)(451199024)(1800799009)(186009)(40470700004)(36840700001)(46966006)(47076005)(1076003)(107886003)(26005)(7636003)(16526019)(478600001)(336012)(54906003)(6916009)(316002)(70206006)(83380400001)(356005)(426003)(82740400003)(36860700001)(70586007)(6666004)(2616005)(4326008)(8676002)(8936002)(5660300002)(2906002)(41300700001)(40480700001)(40460700003)(4744005)(86362001)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:25.7884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 553e9ebd-6c9c-4650-f88d-08dbd4b9fbab X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5711 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Document new RTE_FLOW_ITEM_TYPE_PTYPE in the release notes. Signed-off-by: Alexander Kozyrev --- doc/guides/rel_notes/release_23_11.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index 0a6fc76a9d..548e38cde4 100644 --- a/doc/guides/rel_notes/release_23_11.rst +++ b/doc/guides/rel_notes/release_23_11.rst @@ -122,6 +122,10 @@ New Features a group's miss actions, which are the actions to be performed on packets that didn't match any of the flow rules in the group. +* **Added ptype matching criteria.** + Added ``RTE_FLOW_ITEM_TYPE_PTYPE`` to allow matching on L2/L3/L4 + and tunnel information as defined in mbuf packet type. + * **Updated Intel cpfl driver.** * Added support for port representor. From patchwork Tue Oct 24 17:51:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133273 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 376F74316B; Tue, 24 Oct 2023 19:52:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6659B41611; Tue, 24 Oct 2023 19:52:32 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by mails.dpdk.org (Postfix) with ESMTP id 0695041149 for ; Tue, 24 Oct 2023 19:52:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oP3CBJcGumdpIVRzsQ058neF+stuvxxHgyL/xqtPXkYK01Zb/ybwmLkjyPnxTivfTAKCBAfVhhdVNkoKZJhYKk1GR8JahnPUZirRgIwlz6Y00uUdRtnSjMU31ygQl3jQXVzbK6z16qdlRw/d2TaI2WeJH8DIss3qBoHBSozma2LkELAoQOe0Z4sAi1DK6cX0r7mdV6jKKnJ+e1/lPQ0ez+b1y7R11zGOo7PmJZN+kuL8Bob6WWruwwy9Qhn8jfQH9UfN3M8A6HPCL93B0ICTfVAJxrZKoNSj0/GMqOxpcJkmAi5s2DHuokcy2IV4DhdFsIGZboTIueatcKtoLZhJKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oWeZwn5xG7H5zSU/ocy7CMHvsOSmmGtJ+ZRFpze9oXk=; b=ISfUsd60DOrMapn7n/CJqYzxf/isNJ7kAUCmOi1erG401UwYToHewwaxR0591cU8yBpSk71jvRLxCw2d9rUQufFYnHRNGxuY9MGI225XIPczSsyaFlZVbWrN/fhZd/f6JGjCSgO1Z7jtYaeakZpBkGm3jl1XJ93wY4RzTsfyaG169l6erJpsdmKyyuNLkH67eMMk9SQOnwJmDkaR3TT5VMDGyZfmEbx0pJ/Ju6mX14quibDEg0qrMghkWywE+nFWhGB8FN3vwRWQ4Lry4/hykh9oCCWLQu76PBQdQDV1pdORGCmxb/v0f5ppJLQhFHwt+P9bNVhxq9oTSFEk7Ax79w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oWeZwn5xG7H5zSU/ocy7CMHvsOSmmGtJ+ZRFpze9oXk=; b=i5bbWTV2S56On9+8E+LR/woed0eMTcUDQW3VMSjvTbD5ijeTO/RJc8WWHipeJxGH96f6HJR0rgN9uXDTnreB8LIGVms4fV/Kab4p9f1KQCXYDcPoq1QS88Tb+zF6GO1v0g/YlIo58MdEQF7rGn8GFpoBzraLWl0h8/HsFCNb6/A/cZBDZaUmTI/6CGUyllSD6WqtROop5ezuvQPicLkvsDLjiGiz0FLy2oL9TC39kqPrvYm0CF0w3sbRYPQU+qGmQT3DlOJPaj2Hyrif94HT4PhL2ZqOX4HM5n9tDliQRD7Q3Zv5BCn5Qt0GSpKxzHqtq9XJ03d8jrvC/UIKvu7/kw== Received: from PH8PR22CA0005.namprd22.prod.outlook.com (2603:10b6:510:2d1::18) by DM6PR12MB4122.namprd12.prod.outlook.com (2603:10b6:5:214::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Tue, 24 Oct 2023 17:52:29 +0000 Received: from DS1PEPF0001709B.namprd05.prod.outlook.com (2603:10b6:510:2d1:cafe::2b) by PH8PR22CA0005.outlook.office365.com (2603:10b6:510:2d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.36 via Frontend Transport; Tue, 24 Oct 2023 17:52:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709B.mail.protection.outlook.com (10.167.18.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Tue, 24 Oct 2023 17:52:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:16 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:13 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 6/7] net/mlx5/hws: remove csum check from L3 ok check Date: Tue, 24 Oct 2023 20:51:31 +0300 Message-ID: <20231024175132.1435553-7-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709B:EE_|DM6PR12MB4122:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a678d53-7eeb-4ffd-de80-08dbd4b9fd24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aLY+rEqKx/PEtwBloEX/iLbFUUDA+ZtfqWatq9fYz7nTI+TFs4ApG97YyZhvFqamIcCk4zXpiDktfHg2Le6hMil/52pkRvx1LYQBSPjzLT0oUh9wztdlmhlHSKhIUdafDAMSK9yauHX8K2hueLIlWNs/zulMqgrfXopQY0dAJAAgeCMu7pbuFsjt5Gt5hobiRpaAhJ5mTYGJQQiwHfbpeMEbPBAd+At81DMV6enTwS4x144BUggl80Afb6NWm2So1dNVX/6d7AxSnsodCdXhAQFIUrBVHNGtivqSj2EYUZZShmTm8njwRsoNt6GV5AwVA6VYUtVzuD8FOJv1iyHaiG3mJoB1AXCLWNlHb7SP0JLdmD23apIjNMs6/xscixTrA61dYDvGv6L6BG5FcH4ext18Of1CJgC3IZYKt8nSrAuhJpHlw8q9rHp+K8OAdCPb6nU2iiTB1fANxH6wlbQmcJGefpvBg+aB6WMwnWKE4GendR+ba9NM/daJD0XCx51AqPIfSPEBKsEjVfpzSOziR14b24NQkKLLrCxK7OqieYXVTRJb2W6QIS1MTEVfg9vmn8Opa/2aJ4+J3DOM5DLf5ZdIMAoaSGzxco0V8hQstMsuI7Gc7hD9GnlHpJPIET6rABubu72ELn/9CCM3xCO6qtbdARUbflj8fDO5XgpjbfP3PgI2CSxaWz4jLbISV2KdODxZUaNlYL70KqUx5DPrMxpS0mcdbkSLghkbbImN2Sf+bRWjeJs8ClZecXfTLiyK X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(39860400002)(376002)(346002)(396003)(230922051799003)(82310400011)(451199024)(1800799009)(186009)(64100799003)(46966006)(40470700004)(36840700001)(36860700001)(2906002)(47076005)(5660300002)(83380400001)(41300700001)(82740400003)(7636003)(356005)(426003)(336012)(16526019)(1076003)(107886003)(26005)(40480700001)(40460700003)(6666004)(4326008)(2616005)(8676002)(8936002)(70206006)(316002)(54906003)(6916009)(86362001)(36756003)(478600001)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:28.2584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a678d53-7eeb-4ffd-de80-08dbd4b9fd24 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709B.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Michael Baum This patch changes the integrity item behavior for HW steering. Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum. New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum. This change enables matching "l3_ok" in IPv6 packets since for IPv6 packets "ipv4_csum_ok" is always miss. For SW steering the old behavior is kept as same as for L4 ok. Signed-off-by: Michael Baum --- doc/guides/nics/mlx5.rst | 11 ++++++++--- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index c9e74948cc..8d7e0aad7e 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -663,12 +663,13 @@ Limitations - Integrity: - - Integrity offload is enabled starting from **ConnectX-6 Dx**. - Verification bits provided by the hardware are ``l3_ok``, ``ipv4_csum_ok``, ``l4_ok``, ``l4_csum_ok``. - ``level`` value 0 references outer headers. - Negative integrity item verification is not supported. - - Multiple integrity items not supported in a single flow rule. - - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. + - With SW steering (``dv_flow_en=1``) + - Integrity offload is enabled starting from **ConnectX-6 Dx**. + - Multiple integrity items not supported in a single flow rule. + - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. For example, if integrity item mask sets ``l4_ok`` or ``l4_csum_ok`` bits, reference to L4 network header, TCP or UDP, must be in the rule pattern as well:: @@ -676,6 +677,10 @@ Limitations flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec l4_ok / eth / ipv4 proto is udp / end … + - With HW steering (``dv_flow_en=2``) + - The ``l3_ok`` field represents all L3 checks, but nothing about whether IPv4 checksum ok. + - The ``l4_ok`` field represents all L4 checks including L4 checksum ok. + - Connection tracking: - Cannot co-exist with ASO meter, ASO age action in a single flow rule. diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 0e1035c6bd..c752896ca7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -380,10 +380,8 @@ mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, uint32_t ok1_bits = 0; if (v->l3_ok) - ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) : - BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_FIRST_IPV4_CSUM_OK); + ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) : + BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK); if (v->ipv4_csum_ok) ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) : From patchwork Tue Oct 24 17:51:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133275 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D38764316B; Tue, 24 Oct 2023 19:53:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D191A41104; Tue, 24 Oct 2023 19:52:39 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2040.outbound.protection.outlook.com [40.107.220.40]) by mails.dpdk.org (Postfix) with ESMTP id 5605840DC9 for ; Tue, 24 Oct 2023 19:52:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wyx73Ey/yzwXNVauVonmiLYqaIWNHS3Bqz1XMK0G96DangIya2YR1JXurUGpmSgnFjZ/p3KG+h/n7zlOjeBTMaIkPIMINfTTJTD7MTHTUSUUXZeRdCScxQ+yy7CTOwwzTd7Cr+Qkp6YtR7DAScMSK0SR9gsVi2khxyuJOVHeNQF1rpirL9YQlPAzqPKiN2vISdKJKF+WplEm1kHIIg5VyGv+7IbCKAbINRXtrcqpbuZucjh9MAglAKmylx5i/W5RQlMmOB9TQAVPcXlZLRASiD5L0EwS+fLMHm9iaKmJ7cy41LoEuJuajuVVHb54knytAQTAehB3EBfxPIfDaP6x/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doVg3uloVj0g4isFYPoHdrJRqmk4hf5XRqDqwcYQMWM=; b=GB3+HLygmJ/8WLHmGDw7r6kI9KLSeRtNSKepqiOLkGovfyeBlW00Gs8c7unosdtviynsvRqNOrVk5gxVgJjU3iS+BO5jNnfZXSp/kOqMql5kIqo6+TazKlyi3Kt5ozDrZWT6VCkVDHJgkLPUPvoJN75piXQKMybyExljD/51jRfhcGqcrFgpJoZvGmrYjRtv3l285wqQg3c2ZprtXnJeT/5o4P0beQat8xCL7/0NqHSjFaYWcyBft6AXqmaIhZbMZ9dcQ0v1p4BOvSxLTWUpOZT92x3MxxvoXQZCNQO9gsN0fAK6/nRZVMjLfCQoYrxktEycbwifWiu+due+NB9rnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=doVg3uloVj0g4isFYPoHdrJRqmk4hf5XRqDqwcYQMWM=; b=LLG2atcx3BFT2LQrmRC5sbnqV/vXq95tbigzfRHvCi7G6VhFslAwNlizJeh9OiMokEMMWw8tyIwUiLMFiHnFE1Gu9pFW6kmgINmzuPwqmnpwGDQhswa25iFQkv3aZaKLmuPDXVhw8ZAaZ5Y+vLgRacdnm9dQpeint2oUreTVKaUZ5p1NeF02NQI148OV260oy8l5Q8wKlBdZjji7u+U79VM4gka++n6XoxZgVYyhLRTJlWgLwHrM3BPpm+AHMha8XX2ATZ2Htdcb/vI7NrxxsnTOFUpQXNdv9lJqBzDfRTEXjwueTIfH6lmZCYCl5MAcKn7pYXP/SHM/23rMcU4TqA== Received: from DS7PR03CA0163.namprd03.prod.outlook.com (2603:10b6:5:3b2::18) by DM3PR12MB9391.namprd12.prod.outlook.com (2603:10b6:0:3d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 17:52:35 +0000 Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:5:3b2:cafe::f5) by DS7PR03CA0163.outlook.office365.com (2603:10b6:5:3b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.34 via Frontend Transport; Tue, 24 Oct 2023 17:52:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Tue, 24 Oct 2023 17:52:34 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:18 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:16 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 7/7] net/mlx5/hws: fix integrity bits level Date: Tue, 24 Oct 2023 20:51:32 +0300 Message-ID: <20231024175132.1435553-8-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|DM3PR12MB9391:EE_ X-MS-Office365-Filtering-Correlation-Id: af8d22a8-a9d3-46ed-e46c-08dbd4ba0125 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cZKwv6xLqCqHE5PxJqNlN9wM+qvvbyAlSVYQQZSfLgN862ZK8RJEoSb2a1iG5XK3vSmgt7XapyquFoKutafoNS4zCkmV9/V5A5+VvFxL8N+swYAeFlEumGIZqxaNC2god2YLgFcn1NMBYPxNYb1aYOM4dlaPSJ3PehEgfw6CzrQPNNiW0pi58z+nN6q5omMQZ2bvRhl36sEy7QvLmXc6l3oaGtq64Gd8s5JSu0f5xvGjw/hJmV8UJJjJymXAGB4uF/N0tPBs03hTVMXddvVshoa4hfyemYNR+Yej69FKe50HZVC/K1h9ko+BAD/F9uAkEe/prUs34dPf+sSvZ7TzgodEx+nSgNEJnjpq9OUdoda6j3i/jkd9108ZsngHAuzlHv+hlPzvjSBCEfFoYADzkrLNLbX3BuSfYnCbKvV65wjOY4Jo0WjxiR3zdgLg9PNgWG8W0J+92tSTlA2hRUmwN65cqwP5T+Xdkg8y0/pWJdbt62v3R/yA0Nx9VklhLPyYMu79B1ctF+cPCThF/h2/8YUKHm13vHzQqkHkm/Kv4HuAGhUxsq3KMQ/NgwRD+xEIE3YGw9UHoBPYLKGbXgsWjAXHYsTjHT39xjGRKroGWwPV4KkgAiRx1jWYZ4sQsQYgj8c12qT8m43Pyc6hYzHZoTDFFuJTd4Enp7KJgKHAUksodzPFdLQJbk6r8vwSu46huR4/sRNgf4ujzpjqy2C2Q44ztfqqGZ0IRNCHQpBGlms6k+RO1tYTz6vHHw4npkkI X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(376002)(346002)(136003)(230922051799003)(64100799003)(1800799009)(451199024)(82310400011)(186009)(46966006)(40470700004)(36840700001)(36860700001)(2906002)(6916009)(70586007)(70206006)(316002)(54906003)(82740400003)(356005)(2616005)(6666004)(107886003)(1076003)(7636003)(16526019)(336012)(40480700001)(47076005)(426003)(83380400001)(40460700003)(86362001)(5660300002)(36756003)(4326008)(478600001)(8676002)(41300700001)(8936002)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:34.9604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af8d22a8-a9d3-46ed-e46c-08dbd4ba0125 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9391 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The level field in the integrity item is not taken into account in the current implementation of hardware steering. Use this value instead of trying to find out the encapsulation level according to the protocol items involved. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index c752896ca7..f1f9235956 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -1905,7 +1905,6 @@ mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, { const struct rte_flow_item_integrity *m = item->mask; struct mlx5dr_definer_fc *fc; - bool inner = cd->tunnel; if (!m) return 0; @@ -1916,7 +1915,7 @@ mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, } if (m->l3_ok || m->ipv4_csum_ok || m->l4_ok || m->l4_csum_ok) { - fc = &cd->fc[DR_CALC_FNAME(INTEGRITY, inner)]; + fc = &cd->fc[DR_CALC_FNAME(INTEGRITY, m->level)]; fc->item_idx = item_idx; fc->tag_set = &mlx5dr_definer_integrity_set; DR_CALC_SET_HDR(fc, oks1, oks1_bits); @@ -2471,8 +2470,7 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, break; case RTE_FLOW_ITEM_TYPE_INTEGRITY: ret = mlx5dr_definer_conv_item_integrity(&cd, items, i); - item_flags |= cd.tunnel ? MLX5_FLOW_ITEM_INNER_INTEGRITY : - MLX5_FLOW_ITEM_OUTER_INTEGRITY; + item_flags |= MLX5_FLOW_ITEM_INTEGRITY; break; case RTE_FLOW_ITEM_TYPE_CONNTRACK: ret = mlx5dr_definer_conv_item_conntrack(&cd, items, i);