From patchwork Tue Oct 17 16:46:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 132765 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E989B4318E; Tue, 17 Oct 2023 18:46:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6A3242DDE; Tue, 17 Oct 2023 18:46:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 8B2D642D66; Tue, 17 Oct 2023 18:46:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697561192; x=1729097192; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7dJ9uezaIUjSVWepaWwVyTzCQcNhp4FvFPLPREdpxSM=; b=PbWbwrp/bFabq7RKP3M6GJ2/LUfZTVomCZHMGbk0wa0f4lWFzcOv4Bc6 4OYofFcYHgAFLuaSQmJXss07DwlOO1ns1VzejBIBkvzdN8Cddmxtgqf66 B1Lu99IGDZV8SDGx2n2yOmT5E3APSIeMlyL0APZF8hhAwuyOC84fHzZXn 32DsWSDYu+Wo43Qs5w3jwi0GX2yJhFTjBmMbAufx0o5ed1dWiSXzr1wLN qjRIHGs7IbU1lfF/pu4cIDeTy5VODZZpA3oNUug8AeU9E2QHLqo/AZGiA /URwFKRKYm/2gxO1MD3KzznMtmMAfnl5DDXmNHrXnirLB0jUAYf242WQI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="388688385" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="388688385" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 09:46:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="872640538" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="872640538" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.41]) by fmsmga002.fm.intel.com with ESMTP; 17 Oct 2023 09:46:26 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Harry van Haaren , Jerin Jacob Subject: [PATCH v3 1/4] event/sw: fix missing device pointer Date: Tue, 17 Oct 2023 17:46:07 +0100 Message-Id: <20231017164610.191852-2-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017164610.191852-1-bruce.richardson@intel.com> References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231017164610.191852-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Initialize the "dev" pointer in the eventdev structure so it can be returned in calls to "rte_event_dev_info_get()" and avoid potential crashes due to a NULL value being passed to "rte_dev_name()" Fixes: aaa4a221da26 ("event/sw: add new software-only eventdev driver") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 6d1816b76d..bf166a8cfc 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -1080,6 +1080,7 @@ sw_probe(struct rte_vdev_device *vdev) SW_LOG_ERR("eventdev vdev init() failed"); return -EFAULT; } + dev->dev = &vdev->device; dev->dev_ops = &evdev_sw_ops; dev->enqueue = sw_event_enqueue; dev->enqueue_burst = sw_event_enqueue_burst; From patchwork Tue Oct 17 16:46:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 132766 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 117834318E; Tue, 17 Oct 2023 18:46:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B41342DF3; Tue, 17 Oct 2023 18:46:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 73D5642DA7; Tue, 17 Oct 2023 18:46:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697561194; x=1729097194; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MFfk0r4DuerpVXOqGkvkA0gFyRJIFD0wrUQpA0wAnYM=; b=YjNMK92Ow16FCRYvBvXb32ifGyOcKLYCX4tK4RL2vAVNFsaIyrOKubzA rBvSX1MuF1ZDiUu5ufq3+6LfRccPTd8tKtwicrJqxr6x2yCwBpPpugvpU Z0h8I/9Xtw5i46TCNRVp1UXHXvnIHZ2WSFYMdi7dj7pcFXZuB+jX05Qc7 jKXgBQ0qmoFnVQyhKJ9tYdrdz4v1fxEn4TMSUrobGsM9NO6On+Tow/AYo c/UDVyZOjITgq9uuXe5GJNq1L7FI/E0Z97eA529OVbpxI1P9vTytwFkTI km44ZcSLSRHrT8lzDcgSCM0m++qYeZ+DtaY62NIDYO/2HM5NTyh5K7VxW A==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="388688413" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="388688413" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 09:46:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="872640587" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="872640587" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.41]) by fmsmga002.fm.intel.com with ESMTP; 17 Oct 2023 09:46:30 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , mattias.ronnblom@ericsson.com, stable@dpdk.org, Jerin Jacob Subject: [PATCH v3 2/4] event/dsw: fix missing device pointer Date: Tue, 17 Oct 2023 17:46:08 +0100 Message-Id: <20231017164610.191852-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017164610.191852-1-bruce.richardson@intel.com> References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231017164610.191852-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Initialize the "dev" pointer in the eventdev structure so it can be returned in calls to "rte_event_dev_info_get()" and avoid potential crashes due to a NULL value being passed to "rte_dev_name()" Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") Cc: mattias.ronnblom@ericsson.com Cc: stable@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c index 785c12f61f..44da3c60d1 100644 --- a/drivers/event/dsw/dsw_evdev.c +++ b/drivers/event/dsw/dsw_evdev.c @@ -440,6 +440,7 @@ dsw_probe(struct rte_vdev_device *vdev) return -EFAULT; dev->dev_ops = &dsw_evdev_ops; + dev->dev = &vdev->device; dev->enqueue = dsw_event_enqueue; dev->enqueue_burst = dsw_event_enqueue_burst; dev->enqueue_new_burst = dsw_event_enqueue_new_burst; From patchwork Tue Oct 17 16:46:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 132767 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B11E64318E; Tue, 17 Oct 2023 18:46:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B54BF42DFA; Tue, 17 Oct 2023 18:46:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B4FFB42DFF; Tue, 17 Oct 2023 18:46:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697561198; x=1729097198; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S/1yat0EU5J/VVIfpUHkudwfR6tDPId7gmAD/iqHbV8=; b=dIvWmKoOa6BZ0IUL4/ntYKd0+WbjX+aI3zd8+VqjYAgfMpGA4RHREHSb /LXli2BHj1hACkyHPQzUDG3s6I/ipxskmQLleNvEkU7fCl8JRPP27Ok/m rQA766/Td2xvwgnH7lXenNFhIJMHp4YE8FcB9mRMN/+uBZGYf5QHTYEQ4 gOML/TzoUUbMPTuIYV4VrXzWTHBKrCoeaMAZ5dKBHkGuY13w196fPZ3gw ifl3sQ+kkjL3g6CPP4QWQLcgY5rMKiIDVL15o/EZxI8GFcchT3ihe58c1 qat5aTrIBGslQXowVTQA0yBhtb3sUmxCjMAy27j8u6kXhP/c4/gvs9Ggq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="388688439" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="388688439" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 09:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="872640610" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="872640610" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.41]) by fmsmga002.fm.intel.com with ESMTP; 17 Oct 2023 09:46:35 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Jerin Jacob Subject: [PATCH v3 3/4] event/skeleton: fix missing device pointer Date: Tue, 17 Oct 2023 17:46:09 +0100 Message-Id: <20231017164610.191852-4-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017164610.191852-1-bruce.richardson@intel.com> References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231017164610.191852-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Initialize the "dev" pointer in the eventdev structure so it can be returned in calls to "rte_event_dev_info_get()" and avoid potential crashes due to a NULL value being passed to "rte_dev_name()" Fixes: bbbb929da5e6 ("event/skeleton: add skeleton eventdev driver") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/event/skeleton/skeleton_eventdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index dc9b131641..3aa6657f39 100644 --- a/drivers/event/skeleton/skeleton_eventdev.c +++ b/drivers/event/skeleton/skeleton_eventdev.c @@ -428,7 +428,7 @@ RTE_PMD_REGISTER_PCI_TABLE(event_skeleton_pci, pci_id_skeleton_map); /* VDEV based event device */ static int -skeleton_eventdev_create(const char *name, int socket_id) +skeleton_eventdev_create(const char *name, int socket_id, struct rte_vdev_device *vdev) { struct rte_eventdev *eventdev; @@ -440,6 +440,7 @@ skeleton_eventdev_create(const char *name, int socket_id) } eventdev->dev_ops = &skeleton_eventdev_ops; + eventdev->dev = &vdev->device; eventdev->enqueue = skeleton_eventdev_enqueue; eventdev->enqueue_burst = skeleton_eventdev_enqueue_burst; eventdev->dequeue = skeleton_eventdev_dequeue; @@ -459,7 +460,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev) name = rte_vdev_device_name(vdev); RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name, rte_socket_id()); - return skeleton_eventdev_create(name, rte_socket_id()); + return skeleton_eventdev_create(name, rte_socket_id(), vdev); } static int From patchwork Tue Oct 17 16:46:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 132768 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B22C4318E; Tue, 17 Oct 2023 18:46:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 186B542E03; Tue, 17 Oct 2023 18:46:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 47BB742DF2; Tue, 17 Oct 2023 18:46:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697561201; x=1729097201; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=srs+5A4tdpKbL8X6qSp/E0WrTHuQJUcsCrhZY9U/Gcg=; b=lmYjXwK549D0I7eh3vEBz9vmM3usHkdqBF4Gkrtog1mIcKcz5EG5dY5y G+E+rFdUVzqy+Be11S7f0UbsjgAY0yGA/0hPbhfVWIbiti20NRHvTXS1v ulfobBb4Ihjbi/xUIFNZPyXFovv21D+F594BYlF1BAfijMJ9QlJtt+Li3 k8k+vwugMb6ZijfpNhNyQ0IgGTlUy0fW4IEj8SPBJrtipQMALcujkfQGp mA3KNJFeC5CaTIaSF8IuunOEDV3KL3M0g5/+OiArG0PPXUT/9V0Fds/10 l4RUCgilDUlNAqu/50AjBx8G8kad7EGBUGVu8yKR0KdG96qtVQey3zG4s g==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="388688463" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="388688463" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 09:46:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="872640630" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="872640630" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.41]) by fmsmga002.fm.intel.com with ESMTP; 17 Oct 2023 09:46:39 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Jerin Jacob Subject: [PATCH v3 4/4] event/skeleton: set driver name string Date: Tue, 17 Oct 2023 17:46:10 +0100 Message-Id: <20231017164610.191852-5-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017164610.191852-1-bruce.richardson@intel.com> References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231017164610.191852-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When calling rte_eventdev_info_get() the driver name string field should be populated. Fixes: bbbb929da5e6 ("event/skeleton: add skeleton eventdev driver") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/event/skeleton/skeleton_eventdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index 3aa6657f39..ccceae22ad 100644 --- a/drivers/event/skeleton/skeleton_eventdev.c +++ b/drivers/event/skeleton/skeleton_eventdev.c @@ -24,6 +24,7 @@ #define EVENTDEV_NAME_SKELETON_PMD event_skeleton /**< Skeleton event device PMD name */ +#define EVENTDEV_NAME_STRING RTE_STR(EVENTDEV_NAME_SKELETON_PMD) static uint16_t skeleton_eventdev_enqueue(void *port, const struct rte_event *ev) @@ -88,6 +89,7 @@ skeleton_eventdev_info_get(struct rte_eventdev *dev, RTE_SET_USED(skel); + dev_info->driver_name = EVENTDEV_NAME_STRING; dev_info->min_dequeue_timeout_ns = 1; dev_info->max_dequeue_timeout_ns = 10000; dev_info->dequeue_timeout_ns = 25;