From patchwork Tue Oct 17 13:13:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 132753 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FFE64318A; Tue, 17 Oct 2023 15:13:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8C9140273; Tue, 17 Oct 2023 15:13:50 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0ABD740270 for ; Tue, 17 Oct 2023 15:13:49 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4967220B74C1; Tue, 17 Oct 2023 06:13:48 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4967220B74C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1697548428; bh=uyxNTt79pGpAD9v2ovAA3V2RyXgmn9nGYVSiZIX6AcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wgu6k72nanGt9uS3F7FV9lzoMroClmdjuNsKJ8BZx36PNBwmDUHKMDpEL/IUBfhDt WDh4JbSWE5ygxv+xkAbLRm6aN+bBMWLVhnF2qMNofvuHkm88C9dVxs0ADIeI6M6DcF 3JDUh5BcxGPu7CVopWXZPNDPgXA5K1V05g3XUZhw= From: Tyler Retzlaff To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson , Tyler Retzlaff Subject: [PATCH 1/2] build: temporarily disable MSVC warnings Date: Tue, 17 Oct 2023 06:13:46 -0700 Message-Id: <1697548427-10153-2-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1697548427-10153-1-git-send-email-roretzla@linux.microsoft.com> References: <1697548427-10153-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Temporarily disable integer truncation and conversion warnings for MSVC to allow CI pipeline to be established. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- config/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/meson.build b/config/meson.build index d56b0f9..6e8320e 100644 --- a/config/meson.build +++ b/config/meson.build @@ -36,6 +36,9 @@ if is_ms_compiler # the MSVC compiler regards as unsafe but are used by DPDK dpdk_conf.set('_CRT_SECURE_NO_WARNINGS', 1) + # temporarily disable msvc specific warnings + add_project_arguments('/wd4244', '/wd4267', language: 'c') + # enable non-locking atomic operations add_project_arguments('/experimental:c11atomics', language: 'c') From patchwork Tue Oct 17 13:13:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 132754 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B51C4318A; Tue, 17 Oct 2023 15:13:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C54C42DAC; Tue, 17 Oct 2023 15:13:52 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0F4BE40273 for ; Tue, 17 Oct 2023 15:13:49 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 577D620B74C2; Tue, 17 Oct 2023 06:13:48 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 577D620B74C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1697548428; bh=5k/tooEfru0VqKbl49c8v4HdGrp90EVouoUmHq6AtaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gEuqieYUEdXtupq+s5a8drGei+gzbL88FTNvgt/O2gZ7Cf9uqdP90CFalTO8AwHZ/ gNuz+541lJL2CDw8X9usIC6pXh5lPzfI8RpDoASG5mJNVrWC6CD964RxhL26bFfjc2 aZNgdqG4zhuJAeK7owyR5pp8M1/hz63dVHnW3Sfc= From: Tyler Retzlaff To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson , Tyler Retzlaff Subject: [PATCH 2/2] eal: temporarily disable standard c atomics support for MSVC Date: Tue, 17 Oct 2023 06:13:47 -0700 Message-Id: <1697548427-10153-3-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1697548427-10153-1-git-send-email-roretzla@linux.microsoft.com> References: <1697548427-10153-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC will define __STDC_NO_ATOMICS__ until versions of the compiler that support atomics is released. Currently we use the Preview version of the compiler so skip the test of __STDC_NO_ATOMICS__ avoiding failure. This is a temporary change until the required compiler is released publicly but allows us to establish the MSVC CI pipeline. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_stdatomic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/rte_stdatomic.h b/lib/eal/include/rte_stdatomic.h index 8579e2d..7a081cb 100644 --- a/lib/eal/include/rte_stdatomic.h +++ b/lib/eal/include/rte_stdatomic.h @@ -12,9 +12,11 @@ #endif #ifdef RTE_ENABLE_STDATOMIC +#ifndef _MSC_VER #ifdef __STDC_NO_ATOMICS__ #error enable_stdatomic=true but atomics not supported by toolchain #endif +#endif #include