From patchwork Tue Oct 17 02:37:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132688 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 513CC43185; Tue, 17 Oct 2023 04:37:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 265B6402B3; Tue, 17 Oct 2023 04:37:55 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2112.outbound.protection.outlook.com [40.107.243.112]) by mails.dpdk.org (Postfix) with ESMTP id D91AC4021D; Tue, 17 Oct 2023 04:37:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XP87vMLlxyhM58Pkb0BT0Ce5WSrv2EQpbIvhN3CMrFiez3STqZ08FzRLsZ5jRSAB92tF7Dn/fSer3rj/6HU+4yv097kprYm8eJiy4m2iGgtYiH5YcvpiNkT5aXD7gMzKCEFvkBie5cCZGWvgsRAIh1wPBny0lQKbn0wDgRKW/PR1xIxZpoJ04dqhBWhmQvB98kpdTkzGG3gSFTDjTpO3GM1LKFqUz+vF264rzFTuN7sl65dRrzDkr5/xYbDxnW9KG3vTglnFk7JchC+HEImE83Ty11GpBr9GabstKMGZzBV0N95dXKm3pDFkh73KWh0UPqPCPRy47sI8jYrZWjC6/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v26B2icoC8fykqvzcESwwF/bzU2s/EG7FHnmIfNKPz0=; b=AtSong0CRi3nrrUpDOUUBkyNYUKsxWe8Y9Cvs9nA6Y5fQCsUwb+dPleYAlnQR6ZkBy58nzrDYSid9pvUQ65fKEECVHwV4lepr32w4Vb5zL4btHIYxoItlRb4tbVEHyX5txlPMy1hU0ttICNUjjQxc4/5MJ0KUG2r0/SEYkPSDpF6Pji0JA1P9Z9Mpf8yi7C7Su1MxPIHrvhITIA9AkNquHu2sZ93ZKB65LmOh/4iCiRtAQNgBEoI3hPLmknGX/KS3mFQt4oyOGoi3GTyj6u4J6EMQFJ0TvWO3mLZvOm/WDkJUhs2ntPvhqh72x/rKccbQsFFUt/8J2bYLdLSWmoRtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v26B2icoC8fykqvzcESwwF/bzU2s/EG7FHnmIfNKPz0=; b=n6ia/4g2F2JNxJks9yiX1j5kRh0Qt6rIIZOWtyVMh9CHGyauhtlgiYHMwR9WX5j6iq//0wncs25vYhGme+N8e14RrJ1HQyidZ+f+OaA/g4uVFBEIxYUlC2K93yany0hlYzklJ20RfFc+o8YsDPZcDZ3gP6VG3fWM0a1w0/6VbHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) by LV3PR13MB6454.namprd13.prod.outlook.com (2603:10b6:408:19c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Tue, 17 Oct 2023 02:37:50 +0000 Received: from PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::b070:92e1:931e:fee7]) by PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::b070:92e1:931e:fee7%4]) with mapi id 15.20.6863.047; Tue, 17 Oct 2023 02:37:50 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH] net/nfp: fix coredump problem when testpmd exit Date: Tue, 17 Oct 2023 10:37:30 +0800 Message-Id: <20231017023730.421385-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: BY5PR17CA0017.namprd17.prod.outlook.com (2603:10b6:a03:1b8::30) To PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB5568:EE_|LV3PR13MB6454:EE_ X-MS-Office365-Filtering-Correlation-Id: 633087ce-9896-46af-17db-08dbceba0df6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qndi72lV0o6HBh+rR3M2Obzwi9dkFQoxpaTt8MOB+XwTgJ5wwcHQv5wuGFMTT16+48ZMPlCshurGk2/krNFhQGBlO/YJu9U33H0FNsNAuXea2iS8qSUtVZkWyUnZPuH+g82gb4nTtCK4aIWTLOa35lM8JHS73RTLydQbU+iF/9wX7QFJBHUSs7ytK5fJv+OzmvFTGsWe0ezIO067UL7pxZfhyDTDJb0DRYuLCUIrpaxlcoQOi2I/YcAkQU5XGf0Q8mygt3abjrKd2FTlr7+viX6+cWQX7Q4dAQO8+26J9pbK+ei5/b0dpHAfpan0h7ys0hR2MSGLyZ2KzuyLdakFSKUuJNDD968THQZhLT41iYqfcxC9YW+Y0RLbgrx2VENK31DUtpC5jpZjNtVR0IhpGX4+t3cD7imlsWEKyoziAiiMNAib3t3gXn2ep7ebmo4wrz1dt+wbMzg3UdhvA5XxEePTiS01wRrpA2Iqs/uPn5ZvTMI1SWgR9TN/7oGQ95jnpcokTvoz/FPR5lkodgyBljhNWZezBgORzD4+VXmI8KFalN8o/6KUvR/1OY/OhkYpMiN6fDhibNmHcZWpO1eqLiG9NslNrLFGvtj6CdonHTFaDw3iT8p1ZDhgTjIlYwx+hZ3TTuO/W3yquOPC+9Om4MosEV/WznDwQZ9i0KBzJIk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR13MB5568.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(346002)(366004)(39830400003)(376002)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(38350700005)(26005)(6916009)(316002)(450100002)(107886003)(8936002)(4326008)(1076003)(8676002)(5660300002)(83380400001)(478600001)(6486002)(6666004)(2906002)(2616005)(6512007)(86362001)(44832011)(36756003)(54906003)(41300700001)(66476007)(66946007)(66556008)(6506007)(38100700002)(52116002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /LTTDjRdWsyM0i5W7kh+LOQvN6fUE5mZg+e9qQYiX7sN3cCamEfzIGNouoYoFoUeGJv/t5zllYAMz/nF99hreBrdrSYbwcHllxrubBKSpdLnp8gTF8GjuI1eB8+1WmR+dC34enkVae7jDvLHYAt06Wq9MN1hxoWNlsutARzfU1OwI142HaoADLkJEAX7mWvuJ5wU9wOtHS3o2/gLgxoEebjoXpiPN+6PO6PgIsZM81sPVjxMztCQsAkx6AjbxiI+OjfnYD55gohkt77AO9oC8i4NeHI6M/aX7j0gDnL1LziW8qEK3i492zV5Le2y2740g3pSC+S4odSE8kkKM5Fpc2Unpg+VSdR9LxtGmotoeJin7lZUVrQdNEd23Ruq7Jc/MEEwXRqzUWP2neDf2iwHwPR7NIioPk1gFyXLO87cubWk8IArIJQ4nI1s3aA+WggN7F/ih1uzJDMIjLNyC9dtKVNPp5TNLkn7OjZ3GtVe7FbJxSuafGCCcgxOOtfib2pOoJRQB4Y/YIYWVj+1UIkiCQcMH17pTcLoYmYREwzlnaELlSJe7NqT7XfMZxMgU2lgI+S+CRF+2kcCWrusCQ7e6k1esw0/IqHyeBPko4qQ8bMTHRESo+QBHdU1MPaX94w+6H3lK5gA2hLrr8W48lUTkY5YIDWrJXh1rprf8VobkgCRux01Jm7KiU+WiyVL24a6hKZFfSee2O31st3LEsIsOi80nChBgpgzMKJnBdeHzoUJ9wQqVE0EA9ZaKbNEI8m5DQnedDkFfadV9tqt5jZg1mgD8sLSgOVEpLGp01MYnV9RdXUYC+SpyHhl1JLa42Wq/YbMTyh80YXrJIOxo5cu8fR6OJFlMLs887mdR6dZqxJIhT2JpPeI5+O3PB/YX2YnHffEow/OPnIgCW5ql9oEpHf3J1A5sUPbTHZnNAPRJmJYf0b8+xGQ2+Hxck7qmIA80i9GWeng10eILbC+aFf9GK7RY3BO5KC4u2nuVMXZU/GYFxRfxwo4BxZXAf8fxY9jG/WauQiTWELmnJXkfyJ1Ej7iatKhoOb5zu8FATZkZHtoKemyxJTrdFkF0TYBsbud3ZU1TDMZm0ildEDuVtvEV6DfMsCTWmSiXamMmu5J0PiK3YWTmi2M9UYldOsaLAh4ZuUBCMpKzxPRHUa22crUyP35rgRPDYI3YaoCVF8WG5A76p6vLP/ueU71F4MfhjTmOxArnDbip+bnJebgmVr9Z7zBYoyBaRg2l8HsEUvPulilDUzex1J/JlkKG+/C4XPZ8CGbi9TKPlilYvAnh/1q5X54HCcE8AuK6axpbreOsjOEWAC5vi91tsbu6T8TxTxlf2I9r+Kf8m8Zg5QFHALzHSaxhtKLnMoXThet8qeVQMWUtaeL8pM4b21Qc8oQAHZT67FCl+19ptupvvT5hBVawL7wUhjCtNNRJCIWBA70MxbPNh/myxiJa4116YRdheVa9GXaN3OhCHW3gvW6yCy4jSsKJw6BPw109M8OBEAi0+KNHQL+8UMg1LMlSlXeUkPRKqv4F8+9gDzWltEy3pNKdEsEHCJyafK4xtzmfUPbeOX8Xbfuln7xE237/kxhztTEVXEWBRTZntGLvS64Xb5jdQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 633087ce-9896-46af-17db-08dbceba0df6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 02:37:49.9734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mPA/3om3Gc/PYGRselYFIYqwrnoY+a+buy9n4RFSIysgpVF33vDYbyzEZr2rK8NPTtlheymKoSRIKWsBjytQoQpTwlhvK4Kc1XdmeMY8Q7A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR13MB6454 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The ".dev_close" should not call rte_eth_dev_release_port() API directly, the rte_eth_dev_close() API will do it. Fixes: 831c44ab7869 ("net/nfp: add flower PF related routines") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 2 -- drivers/net/nfp/nfp_ethdev.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c index 0c54d7ed27..60d843451e 100644 --- a/drivers/net/nfp/flower/nfp_flower.c +++ b/drivers/net/nfp/flower/nfp_flower.c @@ -221,8 +221,6 @@ nfp_flower_pf_close(struct rte_eth_dev *dev) nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff); - rte_eth_dev_release_port(dev); - /* Now it is safe to free all PF resources */ PMD_DRV_LOG(INFO, "Freeing PF resources"); nfp_cpp_area_free(pf_dev->ctrl_area); diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 20940072fe..d32a82210c 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -286,7 +286,6 @@ nfp_net_close(struct rte_eth_dev *dev) /* Mark this port as unused and free device priv resources */ nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff); app_fw_nic->ports[hw->idx] = NULL; - rte_eth_dev_release_port(dev); for (i = 0; i < app_fw_nic->total_phyports; i++) { /* Check to see if ports are still in use */