From patchwork Tue Oct 10 06:23:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132455 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6E5342348; Tue, 10 Oct 2023 08:23:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FDF3402F1; Tue, 10 Oct 2023 08:23:30 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2095.outbound.protection.outlook.com [40.107.92.95]) by mails.dpdk.org (Postfix) with ESMTP id 0A65740041; Tue, 10 Oct 2023 08:23:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4j26MQPMC4C8OxuyqNAMqg60j884Fnhqhc49IaOEZBMIul4Lftedo4S1HMgQnL222xMrBMoVIM05/osS5mvnRfR9x+2YEJiozJKpYSjMg7w3dWkOo+w3g9kaC5YsRZ9JrCMIm5R4WU4aJoxAGBa7V4DebHYxqhz5ukhATsOwRcdEzJpSeQsSsM8BNbYnfazCLz5XkAYb9AYng99CIRTE23MFHfbmcfCT9wIM7DI6/aV9z1XgacGXo6GNGaAd8La+/VmdQeBr+frTb4zvoNboXADcI9JBZYNahkScRkYeL8c7xND+kYoDR60KLG2APZKnpYUmQB2D67nZZ3R0OSkVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mWo1BSy68Infql9OOFMLYisq4A6rG4YdAyyqSzoGOls=; b=I/6ExdLXweYWIYu8TtecfEzc5OSZGKx5UebGOGi1iQBYmTRzP6RYUtq+QYg5lCvazuksh3Au/RPWV0tuYs4iUYjMbQ6FLwV2o11X3EAlCwLDzKWxYrmAF+TG6Zf2GFZaK6x53AgeiV5NBbbLoKC0njGC/F8Wc0iSIdWmvsit06xbuMHS+dBVBJkoEMU9WKV5cicbRh4vAAHoI67JQsVtiYM1bbHkcMRAbYHXYgBU8xUdn+NIN3qfhNHrxTRQRhiEX1xuLGw85XWYUHSiVDV64y0aIKGSOFF4nS6hrQSIy0wJVBFEiKq3Ug9D3OlHt0kt8tnG0eyC8OTPtiLJxK27YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mWo1BSy68Infql9OOFMLYisq4A6rG4YdAyyqSzoGOls=; b=Joq6af6mfDODY5Qtdo2aVRqyybEHMJUBOl7Aj/s4RjMEerUUj9ErDj8bL5b0tdceObhwm3qrz1mNQC6iU5ytYEZy3fS6ga435khlYLocD9kRbJnP5GSpA3DOO2vQK5plLDME5Wn8Tfvy6vkiNjLop6/OpujWYOlkdanQg+RlvbA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB3802.namprd13.prod.outlook.com (2603:10b6:5:24e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Tue, 10 Oct 2023 06:23:26 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:23:26 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , tomaszx.kulasek@intel.com, stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH 1/3] app/test: fix control flow issue Date: Tue, 10 Oct 2023 14:23:02 +0800 Message-Id: <20231010062304.205933-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010062304.205933-1-chaoyong.he@corigine.com> References: <20231010062304.205933-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR07CA0057.namprd07.prod.outlook.com (2603:10b6:a03:60::34) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM6PR13MB3802:EE_ X-MS-Office365-Filtering-Correlation-Id: 56090a8b-f800-4013-9785-08dbc9596971 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c6U4FGFWhqSj4q6zgLtHOJTyTA4Z6nv01fkuj39NUQtPzIR7nPaJmEUUK+E6IEGMUhM3Y6oUfjONg8Ulb43plo/bhH0WLaHSIwBbFolWINvT9m7lUgmAld5TXtyxh4PhdIHwRZEhS8nPtf4rdkae8EJqOyHz93zn4ozf+zJogZZVMXJRBc7PU9X+38pck8HKFbqC4psfKm0uYI6de1nmK5SJrFQ+n4Ot2VVPSd1RAfyvHJBDJh+xxxQEpV6fdDXKm61JnhqKMxaozACXPPQjz81Dx3y+9dkdadxbHQqJFL2ANESuLpyowalbasBbCksjsuGwPOaNTf6Bo2e2KcRRbLjvc9xdCDIkFtQFYAVPImiaQfPEtJiHBcAEK5uMjT3KCsACWBBxaVod8yOmARHKLPM0tFZfnTEeI3mMnR4DcF64iRm9DDhg3KH8IW9Yx+qiv4F9xR+p6j+O3QTge4vfXQEeNLDlNF6sTi/kSFKOeeDz7q+BrP3gdBSOAPJ20gcSAlqxJEEmxS0ImBGExmbuKSjwndggrJptCLaE0ToT817IwdrC6XAoIhEZaARktYuKaYG+yjnEScoLkhe7cnifufv8/LPl/8GmNrDn0i9RC9ffffgs3cz/H/fKKH1DKwvxE5wef5WT9jcj5SXa9ScwoTpWDx9Y35MZb6wNrweiKNA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39830400003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(86362001)(36756003)(38350700002)(38100700002)(1076003)(52116002)(2616005)(6512007)(26005)(8936002)(4326008)(44832011)(6486002)(8676002)(5660300002)(6666004)(6506007)(41300700001)(2906002)(83380400001)(66946007)(107886003)(54906003)(66556008)(6916009)(316002)(66476007)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MudSCdEgNBhDcndUjiiF5oYOEkLxcKBX6fIwzcy5Hl/gs8iHqh+GJz5OX3mDZhKuCMSq+nGLZjFbSBfQ72zwps/23DfTZH8aQPLSHGYF24PK8NYL5fPqSSDhTV9K3tkKahsX7Q9EfGpvL8EERXtf3tqSNCnF7G1YIj70hPUp1C7axqloXkrdRil19b1D5NUI9XZps1FM8mrVK/X1MW5m1cwIjU51PtheAgjWuB5K/x+rnzKLUOot5xdcN+iPYjEPT+6ZuCxy3yXCwlDhw368hApA3qz05OEa1kVMx5C48etzzw1+cG2KFTa3NaswPepWfY1+6dESQHFcXpcJDBdEJ6FCk5YlXqE8jUcA7YNQykcIYRVsMd38gqV65X/Dub/ZTjnuQy0kClNUwMEU0pdnJmXVS1e/WrDXm+0Zw59Wa6ZvzRc/WZAG2PIYrpVZzacRczznLExZnwZZG2kolODDAzQWrbXRtNers4I/SV9E7ZI7GWqabtizqlIrBbTDeFBfwIQ1YMVtfLqHXj+mPZFAB2IGLjbvmmoqEfwfYQqIijw8yMrtv+9xznFkDa5Pc6FyXscqVnIOpSLjrv7Gur6wOQ+XTOHmvV87/1i5beP3M55r6Q5WtMKa1oScMin+yDaiaI3T0J3pTn431ZXjgmRK6ul1ira2w2Nx0qea/DEJ73KRgNdEGiUTbQaRkJ4B6aamNkPciMqM9x5ErMDezgs5jyN2Xc1qT924FRBug5g/wTisKiNpSHPClCSznF/3YRItsKfOT7PX5gG3wDzmgurUS+ROgBslQSwL4CBtpodwoQ3zkN758VT+MNSMdLkibd0cPrkxkCkMLqYGHsS3C4Pu6Czvmr59HmDGOr56Af491rYQXeeuizwLFdCj1DWjvim+bEedCE8sAZPCMy/aQtAqyBa2olmbTQpEyWCsSIen8LmWqu81xjCL66iv37zyLB6aNNIvD/KSAXMQxq9g35moXlrzzd18O99FmD7C8t/k8hr5To4LjoJmliktRmFlGM+Js4g8W8iU09ytWPs1M8KfXG2Px0+G9wW0hAI84aqnwbL12i7Qu+4obBa3WQr7jlJJNIDJeBze6yzwoBT0rDXNS0PXJzLpFazAKi3x0/W9AWIrr3cns1JckbMlaFaSJ6Js2maTsTtr+IwVGV6D3/mk4qV4R+0qcPSFyn4EpZ5h8vxzr/N1YlGYXO//GBFI2tDl8FLjkflLH1GqVUX5eBX8fgzaNamNygY3k7xHh/jDG//bE0xmV83GmURDvtQUN1cTGVBQocQkQdWR7ait61AZr/TE4aumRvhncque1jA6Zdq38ATvF3vYzoMh0DlHrDJtI85qVwHabmkJnJjN8MQx+6QXbJkG+OKk7XAy5IEgCPQVpi13luV+luG9Wegs5CXBfUNO2G7qMZiTph4Ymv398jYjnO4mBaJXvXqM2M4mBctOz353BOy9j/YcwttlSSQSNLJs2VvqZjSO3yc2Fp+TsZfGD3OY0jO1lXHV/2sI6RVF398Non1Z2It0Okk95zITxXdskZ9C7L6eaEV7uT/4f8fPZBvq6WJT1GAE+ZxIYtGOxtTiDSkcXE5YSP2ijxM6qfNA3eREVpVZ7w7aNf4wvg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56090a8b-f800-4013-9785-08dbc9596971 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:23:26.4769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPOFhUBLIk3/JWfGLZRVzps1opfhxJrzbempI2DBSVlYptoHJpZa28fYuvEw9e1s4NP5KIvk/99CYD0sP+cODO9t17pPsbyLD3wBouH554k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3802 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found that execution cannot reach the expression "-1" inside this statement. Coverity issue: 403097 Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") Cc: tomaszx.kulasek@intel.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding_mode4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 645fc1e0d4..ff13dbed93 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -641,8 +641,7 @@ bond_handshake(void) /* If response didn't send - report failure */ TEST_ASSERT_EQUAL(all_members_done, 1, "Bond handshake failed\n"); - /* If flags doesn't match - report failure */ - return all_members_done == 1 ? TEST_SUCCESS : TEST_FAILED; + return TEST_SUCCESS; } #define TEST_LACP_MEMBER_COUT RTE_DIM(test_params.member_ports) From patchwork Tue Oct 10 06:23:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132456 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A19B142348; Tue, 10 Oct 2023 08:23:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8214140689; Tue, 10 Oct 2023 08:23:31 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2100.outbound.protection.outlook.com [40.107.92.100]) by mails.dpdk.org (Postfix) with ESMTP id 0FAF1402EF; Tue, 10 Oct 2023 08:23:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvGviTrLM3tcaXTd30bTsY1KWMwvg2RlWC6PE4N7GLRNuCgeSxb8PyjUeR1cWPAbdZ0rEpiniPQOPD3/PNkIa51d6abT/hXS6MDbQGARPi71NbRJeg38hwkNfXroJ+QIYHXUHgpAA6w+LRl+CeFK/1ci0ktRFiGwn3qqwqHJssQGBVYAlW0xOm+OWCUQph+/y/qgkU39sxRflWx6m9fVY3ZIcIXwYLGgN1MpbcdFQ+x+h4sPywsdzt7VHemWyIMM/pei9MWY/PmxbJTn1cQ6AdHtPm4gu3k9jCFdbR5KhCZ3aXHOPTfub/dlwTXII6d4+m7p7AxrL1lwmWk2KpxMIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZcMTBjOBUXnZ77cnxSIRhO9rU/je8w4p6q/F+HU+KU=; b=iFANgZ2zqWvtw3gRUwI+XiE0hhapxa6C/Tjty3CpiyUq5pPEP50Dou/aZP+SJRrHklE2tLuOz2ZQoWTOFLs3GA+LD2gTHqf1NKrSILHl03T5vK/Fs272RMZm8/yFAzsbzUpDq3n59W5U83+Un0EgWxRrFngqKSWkXb5DOGTTtHqL/PCL0p5Fd5myxRTxfQJeyG/ekN4nLnxpLnXUOIHYYvr+LDekQIpRH4sakWWoTFwG3hz2rj3ZUxU37OIem9NyXqDTsZGGwFi2YPPe4f986zzB0xjP+uF4mKPbVmjUaXF5zn+A2p5QDyEh1qEw+Fcbehd3ylGQQSbxustv+elV9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PZcMTBjOBUXnZ77cnxSIRhO9rU/je8w4p6q/F+HU+KU=; b=QNG+pltIyH4z8s1Fkbg8YpH3VtvMob3j5lzaQMj2nu3e7vs/iJnHhVCpdz2EAT+IKphUSL4RIPLcjcWzHRfjqiAV6GqI8iI7VVh23BeeyqCp0d8/2xrFcTivpvR/7L+3x0qBPf2fXsIL9CpGLvZlGnjVANvmffxPUZVEf7SMCsc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB3802.namprd13.prod.outlook.com (2603:10b6:5:24e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Tue, 10 Oct 2023 06:23:28 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:23:28 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , danielx.t.mrzyglod@intel.com, stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH 2/3] net/bonding: fix illegal memory accesses Date: Tue, 10 Oct 2023 14:23:03 +0800 Message-Id: <20231010062304.205933-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010062304.205933-1-chaoyong.he@corigine.com> References: <20231010062304.205933-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR07CA0057.namprd07.prod.outlook.com (2603:10b6:a03:60::34) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM6PR13MB3802:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e93b226-24e5-4377-2645-08dbc9596ad7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NBAflRnDqlx7W0S1kMzxBhq2qRGuRKuAUMvTGigoUZCchM+/1nACmEZSn8B2Ca9GJu2nz+00Y93BBVljq6BebQ7XjfQKmM0tsY7+ibEPBGra332siRvrn4HmaWdabQmy2bAQ4YOmqeYs5zL91WSbvMTopYeALthcbL/MPP1xFt2sdupP/xksSyhynX7hwM58BOmlsGGGRTPSWxqGiNPd5KPwO/RxPs7UPhdi7CMzm7J+dAHnjKV2Q+SCxFi7IkCqr6AGlnrZNMksfHOSwvjtD/flKlmyVN+dX4di88gt4S5K/adn8nR7t37AgxGrpdrIMXOLjNjx9bNWs+AxcqIJx6ZlMDeCYRRCuqAx+AymfqtaNwvgySdVPJXtjB7afQqM/qFBoi91DULqla3SaQ0YYuK0cvYVX31vfdkN4K1clFUQ49dZbsraT57E4NqFP+SUukS/qzgH8Bzwe5JQxpSaDkORprzL665SVZ+B4lfEPdI1UyZDbahNbCGpmG94gb8nVPyc7zxyfrAFM5za3+t43Ae2S693NSlgnaI7oWLIB10DnplVwzZp3iL6Wt354fdLnWgr7cRnh9CP3mSy+ydhi+yB95Yvpje5XfFo93TuK1pP7zmBI6GGh8unKs2xCSdqIvWnLVLiMs2zzp9W6f2ctNqT9+7oPZ42m3oaIPDAbUU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39830400003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(86362001)(36756003)(38350700002)(38100700002)(1076003)(52116002)(2616005)(6512007)(26005)(8936002)(4326008)(44832011)(6486002)(8676002)(5660300002)(6666004)(6506007)(41300700001)(2906002)(66946007)(107886003)(54906003)(66556008)(6916009)(316002)(66476007)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: i+J/k+xj7/sHz4OsYg7HntIF8W3gHNdkUk6zPCCN1eKoMBY0uPfxe+mleVaJ6sD6rtiZ2RhZAYaTt/Nj86q2FylWjAC1MI632km4FABLsfFUNzyLb+scNp79ExL2CuIURrI/1vcoq0MjrHzMRcsyPQ/u9bfDm1azBniH4bNUEt/xhDPW7W9+fCmlXX1SARcNFgiMYmDYOgy2QqzB+VXiNy/aD3tTFOJxdUYt6bTAr+sJcFyNy7GwfQV5jzI/D4jbeBFW2FkjUxNVT+dS+78q0GnYnsl/49PIJ/tzg1ZNOMnmPlrWQwtBbM2ynnUleNamks2mTXoLbpto5hLZ0l72yoKj49toMBrr6p5DLwbUeMH7qLimw9WNcXfcohBNwB/yMRla92dsas4USZHeoNAj3F0M9awojyqWjIZn1N9xu93OOQLuB2XOugtrwjZ1ixH1yf/UVHMnQVapycHjYUaviCxw6/EYqFpgxVTQgkn+kr1XmVY6zLP+geqYmn/CmfVkYl/4QGzEN5dJPP1wrYPt0RpwsODue3G0OKRInqQTZRX2RnNORH9b1wImV43SSEm6DG8ZbmlX0pscMqN9TGA04/DfZEjinvR7dHa/R88/3+41rriz6SnwDAG8EvVaAHKWC+sEnxlK+OQtvjESimOuK6Elm6t7sSHje4E9VcZN+YhUd3ckvfekmWlUa43oKIABff4QEfgy5L0yNVcvYp3lAp3zMQYijd8PmAFhxN2TzkrNNEEZBxI/0uPDcua5faT3c7uXqagNkmTjRgE7tXFJXDTP7ca+sHXbifVcq1rHbxoGpi6zcHS2Xn4s+k+jyPlkqjoN+Yu0IEWulVDKxkRcGZQ3BsHd9DnydF3f9sB8IMV47kIvKAe3IUU7euX78Vu03IOtAvKqLcOkinKwmR+MmZf3M6DnxWbt+oSbQ/LR3O0R1aF3JCmJpzbfzIQr1JcgozrqPMg0o13cr3q7C3R4rJZBB3T04VuySdS0OmyPyHnufvdPTnJuy9eX3kUaCbB93ELgPCZ2vlY1pVUbzYP3rKUY2vbeu/GwUWpzIubkTSPVLX5Hnmt2ZGO7q+7X2ckvxAOotLLzgsgF++uI45ERQqK44Mx1iPYHHNqb3DEkJQicm+Zg2PTjv8vnV/imJN2T+oZlyPau1j1DvFtOFr2ST5zF8ZzCbPczL6a6yF3ow/ZGuZE+Oj5dkawhCU6Y9x/ab4TXdij6k5sZZ4fHTHqHfBKRyy4Cij4yu8yMgOrYp1gJjqfrUgWRajQrRpXOeg3nSoJfB1/hgKTUvT40GhCmk9ii8AFs15iKZ5pxWrwqvyyvuZ+p08BSGZajOT8S/HqbuAVpm+BMnxfbyBSrj8X+2EMDRGA+wRIf9xbbRQFKqFJXpx+gL12Zr+AKa8fqtDLUPJ7zSsC9eTCgPmCSStuZdc7zrdoTXiIyciwS5jyCDnslOuxlzdPnQda6mtCQjk6Wu9FtBt9/jZu+PzMmjLmBYppm4ptgh0g4EcXDc26UUT/oK2xVkISiLh2bEUa9TYkVImvSiNRWfIFWz8FBxpluak+StxdfCx3VGh+D+oEx1Fl01BeGngU8lH4odcMcELSx8N6irx0GxgCtp5UhKVM01g== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e93b226-24e5-4377-2645-08dbc9596ad7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:23:28.7569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tkyx39c92RYy836GAqs6MO+DqzOEx0D5JjxfZ13AzHcJS3/4mBHk6/xMCJ85snsakHZiKk4V3IZavrqgl4J6i2zq36Zv3NzqWLa9UWLxUA8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3802 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found that overrunning array of 32 2-byte elements at element index 65535 (byte offset 131071) by dereferencing pointer "members + agg_new_idx". Coverity issue: 403099 Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyglod@intel.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 677067870f..0be33f61e3 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -732,10 +732,14 @@ selection_logic(struct bond_dev_private *internals, uint16_t member_id) switch (internals->mode4.agg_selection) { case AGG_COUNT: agg_new_idx = max_index(agg_count, members_count); + if (agg_new_idx >= members_count) + agg_new_idx = default_member; new_agg_id = members[agg_new_idx]; break; case AGG_BANDWIDTH: agg_new_idx = max_index(agg_bandwidth, members_count); + if (agg_new_idx >= members_count) + agg_new_idx = default_member; new_agg_id = members[agg_new_idx]; break; case AGG_STABLE: From patchwork Tue Oct 10 06:23:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132457 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DDB642348; Tue, 10 Oct 2023 08:23:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D5BE40A6C; Tue, 10 Oct 2023 08:23:34 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2130.outbound.protection.outlook.com [40.107.223.130]) by mails.dpdk.org (Postfix) with ESMTP id 8534E40698; Tue, 10 Oct 2023 08:23:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ekSAOnte0HdhaQ3iv4YfcMa861ASn+iNTHJVZSjn3Xok23XeYLQpTR99QLK8Wy5kDktV6PzwpyHWr2j6SpGw4xpijt6h0Sl1LPhGpVnnEr5rzyc7oJ8fn+i/q9LzHk8TUFdqV74IN+qubXJFpMaFBeYkrIAwqc6ljLGnjoev01AxkcalE2p+OBJA4j6deMpgDweiyVcZSBVwR+EfVCYzL/gUG1kJMilPGYRgwG3GSNUiV+fyNLDYSDjgh/sGmb392BzYIvuvkq5gDNOxlmXG3uLZBHqN1tv4mOp1phKqvk9DvNVN2iX4zpzhhmysbspw58hjka/mTK43My9dzklnfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PA97/T5hzQ/61NQeuqQP5D5HFo9PVlvwoK/oGoX76+g=; b=Zbhg+33aosTX5F6Q4tn+UBhgzL+vfI9X+VX7XwM0u5+KceWeUtrSTRk3YVD6vZX3rbTWjlh59AdlindgCjRuee/XDwuAwRDQJhJ2Eu4HFXRVcbg6L4wWZKRmaOZjEPcYkPyyNcbV9Qnmzt7IzhuFCj0OsqVNa6axwGmcvkU9mIZmtEbFfjitwVaZAUzug/KK+y/fl6F3qYx9Qsblyx2Zd0I2JaZQeAQ20v4prOSOvIkV5UKw/VRHLehufjF2tnIH/EMcRTYmdD5gu3lKN7vmIbtoPNXrG9/W60jUxY11JfyKfbY+LtR0oAk310avcJ2G5KLbIZTiOj+0vpo0p6H51g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PA97/T5hzQ/61NQeuqQP5D5HFo9PVlvwoK/oGoX76+g=; b=M7QiJroCN3OLELuMzL8Vrwe6kSK3qGMssXgjptDPa2RVnuRU/tMvaHo/QGAU5UTalTcL1PfpmlwjUpCwsezayqGieJMx6DT8toY3jXAzFKiL3TXvh6oS9gxNDa8wlYnV5aY1VG7yo3CFyAkRx/PUoDQaeOBn2lEqwUZeOA5zFKc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB3802.namprd13.prod.outlook.com (2603:10b6:5:24e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Tue, 10 Oct 2023 06:23:31 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:23:31 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , declan.doherty@intel.com, stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH 3/3] app/test: fix checking return value Date: Tue, 10 Oct 2023 14:23:04 +0800 Message-Id: <20231010062304.205933-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010062304.205933-1-chaoyong.he@corigine.com> References: <20231010062304.205933-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR07CA0057.namprd07.prod.outlook.com (2603:10b6:a03:60::34) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM6PR13MB3802:EE_ X-MS-Office365-Filtering-Correlation-Id: 93e80933-1e99-4d2d-c9f5-08dbc9596c30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J7dQW7IrT63I2MEor9w3Jwh72A3DS6JfI6Y9Od58mwokhoYXs886cqCRu9FbP3SmlWKUH+pCeZKUAEMmQWGjLCj+1G2+1/hCeM7536gidG8i8fYUdtyuCBzdcxkiX69FboLEJYuEwW9We2CeHypII9wgzg0Mh0IdGbeJRhFoaW9zeZezjbrP7xxf2JK7WeXkO/xmlCAc3v3NWeKj6iuYQUky8ugUOvC6bwXFBLbwHyniPNWJ02nAI/YG28K7Lr/L7Lrv+/Uy7NtKmpyql4bZLYN1ZnLBcF3vMHF3ROll2g2b3sywYCNRnOfQCn9RKYtUC/IsJlm2U7fhN3nWn/bezr7SuiOeIropm/mjRsQr/SFtThbEFR2LMR2SoEa07vcOaigOEJdO02j4/rONBC3y1xKpKRMGl3QvhZQBOr+zioELV3Z5p+rauwXuXFkjq8bEhWg/G2nKt1e6buzIJwuxjHKoFdrM6GM/IKm2ygd8/9v4yKkQCoWLRqra13Ef4k2yttX2FYOFruyTx9ajXRDbHpbMX1rI32/yMZ+O5z5RifzvBYLP7X81Zbt7wVRQ/tfKk25SNDPhBDLtK2EL8KZgL5aJCVBUvTzNXDFMfth8pg7RFOeHEPVSuyR3Nh0OBIBCk2WCSR5gc+c3EQPLRtsQCdICQ8WqfsLUUYWSKVLap/M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(136003)(39830400003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(86362001)(36756003)(38350700002)(38100700002)(1076003)(52116002)(2616005)(6512007)(26005)(8936002)(4326008)(44832011)(6486002)(8676002)(5660300002)(6666004)(6506007)(41300700001)(2906002)(83380400001)(66946007)(107886003)(54906003)(66556008)(6916009)(316002)(66476007)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Z3luRItQ3xQI6P4riw0mFm9iw8u+QQo/y3M/faNMustRZZN9WJ0JPwgKZ4gjMu6K1lnH1JMpXeBcYapwAw8TmJdyZx5dKqDoQWgU6jCkoa3TZeHEjyuvspPPlDl3jlFjBWy+mJuwkw4y6/d2pyu7fZjPpdgYLqcW0lr+fBw3xowB7tgBpqPcQhZhvTSeJ/j7qpT/2LQsB3J55QUP+m4mHbOfy3SPftGejfArRbO9M5UNVo+HT0/e19ZTqlRa9p+PU31kBQw67qU3VCa6kilkAEPvVst2Epx9gt/Vqovl6FL75ILmzsEfkCd9J4lqT9EuJ5DhWnGS7Mv/GU3NbN+kKRSZtAINhJliQuC2cBrgLR4Ce4EGHeWco63bUmXNynr8AFG9+j/oh7/cz5B1CnaF1588aNGkjZlQrYQKf+2V7zXIbCzjnOHNrDghxMrOBbqCtU7lV8LLvAIugMoSUFV5hzhdf495UMvf+bpgkw002R604CwtLZ8/4+sb8Il4577nFqGVrRd40YWqX95H7zcYeWyJp922mbqf+gqKNJuWU2xLM8zodnLEFykrZYsI54Gm0Iq/HPKrdPKOJOpWZT6GAWaijJkq+PJMCwAsue49K/JzNB6vU4WbtR1ZRXQuY38jjSUc8Gbbwp5cZxrix7TfTMnCMh30nBqNsMfPGaiSKgn8je0cCXwgPOXKCaBGDbESbfK7VqmE1LlAOpW21NI8Q7Da33R65SmbChTAiU089TQS55YwTo1Oyu45qVKJH6qgzr7yKhKTxW9ZhPUS15nLQJ97T/dwyY5fSxyHyV8AhQjgjx0pZom9fTB3/hPC6jo2ZNg3fzIA+WZVRPSR79Yo86VbdW+bTKtSsOYpWjPlUeK+zwjY7lfHosj8Q4f/ZQJRCB202BrGidsgQINZ2jBx3JqAarQc4HjxE+yL4VMbUgfydeyGEOYg2lskW5nhziWr8xGCbTGM2Gvii/yQWjgk4qTdqgyKWGQFrO1w+TKg0ctjuRMDdZN3LqmS58QlKpzEMayBujuXmhukXymJ6eldCxNc+YztI89dHqcHeItaZ+9mMSOJybxn/c97l+ztvAmz4cQP3mX9SE2oy/Frb2JdkP0wRjM3HA/iEWg8u4XQq0shFMKMA+jlxUdTdUrARGm8PY0PxJBLvXtDhe3/+QdRjlZhcs3UDEuNmn8iHKGMBY1xz9DWha6227aQ5RdHsVnpF6JdywSAZehxy7UpZcKtEN7vAYM70HsfC8148I4s3IF3z1C7jGzVcMYe1s/K0hkcCshaYRcVb7aovx34lbXESbcv3SE0pBqkC0FKKhgW+4/JHBQ/tHay1qBhFcZUrFw968QwpmOQfKdkY1iLlN6bwpEMkO3Qnedqv2YIHjnN5holtdnvJAO6KxBl4dceJCKHFgzXp49uKEzej12TIeaFIluUMNHHRKHkiReep6ckwc37G1eCQ+T4K5M3iyvsZD9P5DN3huf3njauytiiIN8L1CqvaaNZhjn+DybeGlp9yMpBISPbJUl+7RUuOUJnfVmVpvGPuvhy6sLEmw5a0d2JaPser0Fofz1Phsd9EamN8R+8ORoyWzylV1hlsemX7ZiTzYVgAMCCTTuxNOPRKTCvjQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93e80933-1e99-4d2d-c9f5-08dbc9596c30 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:23:31.0242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NlwY5vgDCoBLXf7dKp3kaY76VAFTt1yT6EnLlgckNiWp7oZ7N8qEtDrEvuec/QrKCG9b8b7jvb14K0BG4h5mdx/lZjx8+gMi9G3qFGfHMwQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3802 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found the function without checking return value in this place. Coverity issue: 403101 Fixes: 92073ef961ee ("bond: unit tests") Cc: declan.doherty@intel.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 4d715c4465..4d54706c21 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -449,7 +449,8 @@ test_add_already_bonding_member_to_bonding_device(void) uint16_t members[RTE_MAX_ETHPORTS]; char pmd_name[RTE_ETH_NAME_MAX_LEN]; - test_add_member_to_bonding_device(); + TEST_ASSERT_SUCCESS(test_add_member_to_bonding_device(), + "Failed to add member to bonding device"); current_member_count = rte_eth_bond_members_get(test_params->bonding_port_id, members, RTE_MAX_ETHPORTS);