From patchwork Tue Oct 10 06:17:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132453 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 785F742348; Tue, 10 Oct 2023 08:17:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BEA6402F1; Tue, 10 Oct 2023 08:17:50 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id E384840278; Tue, 10 Oct 2023 08:17:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQMURM9D2ELB6h9a62qTYym1tjfrDOTc1XUJ6S6RalsvZPVLZO/edvnRFrhdaNwwF0OZ5R/Rq3iZhfVZ8sAreG3HpscyxWtrdf189Q4SDvZ4yqK9Xisssl7XqqZ9NuzHfhtvTaX05wpd6IoGDTSeNiEDdX15DLZE322/G3GGyF1LYGs7cBr77RVSbORTKca8XYkkyth3Wmu6Br51HjioiR/RiobdCc5rL8FhVESHeCDuqZ2oM+cr8galgKDE/8Q3lvglfxQk2JZtUQ6VTBN2th9IsIA2ZGgppSjaGRAhG+pWfWfpIeEMp7dKUeqcoHaA7oQFbZD7Fp5JPs9xGx3RYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rI3D5c9g2+u36RFoOlyGgUVpbe0J2R9vlbQ/10H9P5A=; b=nwhplDytpnT/+KFnYDKqG4hzZXHBUc1iA+jLiQHSAqj0C2xlT3CohmjjcNkHs5tc5YOaBWIrJ58pvzab1zuYZxoCeA3d9CCk1dSuBuIw+iRYGMfxOQnaSmBvfpwG7AZYFockTw8NONrET+pP4IKV7VFnpuiXGmxg1tPO0GnJmkqMQDPpVjqZHwjFY9Ax7NVqeO4n0FpTjkB3RbnqSJDWnoLxXzzKgMhcUsKZyQbQF29ydAwX2jlCJickr1gcn9HqrNN9MG8U+5JMPSs/DQ7mgy9WBTnO3z+1ubM2HAIEIUkjM+YWYOfSm6grR+lamfOyMJ9j0GdedtssVNbf0Cr7yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rI3D5c9g2+u36RFoOlyGgUVpbe0J2R9vlbQ/10H9P5A=; b=voPBIK3/mbj8RD6t2l7A5R4nnPc06v/asYzvH9+G0yD0JLSqDfhcpw8g5qxCKwHVjM/UWno+RCpLqWDYcauwSO7EOhdfByMPS2vJ7xGjGrgBUm4wG6foI14SsXDEoszlGxDcnzStSlFS9IamH1caE9sFuKuREXKYkFMurDYd6Uo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM8PR13MB5192.namprd13.prod.outlook.com (2603:10b6:8:6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 06:17:47 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:17:47 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , chaoyong.he@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH 1/2] net/nfp: fix checking return value Date: Tue, 10 Oct 2023 14:17:26 +0800 Message-Id: <20231010061727.205886-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010061727.205886-1-chaoyong.he@corigine.com> References: <20231010061727.205886-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR17CA0023.namprd17.prod.outlook.com (2603:10b6:510:324::24) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM8PR13MB5192:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a03e302-d6dc-4fb6-b83e-08dbc9589f7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rvOAfz5QXi9v4Vpn8mzb4H9q4QPzfedAjqtlnpcrPfksUm4n3w/ZJiI2AZdO34f1wny2V7M0lL5ZlgP/lrGZ1bw/rRzJPiPy9yoIizZUD3NfILJ6+N5ngc0EvYeIAZYdrl0/XgvtPNgFcjJKFfdrZ59f1cyW2hhyaH6HOVAUsvZmDUvpfwSl5Ar/L8wgxKsjpEAqxXjonrW0Aq+XwSw8jdhSGPOX+IIjGeqrQiN9SvhJ2fOWTezB9GSiAogEmbfDf1wbWJAqsgCkrilNdaDMc5lHp83nR2q5ht7wUyflI+6nZDD8Dfx3zS8RSHrDFaAWP2nW+WmHYeAMJ+Gz58FqlXZWMi5oyMjJ+QrTtTGA9g9PyVqHaP/SoesWZnTL0gWg6Vm0TCsgX2MyMlPDmEuUnb5th2ASBYImJQbvV/F0XsESHNP8mIayLdirtJ7jrt1eri8mdUSWXbCVJuXeE89F0WJ32EBFCKZxIlHlooP37R05nVik+IgBu2oF0VFx44Ul6aBRwRrwJTDn1DYx9pfQdl/NHf2xqlghK1VU6DuV+90wpzH6RSFPTnp36fQNW7UKTr38ul+8g2VZfeqtSiKWm9q5tm9Cy9Y4UoPLnrx2iNPzI3CI0usj/ogtOHObh+QS5hGm9M3ZURRpRuk75a1TKAqqePKPvVfxjwLJQ26nw6Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39830400003)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(5660300002)(450100002)(41300700001)(8936002)(8676002)(4326008)(44832011)(86362001)(2906002)(52116002)(6506007)(6512007)(6666004)(478600001)(107886003)(83380400001)(36756003)(1076003)(2616005)(26005)(316002)(6916009)(66946007)(66476007)(66556008)(38350700002)(38100700002)(54906003)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SF+c2PX70t0soQvQUIdI+ZRf2wcHF2L0IpRrzUWHQ3+fZbd6+WwObRh2aPIdBn/QFgwJPyxHB/XYlImP/59r3EifauV7UQObWReXRQpyy8kbD7/iNibE7uQWDZ3ssz1EOYQvKmm0p8lTx0yU8MVuUejmRiG+/dDTuoxyDk0OXrcnsGbH3+hD3OFn/VembvGqqdnRIoLgVHsocCowenyHwbvsKNk6Epu9mUUNIEXITWYdAlbptjHzwIIkL1FaEJE4AO+E8MNu16/wSLk5tCUfP9rcMDWfO3mEa/mBiOTlgtcVu4Z2Y0UtNHSHpHk3YseCBMR4nH62H69wgmJTQksJ7eLnDZGOBZdXlEIYeT6jNQw/id9rsKHz59awzrwZ8Ttwhwj2cSNcbQU3F2qeGDOZohxB+ghQwudpsGyYC0vCam1Umcfjxh3W78vY/PgzaK1tWz4dyEbn4YjiB/QJGmq1pxKteeV1zoROVc+h4d2S2meGTe0Os5QIlPg23Lcwjk1t4u1fQBsGhBNSrDYGvqSFugzCelLphI/g5orgpn+UIkDBVfBscOo237LLRTjGSVVdcG5J0yJwj9WAZp2kptehQCDW2yVRWu8+LJtLHqfIzbQn4HGJuNM1O9E8laVw2JpisnU+sEKbb4amyyYc8JT1IYeZCHxiEwGrKKAkHrxVieqxx9HPTTY3x8t9UJbgzPyP7BYLtmcfBAUT6vgsmRGv3mqb0JbP0Dpwgbwlen4QjO+qfFbIO39SR+S2IZlhupubvI47rUdzl4DfF/Om00W6Yk/XbIe2/5fPSMs7wr1W2s0ZlOmoB/Kk8jiyTYDljB/UwsYgelP8+FUbfJ9hiGTB26Cwr6YF3mm82jDtpIRqpx2ua8kleRTO4P3thhbPyqDowEJDulj3JpEw0qmWTBLPEjzrqxV1MIvgFxtlZpuheFz8b5GPkPYrwKBBq2VQnIb2RaQ206wtLSTuZyqxYXj71ESC84JF9w5YTskncTlsSwa3nfDYH60IRcXV8j6rxQ9NGS4aufwMg28SPGYBzu6B5o9a35HVNfsuu0oc7I+Y/g60RzgMwGZK2lp5bEm2RJRFXl2gU+F5lhWY5QzfDzd9fP6EKzbDjSZipbX5YuE6VOgg52QPn3NaeGx2cExM+m2fzobdFBhmlORSDMg4LfLiLWH7Rpvf1ySi52WoXT6FnD0PIpFNtWc1XZLGvk6p7oQQUneWBqL/IXdt12/d6qEjO2Q+iaz6L6t1wWy6J8J13x5D5vMVpoRgx6Qk8L9+L/aRuScjVvrtmtQrp83iH/Oh/GmJLVFXWZXIKcyZ7dmEB+Q/ysjvnc08bq8AswJcRClrtUVztGX9C2DwF5Q9wutA1XO6WLuDVCyQ7nMNRYVCE8EaUWb26KEekqNhvlgzTd3Zq+75Q0RllqlKScakL1n0viX1qh8cSfKsSRckvuo0g5lEfeZwGVFHH2Dqv6M+Kj3FgMMwPIp1krcqNy1yDHVDkk+1BeXQVfIxWfgOtX6GFinB2B9jvCE5YsnNj4qEBClLJTWY5Fh6Bu6WEzsFvqnhH8W+APe0geTnbnrAFDbhE3bWeql9AoTGu7TGdxF03o4GzafTSVMdMMYzaK8KzcJnDw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a03e302-d6dc-4fb6-b83e-08dbc9589f7a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:17:47.6075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yKP/F5oXn/HJ2b0fXRF2hdXruvPEl9H8xhIwQSIN6oZlykgfQssp11/nrzFKa5Wo0MM+jUq3uigyeh60tb2XfVTuTNpusnVee0qlSBoxg4s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5192 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found that calling "rte_pci_write_config" without checking return value. Coverity issue: 403100 Fixes: 1fbe51cd9c3a ("net/nfp: extend usage of BAR from 8 to 24") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp6000_pcie.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/nfpcore/nfp6000_pcie.c b/drivers/net/nfp/nfpcore/nfp6000_pcie.c index 13cf523506..a6fd89b6c8 100644 --- a/drivers/net/nfp/nfpcore/nfp6000_pcie.c +++ b/drivers/net/nfp/nfpcore/nfp6000_pcie.c @@ -214,8 +214,9 @@ nfp_bar_write(struct nfp_pcie_user *nfp, rte_read32(nfp->csr + xbar); } else { xbar += nfp->dev_info->pcie_cfg_expbar_offset; - rte_pci_write_config(nfp->pci_dev, &newcfg, sizeof(uint32_t), - xbar); + if (rte_pci_write_config(nfp->pci_dev, &newcfg, sizeof(uint32_t), + xbar) < 0) + return -EIO; } bar->barcfg = newcfg; @@ -379,7 +380,8 @@ nfp_enable_bars(struct nfp_pcie_user *nfp) bar = &nfp->bar[0]; bar->lock = true; - nfp_bar_write(nfp, bar, barcfg_msix_general); + if (nfp_bar_write(nfp, bar, barcfg_msix_general) < 0) + return -EIO; /* Sort bars by bit size - use the smallest possible first. */ qsort(&nfp->bar[0], nfp->bars, sizeof(nfp->bar[0]), nfp_cmp_bars); From patchwork Tue Oct 10 06:17:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132454 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3319742348; Tue, 10 Oct 2023 08:18:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42E5740647; Tue, 10 Oct 2023 08:17:53 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2131.outbound.protection.outlook.com [40.107.237.131]) by mails.dpdk.org (Postfix) with ESMTP id 62551402ED; Tue, 10 Oct 2023 08:17:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5Q1hPVv3vg8+DY04Aimuxr28p3l8678m/RtePxtX6IDufaf+MXb1DD9iZnfYwjeZbSK89066JUTDmri1FNl1+Adbgnx/nPh24Jr4/ZOT511BIBAeXqQrWKZEkBSBWvv65IbCruWVsTbRe77r4eNi/nwVKX7yc8dI8ZBHqqZxBj2S0H3T8fo4rcv3meZCW3NsG6f+u9s9YLVK/oLxU36BuRUIcxR7XmMTlhvwdgOViOyY6pHHafeH9sYtDzcot71z8h/xSBZ9BdYwALAG4T8fufVus3R3akC+Qrb2ItHXIYsrjrHovSZCJAINLxK1bw3sxdrUkP1WecpW7KIKikLnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0zispk8LqIxqTgwPA4y0RMIKingI/al6FObor/+/E8c=; b=l+fpVbmoHHzG+KUDiw8Lzl2v7AcZGXdGwF0ARpbNFEairHo87VnL2SQgR7jEIAs3/5MrSGObcX6Nc/NM3VmI1wId9rTLYEtXcZEkTVNxWfDgItsgFqweFzWX0mQ6oZ+yzYZbsDcwezrwNtfrlLTgNLUO9eV2uejp+J2GK7O12+dTPMb3Qrh91YBqa28OfhwOXJqHIv88KifN9izL86sCQUvTK7gqqxTJ/aQERCrIp58jzveogv4A/wrh8VynngfeM01a6UAKil53fwOubl6sI/4e2fGqgjZsv9fZEcxVfRlRHfjUZoRBNJbnuL89gfJRJM4Gbjt9oAbttWUQpTIO9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zispk8LqIxqTgwPA4y0RMIKingI/al6FObor/+/E8c=; b=daDD9L7llcHo8LoRRq4YRG0JsFMc+D28bJRBA2U1u0u383VxMFR3SFV68e9k9R1GGTtTQ6CZTnfc3sLTnjSpRGYEdp6fnSbJvetBHTI8+X0/HUQTbHa1FLegLOMrLGj1dIBrSlxMs0voixjMD0EJwg5jQP7iIw1BNzlkplNmcHg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM8PR13MB5192.namprd13.prod.outlook.com (2603:10b6:8:6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 06:17:49 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 06:17:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , chaoyong.he@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH 2/2] net/nfp: fix illegal memory accesses Date: Tue, 10 Oct 2023 14:17:27 +0800 Message-Id: <20231010061727.205886-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010061727.205886-1-chaoyong.he@corigine.com> References: <20231010061727.205886-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH7PR17CA0023.namprd17.prod.outlook.com (2603:10b6:510:324::24) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM8PR13MB5192:EE_ X-MS-Office365-Filtering-Correlation-Id: 254f8217-4448-4f99-5be0-08dbc958a0d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I1vMFotZrzNHkJyxP8vWc+UPAkzYSTTcZHkbW540qP/c1p2950yCwa0vCcSzqjjKlpwkulYsHUJfc50QFwqzRXj66MVjLFgiTiYzfSyFnLVZlcJPN95FMIhW0PnsvdmKnCvBRr18smyk5en3cyvNyWsJrkQ1s6P3ujXmyLHnmwWtGMawh9lOrEgknWkGzmrAIuec8C1i9sswqf1PGMsITdCvMcFamOmvJUNYpgv0UHdOsRmsE1iffst6CKqGktBE4QClxNOmqI76u6tiL0ASEfOp0V1g1IUT6Jb0wgSTuXTwa3gDASkGQSU5wttG+sxHmgzH0FDv6soU3drBPI+xxN8JKwZV/NnS/aL4vhy+aGyNTwOhZnMJ0C6/Azs5MB07EB2/ai+M7Co420YkftBMU+M64IRJfZEuLkQs75QtwXpbfUDTxvKocoRrEbL2abfTYF/vtq+C0k2iIVCvW4GWC7v/C6PbOyI0bA55bOU3Otyi5mNBYHrEM1jY7vfRLyadwQfA1iLoeE95RyRzxRW2z7J6sdncPmwd2MVgKULNDqSHifivtjIZQyw/EAigXFV12aVmUBSt/NfiWeReLa3hgK2UDDI0TvB1dfi7LiMtF09G/EH1gAShMPFkSj5cToOsMsPKiOp62jArLl0WjwqxGnNrTzEtbPrNvXne2ST6b5Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39830400003)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(5660300002)(450100002)(41300700001)(8936002)(8676002)(4326008)(44832011)(86362001)(2906002)(4744005)(52116002)(6506007)(6512007)(6666004)(478600001)(107886003)(83380400001)(36756003)(1076003)(2616005)(26005)(316002)(6916009)(66946007)(66476007)(66556008)(38350700002)(38100700002)(54906003)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hh74oGILtISbtblSd/YNi7BRvnPuvWDOKr4Naomw1WvUQqsBMhrnFMv0vEjpI3IpgGoYOSZ5wUv97iFlTRORuQRnUR7f6jAMRM09/U6KGQQ/prfbTh7VgJWUXWvY5gvsc3pV+uGKp1ecca2W+nHb44D6PJ2YKAumazN+LWWdvG8tKREQEIdUPvuqdetJ796a2GaTJabMxiZ+ab6pY2xbAtLxyfKAmpVDLeZoealzaucketH8+LQ6lfOT4aC+At4Hjn+sOAd2wbZsUUs22rJH9jVFFiMds5nhRDgEJEWsQTUsXalaJf3/UCRsU0ntI/ZxEwoX9sNi3uwSjsCPFhQMifLEW3q7MXaNKeBMaWYYXfK+jCFtDLlumVDCVPhEY+2sE4oKiRxbiQQ6WrU/KUMrV8B4cOv1tZBWjZoHHOJ6u+RC2ncGV/8PIahlDWK4pEMa78IcnUxdhT8RnsPaz0hyd6H0RYuZoO52nDSIkNCkinI9+ZyXk/vn46AkLALKqUMryqc+af8Gol7ILnOJ3NEUspNlzdlAvZG+ruQHswHD9br65lchYZ2qVt1ZA4g/10JEoyUERsjAO41Ffzp46vQlM2z1sGk4cHb/Dp7zz29nT2ThCNfU9n0j0rFoqC686r61KpRexjwn8jQqx/PGs7b2otkzb2HqThyD2osoyykl4OOfnr9F2ZeASG3hwbW8+99CcJZs98EioMSVxebv7BnxNt/6zmjqrAMmczXwmJuFE57h6TXeHpKhCL0i0nBWQ0limtGE5lCZ/2hbYCuVThScD1iYto8I1UKVszh9Gt4QgdkE74PUp0DHDxQqSx9hm+PVLOZd7sJwy1oQFTpQUfgnU3jOiiTDvF2zVmY8JWlnus7DpKjN93OLugXFdYSR17sdZenw6/7g6JMDQeolPLUCa0hQ+hZnt/W3Lmmzfho+/qZshVHsuFjSyJ34aEysJjrVatE6ix+mHENZ7/HoTT4uP97cIcDBhwqLnKSl+S3IXZD+BEZuef/kmSucyEbfcskZVD2+Z/pm7K0le1HqA1g1uUZpg23nbXk/T6qfEXpgthZOEKOAaGm9sxnzQXsTzB5njEH4gQlx8RWZuSim/IDGt8Pb545c2aUdibGb9yDB/2nbaUUadgeiNNbPeu9Dt17AZ8O7j09MzkWSVW7H81lvHR0Q8oLRnEt5JCwDg5BJI8OzcZCxzwDPJP7L/9+mpVYSMy5QhOK+dP6TBqefGNWWXXmLZxQTQZE3YkF6iTeCAwbWgsXlwq7btqFwRnSG48foWg0rCbFtd5RE3PSDo++PQaYqs7fzmkrD7MbtjcTdEqLgnhBs9KId6AnauGSs/HpBVxGN22HEMa3Ne/zqlsJgZJQS74lMIRZJwe3zpm/Hrak5pNx9hT8IfK0VKD+EJQH0IDptsT5ZmykuCmL2DRIl7nLv+Kps3lq89OfCw09YjR0GkB8IZhpGVg1pIEfAjimW5XLE0cWSx3qpTbcHHS/J/+SB+gAyXzDoXlbWFzZkNXqrxR4GGFGtyCDX2a6G+y8h/zMA0G5gZI5RC+wWuxVzZC1C/fBB2dN339uVAseh0Thg2AfNbAsT/EpAjnmNhdW5J5Y9W26jo9Cech29PIVbYw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 254f8217-4448-4f99-5be0-08dbc958a0d4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:17:49.8555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pkbYaT6DCKEimdSQkyhsGWpL+bi14Mmu+GQFb8kyU0gUriGGUjORqqVdjqqLYXQ+8H1ARnEnayO/KDdoqr7qfvZa54u/jbgChn6NB7PDmMs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5192 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found that overrunning array of 8 bytes at byte offset 8 by dereferencing pointer. Coverity issue: 403098 Fixes: 9641a2d ("net/nfp: refactor rtsym module") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp_rtsym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_rtsym.c b/drivers/net/nfp/nfpcore/nfp_rtsym.c index 022753f98a..5cefbace96 100644 --- a/drivers/net/nfp/nfpcore/nfp_rtsym.c +++ b/drivers/net/nfp/nfpcore/nfp_rtsym.c @@ -337,7 +337,7 @@ nfp_rtsym_read_real(struct nfp_cpp *cpp, size_t length = len; uint64_t sym_size = nfp_rtsym_size(sym); - if (offset > sym_size) { + if (offset >= sym_size) { PMD_DRV_LOG(ERR, "rtsym '%s' read out of bounds", sym->name); return -ENXIO; }