From patchwork Wed Dec 26 11:33:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 49273 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66AE55F1D; Wed, 26 Dec 2018 12:33:50 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150077.outbound.protection.outlook.com [40.107.15.77]) by dpdk.org (Postfix) with ESMTP id 6F97F5F1C; Wed, 26 Dec 2018 12:33:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=54b+Opv9v/MoK6CAIpl5AIznzhFeGWLzbNhPazFiqNI=; b=UcEzZ4x0OcbNHBYkWT5DPwulmd9jiZmeL8xb2SPK+si6YyFMy9BIY/0JcqlZzX4+ZJQFN9k3jOius0/Il6XqKAEcqQzJFpmWIr67pFaiu8Lo8W6zDZZaqH1xz2cs/ASZNS4iO2dW5w7qUsGzCP5DN+WZEZ9htR8Z1gDaWj6/vKs= Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com (10.168.147.150) by HE1PR0401MB2569.eurprd04.prod.outlook.com (10.168.148.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Wed, 26 Dec 2018 11:33:47 +0000 Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63]) by HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63%4]) with mapi id 15.20.1446.026; Wed, 26 Dec 2018 11:33:47 +0000 From: Hemant Agrawal To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Shreyansh Jain , Nipun Gupta , "stable@dpdk.org" Thread-Topic: [PATCH 1/4] bus/dpaa: fix the logical to physical core affine logic Thread-Index: AQHUnQ7dxAyq46j08ke7/Y17mXhCpQ== Date: Wed, 26 Dec 2018 11:33:47 +0000 Message-ID: <20181226113321.22279-2-hemant.agrawal@nxp.com> References: <20181226113321.22279-1-hemant.agrawal@nxp.com> In-Reply-To: <20181226113321.22279-1-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.30.134] x-mailer: git-send-email 2.17.1 x-clientproxiedby: TYAPR01CA0228.jpnprd01.prod.outlook.com (2603:1096:404:11e::24) To HE1PR0401MB2539.eurprd04.prod.outlook.com (2603:10a6:3:83::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0401MB2569; 6:w+2oNkPsRvOodKM1r5el/kzZABMAczSGKEn5lWrjkY+7eKJ7Wjf5AS+9XOf71Xv0zrAv4aQmhaYHoQCUm8v5WANR5nV4FI6+TppZ+r4my7t7tAu2bC1s5fYxW+9H+X5IeodNCflRKP+UWE/qoWpALjQrtrHZbyAVJW3JMYKvWGRMR+cmE6a3uRwtpowE/CIFxPczYRMoGZGBrHZvxbmnMYmxixo1Cpwj8Gwa1exDPCCRELzDtjLbFLeCqFC5hoyBDH8mhWscX0fPbi97Obf+cTKOTLWMn2ufgbtg/KjJgL4gVx7gFFBqY2kZDzZSDz4qYAe/EpEdxdb8N/Z7nP7452EUqv1BJTECOZQuMHxQ0gCkZHHPRjzm8qTuUmR0blLgKpKcYF7PScPAydmDeqxJlUQWrmYetiKLkL0cuZwbcznD35Pxn/klGlEjtmXc6t6uY8Iwox72ib/SRA5mBdes/g==; 5:rCuhHr16W3m3h8SM6uVwHYLyaLLapGGkhX4c6clh/yhfCSYm35dlTF86r7eDEuqmqVALtVokJTHS0lA9+YuXo5tknsMiJmK6WW04MOzjUJrMsTXlCtQHs6TZmH0zn4bGivENlRkSFL9fuE8Dyb7+SdOfAq6zNhPa1AIYpR9Em6Y=; 7:cbHqkj+jhqKeHHNckgV3AL35coojRibJOhr25fIki2SwjbPJQ0NC9f033Pq3Kyi/CX99e2GXnS3c15AaRxHEIzAXsCi7S3RZlGJDUz9NE+IUFBynAhtjdwFVvVG0Rs7rzzmvpKwCM3rq5V0kyOsOxQ== x-ms-office365-filtering-correlation-id: 9a0f5eb0-a554-433a-ce0d-08d66b25fffd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:HE1PR0401MB2569; x-ms-traffictypediagnostic: HE1PR0401MB2569: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(3002001)(3231475)(944501520)(52105112)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:HE1PR0401MB2569; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0401MB2569; x-forefront-prvs: 0898A6E028 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(199004)(189003)(2501003)(5660300001)(316002)(14454004)(54906003)(25786009)(305945005)(478600001)(53936002)(55236004)(6486002)(256004)(386003)(6436002)(6916009)(68736007)(81156014)(6506007)(6512007)(99286004)(2906002)(5640700003)(106356001)(446003)(1730700003)(11346002)(105586002)(26005)(44832011)(97736004)(81166006)(36756003)(2351001)(486006)(8936002)(1076003)(50226002)(6116002)(186003)(4326008)(86362001)(66066001)(76176011)(8676002)(3846002)(102836004)(78486014)(52116002)(71190400001)(71200400001)(7736002)(476003)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2569; H:HE1PR0401MB2539.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: v09mtBHcbrZqTjM+GVhPUXqy1CmoGHbODcftMr3polH1IQI+A2LF7MdrsPJi/tlrUOOvHOQwvrhbfgpRVbqBrZS8SMqJbzFmZcIaNVCxXRrg6cyTrR86uYF7jt5c9Wshp0x7OEeiHeIvuV3vDZZRvFtJz35r/VPKzarvye8OzXvzixzzsxPfM993u8HSVBCGXPigeuuw7bVSpLZQQOsk/gsB08m9TM4f9G+EC7cJt1fqXjA+LcwSOnSCGGv6S7xyzmN5rRERT1coBpn9KX1Wt3w5MWqSgK1Up0EWGRX9YVrXrxfwJNUTv6uTFURcFq8n spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a0f5eb0-a554-433a-ce0d-08d66b25fffd X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2018 11:33:47.7083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2569 Subject: [dpdk-dev] [PATCH 1/4] bus/dpaa: fix the logical to physical core affine logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The code was treating the lcore id as physical core id. The code is updated to use actual physical core value for any core affinity logic. Note that DPAA devices are single cluster systems. Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Cc: Nipun Gupta Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 41 +++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 203f60dc1..1f9e3ca11 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -250,52 +250,53 @@ dpaa_clean_device_list(void) int rte_dpaa_portal_init(void *arg) { - cpu_set_t cpuset; pthread_t id; - uint32_t cpu = rte_lcore_id(); + unsigned int cpu, lcore = rte_lcore_id(); int ret; struct dpaa_portal *dpaa_io_portal; BUS_INIT_FUNC_TRACE(); - if ((size_t)arg == 1 || cpu == LCORE_ID_ANY) - cpu = rte_get_master_lcore(); - /* if the core id is not supported */ + if ((size_t)arg == 1 || lcore == LCORE_ID_ANY) + lcore = rte_get_master_lcore(); else - if (cpu >= RTE_MAX_LCORE) + if (lcore >= RTE_MAX_LCORE) return -1; - /* Set CPU affinity for this thread */ - CPU_ZERO(&cpuset); - CPU_SET(cpu, &cpuset); + cpu = lcore_config[lcore].core_id; + + /* Set CPU affinity for this thread.*/ id = pthread_self(); - ret = pthread_setaffinity_np(id, sizeof(cpu_set_t), &cpuset); + ret = pthread_setaffinity_np(id, sizeof(cpu_set_t), + &lcore_config[lcore].cpuset); if (ret) { - DPAA_BUS_LOG(ERR, "pthread_setaffinity_np failed on " - "core :%d with ret: %d", cpu, ret); + DPAA_BUS_LOG(ERR, "pthread_setaffinity_np failed on core :%u" + " (lcore=%u) with ret: %d", cpu, lcore, ret); return ret; } /* Initialise bman thread portals */ ret = bman_thread_init(); if (ret) { - DPAA_BUS_LOG(ERR, "bman_thread_init failed on " - "core %d with ret: %d", cpu, ret); + DPAA_BUS_LOG(ERR, "bman_thread_init failed on core %u" + " (lcore=%u) with ret: %d", cpu, lcore, ret); return ret; } - DPAA_BUS_LOG(DEBUG, "BMAN thread initialized"); + DPAA_BUS_LOG(DEBUG, "BMAN thread initialized - CPU=%d lcore=%d", + cpu, lcore); /* Initialise qman thread portals */ ret = qman_thread_init(); if (ret) { - DPAA_BUS_LOG(ERR, "bman_thread_init failed on " - "core %d with ret: %d", cpu, ret); + DPAA_BUS_LOG(ERR, "qman_thread_init failed on core %u" + " (lcore=%u) with ret: %d", cpu, lcore, ret); bman_thread_finish(); return ret; } - DPAA_BUS_LOG(DEBUG, "QMAN thread initialized"); + DPAA_BUS_LOG(DEBUG, "QMAN thread initialized - CPU=%d lcore=%d", + cpu, lcore); dpaa_io_portal = rte_malloc(NULL, sizeof(struct dpaa_portal), RTE_CACHE_LINE_SIZE); @@ -312,8 +313,8 @@ int rte_dpaa_portal_init(void *arg) ret = pthread_setspecific(dpaa_portal_key, (void *)dpaa_io_portal); if (ret) { - DPAA_BUS_LOG(ERR, "pthread_setspecific failed on " - "core %d with ret: %d", cpu, ret); + DPAA_BUS_LOG(ERR, "pthread_setspecific failed on core %u" + " (lcore=%u) with ret: %d", cpu, lcore, ret); dpaa_portal_finish(NULL); return ret; From patchwork Wed Dec 26 11:33:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 49274 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E61CB5F28; Wed, 26 Dec 2018 12:33:53 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150055.outbound.protection.outlook.com [40.107.15.55]) by dpdk.org (Postfix) with ESMTP id D8EB45B2A; Wed, 26 Dec 2018 12:33:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WPYS0zTGuG9jiSSLKziYDvJcJsfCKLBoi7tF0USHj7Y=; b=it+uTHZ+KY2DmLQdtUfH/s3/5iP1g3Fcd0t2FnmV5c06ntZdCkt9t66SjmHeL1erzL79qrvXQLcChB+37MzI0QbmW/T+KTPOJt0Sup+pc/MSBhY0zEV1XJKd1jcY7210k+LWLk0xncS76I5lq85j+hV/nxcZSL0Y1tU3ofdVYzM= Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com (10.168.147.150) by HE1PR0401MB2569.eurprd04.prod.outlook.com (10.168.148.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Wed, 26 Dec 2018 11:33:51 +0000 Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63]) by HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63%4]) with mapi id 15.20.1446.026; Wed, 26 Dec 2018 11:33:51 +0000 From: Hemant Agrawal To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Shreyansh Jain , "stable@dpdk.org" Thread-Topic: [PATCH 2/4] net/dpaa: fix the secondary process Thread-Index: AQHUnQ7f63XRI3fl50iBt59KhgPcjQ== Date: Wed, 26 Dec 2018 11:33:51 +0000 Message-ID: <20181226113321.22279-3-hemant.agrawal@nxp.com> References: <20181226113321.22279-1-hemant.agrawal@nxp.com> In-Reply-To: <20181226113321.22279-1-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.30.134] x-mailer: git-send-email 2.17.1 x-clientproxiedby: TYAPR01CA0228.jpnprd01.prod.outlook.com (2603:1096:404:11e::24) To HE1PR0401MB2539.eurprd04.prod.outlook.com (2603:10a6:3:83::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0401MB2569; 6:1MD4rolWraUYh3uwGxk7Fxkf2xQiS/WAsLNxg9k73ivgTMOq7jhvFSgUNiZY6JyopcpHiVOWlGK61I4UtPeFSZA2+uGU4aKWdSqlUxMB8I9XSpZlfcICfMX0uTaAqO5/qMALLrkCTHlSGXA4/QfUz1Z4jX1VL7SQ3C1adIgkX0SkwKTKrS8iwOC6/cjMin/2+hfMwliSM5QK2jhu1qE5bDlFOr0PPYzWPucYc8gE/Rw5GcPpn9IKn3jMcCH/cMEPFd8XIxmRqaKg3z0CmqB8Neh4CgNWgUJp+62/ap6xh7/GeDiKS2vvoVqWdiEixjhO2LVGLQmZ0I8Pgb0oke2ATyL098f6ViNtLNQfY73WLtBlWl3b3VKrT34SOZ3q4jNDDXNya2nMD1hOP9+pUnZWQ4guoNcns6uvvRcD6huiVDpcNBZi2Hbewn9XcR0peSAA99/1qZTykyf5mp5ico9LVw==; 5:XwbSFKL9EYN8fe05/zi594yVQMI4veXmSAvBsQpBYxYS4z1bxMj6RhywJfmrh5c26l1LcEnTjVbZ8m0pJDz+xbVIZZSKantMJ3+ACJCE55d9Zyl+MPzaQ8ERf+1XTtxmZwVnoK7GHcegPJH5oRGunkIh18m+DaxES46g/q3FRz0=; 7:Yq6235BxPyM/ZOgw7pYxe4OyWZ8JS0PmojuzI2qx/P5WsmtvnqGJhKKLfWG5JZYmVotnxaSI2hVbqGqCK91OZxRmJ5n5nrt5HxBMYkNL8GSdho70X4pFtKqQKssm5xQm5RVQh+FH1swP1pV/1KI69w== x-ms-office365-filtering-correlation-id: a3043c5d-8c6d-464a-bf94-08d66b2601f7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:HE1PR0401MB2569; x-ms-traffictypediagnostic: HE1PR0401MB2569: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(3002001)(3231475)(944501520)(52105112)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:HE1PR0401MB2569; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0401MB2569; x-forefront-prvs: 0898A6E028 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(199004)(189003)(2501003)(5660300001)(316002)(14454004)(54906003)(25786009)(305945005)(478600001)(53936002)(55236004)(6486002)(256004)(386003)(14444005)(6436002)(6916009)(68736007)(81156014)(6506007)(6512007)(99286004)(2906002)(5640700003)(106356001)(446003)(1730700003)(11346002)(105586002)(26005)(44832011)(97736004)(81166006)(36756003)(2351001)(486006)(8936002)(1076003)(50226002)(6116002)(186003)(4326008)(86362001)(66066001)(76176011)(8676002)(3846002)(102836004)(78486014)(52116002)(71190400001)(71200400001)(7736002)(476003)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2569; H:HE1PR0401MB2539.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lkr3gNajKPXzgV1WfRGAPAqh5BuU0iy4WLpwnlbjtYbzK46kW7dYJjezyGLBXwAsVbwcSWJCGPrGEAFEVqT51GJXDVBX5U0MH1FhwuLJ32D9sQuMARdn6kg6nYdBmgSCJwZyBcQCG48jzyh0SBFCAjeMGW7udOC6/A6ZP437Nb9TI0gcQsRSgOgHrqS35evhKs5tU3RYlBlUWkfPBW8/7l4MYobKxjy0cU7JjOZ3mbsv0Ywn9SndR6Y62eTT/Li4LVaTpFE4quKVeP333L3fkcrUjggkoXSl+iGJXCTpA3/Huk5X53urWbarZbkh3VPX spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3043c5d-8c6d-464a-bf94-08d66b2601f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2018 11:33:51.3753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2569 Subject: [dpdk-dev] [PATCH 2/4] net/dpaa: fix the secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In order to support I/O from secondary process, the burst APIs and OPS APIs shall be mapped/plugged. This patch fixes the code to remap the ops and burst apis. Fixes: ff9e112d7870 ("net/dpaa: add NXP DPAA PMD driver skeleton") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index d0572b3d9..5448a2ca7 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1223,8 +1223,12 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) PMD_INIT_FUNC_TRACE(); /* For secondary processes, the primary has done all the work */ - if (rte_eal_process_type() != RTE_PROC_PRIMARY) + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { + eth_dev->dev_ops = &dpaa_devops; + /* Plugging of UCODE burst API not supported in Secondary */ + eth_dev->rx_pkt_burst = dpaa_eth_queue_rx; return 0; + } dpaa_device = DEV_TO_DPAA_DEVICE(eth_dev->device); dev_id = dpaa_device->id.dev_id; From patchwork Wed Dec 26 11:33:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 49275 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7FCE5F1F; Wed, 26 Dec 2018 12:33:56 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150055.outbound.protection.outlook.com [40.107.15.55]) by dpdk.org (Postfix) with ESMTP id 8C9DE5F2E for ; Wed, 26 Dec 2018 12:33:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMBZyzrdIQM9yvihl9jjJVKdoowqFzyzt450IHJCklM=; b=XYIEYOOXoOtMHLRbjEE/tndQxVyIACsKADaYfNYk/t5mW+sgj6LugBEq4wRSIyr7EldEWdBa/TcN5gxFvvZdIxJt4etp3i6l4WmvmMk73cnoPhzATC85nL2x9PJckKLkf8VtjsCnUfnhnpPrWKTH57UHxU1YuP2tQVULJsFZzRw= Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com (10.168.147.150) by HE1PR0401MB2569.eurprd04.prod.outlook.com (10.168.148.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Wed, 26 Dec 2018 11:33:54 +0000 Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63]) by HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63%4]) with mapi id 15.20.1446.026; Wed, 26 Dec 2018 11:33:54 +0000 From: Hemant Agrawal To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Shreyansh Jain Thread-Topic: [PATCH 3/4] net/dpaa: update supported ptypes Thread-Index: AQHUnQ7harifnZO86E+SVh4QIhNqrw== Date: Wed, 26 Dec 2018 11:33:54 +0000 Message-ID: <20181226113321.22279-4-hemant.agrawal@nxp.com> References: <20181226113321.22279-1-hemant.agrawal@nxp.com> In-Reply-To: <20181226113321.22279-1-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.30.134] x-mailer: git-send-email 2.17.1 x-clientproxiedby: TYAPR01CA0228.jpnprd01.prod.outlook.com (2603:1096:404:11e::24) To HE1PR0401MB2539.eurprd04.prod.outlook.com (2603:10a6:3:83::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0401MB2569; 6:KfDiy5qziBZPv0gJ92W9M7GamlrxYmZz7MdwHryl+owSMf3czl5Plrsag0RxLOSYl8OARaua9oFb+GynIzzDNxeSwxFopbmGYHs1HVQdRsTM6dR0Sv3hbYnCtzAmy8mMSWj0KLiWdV9Ab0oewZJn6CTiqV3fphfbN3/ndwL/sFfsGvoITLUEAe2NMHMMhRV6Db7rR/GZxhGg1PJNTju50Y53B0xN/TGq0oiA7xGhJQWMpz+ySkpyEArr/8K82Y9KO6tYhrT9pzj1KBtT9tFzgrDr9Ah8kqZAi7gFCcaG63uPPnNLLQsQZxtGKxOrX/fRXLcnj242WL08uhigASNXCDI2V1bfHQsztaFHnXd+p9nYnSPU6O29OtyRq8uIuEEpQCbJVEO+50T0yXkS7a38ekhiAcD1qrP308B6ib7OUTtMb6DDv2tomt3IvQCbLrMc1ElHiMFLR6YqArNjxxI1eg==; 5:pEgfUjWcmwQz9/2RPbp76HKB0kVxFJ2bbSBfKK6DJLdSBMVy5U7JT2YyqYEG5I9Yo/BRI68/9KBhiEah4uNuDXTxd3g+rvq64XlXLFQtlJAywwTr14+Z9zYDEw21m5NlWJpvYlLj61Es9UyBiVJ+WG7vGQDzDex522AwR4S8uuM=; 7:XQUSttu+bmqLN8lfgZ7B/4OBwbgxzZBufJH9wRlafZdGmUqn6pFSwxaOc8E7JP5I+uPUSJvDAwwTrpZNvaziNhXhATaX/okzBemaHaEDHHf2JTBA52rAMUyp0NpbWsYF4F1U0gvEvudb028JAWKEtA== x-ms-office365-filtering-correlation-id: f6a0234c-a87a-4bbe-991c-08d66b2603e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:HE1PR0401MB2569; x-ms-traffictypediagnostic: HE1PR0401MB2569: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(3002001)(3231475)(944501520)(52105112)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:HE1PR0401MB2569; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0401MB2569; x-forefront-prvs: 0898A6E028 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(199004)(189003)(2501003)(5660300001)(316002)(14454004)(54906003)(25786009)(305945005)(478600001)(53936002)(55236004)(6486002)(256004)(386003)(14444005)(6436002)(6916009)(68736007)(81156014)(6506007)(6512007)(99286004)(2906002)(5640700003)(106356001)(446003)(15650500001)(1730700003)(11346002)(105586002)(26005)(44832011)(97736004)(81166006)(36756003)(2351001)(486006)(8936002)(1076003)(50226002)(6116002)(186003)(4326008)(86362001)(66066001)(76176011)(8676002)(3846002)(102836004)(78486014)(52116002)(71190400001)(71200400001)(7736002)(476003)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2569; H:HE1PR0401MB2539.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +3TyRzDO0yAZDAD8aEl7aOHjvJKZrfAdj+ZFa2qW/2V8FtGPHhVRQJfO6957v0/teGVbcGmhHYTiCpZqTyIbCYhgnTgJr7H4l39zHKbLMAm2USOovMQh7yZ9MjZJqjdD9ex13AavdJNLcYe9zT5Dl7KCSeH9cgFD/4CaPfyb6s+g/TAnfr30mEIMfOcY/8M9xvruI++TGQaOBLX+60lobKpy0nAIxUnOe53pKwxC81BvLmuMWKs2W0B/MC4r61VxOWHW28IdirNowdlTGlilkWDInhvp8RrX/ZaRzvyhUBcYNevpu7tUrzZZ7a7AHzrj spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6a0234c-a87a-4bbe-991c-08d66b2603e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2018 11:33:54.4008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2569 Subject: [dpdk-dev] [PATCH 3/4] net/dpaa: update supported ptypes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Validated and tested additional packet type for the DPAA platform. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 5448a2ca7..ba66aa2a0 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -245,12 +245,15 @@ static const uint32_t * dpaa_supported_ptypes_get(struct rte_eth_dev *dev) { static const uint32_t ptypes[] = { - /*todo -= add more types */ RTE_PTYPE_L2_ETHER, - RTE_PTYPE_L3_IPV4, - RTE_PTYPE_L3_IPV4_EXT, - RTE_PTYPE_L3_IPV6, - RTE_PTYPE_L3_IPV6_EXT, + RTE_PTYPE_L2_ETHER_VLAN, + RTE_PTYPE_L2_ETHER_ARP, + RTE_PTYPE_L3_IPV4_EXT_UNKNOWN, + RTE_PTYPE_L3_IPV6_EXT_UNKNOWN, + RTE_PTYPE_L4_ICMP, + RTE_PTYPE_L4_TCP, + RTE_PTYPE_L4_UDP, + RTE_PTYPE_L4_FRAG, RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP, RTE_PTYPE_L4_SCTP From patchwork Wed Dec 26 11:33:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 49276 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F30369D4; Wed, 26 Dec 2018 12:34:00 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150053.outbound.protection.outlook.com [40.107.15.53]) by dpdk.org (Postfix) with ESMTP id ACEAA5F36 for ; Wed, 26 Dec 2018 12:33:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v3IFURm4Cbk78kSNXW4M1vXnz1/QXOUVsIZG+BDNhQ0=; b=fYj0Zs+PxmP4GIPDyroPuiWgcKRm78Uj6rQlbSEW/caLDKTPpjMcap+96XwZXwUqQ0GgyyNublxEMn7o32pGbzJ9YM1SjnT9dcGTuEnG9y1Aw5mRByxCANfFn13if7ccBpZX13etRvaCyBrQjASGASAEZ9zukUmk8UKNyDktfbE= Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com (10.168.147.150) by HE1PR0401MB2569.eurprd04.prod.outlook.com (10.168.148.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Wed, 26 Dec 2018 11:33:57 +0000 Received: from HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63]) by HE1PR0401MB2539.eurprd04.prod.outlook.com ([fe80::20ce:2eff:1e7b:9e63%4]) with mapi id 15.20.1446.026; Wed, 26 Dec 2018 11:33:57 +0000 From: Hemant Agrawal To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Shreyansh Jain Thread-Topic: [PATCH 4/4] net/dpaa: update RSS offload types Thread-Index: AQHUnQ7jkfCmTApZGEGkaGljVQ7pLw== Date: Wed, 26 Dec 2018 11:33:57 +0000 Message-ID: <20181226113321.22279-5-hemant.agrawal@nxp.com> References: <20181226113321.22279-1-hemant.agrawal@nxp.com> In-Reply-To: <20181226113321.22279-1-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.30.134] x-mailer: git-send-email 2.17.1 x-clientproxiedby: TYAPR01CA0228.jpnprd01.prod.outlook.com (2603:1096:404:11e::24) To HE1PR0401MB2539.eurprd04.prod.outlook.com (2603:10a6:3:83::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0401MB2569; 6:CTX7+hMKfT07vQCdWBkZ2VmRcqeHpfsBBGIccRrWO/VfNJ+Lr4npLmxvAwKkFSukwOtwARV7lbUK+AUUKt5l3sxctgB0b4jOi9i4Bozx22XL2ZFUKDVm4QlvpEBLeYSfwNuafgF8vt2QHrqGAil9ujRTMWSYq9lOoQBrdkl25V7APGOLFNX0QJFoDBTkGR0Mg6XRRerdusD1XE/3NtWZfrY9TFynryXLAexwBAHSIhX18fDq7v2i/CZk2GpQfDCvuPJ5sHS7wEI0M7giR9PHKGShDjxwuQhOvxoQ3rgp3HD0NhlxzthMSGkyA/UjtmRZBoh8PhlzzBZcWXaGiyeGdSHr3/kYFkaT20LQJroLkaE/78/NWZXWB4BnY+XD3XiLHcsJyj1ZKrBVRseca5ZHmnIrSRPexAmJXY6OHBhCG6Dr8ygYChKsPHToUjKV97AxG9uRCxVbCl46UClTylIKIQ==; 5:rVxBdUFPQeTJ729ugdm1urNvP5BtMwxpMoqICaJfrNV/ybzuiGe1P0NPCKK93BiloivP5So9NxV0KpEgK0NzNK5gs+4Q+FVH2cnlhnSVyJHpEiw4tWUKzZloJbW3Z3afXHffVJEl/LkChVDKofl934qPRdWWWy/N/J49K9WFgJ8=; 7:5sj3CRrkHoapDa7l+p7m/IIDye6RC41yv1X6mjbfingP6mOABOPK4/EplPKTn7PunZZou7TVCqymiRGfg2cU7nM/El7aGYvfJ3yjWLcUS2qpA882yKglD7jmL7wzGXuoCe+d9OeonFedKgnL5TFBbw== x-ms-office365-filtering-correlation-id: b801aaeb-3c37-42c1-a4b5-08d66b2605b6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:HE1PR0401MB2569; x-ms-traffictypediagnostic: HE1PR0401MB2569: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(3002001)(3231475)(944501520)(52105112)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:HE1PR0401MB2569; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0401MB2569; x-forefront-prvs: 0898A6E028 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(199004)(189003)(2501003)(5660300001)(316002)(14454004)(54906003)(25786009)(305945005)(478600001)(53936002)(55236004)(6486002)(256004)(386003)(14444005)(6436002)(6916009)(68736007)(81156014)(6506007)(6512007)(99286004)(2906002)(5640700003)(106356001)(446003)(15650500001)(1730700003)(11346002)(105586002)(26005)(44832011)(97736004)(81166006)(36756003)(2351001)(486006)(575784001)(8936002)(1076003)(50226002)(6116002)(186003)(4326008)(86362001)(66066001)(76176011)(8676002)(3846002)(102836004)(78486014)(52116002)(71190400001)(71200400001)(7736002)(476003)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2569; H:HE1PR0401MB2539.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: n3FddkG+l7uwj5cD40ocin6OfRyADsiz+nN9J+kd1mC9ov2nqAG2fPAGcjMBN9WvgtLgNYdOmW/GahN+2UtVFUdZ5V5sd9lVxZzr/hm9EQx6CZQLizM/JrTRzFHVGpeAGT1+H69ab+kZ9dPH/9AoXdl0Vls/gVPWzDykXMSL5wc4wPuK1KTjyOv1ZA6BMWt59aev10iyFV8fn2CqulOjgieGWYKnoAKLZ7cFIK+fA0CRiq8Oll2O67Rqml305eGRnlPJCP2p21+QAer8AEUMwp5WiSlQgWCaZgTuYQr7sEuwdlTSbrAVZfGPSlr7gUJr spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b801aaeb-3c37-42c1-a4b5-08d66b2605b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2018 11:33:57.4954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2569 Subject: [dpdk-dev] [PATCH 4/4] net/dpaa: update RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Validated and tested additional offload flags for RSS configuration. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h index 2fc723171..e906a0bec 100644 --- a/drivers/net/dpaa/dpaa_ethdev.h +++ b/drivers/net/dpaa/dpaa_ethdev.h @@ -79,10 +79,14 @@ #define DPAA_DEBUG_FQ_TX_ERROR 1 #define DPAA_RSS_OFFLOAD_ALL ( \ - ETH_RSS_IP | \ - ETH_RSS_UDP | \ - ETH_RSS_TCP | \ - ETH_RSS_SCTP) + ETH_RSS_FRAG_IPV4 | \ + ETH_RSS_NONFRAG_IPV4_TCP | \ + ETH_RSS_NONFRAG_IPV4_UDP | \ + ETH_RSS_NONFRAG_IPV4_SCTP | \ + ETH_RSS_FRAG_IPV6 | \ + ETH_RSS_NONFRAG_IPV6_TCP | \ + ETH_RSS_NONFRAG_IPV6_UDP | \ + ETH_RSS_NONFRAG_IPV6_SCTP) #define DPAA_TX_CKSUM_OFFLOAD_MASK ( \ PKT_TX_IP_CKSUM | \