From patchwork Mon Dec 24 15:34:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiming Yang X-Patchwork-Id: 49257 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF97F1B4E5; Mon, 24 Dec 2018 09:08:06 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5CDB81B4E1; Mon, 24 Dec 2018 09:08:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2018 00:08:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,391,1539673200"; d="scan'208";a="286093038" Received: from dpdk-qiming2.sh.intel.com ([10.67.119.132]) by orsmga005.jf.intel.com with ESMTP; 24 Dec 2018 00:08:03 -0800 From: Qiming Yang To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Qiming Yang , stable@dpdk.org Date: Mon, 24 Dec 2018 23:34:02 +0800 Message-Id: <20181224153402.125944-1-qiming.yang@intel.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20181221130145.182446-1-qiming.yang@intel.com> References: <20181221130145.182446-1-qiming.yang@intel.com> Subject: [dpdk-dev] [PATCH v2] net/i40e: fixed get RSS conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_eth_dev_rss_hash_conf_get API doesn't force 'rss_conf.rss_key' to be not NULL, so rss_key = NULL should be alllowed in i40e driver. Fixes: 16321de09396 ("ethdev: allow to get RSS hash functions and key") Cc: stable@dpdk.org Signed-off-by: Qiming Yang Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 8dc1a4a..a6b97e1 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -7407,7 +7407,7 @@ i40e_get_rss_key(struct i40e_vsi *vsi, uint8_t *key, uint8_t *key_len) int ret; if (!key || !key_len) - return -EINVAL; + return 0; if (pf->flags & I40E_FLAG_RSS_AQ_CAPABLE) { ret = i40e_aq_get_rss_key(hw, vsi->vsi_id, @@ -7492,6 +7492,9 @@ i40e_dev_rss_hash_conf_get(struct rte_eth_dev *dev, uint64_t hena; int ret; + if (!rss_conf) + return -EINVAL; + ret = i40e_get_rss_key(pf->main_vsi, rss_conf->rss_key, &rss_conf->rss_key_len); if (ret)