From patchwork Fri Dec 21 13:01:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiming Yang X-Patchwork-Id: 49222 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9826C1BD42; Fri, 21 Dec 2018 06:35:51 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 44F6B1BD41; Fri, 21 Dec 2018 06:35:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 21:35:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,380,1539673200"; d="scan'208";a="100415194" Received: from dpdk-qiming2.sh.intel.com ([10.67.119.132]) by orsmga007.jf.intel.com with ESMTP; 20 Dec 2018 21:35:47 -0800 From: Qiming Yang To: dev@dpdk.org Cc: Qiming Yang , stable@dpdk.org Date: Fri, 21 Dec 2018 21:01:45 +0800 Message-Id: <20181221130145.182446-1-qiming.yang@intel.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-dev] [PATCH] app/testpmd: fixed get RSS conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I40e do not allow to get rss hena only, need to get rss key meanwhile. Fixes: 16321de09396 ("ethdev: allow to get RSS hash functions and key") Cc: stable@dpdk.org Signed-off-by: Qiming Yang --- app/test-pmd/config.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b9e5dd9..482c4f5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1764,8 +1764,7 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key) return; } - /* Get RSS hash key if asked to display it */ - rss_conf.rss_key = (show_rss_key) ? rss_key : NULL; + rss_conf.rss_key = rss_key; rss_conf.rss_key_len = hash_key_size; diag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf); if (diag != 0) { @@ -1793,6 +1792,8 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key) printf("%s ", rss_type_table[i].str); } printf("\n"); + + /* Get RSS hash key if asked to display it */ if (!show_rss_key) return; printf("RSS key:\n");