From patchwork Wed Jul 5 10:25:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 129284 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B19842DCC; Wed, 5 Jul 2023 12:25:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E24054021F; Wed, 5 Jul 2023 12:25:36 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9C37B40150 for ; Wed, 5 Jul 2023 12:25:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688552735; x=1720088735; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xllHNyLuSzDrgFwrIL7D/aJEPjrql2JUeYRsF4KqUnc=; b=lqlfDFu6GXXMvaAy3fzyFg7tXH1Hy6aBaD1d0Mde7AftX55RgaD+Nanc KZOD6mE92zEaMlUR4z2m8D/kOeukQMizIC1Dk0WueV4f60cwLOEHh1hR6 p8VBVr2Srq82yPGJqJ5YpaQ0ayIAS3XqdM7ihHFi+4RHkdwXIgE8UNqPH d/D4dQ0/fGZnEeblh6/x4vM4s0kRRra8ESDzFPM4Jxu2qhmCW+d707QgP yYB0N38UVrmErxTAXeu0diCw3xCsotRTiQRQ2aRY6HqLLaxXc4dgivhH2 BP9vQYiPs6ton+oMowtKlBOBLFfjk1fYg8j5yt/JZTEp/e6mO69Iy2xUk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="348092433" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="348092433" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 03:25:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="748674093" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="748674093" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.80]) by orsmga008.jf.intel.com with ESMTP; 05 Jul 2023 03:25:32 -0700 From: Ciara Power To: dev@dpdk.org Cc: gakhil@marvell.com, pablo.de.lara.guarch@intel.com, Ciara Power , marcel.d.cornu@intel.com, Kai Ji Subject: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst Date: Wed, 5 Jul 2023 10:25:30 +0000 Message-Id: <20230705102530.1127021-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230705101521.1126253-1-ciara.power@intel.com> References: <20230705101521.1126253-1-ciara.power@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The jobs variable was global, which meant it was not thread safe. This caused a segmentation fault when running the crypto performance app, using more than one lcore for crypto processing. Moving this to the dequeue function where it is used fixes the issue. Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") Cc: marcel.d.cornu@intel.com Signed-off-by: Ciara Power Acked-by: Kai Ji Acked-by: Pablo de Lara --- v2: fixed typo in commit --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c index f4322d9af4..f702127f7f 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c @@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data { uint32_t offset; }; -#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM -static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL}; -#endif - /** * Calculate the authentication pre-computes * @@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops, IMB_JOB *job; int retval, processed_jobs = 0; uint16_t i, nb_jobs; + IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL}; if (unlikely(nb_ops == 0 || mb_mgr == NULL)) return 0;