From patchwork Wed Dec 19 06:22:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 49100 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C3B81BADD; Wed, 19 Dec 2018 07:23:25 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E24CB1B698 for ; Wed, 19 Dec 2018 07:23:22 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 690E680081; Wed, 19 Dec 2018 06:23:21 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 18 Dec 2018 22:23:18 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 18 Dec 2018 22:23:18 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wBJ6NHa9003347; Wed, 19 Dec 2018 06:23:17 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id EB64B1616F0; Wed, 19 Dec 2018 06:23:16 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit CC: Date: Wed, 19 Dec 2018 06:22:58 +0000 Message-ID: <1545200580-15467-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24296.005 X-TM-AS-Result: No-0.500500-4.000000-10 X-TMASE-MatchedRID: IJfQKf6xjE7XldNKzKPlvTPDkSOzeDWW3g3xD6V0LtT7SBmDTxVcWk/O fkh/+AL4hUHepIxgktgTzo/7p2GUyF7FwpET+YHongIgpj8eDcAZ1CdBJOsoY9mzcdRxL+xwKra uXd3MZDUoWeJacQYjEf/WdjrOm7qEUGjF6bp/KKMgnoTiC/yJzwo/X31uF/dnOTe7/kgbf8AhjK 1Gqzc+E3bjh2dLZv1fNIRr6kHTKfNGkBjbMbD9rzigZBQJvBjlD6DuZ3COjrnoW0NkKZgEnW3Lg NyHejuiQwymtxuJ6y0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.500500-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24296.005 X-MDID: 1545200602-KAeT_jQeJV1U Subject: [dpdk-dev] [PATCH v1 1/3] ethdev: advertise MTU as retained across device stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Changing MTU in running state may return -EBUSY saying that MTU cannot be changed when the port is running. It assumes that changes may be done in stopped and started (but some PMDs may reject it) state and it is logical to require that changes done in any of these states are retained. Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 1960f3a2d..617551f72 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -80,6 +80,7 @@ * rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will * be retained: * + * - MTU * - flow control settings * - receive mode configuration (promiscuous mode, hardware checksum mode, * RSS/VMDQ settings etc.) From patchwork Wed Dec 19 06:22:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 49103 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 862761BC1B; Wed, 19 Dec 2018 07:23:30 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 93C481BBDA for ; Wed, 19 Dec 2018 07:23:27 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C03DD8005E; Wed, 19 Dec 2018 06:23:21 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 18 Dec 2018 22:23:18 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 18 Dec 2018 22:23:18 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wBJ6NHUA003352; Wed, 19 Dec 2018 06:23:17 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id EE96C161D44; Wed, 19 Dec 2018 06:23:16 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit CC: Date: Wed, 19 Dec 2018 06:22:59 +0000 Message-ID: <1545200580-15467-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24296.005 X-TM-AS-Result: No-10.363800-4.000000-10 X-TMASE-MatchedRID: kII+BsKkYBAtg1fUv6/cnsf52VD5rJyZU+A7YkpDJ1hPgJpuGFm9djLk 8G2qhCWTXfUIozyICkW761Rb2kt6b0QVckjz5U5ekVUMyVUKRZ4wyvga40dfWsFKCo95h/aQ8rM P48ANS13i8zVgXoAltsYlDcGKIsCCC24oEZ6SpSkj80Za3RRg8AULHC+Ptywgf0ZMybmq+HxnYB MyuAnwY/AM50xaDaFVJuUoCN+T2k4= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.363800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24296.005 X-MDID: 1545200602-8xqXjXpg_DAY Subject: [dpdk-dev] [PATCH v1 2/3] ethdev: advertise default MAC as retained on device restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The documentation says MAC addresses array is retained and it is logical to assume that default MAC address is retained as well. Also some PMDs do not allow to change the default MAC in running state (see RTE_ETH_DEV_NOLIVE_MAC_ADDR). Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 617551f72..8ca80f0c0 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -85,6 +85,7 @@ * - receive mode configuration (promiscuous mode, hardware checksum mode, * RSS/VMDQ settings etc.) * - VLAN filtering configuration + * - default MAC address * - MAC addresses supplied to MAC address array * - flow director filtering mode (but not filtering rules) * - NIC queue statistics mappings From patchwork Wed Dec 19 06:23:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 49101 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75E851BBD0; Wed, 19 Dec 2018 07:23:27 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1CB231BABD for ; Wed, 19 Dec 2018 07:23:23 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id EB1A080070; Wed, 19 Dec 2018 06:23:21 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 18 Dec 2018 22:23:18 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 18 Dec 2018 22:23:18 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wBJ6NHCp003355; Wed, 19 Dec 2018 06:23:17 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 084A01626D1; Wed, 19 Dec 2018 06:23:17 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit CC: Date: Wed, 19 Dec 2018 06:23:00 +0000 Message-ID: <1545200580-15467-4-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24296.005 X-TM-AS-Result: No-2.088300-4.000000-10 X-TMASE-MatchedRID: Wv0/mEfewaFEFXJI8+VOXgPZZctd3P4B4wQlYP0sRm8uqIEAvQJhMZ4S u3+FxtJm4vM1YF6AJbbGJQ3BiiLAggtuKBGekqUpm+MB6kaZ2g4xsGj+OiDuBXyREEzlyK5wNNp aAWUBOBtFEQQJB6qkxGo41OaTPCCpeOYDq43yeK6+ARjeU4t3i36CZ1n/vMFwdApXOyQl2yzkA8 OrYHdwDGfYlY/yoV/0Up6EHOb2+c7kHZDO53QSwjflzkGcoK72 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.088300-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24296.005 X-MDID: 1545200602-yuDhBYLpC6AU Subject: [dpdk-dev] [PATCH v1 3/3] ethdev: highlight that all-multicast is retained on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All-multicast is a part of receive mode configuration and it is better to mention explicitly that it is retained across restart. Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 8ca80f0c0..aa0e6fa6f 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -82,8 +82,8 @@ * * - MTU * - flow control settings - * - receive mode configuration (promiscuous mode, hardware checksum mode, - * RSS/VMDQ settings etc.) + * - receive mode configuration (promiscuous mode, all-multicast mode, + * hardware checksum mode, RSS/VMDQ settings etc.) * - VLAN filtering configuration * - default MAC address * - MAC addresses supplied to MAC address array