From patchwork Tue Jun 20 08:51:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Herbelot X-Patchwork-Id: 128830 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D95E742D06; Tue, 20 Jun 2023 10:51:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1B0D4068E; Tue, 20 Jun 2023 10:51:46 +0200 (CEST) Received: from mail-ej1-f99.google.com (mail-ej1-f99.google.com [209.85.218.99]) by mails.dpdk.org (Postfix) with ESMTP id C0668400D6 for ; Tue, 20 Jun 2023 10:51:45 +0200 (CEST) Received: by mail-ej1-f99.google.com with SMTP id a640c23a62f3a-982a0232bdcso699651266b.1 for ; Tue, 20 Jun 2023 01:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1687251105; x=1689843105; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lqDXOWs9tIIYKQBRslQS2p6LDtmQb28V/U3pYz4hOBg=; b=Vv3A3afNqeihnWNtOJTjNjMwGkQazuTB6pHOzGc6OaCwFIORX9vyUKGNoqmdTqCntO dCZ6qbyK8lKkcFSgy5aoKVVdsobAnM1HXHRrFDeZ6msZyoNHgC/OeAa38OsOH7xyrkYM nZ0YFK8s6thGYbM99yXgNtZBsrYhfmSY1DTJkoj8ETHh1yI+rVsdh0u2ciMjGLLJ6pf7 yBsvsMMv0hj5kg18i4HWLPBcXkkWIWciWJL7pxRKK+Oepl0L6Kv1r2S3Rz22IpUoysov fUT614u/xBoqzs2cnyzoLFumg8ij3Uyt1M1Uz/faBbAb6yExyu24+T7fvRputTFJyelw q5TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687251105; x=1689843105; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lqDXOWs9tIIYKQBRslQS2p6LDtmQb28V/U3pYz4hOBg=; b=kKvcu3w2UqVll0BikbwOIwNn0/DR5eGg8Y0qlr3jZe4X5m9+YmwEuxqKB1hVO1sxT7 G8ohx4m5Am8eMgjQds4G3XVWbGazzwtZDqzjw50o6LxrN2pIoyCiKR5caI4IPoDtCwDa 7SbxrW7nOrT3xe5Bj7ck6gXOlDpoO8TGn0sxN4Svi0qEI1G4VMPE2ewBdotWhY3tREPp FdD9oLWFhe9LJ8LBLNyxKJlZyXc+997BQDcKIPGuP5fVQ+FmNmMrbGReIvqtwUsJ3TDw cJPjAHqcThXCVYLXIPhrPEuXL90h6t/6BO5SscjapyFxcmy0usJaTf+d/elEF5ityTwj EhNw== X-Gm-Message-State: AC+VfDwVCg/VHgDnDtgU5qiVvho2Di8eS1muVL02XcR4BFPO8IdMXSvf 1qwW97uCXkvoScHV0N2+jlg0Diz82FuJ0LW5bBdT+2k4ow2d1hifmI1d X-Google-Smtp-Source: ACHHUZ6AshKX0OfIZFxJOZmPmc1qOZ9rmTwzi1E9RXQN12XLOTWWqRWJ8ZKqcR1yb28xYX1cXNu6W1oD9Z16 X-Received: by 2002:a17:907:7b96:b0:984:5c67:e73f with SMTP id ne22-20020a1709077b9600b009845c67e73fmr11868636ejc.54.1687251105263; Tue, 20 Jun 2023 01:51:45 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id ds14-20020a170907724e00b009876382477dsm278379ejc.218.2023.06.20.01.51.45; Tue, 20 Jun 2023 01:51:45 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id E7EC8601BD; Tue, 20 Jun 2023 10:51:44 +0200 (CEST) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Nithin Dabilpuram , Satha Koteswara Rao Kottidi , Jerin Jacob Kollanukkaran Subject: [PATCH] common/cnxk/roc_npa: fix npa_aura_fini Date: Tue, 20 Jun 2023 10:51:34 +0200 Message-Id: <20230620085134.3124796-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot --- drivers/common/cnxk/roc_npa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 377439c2baaf..38e149da82cc 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -245,8 +245,10 @@ npa_aura_fini(struct mbox *m_box, uint32_t aura_id) if (rc < 0) goto exit; - if (aura_rsp->hdr.rc != 0) - return NPA_ERR_AURA_POOL_FINI; + if (aura_rsp->hdr.rc != 0) { + rc = NPA_ERR_AURA_POOL_FINI; + goto exit; + } /* Sync NDC-NPA for LF */ ndc_req = mbox_alloc_msg_ndc_sync_op(mbox);