From patchwork Tue Apr 18 11:48:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiale, SongX" X-Patchwork-Id: 126204 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 431C642976; Tue, 18 Apr 2023 05:30:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E75D42C4D; Tue, 18 Apr 2023 05:30:54 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5E06440E09 for ; Tue, 18 Apr 2023 05:30:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681788652; x=1713324652; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zIMrP3mZFhuBpTUyWjquaLzl0VzV0kqOfu0MJJ1jFuU=; b=DBdeTLvB/gR/yydZzKO0MNGV757n2iP1cbGk8ywN9qWjcXwLKdXsCn9v P0xgay1YpO5Lmu/yRFQPkVWVR4ORPVkdE0n6u8PFApHb+5Rydj2em8y7t X613LSsa/qreZb5oaHXFLwD53BfKbEdkRzwc7ChBFXhM4Kv0jawGxtegP G5+grXX0N9V+JPOEVSqkC2k3MSoGzF/RXCCsqfX+ejYuEO2K1dMtszYVX gz4ZrQL5l/6uNdIYP7KV9fCWK4Laj+jHnU7j8zH8ZSBMcFuRaG5O0PX5C 3f4j424ABsgnzAuJOkLQqaawRZpIRodEjyD+MkBuinHMYdVZGjr47VKQ6 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="346911444" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="346911444" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 20:30:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="668338567" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="668338567" Received: from unknown (HELO localhost.localdomain) ([10.239.252.96]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 20:30:50 -0700 From: Jiale Song To: dts@dpdk.org Cc: Jiale Song Subject: [dts] [PATCH V3 1/2] test_plans/stats_checks: add a case Date: Tue, 18 Apr 2023 11:48:19 +0000 Message-Id: <20230418114820.168122-2-songx.jiale@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230418114820.168122-1-songx.jiale@intel.com> References: <20230418114820.168122-1-songx.jiale@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org add a case to test pf negative xstats check. --- test_plans/stats_checks_test_plan.rst | 139 ++++++++++++++++++++++++++ 1 file changed, 139 insertions(+) v3: -modify launch testpmd parameter. diff --git a/test_plans/stats_checks_test_plan.rst b/test_plans/stats_checks_test_plan.rst index 1b7d722f..64799814 100644 --- a/test_plans/stats_checks_test_plan.rst +++ b/test_plans/stats_checks_test_plan.rst @@ -281,3 +281,142 @@ Test Case: VF xstats Checks 3. Then run the same steps of PF xstats Checks, get same result. note: because one port forwarding packets, so check rx and tx both in port 0. + +Test Case: PF negative xstats check +=================================== +1. Blind the PF to vfio-pci:: + + ./usertools/dpdk-devbind.py -b vfio-pci {pf_pci} + +2. Launch testpmd with default mtu:: + + ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c f -n 4 -- -i + testpmd> set fwd mac + testpmd> start + testpmd> clear port xstats all + +3. Set the mtu for the port where the data packet is sent:: + + ifconfig ens7 mtu 5018 + +4. Send jumbo frames:: + + sendp(Ether(dst="00:00:00:00:01:00", src="52:00:00:00:00:00")/IP()/Raw(load="X"*4980), iface="ens7") + +5. Check port 0 xstats:: + + Check rx port can not receive packet. + Check ``rx_errors`` and ``rx_oversize_errors`` increased, but other statistics are 0 for tx port. + testpmd> show port xstats 0 + ###### NIC extended statistics for port 0 + rx_good_packets: 0 + tx_good_packets: 0 + rx_good_bytes: 0 + tx_good_bytes: 0 + rx_missed_errors: 0 + rx_errors: 1 + tx_errors: 0 + rx_mbuf_allocation_errors: 0 + rx_q0_packets: 0 + rx_q0_bytes: 0 + rx_q0_errors: 0 + tx_q0_packets: 0 + tx_q0_bytes: 0 + rx_unicast_packets: 0 + rx_multicast_packets: 0 + rx_broadcast_packets: 0 + rx_dropped_packets: 0 + rx_unknown_protocol_packets: 0 + tx_unicast_packets: 0 + tx_multicast_packets: 0 + tx_broadcast_packets: 0 + tx_dropped_packets: 0 + tx_link_down_dropped: 0 + rx_crc_errors: 0 + rx_illegal_byte_errors: 0 + rx_error_bytes: 0 + mac_local_errors: 0 + mac_remote_errors: 0 + rx_len_errors: 0 + tx_xon_packets: 0 + rx_xon_packets: 0 + tx_xoff_packets: 0 + rx_xoff_packets: 0 + rx_size_64_packets: 0 + rx_size_65_to_127_packets: 0 + rx_size_128_to_255_packets: 0 + rx_size_256_to_511_packets: 0 + rx_size_512_to_1023_packets: 0 + rx_size_1024_to_1522_packets: 0 + rx_size_1523_to_max_packets: 0 + rx_undersized_errors: 0 + rx_oversize_errors: 1 + rx_mac_short_pkt_dropped: 0 + rx_fragmented_errors: 0 + rx_jabber_errors: 0 + tx_size_64_packets: 0 + tx_size_65_to_127_packets: 0 + tx_size_128_to_255_packets: 0 + tx_size_256_to_511_packets: 0 + tx_size_512_to_1023_packets: 0 + tx_size_1024_to_1522_packets: 0 + tx_size_1523_to_max_packets: 0 + +6. Check port 1 xstats:: + + Check all statistics are 0 for tx port. + testpmd> show port xstats 1 + ###### NIC extended statistics for port 1 + rx_good_packets: 0 + tx_good_packets: 0 + rx_good_bytes: 0 + tx_good_bytes: 0 + rx_missed_errors: 0 + rx_errors: 0 + tx_errors: 0 + rx_mbuf_allocation_errors: 0 + rx_q0_packets: 0 + rx_q0_bytes: 0 + rx_q0_errors: 0 + tx_q0_packets: 0 + tx_q0_bytes: 0 + rx_unicast_packets: 0 + rx_multicast_packets: 0 + rx_broadcast_packets: 0 + rx_dropped_packets: 0 + rx_unknown_protocol_packets: 0 + tx_unicast_packets: 0 + tx_multicast_packets: 0 + tx_broadcast_packets: 0 + tx_dropped_packets: 0 + tx_link_down_dropped: 0 + rx_crc_errors: 0 + rx_illegal_byte_errors: 0 + rx_error_bytes: 0 + mac_local_errors: 0 + mac_remote_errors: 0 + rx_len_errors: 0 + tx_xon_packets: 0 + rx_xon_packets: 0 + tx_xoff_packets: 0 + rx_xoff_packets: 0 + rx_size_64_packets: 0 + rx_size_65_to_127_packets: 0 + rx_size_128_to_255_packets: 0 + rx_size_256_to_511_packets: 0 + rx_size_512_to_1023_packets: 0 + rx_size_1024_to_1522_packets: 0 + rx_size_1523_to_max_packets: 0 + rx_undersized_errors: 0 + rx_oversize_errors: 0 + rx_mac_short_pkt_dropped: 0 + rx_fragmented_errors: 0 + rx_jabber_errors: 0 + tx_size_64_packets: 0 + tx_size_65_to_127_packets: 0 + tx_size_128_to_255_packets: 0 + tx_size_256_to_511_packets: 0 + tx_size_512_to_1023_packets: 0 + tx_size_1024_to_1522_packets: 0 + tx_size_1523_to_max_packets: 0 + From patchwork Tue Apr 18 11:48:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiale, SongX" X-Patchwork-Id: 126205 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63EB542977; Tue, 18 Apr 2023 05:30:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6030342BD9; Tue, 18 Apr 2023 05:30:55 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C06B940E09 for ; Tue, 18 Apr 2023 05:30:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681788653; x=1713324653; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bWvl2RCWFdbhoW9VsPuVQ5aaonuI0qObGFxlD4DXl+0=; b=IVdin9H9bORTVOwK4x/KNVNwOPaDbCsQp6P/oUNRw0wtrzDyqT8sLBZa kwO2b2zcHpxathPbxZt3IUeovnXVcaJMH7QIQobHt/AGs24i72Y19EZ2D 8v/rH9Hd/pysdeKlUwTw0o7EYEHm7LDxO8OMk6nRDbFz9pzT9EZfxqTTW B9H+XGo+kdAYslSJ+KdGP3zduwHHLo+pCfXeQD0/PAQcdgQO8R+HCEqy5 i9BskQMRTv1i92IKcI8IoaChkz0dxGAgcRzdzQSb0SIiN/CwajAmGy7yy WkUwPJ2CRWhxZQa2zCIBwM1Z+ISN/u7f/DgaQTMme8k9wriYeSzLRUgwo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="346911448" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="346911448" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 20:30:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="668338580" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="668338580" Received: from unknown (HELO localhost.localdomain) ([10.239.252.96]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 20:30:52 -0700 From: Jiale Song To: dts@dpdk.org Cc: Jiale Song Subject: [dts] [PATCH V3 2/2] tests/stats_checks: add a case Date: Tue, 18 Apr 2023 11:48:20 +0000 Message-Id: <20230418114820.168122-3-songx.jiale@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230418114820.168122-1-songx.jiale@intel.com> References: <20230418114820.168122-1-songx.jiale@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org add a case to test pf negative xstats check. --- tests/TestSuite_stats_checks.py | 47 +++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/tests/TestSuite_stats_checks.py b/tests/TestSuite_stats_checks.py index 6ab5dd19..a9c6e040 100644 --- a/tests/TestSuite_stats_checks.py +++ b/tests/TestSuite_stats_checks.py @@ -28,6 +28,8 @@ prefix_list = [ "tx_good_packets", "rx_good_bytes", "tx_good_bytes", + "rx_errors", + "rx_unicast_packets", "tx_size_64_packets", "tx_size_65_to_127_packets", "tx_size_128_to_255_packets", @@ -42,6 +44,7 @@ prefix_list = [ "rx_size_512_to_1023_packets", "rx_size_1024_to_1522_packets", "rx_size_1523_to_max_packets", + "rx_oversize_errors", "rx_size_1024_to_max_packets", # ixgbe "tx_size_1024_to_max_packets", # ixgbe ] @@ -384,6 +387,7 @@ class TestStatsChecks(TestCase): """ self.netobj_0.enable_jumbo(framesize=1518) self.netobj_1.enable_jumbo(framesize=1518) + self.pmdout.quit() self.dut.kill_all() if self._suite_result.test_case == "test_xstats_check_vf": self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0]) @@ -442,3 +446,46 @@ class TestStatsChecks(TestCase): dcf_flag=self.dcf_mode, param="--txq=4 --rxq=4 --max-pkt-len=9000" ) self.xstats_check(0, 0, if_vf=True) + + def test_negative_xstats_check_pf(self): + """ + Test Case: PF negative xstats check + """ + self.pmdout.start_testpmd("default") + self.pmdout.execute_cmd("set fwd mac") + self.pmdout.execute_cmd("start") + self.netobj_0.enable_jumbo(framesize=5018) + self.pmdout.wait_link_status_up("all") + self.pmdout.execute_cmd("clear port xstats all") + self.pmdout.execute_cmd("show port xstats all") + # send jumbo frames + self.send_scapy_packet( + self.rx_port, + f'Ether(dst=dutmac, src="52:00:00:00:00:00")/IP()/Raw(load="X"*4980)', + ) + # get all port xstats + all_xstats = self.get_xstats([self.rx_port, self.tx_port]) + rx_xstats = all_xstats[self.rx_port] + # check rx port can not receive packet and rx_errors increased + for key, value in rx_xstats.items(): + if key in ["rx_errors", "rx_oversize_errors"]: + self.verify( + value == 1, + "the expected value of %s is 1, but the actual value is %s!!!" + % (key, value), + ) + else: + self.verify( + value == 0, + "the expected value of %s is 0, but the actual value is %s!!!" + % (key, value), + ) + # check all statistics are 0 for tx port. + tx_xstats = all_xstats[self.tx_port] + for key, value in tx_xstats.items(): + self.verify( + value == 0, + "the expected value of %s is 0, but the actual value is %s!!!" + % (key, value), + ) + self.pmdout.execute_cmd("stop")