From patchwork Thu Mar 9 03:36:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 124874 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 616B341E37; Thu, 9 Mar 2023 04:36:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4451E410EE; Thu, 9 Mar 2023 04:36:10 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id C62F840A7E; Thu, 9 Mar 2023 04:36:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678332969; x=1709868969; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Kv4oz5y18jV0PgVNcwkGMrWuw+kKFoeM7VZL9ngzXZ8=; b=RVUY+TGRHYIxSzY2RmgsAWq8T65hCdBa7KYe1gWr+BCN7+gq3cIWypAC IYVs9khikD8gZkciUijxJcDB3rnDb7hvmcM2QvNrwQUf73UD5vn0WTq5J vGGo2AKBsFMOuGfeBwBMhfKnHfipmsHkR0UtyoGbk5qNaR06x9mRV5JCp aG9YQ5WHKqna3eS0HR2PIrldXxmD+fEl7pd2/PlTQZyx9bLYEzP28LKO4 HbuHK9y1DDHfQ7+7nrMx174DR2fR7WNtBQNtOe78hOAdODehrKmBV7jzN MWqMakb6jCSkDLJvpEjYts5O4MsAcj/CCqM8bTriLJ1KV5VIWJTY0gUpd g==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="336359849" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="336359849" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2023 19:36:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="707435595" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="707435595" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orsmga008.jf.intel.com with ESMTP; 08 Mar 2023 19:36:05 -0800 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v1 1/2] test/bbdev: fix possible div by zero issue Date: Wed, 8 Mar 2023 19:36:23 -0800 Message-Id: <20230309033624.61660-2-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230309033624.61660-1-hernan.vargas@intel.com> References: <20230309033624.61660-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add extra check at function level to ensure num_ops cannot be 0. Coverity issue: 383647 Fixes: f0d288bca467 ("test/bbdev: add support for BLER for 4G") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index e56d314e93b5..15ebcdfc1556 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -3722,6 +3722,7 @@ bler_pmd_lcore_ldpc_dec(void *arg) TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST), "BURST_SIZE should be <= %u", MAX_BURST); + TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0"); rte_bbdev_info_get(tp->dev_id, &info); @@ -3856,6 +3857,7 @@ bler_pmd_lcore_turbo_dec(void *arg) TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST), "BURST_SIZE should be <= %u", MAX_BURST); + TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0"); rte_bbdev_info_get(tp->dev_id, &info); From patchwork Thu Mar 9 03:36:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 124876 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09BE041E37; Thu, 9 Mar 2023 04:36:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 965B64161A; Thu, 9 Mar 2023 04:36:14 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 144EA40ED7; Thu, 9 Mar 2023 04:36:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678332970; x=1709868970; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=micC9+rYsli9hdjV68NXkd42NuzA4H446d8fx7tWFuM=; b=eInneiLaFLIm6OjoyRVXeyesOUE2rYJvnQiHmd+j2cLNUZKaAFfSF/DP +xJoAaIfpK42511LCldBSejJIemTZbC2HVkrFlLVvYgGv0r7N60L8Cvkb KhutjbLazYcc1USvS0zXd/dlCuMkqiC5EBpYximAi+gWYgaapOQv3vN0H 8FGkfQ4KZw4ezq5bcJiA65/OmjOIjuUD9sn5kd0GvqzhplpSE1+9oHL7N ZVzSm7IszC9MmLuT/SUMLXRcyhBTSXq6DlsdsMKpDJYHJRAXfiiRiVR2k lvSpG1XD+vUcd9sQf9xALaaXWeOWvhq66NbYn0W4PjMBa+g17K8kSz21l w==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="336359858" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="336359858" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2023 19:36:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="707435600" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="707435600" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orsmga008.jf.intel.com with ESMTP; 08 Mar 2023 19:36:06 -0800 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue Date: Wed, 8 Mar 2023 19:36:24 -0800 Message-Id: <20230309033624.61660-3-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230309033624.61660-1-hernan.vargas@intel.com> References: <20230309033624.61660-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add check for return value from get_bbdev_queue_stats. Coverity issue: 383155 Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 15ebcdfc1556..276bbf0a2e6d 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -5679,7 +5679,7 @@ static int offload_cost_test(struct active_device *ad, struct test_op_params *op_params) { - int iter; + int iter, ret; uint16_t burst_sz = op_params->burst_sz; const uint16_t num_to_process = op_params->num_to_process; const enum rte_bbdev_op_type op_type = test_vector.op_type; @@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad, rte_get_tsc_hz()); struct rte_bbdev_stats stats = {0}; - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + TEST_ASSERT_SUCCESS(ret, + "Failed to get stats for queue (%u) of device (%u)", + queue_id, ad->dev_id); if (stats.enqueue_warn_count > 0) printf("Warning reported on the queue : %10"PRIu64"\n", stats.enqueue_warn_count);