From patchwork Tue Feb 21 06:49:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124266 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B170C41CF8; Tue, 21 Feb 2023 07:49:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF55D4316D; Tue, 21 Feb 2023 07:49:55 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2126.outbound.protection.outlook.com [40.107.243.126]) by mails.dpdk.org (Postfix) with ESMTP id F035E43157; Tue, 21 Feb 2023 07:49:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FSrOAe2GIAvWj9K56rFXjb3q6biTN7tCkBxpOCLszqJmdt2RrP6+yk3SlNl4H3p53ON6BvtZC1CZg0My4n04mgRA5l/osgc+d3DTo0ERXaD+gEMxhaMlL9vdqinqvNSSDgeog+0NlZKxAY2Nb6b5hamsmxImCEBA7h9ripi8kDvED9fyebRi2ZNxfbBuFfseAz4vGiOOGS+dVTerLIMwjFka/H9HCity32UPbcZ+dGLtJ+R9YwoYlTz1K0OmPfMR7cIThBk1mN2ppSWNguTlwLcNgtPufQmGqG8TVOib8nLKIrrX+BBpAYf/z9aV4jFVkuQzsF63Ya/RcOifbeaetg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pr3Uu3+nnFy1Bw7famyLt7Po46TSxwTd3aayVNWvKlI=; b=d8XNkGCTNTnlghYw8OTuuCy63be5xXhtGO0JIPdZhWF/3WneIoppwq+VbakUu5cRrkyzDmR+P+oa3ajBfLY+02/V/W7pkf1u5kU5vFrG1p73x9+g7iW0gRVyg5APQBIgOpzLyg/1i67yqdcX6Yc1C5LeBPOVJ9RORIg9mpB6+dXyHbVUyZZzmybwQLbj+eGMBmkwVsPZ9WxTGOuPdoodg9P9BjMZzGtpuVbZjaDmpDUHNKe+eia9KsO8HAfMzGhUDGZR2Bp+BlGQQl/MFZVPCNYmdzkpHDLfM0dMmPDaoddD//LpNILrJHXnmYZsZewu3PferoOP/jAc3T4VuInEHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pr3Uu3+nnFy1Bw7famyLt7Po46TSxwTd3aayVNWvKlI=; b=UCj7C1Pwg2tDEnK2vB/WRu/KfeHmPrmjAS/NCMbFvKubvNiBz32b1GMHx1iNxb8g/o5GerxWJTWDsv+2Eohy/lwighAaMwjE4PLMabL2+QIuoNMSDgz3sbYO1nTmhJ33apjbGTseBr2bprg5rUJ2at9oiVEM27Rt15PmDqsZU/U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:49:50 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:49:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 1/6] net/nfp: fix the set MAC flow action Date: Tue, 21 Feb 2023 14:49:25 +0800 Message-Id: <20230221064930.3399-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: 453ed114-ece7-46af-303d-08db13d7d3c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XO7Hn5wI3pj6NMe7wIrE81SMzUtZeARBM/GzsE+ppLTFYTIYkFciFHgnwP9Pl/hZumUkH+bKGgrWR27fUgfFP38eN1WI2UlF5DbXJQw+gk9J25UJrTZMwFKiIsRuYmoHvhZgEgwuow6M2ilCqj4Q/qywPnFdPFnmneo+Mz6958wm0hevfGPHCtRetsjr99NKOkMLRc/fgYElNzninEQ+UuKZ7f65KIH/WBQXUIHiAxxLsgTne9Nn0jmgEf+rrljGZ5gxZQKbZAz4J6o//WTN4NJXsOVZznupm1S4JQoALlbpB0pKcKG16vF5cD1sHl0YXiC2pGBXFqJq/Z06VvhbmUu9Ly4KnrmCAhll978NkbVVQGmt0dMb87hnAZVzAUArP0OSojoTXMfhM/m1QL8MVRwKf3snFBC3f/ZWWhMwJ4HoXOMlO2xiLIW0CBFuj/O8CBO5R/opqxPAU15ZI6u4TQDtO+45/YF0CoqotCcOlE34AUCFEX1jLR4QR8mPeIah4i5uybrHFNu+EUFZBZiXeRBN7nOMrjCAcKXSFIFcOdA5JLwzXb2jJbHVUxsugBF9j0SJ2RryNYKsOQeut4x68wi58r/ULop2XN3kivxMgHD0N79K6ixxllcWJ353lOThPWg2oMuAah7HEQSNrTspEhn4BAlgkBE1DWoxMbWlE3lr7mB/tVPQ8sgJVURmoMtsAtO5vLj9cSJFR7VizuW/Nw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ioEQaIXc08e+H5SYF8yybUGSLQxS?= =?utf-8?q?Jxz1nlaoYrPGE1bdHzoVRC/vVVYBHYlrkr/xx4fc56/vwHmjNknderkr1zCSsvHs6?= =?utf-8?q?XOjXD860pcZDQQ1x/5sQffxhtiQV0GY6HsIOpZZeijJbUf4+OA+OqD0+7k3KcJukT?= =?utf-8?q?0hGwVZEMMiZhXDBuqMYnH4oqsk+keWB9CauWyBppz8qkbN8yhT0x0/WNnGWz8oI5t?= =?utf-8?q?tN1pqkskNy1slxQHZjB44wm1mODp/wiFXtk0DGwHx0USGKjAMQITG3l+jqGTPcHtu?= =?utf-8?q?D/E2Y2bMrhMuCSgDWgwC4yzkJqLL8RTAFtJH7Tp0rj+s9ha4A1h9KN9sKqulmGz2U?= =?utf-8?q?uZxwfIfLV0pz1RLuuZHI+Bjlfo/hh9uUiE36djFQiM7DLhZRsPOmLlJe2h+hs5udW?= =?utf-8?q?dNFGSxF8GtyuKgu9HaYp1rN3ow0/H8Pli8OpepAXoXJ/Pi19GqVxofZTKFH3pNReX?= =?utf-8?q?WjYs4v3E5jBU4AksdMa1ya4izR82fINpQpfNhalhYSgf266IINkmPh4jNdlNlSlBO?= =?utf-8?q?3liWO02MSjD3fdGaRiA+w8Pr9bNVuiRnvzgaqnjXvz7GgEwQnPwlA7Q5tYwDBK5BQ?= =?utf-8?q?DQesTGs0nKkThF3UGSe5HguEFHMX3rG2Ika/EABazk/l2J1wfZGve9MbPfaP61GxT?= =?utf-8?q?zVpIqEZQqAGt0kt8v6Cy9ZlR1bcOtrv6gtHh/eIzr+ZATNDuLzcbwIpMwyEAtDOjd?= =?utf-8?q?SibJ2dOAuBGoQ0RDEG8wyg64wnZbSsAvcoy5hCy34UOUpOgMBniBE//F0Wk/5m4fr?= =?utf-8?q?69qpGmfA5x2KWDI94whPydnvMciYWnCB5SfoXLKsznLbBkSDWcYyW0VFl0W8E5Rz3?= =?utf-8?q?3uEtHKAur83KFeWKNL/clSrWmUZP6OZRMuuwpg6h85ng1T9VTlDc2bbApvm/QBOuh?= =?utf-8?q?dX92wsD/IagfGOtW/tOqaAtPKFl+8hNpnXigRiFlSKoxLYrZcqaqytqt/KKEZFC5B?= =?utf-8?q?5jebOiIzCYIgjIyu/dbvRwcxNvKGAunoa27RwTpf+HVffQASnhjhokqmDOISVcnUz?= =?utf-8?q?qR8KNq0xhc38XCYJaGcLHv/xXWyk7G+oVdcQIApY6iilAQ64bRVDibaZD/BEYJbKz?= =?utf-8?q?SqkIZjwQasR91sjiENCdVxIuVScpZiJqexwo3EnwjoTtkA9JvQ6QCDYBnKSlNBmV/?= =?utf-8?q?K5rLgDZa5wn2oLUed8QL1z9xbzPGcdRp+fbg8anyRD5i8o+N9tK9h+ecoyelnVl4a?= =?utf-8?q?3AHDVNyNMGXVtr2yVf0O2P86TeYH3+mAbPogtF8b3awnF26UkMjWqJNCcsNATi6mU?= =?utf-8?q?M0ZFdp9INg7WbVeJEnMIZOE2U0PVvvk5T7x4LoHRdB+sxY5jgGac6p8mX72Jnq764?= =?utf-8?q?HXjH0XGpa80mww4NzgbEDYKjXDxOPIVxLgXYkBIZ7CTr+jclKbkd3/16axqN+boCs?= =?utf-8?q?EPvLC2/EMLDMOl9SEHrnfNs4kkhtj5HWbIfpjUw0X982qC83Uf7B5PRPScDVwCOmK?= =?utf-8?q?1aqGZHqSaNxMpeb2UrVrn9M23EGGlW0aEm7RVd8pAC6DRSINdqn89IjscZc+8Aox3?= =?utf-8?q?5fVvfaNtEoImRSMdbi8BVh/P371vfyaXog=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 453ed114-ece7-46af-303d-08db13d7d3c7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:49:49.7655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YbOZVSkx1RJkWSv3xyNV0zdeF0gdpItBgpAH9CEtvQiTNf/ME5gCmEoJjcpBq/C0j3wrLNaq2h1PyxqIiWLwAVZWZbO6E28/Uxz3+DKIFl0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set MAC source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right MAC address as expected. Fixes: 4f6983154570 ("net/nfp: support MAC source flow action") Fixes: eecc7ca3088a ("net/nfp: support MAC destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 0c38925701..f373171d7e 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2066,6 +2066,7 @@ nfp_flow_action_set_mac(char *act_data, bool mac_src_flag, bool mac_set_flag) { + uint8_t i; size_t act_size; struct nfp_fl_act_set_eth *set_eth; const struct rte_flow_action_set_mac *set_mac; @@ -2084,9 +2085,13 @@ nfp_flow_action_set_mac(char *act_data, if (mac_src_flag) { rte_memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN], set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) + set_eth->eth_addr_mask[RTE_ETHER_ADDR_LEN + i] = 0xff; } else { rte_memcpy(&set_eth->eth_addr[0], set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) + set_eth->eth_addr_mask[i] = 0xff; } } From patchwork Tue Feb 21 06:49:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124267 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F57D41CF8; Tue, 21 Feb 2023 07:50:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B3DF4318C; Tue, 21 Feb 2023 07:49:57 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2126.outbound.protection.outlook.com [40.107.243.126]) by mails.dpdk.org (Postfix) with ESMTP id 4BE8A40E5A; Tue, 21 Feb 2023 07:49:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aokJ5fL8Md87XMmjs6Eqbu4k6rzZHtvLqbZ9OuKOyypwesyPPFw4sISM8PKkYe/e5SxWT95VkQeR6VN6MIyYAAOBDLGTsQN9KCR34xxkE4fc96DRME7xDoUhXcRE0ZuPciTlX9NBGvLHDBHNTjj4gIVIcBmSzx02DSALz1fugIB8t/hNrSJJEHknaXBJ8Noh0NDujKSsoiYRyRum0RRYUJRRpAYIrY8GFgXaysja+Ex38L65OC46fHQ5zLdc40A7PT8MYO9e8mBjB1it1cZi3X2+K+U5ywhMRTfOSzZzQfh7GAP0Co1wEowO8qxfbchknhT6lSO1AGdxA12EqwnYiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wspGSCkYs5t536mMdZWzrpuZxnz0X1pOXyGsHWpIElU=; b=BaHtBL/jZGhLmOY58GlX2YxbUGm/aToeOjeF0Zh0Zb98usgftPYhb59lmW81R+cNy6/aMaj3yFtvsfD2rdYE9Ktc3+ghEvQGjKEZwKKgF6qVkKCs1QzilF+j5x5fT3RDYl/ndJ1U44C9fyIR5ZZlCMN2LXF24ZgRc5Ez363AhlIwubasM4u7aMp7Lq9NLZuJU5xxOujz8OskJJDbjJbWiOAAVM0N99jQsl+qebPME03mYXaio5+yd/jqxRbEsZQKnTkALrkhteIOUhBkEEk2O8gd7L0N8CXmD9RWS004Zg7KHm7vl6ybTmQCB6IUgcgMQU5R29qb0hXl4vCSG7l8uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wspGSCkYs5t536mMdZWzrpuZxnz0X1pOXyGsHWpIElU=; b=BWUBFjbEOu6jUFrZmcqPeCEF1TFyAq7y3zUaSoa4LR8EYyd+Y1ykMREce7x95I3bTGZUs4SJQcurcYJXb+DbZrZecndE2BBxPNhXIa4V6tpPCwpPfl+OQiyk0eLIBy5vHAddp+ENdhNhYuHQxSQ6lbG82zXAHOFKPHtH+oIFMks= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:49:52 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:49:52 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 2/6] net/nfp: fix the set IPv4 flow action Date: Tue, 21 Feb 2023 14:49:26 +0800 Message-Id: <20230221064930.3399-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: 728aae53-b74d-4c5d-c9b8-08db13d7d525 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NE8etRcJkQL+09LVaNmT1s3N3uJLOq11PKD6qRQlblWR3aHSWvD7CSroXysUrFyXTgCFYOCe+euPaACUAfuTr1ErnwE0QEwgSkCd2EiM9N48HTWuHjY8o9ed003t0XHV/Q90U/bLCyY4HF3wV0X9buL1ESOeuLMJRCNXGpBKo97yYqRsxMixWvdY5eDnPfiUGjt3Z6KtGNeYVDdqxr35DvcLSB0Nj1s3gr9qAwl1iIypXkamePVyU8SuQhBb667xdCwIN+XhasgLv1PlJQ2XgzUtnfgufKuy1y8FMpIpcjEF+DkHus/v+fAxBqb9wwVY6QeK6+SbxAFd2Vffbb4GTw7ws/HTcj+1KI35TxKPzszhGeY9ZTD5khYTxbz/g+XKxMh8pJAFmJKtYMV20T5sasBzONDLND01/CGDWAUjdAPPM1ebklhhqym3nEU3+KyjDnGam4fajHnA+A3UZGcVZdpXXKupOmm3tHLChobu7YvheQRf7EBw+x3ug4qaN7R9PJclLlCMq+A4s0IN+fq0yhxWA5kM9FyDppVgSsYG7YqUmiAITmMDYRlQIR5FJYeAHCxz1Boc4OFYinCrctg7jZpBR/tirIXDhX6zlhVtNBSPBw2QVt13O+S0IEMm4t50kla6+axyBA1Lvs4b6uZ43RUlOaASyo6zOu8sT94YYujPowXR3+WE2ctpXCjrl3w7AIcFUhUDxpvgfIq/R0JELA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?q3Uzqw3OraPDsIt061GjieXPkiz7?= =?utf-8?q?lz7yjD1DZO+bjX0A6rMCZvko+8B6pxq/vfnNionxvs17MUL/sxNHW42SXR1CvZFOo?= =?utf-8?q?jtutR/dzfmALmzk3AJFTUKV5eJEgZ4deuTmJBb2sAPig6PjID7luvxDKUjr2V9+x7?= =?utf-8?q?1t/0g/9QuCJoyHqrmHi6vpKQR+c8B6L1IRA/b6HmpEAirDL6/Wh0cObVolpqlzO4N?= =?utf-8?q?0lVfQdFh0OJe0UFBCpaJMxqb70L7sdAGKqDM/EMHUxtNWHScQ/9oUJe+I7nUVFAZs?= =?utf-8?q?lHMun+PDEbBfida0zExR+AI5875f/XoIqXb7TO996rpX7aXJp0y0rgTxqBHU08QIH?= =?utf-8?q?NNRJ6eMNrHIPLk+wOkCwujAOtkK/u/cMvrrGG1hbQ6vf9jjj2lFw24/RL/91GyyNq?= =?utf-8?q?Zve4UQQJGc8tjld7tqKMgou4FZLOYbkFH4BdSHbZO9U6yyW/chJg8hB8y0qENR/nA?= =?utf-8?q?nkxMD72DLJTY2VDr/JrM3cHCbaVszLx+WWKjxTDgRMomHTHqJ8HwVKeArIb8u7WJ0?= =?utf-8?q?k0/2owzw+By0SA9+msqxEFccseEhsI7ZEXBES9xsuqvJ9+vepvOVumq6Wu9eai581?= =?utf-8?q?CjV0zysbnPrLPtyV0J8H3qwcbyrq793j/dCVeZ9+DO2p1INDthBL36AJT31HA6UK5?= =?utf-8?q?pn6OL1Vn3KvWQr2C7IHHwnFETVUNakrVJFlESl/8W/HTzGBleX6BgPNIo4oxKvPdz?= =?utf-8?q?1bXJqGlek2X6muxZwjxauY97CC8ZWdvaL77QdaiRwM8K7E+oZbnjOepK64cp78eWj?= =?utf-8?q?iuiXtbSfguNwiOTj1rAuO4Z+2Ggb2uKYcx7cvGQaGdNkm8xBBEr0nGJa8dSBktm+R?= =?utf-8?q?jEzAvYt7SoW20OygJownzcbPOb9Nf0NjRyjoYjQDxi88fL021s1Zi6Ov5I6masZOo?= =?utf-8?q?Ey71n/h+jik6RNHiw4ggP1DV603qb3wSjjMmmzvkUkBF4srQsdbYDrwByvex7K/uH?= =?utf-8?q?ammqKfBT/k/8VATrqfnsU2KkQRmnxpl0l7OUwpNZYmffEFIJ83X7H/Hkx/W9FJBv8?= =?utf-8?q?L8EmU8N5Crx2gM1SSiFHYssoqdVtB9g3wmZNO4OvC5xvGNEAh4wFREfv+K6DSOtQv?= =?utf-8?q?xan8Dn4c1251eA3G2/3lI2eKSDGKvD95+7Qv7AoRv8q+dvJ+QJ0zIF8kzEX2Li0UA?= =?utf-8?q?1rgOaIcgWp2pfp9VsXd7K86O9Ku7GaeZmHijIjZ+3vaGqRRfcw8SfBtAfjQ9ffMFF?= =?utf-8?q?cM3U64IXOlGLa31AzDAo4cbAHf7Dg3j+RkoAulTFe5E/o5gvw0LWlh8z3F40hJLYp?= =?utf-8?q?1X5BBajVwO/sZkUplCnIJlyVZ3Ta986dbJEtmsDTXME7LxxZEVqFze59SApwiFRwg?= =?utf-8?q?RHNkOLgdXQkjWj8bKI3SPTJuZ1eKWazmBpgteotKC8HKwa8dAcShPzh8nlNrJKiNY?= =?utf-8?q?FT7NVinggqAhINdBF1OfMeR/7K6NWvE0R5rAH1sq/CDH306UN1S+K0wPNv7ZvgAAX?= =?utf-8?q?gEs9dPCubPVwILi3alGw/btQ9fy4xn8fNaqCLqLNBbAIpgpIYZ7L/P6m2qBmeyibt?= =?utf-8?q?XidU1n/DH5NcCMm6ySyn95g6yIsWnp1kJg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 728aae53-b74d-4c5d-c9b8-08db13d7d525 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:49:52.1570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QLYYb5S/wu8jy4dHUVtjmmk7Cc8r8+GuYxH+iGnjYXNfwfFP6nVoDhSeUeQxI+d1ghrYU2jzrR7EQ1M8ieTwWT6KsMnYk4iKAqHC1Uj/qtc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv4 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4 address as expected. Fixes: ab80975b0a14 ("net/nfp: support IPv4 source flow action") Fixes: f85c1e05bff3 ("net/nfp: support IPv4 destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index f373171d7e..39493ce98d 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2132,10 +2132,13 @@ nfp_flow_action_set_ip(char *act_data, set_ip->reserved = 0; set_ipv4 = (const struct rte_flow_action_set_ipv4 *)action->conf; - if (ip_src_flag) + if (ip_src_flag) { set_ip->ipv4_src = set_ipv4->ipv4_addr; - else + set_ip->ipv4_src_mask = RTE_BE32(0xffffffff); + } else { set_ip->ipv4_dst = set_ipv4->ipv4_addr; + set_ip->ipv4_dst_mask = RTE_BE32(0xffffffff); + } } static void From patchwork Tue Feb 21 06:49:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124268 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C7E341CF8; Tue, 21 Feb 2023 07:50:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8287C43187; Tue, 21 Feb 2023 07:49:58 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2105.outbound.protection.outlook.com [40.107.101.105]) by mails.dpdk.org (Postfix) with ESMTP id DA8B743175; Tue, 21 Feb 2023 07:49:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WrjnexAHZyUeS04bY4GgwQKFaJXO/nmddnScgkZXeVz97+T0iIZ62Ajh2c7OZOIOZ23VxdNr9ihrNAaa3wNVSr5cPp+kDuRrTY8F7oGohHI2aCduIfoo7WjnbM4ZKOCQndzGeBkKZZXJHb2KSawm1P2NFCXWP5fb5NgBy4R81/WGR2Qf6vokz2YT7cch2Yy13fu4uvFjxv/gUpjP0gJ2HwtP6vOrD9yfygoYusDwPGZvwHlfD+DKIo3gO0l1u5ECOpBgl5r7Mn2LsqX9BkoGgCDHi6rwSZypAWm36QKyqz06As9ZCyHYtBzRQubePWbKtZ3TjKEqbO4wsgbjXXf3xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mUbK7qEJe7YmsUgmARIlhm733z4mUE0GY+ypuD3mb/4=; b=kgkayh31A01nFC6NpP6bKMA9XA9vyO2UeCrBwVPIpKELNPeLSSpCjJPwO5ovIKTYEcFxl6pKn2ImGLMk8UF8+XkjyO2Xz/KOcoLE4Oa2rPUa5TJLGjY6NPaTid0Fb9mjnj7Ap7UgNJVozeDedl7o2mMRRGqWjU1Yq9TcsVFK0ux0p9YUzjJhiAP+jfBEbEOHLFW0FaOSsLLO6X59Pv7vWQTOdj24T7cHCr3jy/iR4uIQeBRV5yme7D0ehtM/Y5GbgSq1FdJMJpiRPL2s+YSiVqRvIp87mgI4OaK9MWZ6CPtSkAs49GK6uQ1VZtrP2bOhITEQuVSRl0fJCY9ev+5DuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mUbK7qEJe7YmsUgmARIlhm733z4mUE0GY+ypuD3mb/4=; b=fodq8ctcGwaI2mGWrT8fgar/GY/hje/5WMxjwgdwEyHpizRH2LmS2jA6x6KDGubhBSVonZrWlsEMdNaQw6lWteEbnbbEoh7cfzoJ4M2Nr+PcTHH8Pfsuftg9Nqo2Ul6HLMjwELwzfPi0vijYJOpQ44WZQGNocDcQAwYKdDuEkgE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:49:55 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:49:55 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 3/6] net/nfp: fix the set IPv6 flow action Date: Tue, 21 Feb 2023 14:49:27 +0800 Message-Id: <20230221064930.3399-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: 04cd3afc-293c-41d3-2b71-08db13d7d6c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nXbwIaFahthfTeNDynWMo8uc9Y9wjN7KsTXyYJoONZdhDDGz83IfDyEj4ZADZtCPQsajTZaIU4IrmaE1gL3p+p3uqWdAAxpHHOBhX/x+wQwEZ81lBIZZrx2ltVbs1YbnFd+iQXmLahZN0bsXIvzq4kReO2y40bqt0mhnTb3vZKLJlIUarVKu9cKZWGMRWfIm+XE+IYjZ/G9aaQp84F3LYDT5IgbUjbaqv4mPKMpLLqlNIpML69skrlvCxNlvjWCiUZDFtBxycnM2tN/TQuvBuKPg7QsJ1+0zV/I6+xp5z1bb55ZziD70axgJlyST1f/hV5Buc1EBP07kfHWymbFdK8dydTIe5wUagEsRjMhmgeK+vFKTh/jFDwQjpfg/Sq5QV6bdJu/hqeH4I0jCpsqtrxCQyUmOK9DksbIAx0vriGKANDu3Kr1l5Qj3hWLnPuNGB/FKs1WbqoQDPmTnmm/bpCr3IFgNqt94yvnpxEiPX7aGSPbocbAKQNIS8FsZPQfj2MLVEB6Dh+wSjtLoXp89dVJlS1F4ZLX0keSSbuX6THOrDbCKwrSDKsZRpANRRebZzZI/cMcCwNxKbNqZmvXlBfrWVeYE2+bB4vhQgFkKc/PurAgdE6EHg31TbmIPxosO2WZugYj0KaMkGoN7BlJ3Oxlzp7T5GabsuMM+THBsH9RkRDNv6j4uZPHivp6Uv0piSm8Vde0MbK0s/YMPtSk6Hg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?28HqtM3DhlJzthrIgRaMJ55yyfoI?= =?utf-8?q?Y1/j4rJ26Y54sAEFCniSB/5RajjcXBQl3lk6t/ZZ6AP1xmBtWIsB+5KXbL4Y4tvM1?= =?utf-8?q?xTxZYLyzpXWwGb5yTSwj4wEKlCw6Qw4fQQSXFnTQVCyYFgaNt1Iohg+hOppm4adKy?= =?utf-8?q?0VBXRXpo2WQxOM44ejFSmEtkN7oENmm6MU5Q+mCcc8Zpu53Tb7KyHp/zi+oNQiW1d?= =?utf-8?q?ts/U3YFWwUSdVHxZSV1U20VL6ZyalOU5DT382Z3MeyukePQzDKp3u1MMVgbfLsZFt?= =?utf-8?q?TWYltuWd5GYvK+ZPb+zDC4jjziRua27nvysRRZCgnLSOZpSbkuqeQC1Eem38yZ+Bj?= =?utf-8?q?kqDwSTKyCcS1KE9+rBJrkZ3uNTeHVXmnTI6q9JJjsQBzpUU7HwrSBzqFvXqEXCIRs?= =?utf-8?q?yMJ+tf8SWk2S7HpLbpjlxHXb66alyslYkLXbaVlu5d9G23vTP/yIQEUlZKLEep/qH?= =?utf-8?q?IadSsOl1AxG8Mnj3rY9Fb/okW40UPj3HMCI7UMPDznNfgXTsM5f9S9j7mGBhnkLm6?= =?utf-8?q?EDJ7s43mXYWeJnm2CdfF5MEZKCbUKFVqNgX+QaqQSGR7D+cVLiYlN5CqhdwM9NTvQ?= =?utf-8?q?AqxtGPuuuyktiKgxn004WEC1DS56kJ6nDM/WZ9TGq6dtoIZSvr6qLAB4zn+ybWG+L?= =?utf-8?q?mTUjDZkskCzerPB5OhXeAWQ7LVlCMSALuAUBF2y/Q6HmP5wiew8ExIQ3l/xEqxO8w?= =?utf-8?q?B9eIK1Z9IUGB1+wr6XqLzAHf1yzLAUYnBvykyKExGquwNMa/fX8Z1JuKuuxKp9WwT?= =?utf-8?q?NiWyjUZwYAO0irSPHXP0dL9zyPS9QckizXMyzU5r3hu+RbHwCkrHp3TRL/gpPldAQ?= =?utf-8?q?xBA/Z9m6RpqG0vOV5UVQFAh7waJPbBe0v7O/2KSTporG/rL5zX501kruHEXurpZuL?= =?utf-8?q?e3DpTSegP705H74iCuczxbqSe7hTunesI+KfEsWTPTEnx1fEsN0fMttE3XGI6dFyZ?= =?utf-8?q?OV47T1aY5CQj1wDL8F2gUxy5SvfjPwWmyQ9ZfSzZ7jkSproBFvf83s1mw0alBlGb9?= =?utf-8?q?qdVRtdFeyfed4Og9vTsisWGqfQuVlDrPzNaQECuQpLUXr6NZV6RW5GWIMOX5o/etb?= =?utf-8?q?4ezhHi+iFCbBqAoZ1GEgKbSC5MWhTKarKlYesmiUYn5v/a/9dXP1rrwrfVBdb3y4A?= =?utf-8?q?eRWmL2Db7fBNWTrAZmlbZMEYdt5GtM2Lb7S3nB1/ZHuKyLnCTfy/RgSw3irmrsjI5?= =?utf-8?q?CPJSW3S7hDTKdPaKavEbYhsJUQ3QjKlSzUxmoNtuf8nADMa4TcChpk2tM118i4m5e?= =?utf-8?q?aLH9m3bIigaI0eY0eYkovLCoKHp094VFlGr0HeVRaAFKdbfQtMF4zUFvoCt8qwf35?= =?utf-8?q?hKLC6YaElyuApj4ObdvcvIEbqWd0FYYeNV5svGDAinAcyLEVZ3Ee9Agtgti+qI6Sl?= =?utf-8?q?Q/YeysPHIQJV7oAHDlINhYuiqVBLS8WEvuSAyH0BiIMXSbIOYP194ii4H4Y5a6sF4?= =?utf-8?q?82qx6Xfh92KrRSmqtfPe+itxl71DynK+D0xSEX6JvbZuGsJnqWw4SRl3uVxRwOb8P?= =?utf-8?q?kVHLU0OImRvZB1fKkfPTomq7x5827ef0Bw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04cd3afc-293c-41d3-2b71-08db13d7d6c7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:49:54.9092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DweVke0t7dvq1yIKFT0WTcyp+HDWZXzhTyEBY+DYIMR5ENA6yAEwqJXhDahqoN5t9S9dxWW4W0++UAR6lcFOcTQugoexrk+fv/KlrRcdGak= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv6 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv6 address as expected. Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action") Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 39493ce98d..a4561b08e8 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2163,8 +2163,10 @@ nfp_flow_action_set_ipv6(char *act_data, set_ip->head.len_lw = act_size >> NFP_FL_LW_SIZ; set_ip->reserved = 0; - for (i = 0; i < 4; i++) - set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i]; + for (i = 0; i < 4; i++) { + set_ip->ipv6[i].exact = *(const rte_be32_t *)&set_ipv6->ipv6_addr[i * 4]; + set_ip->ipv6[i].mask = RTE_BE32(0xffffffff); + } } static void From patchwork Tue Feb 21 06:49:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124269 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C9B441CF8; Tue, 21 Feb 2023 07:50:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 228BB43197; Tue, 21 Feb 2023 07:50:01 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2126.outbound.protection.outlook.com [40.107.243.126]) by mails.dpdk.org (Postfix) with ESMTP id E218C4318E; Tue, 21 Feb 2023 07:49:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CkaF8gEegEmoIOsq5cfcjX0FnR/Dtuxk3aHIR3ol390MATVLIk0cNYAD9MuIjbeBkD5uY2a2ng+MzuF33EK+voCeM18x+kVIHgEoAj7rR0QKk+DdEOc5kiZOYovUljGFIezm6YTbqm5SpMZEwBjdImMrFjb55/WMCU2EfrPAWG6sG6DPrFznKWDIPKplKLFahfMWwinHrU5Dz0rBz/u3iie3SrZ9sMqFJbL9spYjvlJN3j1TSUwRFJbHxYt38b0Y4kuhnY83KPT2sLrDfyQ/TVMeAJ4fbkHOKw1eQNZSiddwA8IdTwB90El6doB/OP3z6S+gKtpnklTK9VhL56RjfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HxvSBGEYnlBGcngeFvJiaPII8z867fOMaKU4VCg6edg=; b=YhNPdBBikO2KIbwYvZbRyHYlf+EzLMjXKs5259WnCb3PHC0GdJrgRzZYBfoN+ZWrqa9AVum1fuNVo43K40xvrDApu6/Lkt3YfWUOlJXvf+frzXP27ayHpmHMWr9F54WzLCE3oMWhs90jU5V5ID8cX94f2ISgsUDZjrBA12CT0TxQICd6+y1dXgJjCJBO6B0KmqOjCqK8jFEGX14vwVofPOtn/1ZnpzS9fcD/7MGJSslZEz38a0V+IzcuxSkWOyEt7FEzQWNkIDchCLpFxmLluMuHHv/Eb8WUywNVfpb36Kog+jb+lV2niJtI8nDLN/SvmDo4DZ6sUF2XZdCwgU6g+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HxvSBGEYnlBGcngeFvJiaPII8z867fOMaKU4VCg6edg=; b=idvCxdzV1O703MOD79oXQGf9J0D4+oCc/+nYbUyLGWo4lOSL8eOVsOEQKMPV3uoe1TuJMTrqfh+tGj7NgoY0lN7OF1aZ6uIsXVMojAsgrzE8MY8eKbtM7EDsPv86uqg32kG6sLCd52UX46mLsgRs+mdvbuKu4DiO/mUenIVuu3g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:49:57 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:49:57 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 4/6] net/nfp: fix the set TP flow action Date: Tue, 21 Feb 2023 14:49:28 +0800 Message-Id: <20230221064930.3399-5-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: 7df5e6b8-f7fb-45e2-9378-08db13d7d836 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ru0aLEZxhWuLO7uhZ2XczVvuPHQ6schlnr/l3srt/6EzuHjhby0j6UKKdxI8lRx3mVm03GXGiypMOchFW5n19PKjO4Sffrc/GfS22oKkiUJovb2X4l2U1PsU+tFZ9pVOezwV4BOx9xY4aX7J0uNa2B/286R4XykV9Ch/tiHh8K1STegCaT+mWF0tBMdiTgcFYeE5IMQ/1ViAR0+e/LSg2gr0CJxNu7N7U/iA+Kx83Plb6VXgdJDe4Q7D073u6Q7PmHn5APoUPO7ZsrCbDB+hFLY/lFeMQddj2BR7xK8f7p8hJKr1WafQPmMOtbl02QEjjmrm7CwnfQOS/slrcMdUKmzQKRR94B+JZDMuKdkZLEEi5PdxPEfGuJ/4njinuRvDMv3pqWPC7JH/RBjnX5cpxXFenHxxNM/+Tpl6YzZ8CXj45H/ZjFijzz5hEAtzf9XqriZLO+FWJOcoGzeQDwZuDFzUcEEPsSLDIGuGFA1h0hVuEe+TChED3XhT0EWMdDCbkCmJ1G+N5VO8GLENG/uxbY5ZFROdem/zL5O6979zZsbTN0Nkos9agezNcS+XsaOUc7+P+7r+XdA09Wq08zVvi4crwpUpF+lR4pDmc/xfxLCIhQSXOqjm0KyHVn0UGZtkQRKMhdEI4713naz2VC1CjwIlLgoNzOUrm7AD49Gi5BXqzavxkqjfpcPmWKiK66N7PWxgiAugqBCB45AF+EbmGA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OzsjRFTAnwEeero2ro18T3TdTdCZ?= =?utf-8?q?DmPqoG4mF2nH91lFafjg4Knh4FutqHLnj6TUO17P1RSAyEzs423FZMmuWXWpwha3D?= =?utf-8?q?tVqk42gmUJR9ErBlh2BQgziIvgyLJUx04N3kLq0yEUQ4MxidicXEZtl31RjH5eaig?= =?utf-8?q?8jdkyllyodFTOZ3YENLpKuOCiK0hzRZxgbclqvkbpBOyr58mmL7UwkdbnaPlclhNt?= =?utf-8?q?LRj2X9wBOthHdSl9+EBjYCH7io2va0VkD2AvfZbRlqVxOMzrgIKcbOIxb5Htohcam?= =?utf-8?q?38jBkT6BTWVblLFhdn7HLRWTJxVqQa/D76SfZoeaY9/GSjt+M3m2Yu2Ad9y+ZwOKL?= =?utf-8?q?FiiYeUsVkXVeyXJH/idt/6RO532fx+qWBCyVPTc88mnAj7x/itUmCc4ukCl17Z/px?= =?utf-8?q?b6oae3oD/oBn3MeUKx0Gv4oe9XMlWrdxird5r0+KZwXTxzgAqwkhFmFJqA9PoZoSS?= =?utf-8?q?CVV6eE4QWmrpIHiLKTDash31kjv7rA78CivBB8i3gnv5BHsV+pLxCIgIUWvl5P1vZ?= =?utf-8?q?VpiarXl7DnHGGYHg7EHi+h8HeRNEFbktmDuGCAfZojtMlwQOZ707BowkV0S51X1k7?= =?utf-8?q?llRO78+TQ2pfguHQp2arUH7q6L7xha6GK9gd9FZIAYsqx4Oiis/6FSzZIF5OML6L6?= =?utf-8?q?pCZLzupdAO6l6u3RLpVrc1FUAJlBL/nhNbcaWv6n04VyPhX38lqPLWNrA9JSS00a+?= =?utf-8?q?43QjfYiwwjMJgZbHvIPtk33znnsiTy90G6xUfpxPnNmjDMMukPTHQhrWSo2RwYV49?= =?utf-8?q?vIw3Y8Bq6MVSletqlrP5qk0zDzzFvCWNCoVB97BFf290ZVq4T9Bl2/qGO9Lgc1lnp?= =?utf-8?q?3wSrXVzfJzVeRPj6ghgUQDp+ExaEyGNjTADS09KXWaD1jn9lbJZqCFp6Kf5fJpM5S?= =?utf-8?q?kut9Svsr2mpy8qCgwDqaAy4f7jZ+xjAHVpE8wBdRcWc3y40RZmCTfJMGbv5S3nXG0?= =?utf-8?q?wY7VcTTDVznDoBrtfzShGokBu9qgstiiHlrFpd9xbS6dEav1bbm4FYq1E7X0Ye49P?= =?utf-8?q?iLkYblqWbtFgpXolZ33DRSu0j3VcP96VJLlJ8H1RjJc2C4UCRXv1gmtZQ8eg+dsDi?= =?utf-8?q?TxYQAuw9yTvZ76iEXokaL3WYfbAO/tuE0QSWO9z6nFVoCiWhxnWVR54UJ654VKwXX?= =?utf-8?q?1zZTp6bU1ggIyPXqwAannBHeRAuF1ik7hN+lUmsIQdQJztUlvKu3WPwIQC+dCeMTU?= =?utf-8?q?lY8pIasGLoCVVXj11HD6jKcpfpwzdFmaom1Gchn6+S57ImVil6Q70Jenhbenz4bPM?= =?utf-8?q?ZBDwgw/SW1/sqELWXWhmeK5iYLbgQHvyYVC3GimAMzKsUL+6Gv/De4Y2Lsb60UCEd?= =?utf-8?q?d0Gbc3Hu+VP8elTyz23tdThBlorwzgZmOm9/noVwXVf7qoV2VAOBte/8KNLXDFqhn?= =?utf-8?q?7ZEVygC586QgCgO8HuU/KBUFzoID5x+qGZMSFfS+QCZ98snM3RR1rcQs79XfD61En?= =?utf-8?q?ffSo2bsOxmF6zwqIh8CYuKeQRY1czBS47gA9mUoFElC1qsCA828/TIfKTDEJ1aJBO?= =?utf-8?q?BPrUK1z5omzz/ulvO7AV/UfQXOkXjkOmcQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7df5e6b8-f7fb-45e2-9378-08db13d7d836 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:49:57.3158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z+PvOZyI7OAuE0400Qyki7ZmFfI/lx2EQk+Ll5NnvCEgRlAZtHq4ldpGqfYxzdg53jqMFzFEeqKko6dyFC24fb7vhWkFl6tDroEjCu3Plms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set TP source/destination flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TP as expected. Fixes: fc185097bbe6 ("net/nfp: support TP source flow action") Fixes: 87986df09d75 ("net/nfp: support TP destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index a4561b08e8..f22e89e1ea 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2190,10 +2190,13 @@ nfp_flow_action_set_tp(char *act_data, set_tp->reserved = 0; set_tp_conf = (const struct rte_flow_action_set_tp *)action->conf; - if (tp_src_flag) + if (tp_src_flag) { set_tp->src_port = set_tp_conf->port; - else + set_tp->src_port_mask = RTE_BE16(0xffff); + } else { set_tp->dst_port = set_tp_conf->port; + set_tp->dst_port_mask = RTE_BE16(0xffff); + } } static int From patchwork Tue Feb 21 06:49:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124270 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1270E41CF8; Tue, 21 Feb 2023 07:50:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73410431A3; Tue, 21 Feb 2023 07:50:02 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2121.outbound.protection.outlook.com [40.107.243.121]) by mails.dpdk.org (Postfix) with ESMTP id 52C1C43199; Tue, 21 Feb 2023 07:50:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFIrZ1imFBeT31lCnE5awKXRogLhq6QaVqp9WLoqfEBPsEtd5zSIoNc9LkZbIHNrDz1EP9/Y93runqDTEmUVe27/BH/gwA9JABW2cyOMEqCRUkE4l+vOmTAkVq1K/Ihd9Rs7YFAonoClRlHmvX555HkjD+FXpLxSlk/mM1+BHpndpHETMmUJXCQtcD+7JbpCS4wmYd+aUXmbDk0YnU4Npi0H89OvrxjrOHvMn75IsJDliTHe1uQwsXXAgceg6mS016cRbma3eNnHUZRn+IzvOLRcB+jkSckYeskfS0KNRB7G+8yvou2HxrIIs+R2AG+FzFkxhve655usfIkxtyvEog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5HieQ6nfU2Tvkxud5wZBQTEYAIYTvV0lmww4866JC/c=; b=DbBH+srrkyIEhhTJNFvCrQ4X7QaIeULysMIEv8sue4uEAc/ZPIEFri2B3oiS5S1MCDlrr+jiraaPpvjSxQG3Tdli0uP3yCjYhhBVmLCxWYlu+Z5tJ/rPyysep9E2Q3Ib77mGJJ4xRzN7fYIX7hF6FKUW9SjJTsZ82bI1qR/ceERehNpSrYPj2iMBhuPqGyEGurTkZeprtRiCy7bxLsU/t4+podlTRCH9IHSunbkX5BSeqner5co/fySusnu5uW9d5uIvNtDXXhlQOEmC1BcZSWGpGf6EpilTGXRf6ssX/IcfGz9gWAzypeV7oLIE3w8XD1OD5/3oQjOb3rm02i9iWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5HieQ6nfU2Tvkxud5wZBQTEYAIYTvV0lmww4866JC/c=; b=aXD5SC9e0IPmjUIpg0UczF+viVVedGeluZ1C6KmkUChfOQP12wHFYeJQ/8JUZh/LqpI1B01LeSQijwjN868xGiPO1jUWNsOF8OIY17OvggCeSEIqcu8U0PAIj37KmQGgi7K6xqFmZlVCLgaKY2tb9CXsM5Y6htWq+cPP6PHugjI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:50:00 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:49:59 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 5/6] net/nfp: fix the set TTL flow action Date: Tue, 21 Feb 2023 14:49:29 +0800 Message-Id: <20230221064930.3399-6-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aff2354-453e-4dea-41f5-08db13d7d9a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lb4ugTzLt68jhN2vBk8bkITlFJZsvrWE/TDWD0Sk/S8OjS3D2JLqOvcCGCkdKTpgN4qiVAhYpisyp/nrQxh8G5s0F9HlhdQR7lPe8rcwx+kzPt4U2y0mBvrSVSKxy3L+gFMbAMLTFm3bYgimyD/JeaKffnIfiY+AZ5xuIiGL1MIn+7ICZCO/6x1hpovQgUcHUuoH9Dj6uVVKfrqGdJ4Ubq9fkRLqotTmZLdkqACKO+SqTVtgKYwktdBsyknE2slfPbWN+kqSjbODfvgjQKfK30u6hJ1577i3eac4ydXv6/yDijzV/ktYrcvP0HrxgJNZUrl3RzQNfgwALnPYd0XOClwlFzy/oK8S11r5xR0Ong57xHYrVVrCIm9uJFnd5eraUofrtoEhnZHEU/xmENah2E+PXyvrs6gMddtz6C/Z1LHYK/9KKKqfhA0LwqPdu1n1dHpqAnxOoIo4FlwZOx0dMRLwnw96hFoFxH2cQyLODHvqf4e38dxYfldYKxeu6+JRTGrkMRaRzWXo/7kiYDIbmt0EInAuOzKPY7kl0XIKGsdfzLxeE9HT0acGKXDn6sNApXWymctSRD7vuEENSDi8cjxyvDApIqp1zVzWXXu2uS60Fdam8B0hDWVDvq+Ippv5ABoCLd/BaUpgzEVO+OLjwqNcuJDgHgoUAUzonv7ja99bRzB7z+D4Awzh4pxvqMMweklcrpROHoF8ThDIlpT0MA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(66574015)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?s6OTKUKBTRhvSlM7yVaASo300Gf1?= =?utf-8?q?yLEbel61npr1Y/Svqbmvzz/Y1Ug85SvtAxJuIDFZ6KfrjZ5Ps71xqm3DidDmwvcRD?= =?utf-8?q?okLlVsDwAhRrtonmFAWOEnuAyTrYksxDusBzP88qaqxbS9QaHSKFulWrSGe4xpV0C?= =?utf-8?q?pnpbDeP0YWSv+RR/DPxb+Lwrswr0UF7nlDO5OfR7nzSuasNtq9N+eAT3O/GRfPPGp?= =?utf-8?q?pGrEKbH5lFzfsEpKcXtoFar6XuOgcQghDzOmozPT1V0p2vFdM0CjZRwXjdyoEMFCK?= =?utf-8?q?CBL2KAtM6X5FCdR/sGIWNnrWGb5wzeEJsBNg1Syyz/4ptaJAOqP4U64w213I3pkv9?= =?utf-8?q?LVKsK1tJ7bVqNZ6Vw9c3vUrbT2gHan3LfwwkWXW98CY69pqlLDSDgE6Rfb+HQcZKC?= =?utf-8?q?kuoTuopSvE9kPQCAL/Z/E3HL8m8i9idQtMFbtn3tpGyTw7hgHvoglNgUqv/NORPgx?= =?utf-8?q?YCsa/XcMMN8OTSEa+ZfNmuhXYSfvMrQQQySrKVa6dlPH2nZ5dFPXfuoe3TDeQehBS?= =?utf-8?q?kCW/G0wfHUfJWyelwkWQoSJW1X4m9eQgeRVXHvzh+JGhIYJ/i1KvByBFqLAVdrQZE?= =?utf-8?q?8/vOihsw7jPf0ccndlYtPSl80Zrbqk2nsmJ+BzpwGbnz+8qI8LK+DLwoB4Ah2QnD/?= =?utf-8?q?a5szElnZhUdqQYpGkFuenP30EC2qKZfbi5XWA1r8NRcAQnwO/MmVwOJIG3XGpr4ci?= =?utf-8?q?jv5yNDKoTWyXSRpDnwG+Gsn4A37lqqhAluGj+jrKmz2ye60EPFyDi4fwq42QZXMp2?= =?utf-8?q?8Tof6zoPuyUhvgYs4DceObBlAWh/iCxSEE0bT8PykxrPdqMpVu2RQqyuPvwiaGyEG?= =?utf-8?q?kYN/OZYyvKkMcOkdjWxiFdPDeG8ZZgnrgcmiPH2h/TxdW763sgGctA2rWaIBbAetu?= =?utf-8?q?an24GByahor+thzP6atGZT9N342yIlAfROYRG4OyCwXhGr6deg6z4H6Fx8wynE8j/?= =?utf-8?q?ad2SFKnXLcmCWcbos44jpx7WVMnZZJooRWP+syquGND83qacfKwKtzg6NvB7zvzx6?= =?utf-8?q?EHALMc7TpwzUZvIqjj6rEHhzlVUnGHhJNLWWWco4V/vsHoVmfxpNHY+KBq5ERiGFt?= =?utf-8?q?1LRb+keDSETcWhCro9Q5p9FTyByiuWTU52/K5i/Lsu2wM4UOqEjJdskAZD+24Ebrp?= =?utf-8?q?QLvQC/BilMPEDnzLZwt0ip7A2LbrU1wtxa9UYlS10jLd9snrlxinwQKx88Za+182f?= =?utf-8?q?jLgChk32k1b25GXEVpgVdYweOMD9TE0iQkMERoVYXzUhGzWi6xPt00BpXoqOS2AB2?= =?utf-8?q?yf7CsEpT+JUjGdEpJpHnZv49Pjt0Rw1CijCE0L23U/II5TA1ATdWLppmG/u6c+693?= =?utf-8?q?bhzAMiGkAz4MgT3bQqKCAEadi072mplamet6amcvkIrBw1M0J5GwlswSSV+sXqItb?= =?utf-8?q?aZ51UkKwCpx1m/51Cros3ZZgv4x6qimN/Qvi1CN3BC/Fe0SYVsztezNcErw8Feiru?= =?utf-8?q?/2AehkKAGeksaylO6H48THqP88k4Kdi7eWeCX2WTWQOVOzTBVi25ccbWxXhXy5IOx?= =?utf-8?q?sHHo92gkaowlyZinHLxRw/hP3H0aWgnOlQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aff2354-453e-4dea-41f5-08db13d7d9a8 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:49:59.7698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XlBPVJT431P234oyXA6Ip0hCNEcVu+uQNDLEsPM72/IFTL84v/jETZO7S6YHoWkgag2Fe06HFLpv5WGvyxf6D5odc9KAyBFr7z+QYplcfrA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set TTL flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TTL as expected. Fixes: ac12e126c482 ("net/nfp: support TTL flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index f22e89e1ea..c6e19d8cac 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2252,6 +2252,7 @@ nfp_flow_action_set_ttl(char *act_data, ttl_conf = (const struct rte_flow_action_set_ttl *)action->conf; ttl_tos->ipv4_ttl = ttl_conf->ttl_value; + ttl_tos->ipv4_ttl_mask = 0xff; ttl_tos->reserved = 0; } @@ -2275,6 +2276,7 @@ nfp_flow_action_set_hl(char *act_data, ttl_conf = (const struct rte_flow_action_set_ttl *)action->conf; tc_hl->ipv6_hop_limit = ttl_conf->ttl_value; + tc_hl->ipv6_hop_limit_mask = 0xff; tc_hl->reserved = 0; } From patchwork Tue Feb 21 06:49:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124271 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D556441CF8; Tue, 21 Feb 2023 07:50:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9A02431AA; Tue, 21 Feb 2023 07:50:04 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2102.outbound.protection.outlook.com [40.107.243.102]) by mails.dpdk.org (Postfix) with ESMTP id 96B89431A6; Tue, 21 Feb 2023 07:50:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lm11CPg9z7g0yE3M0v6wchLVSrbi74k2S/GxpVnyl9fKiHCLo8TszBE1v9/AAlonbuuIa3s46CxF4KKP+7buincUVxnzErNQRrZV7dpBIqJ5oVgV7K1tnL1YFv9TsRShmmFO6qxJ/U7LuaNORwDky6Q55co3Cff2R6T6E/gpOoYm0P8gPCwQQY3jsqYTPx78a7lAxDCAPAEHUOUp1jWP7pvsuz+suYTuSVazAL/5E5Fqw3Z+g54JhO2At5holKpQxsUujUieMZP4TT4FZZ52CFYGNDKwSk8YsWLqhUHxwaHNN3Hzjj7YtioRHF5y30CSHQh3KpKg8ElABQG5QslrtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7CwuZbTNEVTEdxHvau5BXugEPtUlAPIJu+1Ed+GqX3g=; b=irB+38iy9W4hJW1UubRbUIq3Sd9Nmp56N9slsDHyJyS6WWeudAsq9HOBSoSHFRdTdu6Iody6coqlnAoStAS9tFt/HYHpGBGxgMf5+Q/cSVMl9BbkV3F/AgRSjPj6IKBlEz5asa7shvu0rbid4jH6y0/kRuvs72iQkqflPxL9AvBeGPUa+MN/2GSsyPkE/pmmlJe9mrNR2oEgc6y1dg0vEnMtEFxrHpaYg8tG63MftSCebFflYEyp8IuEsakPcXkYGC9RWZWlA4waIhjV8xdklMdeCs1gmY0Rd3RFXVdso/YUjRXP3rRViiXaLVELijqg+lOvOT0SToj0ioGqQsI7bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7CwuZbTNEVTEdxHvau5BXugEPtUlAPIJu+1Ed+GqX3g=; b=rCdxTuLjcFl+6Az51pUZrYUpB72i0y+9YfEgDV2aKEgGcv+Q0Umr7IDFC/NmT+Bo45zCqMQaGXgni1F7FnklcsC/xtOfniQj8RbN9wXxuK0SS5hEexpHTEsjcQdHaonM2sexQbQlA4ZVrvSgHriwUNQrivmTZWra07UKzDqwNsg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:50:02 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:50:02 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 6/6] net/nfp: fix the set IPv4/v6 DSCP flow action Date: Tue, 21 Feb 2023 14:49:30 +0800 Message-Id: <20230221064930.3399-7-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: d3c7333f-d82a-47fc-6971-08db13d7db17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jQpa+KnB1Q6PTCc8oesrZMC9tAegjeEhg05N/j0Sv8NJBs6CW0xEcODtE7zyQbR/hKgieOEDCQfb0jwiDkIyYjPiCoWsM/uRtmHzTTUuBznKAzQPl4XkjsjdGTwBD6DnyTMciKoc0H3AoaUYDNUnxxOBvOVZLW4FlFUI5FaDKntwNgBhfLhmnbXtm/PuShQFWqbQjctswDdtZOa5KIL+xDhGqYY/eAr1lP8fFzLORTrrbE0g/pX3MUWy/YDwKFBaZqItf5AYxUsWKzYi24DPSnkpxq57bOu8NG8406C/Hz9TEiH7xVJJcr9SNk5WuWDENT7dpzJ0rV8Lqb2p/Hfp3fbJgSD5UO9wOSmcZGRwlDe+tbtyKRsX+e+aIPT6RDas8OfA5Qv5saDbwQv/QDxcJwvtMFzPPgy8Vs6a2zvpBtHYiy/RSiwSwnv8pkZshS0KcI6OzCkPqCXbRzsEuoquGo4QhmmjZWVsAceG6tKZeUNPqPV3OdfKtFwwxP0PFHsNYVAU/fBcthZ5S5FviMweUriJ4801u2gUFVRmxRS+Mq6yEC2LOxfUZItfJNvX3glZIRlQv0mYyjXUzTU6uNYCqYn7eTOtwL+9n15SPPGTEX4OJXKpcp3IY4rblnHoh2DtmL9VcnPwO4JMalseoktlgdKbJNE0k7yXg4KZO3TbkMbESdH5Dfnn4TMXZ+NYNMHxCm1RnQeQv0dX/0/+uNapwg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OabQQlVCxLBJI2Lq9fPG7kKh3eoL?= =?utf-8?q?4bMTnPKXgpHHC+M9KwA4ZoiN2LZin2aRjMMLmKsF2O6EtY9wlQeqsFrqkLIwfFbaF?= =?utf-8?q?2PA/NqvX66ktgCWgcCb31SV4qYdgetxE+ph7cYBYmWJBBuN9p/cbWXVeNtA/E6Nv8?= =?utf-8?q?HzMco/GNsAt7z0bihD+MxWpjlxRHwdZy9JY19T0/3PjTVxgGZ638psfvb35AyurCK?= =?utf-8?q?loWAlqLcnmExgf1Ii+PQGYcXICL+WEVQA3JBtURprTT69Y+4mD0bsyugNssstHyzF?= =?utf-8?q?nApXteRhnnWQHH6rFWUzdClRqhaD5g2zwnyHybn1vnNQuYf2mRhzYaz6NLLDhjnWP?= =?utf-8?q?aS2hxQ0owWBVdFum3dA1A3huzi0+7dWFseJ7sLyji+zxL7hh9Au0390EzE2kDI55b?= =?utf-8?q?+gcRFhu0+4+55GBXEqKqi84jy2KjcQO9cf5FHpipZ4p1p9xJaBJX0QzvRGNMjb+P+?= =?utf-8?q?8hURz0viiclb5zczy2aI9iycimNWzoHXDIWg3zyxuFv1SU0NzCR8kdDVskSLO3bxH?= =?utf-8?q?3QzOM2pEm8klqKZUqItWWjgoHx/yg6lrY1CazbxCdAARZc3cjLhForOgyWKjVXFbw?= =?utf-8?q?RbZpXmu3596A4X17DZWn5zD4TOT5nr5IFYRnwhbreRCeyTR3b1B0Vxs7bYyXnOugR?= =?utf-8?q?1tcjn/RqqrqsCyeheKRuiDvDb+1Z72wXkbn2Ai8szP1qVFYP1qn+ceOHIK8kDAgzL?= =?utf-8?q?njC0bc+S5w4KILKFVMn1ZRYlLW0dQwDrxd+bwG9ExV7K1ZY5b1HHsg5djnNtJcGLM?= =?utf-8?q?ObCaaf9j0ZA7mpjKe1WWOi5jZSlHcx1eUlPAor8gcV2imAWTiCYZZgNdRZDqV+YlJ?= =?utf-8?q?Z6Tnap/gffll9fHAUsZkMjF4ILZcUDpLUdMrhnHepP1CNdyo6IXMX4Cx0qhpcZhTh?= =?utf-8?q?/GrckWIq5DASqCbMPpY+T02GTPJRreVM5QBjA5gDuGjKvmXzIM1rEY7f4MKAVIq18?= =?utf-8?q?E8v6HWONFluMxuQmn10PxqXzE2tbb+N5vzHTC52oPpmLNgxPLH3OeyPOuYmo0hjUW?= =?utf-8?q?Gk/fJCuQlU56ltMgYc7SnhkChMHqxNsHoszzfpo9mlplUj66Yjfb12IsfWTRPX7Dv?= =?utf-8?q?oWydscbKunuUPaMvEJzGXrnaQ+J5sRFvysQFPFABGP24CTjqksSPtsj7MfGAkuKbm?= =?utf-8?q?c7LDRiqSJnk12B68XcDF+AogxeNjmUEyKagsM7ayfrMD/sBer3W8yhi0VrZ5iA34/?= =?utf-8?q?l/nM466tCNDiQMI2CGPUuXz3KZuczoAguEzaHCbG77EhVzBm3ECLSqXG0+/DTgRwH?= =?utf-8?q?+Dt5PVQSyoLyINEyGGm4RgbKfVfoBPQW7hv/dkjgpbDRyGYd3bqw7Z6fLqQbfQSUf?= =?utf-8?q?/gmjP0vgqTyyMY62BXvI7CTGvW13cOJKBsYYFbx2vVbBbh5N0QtAEhrm3GSr6MxjU?= =?utf-8?q?w1Hgb/nCev2dM6BmnJ0DENI/O7ic9wvf+9io5osxIUNLVbMX5q1htVkq2OaIGQBmr?= =?utf-8?q?LQQfImz52Ylk0ZPv81dvRCbzzTnrk2CG9iREHuQa7vMqukWh+OgXkb0C7tc6ZYF5/?= =?utf-8?q?Wd65LT9Xh45cindow8ZXeE2MQIn9U2z2Aw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3c7333f-d82a-47fc-6971-08db13d7db17 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:50:02.1759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M4AfCTIyXkmQCzM9hcrgMvHBfeoVeZtF8CDVWDJlBm+ZU866RYzbFRNq5OPT+D66COqH4KJGWLD/6x2Rtc2HKng4rXIVfCLCAtPv4OQPDB8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv4/v6 DSCP flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4/v6 DSCP as expected. Fixes: 9c665d70f7a7 ("net/nfp: support IPv4 DSCP flow action") Fixes: 3202b003bec1 ("net/nfp: support IPv6 DSCP flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index c6e19d8cac..c8c57bc363 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2300,6 +2300,7 @@ nfp_flow_action_set_tos(char *act_data, tos_conf = (const struct rte_flow_action_set_dscp *)action->conf; ttl_tos->ipv4_tos = tos_conf->dscp; + ttl_tos->ipv4_tos_mask = 0xff; ttl_tos->reserved = 0; } @@ -2323,6 +2324,7 @@ nfp_flow_action_set_tc(char *act_data, tos_conf = (const struct rte_flow_action_set_dscp *)action->conf; tc_hl->ipv6_tc = tos_conf->dscp; + tc_hl->ipv6_tc_mask = 0xff; tc_hl->reserved = 0; }