From patchwork Tue Dec 4 08:28:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 48517 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5303E1B3BA; Tue, 4 Dec 2018 09:28:46 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6A64C1B3AE; Tue, 4 Dec 2018 09:28:45 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CD3E3082130; Tue, 4 Dec 2018 08:28:44 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-117-158.ams2.redhat.com [10.36.117.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76B3958B9; Tue, 4 Dec 2018 08:28:37 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, nhorman@tuxdriver.com, tredaelli@redhat.com, ferruh.yigit@intel.com, ivan.malov@oktetlabs.ru, arybchenko@solarflare.com Date: Tue, 4 Dec 2018 09:28:31 +0100 Message-Id: <1543912111-8106-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 04 Dec 2018 08:28:44 +0000 (UTC) Subject: [dpdk-dev] [PATCH] log: add missing experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When rte_log_register_type_and_pick_level() has been introduced, it has been correctly added to the EXPERIMENTAL section of the eal map and the symbol itself has been marked at its definition. However, the declaration of this symbol in rte_log.h is missing the __rte_experimental tag. Because of this, a user can try to call this symbol without being aware this is an experimental api (neither compilation nor link warning). Fixes: b22e77c02620 ("eal: register log type and pick level from args") Signed-off-by: David Marchand Acked-by: Neil Horman --- lib/librte_eal/common/include/rte_log.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index 2f789cb..f334efc 100644 --- a/lib/librte_eal/common/include/rte_log.h +++ b/lib/librte_eal/common/include/rte_log.h @@ -24,6 +24,7 @@ #include #include +#include struct rte_log_dynamic_type; @@ -226,6 +227,7 @@ struct rte_logs { * - >=0: the newly registered log type * - <0: rte_log_register() error value */ +__rte_experimental int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def); /**