From patchwork Mon Jan 9 03:40:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruifeng Wang X-Patchwork-Id: 121703 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 137E242376; Mon, 9 Jan 2023 04:40:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEC6B40687; Mon, 9 Jan 2023 04:40:37 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id E9B694067C; Mon, 9 Jan 2023 04:40:36 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 62B861042; Sun, 8 Jan 2023 19:41:18 -0800 (PST) Received: from net-arm-n1amp-02.shanghai.arm.com (net-arm-n1amp-02.shanghai.arm.com [10.169.210.108]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 931E13F67D; Sun, 8 Jan 2023 19:40:33 -0800 (PST) From: Ruifeng Wang To: kai.ji@intel.com, fanzhang.oss@gmail.com, gakhil@marvell.com Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com, feifei.wang2@arm.com, nd@arm.com, Ruifeng Wang Subject: [PATCH v2] crypto/openssl: fix warning on copy length Date: Mon, 9 Jan 2023 11:40:21 +0800 Message-Id: <20230109034021.2759215-1-ruifeng.wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230106101520.2736826-1-ruifeng.wang@arm.com> References: <20230106101520.2736826-1-ruifeng.wang@arm.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When building with gcc 11.2.0, the compiler warns as follows: In function 'memcpy', inlined from 'openssl_set_session_auth_parameters' at ../drivers/crypto/openssl/rte_openssl_pmd.c:699:3, inlined from 'openssl_set_session_parameters' at ../drivers/crypto/openssl/rte_openssl_pmd.c:826:9: /usr/include/aarch64-linux-gnu/bits/string_fortified.h:29:10: warning: '__builtin_memcpy' forming offset [4, 8] is out of the bounds [0, 4] [-Warray-bounds] Fixed the warning by copying up to string / buffer size. Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: stable@dpdk.org Cc: kai.ji@intel.com Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 05449b6e98..abcb641a44 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -696,7 +696,7 @@ openssl_set_session_auth_parameters(struct openssl_session *sess, algo = digest_name_get(xform->auth.algo); if (!algo) return -EINVAL; - rte_memcpy(algo_name, algo, (sizeof(algo)+1)); + strlcpy(algo_name, algo, sizeof(algo_name)); mac = EVP_MAC_fetch(NULL, "HMAC", NULL); sess->auth.hmac.ctx = EVP_MAC_CTX_new(mac);