From patchwork Fri Nov 18 08:53:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119953 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF630A0542; Fri, 18 Nov 2022 09:55:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FCB342D21; Fri, 18 Nov 2022 09:55:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D33C642D1D for ; Fri, 18 Nov 2022 09:55:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U2xQtFuJGTo2lRFar4K2kL1s546UJLYs6ItVgRrjKYc=; b=Gno27cUPunrlfrg+yeSf8qaPgoUlQd9sD13ncyqCDfQwVzTaqk9lxubkElkXGwsO9tIEXe ywnmO4mIsvgr1FTD/3Aph9ij7AJ+ozaSxM6p/7oR5qSNZ7cnf2d/lpWKR8M0Z08/xxIlRQ dyP8u6pLOHLUy6VImBy/gJ9zaOv3SPQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-164-yJayr8gQODe1u7x6SVEuEA-1; Fri, 18 Nov 2022 03:54:59 -0500 X-MC-Unique: yJayr8gQODe1u7x6SVEuEA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B7B418027FE; Fri, 18 Nov 2022 08:54:58 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3E6B40E9920; Fri, 18 Nov 2022 08:54:57 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Harry van Haaren , Jerin Jacob Subject: [PATCH 01/11] service: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:03 +0100 Message-Id: <20221118085313.2118977-2-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Bugzilla ID: 1130 Fixes: 21698354c832 ("service: introduce service cores concept") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Harry van Haaren --- lib/eal/common/rte_service.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c index bcc2e19077..42ca1d001d 100644 --- a/lib/eal/common/rte_service.c +++ b/lib/eal/common/rte_service.c @@ -107,14 +107,12 @@ rte_service_init(void) } int i; - int count = 0; struct rte_config *cfg = rte_eal_get_configuration(); for (i = 0; i < RTE_MAX_LCORE; i++) { if (lcore_config[i].core_role == ROLE_SERVICE) { if ((unsigned int)i == cfg->main_lcore) continue; rte_service_lcore_add(i); - count++; } } From patchwork Fri Nov 18 08:53:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119954 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2189A0542; Fri, 18 Nov 2022 09:55:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1165842D25; Fri, 18 Nov 2022 09:55:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DE5142D25 for ; Fri, 18 Nov 2022 09:55:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgbtBfgdHrWSNXT16Gk6MJgGPmO+pU9/GAEKvrOerso=; b=LKY5GRi32403+Tu8TALuwWEOd8K0M0tdGF6wwsZPC7vYq9lYNmkCpWDhFN69caK9loAJHS glvYn6Q3JMFOz7R6DyEY+Vh8XcxldC5glkUEjb1I/kJLoR9uhlsiMNb3U+BGV1QYm9QXDZ Muvjnsc1yMyGlqxCTl4ePA+eVug6MQ0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-CcMFQAaRONKfNuzay51ucA-1; Fri, 18 Nov 2022 03:55:02 -0500 X-MC-Unique: CcMFQAaRONKfNuzay51ucA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C7361C05EBD; Fri, 18 Nov 2022 08:55:02 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id E38372027063; Fri, 18 Nov 2022 08:55:00 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Maxime Coquelin , Chenbo Xia , Jiayu Hu , Cheng Jiang Subject: [PATCH 02/11] vhost: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:04 +0100 Message-Id: <20221118085313.2118977-3-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Fixes: abeb86525577 ("vhost: remove copy threshold for async path") Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 4358899718..9abf752f30 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -1877,7 +1877,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue struct rte_mbuf **pkts, uint32_t count, int16_t dma_id, uint16_t vchan_id) { uint32_t pkt_idx = 0; - uint32_t remained = count; uint16_t n_xfer; uint16_t num_buffers; uint16_t num_descs; @@ -1903,7 +1902,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue pkts_info[slot_idx].mbuf = pkts[pkt_idx]; pkt_idx++; - remained--; vq_inc_last_avail_packed(vq, num_descs); } while (pkt_idx < count); From patchwork Fri Nov 18 08:53:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119955 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6641A0542; Fri, 18 Nov 2022 09:55:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1E3242D2F; Fri, 18 Nov 2022 09:55:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 66F3642D27 for ; Fri, 18 Nov 2022 09:55:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+wnZZgNO7wpJGwyzIQWnbtoYomzzCIlKO/3BdF2Fo+w=; b=YO4AzIgNkpzlnGmCAlldRBGeGRLCF9as24CYiDO+azGRWaXYziTJ6ftyfQABA0ZGzM7xJZ VJZ+GEpAL/9xEExZ1aj8BRTK8BzKCTOSZFrbb97UI64/ZRViMvXMn20kuoGoJpQijieCiC SPSUa1s0Ndc4PhtWiN7iec3FRuj5no0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-339-yTVjeHu2PSSumxjpg4sgpA-1; Fri, 18 Nov 2022 03:55:06 -0500 X-MC-Unique: yTVjeHu2PSSumxjpg4sgpA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9D07833A0D; Fri, 18 Nov 2022 08:55:05 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DA79492B04; Fri, 18 Nov 2022 08:55:04 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Hemant Agrawal , Sachin Saxena , Shreyansh Jain , Roy Pledge , Geoff Thorpe Subject: [PATCH 03/11] bus/dpaa: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:05 +0100 Message-Id: <20221118085313.2118977-4-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/bus/dpaa/base/qbman/bman.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/bman.h b/drivers/bus/dpaa/base/qbman/bman.h index 21a6bee778..b2aa93e046 100644 --- a/drivers/bus/dpaa/base/qbman/bman.h +++ b/drivers/bus/dpaa/base/qbman/bman.h @@ -519,7 +519,6 @@ static inline int bm_shutdown_pool(struct bm_portal *p, u32 bpid) struct bm_mc_command *bm_cmd; struct bm_mc_result *bm_res; - int aq_count = 0; bool stop = false; while (!stop) { @@ -532,8 +531,7 @@ static inline int bm_shutdown_pool(struct bm_portal *p, u32 bpid) if (!(bm_res->verb & BM_MCR_VERB_ACQUIRE_BUFCOUNT)) { /* Pool is empty */ stop = true; - } else - ++aq_count; + } }; return 0; } From patchwork Fri Nov 18 08:53:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119956 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6347A0542; Fri, 18 Nov 2022 09:55:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E186D42D31; Fri, 18 Nov 2022 09:55:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A586F42D2B for ; Fri, 18 Nov 2022 09:55:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mowp3fRhH95mTtAvf2xhYOMztca9CcYuqk+RfYNfkX0=; b=aU1Y+GlfdLJqBL66vgbrr5BEOaeE3ilF8A/i0rg0v6QO9jwptIrNISHN8mGWHgg6BHajMf a75cKVywj5FjaAymN+k/OKFGhGGkfdNWkNTsamRFeAM+hO2BE31/r5MGYxDto3sbIqfQjH /46rS0Nd75hFRD91ROUSEV0gQaBS09A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-189-DchEbWsDPpukiOxOY5Utuw-1; Fri, 18 Nov 2022 03:55:09 -0500 X-MC-Unique: DchEbWsDPpukiOxOY5Utuw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C5B2E811E81; Fri, 18 Nov 2022 08:55:08 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB54B4EA59; Fri, 18 Nov 2022 08:55:07 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Igor Russkikh , Pavel Belous Subject: [PATCH 04/11] net/atlantic: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:06 +0100 Message-Id: <20221118085313.2118977-5-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/atlantic/atl_rxtx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index aeb79bf5a2..cb6f8141a8 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -1127,10 +1127,9 @@ atl_xmit_cleanup(struct atl_tx_queue *txq) if (txq != NULL) { sw_ring = txq->sw_ring; int head = txq->tx_head; - int cnt; - int i; + int cnt = head; - for (i = 0, cnt = head; ; i++) { + while (true) { txd = &txq->hw_ring[cnt]; if (txd->dd) From patchwork Fri Nov 18 08:53:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119957 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62641A0542; Fri, 18 Nov 2022 09:55:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DA5842D3C; Fri, 18 Nov 2022 09:55:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4DA4542D3B for ; Fri, 18 Nov 2022 09:55:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=23IWTLKyzE5I7nc4upJoOLmeAp6Co3jcYqX1kAn6iMA=; b=GXlPYTpJZA1jBmWzk/YDw1ggPXrcrDaRLD/TjKIGmc5IRxQjkDdJOXDWFZQTcB7vomD37I yo6K7LU7tpg9Xjegg+2D+H2bKarBLGXPGREzmMy2/uhJ2Qfk2VWBfUBlLLarcuisnTsfc/ lSayC1C2zpqXR1yFB8dkDLhIhVDMq4s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-80-vr4uRw1JPpKpW1JvFJi5Pw-1; Fri, 18 Nov 2022 03:55:12 -0500 X-MC-Unique: vr4uRw1JPpKpW1JvFJi5Pw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E63BE85A5B6; Fri, 18 Nov 2022 08:55:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8179C0297B; Fri, 18 Nov 2022 08:55:10 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Hemant Agrawal , Sachin Saxena , Nipun Gupta Subject: [PATCH 05/11] net/dpaa2: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:07 +0100 Message-Id: <20221118085313.2118977-6-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Fixes: 4690a6114ff6 ("net/dpaa2: enable error queues optionally") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/dpaa2/dpaa2_rxtx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index 5b02260e71..f60e78e1fd 100644 --- a/drivers/net/dpaa2/dpaa2_rxtx.c +++ b/drivers/net/dpaa2/dpaa2_rxtx.c @@ -620,7 +620,7 @@ dump_err_pkts(struct dpaa2_queue *dpaa2_q) /* Function receive frames for a given device and VQ */ struct qbman_result *dq_storage; uint32_t fqid = dpaa2_q->fqid; - int ret, num_rx = 0, num_pulled; + int ret, num_rx = 0; uint8_t pending, status; struct qbman_swp *swp; const struct qbman_fd *fd; @@ -660,7 +660,6 @@ dump_err_pkts(struct dpaa2_queue *dpaa2_q) while (!qbman_check_command_complete(dq_storage)) ; - num_pulled = 0; pending = 1; do { /* Loop until the dq_storage is updated with @@ -695,7 +694,6 @@ dump_err_pkts(struct dpaa2_queue *dpaa2_q) dq_storage++; num_rx++; - num_pulled++; } while (pending); dpaa2_q->err_pkts += num_rx; From patchwork Fri Nov 18 08:53:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119958 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC77A0542; Fri, 18 Nov 2022 09:55:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D48DB42D50; Fri, 18 Nov 2022 09:55:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DC2FE42D3A for ; Fri, 18 Nov 2022 09:55:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uUaniDga2fTY4DekwcSZ24+KNerZJu0Xf3Mn+J9nAb8=; b=h2uBgVPCs1N0AhAGQv4o3+/1vxYTDpvQOmW57XpUun4pIN7jC2XRT9nOOawxpG+IwrEqF+ 7tmZeRgsC0LoRNTYWvxJ8AMECBRFs7lsnDTnkHPy3ANrHr7ewlzEEqq5E7fgRij6DhqKb7 6OIpdGVZBOBjJUEXRLHYahvf6yZqkvg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-6nWA6ZAyObOPWJ2X7O7www-1; Fri, 18 Nov 2022 03:55:15 -0500 X-MC-Unique: 6nWA6ZAyObOPWJ2X7O7www-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F9E3383D0C7; Fri, 18 Nov 2022 08:55:15 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 149D640E9920; Fri, 18 Nov 2022 08:55:13 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Qiming Yang , Qi Zhang , Steve Yang Subject: [PATCH 06/11] net/ice: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:08 +0100 Message-Id: <20221118085313.2118977-7-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Fixes: 0d8d7bd720ba ("net/ice: support DDP dump switch rule binary") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/ice/ice_ddp_package.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ice/ice_ddp_package.c b/drivers/net/ice/ice_ddp_package.c index a27a4a2da2..0aa19eb282 100644 --- a/drivers/net/ice/ice_ddp_package.c +++ b/drivers/net/ice/ice_ddp_package.c @@ -439,7 +439,6 @@ ice_dump_switch(struct rte_eth_dev *dev, uint8_t **buff2, uint32_t *size) int i = 0; uint16_t tbl_id = 0; uint32_t tbl_idx = 0; - int tbl_cnt = 0; uint8_t *buffer = *buff2; hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); @@ -481,10 +480,8 @@ ice_dump_switch(struct rte_eth_dev *dev, uint8_t **buff2, uint32_t *size) free(buff); - tbl_cnt++; if (tbl_idx == 0xffffffff) { tbl_idx = 0; - tbl_cnt = 0; memset(buffer, '\n', sizeof(char)); buffer++; offset = 0; From patchwork Fri Nov 18 08:53:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119959 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BD76A0542; Fri, 18 Nov 2022 09:55:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E144142D4E; Fri, 18 Nov 2022 09:55:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0A01042D3B for ; Fri, 18 Nov 2022 09:55:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aMoPOzt+eX57oSNwRxnWA9fiC8fiS0u4N9em7sQCJJo=; b=Vc6J3aQYDpUkhOspQ0n3DXCpyy/m3hTxKGI3mGRIqZLuYbdoEEt5Ab2IZ3jHvEaWIoAI5h xNTG1U1nzlWpDC9Z7dh40b2pe4apnoHaFof73yIS4ramEHHp51GWv2AUHTXvHbE9AqLVMp tdm8vm0Pb2wb/W2cvMZxeXNUPXksH9c= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-UAMc2aXQPnWL2EYbj7rM8A-1; Fri, 18 Nov 2022 03:55:19 -0500 X-MC-Unique: UAMc2aXQPnWL2EYbj7rM8A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCE422932481; Fri, 18 Nov 2022 08:55:18 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51247492B15; Fri, 18 Nov 2022 08:55:17 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Kevin Traynor , Bernard Iremonger , Jens Freimann Subject: [PATCH 07/11] app/testpmd: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:09 +0100 Message-Id: <20221118085313.2118977-8-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is used to create some artificial load. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Cc: stable@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/noisy_vnf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c index b17a1febd3..c65ec6f06a 100644 --- a/app/test-pmd/noisy_vnf.c +++ b/app/test-pmd/noisy_vnf.c @@ -57,8 +57,8 @@ do_write(char *vnf_mem) static inline void do_read(char *vnf_mem) { + uint64_t r __rte_unused; uint64_t i = rte_rand(); - uint64_t r; r = vnf_mem[i % ((noisy_lkup_mem_sz * 1024 * 1024) / RTE_CACHE_LINE_SIZE)]; From patchwork Fri Nov 18 08:53:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119960 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3AE7A0542; Fri, 18 Nov 2022 09:55:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6271542D48; Fri, 18 Nov 2022 09:55:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A1BA42D3E for ; Fri, 18 Nov 2022 09:55:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKESblSIJB3eSeSYQ8o7n3EtLtN5yBqAyyPVnogtIQM=; b=BL5DvKq/gBgrL8BuWn3Pj2RORjqI6o+Ipi2J9j7/tTNFvfmWlRg7P6SpJI36sARBg1d/Rr oU7w3flZ2JE0wI07vFtII+JBjgcvarZk5oNMKjf9YIw/ONvCblfZHH6dujmirUG6xa14GQ kia5hmZk2MiD9Uq8EkgGCWLIAE+KNrs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-671-_tphYMHAPEyH7hdfce3paQ-1; Fri, 18 Nov 2022 03:55:23 -0500 X-MC-Unique: _tphYMHAPEyH7hdfce3paQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 033C3101A588; Fri, 18 Nov 2022 08:55:23 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E07918EB4; Fri, 18 Nov 2022 08:55:20 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Olga Shern , Adrien Mazarguil , Ajit Khaparde , Ori Kam , Andrey Vesnovaty , Alexander Kozyrev Subject: [PATCH 08/11] app/testpmd: fix build with clang 15 in flow code Date: Fri, 18 Nov 2022 09:53:10 +0100 Message-Id: <20221118085313.2118977-9-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used and has been copy/pasted in a lot of other code. Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Fixes: 55509e3a49fb ("app/testpmd: support shared flow action") Fixes: 04cc665fab38 ("app/testpmd: add flow template management") Fixes: c4b38873346b ("app/testpmd: add flow table management") Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations") Fixes: d906fff51878 ("app/testpmd: add async indirect actions operations") Cc: stable@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/config.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 982549ffed..9103ba6c77 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1787,7 +1787,6 @@ port_action_handle_destroy(portid_t port_id, { struct rte_port *port; struct port_indirect_action **tmp; - uint32_t c = 0; int ret = 0; if (port_id_is_invalid(port_id, ENABLED_WARN) || @@ -1822,7 +1821,6 @@ port_action_handle_destroy(portid_t port_id, } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } @@ -2251,7 +2249,6 @@ port_flow_pattern_template_destroy(portid_t port_id, uint32_t n, { struct rte_port *port; struct port_template **tmp; - uint32_t c = 0; int ret = 0; if (port_id_is_invalid(port_id, ENABLED_WARN) || @@ -2288,7 +2285,6 @@ port_flow_pattern_template_destroy(portid_t port_id, uint32_t n, } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } @@ -2368,7 +2364,6 @@ port_flow_actions_template_destroy(portid_t port_id, uint32_t n, { struct rte_port *port; struct port_template **tmp; - uint32_t c = 0; int ret = 0; if (port_id_is_invalid(port_id, ENABLED_WARN) || @@ -2404,7 +2399,6 @@ port_flow_actions_template_destroy(portid_t port_id, uint32_t n, } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } @@ -2534,7 +2528,6 @@ port_flow_template_table_destroy(portid_t port_id, { struct rte_port *port; struct port_table **tmp; - uint32_t c = 0; int ret = 0; if (port_id_is_invalid(port_id, ENABLED_WARN) || @@ -2571,7 +2564,6 @@ port_flow_template_table_destroy(portid_t port_id, } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } @@ -2719,7 +2711,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id, struct rte_flow_op_attr op_attr = { .postpone = postpone }; struct rte_port *port; struct port_flow **tmp; - uint32_t c = 0; int ret = 0; struct queue_job *job; @@ -2768,7 +2759,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id, } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } @@ -2836,7 +2826,6 @@ port_queue_action_handle_destroy(portid_t port_id, const struct rte_flow_op_attr attr = { .postpone = postpone}; struct rte_port *port; struct port_indirect_action **tmp; - uint32_t c = 0; int ret = 0; struct queue_job *job; @@ -2886,7 +2875,6 @@ port_queue_action_handle_destroy(portid_t port_id, } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } @@ -3304,7 +3292,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule) { struct rte_port *port; struct port_flow **tmp; - uint32_t c = 0; int ret = 0; if (port_id_is_invalid(port_id, ENABLED_WARN) || @@ -3337,7 +3324,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule) } if (i == n) tmp = &(*tmp)->next; - ++c; } return ret; } From patchwork Fri Nov 18 08:53:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119961 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CFF7A0542; Fri, 18 Nov 2022 09:55:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C10242D3E; Fri, 18 Nov 2022 09:55:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1F49142D24 for ; Fri, 18 Nov 2022 09:55:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKEYdX3u5XQfLLQNkdrRDTMFdVLz2mwx5CSv678XW2U=; b=LugLKqbhIVMXthDqeavjYK/g61QWkUOxj8fWqo6KqlH95jiV89kY4/eDR09WIFKCHaFKAn YkuzuSpcimgxbM+Jh3fClsX3b+yU5dPeu5Ym/s1/v8Qh4c/svY8b6Lx4xyFXjtKXbKDSpn u74ZbVO4+MOxh/BBuc/ps1TRY3rki/s= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-94-BslzbZ3YPImm1B0VeSk6ag-1; Fri, 18 Nov 2022 03:55:27 -0500 X-MC-Unique: BslzbZ3YPImm1B0VeSk6ag-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0DAF72932488; Fri, 18 Nov 2022 08:55:27 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CC742166B29; Fri, 18 Nov 2022 08:55:24 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Byron Marohn , Yipeng Wang , Saikrishna Edupuganti , Karla Saur , Christian Maciocco , Pablo de Lara Subject: [PATCH 09/11] test/efd: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:11 +0100 Message-Id: <20221118085313.2118977-10-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This local variable hides the more global one. The original intent was probably to use the global one. Fixes: 0e925aef2779 ("app/test: add EFD functional and perf tests") Cc: stable@dpdk.org Signed-off-by: David Marchand --- app/test/test_efd_perf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test/test_efd_perf.c b/app/test/test_efd_perf.c index d7f4d83549..4d04ed93e3 100644 --- a/app/test/test_efd_perf.c +++ b/app/test/test_efd_perf.c @@ -153,7 +153,6 @@ setup_keys_and_data(struct efd_perf_params *params, unsigned int cycle) qsort(keys, KEYS_TO_ADD, MAX_KEYSIZE, key_compare); /* Sift through the list of keys and look for duplicates */ - int num_duplicates = 0; for (i = 0; i < KEYS_TO_ADD - 1; i++) { if (memcmp(keys[i], keys[i + 1], params->key_size) == 0) { /* This key already exists, try again */ From patchwork Fri Nov 18 08:53:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119962 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C040A0542; Fri, 18 Nov 2022 09:56:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A848442D58; Fri, 18 Nov 2022 09:55:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 97C3D42D5D for ; Fri, 18 Nov 2022 09:55:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aRBJKh2QZHNS2MAcZvBCQk0zla4FywNluXEZyk6pUsk=; b=IblpCEJgBfz9O8tkyraUJMDjnnSGg3MLQ/dpCSeIqoNukGP6Ys75Ew5v1DcpQz7wEk6hdU Z69p2kKL4dkOItHSHN/ZMVbOn2EI0NJi2o+yvMsA1HShl2g96qug7Xds06NZyd5n5WV2K2 LPnPm31lSpsCz2we0TpAdxTXBWR9h7g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-523-fJiGka8MPvGIphuzQ-JKzA-1; Fri, 18 Nov 2022 03:55:30 -0500 X-MC-Unique: fJiGka8MPvGIphuzQ-JKzA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4AF38101A54E; Fri, 18 Nov 2022 08:55:30 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 319FD40E9920; Fri, 18 Nov 2022 08:55:29 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Yipeng Wang , Sameh Gobriel , Pablo de Lara Subject: [PATCH 10/11] test/member: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:12 +0100 Message-Id: <20221118085313.2118977-11-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This local variable hides the more global one. The original intent was probably to use the global one. Fixes: 0cc67a96e486 ("test/member: add functional and perf tests") Cc: stable@dpdk.org Signed-off-by: David Marchand --- app/test/test_member.c | 1 - app/test/test_member_perf.c | 1 - 2 files changed, 2 deletions(-) diff --git a/app/test/test_member.c b/app/test/test_member.c index c1b6a7d8b9..4a93f8bff4 100644 --- a/app/test/test_member.c +++ b/app/test/test_member.c @@ -573,7 +573,6 @@ setup_keys_and_data(void) qsort(generated_keys, MAX_ENTRIES, KEY_SIZE, key_compare); /* Sift through the list of keys and look for duplicates */ - int num_duplicates = 0; for (i = 0; i < MAX_ENTRIES - 1; i++) { if (memcmp(generated_keys[i], generated_keys[i + 1], KEY_SIZE) == 0) { diff --git a/app/test/test_member_perf.c b/app/test/test_member_perf.c index 7b6adf913e..2f79888fbd 100644 --- a/app/test/test_member_perf.c +++ b/app/test/test_member_perf.c @@ -178,7 +178,6 @@ setup_keys_and_data(struct member_perf_params *params, unsigned int cycle, qsort(keys, KEYS_TO_ADD, MAX_KEYSIZE, key_compare); /* Sift through the list of keys and look for duplicates */ - int num_duplicates = 0; for (i = 0; i < KEYS_TO_ADD - 1; i++) { if (memcmp(keys[i], keys[i + 1], params->key_size) == 0) { From patchwork Fri Nov 18 08:53:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 119963 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAC70A0542; Fri, 18 Nov 2022 09:56:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89D5642D56; Fri, 18 Nov 2022 09:55:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B638B42D5C for ; Fri, 18 Nov 2022 09:55:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668761735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eS1zi381qz1a2JAbp/lb3jnbGghys7LdfnqtWD8uY9g=; b=SlCdQKr5cIsFkT480aQ6ELpUeoiTRMtz+WuA3T8mJQ7MoLogH/En+nr1LKYohsf9Jxzj56 AJUU7UGmDwtQxH3qJFyehbzdYw8L+xHXcdTv2D9i/G92E3He31JpHNPXD0lT5jYkBIeWhy D2rIiJ39tk/7GLRyrwlhfmgpkpvz/kw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-PgGz84OCP2WA3F92XnL7Qw-1; Fri, 18 Nov 2022 03:55:33 -0500 X-MC-Unique: PgGz84OCP2WA3F92XnL7Qw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 443F53C0D855; Fri, 18 Nov 2022 08:55:33 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-54.brq.redhat.com [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 49855C0297B; Fri, 18 Nov 2022 08:55:32 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Erik Gabriel Carrillo , Pavan Nikhilesh Subject: [PATCH 11/11] test/event: fix build with clang 15 Date: Fri, 18 Nov 2022 09:53:13 +0100 Message-Id: <20221118085313.2118977-12-david.marchand@redhat.com> In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com> References: <20221118085313.2118977-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This variable is not used. Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") Cc: stable@dpdk.org Signed-off-by: David Marchand Tested-by: Daxue Gao --- app/test/test_event_timer_adapter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_timer_adapter.c index 654c412836..1a440dfd10 100644 --- a/app/test/test_event_timer_adapter.c +++ b/app/test/test_event_timer_adapter.c @@ -911,7 +911,6 @@ _cancel_thread(void *args) { RTE_SET_USED(args); struct rte_event_timer *ev_tim = NULL; - uint64_t cancel_count = 0; uint16_t ret; while (!arm_done || rte_ring_count(timer_producer_ring) > 0) { @@ -921,7 +920,6 @@ _cancel_thread(void *args) ret = rte_event_timer_cancel_burst(timdev, &ev_tim, 1); TEST_ASSERT_EQUAL(ret, 1, "Failed to cancel timer"); rte_mempool_put(eventdev_test_mempool, (void *)ev_tim); - cancel_count++; } return TEST_SUCCESS;