From patchwork Mon Nov 7 09:59:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Vesker X-Patchwork-Id: 119519 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A06FA0093; Mon, 7 Nov 2022 11:00:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22A1340156; Mon, 7 Nov 2022 11:00:19 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 4678640151 for ; Mon, 7 Nov 2022 11:00:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WJtabj+5aId6l8Jps5ywbNsAabrMA4VQHC77aQP66jaVVh/eKH96zHhlCIjcZmqU4779RgFrwe74N8eq56BYD7fcolGD3NQ6yh1M5s5YFwUhMbxKozT1TNUNWRPFk0PZ0TstWpUizPi9jAyXmS/uqtMLEbAq257kFFnfpQJzYGe7+NcOl+lxtvDgx8q6Ba+tOM8CyjHcEgnYH+EJHVK16dCbf9U6psFADLk22x/rg4neLx+lc+ROg3iaPsNAX3/6OQmsDSMHPUSS659V0CwbacW8Chkos3FZIlp8PN4hlV6rPvoabZwpDWQ9JSZ5EOlfX9KocZNCnBm0bWQkuHRNGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ikvifrNzU86WVFAfmJsr2Wgh5kOUvLe7KyCclfxL35Q=; b=IC/Jj7XA/LMYKrcW++en1WEaFHqjK/gFD4bk8PfyFM0m7ulNfZ2Ge2q8j0D/7JTZvbkfdsnh7NJGVaQvsXD8r9KQ74RBFVTBEc0V4v52ReMq0myJ7sdJZNab4ZofNR4pgp6CjUXNWhvzVURMF2jR/mgCrhOATHPWP5Pkb1d2zn9CmZYyWgrEiO5jYn2TStfQuL+lsnKH+A9ceWF+3LGSDiiqGEihVovvcmPJPJmEUyaN9Ho4AHtd/2B8sdP8jtn9/OJZ5O+ZfjtO1tHkC/+r7rIDbe+qI9e0t279R+M5lGcaS4UjlrfmEAEz5lWvzd6tLIgstLbVHFT8sg80DWTpLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ikvifrNzU86WVFAfmJsr2Wgh5kOUvLe7KyCclfxL35Q=; b=qLU4AMhotPXpIFHbrQ9h3zw1pjSmVTwKFpp2s9oqNiOwBPWP9BzcsXrUXBrRYVyR7tndS4QHVxorCEFuCVl+STBkgSoWzKAVP6B93p/17oDeFtHjfVEcOixEBkqQRnOb5om8KaZrKiai8Fjcqs4KVlf38h3uLgUIa2OPjybHelW8rKH0M90MLo2B4sAitFD+G18PNwYjTrZ7H3Wn4s7ppTwNAl5vJJ7NUoEgFGjlLXw/z+M2OBmnReD/41kTl4nbcF95DJ6D91D7kicAr/R1YdixT5/IKV/AhoUYV/IWWkHk/dyjkx+uSR7m/qh/pOMbwcGlC2EPOsI45kBDoP00bg== Received: from DS7PR03CA0034.namprd03.prod.outlook.com (2603:10b6:5:3b5::9) by BY5PR12MB4066.namprd12.prod.outlook.com (2603:10b6:a03:207::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 10:00:15 +0000 Received: from DM6NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::9f) by DS7PR03CA0034.outlook.office365.com (2603:10b6:5:3b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend Transport; Mon, 7 Nov 2022 10:00:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT097.mail.protection.outlook.com (10.13.172.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 10:00:14 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 7 Nov 2022 02:00:04 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 7 Nov 2022 02:00:02 -0800 From: Alex Vesker To: , , , , Matan Azrad CC: , Subject: [PATCH] net/mlx5/hws: fix possible action setter segmenation fault Date: Mon, 7 Nov 2022 11:59:48 +0200 Message-ID: <20221107095948.15177-1-valex@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20221103125108.7203-1-valex@nvidia.com> References: <20221103125108.7203-1-valex@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT097:EE_|BY5PR12MB4066:EE_ X-MS-Office365-Filtering-Correlation-Id: 024b2c5e-8a4b-4edb-9aba-08dac0a6de1a X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iKGUTT8RXt1ykRMS4GQEiMCjNH5mk+2tQZRGrWltmzqMgOBx2qjZ0xAo/yZpRh9zvVz4s49TYj5lm9aq9yWf+H+LqjJ67ol7i/K9r6hm/IOHzDsEapWW3klvDq7AFQxnxHNq4tt68v3skkBJbxb4NT8wGmRINT3OHNHtOINZLze1BHBvbJJv3pntW64z2mnzQHmn7L56p4wG0V8VPbI0S4g0q6DtyRED5QMIr09L5vKap0/HKcSUxIqreVPDU3f9MuMPAxKn6M64suZiNlxJ2MVI9Ld+WbLMFR/kRubxzYb21lRtaa8zajYqKXGXMuyJ77e0h8VzK4jhigAmQMA7iZW3VboR4ayFQxNERo4itIjshDuXhQGNUree6eV6H7BRJWsewVYqiX9mErMRIU7YrstHp3UdjDfhnsdqsTKORAXS8t871pFgEhFif3K5hDpcNBpWnFouq0imniyb5tFcmOl+7oiph16y0vfkuNv4rKBvRDl61ioeu52axg09oyEcekKzOyrcPAK0NO36TjPMkdLj/ITVnRcAd3pHiNddU2cLWpSo8LmLuAU3R0Cb2Ahbxsc1OheBY0yIH7OCMdd0MN0kmwuy8gDIEaDMz/J9PQvenOuJ2hFzGTNPwlq0NOPWWvWf6gbChsKaaP1rr/xk64WG8Oc/G4m9iH0SFSPCCD49ltFQXXSEuDl132dU8vWT0UlvxTjIme7FdM/LCcVrVBMGNh3gFwjk3zzCOn1Hvx9/65Am13gBnv1OVzIs2BvTyIj3VI6krLiXn82lJ1Putg== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39850400004)(396003)(346002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(82740400003)(26005)(5660300002)(47076005)(4744005)(6286002)(82310400005)(478600001)(316002)(36860700001)(110136005)(54906003)(2906002)(86362001)(7696005)(6636002)(41300700001)(8936002)(40480700001)(36756003)(6666004)(55016003)(107886003)(83380400001)(426003)(1076003)(4326008)(7636003)(8676002)(336012)(356005)(16526019)(186003)(2616005)(70586007)(40460700003)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:00:14.8017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 024b2c5e-8a4b-4edb-9aba-08dac0a6de1a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4066 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases. Current max was set to 7, but actual max is: Max TX: 8, Max RX: 10, Max FDB: 9 Fixes: f8c8a6d ("net/mlx5/hws: add action object") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.h b/drivers/net/mlx5/hws/mlx5dr_action.h index 3b31ffc90e..9a4827481a 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.h +++ b/drivers/net/mlx5/hws/mlx5dr_action.h @@ -6,7 +6,7 @@ #define MLX5DR_ACTION_H_ /* Max number of STEs needed for a rule (including match) */ -#define MLX5DR_ACTION_MAX_STE 7 +#define MLX5DR_ACTION_MAX_STE 10 enum mlx5dr_action_stc_idx { MLX5DR_ACTION_STC_IDX_CTRL = 0,