From patchwork Tue Oct 25 14:14:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ciara Power X-Patchwork-Id: 119107 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 335C7A054A; Tue, 25 Oct 2022 16:17:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E435942BF6; Tue, 25 Oct 2022 16:17:03 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 3329F42847 for ; Tue, 25 Oct 2022 16:17:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666707422; x=1698243422; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sYkg1Dvc74F1AuAwGtTh1035L1fZw3ESVQ6GjZW42cM=; b=LrWaaZV77ldfeLzp3J90LyuBdnQ+usG+fvQNVMstlLQAhG51CwLnube1 RmzO9IEJnOoePHaib5+jr9PWCQxNjVSHWUI2YTEFQSQtgbpLmt2d1oPI7 9TH04FpoxBJO+XARClE2sqfTyAdKhZzcyvhjxjw9Tkd9bjUaMWh0dx5qL pprU42Mb3Fsq2hxhdCE/9Ivbf8Ng06iblT94QGeIEM5I1/ujfPbXXs5uK 0rJ/XbBGitN+oPXi3ub+q2A0+OZT5mTUQpnp3vQ16838ZGPL9fKWeRuhT LMOHgWZAHGYytWQYZCpHo9nxSFG/Hhb3T3+9tdCLPeFO+C5amlOEYbWmD g==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="306413398" X-IronPort-AV: E=Sophos;i="5.95,212,1661842800"; d="scan'208";a="306413398" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2022 07:14:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="626433747" X-IronPort-AV: E=Sophos;i="5.95,212,1661842800"; d="scan'208";a="626433747" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.163]) by orsmga007.jf.intel.com with ESMTP; 25 Oct 2022 07:14:33 -0700 From: Ciara Power To: Ciara Power Cc: dev@dpdk.org, kai.ji@intel.com, gakhil@marvell.com Subject: [PATCH 1/2] app/test-crypto-perf: fix number of scheduler sessions Date: Tue, 25 Oct 2022 14:14:28 +0000 Message-Id: <20221025141429.3463350-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The scheduler PMD needs 1 session header, along with a session per worker. After the session rework, this change was made to other apps, for example l2fwd-crypto, but was missed in test-crypto-perf. Fixes: bdce2564dbf7 ("cryptodev: rework session framework") Cc: gakhil@marvell.com Signed-off-by: Ciara Power Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 420acc3c6d..0fe47c6caa 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -263,18 +263,14 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs) opts->segment_sz += (opts->headroom_sz + opts->tailroom_sz); uint32_t dev_max_nb_sess = cdev_info.sym.max_nb_sessions; - /* - * Two sessions objects are required for each session - * (one for the header, one for the private data) - */ if (!strcmp((const char *)opts->device_type, "crypto_scheduler")) { #ifdef RTE_CRYPTO_SCHEDULER uint32_t nb_slaves = rte_cryptodev_scheduler_workers_get(cdev_id, NULL); - - sessions_needed = enabled_cdev_count * + /* scheduler session header + 1 session per worker qp */ + sessions_needed = 1 + enabled_cdev_count * opts->nb_qps * nb_slaves; #endif } else From patchwork Tue Oct 25 14:14:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ciara Power X-Patchwork-Id: 119108 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06AE4A054A; Tue, 25 Oct 2022 16:17:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECC3F42C1E; Tue, 25 Oct 2022 16:17:12 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1A53342847 for ; Tue, 25 Oct 2022 16:17:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666707431; x=1698243431; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=goBsJ8CY0PBHnD5fjyr8D39HHX8G/3hJMJS398jGIew=; b=EMwNKfw9ISWDe/fvrmvNvhjHlNiJx5TLLyd8ECYyFCLxuNQQCIwCq42l +F7KSJVJf/VV2IhhrCDoUSBd+KFBDwMxw2XfLqamEcjMLwUbSrIau6fFh uzToRqIsHgImBITeL20M9ULcfafZQnkxFzl2MZCAlYBaGiCTeSSkZ6W8Z nPHUOHlApc/b3pviXsj8qQ0+stFRnJb9Vrw1KFTi1IVVs7lSRbRlFLnvq 87dqVAs8ZkRwhGLr9Gbj6AtFsoiVOUS2Rqrh5SyZXAGdnA7UkWbRkMTup Ojw9nT3OA6PnxYgmgoyYm6S9BFyVjbVP9oPJWPP0qlDQuUNuGQeICJuoF A==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="287403190" X-IronPort-AV: E=Sophos;i="5.95,212,1661842800"; d="scan'208";a="287403190" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2022 07:14:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="626433762" X-IronPort-AV: E=Sophos;i="5.95,212,1661842800"; d="scan'208";a="626433762" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.163]) by orsmga007.jf.intel.com with ESMTP; 25 Oct 2022 07:14:34 -0700 From: Ciara Power To: Kai Ji Cc: dev@dpdk.org, Ciara Power Subject: [PATCH 2/2] crypto/scheduler: fix op session in pkt size distr mode Date: Tue, 25 Oct 2022 14:14:29 +0000 Message-Id: <20221025141429.3463350-2-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025141429.3463350-1-ciara.power@intel.com> References: <20221025141429.3463350-1-ciara.power@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The index for sess_ctx was incorrect when setting the op session. Fixes: 6812b9bf470e ("crypto/scheduler: use unified session") Signed-off-by: Ciara Power --- drivers/crypto/scheduler/scheduler_pkt_size_distr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pkt_size_distr.c b/drivers/crypto/scheduler/scheduler_pkt_size_distr.c index 396cc3723d..41f05e6a47 100644 --- a/drivers/crypto/scheduler/scheduler_pkt_size_distr.c +++ b/drivers/crypto/scheduler/scheduler_pkt_size_distr.c @@ -148,7 +148,7 @@ schedule_enqueue(void *qp, struct rte_crypto_op **ops, uint16_t nb_ops) target[3] = !(job_len[3] & psd_qp_ctx->threshold); if (ops[i + 3]->sess_type == RTE_CRYPTO_OP_WITH_SESSION) ops[i + 3]->sym->session = - sess_ctx[1]->worker_sess[target[3]]; + sess_ctx[3]->worker_sess[target[3]]; p_enq_op = &enq_ops[target[3]]; if (p_enq_op->pos + in_flight_ops[p_enq_op->worker_idx] ==