From patchwork Sun Nov 11 15:24:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 47987 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4F3B548B; Sun, 11 Nov 2018 16:24:39 +0100 (CET) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780083.outbound.protection.outlook.com [40.107.78.83]) by dpdk.org (Postfix) with ESMTP id 7ECE2548B for ; Sun, 11 Nov 2018 16:24:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T0qjmo6gFkbmiWjAIh/i3bNH6iHag6bHGzzBwKqbYUo=; b=TOAAtBaSuCQhVShNLju9HOF1Cwq4JR/fo9G9SbT9BeNhvPIwp6v0lSH5MOyz8q2yJsY5WeugcO2tv1BuH0e9U++svNWRTMjfuIOXMZQnnuwwc6oNuO50cwjXTdmwslAmp+IV+m7q+iJPm2AvGy57IRxs+KaxNlpNplpE0OgFzys= Received: from SN6PR07MB4911.namprd07.prod.outlook.com (52.135.77.157) by SN6PR07MB4846.namprd07.prod.outlook.com (52.135.73.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Sun, 11 Nov 2018 15:24:36 +0000 Received: from SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4]) by SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4%3]) with mapi id 15.20.1294.044; Sun, 11 Nov 2018 15:24:36 +0000 From: Anoob Joseph To: Akhil Goyal , Pablo de Lara CC: "Joseph, Anoob" , "Jacob, Jerin" , "Athreya, Narayana Prasad" , "Dwivedi, Ankur" , "dev@dpdk.org" Thread-Topic: [PATCH 1/3] crypto/octeontx: fix non null terminated string Thread-Index: AQHUedKnrFHRvyhlrUCnS7PKzLOBzQ== Date: Sun, 11 Nov 2018 15:24:36 +0000 Message-ID: <1541949837-9629-2-git-send-email-anoob.joseph@caviumnetworks.com> References: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com> In-Reply-To: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-clientproxiedby: BM1PR0101CA0039.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::25) To SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4846; 6:elZLPgWQvZYe4Obe6+ypzvAT2zz24Yw8Zuo8x1OSZb0WOjViUx+AoIfd0XOiNhzghDqtZd4VAkzyt0qmmuKLEDXe90deI1geGev0bmGdTblxev20I15ooBAUH7P5kEmmaXt/rad+blvVsSqPAQLLXOoovt/0e5PXXR6upkXvSt+ZSqy2nC+ROD9lhJM3eXYcDkwmANeECbGiv9DUa2gxZuO7CFsODFJ9CHcLetzNsoU7VIdOwQGT/pwAbjQXG674P15kekK0gGN87n0CGV+zGhumj8upvCNL4FXrOZUn0ZwFME+uUu6FEJGh31fmFmSNsfz65MLi84oQY7GWIvIZiz1rDOPLUT+pULXZWggfb0/OOUecnWCxysh/BtZWtQPkl9RY0ChE3dsjSrcAeF1zVfuQQF4KaAeRcCKCnpT5pD0YTOY9Fo5K3lVoeyFyJiON0roSSRpnxayXjmm6xaLzVw==; 5:sajbvqb8dv+/FOazB+XDkVieZDxdPJzCjxU7/4H7HpasMnSvPAd3NCRyAIuNTZVDo9lfArTbrVBwZ2rt3jZXsfxxXDN+jr2XGLWOGD6gF/hYBxqYbkND4RlR1Dk9iWUEMrXSlcqAL6r8WlFWwBEcwC/XTCIQ0kOPcyqFdFtfaxE=; 7:jDDTIdALvDFTR68FFHtM93bxfq2XfUwyOHV5fhhTGAWPsC8YQj0O6iIvRiolBgH5F4q7MuyyV4n5N+KPFm+P0fm4l5cwiacolkuyIDbMyZsL4JUQskX+5nE/95IpqGIOBG97hs3wqZ949RselxWu9Q== x-ms-office365-filtering-correlation-id: 58dc86ce-db07-4dff-79f1-08d647e9c9ae x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390040)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4846; x-ms-traffictypediagnostic: SN6PR07MB4846: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231402)(944501410)(52105112)(10201501046)(3002001)(93006095)(148016)(149066)(150057)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB4846; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4846; x-forefront-prvs: 08534B37A7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(39850400004)(366004)(376002)(396003)(199004)(189003)(478600001)(6486002)(11346002)(446003)(2616005)(486006)(4326008)(476003)(66066001)(105586002)(5660300001)(6436002)(106356001)(68736007)(305945005)(2900100001)(7736002)(26005)(76176011)(42882007)(52116002)(14454004)(72206003)(25786009)(99286004)(97736004)(316002)(256004)(14444005)(71190400001)(110136005)(6116002)(54906003)(6512007)(53936002)(8936002)(81156014)(2906002)(3846002)(386003)(186003)(102836004)(6506007)(55236004)(8676002)(71200400001)(81166006)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4846; H:SN6PR07MB4911.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: XwgP5ACs2dGwLGwSJsCUcGktndTlwZ9DB03Lfj5rcCUyjkZk9o/tdMSZP17NkdvY9rhwrG0pWyydXpao32CjfMY9VAS/H2FgpEfo6RW0urBOZBrRL/mo5hOjy3oyla2mnxCYSCchgIMB6OERnIdbRflJwe2eMzDjLJvfQXRD58goodFfUZrj4/L+ZibvW7hD9UVrpetKFsNCE2/FSdpyQT5nq8hvSsm3lNHRxWYvrOn4KLAZ4nEMgPxEdZcy4jXyoOyXiD2BbSfGULu6UarBSpAd/Fmsk09ieLt9bGtOJMgpaF9FHX6xFZVgz1TyE9JhbY2KTZ4jg3Q+2YOH3eJ7qRNq+9522eVL+SFb3bsw4tw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58dc86ce-db07-4dff-79f1-08d647e9c9ae X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2018 15:24:36.0714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4846 Subject: [dpdk-dev] [PATCH 1/3] crypto/octeontx: fix non null terminated string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If the length of string pointed by 'name' is equal to or greater than the sizeof cptvf->dev_name string, the resultant string will not be null terminated. Using strlcpy would make sure the string would always be null terminated. Fixes: 0dc1cffa4d33 ("crypto/octeontx: add hardware init routine") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev_hw_access.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_hw_access.c b/drivers/crypto/octeontx/otx_cryptodev_hw_access.c index 5e705a8..18f2e6b 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_hw_access.c +++ b/drivers/crypto/octeontx/otx_cryptodev_hw_access.c @@ -9,6 +9,7 @@ #include #include #include +#include #include "otx_cryptodev_hw_access.h" #include "otx_cryptodev_mbox.h" @@ -366,7 +367,9 @@ otx_cpt_hw_init(struct cpt_vf *cptvf, void *pdev, void *reg_base, char *name) /* Bar0 base address */ cptvf->reg_base = reg_base; - strncpy(cptvf->dev_name, name, 32); + + /* Save device name */ + strlcpy(cptvf->dev_name, name, (sizeof(cptvf->dev_name))); cptvf->pdev = pdev; From patchwork Sun Nov 11 15:24:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 47988 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36B6358C6; Sun, 11 Nov 2018 16:24:42 +0100 (CET) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780072.outbound.protection.outlook.com [40.107.78.72]) by dpdk.org (Postfix) with ESMTP id 8F8F35699 for ; Sun, 11 Nov 2018 16:24:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f+rZZhDBRWEECjh9wvM1oKr2w6s9tc5NvnAQe4ToO8E=; b=lfkDH+kk0YqwI1eszlwRn0rMi4dG8e9UTclF+ac5+H3p2G8p2Q3zrzuxa+Dz4kclb4rYkQ36eev0lje17f9GnerkXuLoh8Qr1Q4NVIjQCkjpqvHWV16GbQZ0A9HA03IPapudFZGcT6k7QT97ecqurUHQM+LpVq/9jFDCko+sVSM= Received: from SN6PR07MB4911.namprd07.prod.outlook.com (52.135.77.157) by SN6PR07MB4846.namprd07.prod.outlook.com (52.135.73.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Sun, 11 Nov 2018 15:24:39 +0000 Received: from SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4]) by SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4%3]) with mapi id 15.20.1294.044; Sun, 11 Nov 2018 15:24:39 +0000 From: Anoob Joseph To: Akhil Goyal , Pablo de Lara CC: "Joseph, Anoob" , "Jacob, Jerin" , "Athreya, Narayana Prasad" , "Dwivedi, Ankur" , "dev@dpdk.org" Thread-Topic: [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing Thread-Index: AQHUedKpAd5bMeLd60u+S+3BLAzkYw== Date: Sun, 11 Nov 2018 15:24:39 +0000 Message-ID: <1541949837-9629-3-git-send-email-anoob.joseph@caviumnetworks.com> References: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com> In-Reply-To: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-clientproxiedby: BM1PR0101CA0039.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::25) To SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4846; 6:G7PTPQOl52ZN1/740jPHc8iStt/JtLvCWY3FRe4rGYC68bA1amjbjJgr21h8sOmCSoYrTGLMZ+KOCCsi0b7ptswqnnPM7+P1KbY3JpdQsM2zfIlA9fGe8+VvLoyi2sOu9pVJBQyGFt6RJqdbawlOBdGFYyVwq72Y1aiS8/Q7GixRJiiTgGONrVp6nKauo1CA4vynYKbHCqjEdQD0cN8bbGnHRBn36v0VSB7q0FcTqGkZwxNEC1O8oW9T8W/dQEC0/wjhO01qpCn/y6VSPhsQbalikxG7DCtt9XIP13yIT9AaO7AHftxD3IA/FfMQImtpZ/mUCCtRZ3dZzTX4dAe4BBIppvwt5tSDaOz3LHV2j+J3tlgu1GkyirglGexPD6gsGrXV2X7Mw2fQMzuQkNgHGuaYZ1FjVCKK9arJx8QyCQJHUddZ9tc02WefiCwe3gqC5a3UiVQUau/OlPLHxWkTMA==; 5:LJAoM3K8ZwIk8w/p+uFGTqp+9pPczEE02HlYDEna93kfr1KJWtTGNVw+uNQzmvmjGJw3AvmPPvvQ/eSR3hCzGXbWAtRrodqUIgZHwMa3A2xnL7vm8mpHX3sJ8psRDFJ9RzqO4i7BO102gVqBT6IbRnDxtl6dPPXDQN04GNG5nis=; 7:9rM333OW2+TM7ow+ftTHpyuUvvdbCXConCqg0psYYqh/XJDRzT4u8Eky+EienYyyHDHKEyp6JPNKckUyoXSqYXRlZh2FupODi1hHHD//JKGXVI9sdoQDKpDyPEgQCwqsWKr3xzdUV16UeDK8kXjfZA== x-ms-office365-filtering-correlation-id: f90bf268-5475-4660-cd33-08d647e9cb77 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390040)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4846; x-ms-traffictypediagnostic: SN6PR07MB4846: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231402)(944501410)(52105112)(10201501046)(3002001)(93006095)(148016)(149066)(150057)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB4846; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4846; x-forefront-prvs: 08534B37A7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(39850400004)(366004)(376002)(396003)(199004)(189003)(478600001)(6486002)(11346002)(446003)(2616005)(486006)(4326008)(476003)(66066001)(105586002)(5660300001)(6436002)(106356001)(68736007)(305945005)(2900100001)(7736002)(26005)(76176011)(42882007)(52116002)(14454004)(72206003)(25786009)(99286004)(97736004)(316002)(256004)(14444005)(71190400001)(110136005)(6116002)(54906003)(6512007)(53936002)(8936002)(81156014)(2906002)(575784001)(3846002)(386003)(186003)(102836004)(6506007)(55236004)(8676002)(71200400001)(81166006)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4846; H:SN6PR07MB4911.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ar9P+sJrTeeIyNlZKnut1iS0ELiZviNQ3hn9n45GD0kUhqrVIftO6uwd9Tkht9yXfPeglbXnKvFWeF4Reh/0n96+b1JVRDUYheS1JcUI2IEck0f8A/r9MOyrAawhl9GVZBH4xG54cp1ujcgHxCRfAdUEkNE2x46J3l7aYKc2jT3x8HuWQMh2jgs/gcArcAJ7y3TM2ptu6kb+HGngYwip31qWQzt7sX3VCcpUbLZSzx7NmZEexnmUH3Y4Y6Ntvsf9BgYbEkoM0bwHqSwo/0xN6fh+ZmaYGN12rnkpoDeXZuj0mcu4vSy+ur3DV1Pha9sBmg/heOejDjx2QPklLncbRUTL9l3Yuaa+kSLAQpPL8NI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: f90bf268-5475-4660-cd33-08d647e9cb77 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2018 15:24:39.1415 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4846 Subject: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c index 269f045..b201e0a 100644 --- a/drivers/crypto/octeontx/otx_cryptodev.c +++ b/drivers/crypto/octeontx/otx_cryptodev.c @@ -100,8 +100,8 @@ otx_cpt_pci_remove(struct rte_pci_device *pci_dev) if (rte_eal_process_type() == RTE_PROC_PRIMARY) rte_free(cryptodev->data->dev_private); - cryptodev->device = NULL; cryptodev->device->driver = NULL; + cryptodev->device = NULL; cryptodev->data = NULL; /* free metapool memory */ From patchwork Sun Nov 11 15:24:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 47989 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9A875699; Sun, 11 Nov 2018 16:24:45 +0100 (CET) Received: from NAM05-BY2-obe.outbound.protection.outlook.com (mail-eopbgr710054.outbound.protection.outlook.com [40.107.71.54]) by dpdk.org (Postfix) with ESMTP id D92BF58FE for ; Sun, 11 Nov 2018 16:24:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQ1zNYdBdDRgnmnUlKpOeHAJGO9v7EwKKeOSSk4eeWM=; b=eNPK2hG1RGigEfbbZ4X6LQzN+EGE0UiA5rlm1KepKybbkvloLTWLiXaoKlQ9GUKu8o/XHdFsxigYvfpsr8QwOpPNLjIua3Iazrzy069SL3r9JRdCiGPWwccvOztmUHDeQIdqHPuV458IaTosp+5dGhW6MTlWBayuV1wE3tnboM0= Received: from SN6PR07MB4911.namprd07.prod.outlook.com (52.135.77.157) by SN6PR07MB4846.namprd07.prod.outlook.com (52.135.73.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Sun, 11 Nov 2018 15:24:42 +0000 Received: from SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4]) by SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4%3]) with mapi id 15.20.1294.044; Sun, 11 Nov 2018 15:24:42 +0000 From: Anoob Joseph To: Akhil Goyal , Pablo de Lara CC: "Joseph, Anoob" , "Jacob, Jerin" , "Athreya, Narayana Prasad" , "Dwivedi, Ankur" , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] crypto/octeontx: fix null pointer dereferencing Thread-Index: AQHUedKrCxQgwR7i5kOaEmFrvrganw== Date: Sun, 11 Nov 2018 15:24:42 +0000 Message-ID: <1541949837-9629-4-git-send-email-anoob.joseph@caviumnetworks.com> References: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com> In-Reply-To: <1541949837-9629-1-git-send-email-anoob.joseph@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-clientproxiedby: BM1PR0101CA0039.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::25) To SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4846; 6:uz7GhVOswLwBsep/BWp1Laoih2CURSCNoQg4Y1uV+N1iRFrz0F3l2XWbcT+viUQTsCreKsGEKC4UsaSUyws9VQ+mNy5RvdsokQs0MR3T9h53YTI9nE2wlI6JCMdp4EiqQLiEjVeKcpib9MuuHa7APNaHQdPSRa0Bq2RzEKrRDoCBvKLI33jY2E9uQLZb7N0w18WN96AAx3igxQyD73WRzxLDwd1xk3jz5Lsx5OVU8Qt4RrM/A+/Rxng0ACWezd9zdxusEFL/6rksQoi148ciOpWFHVJ69lySCrbwvtE/xydy+MMxmM5zzZhuREg1UQpQUX6dCF0m4dx+1r5WLrmk4owtv3gtIv2O6Rnk0U45vmNN4GknVhPMxN7OHi6yMd0vNEz3Cirti3CYpI7HkjOsZ8fv2M6kPBf+jOaQAKnBT7q3aGWggOZ2Mf75KsRCiU9KSGNF23O9FkEj/n6MADuqvQ==; 5:XFTGRW0bLht6b7KI4K0q4vgky3Xj+mkpETyWGB0bSuLw0+YNDuArOsPyaPSa9RTAmsGcIhUEECM6o8NN6EnpadFq37rJZlVPl0Ua5rST903XhkwtTPskWHNAod6ruk75i5luJNFsRvNCprRFKEUSDB4oGNHM+Ezv6KzgEmYh1Ww=; 7:eqdqkpp7zzPIRg3GDrAa+qId+jBDRxeir387RVFs4ItnZOBDuvAL+reMjIgvlB5atkuiZjyxbYLYXv22/x/cMbad1y+CJFs5iZ/WwSsabRTMNqdw/7uKPojGnv3Kf94wLFyLO7sXkkN+J2vgmVOqkg== x-ms-office365-filtering-correlation-id: 3d4e237e-b874-4978-de9b-08d647e9cd4e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390040)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4846; x-ms-traffictypediagnostic: SN6PR07MB4846: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231402)(944501410)(52105112)(10201501046)(3002001)(93006095)(148016)(149066)(150057)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB4846; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4846; x-forefront-prvs: 08534B37A7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(39850400004)(366004)(376002)(396003)(199004)(189003)(478600001)(6486002)(11346002)(446003)(2616005)(486006)(4326008)(476003)(66066001)(105586002)(5660300001)(6436002)(106356001)(68736007)(305945005)(2900100001)(7736002)(26005)(76176011)(42882007)(52116002)(14454004)(72206003)(25786009)(99286004)(97736004)(316002)(256004)(14444005)(71190400001)(110136005)(6116002)(54906003)(6512007)(53936002)(8936002)(81156014)(2906002)(575784001)(3846002)(386003)(186003)(102836004)(6506007)(55236004)(8676002)(71200400001)(81166006)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4846; H:SN6PR07MB4911.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: izZkcR6KGyWgYbB05Un5bd0aKVyWhfg8isfuPvlvfZmEnb1H9XKHPNIh3bydY2hqOP3pWqvEn8CtVFySn1Ko7y8xLdRe6iU/mjmvM+8LX4714uVT0L1OhuG9vJNbxU0gN+7uoZ1Q3jfRvSwTgJpik6WB2rF8rZkp0w8Zkd10coMNYnaVm+DEXgmElgPjQm59mBjxgxjkPuMoM27T5gzI/aQU2ab8mCQFxUb2A+HBzTnW106eYmo2BE2dwJS6qpmxc17wKroWlBg84eets+lV4ISd8GDDstDD5TORU3ORat+vrhbNyqE/7EShyS0rq1YPHvhupvOVx1b9QUl1HQjtJ4hZiTMm6hR0RmEGDwQK7xk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d4e237e-b874-4978-de9b-08d647e9cd4e X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2018 15:24:42.3088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4846 Subject: [dpdk-dev] [PATCH 3/3] crypto/octeontx: fix null pointer dereferencing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function otx_cpt_get_resource() would be setting the pointer 'instance'. In case of error, 'instance' would be set to NULL, and returns rte_errno. If rte_errno when 'instance' is set to NULL, it can lead to NULL pointer dereferencing. Fixes: 0961348fdf52 ("crypto/octeontx: add queue pair functions") Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index 23f9659..90d0c14 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c @@ -216,7 +216,7 @@ otx_cpt_que_pair_setup(struct rte_cryptodev *dev, } ret = otx_cpt_get_resource(cptvf, 0, &instance); - if (ret != 0) { + if (ret != 0 || instance == NULL) { CPT_LOG_ERR("Error getting instance handle from device %s : " "ret = %d", dev->data->name, ret); return ret;