From patchwork Thu Feb 10 23:09:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 107306 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 865DEA00BE; Fri, 11 Feb 2022 00:09:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1D2D41169; Fri, 11 Feb 2022 00:09:13 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id CBBD64013F for ; Fri, 11 Feb 2022 00:09:11 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id 10so3190426plj.1 for ; Thu, 10 Feb 2022 15:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4g03cnWsKmnvSuAS2CELAlmMann/H8Z3gEd+k1j+F/E=; b=CMmHd2p7ymxoQnr3wXoDwHAegXYcCN9UlCg249SA/hSuEF7hJNfoTCWD7p0t4e9CWa qUZBZY6UBUCcYSHiJbR/qKUr+Yibfk3+shlHGSiSlyyiyaMA0FrjrWIZqd6nr8LHWM/N G8UGDs92PHy1PKr/DQTxecoV75tRQXDwIbE3Ncp5yk4Oz0fEFl6wKgkBV1tEcZSjSGdI /1LNHyLSLVxFzVZqewZ5/TRAtQjIUDGySs/TiN3Ket3TRuW+qprvb7YsX8ROEioU6LsN J2/IqeOs81f8Q00HXQSE0TBNjFPyql4KSS83w/7vCjXKZ0+xj0iJMSyIGM5FZfz1iZXz 2voA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4g03cnWsKmnvSuAS2CELAlmMann/H8Z3gEd+k1j+F/E=; b=BNPeaQBDzequNuz56o1+XFhMtcnEUGfXA0y5Amd0kscuy5f5TV5wDRr5mHD9l6GFUH ta7hQsrr1GKCbPNJS3aNQxC0ZUK9lhmsbFGhZhI1bfq8iaZ61NFQ5UBHVdnJ2conbx3B DotZld2p4o+IWVgskjHjYHzvnONSqxe1EDu20XlFpJ8x4I5QwnbO/hZIr49FkFoUdKa0 h7kOpd9aoSSkmzz8yaGHwGZj/hsKK0lKqGd8L+C/qLe9kA98C8XvskfRIgf72CxAJm+G 5QJ4MBJJLS2g6oaXQniCtwOBk3rkYk0TAHvPbYyW2BVVKWmQZ/hb3PxMMiWxN1KRpKlj 9Fig== X-Gm-Message-State: AOAM531MpAmrGHC0qQKoWOBVdPwHW6K7GLPYvIa1z232l73QDYatZG40 5UL/cLF5E4bE39Uo5M9wbfDdoKozv14yO9kW X-Google-Smtp-Source: ABdhPJyIypXvSMq/sdbKuDrJLmmWly0m5EIDBwm3+IWHuBHxnnyFKFy5NjT7MHgXEPA/kMO0G8eaRw== X-Received: by 2002:a17:902:ce88:: with SMTP id f8mr9483198plg.22.1644534550732; Thu, 10 Feb 2022 15:09:10 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id y191sm24924970pfb.114.2022.02.10.15.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 15:09:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 1/3] pcapng: handle rte_ethlink_get failing Date: Thu, 10 Feb 2022 15:09:04 -0800 Message-Id: <20220210230906.833163-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220210230906.833163-1-stephen@networkplumber.org> References: <20220210230906.833163-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If rte_ethlink_get fails, the code can just not add speed to the pcap file. Coverity issue: 373664 Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files") Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 03edabe73e96..9db058fe422b 100644 --- a/lib/pcapng/rte_pcapng.c +++ b/lib/pcapng/rte_pcapng.c @@ -177,8 +177,8 @@ pcapng_add_interface(rte_pcapng_t *self, uint16_t port) "%s-%s", dev->bus->name, dev->name); /* DPDK reports in units of Mbps */ - rte_eth_link_get(port, &link); - if (link.link_status == RTE_ETH_LINK_UP) + if (rte_eth_link_get(port, &link) == 0 && + link.link_status == RTE_ETH_LINK_UP) speed = link.link_speed * PCAPNG_MBPS_SPEED; if (rte_eth_macaddr_get(port, &macaddr) < 0) From patchwork Thu Feb 10 23:09:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 107307 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1689A00BE; Fri, 11 Feb 2022 00:09:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D82B34118A; Fri, 11 Feb 2022 00:09:15 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 60A964113C for ; Fri, 11 Feb 2022 00:09:13 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id r64-20020a17090a43c600b001b8854e682eso7143828pjg.0 for ; Thu, 10 Feb 2022 15:09:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GcKo7iGchep3EO6+jh8CsUbjdcNAUCIxZmtJcexeGs0=; b=gU9cq0qWFHMqEInRDP4lb0CPo44k/Fgd1L+GssnFvt0pvbEgkE4wD+bB3W5wn/ZJzK DI+dOQ16XFICKlAi7u+9SieK/XyWATAhUofWQCzWUxk6lMOMvOyJ3nspz9f0D4gMtJeB BtWOlNvhSt2g2Ck/M0wn95cewDFenp50JtOLuVegau7UMFqOG2kXMR2f0OVEFEeA/2US jiIH5yN2BvdVm/4p6qnFpTt7BAO9RgbJ21xZK393bCNNOe5YCSQyasqIKopbB4mcbxqM EbnlaQf7VkzW3hKwaXkzYp0tvBm1a65k3XP17+RqEQjeY3nFcuJgiePozFODL+lW6oti eXWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GcKo7iGchep3EO6+jh8CsUbjdcNAUCIxZmtJcexeGs0=; b=7ybYjyNDPEMYcQss5tqXii6rDZXZlI8CjwIoXBzqgRPhZk2UR/SJGqWxelBQEZtYBO NkwgLqAgBBWYNK4ytYtbawl0YagOgo085SEesxjh46q4vdj5Kq5eFNi5Ulrm2egDUGfr EhexTCQ2hxUadmJYVb18ywRw1ViDEynyN1fJ6+jB995eQprD95b15scC7lFrbbe0xRlU XqYDGdEneTx3WGh7y2W5GIVfB94+wkiAkRT0Yt2lKeFk30A7bfcjQLApVe72/28BWPdz qYICFinjEIKJfVcN1zf6Qm0FtMlfR9LztxiFQty3R0K+UnAHsGW7jyNlov5NlJQEOx0R mfXw== X-Gm-Message-State: AOAM533+qDF8Qr2gfimOXSpWFa0ozkuL9ETaDPy3jucpuuE7wwGlbsLI C2QTzPk+DNz06si8MxAsbhKAohUPK8j9fv2x X-Google-Smtp-Source: ABdhPJyNt6+tZ0hWi0lI5UwY+bdu/x3YGZYt2/FEx8AZIfrNRNRpap8rzPXgKFN6bwA7YGVakpsGMQ== X-Received: by 2002:a17:902:758c:: with SMTP id j12mr9554220pll.79.1644534552001; Thu, 10 Feb 2022 15:09:12 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id y191sm24924970pfb.114.2022.02.10.15.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 15:09:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 2/3] app/test_bpf: don't print eBPF program if NULL Date: Thu, 10 Feb 2022 15:09:05 -0800 Message-Id: <20220210230906.833163-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220210230906.833163-1-stephen@networkplumber.org> References: <20220210230906.833163-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If conversion of cBPF to eBPF fails (in rte_bpf_convert) then the test should not try and print the result. Coverity issue: 373661 Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/test_bpf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index d1e10adab545..805cce640667 100644 --- a/app/test/test_bpf.c +++ b/app/test/test_bpf.c @@ -3273,8 +3273,10 @@ test_bpf_dump(struct bpf_program *cbf, const struct rte_bpf_prm *prm) printf("cBPF program (%u insns)\n", cbf->bf_len); bpf_dump(cbf, 1); - printf("\neBPF program (%u insns)\n", prm->nb_ins); - rte_bpf_dump(stdout, prm->ins, prm->nb_ins); + if (prm != NULL) { + printf("\neBPF program (%u insns)\n", prm->nb_ins); + rte_bpf_dump(stdout, prm->ins, prm->nb_ins); + } } static int From patchwork Thu Feb 10 23:09:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 107308 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4693A00BE; Fri, 11 Feb 2022 00:09:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7CD3411B6; Fri, 11 Feb 2022 00:09:16 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 461D84118A for ; Fri, 11 Feb 2022 00:09:14 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id d9-20020a17090a498900b001b8bb1d00e7so7086106pjh.3 for ; Thu, 10 Feb 2022 15:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fi69yJP2LkZgVtyLqlVcHS9KZ69M6S03JlecoZzEoK8=; b=NBfWlDUt0VL4rhFHaMpwFd7PLLFFVYGUL7k3wD05Vah7g8ICbZIJUatbHptjcyFTjf Q9ifBOA/MjM1NSQOn64cLsvfOKNH0WXhT6vqAZmjj9GuIVAfY05HSVBMOD3biNr1qK4m hHr6p0yIYKARMrI8FODriftO2WRHTGJo3ZM/iM6DUIYqaYMCZwivQxHy+cpHzKKxa6s+ 9eos1f2ASzOvnKhzIGXk4D3N/TKHuwu0zSY7Hd3hjNA5LbhRn2bRy7rwDMS5vGuIWvhx 0G0Wn3mwb/lIvvJet9PwnWhRfbnNdd7SeV0faYQrQG8QwfiEoBZA3O23yPKSinqb6ibt SM8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fi69yJP2LkZgVtyLqlVcHS9KZ69M6S03JlecoZzEoK8=; b=Jlgc6ndOqk+Q9uBH584z8Nh2H5UCUSNc8W5IeTO0DfWuUX606+IFWMAmaOS5nSEqDi xgCRbexOpvPTXXaeh0kqhjqJ+SM3IhBtikXnzsrsGc6uT9Op8tEPKajBPh+LE0baEq86 zwf5MGb5Xc6r6SK31tf2It/txpwLYpzZVwmB1FHjrGSrI0JRJEUIDK5sRZaCKfe3Iarq djP7QcmlmbY6+6Fg0eLxAyNtXWTYTR5nY3nNcS7OTC7HalzllJFmU+IRVWnnTl0SYWFI ohryxWuklmUUaeQLB7gi4PoVFBeiU9u3hIL1+79ZGK7V3s89F3WTriO6wrhs+HXTlgKl aNxQ== X-Gm-Message-State: AOAM531Bl4Y4gMfQJPUMERFbGzPUNhx9PpM3QccSNxpfsjtY4Atws4o4 vXTmCzhVDvg40MP0GWXyYER7OPbRCjR1t5mW X-Google-Smtp-Source: ABdhPJx09TK+ALAMus+ZX3j87UgJ4fRWkDd+o8ek0mcGdz40I8JuysElXq+cZFle79OhQp7RFM+edg== X-Received: by 2002:a17:903:24f:: with SMTP id j15mr9668901plh.16.1644534553139; Thu, 10 Feb 2022 15:09:13 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id y191sm24924970pfb.114.2022.02.10.15.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 15:09:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 3/3] app/dumpcap: check for failure to set promiscious Date: Thu, 10 Feb 2022 15:09:06 -0800 Message-Id: <20220210230906.833163-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220210230906.833163-1-stephen@networkplumber.org> References: <20220210230906.833163-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the rte_eth_promiscious_enable() fails, then log the error and continue. Coverity issue: 373662 Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index c5fe4403028a..21cb2810a48f 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -679,8 +679,13 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp) flags |= RTE_PDUMP_FLAG_PCAPNG; TAILQ_FOREACH(intf, &interfaces, next) { - if (promiscuous_mode) - rte_eth_promiscuous_enable(intf->port); + if (promiscuous_mode) { + ret = rte_eth_promiscuous_enable(intf->port); + if (ret != 0) + fprintf(stderr, + "port %u set promicious enable faile: %d\n", + intf->port, ret); + } ret = rte_pdump_enable_bpf(intf->port, RTE_PDUMP_ALL_QUEUES, flags, snaplen,