From patchwork Thu Nov 11 10:56:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 104182 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D2A1A0548; Thu, 11 Nov 2021 11:56:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3A1B40E28; Thu, 11 Nov 2021 11:56:30 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id A829A40E03; Thu, 11 Nov 2021 11:56:29 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10164"; a="220097284" X-IronPort-AV: E=Sophos;i="5.87,225,1631602800"; d="scan'208";a="220097284" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 02:56:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,225,1631602800"; d="scan'208";a="583320620" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.49]) by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2021 02:56:26 -0800 From: Ciara Power To: dev@dpdk.org Cc: roy.fan.zhang@intel.com, Ciara Power , declan.doherty@intel.com, stable@dpdk.org, Akhil Goyal Subject: [PATCH] test/crypto: fix unnecessary stats retrieval Date: Thu, 11 Nov 2021 10:56:19 +0000 Message-Id: <20211111105619.638813-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The device stats are retrieved in the testcase teardown function, but are not being used afterwards. Remove this unnecessary call. The stats retrieval for the device is being tested already by a dedicated stats testcase. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Cc: declan.doherty@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power Acked-by: Anoob Joseph --- app/test/test_cryptodev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 52457596e2..a2f5e71be0 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -1417,7 +1417,6 @@ ut_teardown(void) { struct crypto_testsuite_params *ts_params = &testsuite_params; struct crypto_unittest_params *ut_params = &unittest_params; - struct rte_cryptodev_stats stats; /* free crypto session structure */ #ifdef RTE_LIB_SECURITY @@ -1464,8 +1463,6 @@ ut_teardown(void) RTE_LOG(DEBUG, USER1, "CRYPTO_MBUFPOOL count %u\n", rte_mempool_avail_count(ts_params->mbuf_pool)); - rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats); - /* Stop the device */ rte_cryptodev_stop(ts_params->valid_devs[0]); }