From patchwork Fri Oct 29 10:53:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijay Srivastava X-Patchwork-Id: 103233 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12608A0032; Fri, 29 Oct 2021 12:54:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBAE74111F; Fri, 29 Oct 2021 12:54:50 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by mails.dpdk.org (Postfix) with ESMTP id C85CD410E1 for ; Fri, 29 Oct 2021 12:54:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZSy1TPEuFQ7IRtL9P/2GQcjk3xfi18Kowb3VcA+TlaAankVVbCr6tzmEsfWVvIm521QpKjy22502cxbKDuNFPUrfMiICjR+ru2BNmd7EVS/hVZHw+wes8+dUhYdSDzuQ9c/YT6ptuQmSd5vdQaLVqjGQYiqmB95WLIfdlQTkV4e3djR+15ipzsIHx6iTFdCEbe5G5A2GPxgi2YK0T5f4EZHZTZejE4i1eielFLXnvhbFp4NeapLT9lgDAy1dR7PiU/SLzLHNjXN09kYvcBcSVS9mXtIX3Htmybwv8VimRtnbwVBt1rzX7fircl6bVPCOSo0EXaw/UULDOseLdiuDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8Aq2eDXs4V1S/XRKJ5upbDUckU+0qRaDHn0ZBDKGlA=; b=KvSxBuY8aJejDMj/iI70cu9d//Yge/PC5YT3oG8eUl3llPtEYJnHvPkTQ6oEsMZKmOwiU5Tj4faPG/k5ftDesV3zaUZ8mgoVfIzQr8pZvczpIDQQxCrs9A3iDf3fWlS8RtakWTLhnWaoyGsIzm5AtdB6ldGxzozGJScJteVFaw8XE2zPhD3qCkYyKMeoM5qVgRhH2SAQvZJOIZ2/n+i6F9CSspIiVYTaxbzG3ZcPUna2hFtUFkKuOulcWTvNshTNmECk7CUV9UUHiJSc5ojz7F7WtTCRH4xW4KsaLLoFzXOJJlmUTgrJOU11tW6U5847imhns8jLMwoe9QKe/BSivQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=dpdk.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8Aq2eDXs4V1S/XRKJ5upbDUckU+0qRaDHn0ZBDKGlA=; b=nq2bPi7ucvOMkbLxocvppPEiIn5yoa8PWXrQWhVYlMAs7nUYap+tVYKK3wtEzuJQsbJ8llU9HmCw/WSxBIM2xm9A6cCU4G2sUBfOHZD2DA/K0urGNZnerEeUNVv6bCb0PMSafu4uQ+t1MXea0oFXlYSNxNR8mLo00CGzvXK2FzE= Received: from BN0PR03CA0056.namprd03.prod.outlook.com (2603:10b6:408:e7::31) by BL3PR02MB8052.namprd02.prod.outlook.com (2603:10b6:208:35b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 10:54:47 +0000 Received: from BN1NAM02FT005.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e7:cafe::f5) by BN0PR03CA0056.outlook.office365.com (2603:10b6:408:e7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Fri, 29 Oct 2021 10:54:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT005.mail.protection.outlook.com (10.13.2.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4649.14 via Frontend Transport; Fri, 29 Oct 2021 10:54:47 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Oct 2021 03:54:47 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Oct 2021 03:54:47 -0700 Envelope-to: dev@dpdk.org, xuemingl@nvidia.com, andrew.rybchenko@oktetlabs.ru Received: from [10.170.66.108] (port=36542 helo=xndengvm004108.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mgPX4-000DoF-GS; Fri, 29 Oct 2021 03:54:46 -0700 From: Vijay Srivastava To: CC: , , , Vijay Srivastava Date: Fri, 29 Oct 2021 16:23:48 +0530 Message-ID: <20211029105348.10885-1-vsrivast@xilinx.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92493000-82b0-4792-7235-08d99aca862e X-MS-TrafficTypeDiagnostic: BL3PR02MB8052: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PteJxKGsZVONPcq9DUpFDnaMmkiuM+uPEeT1nBU5ZuQipXwsI6o6QPwQVwFC76iFt2razzHWc9Ra9+F40UCelb7lSpyYxOyc6LgunHSXPDUw6aB/v/KjES1tsBJ8BUPLPey9B/3B+MoUoGyOGAtY9UomeL5sB7tFhGAD83HyMWIQ8rDr+NoSpj6Ji5qat/ZWNq3sQ1jPhpyQaFM3oEcqJw+/96ztHDsOOVZWlDFis5Ij31JYhSZZd8YbbJl3EOgNSCmAEQ9SbCJ416zLHXR6BAkVss5ziE+2gPfQGrcAqsiRUes2D2KNTDzTXUkiiDD2BCpda8h7KeBPHmxz3xuTnFJ5E8oM0WhGFt9Nvx/X1FmLh24Vqmc+YSEl2yzdGb6jIoR+AH6benhC2s1Bwe6cpDh3hYWfsJdhfzosK6JBkCrGyCM+cMo8bpfL8RgMeh17z7O3Ef8dq0cfUdcK3ElJ69zjAe4eiY177rCNhzd54FeAADDnnAw9cBppLQwOc8US0zIvoIqZffWmGVUufhgxGF9SMOBitYdFgeRrVeoE22eexWogn1fVMNpmTC8CH2DL/6Yhueij5uDkTFMXJwAiwvSG3Zf8F+B2+ICGMz1CK6sKX2r/Bg3GzqFbj1ZltZwIW2X2RrEN6DSVsY2R3RtcaYaXZa3cgZEUJ+iwJnZGQCf/TVPKZr4IDkmD6Bos5EiYG8DSwbXDo+OXxfKyXQUsYwg6spKRWyH2BR0xQr+XyOQqbF2sPMXc/dtHQtW+Q6UV X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(46966006)(36840700001)(54906003)(2616005)(186003)(70206006)(426003)(5660300002)(8676002)(26005)(2906002)(316002)(356005)(336012)(36860700001)(36906005)(7636003)(82310400003)(107886003)(36756003)(9786002)(7696005)(8936002)(44832011)(4326008)(6916009)(508600001)(70586007)(1076003)(47076005)(102446001)(37363002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 10:54:47.3408 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92493000-82b0-4792-7235-08d99aca862e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT005.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8052 Subject: [dpdk-dev] [PATCH] eal: fix device iterator issue to find device for class type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" devarg parser rte_devargs_layers_parse() does not configures devargs->bus_str for class type. rte_dev_iterator_init is not setting devargs->bus_str to NULL before passing it to devarg parser. It results junk value for bus_str and due to this device iterator is unable to find device for class type. Bugzilla ID: 862 Fixes: 9a1a9e4a2ddd (devargs: support path value with global device syntax) Signed-off-by: Vijay Srivastava Signed-off-by: Vijay Srivastava > --- lib/eal/common/eal_common_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c index 148a238..4efdd8e 100644 --- a/lib/eal/common/eal_common_dev.c +++ b/lib/eal/common/eal_common_dev.c @@ -577,6 +577,8 @@ static int cmp_dev_name(const struct rte_device *dev, const void *_name) struct rte_class *cls = NULL; struct rte_bus *bus = NULL; + memset(&devargs, 0, sizeof(devargs)); + /* Having both bus_str and cls_str NULL is illegal, * marking this iterator as invalid unless * everything goes well.