From patchwork Wed Oct 13 15:20:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 101370 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12731A0C55; Wed, 13 Oct 2021 17:20:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E880C411EC; Wed, 13 Oct 2021 17:20:35 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 28ED34115A for ; Wed, 13 Oct 2021 17:20:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="290944707" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="290944707" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 08:20:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="570869188" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.27]) by fmsmga002.fm.intel.com with ESMTP; 13 Oct 2021 08:20:29 -0700 From: Ferruh Yigit To: Andrew Rybchenko , Igor Romanov , Andy Moreton , Ivan Malov Cc: Ferruh Yigit , dev@dpdk.org, Raslan Darawsheh Date: Wed, 13 Oct 2021 16:20:27 +0100 Message-Id: <20211013152027.2480175-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/sfc: fix build when assert enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When 'RTE_ENABLE_ASSERT' is enabled (meson -Dc_args=-DRTE_ENABLE_ASSERT) build fails: ../drivers/net/sfc/sfc_repr.c: In function ‘sfc_repr_start’: ../drivers/net/sfc/sfc_repr.c:251:20: warning: implicit declaration of function ‘sfc_repr_lock_is_locked’; did you mean ‘rte_spinlock_is_locked’? [-Wimplicit-function-declaration] 251 | SFC_ASSERT(sfc_repr_lock_is_locked(sr)); | ^~~~~~~~~~~~~~~~~~~~~~~ Fixes: c85675423f01 ("net/sfc: implement port representor start and stop") Reported-by: Raslan Darawsheh Signed-off-by: Ferruh Yigit --- Cc: igor.romanov@oktetlabs.ru The patch that cause the build error is still in next-net, if the patch is good it can be squashed into the relevant patch in next-net. --- drivers/net/sfc/sfc_repr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c index 6ec83873abd1..02131ce3675d 100644 --- a/drivers/net/sfc/sfc_repr.c +++ b/drivers/net/sfc/sfc_repr.c @@ -248,7 +248,9 @@ sfc_repr_start(struct rte_eth_dev *dev) sfcr_info(sr, "entry"); +#ifdef RTE_LIBRTE_SFC_EFX_DEBUG SFC_ASSERT(sfc_repr_lock_is_locked(sr)); +#endif switch (sr->state) { case SFC_ETHDEV_CONFIGURED: @@ -319,7 +321,9 @@ sfc_repr_stop(struct rte_eth_dev *dev) sfcr_info(sr, "entry"); +#ifdef RTE_LIBRTE_SFC_EFX_DEBUG SFC_ASSERT(sfc_repr_lock_is_locked(sr)); +#endif switch (sr->state) { case SFC_ETHDEV_STARTED: @@ -477,7 +481,9 @@ sfc_repr_configure(struct sfc_repr *sr, uint16_t nb_rx_queues, sfcr_info(sr, "entry"); +#ifdef RTE_LIBRTE_SFC_EFX_DEBUG SFC_ASSERT(sfc_repr_lock_is_locked(sr)); +#endif ret = sfc_repr_check_conf(sr, nb_rx_queues, conf); if (ret != 0) @@ -786,7 +792,9 @@ sfc_repr_tx_queue_release(struct rte_eth_dev *dev, uint16_t tx_queue_id) static void sfc_repr_close(struct sfc_repr *sr) { +#ifdef RTE_LIBRTE_SFC_EFX_DEBUG SFC_ASSERT(sfc_repr_lock_is_locked(sr)); +#endif SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED); sr->state = SFC_ETHDEV_CLOSING;