From patchwork Tue Oct 12 12:45:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101210 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7129DA0C47; Tue, 12 Oct 2021 14:46:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B57941143; Tue, 12 Oct 2021 14:46:38 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2079.outbound.protection.outlook.com [40.107.236.79]) by mails.dpdk.org (Postfix) with ESMTP id 5E0A141135; Tue, 12 Oct 2021 14:46:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lecPTm6CG++nVGVYC5AwtIKkEagjSx3jsQO64Jv/DZWs11JDWW3csvYNcEbb4u8oC1BB6OntsvBMWD4fQay569K4wuchpNefTcTAJojdMhan21XFwwgGHuMp6khIlw+qN279nRrrtkyKBaUnRXcYZwZlfAzbniZAkuz6kOXpu7J5wyQDfXMm0cW2rxXFN+wTMeVFhwSVPE2Q4zISh8MbYTyBLRqBUQVg16IohlBQoKbg875mOATfxMqJsldk2OPsGyrKBz8kSqWD97NmZEGakEaf/kl+TarfLc148a2Eel3uYo7vw0/s8LrJiX8bx2ygeWQR4++gKFfAQ/eF50W3pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lWrxiisqFvxPR/b0roPu7DSLZIYcmW/hK016sX7+y3A=; b=UZCDkt5PE4i03/pjp/+3M0RIh6IOPpZ+W2A89RW5Qa2SG0N23o0P/UKt6JbCQMlhZ+n7xF3Ch/3IM74Cjz7lckGcok4VBETSm5eqncyWGwIPDkH/65u4f4BbDWVVYwy4PWnzH6Rf/1d69qwPii5e4kqJ9UAK9J8u8RV83cEqTN5ntEQahhKZ18LLzTi1Q40G10cCPjI/8ACj3Oy0LInS/YN3X4f3o7Rw23IpBMELhVQqCRWrNVriAysjBb7YvvKOTsLa1xPMp3Khf3125gChiTlkj2WXvVFZV4rAF7WbhUmvRFKoh3323djDwiHIAWulZZ76eP3von3jEo9xJLj6qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lWrxiisqFvxPR/b0roPu7DSLZIYcmW/hK016sX7+y3A=; b=Vifxxnj8XTE88AAWhZXJTBvF60ZKXzHZeErUF0LgzEhVsc7YoxZM+oOqUBqLL5TfPSQeqpPX4JDOvp0IDAW9yNKxyvRAa/okIVPiiBHPJhJrQMvcIEf75yVfqugX/OXzIyZibUYegkcuJdQnqUMm7PIVqN6688lEn7kl0XuI01wKGyhBjXoFBs+Zayiyr/407qkFDi+ZxBDDm2SETnHcDvi4jfwwL0LvlxsPMKNb6ggO/eboum9AvJiTw+SyLxxNFJnmpBpzk97CZcPc9n5uSaDMokOxJoPfyV812oO5hYSwD9KZZ9j4pFZn8r6mqte5DnzZuZ91j2wSWiJ5/SHyEg== Received: from DM6PR02CA0146.namprd02.prod.outlook.com (2603:10b6:5:332::13) by MWHPR12MB1248.namprd12.prod.outlook.com (2603:10b6:300:12::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct 2021 12:46:34 +0000 Received: from DM6NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332:cafe::9d) by DM6PR02CA0146.outlook.office365.com (2603:10b6:5:332::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 12:46:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT008.mail.protection.outlook.com (10.13.172.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:33 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:22 +0000 From: Tal Shnaiderman To: CC: , , , , , , , , Date: Tue, 12 Oct 2021 15:45:42 +0300 Message-ID: <20211012124554.21296-2-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dd00dba-fb03-4922-520b-08d98d7e5299 X-MS-TrafficTypeDiagnostic: MWHPR12MB1248: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1824; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hkno35KMk8gMTqsXN8k2mdkwt61dehUyMy06/wz1LOCBBoyGho4LKDDnhF51OkuM74XMYVuj4jN3o9c7135GqT+jm7gmIhFRq16tWRMCOAynggi00O2hbqTzpMFCBRTzp5xIdnVc6mAUWsjnOyCYpuBI8qAACEh+ux2lc9ddS1VOEjm+hnaP/wYKc/kAHwyo6tXCfj6IpMLw68ybBWeTAcwkOQ8Y5+GWfDG48wgzwytVJAXph4N6Fh1e9/L0uYqVx12qYSUSnsd2xYpemLYqFqczXky3tx1I74hT1Pv6+BW/bdUX7apUi93mVSBnf0Cf3GQg/vCyQop7fH3/R4ba1E90ENnyDnVA5S0rBG1iHnFc/93D+rE6c48cBHbDzednwA1FeBZKeWhASpoQ+qtqJH8XzHD02PWQdx9ulYL/eQDhCz6VDncGGIZaw4/CMeEkx5WolCVjrcK+t8IhYyDzgxodQ9T2NQPz8ynaVXR5/bF08rY89YykFOtxt1lad4DEx9tTzeqFaJDoEP0YsWq4GiNRrOXMUtkf24jvW8XMSOTUVY9keKdiTcgUFXBoJMNuvI+3ywTZEy99D6r50qyOJJlgz4dOKUleyWfUDVadbn2l5syhocLs6O+C/a5WMVA9PXHHDY5gsaBfKwpIA/TpvtQhVVMfDYs00Yw+OUF4nC20UZCP6xbaabn5ztiKcVwKuhIFSVb6D6BdJcdqaB7Xm39PZn4WNYB+iF/PVqGAr7Q= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(36860700001)(83380400001)(54906003)(36756003)(186003)(7636003)(4326008)(316002)(1076003)(26005)(508600001)(16526019)(2616005)(8936002)(8676002)(356005)(70586007)(336012)(6916009)(2906002)(426003)(5660300002)(86362001)(6286002)(6666004)(82310400003)(70206006)(7696005)(47076005)(55016002)(309714004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:33.9513 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dd00dba-fb03-4922-520b-08d98d7e5299 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1248 Subject: [dpdk-dev] [PATCH v2 01/13] net/mlx5: fix software parsing support query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, the PMD decides if the software parsing offload can enable outer IPv4 checksum and tunneled TSO support by checking config->hw_csum and config->tso respectively. This is incorrect, the right way is to check the following flags returned by the mlx5dv_query_device function: MLX5DV_SW_PARSING - check general swp support. MLX5DV_SW_PARSING_CSUM - check swp checksum support. MLX5DV_SW_PARSING_LSO - check swp LSO/TSO support. The fix enables the offloads according to the correct flags returned by the kernel. Fixes: e46821e9fcdc60 ("net/mlx5: separate generic tunnel TSO from the standard one") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/linux/mlx5_os.c | 3 ++- drivers/net/mlx5/linux/mlx5_os.h | 12 ++++++++++++ drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_txq.c | 15 +++++++++------ 4 files changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 3746057673..a6542629c7 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1112,7 +1112,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, swp = dv_attr.sw_parsing_caps.sw_parsing_offloads; DRV_LOG(DEBUG, "SWP support: %u", swp); #endif - config->swp = !!swp; + config->swp = swp & (MLX5_SW_PARSING_CAP | MLX5_SW_PARSING_CSUM_CAP | + MLX5_SW_PARSING_TSO_CAP); #ifdef HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT if (dv_attr.comp_mask & MLX5DV_CONTEXT_MASK_STRIDING_RQ) { struct mlx5dv_striding_rq_caps mprq_caps = diff --git a/drivers/net/mlx5/linux/mlx5_os.h b/drivers/net/mlx5/linux/mlx5_os.h index 2991d37df2..da036edb72 100644 --- a/drivers/net/mlx5/linux/mlx5_os.h +++ b/drivers/net/mlx5/linux/mlx5_os.h @@ -21,4 +21,16 @@ enum { int mlx5_auxiliary_get_ifindex(const char *sf_name); + +enum mlx5_sw_parsing_offloads { +#ifdef HAVE_IBV_MLX5_MOD_SWP + MLX5_SW_PARSING_CAP = MLX5DV_SW_PARSING, + MLX5_SW_PARSING_CSUM_CAP = MLX5DV_SW_PARSING_CSUM, + MLX5_SW_PARSING_TSO_CAP = MLX5DV_SW_PARSING_LSO, +#else + MLX5_SW_PARSING_CAP = 0, + MLX5_SW_PARSING_CSUM_CAP = 0, + MLX5_SW_PARSING_TSO_CAP = 0, +#endif +}; #endif /* RTE_PMD_MLX5_OS_H_ */ diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 3581414b78..edb4f26d42 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -260,7 +260,7 @@ struct mlx5_dev_config { unsigned int dv_xmeta_en:2; /* Enable extensive flow metadata. */ unsigned int lacp_by_user:1; /* Enable user to manage LACP traffic. */ - unsigned int swp:1; /* Tx generic tunnel checksum and TSO offload. */ + unsigned int swp:3; /* Tx generic tunnel checksum and TSO offload. */ unsigned int devx:1; /* Whether devx interface is available or not. */ unsigned int dest_tir:1; /* Whether advanced DR API is available. */ unsigned int reclaim_mode:2; /* Memory reclaim mode. */ diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index eb4d34ca55..8dca2b7f79 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -111,9 +111,9 @@ mlx5_get_tx_port_offloads(struct rte_eth_dev *dev) if (config->tx_pp) offloads |= DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP; if (config->swp) { - if (config->hw_csum) + if (config->swp & MLX5_SW_PARSING_CSUM_CAP) offloads |= DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM; - if (config->tso) + if (config->swp & MLX5_SW_PARSING_TSO_CAP) offloads |= (DEV_TX_OFFLOAD_IP_TNL_TSO | DEV_TX_OFFLOAD_UDP_TNL_TSO); } @@ -979,10 +979,13 @@ txq_set_params(struct mlx5_txq_ctrl *txq_ctrl) txq_ctrl->txq.tso_en = 1; } txq_ctrl->txq.tunnel_en = config->tunnel_en | config->swp; - txq_ctrl->txq.swp_en = ((DEV_TX_OFFLOAD_IP_TNL_TSO | - DEV_TX_OFFLOAD_UDP_TNL_TSO | - DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) & - txq_ctrl->txq.offloads) && config->swp; + txq_ctrl->txq.swp_en = (((DEV_TX_OFFLOAD_IP_TNL_TSO | + DEV_TX_OFFLOAD_UDP_TNL_TSO) & + txq_ctrl->txq.offloads) && (config->swp & + MLX5_SW_PARSING_TSO_CAP)) | + ((DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM & + txq_ctrl->txq.offloads) && (config->swp & + MLX5_SW_PARSING_CSUM_CAP)); } /** From patchwork Tue Oct 12 12:45:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101212 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 845F2A0C47; Tue, 12 Oct 2021 14:46:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 098E441198; Tue, 12 Oct 2021 14:46:44 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) by mails.dpdk.org (Postfix) with ESMTP id C02524111E for ; Tue, 12 Oct 2021 14:46:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vm+RuZ+HzwqAiJcNtg0hrgWJo2kybt4pCS45+fcww1ZVBK0IDsKN6eAd/2q/Ve3l+sMAcNIHMUGc8jL5soyQmmIyNx7psHRQ8KgCe0QQfodWBYGBvnBcp9k8ecKzRtpHGPVQazjOfb2SnhFe3B84UWbRTPNfBSkXMA+GxMCsPFsYMjY3VTtCRDfmkClsJ9wCr7hvjHA8jpjEIM/d43RaKtUPg22oN/N8IgfSyV6MzF1WiDKdCVOebipFTSZPrOEKwGJ9RsiR0er/tS94zg/S0A6JNEIh6XjfgguKcod5fUU4uwFRzSORwolRS+GnhmFSUPdvQeuywmNEMEIh1Ug3+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83jiY+mtztfeB8Ipnlp+jYjYA2ehI8UAdCT+lpYmVcY=; b=Eug9bp3UjYEH48xt59PgYI++KS/uIqsw2iOrN7bT+v0ag/47/ifxWy6DuX7Nk9bWnRRtlzBRsOQCf55KYjZ92I/w1lgaKV7TDCdPJQijAvO2WcdYCF2mUb4z/dHxkOk2J9Tuqo74tctNRoU0F1PZuIokimYZpSOPk+6QDVKsoDH0vKqTCjRLsVYEMjt2vS0fOFYazKBOTGiMXAo4qpCk7P9iQSr0cW5DVkK1lr2zu6gR2/a+v/xE+IndvePUeCzXafSPGYmVmnqNNl5fqWopb2fo5L2YVemfyo8/SBEf49U2mQ9DJqog6jGGG/wz9U5BiRO4VF62wNLfIIUGLwnQJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=83jiY+mtztfeB8Ipnlp+jYjYA2ehI8UAdCT+lpYmVcY=; b=MRFGOFUcQzl9l73+4kHt6iqzwtB1wuZjA6Tl63RMxSmmWcvsFrhtWuvDv9Md8rjUKYBDGlFsTT9X/UX4nETkW4gSUSgkKs6zBcKWyl4m7nG3iZRIBXGC6DosPjDDcKb8oumwwmaRiebsxcgvXR3lfAOWh2tNpcq+Evb6fhFpPVRh15JtMJwmLjOUgXXPYkEZYNOe1eFgUQ6DimtC6vLf6zUz7m84UgAcxeVWsnqJs+cdenlHIyy7J2vZnaLY/McBDqLW/fKlAGPntkN/yKARLz6+9irytsD+WEo2xKuOcw71jUDNO8fTbAlJ+p1TLCird/R2KscFux3pSe7jBq2ZBg== Received: from DM6PR02CA0142.namprd02.prod.outlook.com (2603:10b6:5:332::9) by SN6PR12MB4669.namprd12.prod.outlook.com (2603:10b6:805:7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Tue, 12 Oct 2021 12:46:37 +0000 Received: from DM6NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332:cafe::ff) by DM6PR02CA0142.outlook.office365.com (2603:10b6:5:332::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24 via Frontend Transport; Tue, 12 Oct 2021 12:46:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT008.mail.protection.outlook.com (10.13.172.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:36 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:24 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:43 +0300 Message-ID: <20211012124554.21296-3-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94bf4652-4a47-4205-f5c7-08d98d7e544f X-MS-TrafficTypeDiagnostic: SN6PR12MB4669: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CcDXxZ8dEeIqpGOD/6hs0MtT3wqCx8AlGSoilRNJ++r+M/jIY9GJiyCC/F2mg5UShJaceIelaYqvFldrin4b1MUDDXFx8n3VUgv66rDaZKjX1h0ZBSXlF5c0jt3Hm+dfCz5gAnlrXLjDT555AbgaOBl0X78j9wTDT96KIWieyGf09/vo78iaXulvN5xNqgOn1SnvKq5vNFSCQ0yhyWTGpxiX5y7/6O5BmTzwZFGxVrhyTVzDcTpqtHYtJKkfnwJKoF/AVqkLvRWpPeJI7xj3s+D4DBtEOPH/o2jK17SAFCD2d4VFeS3JAm5DNx5+aIWPX7RyeBNAnD4i9zlLkdOo0Ztsphm/HjBqoxanxfefrBwLyyqoNEsu714+bdwQxNDQfiUGjaTalW3OKIp1c5UCPYNtM+QD9uQjrY+r+5uvGQ2pO3BZJgzkHSOoSCgbOMxiN4kyv73IGQ0tDzOK3dP8iJupyLjasF+EIcCtML/0VbUlruaTTFUdwNo0sPg2em+FYDfn3NAdsmH1DrfBW+RvzufuLv+wsnwvmlAhbPZg3rEgRvOkLTz9RnkyiturLqmfHcDTXXP485GiBa/0RrgXW+rKh24AtgNOQXz4FHiiuhqX4LAF5YYkVFTCjZR+asMx7SY8yd0EBys4vIzfbE0DDaN6LbqeYvgEO9p9HlYlGf4XjB+KHL6FQSsXy1pI/vOahXesf0Y++MRKx5ZrZ4URnA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(186003)(26005)(7696005)(36756003)(107886003)(6286002)(16526019)(54906003)(1076003)(5660300002)(316002)(8936002)(8676002)(47076005)(55016002)(6916009)(508600001)(70586007)(4326008)(86362001)(426003)(2616005)(356005)(6666004)(70206006)(336012)(2906002)(82310400003)(7636003)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:36.8440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94bf4652-4a47-4205-f5c7-08d98d7e544f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4669 Subject: [dpdk-dev] [PATCH v2 02/13] common/mlx5: read software parsing capabilities from DevX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5 in Windows needs the software parsing hca capabilities to query the NIC for TSO and Checksum offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++++++ drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 56407cc332..70ba74e112 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -991,6 +991,12 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, hcattr, tunnel_lro_gre); attr->tunnel_lro_vxlan = MLX5_GET(per_protocol_networking_offload_caps, hcattr, tunnel_lro_vxlan); + attr->swp = MLX5_GET(per_protocol_networking_offload_caps, + hcattr, swp); + attr->swp_csum = MLX5_GET(per_protocol_networking_offload_caps, + hcattr, swp_csum); + attr->swp_lso = MLX5_GET(per_protocol_networking_offload_caps, + hcattr, swp_lso); attr->lro_max_msg_sz_mode = MLX5_GET (per_protocol_networking_offload_caps, hcattr, lro_max_msg_sz_mode); diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index e576e30f24..caa444bc15 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -116,6 +116,9 @@ struct mlx5_hca_attr { uint32_t lro_cap:1; uint32_t tunnel_lro_gre:1; uint32_t tunnel_lro_vxlan:1; + uint32_t swp:1; + uint32_t swp_csum:1; + uint32_t swp_lso:1; uint32_t lro_max_msg_sz_mode:2; uint32_t lro_timer_supported_periods[MLX5_LRO_NUM_SUPP_PERIODS]; uint16_t lro_min_mss_size; From patchwork Tue Oct 12 12:45:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101211 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A497A0C47; Tue, 12 Oct 2021 14:46:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83D4341181; Tue, 12 Oct 2021 14:46:40 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by mails.dpdk.org (Postfix) with ESMTP id 854454118C for ; Tue, 12 Oct 2021 14:46:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQlLpSXOwWPSyyJgCBT5J+pRWVoYp+zzBlF/ZzGLYL6RWcb8GxUYcwSv7cAfdzh2+cVXsbPcXCkhyisoTYSkp++EaBBC7hvCWFN72Nqdo5yGsS/Xmju909+k2ctLGlD89bG6EvyX5OhpurepYoliVPhWb9adzBsMPWTlCVyejtxZaQO3dfPI3GnQnihUOnbH/HPJ/bsq7QrjWqhJ8CNUZoB2xioDqNTpuVOJ1rD0vpAky1vDfWa3evOxV7kWyx/6BP2iiFCsb3pbvunx0yOUEXUoF4kTBIjoauob7e1XDuLKfiKU2+MXRn4gHTD9o029ysoXVAJaLR08npCbuOtfew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDXNZcE39QsUgg0k7AEMwCiNwIWDYsWeCe7+4NTAj4s=; b=aQc57Xf0oZAgLKG5Qzk+sf9gKwSQUrW2rnaMK/QZqCDVYyt701JE317SDaGcTrg0jUNBOtZ5eUIVWH5GCN1cogw0zwdflhYlgAfOQII9LTstVhCmLEHgzbbflZuSDXXPjrSbxl6/du80zd9o+V98QgbtHRjxQmJUfpX0CSbFS5Ay+IwmBg1eSQLrwTltvPWPB95nbDpzAmtbjVPnmg+Bq/3bE+P1IFbb6ufmOh5bsoE5kypXv2G0JpkJA1THenPJfVys+bvzyhW/7JkEe0g7+JjqxpRIFu/XI7BTHESLZIVg+f3vY6yaZT47DKALccNDduLPF1tw0sFJsp0g2k1S9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDXNZcE39QsUgg0k7AEMwCiNwIWDYsWeCe7+4NTAj4s=; b=uDXfkNDgXh/CH2QlOyk725qs/2XtzpVzJTZVGwArjmq4NQZRtbyMMLBBt3yG9Yww+6KBUUt7QR0kqmIDzm2TjDkcw2Tatl6r/AT+yrDKV/ldtdJRLiKwgJt3mjXo2vfkaxZ/ZRncIdfao658gMHhsOYWXvBrFwgOXKwXrRMjhRrGobGs7//1UVxpW8enuiH9gxd0zkzmx27hqvpC8wMHhmQCjaOldK4N3DQ8mcIql8iDvkwp0yasTBMC0sPIkkJq43XeOLc6NzDTDG3vX7zvD1npkP6YDEoJl9QEjlU/9w9RhCJkO4HW6NOazJgIkGpdt+NNWwZEJzF9DfbNnv/JzQ== Received: from DM6PR02CA0154.namprd02.prod.outlook.com (2603:10b6:5:332::21) by BN9PR12MB5337.namprd12.prod.outlook.com (2603:10b6:408:102::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct 2021 12:46:38 +0000 Received: from DM6NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332::4) by DM6PR02CA0154.outlook.office365.com (2603:10b6:5:332::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 12:46:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT008.mail.protection.outlook.com (10.13.172.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:38 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:27 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:44 +0300 Message-ID: <20211012124554.21296-4-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb129c9d-8fb2-4bff-79e6-08d98d7e551f X-MS-TrafficTypeDiagnostic: BN9PR12MB5337: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gHLPkDph71D0p+YHixxGSkuvgj3HNsjG0+SfaWMERwdB7BEvTLKjiyByqWCJTqBrUXWwxY37WbZbwOD22jMOHh72dLQqzVVUSqbcfXRDeqds93tvT9NdAmZSh8PszF084yw00xk6E0dhFbMYbYnP+HYyzbyDqIGWZXB9QO7YCYKZi3QjZS+7U20/bHPd/OV1OOeouHlrDh3xSUXQTozQLei9auTcfzGPsiN6Xuac8Bb3DnoGalq1HMxnVkgOV+0thyPOglOHbkeANN61T+c1yXZJENGieIh9BhdOmYV0Y/bhbp4Hg1BXX7j2Q0TUiG95xSYnS9laj9I/2oUzeUrMQvSC/zOSgRMFp8KwCIN3xUN0NfmtR+DucjrTUeMX+JbVVD8J+hcpNFy6rDkk7MIQvOkdqvi4cQYbEHAqKCFc4ebwN+VoUIrbfJJ+tsaASx6jQjU+YD+QosGrgdrYMe6HEIPb2mVuL1rv0y3Ocg9kpyu52k37ZejZNPbY4myb0uwEd6DAOw/9eANlpcPJf68kybuOK7IhzXw4ZwWrdS1BEwK3B6O9yVAAwT7NEHVXN2Z1W4wfNZ8jDFO1GEGvrKhh44EWNh4X2bBTbs71WFj12jGEuCmZcs8dBSNh4zHvYTzo+5xJqg3qWH7IWGT/3CGhtbbKjxXAktFj0F023ZMHg+kMtr+phidcqbtrKqxTw2+fO3DfeuPmyH0PLL0e9Zj0ng== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(336012)(16526019)(7636003)(316002)(8936002)(83380400001)(426003)(26005)(6666004)(107886003)(36906005)(186003)(86362001)(54906003)(47076005)(55016002)(356005)(36860700001)(7696005)(4326008)(508600001)(2906002)(70206006)(70586007)(8676002)(2616005)(1076003)(6916009)(36756003)(6286002)(82310400003)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:38.1910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb129c9d-8fb2-4bff-79e6-08d98d7e551f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5337 Subject: [dpdk-dev] [PATCH v2 03/13] net/mlx5: query software parsing support on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Query software parsing supported on the NIC. Save the offloads values in a config parameter. This is needed for the outer IPv4 checksum and IP and UPD tunneled packet TSO support. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/mlx5.c | 16 ++++++++++++++++ drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/windows/mlx5_os.c | 6 +++++- drivers/net/mlx5/windows/mlx5_os.h | 6 ++++++ 4 files changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 45ccfe2784..add07db755 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -950,6 +950,22 @@ mlx5_flex_parser_ecpri_release(struct rte_eth_dev *dev) prf->obj = NULL; } +uint32_t +mlx5_get_supported_sw_parsing_offloads(const struct mlx5_hca_attr *attr) +{ + uint32_t sw_parsing_offloads = 0; + + if (attr->swp) { + sw_parsing_offloads |= MLX5_SW_PARSING_CAP; + if (attr->swp_csum) + sw_parsing_offloads |= MLX5_SW_PARSING_CSUM_CAP; + + if (attr->swp_lso) + sw_parsing_offloads |= MLX5_SW_PARSING_TSO_CAP; + } + return sw_parsing_offloads; +} + /* * Allocate Rx and Tx UARs in robust fashion. * This routine handles the following UAR allocation issues: diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index edb4f26d42..0694927457 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1828,5 +1828,7 @@ int mlx5_aso_ct_query_by_wqe(struct mlx5_dev_ctx_shared *sh, struct rte_flow_action_conntrack *profile); int mlx5_aso_ct_available(struct mlx5_dev_ctx_shared *sh, struct mlx5_aso_ct_action *ct); +uint32_t +mlx5_get_supported_sw_parsing_offloads(const struct mlx5_hca_attr *attr); #endif /* RTE_PMD_MLX5_H_ */ diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index 26fa927039..1e258e044e 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -169,6 +169,8 @@ mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr) device_attr->max_rwq_indirection_table_size = 1 << hca_attr.rss_ind_tbl_cap; } + device_attr->sw_parsing_offloads = + mlx5_get_supported_sw_parsing_offloads(&hca_attr); pv_iseg = mlx5_glue->query_hca_iseg(mlx5_ctx, &cb_iseg); if (pv_iseg == NULL) { DRV_LOG(ERR, "Failed to get device hca_iseg"); @@ -393,7 +395,9 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, } DRV_LOG(DEBUG, "MPW isn't supported"); mlx5_os_get_dev_attr(sh->ctx, &device_attr); - config->swp = 0; + config->swp = device_attr.sw_parsing_offloads & + (MLX5_SW_PARSING_CAP | MLX5_SW_PARSING_CSUM_CAP | + MLX5_SW_PARSING_TSO_CAP); config->ind_table_max_size = sh->device_attr.max_rwq_indirection_table_size; cqe_comp = 0; diff --git a/drivers/net/mlx5/windows/mlx5_os.h b/drivers/net/mlx5/windows/mlx5_os.h index 7fe41d4e90..6de683357c 100644 --- a/drivers/net/mlx5/windows/mlx5_os.h +++ b/drivers/net/mlx5/windows/mlx5_os.h @@ -16,4 +16,10 @@ enum { #define MLX5_NAMESIZE MLX5_FS_NAME_MAX +enum mlx5_sw_parsing_offloads { + MLX5_SW_PARSING_CAP = 1 << 0, + MLX5_SW_PARSING_CSUM_CAP = 1 << 1, + MLX5_SW_PARSING_TSO_CAP = 1 << 2, +}; + #endif /* RTE_PMD_MLX5_OS_H_ */ From patchwork Tue Oct 12 12:45:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101213 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80365A0C47; Tue, 12 Oct 2021 14:46:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E3C34119D; Tue, 12 Oct 2021 14:46:45 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2083.outbound.protection.outlook.com [40.107.93.83]) by mails.dpdk.org (Postfix) with ESMTP id 6B4624117E; Tue, 12 Oct 2021 14:46:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJuDcb2GEk7ik/bwzJ54ULfa4x0ZuEw68aRHWit0ntJLsp+YHs+J8G6ZCcZfYWwekq5XosGkzgwW/mFxwcMZgXFFRuJaHwzsplebGFXPFWBSI+BqsRGx+tBpF1+ZwTMa7Ej2wIggq7O3mGDjZirvALZ1us9dc5arW3l0ExEqNSU6QMWaG0dRr9VyHPrPhFApFvFcsY0RcxZJNDdhLsJj4icsL4p1K7d7x28MdiTzvpPTjqEtuW5zQkK867usIFInc8F4UhaGdoXPObI3NiS76TEoxGJmR2IzJKYolskHB7C0T9htbZMG5M285qWa3V/HKGpPniVws2zmbsmgbPH22g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X6oaoVCzK5ccNEcAlXQCWTj168vlbTXsRoDbeG+vzHg=; b=cjfHXGjTmOaTPsGVu4GggL88d2DO8+qmHfcwJUGI7UG7LbIAwhzwGeVwgPFNoeTmNkbo5SU9DEDiGy6Ej0IW9DCrIwnUUk06NiT7qNoi7xHL733roxjNN1gpOkagBYv/awNhzaL+c7omjjzSlHvQTM0+t8ysIjj0QnaNEi06sXmzdVTXsHTjLu7yvYXks/DniUx0hRRl9SopLbu+uLOyndzLZRf3VIWLQZDy0LsTDy85vCSo+02YC/48wo+AVGmVf+40geKYtB0NxVlOAOn1320+wZFyeSjS+j4mAReyc7PlRowk6l34WdTzOEgul3UyP3dlcHnI9GoBEa5fkclfSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6oaoVCzK5ccNEcAlXQCWTj168vlbTXsRoDbeG+vzHg=; b=GYfrDngJkj3VpDJfmRh1ysbaiFl69TV7IU81dU789GfU9QLuMxZaaRw+KI1BFpwOEtGUAZPPmYtl2TVtN3dD7K4+R/9p4cRiS6sKcAOfWIsD1lb1QsnLGeHvt1uIcglLpyu4nn6/X8/Hu8d+lWTfXKhr0f9BEgqFk5D2F1kAWTDpsqBhrNx+mO+RZyCMOn5M33PebFc12504tYR6yqGCe00NEXtTtkt87K45d/kKK+nluagF7HaA+WWTuEdt28D30BSk1/wNYncTE2eb8uNuv5wNq6/ZUp0hudcOOA/cpMN2X8/UIMKxFsiyrnDPrcoV2n+FjA4dXQM05xeKrn8HvQ== Received: from DM6PR02CA0139.namprd02.prod.outlook.com (2603:10b6:5:332::6) by DM6PR12MB2891.namprd12.prod.outlook.com (2603:10b6:5:188::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct 2021 12:46:39 +0000 Received: from DM6NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332:cafe::cb) by DM6PR02CA0139.outlook.office365.com (2603:10b6:5:332::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 12:46:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT008.mail.protection.outlook.com (10.13.172.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:39 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:30 +0000 From: Tal Shnaiderman To: CC: , , , , , , , , Date: Tue, 12 Oct 2021 15:45:45 +0300 Message-ID: <20211012124554.21296-5-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff341efe-7ba7-40e3-e90b-08d98d7e560d X-MS-TrafficTypeDiagnostic: DM6PR12MB2891: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6J5gGu6AonECBaQ5v7LqPk7JWsFeWCXI3U01fIV1gAFHrjoFGIlDtkNtBpbEHMz0cHRJfeTg9wFZQsfPcoC/LeFVzLryAP21aLcoz7vvImb3arT7VxYT0gPsoMjOOK9REkxMSV30Yw3FysogXgSBSNWSk1gz7g/4BcT15z7gzuIsECUMKPilnc2iuetSqFGyXxVF21yMOtNSJ3jHCK4j4ibFILgiRRmE9B2xv9NANGMeavK81fgwlkM46j4bDX4GTERTZF0P7SoKYhwErDcdXQSBuc0wgL9rxufM23laWxeuTYf07We++wBWl5D9bqb/LD1LNmgpS640rhLPqrRTebJDf2UHMZPQqhvhcoOacbBL3FbgvaaBtK+4IMFNcMSjcv42Cs8bt2ABEj8rvw3/Q3j6MEBxabe8gVtaHdOX6IQOL+4XYBroYdKvZ/bcupqFJJRivp8jC/gHI7Ef+W6riOybBzjR8YhzM7ZJjfLyomHF2D9F7dxY2Z+p6bsveC/aqb57BpK44Va7xq0NTFugqU361JvXWlyPMPUxN1Whyh0GgvBoEUM7g7lfJcTPazxA7YnC1CYuGMPZAAyeHWWQ+QaRvJAQ0JRA8nVR5KOcegaSX2k/H6EYo7wiWZP3JPad/dDebeF2RNHgSXb0MOCwkniqZjb3bFASrgDw5WdiHpzYOjwqMynX44mAGK0fRWfYYps2wBPVwCls6WH/vUBqw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(6916009)(70586007)(70206006)(356005)(6286002)(47076005)(36906005)(6666004)(2906002)(508600001)(2616005)(86362001)(7696005)(8676002)(1076003)(316002)(5660300002)(36756003)(8936002)(426003)(336012)(4326008)(82310400003)(16526019)(186003)(54906003)(36860700001)(83380400001)(7636003)(55016002)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:39.7585 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff341efe-7ba7-40e3-e90b-08d98d7e560d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2891 Subject: [dpdk-dev] [PATCH v2 04/13] net/mlx5: fix tunneling support query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, the PMD decides if the tunneling offload can enable VXLAN/GRE/GENEVE tunneled TSO support by checking config->tunnel_en (single bit) and config->tso. This is incorrect, the right way is to check the following flags returned by the mlx5dv_query_device function: MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN - if supported the offload DEV_TX_OFFLOAD_VXLAN_TNL_TSO can be enabled. MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE - if supported the offload DEV_TX_OFFLOAD_GRE_TNL_TSO can be enabled. MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE - if supported the offload DEV_TX_OFFLOAD_GENEVE_TNL_TSO can be enabled. The fix enables the offloads according to the correct flags returned by the kernel. Fixes: dbccb4cddcd2f7c ("net/mlx5: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/linux/mlx5_os.c | 28 +++++++++++++++++----------- drivers/net/mlx5/linux/mlx5_os.h | 15 +++++++++++++++ drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_txq.c | 24 +++++++++++++++++++----- drivers/net/mlx5/windows/mlx5_os.h | 6 ++++++ 5 files changed, 58 insertions(+), 17 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index a6542629c7..9ac354fabe 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -963,7 +963,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, int err = 0; unsigned int hw_padding = 0; unsigned int mps; - unsigned int tunnel_en = 0; unsigned int mpls_en = 0; unsigned int swp = 0; unsigned int mprq = 0; @@ -1145,20 +1144,27 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, config->cqe_comp = 1; #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT if (dv_attr.comp_mask & MLX5DV_CONTEXT_MASK_TUNNEL_OFFLOADS) { - tunnel_en = ((dv_attr.tunnel_offloads_caps & - MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN) && - (dv_attr.tunnel_offloads_caps & - MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE) && - (dv_attr.tunnel_offloads_caps & - MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE)); - } - DRV_LOG(DEBUG, "tunnel offloading is %ssupported", - tunnel_en ? "" : "not "); + config->tunnel_en = dv_attr.tunnel_offloads_caps & + (MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN | + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE | + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE); + } + if (config->tunnel_en) { + DRV_LOG(DEBUG, "tunnel offloading is supported for %s%s%s", + config->tunnel_en & + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN ? "[VXLAN]" : "", + config->tunnel_en & + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE ? "[GRE]" : "", + config->tunnel_en & + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE ? "[GENEVE]" : "" + ); + } else { + DRV_LOG(DEBUG, "tunnel offloading is not supported"); + } #else DRV_LOG(WARNING, "tunnel offloading disabled due to old OFED/rdma-core version"); #endif - config->tunnel_en = tunnel_en; #ifdef HAVE_IBV_DEVICE_MPLS_SUPPORT mpls_en = ((dv_attr.tunnel_offloads_caps & MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_CW_MPLS_OVER_GRE) && diff --git a/drivers/net/mlx5/linux/mlx5_os.h b/drivers/net/mlx5/linux/mlx5_os.h index da036edb72..80c70d713a 100644 --- a/drivers/net/mlx5/linux/mlx5_os.h +++ b/drivers/net/mlx5/linux/mlx5_os.h @@ -33,4 +33,19 @@ enum mlx5_sw_parsing_offloads { MLX5_SW_PARSING_TSO_CAP = 0, #endif }; + +enum mlx5_tunnel_offloads { +#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT + MLX5_TUNNELED_OFFLOADS_VXLAN_CAP = + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN, + MLX5_TUNNELED_OFFLOADS_GRE_CAP = + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE, + MLX5_TUNNELED_OFFLOADS_GENEVE_CAP = + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE, +#else + MLX5_TUNNELED_OFFLOADS_VXLAN_CAP = 0, + MLX5_TUNNELED_OFFLOADS_GRE_CAP = 0, + MLX5_TUNNELED_OFFLOADS_GENEVE_CAP = 0, +#endif +}; #endif /* RTE_PMD_MLX5_OS_H_ */ diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 0694927457..58f12cd75c 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -244,7 +244,7 @@ struct mlx5_dev_config { unsigned int hw_padding:1; /* End alignment padding is supported. */ unsigned int vf:1; /* This is a VF. */ unsigned int sf:1; /* This is a SF. */ - unsigned int tunnel_en:1; + unsigned int tunnel_en:3; /* Whether tunnel stateless offloads are supported. */ unsigned int mpls_en:1; /* MPLS over GRE/UDP is enabled. */ unsigned int cqe_comp:1; /* CQE compression is enabled. */ diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 8dca2b7f79..54f42292ac 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -120,10 +120,17 @@ mlx5_get_tx_port_offloads(struct rte_eth_dev *dev) if (config->tunnel_en) { if (config->hw_csum) offloads |= DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM; - if (config->tso) - offloads |= (DEV_TX_OFFLOAD_VXLAN_TNL_TSO | - DEV_TX_OFFLOAD_GRE_TNL_TSO | - DEV_TX_OFFLOAD_GENEVE_TNL_TSO); + if (config->tso) { + if (config->tunnel_en & + MLX5_TUNNELED_OFFLOADS_VXLAN_CAP) + offloads |= DEV_TX_OFFLOAD_VXLAN_TNL_TSO; + if (config->tunnel_en & + MLX5_TUNNELED_OFFLOADS_GRE_CAP) + offloads |= DEV_TX_OFFLOAD_GRE_TNL_TSO; + if (config->tunnel_en & + MLX5_TUNNELED_OFFLOADS_GENEVE_CAP) + offloads |= DEV_TX_OFFLOAD_GENEVE_TNL_TSO; + } } if (!config->mprq.enabled) offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE; @@ -978,7 +985,14 @@ txq_set_params(struct mlx5_txq_ctrl *txq_ctrl) MLX5_MAX_TSO_HEADER); txq_ctrl->txq.tso_en = 1; } - txq_ctrl->txq.tunnel_en = config->tunnel_en | config->swp; + if (((DEV_TX_OFFLOAD_VXLAN_TNL_TSO & txq_ctrl->txq.offloads) && + (config->tunnel_en & MLX5_TUNNELED_OFFLOADS_VXLAN_CAP)) | + ((DEV_TX_OFFLOAD_GRE_TNL_TSO & txq_ctrl->txq.offloads) && + (config->tunnel_en & MLX5_TUNNELED_OFFLOADS_GRE_CAP)) | + ((DEV_TX_OFFLOAD_GENEVE_TNL_TSO & txq_ctrl->txq.offloads) && + (config->tunnel_en & MLX5_TUNNELED_OFFLOADS_GENEVE_CAP)) | + (config->swp & MLX5_SW_PARSING_TSO_CAP)) + txq_ctrl->txq.tunnel_en = 1; txq_ctrl->txq.swp_en = (((DEV_TX_OFFLOAD_IP_TNL_TSO | DEV_TX_OFFLOAD_UDP_TNL_TSO) & txq_ctrl->txq.offloads) && (config->swp & diff --git a/drivers/net/mlx5/windows/mlx5_os.h b/drivers/net/mlx5/windows/mlx5_os.h index 6de683357c..8b58265687 100644 --- a/drivers/net/mlx5/windows/mlx5_os.h +++ b/drivers/net/mlx5/windows/mlx5_os.h @@ -22,4 +22,10 @@ enum mlx5_sw_parsing_offloads { MLX5_SW_PARSING_TSO_CAP = 1 << 2, }; +enum mlx5_tunnel_offloads { + MLX5_TUNNELED_OFFLOADS_VXLAN_CAP = 1 << 0, + MLX5_TUNNELED_OFFLOADS_GRE_CAP = 1 << 1, + MLX5_TUNNELED_OFFLOADS_GENEVE_CAP = 1 << 2, +}; + #endif /* RTE_PMD_MLX5_OS_H_ */ From patchwork Tue Oct 12 12:45:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101214 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E01ADA0C47; Tue, 12 Oct 2021 14:47:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D303411A6; Tue, 12 Oct 2021 14:46:46 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2066.outbound.protection.outlook.com [40.107.220.66]) by mails.dpdk.org (Postfix) with ESMTP id AF30B41194 for ; Tue, 12 Oct 2021 14:46:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqJhOZSwvrBWGI4QV9PFLbw71VNzLdd2ufTdk+XCM9UJp7/pO0cL98Zt9+GRW1pjvdlUIr93BIfHHNkQcLVHL1VdCn5PMhbNJsW4dUoDzSW0+GiHsoTC7iSWuaNIqAmTaQmPY1bpFNij+y24uh/wSIrOt5aSlDga79KLmDxp+Q1ARftYw601RZEuz5fWtSczNZPI/qTHaPJn7jSdMqJDdspZ8Vx2E5XeZhXkZKA49b7lVGdNXvfUoNjsC4UJ0iP51SPHrtSu+p0oRxZtWM1fSZvkJFhA+R8My/3julAmZN3NOxG9H8N6BDw5ePcyFml05X0/zxssHBKTwCH/wVBvLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vz25O3GXvCTPFA1kjpFjx7/t7Z5jSzIm08ByGxV3sS0=; b=Y+P1wxjkrWIAbzRd+toGglAA7yosQQtW3gl0CeUZFsIvFqmOm8xK7QXqfx/zj01nfIwhtNrTqcF1G48lIdJeNphCrcTyxsjmyhkC6BTOVNa3JTSRghyE7vOBvokXYoJDE/Kl+/goYty0DEzo+tzWjVLQXVLVyGuxC6q4Ys+uqVndcRftGWgXEzDDfXsqKr0KEEn7anmjmppLygmoPSAJSHEq278VZwwUQ9gV/Rms6VqeyJseyvrBCMVABF47WzL73fB8K/VBiYsbtVu9XSaHCktf6J647BdUeZnOjbRTLF/aozNIBUBa5CNiyko8xpMztAlwkNqR4BA7zc1XAX6mlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vz25O3GXvCTPFA1kjpFjx7/t7Z5jSzIm08ByGxV3sS0=; b=B7VPWdIQIzQijtKu1sSzpIzS2GKn/qXNa5AY12LtzZbRkIOaLOeZfgz2j1oXJbpjnI8gsqLtw0dmBb7xdvelhidhxzzFlDQ3xZWq6VoZ3Px0wzyBzvIJC3ENEtQwlyh4fI+xp7+smnSLq7WCeH0LXIbZKn2n1nBG3MizFJePD/YlW1DdcNAYJn7xSehr1U1lhGDMHcmB3FHUaxxSHcxzAjb4kackfPhsJJf/NUAylLl5SVqn3xZh+rnj+wWe8cBCufwB/JSXLKlKIlNS7QSaTzij1ct/kuFYxlxuN3mEif30+p6HI/qkbezxVzTpLaaOBl60RXi04JQa8Ph19YWAYQ== Received: from DM5PR12CA0018.namprd12.prod.outlook.com (2603:10b6:4:1::28) by CH2PR12MB5018.namprd12.prod.outlook.com (2603:10b6:610:65::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct 2021 12:46:42 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:4:1:cafe::1f) by DM5PR12CA0018.outlook.office365.com (2603:10b6:4:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 12:46:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:42 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:32 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:46 +0300 Message-ID: <20211012124554.21296-6-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62893b58-d055-472d-1cb4-08d98d7e5792 X-MS-TrafficTypeDiagnostic: CH2PR12MB5018: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nLnS19HHMD5xzmIw09bTK504LejOLVULKM+0DiV+XF7UCqq7/aPytSvcNoLiBIjHupRtx5apzNBWI6Hbdyr7WlUklLamnRaRxdIoJL1d7oBAqDlzCVeqmnO+zYOroZ6Z5V5r1WmwbRgBcYw/KNC6tKuOVOEg7R0LzoojXJFby8EYsOG5yCrLqU0ZeBJ5WUB9QsxqzH+ubliws6LEbe54A9ZtlRI+6dMKoEsPjanvYD0dxRIOVH6VgC68kBgv/sOe2Odrlkm2/pn7AWThp8GxDj21j2pvCp35O+6bfE0mg8CzlTpMJYrEXVNfCJsU6CKAT14C4FpwTyuJd0jMOqdXKjp5Fcrzchpd8qcVjQojBO6pX1CHP6kb5J/a1GvThWhCzplcmxoubBH8J9Gws2zMGlB5d46zwxWcYAzj0/ArimFawbYenNmWow1Y1BcxT2eplJ9CnQhSw9dBO9e/cLPdwtKzG4uB0KVRvR4aKMI47sOLxgj+k8iT0wMYytrNewk3ea+J5j/HOTD0nwmebvTv2EcMLVqsx4nHJgln7w7gUYT+k0PaByPw3opRIsOmRLIiDBPxy+DAcBRrajcHPB5ohyYiCDWzGZeMwENJuJXJK6+o7OBw3JjFvQrzjotoL3szFyd8G943ZmfvgaPMUA2jU8cfakOOCFph7OA/zAWk5DsVlIfHeGfaLHnJw6Kf5bFFTZ300MN1Addr3gW2PbfEcQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8936002)(1076003)(6286002)(6666004)(7696005)(2616005)(5660300002)(316002)(426003)(86362001)(36860700001)(70206006)(54906003)(2906002)(55016002)(186003)(70586007)(8676002)(508600001)(356005)(26005)(16526019)(336012)(4326008)(6916009)(7636003)(36756003)(107886003)(82310400003)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:42.3125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62893b58-d055-472d-1cb4-08d98d7e5792 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5018 Subject: [dpdk-dev] [PATCH v2 05/13] common/mlx5: read tunneling capabilities from DevX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5 in Windows needs the tunneling hca capabilities to query the NIC for Inner TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++++++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 70ba74e112..cd18ab584f 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -993,6 +993,12 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, hcattr, tunnel_lro_vxlan); attr->swp = MLX5_GET(per_protocol_networking_offload_caps, hcattr, swp); + attr->tunnel_stateless_gre = + MLX5_GET(per_protocol_networking_offload_caps, + hcattr, tunnel_stateless_gre); + attr->tunnel_stateless_vxlan = + MLX5_GET(per_protocol_networking_offload_caps, + hcattr, tunnel_stateless_vxlan); attr->swp_csum = MLX5_GET(per_protocol_networking_offload_caps, hcattr, swp_csum); attr->swp_lso = MLX5_GET(per_protocol_networking_offload_caps, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index caa444bc15..893a24dd3c 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -116,6 +116,8 @@ struct mlx5_hca_attr { uint32_t lro_cap:1; uint32_t tunnel_lro_gre:1; uint32_t tunnel_lro_vxlan:1; + uint32_t tunnel_stateless_gre:1; + uint32_t tunnel_stateless_vxlan:1; uint32_t swp:1; uint32_t swp_csum:1; uint32_t swp_lso:1; From patchwork Tue Oct 12 12:45:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101215 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65077A0C47; Tue, 12 Oct 2021 14:47:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 490E1411AC; Tue, 12 Oct 2021 14:46:47 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by mails.dpdk.org (Postfix) with ESMTP id EFF0E4119B for ; Tue, 12 Oct 2021 14:46:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZehoXnF/cdxFdIE2zq3IhcCzaTx2lIa7hUbz5lyXkAXBsyuYxsn1ilYYv8qWldM0zHSpa3Wxxke9/jPrnPBD7q827IBGKxZujPKlCl4QtYqe+/0R5fRvGmhqVBKrMbbkUJwdMQh21BpMq/bqkMykuBJnYVp+KdeD4PJ0NXXeWdiurkrZWuVEG3Kvt429KS8z+fTLNKHVawh+Igga5v+fexaPpbmzFJ9rDTvIJlqEA6MypcIfui0y0/yyTtFNhTzDf7tIhacPmBucMtpKyih1R7VSGYE22w+W7ddNOzJk+EhzIxMTcDQIm+WuKiqXiD2mSWJYEv+Oh3dNQmY6vbO2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ZkRzcKah+N7zLiKGErjXbdihw164SgBIwr/GUA+ZqM=; b=hBmQduI4iGipns8PMaKzQvnSwcWQfG50Rp+A9KiQjwNKqerwCXj8MC4sIiSEj8M6was5XtCjKDokVtFPYxPJtUIdBocI3GDQ7DpdPoeKY/DZAJmsi8bRh+Be/48xhmDjg31hSiZfqWhCdd74LZlavYu2CuDWRI9e5EeLN5S2qv0lN4bf5B7KcASme4apDYenNA3GEd2LMD/eaKPs686Pt+fYwv/uypDAequdsob9T8tyJ2zt0wNCdcX1Ii4moUdcCU5wB3H4j0ieUZuiv3USOfqyqs+x4g8XMeRrGDAio/+IYvMka0cXH44KiXatdbGSmWhrwdilgLneRbn/3VgSzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ZkRzcKah+N7zLiKGErjXbdihw164SgBIwr/GUA+ZqM=; b=UoNbXz4YtkKoFZjAEkFQdOpgxekAX99Ra5XHrvUMPJDU6upi+MAYyAGGhAvD6fg+EQcml5gAK+oD5JxJBGX9o7ccgyrKUs8TLpRuBG995MhYU1RxaZB0EUYdCJUfUeOuY4fezRUhJ3kCj+CGqet/uLChe9v+h4HR6svl2OBVlDE0LDt6TZBxr+TB1cc/RGu7fncxJJ408AdWuKqUfqSkHyzBxsKuhrLJSregz0vIEvNiVRN55o29aDjHmpLMyXipfrwXDFRNmRBWAUcU+MGjmeruINhIi1HrHvKZ6AWoTRRNoqE3q8L7eccAYjof5UPE+55UE3ePLZwAm8EF2Ebc9w== Received: from DM5PR12CA0018.namprd12.prod.outlook.com (2603:10b6:4:1::28) by MW3PR12MB4395.namprd12.prod.outlook.com (2603:10b6:303:5c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct 2021 12:46:43 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:4:1:cafe::41) by DM5PR12CA0018.outlook.office365.com (2603:10b6:4:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 12:46:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:43 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:35 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:47 +0300 Message-ID: <20211012124554.21296-7-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b91557d-054f-4eb0-43e7-08d98d7e5815 X-MS-TrafficTypeDiagnostic: MW3PR12MB4395: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:741; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p9YGTwdrO9u1E7RSiHGhQA047vnwiXLHl7B+VUNah1greCgpXAFk7d1wcQS+onU0B0LoY5jybJdT1A0i4zhgyVuxfHdBjSBUN2NrVA+bnKOX2dfzahJ7t/4Uji9IYy2InwCjTkCJMQsXplUqAyCa0JDrzNFwXrmLrRPbf9+AgQdTgjhZCHU56I1OcjoMJ9qLJI2DE3MYsI8jVedtJbTLGcnNIbkUHUvoCUkkfdGkHedP/xT/m9ipzibkT3fl1hGr/yOjErj1b2PQYEXtlYEL0Qy98ZognVIlrd2f+oUHBW9Yogk2Tr6u/oIMt+BcKzb+tYLCrGClBsZuTYjZerK7A7+D1WP3tVv2wD7HuijAmiG+bPixNh4kfHARml7hi3pRqG/uIbLNk8ilX/+I+eTLg6M11AfpCxZJxHtpCU5cHe1nGmqB88rncd6gCzJ+PTry92rWPw1tM1F6Bug3UPvCrxIV6XcTJyjGG7HtDZIGU0nv3xr0dQ/l/eNcgYHL6bJlqNBB1jv7LPyErP7C8IoqgVSRwmCjJTWc2TKhIhYmi5+YrIs5Bo4hSmwDHJa8cEzIttoDUb9Vlh11MTaIW9tXpxXicOzSGbHmbqElvR7LyOUz1byA8P7Fe9MpOKpGLOsf75Nn4ETKQ6zvSQC5O3HWxkqCeYunUsuC/ZbSHZklE/uISiqFt975kzvILjCDq9o0EkNDbzcIOufy9tLbMifQuw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(7696005)(36860700001)(7636003)(316002)(6666004)(186003)(336012)(356005)(70206006)(508600001)(1076003)(2906002)(107886003)(70586007)(4326008)(54906003)(83380400001)(26005)(5660300002)(55016002)(36756003)(6916009)(6286002)(47076005)(8936002)(82310400003)(2616005)(8676002)(426003)(86362001)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:43.1640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b91557d-054f-4eb0-43e7-08d98d7e5815 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4395 Subject: [dpdk-dev] [PATCH v2 06/13] net/mlx5: query tunneling support on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Query tunneling supported on the NIC. Save the offloads values in a config parameter. This is needed for the following TSO support: DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/mlx5.c | 14 ++++++++++++++ drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/windows/mlx5_os.c | 20 ++++++++++++++++++-- 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index add07db755..a957bc9938 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -966,6 +966,20 @@ mlx5_get_supported_sw_parsing_offloads(const struct mlx5_hca_attr *attr) return sw_parsing_offloads; } +uint32_t +mlx5_get_supported_tunneling_offloads(const struct mlx5_hca_attr *attr) +{ + uint32_t tn_offloads = 0; + + if (attr->tunnel_stateless_vxlan) + tn_offloads |= MLX5_TUNNELED_OFFLOADS_VXLAN_CAP; + if (attr->tunnel_stateless_gre) + tn_offloads |= MLX5_TUNNELED_OFFLOADS_GRE_CAP; + if (attr->tunnel_stateless_geneve_rx) + tn_offloads |= MLX5_TUNNELED_OFFLOADS_GENEVE_CAP; + return tn_offloads; +} + /* * Allocate Rx and Tx UARs in robust fashion. * This routine handles the following UAR allocation issues: diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 58f12cd75c..0dbb9aacb8 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1830,5 +1830,7 @@ int mlx5_aso_ct_available(struct mlx5_dev_ctx_shared *sh, struct mlx5_aso_ct_action *ct); uint32_t mlx5_get_supported_sw_parsing_offloads(const struct mlx5_hca_attr *attr); +uint32_t +mlx5_get_supported_tunneling_offloads(const struct mlx5_hca_attr *attr); #endif /* RTE_PMD_MLX5_H_ */ diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index 1e258e044e..fab7d7efcb 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -171,6 +171,8 @@ mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr) } device_attr->sw_parsing_offloads = mlx5_get_supported_sw_parsing_offloads(&hca_attr); + device_attr->tunnel_offloads_caps = + mlx5_get_supported_tunneling_offloads(&hca_attr); pv_iseg = mlx5_glue->query_hca_iseg(mlx5_ctx, &cb_iseg); if (pv_iseg == NULL) { DRV_LOG(ERR, "Failed to get device hca_iseg"); @@ -402,8 +404,22 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, sh->device_attr.max_rwq_indirection_table_size; cqe_comp = 0; config->cqe_comp = cqe_comp; - DRV_LOG(DEBUG, "tunnel offloading is not supported"); - config->tunnel_en = 0; + config->tunnel_en = device_attr.tunnel_offloads_caps & + (MLX5_TUNNELED_OFFLOADS_VXLAN_CAP | + MLX5_TUNNELED_OFFLOADS_GRE_CAP | + MLX5_TUNNELED_OFFLOADS_GENEVE_CAP); + if (config->tunnel_en) { + DRV_LOG(DEBUG, "tunnel offloading is supported for %s%s%s", + config->tunnel_en & + MLX5_TUNNELED_OFFLOADS_VXLAN_CAP ? "[VXLAN]" : "", + config->tunnel_en & + MLX5_TUNNELED_OFFLOADS_GRE_CAP ? "[GRE]" : "", + config->tunnel_en & + MLX5_TUNNELED_OFFLOADS_GENEVE_CAP ? "[GENEVE]" : "" + ); + } else { + DRV_LOG(DEBUG, "tunnel offloading is not supported"); + } DRV_LOG(DEBUG, "MPLS over GRE/UDP tunnel offloading is no supported"); config->mpls_en = 0; /* Allocate private eth device data. */ From patchwork Tue Oct 12 12:45:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101216 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9A10A0C47; Tue, 12 Oct 2021 14:47:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5F6B411A2; Tue, 12 Oct 2021 14:46:49 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2045.outbound.protection.outlook.com [40.107.102.45]) by mails.dpdk.org (Postfix) with ESMTP id 01042411A4 for ; Tue, 12 Oct 2021 14:46:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLan7HqZGArHv2SNO5lhXZkb8Qt1DAupkKNcgJbn8h6/qI0Psjb9eo2IEI2Fin1Z+ax9iKUmRa9dNRUWUJASw0u/u99nmRZai8+foUOqhL9964cKqqTBVp/e7UAU02DIoUcph2LNifUj7t0r6C18Db0VQWLvs316KrGvmv80Jqjkq4XOYt4ZxcVAisV3sXGlOAmNF+uDux5ov5dQyiU93ifzXc/NGYUZQaqkt383q12MUgaDZcXKySbjBsGxmbLKuYTJub+ydNMoGm8z8TuHEGV36Y8Bh1SfBFF1EXwC4cbD6LeZv3oo70xgxr0g3wgRDKHpqRfMPlmz8Yy+f9oDYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xeBp5dQuWTBPB6NwOJ7aTPdYdBNXGKVBaU3EAdZ32zI=; b=Yf4fCr8edzibnnA2AbqDXbj8mo+SLYSHoFcntyb57qrpKdKJ2Dn9xhEhRzUKaDdPwtO0qhgsIz8Qy76MsRhsyYhhhdJeryheU1OHk+auEpWqqMYC4R/thj32ykXXO9OgYWSzUolovuOi3zzC7uU/243+uIEFyBblYlnAEls8lhg7HktCfAwLqv/h/01Vi5QPS1UO73yp9+tzV1wlp5AkPMHh1dHh/f0iob1NIfEBa27ld65QkyTYQFqzDV0OCAXAEZIu7TxayaAZXGBGdSwMczYhJyEYJBmMjn93tByvL4ryW7Zz3QDNqjyBxfGwhcGJ7+lJw1GZBVrZMB9VpRJkcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xeBp5dQuWTBPB6NwOJ7aTPdYdBNXGKVBaU3EAdZ32zI=; b=kn/j1sPmd1FbraQCndyxyFp5nNIOATlaJ/cZP+3WMyXHmEdkSUcvZBKO5GrCb7vh10B1CKTeD+q3nDfmiPsdGxB6YOYhLUcJVHj5jQGpSxVjrP/DNZNMDGeeImpKPBo1V3t97Mb+kmJ+9+WS8CjBlaeMfhHyFyAWvMElSt9tHz1mIxANJYRUx31QRl4VdRrYEH+NHPoXpU9EtchgLSS7FKiPJ+iG6omQ9HNdyMc+22g30IQMT7zkWJoi1HvYZePy5roesRNOhVw0NER81FfxKVuRIE2+ARUTUOvSZxsfSb3BrMYzvtLZA3rHjnoR7j1ETRWOcLj0DfLH1Xi09EZ0vQ== Received: from DM5PR12CA0010.namprd12.prod.outlook.com (2603:10b6:4:1::20) by BY5PR12MB3924.namprd12.prod.outlook.com (2603:10b6:a03:1af::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Tue, 12 Oct 2021 12:46:46 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:4:1:cafe::7b) by DM5PR12CA0010.outlook.office365.com (2603:10b6:4:1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20 via Frontend Transport; Tue, 12 Oct 2021 12:46:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:45 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:37 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:48 +0300 Message-ID: <20211012124554.21296-8-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed747a3f-f5f0-4afb-83d0-08d98d7e59b6 X-MS-TrafficTypeDiagnostic: BY5PR12MB3924: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I9SC61HsIskNCGWoeclpLQhm/2OCXR2+rtMFm0gFTy+gCaoK96FrCc3IPxc9qb0qf66STGJj/dJyfrW+WNLXeo6+1TY7nUlXk4pe52/zm7YDIq34cnmMM5tSIfhMvhdgUlfS9TIgkc9gX3oARbUmseUSzQDImUwDG/+H5EK35+ls+PgVnuooQkICX9DyoXGaVT2/BwWkoDb/wIw1acgjE+wRTyJ5MmwMofF31q157eOL5lgfS0USH0sHK0y5xo/CZSV+dH53QTAnQJ6xWX3jxQEosvtb+TwZ17gj1eABP482HFNWYV1YCcPr8hkrF2YdQqvBc1zDJb0+LnGvlRC6H9OBzzYgymWWz3KXnRDtp83llsTsjTKAnKSRrnRkVLqBW3d98UKDNLEYG+Nf2V+2ExHAFslhgAhIHwjGNozVlyOP+6bPeKZzV55nmuuBgmnU6OHP3aWHYfeU6XYa6ao+yMr0QvRmWw88Ft7jHjqMpIZIZc99ofyzurPW6T1ZkTNLrAccY5KGH6oSSiRItIWQ7ThvQ3XEIxQXMi2qdPFR20I1BXctSTsAjeSJEEgovaFQ+RrvcHNk+Af2Iejdh4MP6s3R+t7+tBXjN6iWxhppx8NDq7oJkL5amppNo/ofOzlgu61+5w9z79L3bA6Tlr3u/K3wTPc8h+QkYU8bNupoPqw6id5vuhoeEaGfXKwWwoft70wk8JJSV/4jd7yjejRzHw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(36860700001)(47076005)(7636003)(55016002)(1076003)(6666004)(6286002)(8936002)(36756003)(107886003)(356005)(8676002)(2906002)(70206006)(316002)(2616005)(5660300002)(26005)(4326008)(336012)(7696005)(54906003)(70586007)(82310400003)(186003)(16526019)(6916009)(426003)(86362001)(508600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:45.8885 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed747a3f-f5f0-4afb-83d0-08d98d7e59b6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3924 Subject: [dpdk-dev] [PATCH v2 07/13] common/mlx5: read TSO capability from DevX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5 in Windows needs the hca capability max_lso_cap to query the NIC for TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index cd18ab584f..be3c3e61d1 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -987,6 +987,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, hcattr, csum_cap); attr->lro_cap = MLX5_GET(per_protocol_networking_offload_caps, hcattr, lro_cap); + attr->max_lso_cap = MLX5_GET(per_protocol_networking_offload_caps, + hcattr, max_lso_cap); attr->tunnel_lro_gre = MLX5_GET(per_protocol_networking_offload_caps, hcattr, tunnel_lro_gre); attr->tunnel_lro_vxlan = MLX5_GET(per_protocol_networking_offload_caps, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index 893a24dd3c..7a0155558e 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -113,6 +113,7 @@ struct mlx5_hca_attr { uint32_t tunnel_stateless_geneve_rx:1; uint32_t geneve_max_opt_len:1; /* 0x0: 14DW, 0x1: 63DW */ uint32_t tunnel_stateless_gtp:1; + uint32_t max_lso_cap; uint32_t lro_cap:1; uint32_t tunnel_lro_gre:1; uint32_t tunnel_lro_vxlan:1; From patchwork Tue Oct 12 12:45:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101217 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5E69A0C47; Tue, 12 Oct 2021 14:47:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1D00411B7; Tue, 12 Oct 2021 14:46:50 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061.outbound.protection.outlook.com [40.107.237.61]) by mails.dpdk.org (Postfix) with ESMTP id D6A35411A2 for ; Tue, 12 Oct 2021 14:46:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sey3n1kAI3JodVuzR/graNOaXRtNDabi3aWmNQagYKNups5/Q0AGns7JVZAAU0tT9fUbzc0ytfpOzIlqf7UfsuL802SEyPSvhUOH9c+oseKr+ydGW0RLPJ1R/WsBww5vnVowX/USNgpA+NiFfA74n01P1rOfeKyuBIxjJR28LuO524GPVGaz6EaR0F6q4QxKTnoZolM8gWTJI0hdJLamqpZa9/UwkG1Cq6TjWPJJnwJnOagoFSDOeW4D21nDuMfAVUDHiEOYV4sWH7eIeE74SZlcDSxF2VCIAib5O63huuY+wdA1EcOPmuSp2tPu8GUQlKVFOayxg7T9o2YOyprCuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9FY1nxaJfqHkGLFd+bxtb5Pst6DWZpi0bHYOQJ/wZU4=; b=lKwWYyQOToqKrcoG2GqAffMkVMW2+YS1VEupMCzTfBgqF2h7OScYp3wv1puoZNrN5lrhyxTUSXorWAn3OOFhQyu2QnD94GKwI+k+RaTIo/ycXq6PoV+8hN/yKOKFuSxqJtOM9NBwh+kdQXWMia0lrCSZQ8jqhUvder0iiajKF0SuBpYAgsdOqg4I00HqKzECH6fYQ3eeggh0/qy09Q3KzLg3rzcTyw4UQJJXm3vMYMHX8L3Rd3uaFj42LkXxyREFunvFqHgkGGnfBUdFqG0eRr3LMaACBARzLtQkyw7qMrKOj+2tjWdpnpDjI3uj4rm9TUgN8CWy+zghMZJ7oprLnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9FY1nxaJfqHkGLFd+bxtb5Pst6DWZpi0bHYOQJ/wZU4=; b=kHw1B0bn2D7V+QKr7VpfuI/Jq/AmAGQK6shovt0CQGrZLlzWmdCqkXPNrIOHRwj4fGGetG0BCpjKE8nrKeGbdqCPUM7bwVtLgbvz8as0G+2Ogi3tNwvQL51TYCrPcEuN2B96mzUpKMzjPAUa72aW7a4b0leqsRHBa9WpUOFJTWe2FgWTnuwdXd3xwJ4uF8NrYiCXd8Fhppx0L/i+WNSBQzQ2Q5kVLwV6ZxdfqnxZ95XdhE6cn1GCPBkuQXLppUQf6J1ASsiBHWPR5IdhusgLidouP4fkCCCzjn9R8tSvT3Lq1l1azxYbNNQU/Z/7epKx9k0yGddcAFhj+iDH8OIxXw== Received: from DM5PR12CA0021.namprd12.prod.outlook.com (2603:10b6:4:1::31) by DM6PR12MB4281.namprd12.prod.outlook.com (2603:10b6:5:21e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct 2021 12:46:47 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:4:1:cafe::a9) by DM5PR12CA0021.outlook.office365.com (2603:10b6:4:1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:47 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:40 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:49 +0300 Message-ID: <20211012124554.21296-9-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d87401c3-5459-432f-8701-08d98d7e5a8f X-MS-TrafficTypeDiagnostic: DM6PR12MB4281: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7PC3y50MdRv37K0MSsUg4AztlooPcjiL9gUpqNKOWdiYJx21h1W/E/AGJTNa7EH5R18IcODjx2E6yvrCZFIKt1v/fOHZRNSkPnFXwQEZdePnlR4w/leGZLefY7MXUfeQHjecXLBpOlSE/EE0waCc0U0LOHSswybTPPE5l/6IfEXSIR6lJ+GXj9xPXxyxWOJQblmr9E+PGXlpPxgnw+a625nQPU6d+yfA7IHqAGFUW3ZkOl6yom4EjkZXJL9UAMwz38zRa8Ch8ev0LA5j2sccRsTnD6rfnkedgCjjv+NZYw/wSPKPq4cL4Mm3ZWpwmQqRbAL1TBMlyJ36E3GzGwd3KtcUce5Y9ehCsZguSD/2eW/Zn6txpaiS99tvBPnfvr2VDkly/RGeMeel7mji9Ps3QxgfJW4Df6vho18UEj+8TWpwLyxmNxQ3yYkprjmpTYaK+gkpLDirmsUTqwJGeHHp4qsjl+10GhW0ix3Wyv2DSFr0hkBUPZkviEJQrvhAtiK0/5xZZbLItvLr/CTgNst+tG8Az3y5MOBCpV6ly49AJj7QbzL/bYYCjY9h+OwYtH1Mk4cNeQOb1qXfcjraiR8oWseW8MhuQP6ju7WmWtcSiY/a7sixc2qnAPbXV17zNOt1C5yuOaEYAeHP8hfCZ1KoMVfIesHkkBYMzH543FwROVvtbEv0tPG6R+TeRNoft04K4w2rllBVSIs6ZN1TB6yoGQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(70586007)(186003)(55016002)(70206006)(2616005)(54906003)(8676002)(26005)(8936002)(82310400003)(316002)(36756003)(336012)(5660300002)(426003)(356005)(7636003)(16526019)(7696005)(1076003)(6916009)(2906002)(47076005)(107886003)(86362001)(4326008)(508600001)(6286002)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:47.2928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d87401c3-5459-432f-8701-08d98d7e5a8f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4281 Subject: [dpdk-dev] [PATCH v2 08/13] net/mlx5: support TSO offload on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Support of the TSO offloading by checking the relevant FW capability for NIC support. Supported offloads: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/windows/mlx5_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index fab7d7efcb..194cb7d9ad 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -165,6 +165,7 @@ mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr) device_attr->max_pd = 1 << hca_attr.log_max_pd; device_attr->max_srq = 1 << hca_attr.log_max_srq; device_attr->max_srq_wr = 1 << hca_attr.log_max_srq_sz; + device_attr->max_tso = 1 << hca_attr.max_lso_cap; if (hca_attr.rss_ind_tbl_cap) { device_attr->max_rwq_indirection_table_size = 1 << hca_attr.rss_ind_tbl_cap; @@ -494,6 +495,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, DRV_LOG(DEBUG, "Rx end alignment padding isn't supported"); config->hw_padding = 0; } + config->tso = (sh->device_attr.max_tso > 0); if (config->tso) config->tso_max_payload_sz = sh->device_attr.max_tso; DRV_LOG(DEBUG, "%sMPS is %s.", From patchwork Tue Oct 12 12:45:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101218 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 027A6A0C47; Tue, 12 Oct 2021 14:47:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07E42411BC; Tue, 12 Oct 2021 14:46:53 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2058.outbound.protection.outlook.com [40.107.92.58]) by mails.dpdk.org (Postfix) with ESMTP id 618F2411B1 for ; Tue, 12 Oct 2021 14:46:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VzxynhZjqquTyX71l+G6y460vpeGFUBCvjVLKhbVJx4O/i9F6IlYu+S27aw2bMj8kEkpu8LG5D7RzH8MH3luW46WRqlZvx8fZGha6rC2TwGJNas52hlIvnjEwywJ+srlEZjHA8ACXQEtIJ6mNuA0jlSs+80EVnfAidC0WblUI/z7v8+tupa1uoXiMlU1cx1+24UxXhY6FY8isvpWdWQ+FRomxFmSCv+gEm8aZNRxeu/6BwWMaN1kPIH53Y8gdhl6DQn4etNxtKEtRmgp1z+2ujA5UOQWuL5clbm/pfCZ13K18HKhCYGWQXRjGRX60HFRrVUitTE+ALiyUssODavyhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JWIruu3AC9KnRVDviDy9nOnPJUu7q95RPG/i2xHmNn0=; b=JY2oDpYTYJ0M/IxD9x7Zt292+CJPAyEQfSYzvecm0ku0SAPy6GiYh3VPqCZTehNHrxo7C21HMpDt+xUmTChONB/2PznAGKJ2IDdmlojZ81YmyFbu4S7ZtBGLD6xYvux2CEY9THOH5xuIAyiOl0pSipsSdGlw82E5fJ0QUcewINy/Ynfs9QMA3WGpXr+99M8zOXZpxfglfYSE3Cwyzav3V9QMOmvL3IXOg7O4tVBZMr5Ea8V+ixmNM/BAvzOCfc8H6Duk1IGfgQWTY/MsKCBg9I6o/fLetY0E065uBK0VAQaET8C0BHLRD2gOmGvFZ9SE5KuQEulJKt+6v7Xqqxy4aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JWIruu3AC9KnRVDviDy9nOnPJUu7q95RPG/i2xHmNn0=; b=qbkK3K4l/VcnxF5G0k2X207m4H4WG3FVtQmzyeoSM8c1ijdIPeLCPjBL/OdHJmXSGoFVo3NocLpXWHpfsgms5q7RrAKkRmv+VLeZdQ9yxKkCnuE/9z/zSH2ebazKlGdTA4r6B7I0d6EPeHkmCE0mma3nZREg/4qBUkFhTRuiFk0JwhB4cKvFbhtD1qzseE+dyUJwCWNK+jVGedg8ioNWmM7j0sLCma+Tv2KSnH5xZ7So48lRx3JJZBIKAMqo3bj4ujhgRD/CTS4X+EHgmKHPBMpvPs06jk/QsMqHm6/C6cVSp0WmkDx8zOg4nJ9+EG6UT7cwoTy2IDYqgnoL+HHQIw== Received: from DM5PR12CA0018.namprd12.prod.outlook.com (2603:10b6:4:1::28) by BL0PR12MB4897.namprd12.prod.outlook.com (2603:10b6:208:17e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct 2021 12:46:50 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:4:1:cafe::3f) by DM5PR12CA0018.outlook.office365.com (2603:10b6:4:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 12:46:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:49 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:43 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:50 +0300 Message-ID: <20211012124554.21296-10-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abfef89a-c9d8-4a34-710e-08d98d7e5c22 X-MS-TrafficTypeDiagnostic: BL0PR12MB4897: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x1YRlwLqjV6DKcx9KhQAeUNwsxA6qJFy1V2l7w9+UE8uPuJ4MTNyb5PTrGKdEMPjjSpL5mkkDgAwMwzUSKr/pbevBpdl8LJ39TtEigkMxqbDyiAu+k+bBHdxr3FI1GD94nkhnYYspOeqhFc4Eb4YMoHX6QabAXY2Sr7h2Z9L7AP3I2gJFq169TNaAwCnfP2NRSIsaBGo5NoO7Fhym1NeYCdexIopYGbNYeipYWoE3Z+tOazeHl1+sVjUtzfM0wL4rodZQQw9u4lS/24yx1/6jiK6xNnMA1WiBf2M9t+FbS9H0Ebdt9+gQMJLd0qrLdElO1kWPQI3gf8UpsHMDWF/uRyn4vH4DxLhRTuXDUTutKjkzKqEbsPoyCx/Xj1Oxx3FDD5DgeIoa9czgfTXPqfZl0DTNJWc4mJM3JktJcATV0JkbSZmnd0Z8uEhv4JlTNX8rWCih/X0FGcWORlYBYhSyoDLJKayq7G7YV800izeQ8nXtxcUo8LX8muxEKWIv2nL2v36jepwLMfUVDIf8q145yhdVNNvwyozuAWTaN9Q4RBbeC6U87Si1lDmpVfmT0cgG9P1bM7YHRuklp7gX4nHGgQUF7atR4/sMqxWVdUe/4hNgrGfYmNFF8e7MU3S7gUtiVE8SBxfbQbDM7yUpNvS/WdA9ojTKkf4qerw26JAbijAoBtZwNmtpdgri7vstDy6TH8MwAQJQK1A1BxqsnjroQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(316002)(2906002)(36860700001)(70206006)(54906003)(426003)(356005)(7636003)(82310400003)(4326008)(6916009)(1076003)(86362001)(6286002)(16526019)(7696005)(2616005)(70586007)(36756003)(47076005)(336012)(26005)(5660300002)(6666004)(508600001)(55016002)(107886003)(186003)(8936002)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:49.9463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abfef89a-c9d8-4a34-710e-08d98d7e5c22 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4897 Subject: [dpdk-dev] [PATCH v2 09/13] common/mlx5: read VLAN capability from DevX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5 in Windows needs the hca capability vlan_cap to query the NIC for VLAN stripping support Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index be3c3e61d1..deee4954f4 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -985,6 +985,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, hcattr, wqe_vlan_insert); attr->csum_cap = MLX5_GET(per_protocol_networking_offload_caps, hcattr, csum_cap); + attr->vlan_cap = MLX5_GET(per_protocol_networking_offload_caps, + hcattr, vlan_cap); attr->lro_cap = MLX5_GET(per_protocol_networking_offload_caps, hcattr, lro_cap); attr->max_lso_cap = MLX5_GET(per_protocol_networking_offload_caps, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index 7a0155558e..f4aa851cd0 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -108,6 +108,7 @@ struct mlx5_hca_attr { uint32_t eth_virt:1; uint32_t wqe_vlan_insert:1; uint32_t csum_cap:1; + uint32_t vlan_cap:1; uint32_t wqe_inline_mode:2; uint32_t vport_inline_mode:3; uint32_t tunnel_stateless_geneve_rx:1; From patchwork Tue Oct 12 12:45:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101220 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 995C9A0C47; Tue, 12 Oct 2021 14:47:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E15F411C1; Tue, 12 Oct 2021 14:47:03 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2060.outbound.protection.outlook.com [40.107.212.60]) by mails.dpdk.org (Postfix) with ESMTP id 7BA9B41120 for ; Tue, 12 Oct 2021 14:47:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=em6MFuINUCW3FxLLwv3pGak3U47Nw7eRS0BJhG5lN4H9B4fJF7Lsx+6L06Jokd2h6G/wfoiDb2e/28mQTDz3VfQ5wlpo1Ir0lOsRytRKGrGbQ8mz+CHeSjXaOynPgfdfWL5fuDnlF1aQjObh5oq6XbkyYMubkIuEkXePzVDTzBjmJ5jIxiRHIof/bwPkJ7D44OGyqB1l0RUMttPfqGnQ5Z2xMkHZze8S33Ch5gC2NanBHYLaPCXVTJa9ihwf9x0bFABd3e31J01f+JEDjqjMg6ghp1ZmJZnP2WHAJaPiqjn3PHVsiS/p3kNZ1qNcY5g0jcDK/u3MlGo3EG1e1G45sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Kx4nNwMjT4eeHpAyCI6MYquuRfbZZgbQgApN9QJHxg=; b=So2iNX5FqMmE1KFz3c/Dv3jTBNY86FqZjTe446IQQsjz5UAXEygU0vELExSOSnjNXJTC2dOUNTHfJURQR2QNBgQSOvURvuM3iRloIqAUBU5Hddi/cW7z53G6xiXU+iqwW/yWJLeX78lFo+LpZZJGLirSCvTymOFPTXztZL+IikyHUl0fLfa+0/Q5PYZ0Ikd0jrcMVGB8E0nLMBGLHTrWwoa8Q14yyC90GzuwcLUPmi/THhu/vYSnuzr+JzuHKTRSG/qeBbZa4qpQDoojoKp/K+9d/GNvzrAeoHMGOJBvXTvfs6IM1zeeA62gYAdf2IfZvJhohnu+l1gg/R2aPFun0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Kx4nNwMjT4eeHpAyCI6MYquuRfbZZgbQgApN9QJHxg=; b=tltQ2FcXCMe1IZ8/V34IZkseDKlyNYZ/QpZxE5fR+F04U+z0XrLi+cokHkzFzeTNMrX63/W2ZgFQU1CtC0Lv+UJuaEBr9OWBs+TZgsdspypHpNrlIg2uvY2tHGNYJQJKK6d1a6ft5IJbconbzar5ZxD1oYCWxIeAhnPsRYP/IXLqBq22HG6Wc4jpCCF1c8y+QALT1UfjUwIWZTEmaX9g89LddVa91cmqzlCJkYxWZ6gn+b4myZuECXmyQ+c9t0+5ihtdN1+SyM/TS1n4hjpnYbuCDfpllehRALDa3f2geUWrBVIUCMursK1fYu6CPJ4FLuBvAou787bqcxiVdLbXCQ== Received: from DM3PR14CA0134.namprd14.prod.outlook.com (2603:10b6:0:53::18) by MW2PR12MB2522.namprd12.prod.outlook.com (2603:10b6:907:f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct 2021 12:46:57 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::d2) by DM3PR14CA0134.outlook.office365.com (2603:10b6:0:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19 via Frontend Transport; Tue, 12 Oct 2021 12:46:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:57 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:45 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:51 +0300 Message-ID: <20211012124554.21296-11-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1dd6e5ff-e734-48a4-fc65-08d98d7e606e X-MS-TrafficTypeDiagnostic: MW2PR12MB2522: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p6jdBAmqM7DJkk1Up0JjhsUw6jPKLsGQX6rNLkP188iHgIekgZDUbsFIruizTq9CT1fNPd4nCQCNldBwngvsUwlUBxAVCaETpkIZ05Mq/2LSib4nGCGJu0rcTAonNqpsqS9G9tm+f5ja62/4DKu1Px0jMiQmBMU6bT7motCEVukqvs02XmBwU3AKEo9sIOM5AHHyEJ7JO3vZJhKc19c3y4Dtfp7ZvcCySw1IP6LCWFBUXnKvstsS64xr26pn3mkxYedQHQHfuxBgvYwkeTLVywhOY/z8K3H7nbea0Lx5D07am9Y1WlKrpF3zPE1SyiJhaOhtKVW/Fo3Ja7TxT2XFDgrYy0mFyYEv4s8vWklHmdXwVpwqJiDqTk7qaMCRm4naqyNNvkawQWTSUavJu/9hvcaOgQET62rHxTXKYdxONJPHfTSalPjGZGePx/twkrdu8uSv5V1kZwa6OtuoB5+gS06A5vgtY3dUIO7SXMaDvnoEMOLtTgTlucVpnWaSGEWQChN7x7yB7CXEALcVNKUXZdamsPiXEL/Q9RMcmdsVyU/PlABbsyJIo1ebRX7u6imEG8BA58LjNHAgasEPslfnU7oFE5DsPGb8ERAFkzphJsQ3bFRR7+/mGVzgGRMTIiCo+yBm2FMTjbGRqDxloIXZCZgNPE+Ty7jkaBsvMazb+zh0QmsMy7PYYeEOIj81HZMBvcHcrbLbSptII0PjsxJ3ZZ2x2mH5U06hUP1g4786Ggk= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(336012)(8676002)(36860700001)(426003)(107886003)(1076003)(8936002)(4326008)(2906002)(82310400003)(356005)(26005)(47076005)(6916009)(7696005)(2616005)(7636003)(55016002)(16526019)(186003)(5660300002)(36756003)(83380400001)(36906005)(508600001)(6286002)(54906003)(70206006)(70586007)(316002)(86362001)(6666004)(168613001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:57.1929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd6e5ff-e734-48a4-fc65-08d98d7e606e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2522 Subject: [dpdk-dev] [PATCH v2 10/13] net/mlx5: support VLAN stripping offload on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Support of the VLAN stripping offloading by checking the relevant FW capability (vlan_cap) for NIC support. Supported offload: DEV_RX_OFFLOAD_VLAN_STRIP Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/windows/mlx5_flow_os.h | 1 + drivers/net/mlx5/windows/mlx5_os.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/windows/mlx5_flow_os.h b/drivers/net/mlx5/windows/mlx5_flow_os.h index df92f25ce6..dfcb012334 100644 --- a/drivers/net/mlx5/windows/mlx5_flow_os.h +++ b/drivers/net/mlx5/windows/mlx5_flow_os.h @@ -44,6 +44,7 @@ mlx5_flow_os_item_supported(int item) case RTE_FLOW_ITEM_TYPE_UDP: case RTE_FLOW_ITEM_TYPE_TCP: case RTE_FLOW_ITEM_TYPE_IPV6: + case RTE_FLOW_ITEM_TYPE_VLAN: return true; default: return false; diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index 194cb7d9ad..5b941cdb19 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -489,8 +489,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, config->ind_table_max_size = ETH_RSS_RETA_SIZE_512; DRV_LOG(DEBUG, "maximum Rx indirection table size is %u", config->ind_table_max_size); - DRV_LOG(DEBUG, "VLAN stripping is %ssupported", - (config->hw_vlan_strip ? "" : "not ")); if (config->hw_padding) { DRV_LOG(DEBUG, "Rx end alignment padding isn't supported"); config->hw_padding = 0; @@ -524,6 +522,9 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, config->hw_csum = config->hca_attr.csum_cap; DRV_LOG(DEBUG, "checksum offloading is %ssupported", (config->hw_csum ? "" : "not ")); + config->hw_vlan_strip = config->hca_attr.vlan_cap; + DRV_LOG(DEBUG, "VLAN stripping is %ssupported", + (config->hw_vlan_strip ? "" : "not ")); } if (config->devx) { uint32_t reg[MLX5_ST_SZ_DW(register_mtutc)]; From patchwork Tue Oct 12 12:45:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101219 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1599CA0C47; Tue, 12 Oct 2021 14:47:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65A8B41120; Tue, 12 Oct 2021 14:47:02 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by mails.dpdk.org (Postfix) with ESMTP id 72D2A4111F for ; Tue, 12 Oct 2021 14:47:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f0K/MVyUwCYzAAVOdUus5G1ODcTBf/VqDhzYpkGlTrlniuRyx4xTBUEyAA/sJ2Qv/EXa/LWa9cRoZZqkwsYGH5ARVonsKXJiPoYFk41KFEaBTWFkUgdra0hxbAZefT68rZMhGf8V9i42JFL4VOpcfDt6BSlcGO+fciX+1i6MxOixtT3iuQsXZSHSC8wlqSEkDlJfWIliqUv3VPqvtZ0rP9P3+l2zN3KEsQDNsdpVKvUq/lai7+lXuOkOXxYMvyZZ29ToaJfe/iDFAYV30SC8CbVPA1Ynrdtasj/N9Dzq4AcPHTXhg/Jeu+YjkzfyFYx6sOAfnn54omsD3GT1xgS+lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nT/OaQB2km+9v9GkAkW77A5gZGs54ZrGsdzqzPN3c50=; b=LqLFkCoHEn88z4X1Vv57RzfUrLE+gBJN+WUs7SPz/mxEKFlI263DSrqRJmGxu19Oy8mHpjNqSJutf2Eg64V7u41dzGmprTEAWaZffKazSsA8RNV8YWegvM/WjGFMu655u7DftEEr/ruXxFbvMnzOy4S2S2OxM7MTkypG22EIIrBNthMzR6obuxiF3DymmONE70FSTnUQy4BM/L59Dw3EgFUKDYEae8Ca2ZG984K1MgDbjsbIzFyIegDA7TLSZi7rQjPZtCyf5RBbP/sLSGmZBfx7fQlfEKu8mC3cTfY67hLREUhB1EJY9P+cus6aXiu1LeoTo1Qbx0EVsqt+jP57xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nT/OaQB2km+9v9GkAkW77A5gZGs54ZrGsdzqzPN3c50=; b=UcaXw3GT4Rqv1d4V+/eEYpEWAk8PrEOIr17Uq+wcTtlsGSLSUmHHA70QiRzO9tuydp3ScbxDgGyrARuk8a31Y2n6+corklgLiYB4IIW42QVwUiGSQ1A5+JJJtRGVisYx/hjnv54+YKtV/wbpd8iMQeUsGioxXFxsRh/f0gPTXxMSQhKQVl+qetVWMaaL6CqOOa1hwKhJq79Mi3YlG0U6eY9GZx28b4/whqcUyFfb1qlm6Parxkk4ZmHMXh7jatQ1jbUHVSHfh2433Hs6uoLZ4ej4HVtfFFrFw2P19mANP9VwwKCrEiEKyEB1+3nFZTbzUNLZRN0u985Q7uq+U0MlLA== Received: from DM3PR14CA0138.namprd14.prod.outlook.com (2603:10b6:0:53::22) by MN2PR12MB2959.namprd12.prod.outlook.com (2603:10b6:208:ae::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct 2021 12:46:58 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::e3) by DM3PR14CA0138.outlook.office365.com (2603:10b6:0:53::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:58 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:48 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:52 +0300 Message-ID: <20211012124554.21296-12-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 576f4b53-cf7e-4205-fb15-08d98d7e615a X-MS-TrafficTypeDiagnostic: MN2PR12MB2959: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5jc7qYsQ9OE2/ZfzeRzTHglBFua3wKN5z/6WhUVYapx04gGx2Sl/fyUDLFXvVZSy0tvoqe7PArVOqBXNhWePW6yeePA7frTMvBU5gg1fjM3PAtsNHzfB7spavs5bClX6pqJHoKY6dX+bSbNNH/uUwzra6/uGqqCcleezdFAkdFZ+3OVMii1h00UBigjCwCL/cGGaNiwKnQOBhSqhVTJE0+NIT5B1FXo/GqSpjc3xfE40M3tg4Ihc89UOuL96oBWLXkXjDatGqBYJe1u/0Eo4RSpEsB/woW7yKw/w5PZBQO5P+HDjp6faKyR0zAEUFcOD5wP4KRalRxzpY9GzDv1PkAWv1y+Zt6lRbhsHeZL4JJa3ag3ZL4sQJTOgXY1IWDfqQVvE5L6jl6jxfZVUPAj1Rkh4uBA+r3oMm4gsqmvwjgO4WSHYyc7XlVRE8MJ2MOTPlr59WwErNVMLhJLXwU1wcTw5cjmw1SHucLkCe9B6OVxlqoITKHGdKnSFfz8FXfReQLePahBa/qcu/i+HQz6bLrFjkWC/SYpj7r3wJHrzqasrpirLh7FammBXWanxu7THN1mdOA5BBotRkALnvf9+vB6CGtpaUy7AbfQqo1zrRz4MHvACoKAAEk6YSgdHVNf9DhIyS7NWSNj2e4ajH/meSC68JHEA3GG5trE2j/hTOKEs6NcAauD83+Ro8Al+ZXl2kwCKQHIxwjvLcEJQQDEJgg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(70586007)(36860700001)(8936002)(6286002)(7696005)(5660300002)(26005)(186003)(16526019)(86362001)(107886003)(6666004)(1076003)(8676002)(36756003)(426003)(316002)(508600001)(36906005)(55016002)(6916009)(7636003)(356005)(70206006)(2906002)(2616005)(47076005)(336012)(82310400003)(4326008)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:58.7355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 576f4b53-cf7e-4205-fb15-08d98d7e615a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2959 Subject: [dpdk-dev] [PATCH v2 11/13] common/mlx5: read FCS scattering capability from DevX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5 in Windows needs the hca capability scatter_fcs to query the NIC support for the CRC keeping offload. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index deee4954f4..33c064a418 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -991,6 +991,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, lro_cap); attr->max_lso_cap = MLX5_GET(per_protocol_networking_offload_caps, hcattr, max_lso_cap); + attr->scatter_fcs = MLX5_GET(per_protocol_networking_offload_caps, + hcattr, scatter_fcs); attr->tunnel_lro_gre = MLX5_GET(per_protocol_networking_offload_caps, hcattr, tunnel_lro_gre); attr->tunnel_lro_vxlan = MLX5_GET(per_protocol_networking_offload_caps, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index f4aa851cd0..6b9f191a69 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -115,6 +115,7 @@ struct mlx5_hca_attr { uint32_t geneve_max_opt_len:1; /* 0x0: 14DW, 0x1: 63DW */ uint32_t tunnel_stateless_gtp:1; uint32_t max_lso_cap; + uint32_t scatter_fcs:1; uint32_t lro_cap:1; uint32_t tunnel_lro_gre:1; uint32_t tunnel_lro_vxlan:1; From patchwork Tue Oct 12 12:45:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101221 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83FB2A0C47; Tue, 12 Oct 2021 14:47:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA86D411CA; Tue, 12 Oct 2021 14:47:04 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2072.outbound.protection.outlook.com [40.107.93.72]) by mails.dpdk.org (Postfix) with ESMTP id 2248C4111F for ; Tue, 12 Oct 2021 14:47:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MB2C1QdnnEW7l8y1XwGTETzxkVte3XdL/K9JhOaxC2AzVGgQsxtHLOiLCPpnKCgvfbeUmdGEjQClmlAZb8JCPl5ixMq03U3N3Q2rBV96z5JvyfIywoS/Kx2ds5B7KMBlSnzeO1jA9i6Wib5ATWvmiDMAm/jTm3eqs7dwUsVd9rDPIAog81uW0EV9yTT5PGK/M25blCD4SeYEcSWIcxr5yqAv/S30JtQ+ghATKB2smlEjdrlaoOmovR8R/k2lSem81o9o97Oa0mt0uNMW8GTlQNHUMGhld8NHZYggh8wMLpQqK9kwsVYJHTeFRLh7Gf79VFFzH8jxvluOUXGFhWtyGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nno7TMqqyWKRvSNuv3E+G341ZMTDGRy/nMAjkZqFQG8=; b=V+/bjAPHL17UkO7sf/J7LB5z+oVVJUoZTw58NEfdX7J+TatKJFlvUjhlxIMrV7HdW5Q+mndkcBEC6gJL0NdNS4k/Gt0JQ/mkQ4IpIB4CoU6YX94uGFd5jq/RTxQO6L0otQEZi+5XJfIeYY+uiwCJlnbZBZjzWLTPOdPVGjy57zaPFb5Ublv3BQgxrNz3VnOQU2r0sMJ/XNXLcNxAAA6C3vs+KxivZvlMWbDA4ZxhbSK2e7SNP9uZEU7My+Aete3cNo3NbtijSP87CpL/cLD6ad8mUP3/NINaivy5kHYRVZv37+uiAxR4YgcU7ANyxsZ5zXUPpeloEzdSu8GOGbwkAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nno7TMqqyWKRvSNuv3E+G341ZMTDGRy/nMAjkZqFQG8=; b=Y2iiBY0jBaY57/lqURLkigLBMVAvhNR/Gor3rQkNrgoi1AXO7hPYrHJHeqX1qmZA8W/opj8ycMuxrcWhRQT0mo6UdFi3/GLepne2jclVbfkg3yPGJTUCV/TU2auR1Lm9vDWPyCgbZO4vcOjesEzFDb7DrtRM8lCa+56WQKB/kvsyXFYwSFb5nF4jPB44bJ8Y7+vKH+cN+o8F0qKNdgrs65PrbfT//T21GDWl8i6DprSExREP240TZf6hQLIKypuUydWgKNKFAAJIhvo8YSCyqM4tknAAUPDg8qxMpQ0k5IcrWo0X9+G1cpnyN46+nXbKW4GLD/Y8rZtt5T3+u2PEzQ== Received: from DM3PR14CA0145.namprd14.prod.outlook.com (2603:10b6:0:53::29) by MWHPR1201MB2542.namprd12.prod.outlook.com (2603:10b6:300:e8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct 2021 12:46:59 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::15) by DM3PR14CA0145.outlook.office365.com (2603:10b6:0:53::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:46:59 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:50 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:53 +0300 Message-ID: <20211012124554.21296-13-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65839dd6-c8d0-4f8d-b739-08d98d7e61c8 X-MS-TrafficTypeDiagnostic: MWHPR1201MB2542: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nCvozEU2fdgJkXQGPm4/3O+EXsqrLzL6hrcPVH+HkN3KG+WfzD0vk2p9DJrHfthnH2lzOhLIB1Ur33ICgVjTAhj5HDIzKb2Yi0N9sqwusB3yXeBVttqx9NG9p6dIIznAuod0YG1ZLUQlZceN1fSTVCFGutEBWQuYXzq7H2IEJqXeQjj3ofAozSzSZNbiRKG3WjMk32i774iKQ/I1nOmMAS8fwaBV5NXy1/bnObdWqI8EEqEC+4bwLAu8riliGn5c7Mib/QmgvJLQoSi+vW97HUvPpFaa8dK73mTjWUFxfcSaVbiztoSqo+vyQSgb1aR8W8WgB6OUDNy54n541ve2tEzEhdij/+kXq+8sq+AxVKtU39nxWQmQYPKPq6L9Axl3AiqmLhuBkF4gXLgScZ1OLGMs0VYPinHH3/HeK+iG10H6A/XjosfoAXQY4jHsp6PBx1nNLp1X6jTPryea0m4R1UBCL3RyDUjO27GPlJOM9QBRX2y11RrNJGqpCrGeVScgecIh+t393yT+L6aHPmZ7x1dp3UPFfnLGm6Y8G6qrwDCPDLdHWXtfpmeOGvNCTSJdewqLQe2+hplnQfXXz4voWSNsTSJ6wv1o2MfDcJeVqO4xyqcWXvKZCVEN7F0YCGkf3BhKX/lPKnfW1wiGo5un/BJ7MWMZuiogSKKXNWbSxCz7KlOQzdCJrPAaVyLzF+NAD0jySc88MToxk0tpTA8eaQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(26005)(47076005)(336012)(36756003)(16526019)(7696005)(70586007)(4744005)(2616005)(5660300002)(8936002)(186003)(8676002)(54906003)(55016002)(107886003)(508600001)(36906005)(426003)(82310400003)(36860700001)(316002)(4326008)(356005)(2906002)(1076003)(70206006)(6286002)(7636003)(6916009)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:46:59.4467 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65839dd6-c8d0-4f8d-b739-08d98d7e61c8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2542 Subject: [dpdk-dev] [PATCH v2 12/13] net/mlx5: support keep-CRC offload on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Support of the keep-CRC offloading by checking the relevant FW capability (scatter_fcs) for NIC support. Supported offload: DEV_RX_OFFLOAD_KEEP_CRC Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/windows/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index 5b941cdb19..896b6896b7 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -525,6 +525,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, config->hw_vlan_strip = config->hca_attr.vlan_cap; DRV_LOG(DEBUG, "VLAN stripping is %ssupported", (config->hw_vlan_strip ? "" : "not ")); + config->hw_fcs_strip = config->hca_attr.scatter_fcs; } if (config->devx) { uint32_t reg[MLX5_ST_SZ_DW(register_mtutc)]; From patchwork Tue Oct 12 12:45:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 101222 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9564FA0C47; Tue, 12 Oct 2021 14:47:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2226411D0; Tue, 12 Oct 2021 14:47:05 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2080.outbound.protection.outlook.com [40.107.94.80]) by mails.dpdk.org (Postfix) with ESMTP id D78DA4111F for ; Tue, 12 Oct 2021 14:47:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVhPnfO0ZCC0aHcS4FS9BlnAQ11u8uQTM1rB2Afm5Fe3ZrFv9yVmJODERkQCIMwTgFzF2L62WQ6yKpR+iACHVU0wFwWiLmmfjwUfp/l4rab96IdBa+6B3wQYWT5Bh0bByYbqlMFOmawdvwSc6tkobP+HNGuADHMq6P4fkfIMHwfMY5+gwO663PvsI8D+crJ+IAJ5l6NzKPNny9SwPnwuePBL8yHKPEw3BDa7EQo191wm8fhO2imjbVZmvZ2Oy4yPVGYbUFcIZSgnEjf2ytHRhMlzCuokMQITKWh48shzwrM9cxG/zP30+usUOr3zZFdCmQIahKhMe42xBiySxStR6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hCCjj/uSMLCNxJLdC9SXKt7ibGx59QZoGIj2naw5tqk=; b=iKgIHee6FTYa3OIi/UabGAePncooNwVj6VoQwUUgB9qiNxkAvHOI5QuukGXx1fTGaJPITEnPX4FT8vNvHAQ8oIgBwQW5xSS7yH3D9YRgPrZF6zkF6Ks5b3emDRVorXKmj18+Ovxc7mzbqVl43fup85oacEfa6bUQtJYSvyDcL5Dstuibm+vDe0fhPsPG9wPIJKq1NxsR02V8LgBOrkZ7Z1BMYraNo+v2Jy1uQBqKKtg8R8gn4T8tinhLLEi2dnxoZTZR+8sth5Sw3K3djrTC9OlDNUnWODLvN9G22TUJUsxdTsjX5GObaive9G31Wcs3u4KmQMm8y3yZk2rbNAYLQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hCCjj/uSMLCNxJLdC9SXKt7ibGx59QZoGIj2naw5tqk=; b=m7hZLfx7nUKnObToit1nGxFQ6XT/8t7qcH1gfE69Pd8wrUdC3R2AF1li1yb2iwiPSR7pf9AuS2BE1geGma/j+RkDgOSU/kIQl5yxLjQWDtwwcFy0aqK2OgP+8zBgoJO8v18wpIJlmnhJ3ncCcbmZnjAmSBSNTLM+EP4m4eYuSDQTEgR4ZhhV3pZXRRqBm5NMAst4x1lw5vKi8xzD+PGeuKeFJbWai5Lu/nUjdK3gGmvsDOpw1Jkf5eb93FTgtNulqlGo20htH0met+U/L33xcCbfdh/AKJ1t1l8BT2/RkumIkjrUaLjcbgWU0i7377tp9BGEcm9cIYEd94jdjjxdqg== Received: from DM3PR14CA0130.namprd14.prod.outlook.com (2603:10b6:0:53::14) by MN2PR12MB4160.namprd12.prod.outlook.com (2603:10b6:208:19a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct 2021 12:47:00 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:0:53:cafe::b8) by DM3PR14CA0130.outlook.office365.com (2603:10b6:0:53::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:47:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 12:47:00 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 12:46:53 +0000 From: Tal Shnaiderman To: CC: , , , , , , , Date: Tue, 12 Oct 2021 15:45:54 +0300 Message-ID: <20211012124554.21296-14-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20211012124554.21296-1-talshn@nvidia.com> References: <20211012124554.21296-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4a9dbcd-95b1-455d-db02-08d98d7e622c X-MS-TrafficTypeDiagnostic: MN2PR12MB4160: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Iuvroon28DTa7P+ZgY0QMB+5PBBEilz0wUsysn+qddYRzThsgOWhavHKiOCgKXM3hd3xFT2ZpSQ1LGJvP6E5vOvEU9hai4jzX4ELHOxvULeY+Kp5u69H9mexeDxmkE65YWtJwCxofVnpTOPBVI6kKI6uhaYEFi1bjhV9fHvq6HFQBXwizLCBWHSHLBj/uiJy1NkaFeVpRKAhqgwUd+67cZKYpmHRzNwChEENFBH6W3LoCRpyQQG0GE7eOT9Q2OGQetx+ys6z0zINHJv9jy7dY5LwFJA4OdRmNPRsZJ9agF8gEZGFKH2PRO0Um1FK8M7rzY14ljWRsTegUzsBMRlymeGMppHGftvmm8pQK4gK44Vt6gTwCPxBgFlSMqfjgYOv0e4FqJVC/6d+wM0V88Fg5q60uWWfx5CRwBzYM49I8Vx+zYE/IxlCIKB6b9fXRSFXYFkmJz99W17/3vK62yuJU9g5zz32hGjxp0c3kRu5ENDDAAJQnZrMCtqlWd1QJulJOArPLzI7RPbKgQyoZXwiNnXOcBaLRveg2bmj/rsg5uLx3E/dpA2EgtGoUF4r7LQAnReERHbHAfyBwngO4BM7uOh2ZgV2Pa2ULaYF1uxSkZ5bxcq1ZXAKtW47nsjbm63lDKLKZkNtiSa1V0BBDfrBXwNv6WYgQ2bt+LnvYaNw4zG15fOJ8gtForo5/VGNlZo/sDCsED19Fr2RBByoz1QZQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(47076005)(8936002)(82310400003)(55016002)(426003)(336012)(356005)(7636003)(2616005)(6916009)(70206006)(70586007)(2906002)(36756003)(83380400001)(5660300002)(107886003)(1076003)(7696005)(36860700001)(4744005)(86362001)(4326008)(508600001)(16526019)(186003)(54906003)(8676002)(316002)(36906005)(26005)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 12:47:00.0905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4a9dbcd-95b1-455d-db02-08d98d7e622c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4160 Subject: [dpdk-dev] [PATCH v2 13/13] doc: add new Windows offloads to the release note X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Added the new Windows supported offload to the 21.11 release note. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- doc/guides/rel_notes/release_21_11.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index dfc2cbdeed..f2368dd2af 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -130,6 +130,10 @@ New Features * Added tests to validate packets hard expiry. * Added tests to verify tunnel header verification in IPsec inbound. +* **Updated Mellanox mlx5 driver.** + + * Added NIC offloads for the PMD on Windows (TSO, VLAN strip, Keep CRC). + Removed Items -------------