From patchwork Fri Oct 12 23:42:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 46777 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC6131B195; Sat, 13 Oct 2018 01:43:04 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 12B651B147 for ; Sat, 13 Oct 2018 01:43:01 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id q19-v6so3521588pll.5 for ; Fri, 12 Oct 2018 16:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MLEyeyrNf4JfQZytJ0J+nctjGFYYOUIfbNgjYhuFECY=; b=Mpck8WSOKZMYYswrXJvL7pj8QMs9yqL3o/kzX4Qpj+u16Bj/1YbYgTLKdBtBu5tIyb rcN/tvmdKTBewK7jet17b96pzfon4l6C8hvPZZzu6zuGjx9CvS4pvW4a9aQOapWNhROJ Sj8ZIsRk8YIXniydfEl+zKbJ5BRRUbXalMjKpeno3LvoH697Bf54oLWjMRUrYrUQIR9/ pAxqeaJSrXj5UzG9vwcA00IG12UviquBqUrJ3zzdMzrcTeinI/QdPDK92+wxXtpJo5tU ljVowBP2EpAR/y3MOHCpw41kUgr7UeyjF10T7i5zElzrslBxlopugVqH5ADfBQPN+3ju OfdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MLEyeyrNf4JfQZytJ0J+nctjGFYYOUIfbNgjYhuFECY=; b=VygQV78mvH0c+5Xs7OcU3RV8/qta7U5Vn3ypbrGG/aZsvBMGQQ9xw7pzreFdb7GiKM X+rLskoyE95tHszeZkEt/kh2Z7LEPPPtmNXuK46oKV6hc92IixQoMUf7spkXefUaa4O4 a8TNnJEaetcV0wCO6ilY8k3XmjBplPVodgQPnaUjr0CBmmdild5yPnAX2LfGGNj8YJgG 6YLL3zDIb5rh21JTEeNyh+IAT7Hnn/7cKRVaG7Tl9jEFWPaYGnbFlv7psHAoilxE2Dt7 e+ZUOBtagkkZggekw5gaLiHsWtDkySc+OK5eYmqinNccMRSDIGzivGWfYbE7GEC5gK9j peNQ== X-Gm-Message-State: ABuFfoitDAYaUVHGdXrW0QCYasOwPOphCe0+ogCpHpaS11mQHfKFoUkg AuOddJ6J1umD8VYbY244ZBB/e6e5oiw= X-Google-Smtp-Source: ACcGV60kP0Jtf+xvKRquzGmh4CiC7trY0EF6HvKFZ5ATkFnlC8QhNuW/MYF6GtVv13V3kQBuiDArSw== X-Received: by 2002:a17:902:29e3:: with SMTP id h90-v6mr7853115plb.215.1539387780716; Fri, 12 Oct 2018 16:43:00 -0700 (PDT) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q76-v6sm7099938pfa.18.2018.10.12.16.42.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 16:43:00 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 12 Oct 2018 16:42:50 -0700 Message-Id: <20181012234252.29049-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181012234252.29049-1-stephen@networkplumber.org> References: <20181012234252.29049-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/3] doc: remove INIT_DEBUG from ena X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ena driver has used dynamic log type to enable init debugging since 18.05 but the documentation still has leftover mention of the config option. Signed-off-by: Stephen Hemminger --- doc/guides/nics/ena.rst | 4 ---- 1 file changed, 4 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 695960d4c9f8..34c48575bf71 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -113,10 +113,6 @@ Configuration information * **CONFIG_RTE_LIBRTE_ENA_PMD** (default y): Enables or disables inclusion of the ENA PMD driver in the DPDK compilation. - - * **CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT** (default y): Enables or disables debug - logging of device initialization within the ENA PMD driver. - * **CONFIG_RTE_LIBRTE_ENA_DEBUG_RX** (default n): Enables or disables debug logging of RX logic within the ENA PMD driver. From patchwork Fri Oct 12 23:42:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 46779 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 420801B3DA; Sat, 13 Oct 2018 01:43:08 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by dpdk.org (Postfix) with ESMTP id B96E31B177 for ; Sat, 13 Oct 2018 01:43:03 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id y18-v6so6535941pge.0 for ; Fri, 12 Oct 2018 16:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ID9CQRCiCoqsyCsO71eGZp9FwCo12GbVY1ICOpBOLs=; b=PwssQbRaHQncG0U4WK5eZ1xfD90OlJxCTKJa8IYH9tCFTBuhP7C8F/tYzO8jMkCWVM Tr0j/ecRskeUs2cWSp/eygxEIrM3GUii9Xc7nPoDpPD819rDjGu2ILUVV6q75pwj4Op5 bZ9tZgMEgcntsKmDr+HglMQZvdR5Pnr47AEekp8UGlRWpkv7IqNMKHYdTpeTLLgzpiYS iaxlGMcK8kGXJOQNFMOn65blleaCzv+tBT6tEQeht5yt3akWSc1pLluqRjSPcQ90pCmH trYtFdWPDf3RwO4skGnsXrOI2jwNuaS6VPjY/Dt1k4Rh5CzFel8etG5LvWwipgfA5Bmp gxaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ID9CQRCiCoqsyCsO71eGZp9FwCo12GbVY1ICOpBOLs=; b=b5xGNV18BuiTfoBjPp0gAV8be1zaqK0EDW9cns0BPJqWYR1400sE4xbxhgtuecmRB0 fXIK8SETfAwFcOzSMme842h0rkgx5Ial6ijKdDX7VOGv9E8uAlCEdBhLBPiFEBbqXQoa HZwxXNOAxi9bPPZ1y5z6zN2uwEHFMCmnIYXbPqP7L5VblDPf6Nd0jyXjQZm4bHbeRAd/ TK16OsSI4uoLSDR7YRKGF1VUTvv4JQeycE+TwWnrN0rRYde0hBbVq7rP4VD996ruEUmr GpV8ELgwmmb+JseaaShX9GhUdT9G9zernlXbaetv+K4cCXWTC45+HMzhAxjHCT8pToKQ 8ofg== X-Gm-Message-State: ABuFfoi1pfNr2o15BE50QabwjApBYjJ45z/PUQcoVa2/5BQPyqFgsb7L VnDQjXvjhCBPyeLA/PAkKWxzxMjwsVA= X-Google-Smtp-Source: ACcGV63VyUo5v1E7r0Y5MsWs7r7hT34Wiehe9aXIeoljPe8DwF9UZTeKjI7QqI81aU5bUmgMmdwZEw== X-Received: by 2002:a63:3308:: with SMTP id z8-v6mr7280754pgz.220.1539387782303; Fri, 12 Oct 2018 16:43:02 -0700 (PDT) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q76-v6sm7099938pfa.18.2018.10.12.16.43.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 16:43:01 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 12 Oct 2018 16:42:51 -0700 Message-Id: <20181012234252.29049-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181012234252.29049-1-stephen@networkplumber.org> References: <20181012234252.29049-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/3] doc: liquidio remove documentation for old config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The config options for init and debug driver were replaced by dynamic log levels. Signed-off-by: Stephen Hemminger --- doc/guides/nics/liquidio.rst | 8 -------- 1 file changed, 8 deletions(-) diff --git a/doc/guides/nics/liquidio.rst b/doc/guides/nics/liquidio.rst index 87b42cdc4835..e2a38004d0d6 100644 --- a/doc/guides/nics/liquidio.rst +++ b/doc/guides/nics/liquidio.rst @@ -30,14 +30,6 @@ Please note that enabling debugging options may affect system performance. Toggle compilation of LiquidIO PMD. -- ``CONFIG_RTE_LIBRTE_LIO_DEBUG_DRIVER`` (default ``n``) - - Toggle display of generic debugging messages. - -- ``CONFIG_RTE_LIBRTE_LIO_DEBUG_INIT`` (default ``n``) - - Toggle display of initialization related messages. - - ``CONFIG_RTE_LIBRTE_LIO_DEBUG_RX`` (default ``n``) Toggle display of receive fast path run-time messages. From patchwork Fri Oct 12 23:42:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 46780 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 165A91B3FD; Sat, 13 Oct 2018 01:43:10 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 8A71B1B17E for ; Sat, 13 Oct 2018 01:43:04 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id p24-v6so6910014pff.10 for ; Fri, 12 Oct 2018 16:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RjRnEkNk6CC/EUTVBxwdJeLEdKN48L6xVBkeJioxMGw=; b=dnkoM3lt10TOumypvZ0Utnc/o+XLbwJ83mCVlxFYbX97pw484ns268+SXLmJqTshne Db0HA4J9rybXPY99ldqb+wxTOiQS71kng8rMH9w6Aw0PBkXox2DSnuXj6AhgOeN3G7kH dcFVhAGj5ID49WxRODUaoHsTC/PNqnbPam6B/jewL8vk9+gPzBpOP2akc74qbqB+TBh9 l/Y454orIaTXxyYQW88ibe07DIxgrklANSXOrFPVaQvyxseTGiKb8Y/oZ47iapLf/59F anaQnwqZiKnkX0hHaWP/S+l34SRVDARYMnpIDkn1ISnl4Z7SC7h2VBmNdneiWxMsRwK6 qzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RjRnEkNk6CC/EUTVBxwdJeLEdKN48L6xVBkeJioxMGw=; b=mr07om8X5tLWChdtJV3mvrMSARyrKt/0pUZl9WbofAO/N2X7Mn8b2GVU0nNuMRWc7n fz0pvXrZ1BDTxwlNWwEKgc45kbeSB5Uv0aNArl/FA8fToTyue4E/D9aDdffjXfDbigMQ Xrote/D6naPJAXWhpEYVgYNUcJBbnyxgrx+Jj3SVNIIx4vGx/9CfcxV79BCpa+YImBiG GHTZHhrW4IklRjZPINZGuH0aJ7+XL0obxWBVSbHejKuie62RQOGbuCGEa1MmVxC+QBwC ioEcjzueM6zaOKMOmysbraCuudpxy9PiiozRkd20O2uK0LT+X99IwSyQYiW7sdVTYcfn 5pxA== X-Gm-Message-State: ABuFfojEE5QWIkBmL6+vhQLQp9maI64ovExikbvoEpPYZlgNbQpRTDia fdWEp29NwC1hqOAyKFGWjl6BN5AppK8= X-Google-Smtp-Source: ACcGV6323OExwnovEtq3n0rql0hgk4SWyi6xCIkw+qOQTHs2bsq1Ylp4x3+CZiYAxgHWh0Ejt2F6NQ== X-Received: by 2002:a63:ea07:: with SMTP id c7-v6mr6964926pgi.361.1539387783232; Fri, 12 Oct 2018 16:43:03 -0700 (PDT) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q76-v6sm7099938pfa.18.2018.10.12.16.43.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 16:43:02 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 12 Oct 2018 16:42:52 -0700 Message-Id: <20181012234252.29049-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181012234252.29049-1-stephen@networkplumber.org> References: <20181012234252.29049-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] qede: remove #ifdef for INIT_DEBUG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that logging of initialization is controlled by dynamic debug level, remove the #ifdef for RTE_LIBRTE_QEDE_DEBUG_INIT since that config option does not exist in common_base and is not documented. Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_ethdev.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 18d244a9367c..5745832b98a3 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1380,14 +1380,11 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete) static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev) { -#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT struct qede_dev *qdev = eth_dev->data->dev_private; struct ecore_dev *edev = &qdev->edev; + enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC; PMD_INIT_FUNC_TRACE(edev); -#endif - - enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC; if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1) type |= QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; @@ -1397,12 +1394,10 @@ static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev) static void qede_promiscuous_disable(struct rte_eth_dev *eth_dev) { -#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT struct qede_dev *qdev = eth_dev->data->dev_private; struct ecore_dev *edev = &qdev->edev; PMD_INIT_FUNC_TRACE(edev); -#endif if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1) qed_configure_filter_rx_mode(eth_dev, @@ -2648,12 +2643,10 @@ static int qede_eth_dev_init(struct rte_eth_dev *eth_dev) static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev) { -#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT struct qede_dev *qdev = eth_dev->data->dev_private; struct ecore_dev *edev = &qdev->edev; PMD_INIT_FUNC_TRACE(edev); -#endif /* only uninitialize in the primary process */ if (rte_eal_process_type() != RTE_PROC_PRIMARY)