From patchwork Thu Oct 11 14:51:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 46636 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DCEA1B595; Thu, 11 Oct 2018 16:51:21 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1F3CA1B547; Thu, 11 Oct 2018 16:51:20 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 0CEB6B4007F; Thu, 11 Oct 2018 14:51:19 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Oct 2018 07:51:16 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 11 Oct 2018 07:51:16 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w9BEpEl4018553; Thu, 11 Oct 2018 15:51:14 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9013E1616EF; Thu, 11 Oct 2018 15:51:14 +0100 (BST) From: Andrew Rybchenko To: CC: Ivan Malov , Date: Thu, 11 Oct 2018 15:51:12 +0100 Message-ID: <1539269473-21739-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24148.005 X-TM-AS-Result: No-2.863900-4.000000-10 X-TMASE-MatchedRID: xDToTJ4Kd/l3daUeCOH6HRHuQ9dDJbS2ETae8Q/uL1HxxaAXDrCns2q5 xdhoCAX9vr8j/+4r28yqLOntCp/PAU/qpx4DtjGJHcQQBuf4ZFtK4f4Z+CZAZ1pbYq2f4jz+Vej /gFdIvS1Pt+xmgMK7fJRNDYlhDNjb0u5x0DU4ekFH+PTjR9EWkrbIBPlG+6fSgiL/QhKEhDijxY yRBa/qJcFwgTvxipFajoczmuoPCq2TuAhkrGey/reU8XyOtf6mi6vmAueihA+/4lV5qdVBPjwwM BOQFiggElSW2upr6cohhq40vYItvLj46x2wSBDgVdfj0EDmax+F15h6/oibNbKsWJ44GuEGPNxa u39/BitFwHZmk+dWMmhnUCrcDtVn X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.863900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24148.005 X-MDID: 1539269479-20xIURNPB3HD Subject: [dpdk-dev] [PATCH 1/2] net/sfc: allow to query RSS key and HF in isolated mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ivan Malov Isolated mode prevents global RSS from being enabled and configured. However, an application may need to query default RSS key and hash functions when a flow rule with RSS action is added which does not contain custom RSS key or hash function choice. In this case global RSS key and hash functions will be used to handle the rule, and there should be some way for the application to query these global default settings to clarify expectations on the traffic distribution. Fixes: 84a9b48128c1 ("net/sfc: support flow API isolated mode") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 93bfecc4e..00f088013 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1354,9 +1354,8 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, { struct sfc_adapter *sa = dev->data->dev_private; struct sfc_rss *rss = &sa->rss; - struct sfc_port *port = &sa->port; - if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || port->isolated) + if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) return -ENOTSUP; if (rss->channels == 0) From patchwork Thu Oct 11 14:51:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 46637 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB3301B5B7; Thu, 11 Oct 2018 16:51:24 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7162A1B574; Thu, 11 Oct 2018 16:51:20 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 375BAB4006F; Thu, 11 Oct 2018 14:51:19 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Oct 2018 07:51:16 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 11 Oct 2018 07:51:16 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w9BEpErE018556; Thu, 11 Oct 2018 15:51:14 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9EF401616F0; Thu, 11 Oct 2018 15:51:14 +0100 (BST) From: Andrew Rybchenko To: CC: Ivan Malov , Date: Thu, 11 Oct 2018 15:51:13 +0100 Message-ID: <1539269473-21739-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1539269473-21739-1-git-send-email-arybchenko@solarflare.com> References: <1539269473-21739-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24148.005 X-TM-AS-Result: Yes-5.218900-4.000000-11 X-TMASE-MatchedRID: GUpzN83LG3hF/TNFimjSuMAmcZEx8XHJ1KoSW5Ji1XvxxaAXDrCns/G3 99+Ui/td5ClDmDzXYwvy/spf2Nj76EILcl5xUj1WtOGPzYU8VIKBHKTJ+sfXGY1Oeo4wEgnhU8S +/fFbuZOCxS3MiMgVuffJcVgFkoiei2/jyLqyhF0D2WXLXdz+AUqAhuLHn5fEZ0IzKseMTeffPZ 9FevqYPeLzNWBegCW2wgn7iDBesS15zdAzex5xZiJLa8ibf/QxWbTXja20kDKW6mIEnzpiYwusc U1ADvjvSg2BtOzguHco9Dvh0+Lg9mZq06/S/4hztR+HnVnymy5/0MhF+ZfDUA== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 11-5.218900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24148.005 X-MDID: 1539269479-qOecEGxllY3y Subject: [dpdk-dev] [PATCH 2/2] net/sfc: allow to query RSS key and HF when RSS is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ivan Malov If global RSS is not enabled in the multiqueue mode setting, it will not be possible to change RSS configuration. However, querying default RSS settings should be possible in any case since it may be needed by RTE flow API users to find out what RSS settings will be used by default for a flow rule with RSS action if custom RSS key and hash function choice are not specified. Fixes: 63ab5e0c8fda ("net/sfc: use zero RSS channels as disabled RSS indicator") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 00f088013..b2e17f26e 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1358,9 +1358,6 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) return -ENOTSUP; - if (rss->channels == 0) - return -EINVAL; - sfc_adapter_lock(sa); /*