From patchwork Mon Aug 2 19:57:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 96567 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FEA3A0A0C; Mon, 2 Aug 2021 21:57:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF8604117A; Mon, 2 Aug 2021 21:57:31 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 2950D41147 for ; Mon, 2 Aug 2021 21:57:31 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id E37B97F6C4; Mon, 2 Aug 2021 22:57:30 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 3F2957F51A; Mon, 2 Aug 2021 22:57:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3F2957F51A Authentication-Results: shelob.oktetlabs.ru/3F2957F51A; dkim=none; dkim-atps=neutral From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit , Ori Kam Cc: dev@dpdk.org, Eli Britstein , Ilya Maximets , Ajit Khaparde , Matan Azrad , Ivan Malov , Viacheslav Galaktionov Date: Mon, 2 Aug 2021 22:57:22 +0300 Message-Id: <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> References: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. However some drivers implement it in a different way and direct traffic to the opposite end of the "wire" plugged to the given ethdev. For example in the case of a VF representor traffic is redirected to the corresponding VF itself rather than to the representor ethdev and OvS uses PORT_ID action this way. The documentation must be clarified and, likely, rte_flow_action_port_id structure should be extended to support both meanings. Signed-off-by: Andrew Rybchenko Acked-by: Ori Kam Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index d9c0e65921..6e6413c89f 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -158,3 +158,8 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. + +* ethdev: Definition of the flow API action PORT_ID is ambiguous and needs + clarification. Structure rte_flow_action_port_id will be extended to + specify traffic direction to represented entity or ethdev port itself in + DPDK 21.11. From patchwork Mon Aug 2 19:57:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 96568 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22B7DA0A0C; Mon, 2 Aug 2021 21:57:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4007341187; Mon, 2 Aug 2021 21:57:39 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 7A12F41186 for ; Mon, 2 Aug 2021 21:57:38 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id 3B9707F6C4; Mon, 2 Aug 2021 22:57:38 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 5E0117F578; Mon, 2 Aug 2021 22:57:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5E0117F578 Authentication-Results: shelob.oktetlabs.ru/5E0117F578; dkim=none; dkim-atps=neutral From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit , Ori Kam Cc: dev@dpdk.org, Eli Britstein , Ilya Maximets , Ajit Khaparde , Matan Azrad , Ivan Malov , Viacheslav Galaktionov Date: Mon, 2 Aug 2021 22:57:23 +0300 Message-Id: <20210802195723.2153114-2-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> References: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Transfer flow rules may be applied to traffic entering switch from many sources. There are flow API pattern items which allow to specify ingress port match criteria explicitly, but it is not documented if ethdev port used to create flow rule adds any implicit match criteria and how it coexists with explicit ones. These aspects should be documented and drivers and applications which use it in a a different way must be fixed. Signed-off-by: Andrew Rybchenko Acked-by: Ori Kam Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 6e6413c89f..4d174c8952 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -163,3 +163,8 @@ Deprecation Notices clarification. Structure rte_flow_action_port_id will be extended to specify traffic direction to represented entity or ethdev port itself in DPDK 21.11. + +* ethdev: Flow API documentation is unclear if ethdev port used to create + a flow rule adds any implicit match criteria in the case of transfer rules. + The semantics will be clarified in DPDK 21.11 and it will require fixes in + drivers and applications which interpret it in a different way.