From patchwork Wed Oct 10 07:51:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 46463 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EA451B478; Wed, 10 Oct 2018 09:51:56 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8AD781B452 for ; Wed, 10 Oct 2018 09:51:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 65DBA8005E; Wed, 10 Oct 2018 07:51:50 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 00:51:47 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Wed, 10 Oct 2018 00:51:47 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w9A7pjnE025405; Wed, 10 Oct 2018 08:51:45 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 8F3F11626D2; Wed, 10 Oct 2018 08:51:45 +0100 (BST) From: Andrew Rybchenko To: CC: Thomas Monjalon , Date: Wed, 10 Oct 2018 08:51:38 +0100 Message-ID: <1539157900-6208-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24146.005 X-TM-AS-Result: No-0.500500-4.000000-10 X-TMASE-MatchedRID: IJfQKf6xjE7XldNKzKPlvTPDkSOzeDWW3g3xD6V0LtT7SBmDTxVcWk/O fkh/+AL4hUHepIxgktgTzo/7p2GUyF7FwpET+YHongIgpj8eDcAZ1CdBJOsoY9mzcdRxL+xwKra uXd3MZDUoWeJacQYjEf/WdjrOm7qEUGjF6bp/KKMgnoTiC/yJzwo/X31uF/dnEGRgub5jLjjQZa aNgpuQy1TylDZozaXsAzUZfRS5VJdGkBjbMbD9rzigZBQJvBjlD6DuZ3COjrnoW0NkKZgEnW3Lg NyHejuiQwymtxuJ6y0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.500500-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24146.005 X-MDID: 1539157911-sZJwr4e5TtfW Subject: [dpdk-dev] [RFC PATCH 1/3] ethdev: advertise MTU as retained across device stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Changing MTU in running state may return -EBUSY saying that MTU cannot be changed when the port is running. It assumes that changes may be done in stopped and started (but some PMDs may reject it) state and it is logical to require that changes done in any of these states are retained. Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 8dd1799e2..efe223b61 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -80,6 +80,7 @@ * rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will * be retained: * + * - MTU * - flow control settings * - receive mode configuration (promiscuous mode, hardware checksum mode, * RSS/VMDQ settings etc.) From patchwork Wed Oct 10 07:51:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 46461 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC1531B465; Wed, 10 Oct 2018 09:51:52 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 27A461B452 for ; Wed, 10 Oct 2018 09:51:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 11AFC80062; Wed, 10 Oct 2018 07:51:50 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 00:51:47 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Wed, 10 Oct 2018 00:51:47 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w9A7pjV6025406; Wed, 10 Oct 2018 08:51:45 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9899F1626D3; Wed, 10 Oct 2018 08:51:45 +0100 (BST) From: Andrew Rybchenko To: CC: Thomas Monjalon , Date: Wed, 10 Oct 2018 08:51:39 +0100 Message-ID: <1539157900-6208-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24146.005 X-TM-AS-Result: No-10.363800-4.000000-10 X-TMASE-MatchedRID: kII+BsKkYBAtg1fUv6/cnsf52VD5rJyZU+A7YkpDJ1hPgJpuGFm9djLk 8G2qhCWTXfUIozyICkW761Rb2kt6b0QVckjz5U5ekVUMyVUKRZ4wyvga40dfWsFKCo95h/aQ8rM P48ANS13i8zVgXoAltsYlDcGKIsCCC24oEZ6SpSkj80Za3RRg8AULHC+Ptywgf0ZMybmq+HxnYB MyuAnwY/AM50xaDaFVJuUoCN+T2k4= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.363800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24146.005 X-MDID: 1539157910-8d1jkRVGo61T Subject: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The documentation says MAC addresses array is retained and it is logical to assume that default MAC address is retained as well. Also some PMDs do not allow to change the default MAC in running state (see RTE_ETH_DEV_NOLIVE_MAC_ADDR). Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index efe223b61..94f7cd141 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -85,6 +85,7 @@ * - receive mode configuration (promiscuous mode, hardware checksum mode, * RSS/VMDQ settings etc.) * - VLAN filtering configuration + * - default MAC address * - MAC addresses supplied to MAC address array * - flow director filtering mode (but not filtering rules) * - NIC queue statistics mappings From patchwork Wed Oct 10 07:51:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 46462 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 94D441B470; Wed, 10 Oct 2018 09:51:54 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 5D2EF1B465 for ; Wed, 10 Oct 2018 09:51:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 3BE7680062; Wed, 10 Oct 2018 07:51:50 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 00:51:47 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Wed, 10 Oct 2018 00:51:47 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w9A7pjRU025409; Wed, 10 Oct 2018 08:51:45 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id A6E401626D4; Wed, 10 Oct 2018 08:51:45 +0100 (BST) From: Andrew Rybchenko To: CC: Thomas Monjalon , Date: Wed, 10 Oct 2018 08:51:40 +0100 Message-ID: <1539157900-6208-4-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24146.005 X-TM-AS-Result: No-2.088300-4.000000-10 X-TMASE-MatchedRID: Wv0/mEfewaFEFXJI8+VOXgPZZctd3P4B4wQlYP0sRm8uqIEAvQJhMZ4S u3+FxtJm4vM1YF6AJbbGJQ3BiiLAggtuKBGekqUpm+MB6kaZ2g7lgSolsDaoMYFLUJmh/zryoHR s02/mkTOC50dCAfpTCQ1Cfr1AciBTNTzEpVQOSYBf1Yn2DDIIyherkTrwUmgffh/WzFbdYrPkA8 OrYHdwDGfYlY/yoV/0Up6EHOb2+c7kHZDO53QSwjflzkGcoK72 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.088300-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24146.005 X-MDID: 1539157910-xj44yU22LDpx Subject: [dpdk-dev] [RFC PATCH 3/3] ethdev: highlight that all-multicast is retained on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All-multicast is a part of receive mode configuration and it is better to mention explicitly that it is retained across restart. Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 94f7cd141..b98c74785 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -82,8 +82,8 @@ * * - MTU * - flow control settings - * - receive mode configuration (promiscuous mode, hardware checksum mode, - * RSS/VMDQ settings etc.) + * - receive mode configuration (promiscuous mode, all-multicast mode, + * hardware checksum mode, RSS/VMDQ settings etc.) * - VLAN filtering configuration * - default MAC address * - MAC addresses supplied to MAC address array