From patchwork Wed Jul 21 15:55:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Havl=C3=ADk_Martin?= X-Patchwork-Id: 96174 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04362A0C51; Wed, 21 Jul 2021 17:56:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE38140696; Wed, 21 Jul 2021 17:56:09 +0200 (CEST) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14]) by mails.dpdk.org (Postfix) with ESMTP id 6F8694014D for ; Wed, 21 Jul 2021 17:56:08 +0200 (CEST) Received: from dpdk-test7.liberouter.org ([IPv6:2001:718:800:ff00:2eea:7fff:fef8:8792]) (authenticated bits=0) by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 16LFtxsD081871 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 21 Jul 2021 17:56:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz; s=studfit; t=1626882964; bh=i2R2jLpZvXsBZwtl3bB8XGTswYQRgw4aHP4G9UdTH80=; h=From:To:Cc:Subject:Date; b=pZYFOv5nbT+zd2RroCy+1WnX3T3f49HWwRG0kiQvBe/JZ6OPbfEhwd3A3+AGPFEB5 dDv5bSx9R1pe7dp/0btahqQ/CGLULHKEaD+1vcXB1zlQrA8ryAUyfJ2rxRPNpknjhw LS0JWENHjtvYLEATcDKKMxAaKsXxaNBvtoi64mpc= From: Martin Havlik To: xhavli56@stud.fit.vutbr.cz, Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Thomas Monjalon , Asaf Penso , Jiawei Wang , Bing Zhao , Xueming Li , Tal Shnaiderman , Shun Hao , Ciara Power , Bruce Richardson , Michael Baum , Raslan Darawsheh Cc: dev@dpdk.org, Jan Viktorin Date: Wed, 21 Jul 2021 17:55:47 +0200 Message-Id: <20210721155550.188663-2-xhavli56@stud.fit.vutbr.cz> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] doc: clarify RTE flow behaviour on port stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It is now clearly stated that RTE flow rules can be created only after the port is started. Signed-off-by: Martin Havlik --- doc/guides/nics/mlx5.rst | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f5b727c1ee..119d537adf 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -1790,21 +1790,25 @@ Notes for rte_flow ------------------ Flows are not cached in the driver. When stopping a device port, all the flows created on this port from the application will be flushed automatically in the background. After stopping the device port, all flows on this port become invalid and not represented in the system. All references to these flows held by the application should be discarded directly but neither destroyed nor flushed. -The application should re-create the flows as required after the port restart. +The application should re-create the flows as required after the port is +started again. + +Creating flows before port start is not permitted. All flows the application +wants to create have to be created after the port is started. Notes for testpmd ----------------- Compared to librte_net_mlx4 that implements a single RSS configuration per port, librte_net_mlx5 supports per-protocol RSS configuration. Since ``testpmd`` defaults to IP RSS mode and there is currently no command-line parameter to enable additional protocols (UDP and TCP as well as IP), the following commands must be entered from its CLI to get the same From patchwork Wed Jul 21 15:58:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Havl=C3=ADk_Martin?= X-Patchwork-Id: 96175 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7167BA0C51; Wed, 21 Jul 2021 17:58:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C6CE4014D; Wed, 21 Jul 2021 17:58:41 +0200 (CEST) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14]) by mails.dpdk.org (Postfix) with ESMTP id E1D1640143 for ; Wed, 21 Jul 2021 17:58:39 +0200 (CEST) Received: from dpdk-test7.liberouter.org ([IPv6:2001:718:800:ff00:2eea:7fff:fef8:8792]) (authenticated bits=0) by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 16LFwVas082162 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 21 Jul 2021 17:58:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz; s=studfit; t=1626883116; bh=f9F/sXVTn2wNQijIwBM1ViVvSN6slMXTevrhcbpmMho=; h=From:To:Cc:Subject:Date; b=HXk7DwiLGonWwBWt/pJp5QTMbPQ5YXo1fdYr1ddWaqbX8jqs1QkKXTdKi8vxLaSTG fveRI6Z4JihmPp5ybb8jWWm4eukXSDWdofoh8swqfS1V2cERPKKK9DPJ5KfI832HQD bfwQVZxak9dndlFXMOqovyRXTtemdxaUFvmDsPkc= From: Martin Havlik To: xhavli56@stud.fit.vutbr.cz, Ori Kam , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko , Ferruh Yigit , Dekel Peled , Bing Zhao , Gregory Etelson , Eli Britstein , Alexander Kozyrev Cc: dev@dpdk.org, Jan Viktorin Date: Wed, 21 Jul 2021 17:58:14 +0200 Message-Id: <20210721155816.188795-3-xhavli56@stud.fit.vutbr.cz> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/4] doc: specify RTE flow create behaviour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ability to create RTE flow rules, depending on port status, can and does differ between PMDs. Now the doc reflects that. Signed-off-by: Martin Havlik --- doc/guides/prog_guide/rte_flow.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 2b42d5ec8c..2988e3328a 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -3097,6 +3097,10 @@ actually created and a handle returned. const struct rte_flow_action *actions[], struct rte_flow_error *error); +The ability to create a flow rule may depend on the status (started/stopped) +of the port for which the rule is being created. This behaviour is +PMD specific. Seek relevant PMD documentation for details. + Arguments: - ``port_id``: port identifier of Ethernet device. From patchwork Wed Jul 21 15:58:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Havl=C3=ADk_Martin?= X-Patchwork-Id: 96176 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98C0AA0C51; Wed, 21 Jul 2021 17:58:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88AC540696; Wed, 21 Jul 2021 17:58:53 +0200 (CEST) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14]) by mails.dpdk.org (Postfix) with ESMTP id 839724014E for ; Wed, 21 Jul 2021 17:58:51 +0200 (CEST) Received: from dpdk-test7.liberouter.org ([IPv6:2001:718:800:ff00:2eea:7fff:fef8:8792]) (authenticated bits=0) by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 16LFwVat082162 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 21 Jul 2021 17:58:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz; s=studfit; t=1626883121; bh=qxUShGWhH1t/xjRG7Y2dtxqWSKcOHA3N5fCc2ll5k2I=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nEvFli3d9BzujfsTJMZ6dj7MoWwQ3rSE0KnsYcCJmycK2EdrhNM/Fp+OWLyXnH+FN QwxAq7is+n0ne4i6bEGpnlYLvBeemIWyKOkX7dM++bcuQO8LEV2P31dhVi6fGusyay LsgBmDytoqyHes860feO/5Uj3s0YTSkdK/2vIUn4= From: Martin Havlik To: xhavli56@stud.fit.vutbr.cz, Chas Williams , "Min Hu (Connor)" , Ciara Power , Ajit Khaparde , Rosen Xu , Bruce Richardson Cc: dev@dpdk.org, Jan Viktorin Date: Wed, 21 Jul 2021 17:58:15 +0200 Message-Id: <20210721155816.188795-4-xhavli56@stud.fit.vutbr.cz> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210721155816.188795-3-xhavli56@stud.fit.vutbr.cz> References: <20210721155816.188795-3-xhavli56@stud.fit.vutbr.cz> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/4] doc: update bonding mode 8023ad info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Included info on dedicated queues and added related note about issue on mlx5. Signed-off-by: Martin Havlik Acked-by: Min Hu (Connor) --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst b/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst index 30c56cd375..19c65f314c 100644 --- a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst +++ b/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst @@ -116,10 +116,18 @@ Currently the Link Bonding PMD library supports following modes of operation: #. Calls to ``rte_eth_tx_burst`` must have a buffer size of at least 2xN, where N is the number of slaves. This is a space required for LACP frames. Additionally LACP packets are included in the statistics, but they are not returned to the application. + This mode also supports enabling dedicated rx and tx queues for handling + LACP frames separately from fast application path, resulting in + a potential performance improvement. + +.. note:: + Currently mlx5 doesn't work with enabled dedicated queues due to + an issue with RTE flow rule creation prior to port start. + * **Transmit Load Balancing (Mode 5):** .. figure:: img/bond-mode-5.* Transmit Load Balancing (Mode 5) From patchwork Wed Jul 21 15:59:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Havl=C3=ADk_Martin?= X-Patchwork-Id: 96177 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAA34A0C51; Wed, 21 Jul 2021 17:59:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C74404014D; Wed, 21 Jul 2021 17:59:45 +0200 (CEST) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14]) by mails.dpdk.org (Postfix) with ESMTP id D95B340143 for ; Wed, 21 Jul 2021 17:59:43 +0200 (CEST) Received: from dpdk-test7.liberouter.org ([IPv6:2001:718:800:ff00:2eea:7fff:fef8:8792]) (authenticated bits=0) by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 16LFxZwY082261 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 21 Jul 2021 17:59:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz; s=studfit; t=1626883179; bh=Gt57jOXK1GJucZElbtK5lYwGB+HFVRwDl917CjirDDM=; h=From:To:Cc:Subject:Date; b=tc++2e17PbjjsF+CXaKWiQ99JHWdO2xN640K1IDAd14ozILiCKYn7Iu40H0EB4sJ5 B9dM6I/SBvS8+78opDIByO/ylu7780keIZsEB4oJetcwg98y7OVqiGaBwDBUEsVTvi PoTy61ZzD/OwGcwDQQ9SVjllqdF6A72VExjp+tHU= From: Martin Havlik To: xhavli56@stud.fit.vutbr.cz, Xiaoyun Li , Ferruh Yigit , Andrew Rybchenko , Ajit Khaparde , Haiyue Wang , Ori Kam , Haifei Luo , Viacheslav Ovsiienko , Andrey Vesnovaty , Bing Zhao , Jiawei Wang , Gregory Etelson , Li Zhang Cc: dev@dpdk.org, Jan Viktorin Date: Wed, 21 Jul 2021 17:59:18 +0200 Message-Id: <20210721155918.188867-5-xhavli56@stud.fit.vutbr.cz> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In bonding mode 4 (8023ad), dedicated queues are not working on mlx5 NICs. Signed-off-by: Martin Havlik --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 2c43719ad3..8a6edc2bad 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -2603,6 +2603,9 @@ when in mode 4 (link-aggregation-802.3ad):: testpmd> set bonding lacp dedicated_queues (port_id) (enable|disable) +.. note:: + Dedicated queues `do not currently work + `__ on mlx5 NICs. set bonding agg_mode ~~~~~~~~~~~~~~~~~~~~