From patchwork Wed May 19 03:27:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 93313 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CFFA0A0A; Wed, 19 May 2021 05:28:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 215CE40143; Wed, 19 May 2021 05:28:53 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 41AD640041 for ; Wed, 19 May 2021 05:28:51 +0200 (CEST) IronPort-SDR: RGzvaYtznSoybP7JoRv/EPQfdeDccpFenS7YzszQSlh/Nzmqh073eXjO3S5AOl52+sAIg/ufkY yzJMb8ZaBk2A== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="181159012" X-IronPort-AV: E=Sophos;i="5.82,311,1613462400"; d="scan'208";a="181159012" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 20:28:50 -0700 IronPort-SDR: oQjIYrdax1Nq1bjx8PIQj2NF9x10zNWZC44OnCczscb3fvyWI60oacbVDxsjlV+wQ30z1HA62h KqjhBWRFSQNw== X-IronPort-AV: E=Sophos;i="5.82,311,1613462400"; d="scan'208";a="439772851" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.194]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 20:28:48 -0700 From: Steve Yang To: dev@dpdk.org Cc: beilei.xing@intel.com, Steve Yang Date: Wed, 19 May 2021 03:27:45 +0000 Message-Id: <20210519032745.707639-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When user configured the flow rule with raw packet via command "flow_director_filter", it would reset all previous fdir input set flags with "i40e_flow_set_fdir_inset()". Ignore to configure the flow input set with raw packet rule used. Fixes: ff04964ea6d5 ("net/i40e: fix flow director for common pctypes") Signed-off-by: Steve Yang Acked-by: Beilei Xing --- drivers/net/i40e/i40e_fdir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index ac0e09bfdd..3c7cf1ba90 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1768,7 +1768,8 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev *dev, if (add) { /* configure the input set for common PCTYPEs*/ - if (!filter->input.flow_ext.customized_pctype) { + if (!filter->input.flow_ext.customized_pctype && + !filter->input.flow_ext.pkt_template) { ret = i40e_flow_set_fdir_inset(pf, pctype, filter->input.flow_ext.input_set); if (ret < 0)