From patchwork Wed May 12 02:30:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Cheng1" X-Patchwork-Id: 93174 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C09F2A0A0E; Wed, 12 May 2021 04:44:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61B8B410F6; Wed, 12 May 2021 04:44:43 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D5E674003E for ; Wed, 12 May 2021 04:44:41 +0200 (CEST) IronPort-SDR: Fgy0uTBV3R9abI27UMoEC6CA+I/WKWfbgHWNUXxRlOYfMcRDrPngSS91ILs6jg/e29V21X8Dyk hGFcbvM4fhdg== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="220569403" X-IronPort-AV: E=Sophos;i="5.82,292,1613462400"; d="scan'208";a="220569403" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 19:44:40 -0700 IronPort-SDR: RijuHAey9/DpPA+OXrcQoi6AYWcR8koixH/uZ4fJ5piiavYZui/tjJl79L1qT+d7Kt3D1YRzK+ 26qVLOQbpkyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,292,1613462400"; d="scan'208";a="434890755" Received: from dpdk_jiangcheng.sh.intel.com ([10.67.119.112]) by fmsmga008.fm.intel.com with ESMTP; 11 May 2021 19:44:30 -0700 From: Cheng Jiang To: maxime.coquelin@redhat.com, chenbo.xia@intel.com Cc: dev@dpdk.org, Cheng Jiang Date: Wed, 12 May 2021 02:30:41 +0000 Message-Id: <20210512023041.30507-1-cheng1.jiang@intel.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] vhost: fix unintended sign extension in async split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Change the variable type in store_dma_desc_info_split() to fix suspicious implicit sign extension. Coverity issue: 370604, 370607, 370609 Fixes: 3d6cb86b0de5 (vhost: refactor async split ring functions) Signed-off-by: Cheng Jiang Reviewed-by: Chenbo Xia --- lib/vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 8e36f4c340..9137a9923b 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -1474,7 +1474,7 @@ static __rte_always_inline void store_dma_desc_info_split(struct vring_used_elem *s_ring, struct vring_used_elem *d_ring, uint16_t ring_size, uint16_t s_idx, uint16_t d_idx, uint16_t count) { - uint16_t elem_size = sizeof(struct vring_used_elem); + size_t elem_size = sizeof(struct vring_used_elem); if (d_idx + count <= ring_size) { rte_memcpy(d_ring + d_idx, s_ring + s_idx, count * elem_size);