From patchwork Tue May 11 08:03:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 93148 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28557A0C41; Tue, 11 May 2021 10:03:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB43740140; Tue, 11 May 2021 10:03:51 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by mails.dpdk.org (Postfix) with ESMTP id C33E84003E; Tue, 11 May 2021 10:03:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUItUc/MIdEXbhdOPMQ1azltVE4R/MrODckNfBCieh5ApUzD0Zxi14km3Cb3Hl5zLM3Du2BOxzCQfsj3Jm7OZ3Go4U0IgFhVRiQAy4i3n3Idl7LEiCbDaVL3lUEZ/6rdIhJWKvSTLoTwsVxRwn3/d0MalSBMV8l+piD7P6HF/vL/lPtM8PlHiDa/p//szZsGgbj9JXwRDI2/whDwZqt112uUKJNvxkuZsgXegiEx4P24SX1BGqS6EXjC1a91so0MWD5V2n58Ka3j5f85fThu/vZ0iP/2g4XqAwvNQH8YCAXanwd+Vqx8QmUI7+pkVlKcZwUc/AzEIGr4XNIoob8DMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YvzW+qCsPdtqdC0Rmw5zgeNtRLB3jdHF0FYQeOiK/RE=; b=CZwT2UCufvAZ8Ow42eb2W0SfsCbOW+sqqAcoY7RzJRCTiwrgWL7s0XJt9MmTSleRGWipgxty2cPqOkqgxvfUuGY0iv82+Bz+/1LZaAjbZqJHiSjrtWu6tZICZ8IelwXi/jy2l+c6eto9IByo0HkAr338iY5Bcz1HYc4lmt3gVKCFuc7wZLvrQqLBEe2bem3saziZAyVuA8JZeIl5z2lcokOm9QkiklhYxLQJceCZiqHTXLVIkULBJIk/GaTYrjABftLgpfLYXcRfvvdoZ61lHClRufGFl/HVHms+DWRFoiUerpEmWh3V7UedrlqqGhxw6Pz9qxOCKKU1ucBJqRj1JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YvzW+qCsPdtqdC0Rmw5zgeNtRLB3jdHF0FYQeOiK/RE=; b=lEqj6uDhYpX8MiZifmpTKIHLY0AKymbUqPRobaySqPQl1+920/QPaxokI3phiFLPctVTdwJl3dKEkT6pVN5U1fXIemvwgrxQNaqFtOD73LlEsH0sUnc6HN12cTrgc+BapWr4A9CP1+Ph0IeKVQPvxg6iNBKUWrpg7ZC5fL7Sg53R3auqcAwIHoQwzMUk2BQx/JTpaeYLPQy6x8q6v2JBqHj09QGR9Y3PisHXGxoiMwx5486OeISbg5vTRNz3yIzzLz1LBsqrNZ79PNAhyqBkF+CFQ7WNIvl7/eO50v2bxxLrp67pIZ49m/2IdUwjwA8TxlGWlf3j8HgMALZqjPpQMw== Received: from BN9PR03CA0065.namprd03.prod.outlook.com (2603:10b6:408:fc::10) by DM5PR12MB1372.namprd12.prod.outlook.com (2603:10b6:3:77::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.30; Tue, 11 May 2021 08:03:48 +0000 Received: from BN8NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::28) by BN9PR03CA0065.outlook.office365.com (2603:10b6:408:fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 08:03:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT011.mail.protection.outlook.com (10.13.176.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 08:03:48 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 11 May 2021 08:03:45 +0000 From: Gregory Etelson To: CC: , , , , , , Viacheslav Ovsiienko , Xiaoyun Li Date: Tue, 11 May 2021 11:03:31 +0300 Message-ID: <20210511080331.13971-1-getelson@nvidia.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 719d35d6-c6ff-436c-2498-08d914534eae X-MS-TrafficTypeDiagnostic: DM5PR12MB1372: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TQJYNuVYtKl8CmhU96ea29Wq6fh7Sr9rkcBoA2Zs/hj8r2JBMi501DRWjK3QH2GneYl20HtjIhpwWSRMoKWFLUztXLqUFpbpNBLFnxjqPxV7FNl0AU5/VOuRwb49eGUBMth/UwwXpqREGjtHF9mDM6rSpngNDjuqeLie+bon82r9O2hUZEZgvBzt7XOAn3uMrwIWyy/AcbwpqlMPFx4mXv1v5iZjQaxTGOc9OA5MSI9xufy44cekccv86kOzBcbm8EcUnT940WVU7etJEWdJZBQaBQ25QJ2j1ezWgluhDcx7x/YKkB6XjjgkMqvqe6eX0tR1uryeaggtUJmta/1ZCVh2aVDEJSwlPraFpryxPKWHgqHMX4mDIgAUe4ZQUZoyAmV3yE0a+mH/7Idkzb9NxWFA4CqlbnHddyYL16plO8+sy5pZuHOTSIUoSmEReXiZbNw27HWkY5umq3uYvdPoByfwy5UMy2chyJDQ4MIp84kTWAYMqoqXuGvyxoxk1/E8GYRGTAcS44n6rrMtc3uJg+72tEoWPwSEWGmvGtisVaFGdXx5ssf7pBJzf4k7lpgGhyanhsmEikk60Sit0UUvrm3qivckdvvBqOHCTmHnrmxV2BOtc35zwT5ehpHGN9PakPFQbD3CHy5eEJu+kod1vaQCdzleIQWTHR0QVu1JxQg= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39850400004)(396003)(46966006)(36840700001)(6286002)(426003)(82310400003)(47076005)(55016002)(336012)(2616005)(8936002)(82740400003)(316002)(6666004)(7636003)(8676002)(356005)(86362001)(36906005)(83380400001)(7696005)(70206006)(70586007)(1076003)(5660300002)(186003)(16526019)(26005)(54906003)(2906002)(4326008)(6916009)(36756003)(36860700001)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 08:03:48.2703 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 719d35d6-c6ff-436c-2498-08d914534eae X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1372 Subject: [dpdk-dev] [PATCH] app/testpmd: fix tunnel offload flows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tunnel offload model requires application to obtain PMD related flow items or actions to construct a flow rule. These elements acquire internal PMD flow resources that must be explicitly released. The patch destroys tunnel offload PMD resources after flow creation failure. Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- app/test-pmd/config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 01a541cdd6..43c79b5021 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1940,6 +1940,9 @@ port_flow_create(portid_t port_id, memset(&error, 0x22, sizeof(error)); flow = rte_flow_create(port_id, attr, pattern, actions, &error); if (!flow) { + if (tunnel_ops->enabled) + port_flow_tunnel_offload_cmd_release(port_id, + tunnel_ops, pft); free(pf); return port_flow_complain(&error); }