From patchwork Fri Apr 23 21:04:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 92094 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02AA2A0548; Fri, 23 Apr 2021 23:04:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF385410E7; Fri, 23 Apr 2021 23:04:49 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id CCFF5410E5 for ; Fri, 23 Apr 2021 23:04:48 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id lr7so7591584pjb.2 for ; Fri, 23 Apr 2021 14:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jlV+5TxHk5f5zdJKEO2Yu7IxsfPBaKLdcKor2T7ytUs=; b=Y9ECPZVFGgWmtRzBdfFXX59/c6MmiyUVuNUjxGtY7h9kaY6sNplq7E5jtdp8xH1d0q QGxItcxvAL8abvdJlKrWOEJTTEce8ODiKyvI65sZmLgPK342B1dgAa3DM4z+LrlgVZCx jRQPrB8l7qWM80bc1knOz0zW+8SWSjLyQgnj1s9yYM9I1903rcUDWgAxk+cWKaLViVj8 trA4Rv9oOc7OLDQyvo+vFteCZdRDS56XX7HQzpnkmFgAvwOtFbWFeQ2WtwcZl08CXElP WqTocIZ4Dj8FmYu3FG36l0W2vWah4/Rn2nNss7sSYsYk995iloHeodFL20i7I9D+/VUi 9LbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jlV+5TxHk5f5zdJKEO2Yu7IxsfPBaKLdcKor2T7ytUs=; b=o1m4LzY66TmW07Zg2ucb5eyGQ6sIEzW+3HRMTFVF4jUrfX9ekvLc330nwe55P7vs+i 1W8WGZYpgicGgzyPnVy9jn8TbwOO/qbcD4b0lSSIFryXBsNmnul3vJQC7sP/G/RaBp6Z 1YvsSpv3TerEECpDCYUpoWTcE0y9azm4pOeRco8IxbEIUBEGv3RKkdW9PA9yifNMe/Il xxLOQxzhoTrdJ5hJHf4Lu2vxGkg14WMrki8MBYLulEyW0c0mDiEtM+RuWIKZYQY6O5fo owO/Hfvlnx8W2Kzme6nuHqw3Hx70QRaFdWWMdPMWrOztkvnDtdgHMvyEMr5q9PsIZw03 KFpA== X-Gm-Message-State: AOAM530rh2LrVVWfg6VSsHqocRubo9h041CdDNlDFc8wYOJ4sAPpWYKG eeCKgMFqrdairii4KkcG9GOxBFt3/ILTyQ== X-Google-Smtp-Source: ABdhPJzpf6/JmUotyqM6wBuCV4T+1/cgxQM8q5JG6EJxalCokPHBeIGxbCvX0gWnUQdMu1LWjFZuZA== X-Received: by 2002:a17:90a:1610:: with SMTP id n16mr6523110pja.190.1619211887398; Fri, 23 Apr 2021 14:04:47 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id h18sm5563910pgj.51.2021.04.23.14.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 14:04:46 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com, Stephen Hemminger Date: Fri, 23 Apr 2021 14:04:44 -0700 Message-Id: <20210423210444.197230-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/bnxt: use bnxt_ prefix on global function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When statically linked the function prandom_bytes is exposed and might conflict with something in application. All driver functions should use same prefix. Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs") Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_flow.c | 4 ++-- drivers/net/bnxt/bnxt_vnic.c | 4 ++-- drivers/net/bnxt/bnxt_vnic.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index e3906b47791b..844bf1520f50 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1404,8 +1404,8 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, /* If hash key has not been specified, * use random hash key. */ - prandom_bytes(vnic->rss_hash_key, - HW_HASH_KEY_SIZE); + bnxt_prandom_bytes(vnic->rss_hash_key, + HW_HASH_KEY_SIZE); } else { if (rss->key_len > HW_HASH_KEY_SIZE) memcpy(vnic->rss_hash_key, diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c index 14ad33b4e86c..de5c14566deb 100644 --- a/drivers/net/bnxt/bnxt_vnic.c +++ b/drivers/net/bnxt/bnxt_vnic.c @@ -16,7 +16,7 @@ * VNIC Functions */ -void prandom_bytes(void *dest_ptr, size_t len) +void bnxt_prandom_bytes(void *dest_ptr, size_t len) { char *dest = (char *)dest_ptr; uint64_t rb; @@ -172,7 +172,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp) HW_HASH_KEY_SIZE); vnic->mc_list_dma_addr = vnic->rss_hash_key_dma_addr + HW_HASH_KEY_SIZE; - prandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE); + bnxt_prandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE); } return 0; diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h index 00a664c8b839..37b452f28170 100644 --- a/drivers/net/bnxt/bnxt_vnic.h +++ b/drivers/net/bnxt/bnxt_vnic.h @@ -68,7 +68,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp); void bnxt_free_vnic_mem(struct bnxt *bp); int bnxt_alloc_vnic_mem(struct bnxt *bp); int bnxt_vnic_grp_alloc(struct bnxt *bp, struct bnxt_vnic_info *vnic); -void prandom_bytes(void *dest_ptr, size_t len); +void bnxt_prandom_bytes(void *dest_ptr, size_t len); uint16_t bnxt_rte_to_hwrm_hash_types(uint64_t rte_type); int bnxt_rte_to_hwrm_hash_level(struct bnxt *bp, uint64_t hash_f, uint32_t lvl); uint64_t bnxt_hwrm_to_rte_rss_level(struct bnxt *bp, uint32_t mode);