From patchwork Tue Oct 2 10:51:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 45840 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 509B12C24; Tue, 2 Oct 2018 12:52:38 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0045.outbound.protection.outlook.com [104.47.34.45]) by dpdk.org (Postfix) with ESMTP id E580B2BFA for ; Tue, 2 Oct 2018 12:52:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I3lncQzJWnyPTMj/l/GGdr3zGZL1DcYnMd8EecsbkK0=; b=HcLnCVljE2QHO7M9rPmi+3H0143dw/3iCiK3hPOrCMiYK2+cFuUjfNImQpwOy38J14Unr8a1ON9gdIiESwNxtrJ584J5k0Y15+UImhjnu88vUTHSW6yVbsVWtjZ+ZYn/CDr4gP6Icu+L+P6LM0zRokEAIS1mOMCLAV3vTC62AQE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (115.113.156.3) by DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Tue, 2 Oct 2018 10:52:28 +0000 From: Jerin Jacob To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, Jerin Jacob Date: Tue, 2 Oct 2018 16:21:41 +0530 Message-Id: <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0030.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::16) To DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c1cce73-d2fb-4562-8208-08d6285527e9 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5002; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 3:ApV0qqEjeqk56+cXTtSCk8NDh6quusJj1jS1BMZeYVL2ikwUTxVUEKSAA5UzScpy3EZBUn6Nptgj5BflpyNIQ3s8FLu1Y7vgbrANWODJb27+zBn9ORKAtg42dAutCChZgKknjZ/EbJ1yYEO1qMfF1wEPXtL80t7fUlhzHpG9UgbCL6hJtwGzvZy0uGegefRXgJLRrbecSUD8KrAbM4qzJgRVUPrRS0khkIayEy3mzpf6USC5zaSTiDUfuh8auPHz; 25:5gkMmPRIBcgLggFCXB2BQgSbujbudLcRho8O8WeW85uoYLX2YsACokpjdB2UBswtkQ1rjtwoum8xZGCFl0fmKCxtwX4Vpt946skIHWWTF4TRWwVWJh9FEHfNR4/CAyVE2QeHc3idfWI2if99lPDQz/ow6wOUfRQFu1iGnTzGNTXEkgpgRG06FIJcaKuCQZPos1w1de6l5loFLaZS7G4GZDTRzMfSWZzG/TTjZ5UFc3Bjuv1GqOQlSLNLpQAIilPAfTRe94HNdulnQWdQd0jwoFzlhRtIDoGLFdMNmpGdPikIPciEFA1MWY58aWyH18AZNKCzgRtqWAQ2kEcJUHVcVQ==; 31:gKI9cQ3IXYXPfT+FdAgodu+Vy19BK9xZKejd9dXWL2kPJKQw1HsIKd1tkjHLZLgeUayTS0jX0PyPzFP7SxoDq+DMYKUs620ATVWf5lFu8+44gni3H8c768osV/E7WaOqHLcakSg75VEPJVLfI8uMeXzQQEasSEqR4mmIat9u115B0+ukvDKA35J5JNFZ1oGJ+o6Abh+RTIE6QgSoRu/KVJe/f8JivMAvklpaJASR5rM= X-MS-TrafficTypeDiagnostic: DM6PR07MB5002: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 20:VQoX+4mcKa5e6GFKatRW/Dsy20mCuV9ET1AqX4yzUprh4pHncl5piYXE/7hpkpoNegzqQIfB78J941rXwsVITrM4xk8F0uLtWz1365Aq9jpkwjj4W06g3mVvJHOf5DLaZwNCfGf9kx8oJLA3XsZP4qbkbj/5IevQQFmLxViIaHj2Sv/p+4XQgnBTaGdZZ96qpQzjscfw1VoQYtPXnOfOm1k9eu/kSq1ulOef/D4Kyv2rt6w+HuXSIv8HIPyIZAPk8CsVou13Q1dXeKtUbFTVyL7GA5Zixw9x04QfntnxNtmACLL75yND4iesSFF3MgXBs1H4z+U+bg6LWwsL1TPvVtGe3Jl8HHuec1fRyY9wUV57iTn16ETWa5LWwYus8Cn0pPOdiPNIf9gxDm4ON5BUfnVDgNQzYyXrI1gsmtNinrEqNVBlJ+wW5wCoNboiIr26qMlcu4jXmlU3pXhvMoxiNP/YPYeWgsBnv93H+J04VvmRluHQQMonUxp/2ntmsQzNmjzwMp8WJK3QhdD1YzHb4WfoCcuIoC7rJZV2EtqhiNAcryUSCtOKia6qpAeNfupGpgQylVuI8gO2ZNTMURbHcxkw5G4II6m8ILUddS0Lc/g=; 4:RzEKQZQAGBcICeZnH7LV/v9Acblv0HYw5iERIXp95nama2qT/MzeKITmD0gC7Bm0c1B1DDpjN6t9yz2/23yGyhQuGfmyNzJ/RkHrFDpAbGut3/BsKvcIFjya3iHB/GTJAxM761lgTp0lLiw2AxfouA3mSEriyoV2j3bp+mGO2C4I1ZcEpOgGMIUnNNoCoxWlrVtMFrYjByq5AYMRz0qFfXAIQVe3GNWirdF/PlrrVf22J0TLGwJyrqM+0suTezjw5lCwmRvYYU4Jie+GQAfJMA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(10201501046)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DM6PR07MB5002; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5002; X-Forefront-PRVS: 0813C68E65 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(376002)(136003)(39860400002)(366004)(346002)(199004)(189003)(6486002)(5660300001)(97736004)(26005)(106356001)(7736002)(186003)(36756003)(305945005)(25786009)(1857600001)(6666003)(446003)(42882007)(110136005)(956004)(47776003)(3846002)(6116002)(1076002)(16526019)(11346002)(2870700001)(476003)(575784001)(2616005)(105586002)(66066001)(72206003)(4326008)(2906002)(53936002)(44832011)(478600001)(51416003)(50466002)(52116002)(81166006)(6512007)(55236004)(81156014)(107886003)(486006)(8676002)(50226002)(76176011)(316002)(14444005)(69590400006)(6506007)(386003)(68736007)(8936002)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5002; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5002; 23:iwR/JO1MlMgeuzDkeJtUMBmvZukjyAuBD9IhQHYWU?= R0tohad2opyaQOGsaiItFTH3iuW3tLZWwIbxK8r6LtnWMBzKIhczPclgmPKI5vQkxNCaP90nFPaHoHYkv809kBpvQflBmwJsSm/dWCVLP5Mtf3l+xeaE1pASeyna8L0Sx4dTk4LeefxAYYaATdIBtwzu12Z5HhX1YUmSe9+05D/HKzoj4VVIaNr69dIRP4rRhlSrP/dq+PVPIO4EQYlOszTU5eiSk5xJxQFYsjLK8E4MdR/tlu9l1mpQ4crvCumZzlm3QwWhDPiJ8ke+A2wxFK+g/g/bF/CVMF0vnJHxT4x2BL1fTHyLYyyvpOMN274++j36W8RY4UWWhyl+BueYVTh4FBGhgID03kshg67iKbtgh4yDr4dlFBi+cBgfdSlVMkVBfOIUiYR7bKZFr+uAknTajel0z6wMlBaF8duAFTdhRRxwSohRZNwImRCpNldjU1LXX6PwNX66wpt9x0Jc0R070+ZCyJN/m5dWCMruE4Tg1m6D9jDyVZ9WlrTmOyUxt8IZ0JRQs6nMeGwMe5KWmZHOEqWMJAZ2+7Q+3fwdFDF7e7c68nUyreeZcnH2BJtCumMGHX/0R+nk/tehMn4ChuIBa3M8cc1odQC+qXUCeFmflSTmhSqYlMQZMNc7PrgrXNhJFY1rCqOdtY8F7YCpumhqqDo78T8TwFgW3wtznY30h/CGt9tJS+KzD0bI3UcJaY/6JaMb4SnTW7pmBkHVkfYOu/xxKlR4LG17sBnyEoMb/Wzh/DSN/BhetJg/KPfgHMZuK7sKZNqDMJhw9MTYRZ+XMepNEv9xKTWyqxipYgCHUh26JkLKvRxZXoI4Xm1cOSQVKgiCWJQ+VRZgyC83xwW+jHbfNGotHkY67vPFBoetOdYxw3yLZrja+YxuW6OiYIADTBPcTbwr/u+jkL/6H/DeqTkw4kHh6sScq6X77cMJCJI4wT9vOEhMmp/hTpTiDp/XGuKyHN7JVJ/3cgZBX3D4WduPq0A0XLoteEghUwrszdciXlFxx6Uyz/xxCZpaQHb9vVznOrHoPU75b5OZkK/iMC3HOMjMHQR/b14JL4AVkzYm1c5DGXgJtzRVWWZNc3nNBQ46MXijK2nzxtb64ZscCNwdtQtv2drq1MqU5PCN4+/cFJk0+9e3maIdWfKG8/f91ls8lf6+YyKDufaDUegSN9kAxnpslCuliSETK8nJAzjzsb6UxN1IMZ/1IyOG5gPTl/ZTd6qijWcdmjP6jjpo9Lu4+551ad1qlk64yEMJUMy89eepCgnppLxGLs6Trb8TFR51Ex9CY8DJdsAriWPe/sWonyFuw9rhJfB96m7ZkBwn++clxpYwA/eY2zyw5qgOIj9Q5VCqNH3PWP+vsEh X-Microsoft-Antispam-Message-Info: 6Lpuaq1yvKJIHaLKoxfNtviQOhBFlVkjM3rMqnQiDVnZblEFjnkhpfVkfY7QyWV3FQ3MB6kkk3CiyCNf2ZDgbU41HxG2gVvqTGtpfEGiFcmPSO0qvY0ihAhJmvl/SPKZxYM+u/XH90xpTt3kmQj/MdKQlE9ti3ygE+Y5AiVG8VR0pvpu46ZdNsE/rYcd2bY4pIleEusjZzfFujlxgcNKnEwi4H2vSCrog3rkLVN3ZM72ecDz6MNfXD1taRaiBErl+5+t3RtS7WvEnaOh/YDznhilD+pchWvE/QTX2redjsYZxRau8JmQZWDjQDO7xiFxsN98thkel6wLjmkVjGmRcK/r2RI/2iPViYqtGp3t58Y= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 6:mWk9q9dedVuBuazMGxGhBmdfTKS4yibk298mjZ7rZOvjRE8mH4dj/9ifjn+Vw7FmVHc7EqzFcnBq7f5ohPonuVWTOE3goPoC0EPYstzeMlCkp2W6OuEFlSiqfmWc0xqRpe/E/3Ixvbp4LQ/rRUsa/a3kbc4ZdK5QaSzX73cPKwY+kSQSMUmd8XjgAXMj2IEb5myn+vWuK9n3bLFJWIApZMLtiK+4k2SqAgUoCa0xgrWj88YgOwUGMIqkfK4EbQttu+nC+SiZriNdM1cUq4/kCHK686y0TLeQwBlRzLiWelW0olUTyZg92mL09RvQIGwf/cYcHfWpfJZM4mrIfPyE4nLe+G9s9UbLGevJh9KZlCWv+GbH0TNy/WZTs3roAyban5MCn8xos5vrea/pc/OsUWKdthjhMKWTiHIoOtdQDBCEw8lZZlksn88k4TwaCBOrNz5MUHM5WeNVlBQJhhI1jg==; 5:e/qYVNxYpJXcJa4xa988/h7vu2dArWSmjnCacR+xY0O3CIsRn0UUtEpHE7R6kwDPzncnb28zqWl2rJKQMNu9a7rYSXpGrBw1kFlKrz34w7d+u9F/zVHADb+wjMYXRul37N4gAWSDqRLecFh5uI/mmW0LnsRVNFKamfFXco72AXc=; 7:8O2K+3d9h/TVCy7BRGYy5JJgF2TobxVVJQDZxpE5R+yjitMiycaQJ3FsALKYIbrDX3GwtM1R9CrBPo16zL7Vd1VcW/xvL1OVUcv8rFyzII02TCPJLdhC9Mh0Q8gOOMItbWmI6ktWhJ0tZhDP7NJWLno792C4a2vxWvy81RKwQg/0IRMx92hkonbuSvjy8yc4flfFLqlNLctJzAkJQASj9BvL7ustDc564xrWh1WoM62t8M+5m6/8A4eoQuNDeEhe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2018 10:52:28.9105 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c1cce73-d2fb-4562-8208-08d6285527e9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5002 Subject: [dpdk-dev] [PATCH v2 1/2] ethdev: add SCTP Rx checksum offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Added SCTP Rx checksum offload support Signed-off-by: Jerin Jacob Reviewed-by: Ferruh Yigit --- v2: - Fix printf formatting error(Ferruh Yigit) --- app/test-pmd/config.c | 9 +++++++++ doc/guides/nics/features.rst | 4 ++-- lib/librte_ethdev/rte_ethdev.c | 1 + lib/librte_ethdev/rte_ethdev.h | 1 + 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 794aa5268..1adc9b94b 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -576,6 +576,15 @@ port_offload_cap_display(portid_t port_id) printf("off\n"); } + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCTP_CKSUM) { + printf("RX SCTP checksum: "); + if (ports[port_id].dev_conf.rxmode.offloads & + DEV_RX_OFFLOAD_SCTP_CKSUM) + printf("on\n"); + else + printf("off\n"); + } + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) { printf("RX Outer IPv4 checksum: "); if (ports[port_id].dev_conf.rxmode.offloads & diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index b085bda86..d42489b6d 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -576,7 +576,7 @@ L4 checksum offload Supports L4 checksum offload. -* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM``. +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM,DEV_RX_OFFLOAD_SCTP_CKSUM``. * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_UDP_CKSUM,DEV_TX_OFFLOAD_TCP_CKSUM,DEV_TX_OFFLOAD_SCTP_CKSUM``. * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``, ``mbuf.ol_flags:PKT_TX_L4_NO_CKSUM`` | ``PKT_TX_TCP_CKSUM`` | @@ -584,7 +584,7 @@ Supports L4 checksum offload. * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_L4_CKSUM_UNKNOWN`` | ``PKT_RX_L4_CKSUM_BAD`` | ``PKT_RX_L4_CKSUM_GOOD`` | ``PKT_RX_L4_CKSUM_NONE``. -* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM``, +* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM,DEV_RX_OFFLOAD_SCTP_CKSUM``, ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_UDP_CKSUM,DEV_TX_OFFLOAD_TCP_CKSUM,DEV_TX_OFFLOAD_SCTP_CKSUM``. .. _nic_features_hw_timestamp: diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index ef99f7068..e9a82fe7f 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -126,6 +126,7 @@ static const struct { RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP), RTE_RX_OFFLOAD_BIT2STR(SECURITY), RTE_RX_OFFLOAD_BIT2STR(KEEP_CRC), + RTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM), }; #undef RTE_RX_OFFLOAD_BIT2STR diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 012577b0a..d02db14ad 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -888,6 +888,7 @@ struct rte_eth_conf { #define DEV_RX_OFFLOAD_TIMESTAMP 0x00004000 #define DEV_RX_OFFLOAD_SECURITY 0x00008000 #define DEV_RX_OFFLOAD_KEEP_CRC 0x00010000 +#define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ DEV_RX_OFFLOAD_UDP_CKSUM | \ From patchwork Tue Oct 2 10:51:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 45841 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25A054CBD; Tue, 2 Oct 2018 12:52:40 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0076.outbound.protection.outlook.com [104.47.34.76]) by dpdk.org (Postfix) with ESMTP id 82DB52BFA; Tue, 2 Oct 2018 12:52:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iwUalpRyEqy4g/LB0iUsNz1wfoKiUtvZoRfTS9mwOsE=; b=mumWOchLM/ogJKhEEJdIG3YnXVD7obGm0DPz1pGAY0fR6EvRkBGX0vvTuN6Bh/Em/Bf1TsD9C2cdLG4iU8lH0L0eL6kd+wqhJ/JYzgj0fkg0LCqmttc8XYDPOV3kwgNBdBS4fbkLcTPdTACtxY3052zK8DsnAFvLaPSubjsk9W4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (115.113.156.3) by DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Tue, 2 Oct 2018 10:52:33 +0000 From: Jerin Jacob To: Olivier Matz Cc: dev@dpdk.org, Jerin Jacob , stable@dpdk.org, jiayu.hu@intel.com Date: Tue, 2 Oct 2018 16:21:42 +0530 Message-Id: <20181002105142.24333-2-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0030.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::16) To DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd32531b-c3f9-47ef-7fa8-08d6285529cd X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5002; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 3:zdMOcZTQl8Yt4xPLxITlG2e3JCi3UlVhGp6QaXwrix3h5V8J0S42kOhRKjPJq/Kr5n+HHWYwHStcbUHfwwrkubgTijT+HqECN8MQVDzMIynamwF2gA0ej2BV02Ql9T/tQqWLsbeRn0xzoNb2HE0TJd+UNS/UhVwBPIGhRtrlaP9zMkpRF0MEP8qDJ7de9/hf9OclNXwVv049q/jyQuOisCnm+P6UHXWs+LB2Cpn8BDGdlJWam3e7l/sfNW+dkUpN; 25:/jaxT0mfrtUQGl/Oe3UR8lbxhBg+MhrTKoPjYEL5KRyJor2airFtdgvTrbnAKikoii9s3rpwARUQ3QHrkf8V/WxOeD7fpk3iwLf6ePLOoA4FvSIug/F4smJVrU+Yr/35sMQMrZeZj3bcJrovCAEcsSgrZ4gq88gGJeR1AxyviZr9Zd9dihVPohURZHvaV/YwZk5XGIfwSbrWdH2Gh0ZrrNu4v2753MUJC5CEoEFMbqxbONaEbuOL797FbvMAjOQsrDpK+XaMAVYqzMZXBEOWF2L2UWKZIe8neNKXUKA66xJdshx+85IPEjq0v9TgQHwLjbHVlBHbhmRxtW83a7i1nQ==; 31:uW3VpKGk/Z1Fl318eLcHy/8JSnCE4nnr5mj7K4us65MVKTyGxuUZ36BwMWUQq5h2IDArQbP84TXB7CL893ANLTxjGQJBIh/iQCZm6ZLn+RZnBC/5ObyVbGFNPfq95zbCP52VPImbpuCh6qZFo5ILH50yxDX8G1cX35G+pUhy4Ws7+nuZntQP3cNg6wZjYKPoBatXRLS5kBLD4UMTIMC4muGU7lcmtUTvg5PB9Jj1swM= X-MS-TrafficTypeDiagnostic: DM6PR07MB5002: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 20:GPqNBiD8FbShpJu1mna/bdGwV20ewoWpghtGRnDzBGNV5HQonbaLACuAw9gNNDMd30vNHn7Qbxvizm77sG5/UfOUKGPS5SLZfeB4YN+ycntKqQrQOy8RwHZkn+kIX+9SYPCXvmXEXJ8CSIGmdi1oSUxbOfAjv+mNH1cqegXdcQ2w7xF6yAeDmJ5WfCdXMYhrJvpPI+sEt+t8HOrFk+RKfmPLgNJXdGuFTjIjFaCMlXuCDLIE6fSaktCXDY5tbOJc26znC5HX1IAU/kQJGMg3G8g+icAcYn5dzfVHw30nfK1uc4o/31rxFuahh9+4pzDki1tqxx8DOUa7oKMfdhp7CmPxxL7dQ+luVIyYoQ4osq/yk62Y8P99c/zzM5N3To79QczC2+oAn2vtMK9XAwXo9/8p1yedMr0OPyrHdmdfcRtelOB5eCv8eSPZD1K/LgeBLHLaNVEF0G1CJ2HkvD5oP43fIUWdIZySpf8Bx1KaG2pUhsQhKf039agL7tQFWMvO8RtGONUtHpLCd3hPUuYBxDmzDX4/SCC04c7p34XOhhL7DWcGaBdadMWDDsgpQgfbSUynDMmQ/ZvexhazPX2mzTb0tLrwUliJWsxvOO5ItZg=; 4:k7KbDyjTeM6trrV/ghePhdhpnIiCWIj1Vvvj6XST1rQ6FmSqXYF0amiZ80yxfbGu0MmkQ4uXulHzfnJet9oyNr8zr5I0AuATtVJKVoXQ58nDXOCX4VtCLZzZvRW6HLIZpxl105D/FXrvvIfTfQfuy4if+zA1TfuQG8/EUyEcO+efvqLd14o7uosbvsk9xHZtNqe1ZkPbisGHhFkUzZ3PJzoa8LKUGbpekVqMtNqrA0z7Qp8K75Dhe/M10NgzyJp8kXYEaBFK77+U597H/5bBzFRaTbi+fifR5qt4Gfuiz+okWzXAOR/cv++K0N0pmi1m X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(10201501046)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DM6PR07MB5002; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5002; X-Forefront-PRVS: 0813C68E65 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(376002)(136003)(39860400002)(366004)(346002)(199004)(189003)(6486002)(5024004)(5660300001)(97736004)(26005)(106356001)(6916009)(7736002)(186003)(36756003)(305945005)(25786009)(1857600001)(6666003)(446003)(42882007)(956004)(47776003)(3846002)(6116002)(1076002)(16526019)(11346002)(2870700001)(476003)(2616005)(105586002)(66066001)(72206003)(4326008)(2906002)(53936002)(44832011)(478600001)(51416003)(50466002)(52116002)(81166006)(6512007)(55236004)(81156014)(486006)(8676002)(50226002)(76176011)(316002)(14444005)(69590400006)(6506007)(386003)(68736007)(8936002)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5002; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5002; 23:DKiI8CLVJ3e23nstEw5a9BMZ4lmsRM4f/i+c3+Z6U?= q//NH9yhJpk5mwedqwM4fAaj4nitOWntkHt4VqpPdRo/Q0lsuxax96tOGmY0M9mXyicJNQocpz9tRKPG9yasassxW2RM0GTP2rUIThkiDutqr5zdF1a3VwKtqvuXsBBCo4kI1h0p3Ejqc30gB/KGY/zBO3kHcd/qhjLh130eKrPRMmuLHUePPZb0esJQmN3jNdHEv2ulE1SQ9OlwmjNkfRLgu7QDRxVHQaQ0dzYwfkV/A3LNGR3OuWu6zeqiQV+hyZTaAkDSGr1cWIr+9Q6bvw7SSewJmmOLaqQi18DeSaeog6GWK4NBsflqEW10gp36dijlblSLs+kKRPK33pHOFJqB6ZMLERWNGC+MuTrbuIqAPqA7/MwdNQCnreKtZJ6/4tmyIqQ2Uth28jNV1rbaaRb52i0M7NU94uSPK0J3VJ7shaXTwH8bJamQIMOZtvQku6oqgdZOXpOj2nd9dhkD6WbLJy/5Nljy6qged2lAJWIq6y4ZDKvEHsJzu+A/FjyK+00X376c8lGREeRIBSVIh6im25Q3IpAQGrA2jx2wTYiXsk6rhodbldkSBPNahgaVodaPg6/GeIkhvj3JcePElhoLboFox78LbFWFW6jesLQkCVl22gvc12+9BR8hzwp0wsoX6M5Mv1GxVmW0yh48kWfB+dRWFDqOP8bkueqmV+sLHzVwuAblZcW/LvbQ1vPKXr4PMpk0kXv5uP/V81tD3x5u3WrpBfKPRKK6KK2mZMFLKxemKjZGHvdYjYTXl8d6WA0VGpRBGZUegmMaq6WNbyTRMdDhCTY5fnzeKE5Q6seUMNlxLS98zLBnrRIHzh/WVX9exVxnoOWErDQ50g/64MG8WMsnQD8r7yrOFMM5OszO6Yp2bzG7341Ee8dkrA9UPeUyX2DKimD502azVRByBc8Op2Ei2ifP4AYGzXgi6uDPP24LVFZusQL1akroaw2Moa6kC1CplHorTdbb/T0PstzoNu9Uzz16jmAVljgE58Tt2eQF9NKC4POCC4t0ubbZvmgc8u2tPol+mc/ODjKt12APx0M1TeVOOzIobcr+5RJJLyAoM++rTRmmgDrgz43hZmH3+1JniGAur0Gixz/Jms60P5F+Ni1uSH4JxVfGE8LT5xsIY/1HB+xndjOb1cfEEF7Q2M/Y8CVxYtFgZ2iB48qnEH3qk/Vm/UT+hjBTXxI5Pra7nbHlWn9bgZkTyQBOD7m/EqssVtiF1I3Oc37q7DtiuAZgbkLLqtZ2AY5kbimxMpkSyE3duvKfZ/HMm12QgFewEL6rlxozazVKKosQwNk0VzdGnly5RHDotFyG20tNt0/tCQ1icmuLQN1WCCOarw= X-Microsoft-Antispam-Message-Info: WtetyrhRzCbaOZddDZyW9fFZ1RAfNZHIg3kqpwxTusmkh8xdU3aOzuBf75Ln0rtnlOfdewnq8kYoeTUO1GWpYyR48T1iUZqIP+aC1MMkuuwntfvfNETbwkO1ZAp7tWSoRqxDfi+5jCrezvUKdwYH6i0C4c1E7+e89yP3Olr9g1s7m4FFkVc1cDv7FEkpwcg4CbioyRiL3m1uBnofUlECs61jXvxv3wi/nVLT6X0k/u/fe4Li+pepfKu2shxoiddhq8+yDx7/Xp9eHjnI4UvxY4EOFwz0epkQ9DUPyYXffU04oQMH507aTiD/8AEW+hpaW6saexI+SXiCVEVzuli9nL/5warxLISr8NGSA/gTXLo= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 6:q62g+n8AC5MEjNVboQ2Xkp+Au5Cfly/Cf6J0gL9dG2THNPZ7kj+OWqogET2Lv38u16WcR9M49QNGwGLMm3M+iU8k+WZo8jB8yfeISVsia2ZraojzAkbwcWc4JQtCqJn60JTrlXbKpQcEo9j2v6el+0Q/+LxWlnHDxpS5P3Zgomjg4qV5k9KDqpTyrhpCnwN6By0Rs7rGvdN8AiUM3teXMdtAOuQNlWgy33brUbpbearJ4fXdRvlRkUdMnC+I0pRt70gghOzbne0dHxYNGj2KRlawwcP+13gNVBwxTZ86rWdlbLGjyOa8+ylO4sGzCJAtEtCoaBOFAR9mzOknKWAp2Xr8Vxq+irwR83uEZZyXXCuF0Zsw9vSuJdnssah0KDJfoD4ZM78OlIm360pbpYUaRH+1NMxs4bbfUOXN36r4JR420NoZHZP0CuYt/GVRDs6SNjsWIcrUxHre3xZLe7TxGw==; 5:sTiMeh6jHKLCJR58KDIFF4oSPhw3t3XEkjfIv2dgtIs/tTEJ1J9FZ1YO2otOU/Oe6ESh9L8kGbGy/Vwoc1eM0rHp4tVgmVgPPiJpwkvbWfqPzPeRX3GFfzM/cLzs/7WbNeS/N91nMH4Xu7RhVaCjNbAVA2AuJjmX68+Zpy/q0dI=; 7:x03NbyS6aOGSjpzzHw2YMRpift75T9iHyoha2PZxhV8forOrDa4lOP7MTsIXE3go4UqDStcXon52ZvoOdh7DwKRN0dIHpyKQTZ7I8MADqS999vBN5t9qhdLtRiwwTy5Poda/S+MZpNOwIEMnA05bBv3doAEVYgiVBHcCi4iKkYkMKnOB8X51boE6Z33A84F+PKlzscWKNBqSbbjMTxwBMg+1IqA19LdG7so6bRW2kiN9stfUlfv+C0SnEhL97ymc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2018 10:52:33.5355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd32531b-c3f9-47ef-7fa8-08d6285529cd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5002 Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes missing PKT_TX_UDP_SEG, PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. Also sort them in bit wise order to recognize missing items later. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones") Cc: stable@dpdk.org Cc: jiayu.hu@intel.com Signed-off-by: Jerin Jacob Acked-by: Jiayu Hu --- v2: - Add all missing PKT_TX_ types - Sort them in bit mask order(Ferruh Yigit) --- lib/librte_mbuf/rte_mbuf.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index a50b05c64..c8ebc3230 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -334,16 +334,21 @@ extern "C" { * which can be set for packet. */ #define PKT_TX_OFFLOAD_MASK ( \ + PKT_TX_OUTER_IPV6 | \ + PKT_TX_OUTER_IPV4 | \ + PKT_TX_OUTER_IP_CKSUM | \ + PKT_TX_VLAN_PKT | \ + PKT_TX_IPV6 | \ + PKT_TX_IPV4 | \ PKT_TX_IP_CKSUM | \ PKT_TX_L4_MASK | \ - PKT_TX_OUTER_IP_CKSUM | \ - PKT_TX_TCP_SEG | \ PKT_TX_IEEE1588_TMST | \ + PKT_TX_TCP_SEG | \ PKT_TX_QINQ_PKT | \ - PKT_TX_VLAN_PKT | \ PKT_TX_TUNNEL_MASK | \ PKT_TX_MACSEC | \ - PKT_TX_SEC_OFFLOAD) + PKT_TX_SEC_OFFLOAD | \ + PKT_TX_UDP_SEG) /** * Mbuf having an external buffer attached. shinfo in mbuf must be filled.