From patchwork Thu Feb 25 10:07:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ZhangTengfei X-Patchwork-Id: 88206 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8575AA034F; Thu, 25 Feb 2021 11:08:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 232E940692; Thu, 25 Feb 2021 11:08:21 +0100 (CET) Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-eopbgr1310087.outbound.protection.outlook.com [40.107.131.87]) by mails.dpdk.org (Postfix) with ESMTP id 038944067B for ; Thu, 25 Feb 2021 11:08:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dpojhrKebq1Zz+zqx7b5TuTF51qEOQrjOA7/OM8VRitsDW3waA2dhXa+m8GVw9ygNOmRgVUYpIhWJkjVntWEmi+HzJP+F6bl2OfAzA7bH53aw3ZrXX2s2pU0BZH81rPHh4pida5SX7JLsi2aV/YBdLkkMoMdpWYpJZyzrtt86bXPFonAjE8svGyz5ncF+yY/fJkjMWaRnKCtt1Rt0p5UZj9h34u9VIzfOIAOs8/iBX8sACzRElhwFQ9EjDrpxaiNuqIFyiMfjxDbe32f8dvfdP7Nz5vOOscnl8uKP3iYqnpbywwX6QgnzIh1Ca8O9EXPIRZpqKCWAzRNNTBeFBMwHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1hlPhD0s2urDZKuPxtOV0JNj157IrGmXanwCaIGzTUs=; b=WIe35IqXUlXJNlSNkJOE7n8SIFqQcrC4z6KK5fAvG+TcPoRvnSwKN7Y/tdaIjZSfUOh37BcIPvsD177PpsDN6s3mI8y9hiTRrIdFQc7zzIepIaqLFntlNm2cn6WrCLrYAc+7s1NB6mrlxUBhYThChPu9GuWs4x8EwAD5eBVh2etkobOSFBxkeyTv/qB9aTLLewXwjznwICd7H4HWiacr7PSubyZQq5TO6geSPATL1mkyJQrkJx5ofsH9Oao2foNcW1hU2kPjg8F4tQHxBM9ZNEqDfk1ctRT7vce2Etj8ihGoLynjpFPbt+b0RjXfgOCZzCFjntsQRwG+hZc1Dm8dVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1hlPhD0s2urDZKuPxtOV0JNj157IrGmXanwCaIGzTUs=; b=c8oHw4/idNRxbUcmukp440LNT5esToaUOAoi6MzQJLD0RKM0vYhAaKefq9JwmPAy/IyMSSZ/mH3FJxODRghiJ7DzYoFyYOsZG3UkqD9LFWeCXGlPQphOIRII59OqY89nsun87GK+A+a9f34vjyvB6sNEYOTckS/SGfwEmZwFCA4= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oppo.com; Received: from SG2PR02MB3452.apcprd02.prod.outlook.com (2603:1096:4:4f::12) by SG2PR02MB4315.apcprd02.prod.outlook.com (2603:1096:0:1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Thu, 25 Feb 2021 10:08:18 +0000 Received: from SG2PR02MB3452.apcprd02.prod.outlook.com ([fe80::ac8d:e4d8:efcb:34c9]) by SG2PR02MB3452.apcprd02.prod.outlook.com ([fe80::ac8d:e4d8:efcb:34c9%6]) with mapi id 15.20.3868.033; Thu, 25 Feb 2021 10:08:18 +0000 From: ZhangTengfei To: ferruh.yigit@intel.com Cc: dev@dpdk.org, ZhangTengfei Date: Thu, 25 Feb 2021 18:07:50 +0800 Message-Id: <20210225100749.526-1-zhangtengfei@oppo.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [58.255.79.104] X-ClientProxiedBy: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To SG2PR02MB3452.apcprd02.prod.outlook.com (2603:1096:4:4f::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from N80315124.adc.com (58.255.79.104) by HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.9 via Frontend Transport; Thu, 25 Feb 2021 10:08:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3d7a913-2f4a-44a0-733d-08d8d9754548 X-MS-TrafficTypeDiagnostic: SG2PR02MB4315: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wIDV+zLaa1J5W5nOsDpuAepSKzcnxC4JjZ8/dsRtDd+ypJrB/l5iqo5okEsDYsKezSADTDway3MU/7pvajKpWP3Lcuxvxy9qustVemO8R5ojG2KxZDDrGzZHMteywvj9tqurDEqND9l0p/1PbKirKaxe/gWFb+jtbZv9p0z/BAxyBh3g3e5WAYKzcIYxJoDxvTLij/JHUG2JAvBuLAa0ULaep/z52umO7uTKzDV8Y2xvBgLT40EB9Cwe3dHlBD3az7nj3qmIJ8sIhVJfU60Ncx+/MH6kxJOMs5S13dkOx9BvKQvc3g3rvVUEbKtRwhriBaUYpkezcSr6rjJOX4cgz2gyP5Exrc5xJ1CPs9Ya7jqubmtaE46go6dPVbZVD7iTDuYdhCfiJesnpbapWn6QyyzhScF8ndWI20Vudk8CKrFWzmrUHa4aNopGMpreWo2qxCeRdZrQjIqmy/322DrGj1J9NM51TmYkHK4tiqnqHJsNtMiUQtotcfDYVkezK3aAO8bT91najqsigh5jGZ8fHFH8yl3vFWHw5Lh2AXaTb+PXj33gTbpM+YN/ii96kL3T X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SG2PR02MB3452.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(66946007)(83380400001)(66476007)(26005)(2906002)(66556008)(316002)(8936002)(16526019)(6486002)(8676002)(86362001)(36756003)(4326008)(1076003)(52116002)(956004)(6666004)(6506007)(2616005)(6512007)(478600001)(186003)(6916009)(107886003)(5660300002)(11606007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: mjJkCjPQm0A+G44M7sDn55E0zrPEdBtiTtonRkYJmGJTZY77684J+g8sU/J0ifnJL+tHI6Excoria/IuDRTBzrQdq7Mw7/fTU4+YO5pbZTR72LogVcm+Cxi8FiBRf6Sg7FwJfgISgzBJKOVbdYZkCyqUMf3d+ZTsGZbSwBCRNc7LgnDL0GQoHiQkk6EA7Hu/MAR2lIHjMgSPHq5OQ4kXmLwhfIma6y00x7rsL0iHaoUq1CzL3Mx3iSA+f8h9uFs5NtfoOSVsviSCQ9IlH1VEugSwverVcfSmTA1RGIhCfIe/g8+eXzWt+qHEyn9bR+E5iYRtID3DV7NQ2uoFsZKcsVB3gjVuuQ3MU8+VNjEygA1GGOtvXfZUz6706ysvzeCtBG2JzDbpE+Xp8Tn0pfJU+NNErmLJ9iMv0p4lHgcGO5/OccPp6el3XyG83TIw08pwknoMt3soZJjpXQ3rp4XYRlgC1Bxz0kwMDU+hVSU21U2yvIYodgkDFtAsAfjO3y8Re3TclFCexnsGmxFl445qQN3GHIWqeSvYD38w1cKxypFPrapxKuWBKFJvROmRczM7CCaZ6JiD3mjRGoZPWVcfYasSZSDnSv71WegODv239GX5a2WViDpBxOOTWbESueKo5tIrcST9M7XGqGG2b5lSB7An1iwGIr013r3MQpWL+qYhF6v9Rh2TX1YbYs6FLfwmxDb+FTOUmc4PvLIyVursCIiRVcDSquTGW98SUJHbm41cCZhd/yuSnUdaV028RHJym2W4fJ+jfUqSLPP8Fy7BuA//6FsSdbalTe5xDJ1zJ3ww7ScXe+mjxjbkQnZ00uoPsLXg4++acCeJJq6Or/pZYeVgD6QZX25ahQqhuJQizMdnbt5N48Cs7XwAZGVkRRLVHBMaZS5jKRHDCberGSJ+PQRAKjFeyp50cQbdhKCyUprBUQ/KADi3AP5Ka5imuefyGHusCtVCnbYLvPf5oeSM55M7shv4ePRAuP3652X9DRTeDhiYMrLehFPRYnE//TrrdC3kPBuvyBY+gUwImXNFFWVRAGClhAZxb26hXL7hCpKr7RLmFhYwE3vK1hO3UW8Mq9mRFh/tIFTzUkJBEFduuFlBfPT/ArJEmXdxCBFSaP/MuWpp3nBZsaAdBDJl87DdQgQ6fhQo1ad43ml1zfb9gJUHYNg53KbkQ+6mL3UPge8i2cD1er4UrxO9/HDB9LpevQjEGJRDQvqOJS+G7/Dez1CgVsxKEnC+gUaxFvwg16nqhgGvO0AsrleR0invibpgqvOEPyA7D2XN0koLDl5pFGngq8pxdcloJhIIkwInWrrqmCvdRR6sziezZsAgkHGW X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3d7a913-2f4a-44a0-733d-08d8d9754548 X-MS-Exchange-CrossTenant-AuthSource: SG2PR02MB3452.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2021 10:08:17.7098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QE/yblzvec0OBJtci0VVBwD3/gHXO95Rh2EgpGZyREfc4xVLvoxaiDZHlPnuOC3SjqtAubKY6HhgMZHhYq/ZAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR02MB4315 Subject: [dpdk-dev] [PATCH] driver/net/pcap: fix fd leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pcap file was opened when pcap vdev probed, but was not closed where vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 90f5d75ea..fb01ea924 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -1597,6 +1597,7 @@ pmd_pcap_remove(struct rte_vdev_device *dev) if (eth_dev == NULL) return 0; /* port already released */ + eth_dev_stop(eth_dev); eth_dev_close(eth_dev); rte_eth_dev_release_port(eth_dev);