From patchwork Fri Feb 19 08:54:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yu, DapengX" X-Patchwork-Id: 88002 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2D5FA054A; Fri, 19 Feb 2021 09:54:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C31A540395; Fri, 19 Feb 2021 09:54:31 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 837CF40042; Fri, 19 Feb 2021 09:54:30 +0100 (CET) IronPort-SDR: Gzctz8TZcxl8pbx/PawI4+DkQ0xTyt9/eJvtAhK5UCSxQ/r2JpDrlrI7WpTjrUkqNxqBdATP0g cyrlqeoRQ86Q== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="183905598" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="183905598" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 00:54:26 -0800 IronPort-SDR: 7N4YbI5IE/xQtbEpiZelFMmQiAKzXnqgmB7l5k4QQ5ZRdMhv6/Yri8H8LEPDlbCb/alLzSGUUa CLV72O29oPIg== X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="440184978" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 00:54:24 -0800 From: dapengx.yu@intel.com To: =?unknown-8bit?b?ImppYS5ndW9AaW50ZWwuY29t77ybaGFpeXVlLndhbmciQGludGVs?= =?unknown-8bit?b?LmNvbQ==?= Cc: dev@dpdk.org, Dapeng Yu , stable@dpdk.org Date: Fri, 19 Feb 2021 16:54:07 +0800 Message-Id: <20210219085407.97265-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/igc: remove MTU setting limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dapeng Yu Currently, if requested MTU is bigger than mbuf size and scattered receive is not enabled, setting MTU to that value fails. This patch allows setting this special MTU when device is stopped, because scattered_rx will be re-configured during next port start and driver may enable scattered receive according new MTU value. After this patch, driver may select different receive function automatically after MTU set, according MTU values selected. Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") Cc: stable@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/igc/igc_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index dbaa7a83e..0ea6e2a04 100644 --- a/drivers/net/igc/igc_ethdev.c +++ b/drivers/net/igc/igc_ethdev.c @@ -1590,12 +1590,14 @@ eth_igc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) return -EINVAL; /* - * refuse mtu that requires the support of scattered packets when - * this feature has not been enabled before. + * If device is started, refuse mtu that requires the support of + * scattered packets when this feature has not been enabled before. */ - if (!dev->data->scattered_rx && - frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) + if (dev->data->dev_started && !dev->data->scattered_rx && + frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) { + PMD_INIT_LOG(ERR, "Stop port first."); return -EINVAL; + } rctl = IGC_READ_REG(hw, IGC_RCTL);