From patchwork Mon Feb 15 19:18:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 87927 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A27A7A054F; Mon, 15 Feb 2021 20:18:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32D90160684; Mon, 15 Feb 2021 20:18:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id DBF55406FF for ; Mon, 15 Feb 2021 20:18:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613416712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K1rQEah8JwrZ365WpY8sgpRXSY1q1BHw4aHKxpAFQrE=; b=bp54grrizTilN7TwR27ZpYitt3rMYGZfgpZIq6XjzSc5AaYij8EpvE2oXq89vmU4mKptIG 0az6YgLHKsMA+LrvzOux4oSUKHZs8JTpu7IKBc+2cvSysUshvrYM94IragThEjoSG+4I9h YizGOqPf0euALTCnhlX8BIpV9piMZoQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-SeW9bbT-MMe4XXJuueQ9Ww-1; Mon, 15 Feb 2021 14:18:28 -0500 X-MC-Unique: SeW9bbT-MMe4XXJuueQ9Ww-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A65B107ACE3; Mon, 15 Feb 2021 19:18:27 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-114-166.rdu2.redhat.com [10.10.114.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4D2F60D08; Mon, 15 Feb 2021 19:18:26 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: Bruce Richardson , David Hunt , Anatoly Burakov Date: Mon, 15 Feb 2021 14:18:24 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] Build errors due to duplicate version.map entries in librte_power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Greetings, During CI runs, I've noticed lots of failures from the Travis-CI side all related to librte_power/version.map containing some duplicate symbols. It seems commit 4d3892dcd77b ("power: make channel message functions public") made the following hunk: As can be seen, rte_power_guest_channel_receive_msg was added already (it's present in the hunk itself). The rte_power_guest_channel_send_msg function was added as part of 85ff364f3bd3 ("build: align symbols with global ABI version"). I guess it may not be allowed to have duplicate symbols here, because in travis, I see (only for some builds): clang -o lib/librte_power.so.21.1 'lib/lib@@rte_power@sta/librte_power_rte_power.c.o' 'lib/lib@@rte_power@sta/librte_power_power_acpi_cpufreq.c.o' 'lib/lib@@rte_power@sta/librte_power_power_kvm_vm.c.o' 'lib/lib@@rte_power@sta/librte_power_guest_channel.c.o' 'lib/lib@@rte_power@sta/librte_power_rte_power_empty_poll.c.o' 'lib/lib@@rte_power@sta/librte_power_power_pstate_cpufreq.c.o' 'lib/lib@@rte_power@sta/librte_power_rte_power_pmd_mgmt.c.o' 'lib/lib@@rte_power@sta/librte_power_power_common.c.o' -Wl,--no-undefined -Wl,--as-needed -shared -fPIC -Wl,--start-group -Wl,-soname,librte_power.so.21 -Wl,--no-as-needed -pthread -lm -ldl lib/librte_eal.so.21.1 lib/librte_kvargs.so.21.1 lib/librte_telemetry.so.21.1 lib/librte_timer.so.21.1 lib/librte_ethdev.so.21.1 lib/librte_net.so.21.1 lib/librte_mbuf.so.21.1 lib/librte_mempool.so.21.1 lib/librte_ring.so.21.1 lib/librte_meter.so.21.1 -Wl,--end-group -Wl,--version-script=/home/travis/build/ovsrobot/dpdk/lib/librte_power/version.map '-Wl,-rpath,$ORIGIN/' -Wl,-rpath-link,/home/travis/build/ovsrobot/dpdk/build/lib -target aarch64-linux-gnu -fuse-ld=lld --gcc-toolchain=/usr ld.lld: error: duplicate symbol 'rte_power_guest_channel_send_msg' in version script Thoughts? diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map index 69ca9af616..13f0af3b2d 100644 --- a/lib/librte_power/version.map +++ b/lib/librte_power/version.map @@ -34,4 +34,8 @@ EXPERIMENTAL { rte_power_guest_channel_receive_msg; rte_power_poll_stat_fetch; rte_power_poll_stat_update; + + # added in 21.02 + rte_power_guest_channel_receive_msg; + rte_power_guest_channel_send_msg; };