From patchwork Fri Feb 12 16:58:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 87890 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D632CA0547; Fri, 12 Feb 2021 17:58:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 548F322A2AC; Fri, 12 Feb 2021 17:58:26 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 46B0822A2AB for ; Fri, 12 Feb 2021 17:58:24 +0100 (CET) IronPort-SDR: uVse3fUR3u9DQL5eBhCCJ+C5kggn5KuBaAiZpaO0DXfNj/R7h0xfD5CBy/ao8XoaSD2ibaOv8L gDVGO9KQR6Aw== X-IronPort-AV: E=McAfee;i="6000,8403,9893"; a="182511455" X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="182511455" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 08:58:22 -0800 IronPort-SDR: rJ4b3Y3+He3/NSx9sB1fymXcGS+j9lktFwrPYr/OfKaWb8ldlni2dTfTLGi5o7h3IMN8ovkET8 1iXyjojIlTSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="360466416" Received: from silpixa00400633.ir.intel.com ([10.237.213.44]) by orsmga003.jf.intel.com with ESMTP; 12 Feb 2021 08:58:21 -0800 From: Harry van Haaren To: dev@dpdk.org Cc: david.marchand@redhat.com, mattias.ronnblom@ericsson.com, honnappa.nagarahalli@arm.com, Harry van Haaren Date: Fri, 12 Feb 2021 16:58:12 +0000 Message-Id: <20210212165814.2189305-1-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 1/3] service: add component useful work attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit adds a new attribute which allows the service to indicate if the previous iteration of work was "useful". Useful work here implies forward progress was made. Exposing this information via an attribute to the application allows tracking of CPU cycles as being useful or not-useful, and a CPU load estimate can be deduced from that information. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 19 +++++++++++++++++++ lib/librte_eal/include/rte_service.h | 5 +++++ .../include/rte_service_component.h | 13 +++++++++++++ lib/librte_eal/version.map | 3 +++ 4 files changed, 40 insertions(+) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index bd8fb72e78..8595555fc3 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -58,6 +58,7 @@ struct rte_service_spec_impl { uint32_t num_mapped_cores; uint64_t calls; uint64_t cycles_spent; + uint8_t useful_work_last_iter; } __rte_cache_aligned; /* the internal values of a service core */ @@ -294,6 +295,21 @@ rte_service_component_unregister(uint32_t id) return 0; } +int32_t +rte_service_component_attr_set(uint32_t id, uint32_t attr, uint64_t value) +{ + struct rte_service_spec_impl *s; + SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL); + + switch (attr) { + case RTE_SERVICE_ATTR_USEFUL_WORK_LAST_ITER: + s->useful_work_last_iter = value; + return 0; + default: + return -EINVAL; + }; +} + int32_t rte_service_component_runstate_set(uint32_t id, uint32_t runstate) { @@ -799,6 +815,9 @@ rte_service_attr_get(uint32_t id, uint32_t attr_id, uint64_t *attr_value) return -EINVAL; switch (attr_id) { + case RTE_SERVICE_ATTR_USEFUL_WORK_LAST_ITER: + *attr_value = s->useful_work_last_iter; + return 0; case RTE_SERVICE_ATTR_CYCLES: *attr_value = s->cycles_spent; return 0; diff --git a/lib/librte_eal/include/rte_service.h b/lib/librte_eal/include/rte_service.h index ca9950d091..d50b5c8d7a 100644 --- a/lib/librte_eal/include/rte_service.h +++ b/lib/librte_eal/include/rte_service.h @@ -390,6 +390,11 @@ int32_t rte_service_dump(FILE *f, uint32_t id); */ #define RTE_SERVICE_ATTR_CALL_COUNT 1 +/** + * Returns if the last iteration of the service resulted in useful work done. + */ +#define RTE_SERVICE_ATTR_USEFUL_WORK_LAST_ITER 2 + /** * Get an attribute from a service. * diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h index 9e66ee7e29..534f41f531 100644 --- a/lib/librte_eal/include/rte_service_component.h +++ b/lib/librte_eal/include/rte_service_component.h @@ -87,6 +87,19 @@ int32_t rte_service_component_register(const struct rte_service_spec *spec, */ int32_t rte_service_component_unregister(uint32_t id); +/** + * Set an attribute for this service. + * + * Note this API is to be called by the service implementation, to make the + * statistic available via the usual attr_get() service APIs. + * + * @retval 0 Success + * @retval -EINVAL Invalid service id or attribute provided + */ +__rte_experimental +int32_t rte_service_component_attr_set(uint32_t id, uint32_t attr, + uint64_t value); + /** * Private function to allow EAL to initialized default mappings. * diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map index fce90a112f..e60eaa3dd9 100644 --- a/lib/librte_eal/version.map +++ b/lib/librte_eal/version.map @@ -412,6 +412,9 @@ EXPERIMENTAL { rte_thread_tls_key_delete; rte_thread_tls_value_get; rte_thread_tls_value_set; + + # added in 21.05 + rte_service_component_attr_set; }; INTERNAL { From patchwork Fri Feb 12 16:58:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 87891 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33971A0547; Fri, 12 Feb 2021 17:58:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A36F22A2B8; Fri, 12 Feb 2021 17:58:27 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 67CDA22A2AB for ; Fri, 12 Feb 2021 17:58:24 +0100 (CET) IronPort-SDR: smyn2CPWNngAyckG41j1uJFrzgV+yVgH44Fv9gCa5FM+Kkv9kOQ5MbUaZ0SFQen9Rm3UETmX7U mAo8GCizJy7A== X-IronPort-AV: E=McAfee;i="6000,8403,9893"; a="182511459" X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="182511459" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 08:58:24 -0800 IronPort-SDR: iX4PwLiswDwbXG0mdfmg3jxRyxE4M8wthR/mv+CpwW4CjNwavogabMXkizjqtDMfnP4fUyTz3t swv9pMyPEY+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="360466441" Received: from silpixa00400633.ir.intel.com ([10.237.213.44]) by orsmga003.jf.intel.com with ESMTP; 12 Feb 2021 08:58:22 -0800 From: Harry van Haaren To: dev@dpdk.org Cc: david.marchand@redhat.com, mattias.ronnblom@ericsson.com, honnappa.nagarahalli@arm.com, Harry van Haaren Date: Fri, 12 Feb 2021 16:58:13 +0000 Message-Id: <20210212165814.2189305-2-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210212165814.2189305-1-harry.van.haaren@intel.com> References: <20210212165814.2189305-1-harry.van.haaren@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 2/3] event/sw: add useful work done attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit exposes if useful work is done to the service instance. The normal service_attr_get() API can be used to retrieve the value of the attribute. Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev_scheduler.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c index f747b3c6d4..c78f687446 100644 --- a/drivers/event/sw/sw_evdev_scheduler.c +++ b/drivers/event/sw/sw_evdev_scheduler.c @@ -5,6 +5,9 @@ #include #include #include + +#include + #include "sw_evdev.h" #include "iq_chunk.h" #include "event_ring.h" @@ -559,6 +562,10 @@ sw_event_schedule(struct rte_eventdev *dev) sw->sched_no_iq_enqueues += (in_pkts_total == 0); sw->sched_no_cq_enqueues += (out_pkts_total == 0); + uint64_t work_done = (in_pkts_total + out_pkts_total) != 0; + rte_service_component_attr_set(sw->service_id, + RTE_SERVICE_ATTR_USEFUL_WORK_LAST_ITER, work_done); + /* push all the internal buffered QEs in port->cq_ring to the * worker cores: aka, do the ring transfers batched. */ From patchwork Fri Feb 12 16:58:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 87892 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB861A0547; Fri, 12 Feb 2021 17:58:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB0BF22A2BC; Fri, 12 Feb 2021 17:58:28 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 1A1A722A2B8 for ; Fri, 12 Feb 2021 17:58:25 +0100 (CET) IronPort-SDR: yncuD85GOA49GxNkulVdo5HvqbD3UdOoR7EoP6n/t4yGWWrRQKg7T9qz1ZQ2qKlK0tysa4GgFE 3euucRb5y8/w== X-IronPort-AV: E=McAfee;i="6000,8403,9893"; a="182511463" X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="182511463" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 08:58:25 -0800 IronPort-SDR: GYi78azw4NcIVKImxVkoGSIu9QqfTaIhdH9CqWuD41LK+LsekTRSWj7P3J0jx0iVk/qqj/0yWp ht6Rd0FYk6IA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="360466465" Received: from silpixa00400633.ir.intel.com ([10.237.213.44]) by orsmga003.jf.intel.com with ESMTP; 12 Feb 2021 08:58:24 -0800 From: Harry van Haaren To: dev@dpdk.org Cc: david.marchand@redhat.com, mattias.ronnblom@ericsson.com, honnappa.nagarahalli@arm.com, Harry van Haaren Date: Fri, 12 Feb 2021 16:58:14 +0000 Message-Id: <20210212165814.2189305-3-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210212165814.2189305-1-harry.van.haaren@intel.com> References: <20210212165814.2189305-1-harry.van.haaren@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 3/3] event/sw: add xstat for work done in last iteration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Today it is difficult to know what Eventdev ports recieved work from the scheduling core. Sometimes it is useful to know where work has been scheduled. This patch implements an xstat for the SW PMD, which provides a bitmask of ports that were scheduled to. If the SW PMD instance has more than 64 ports, always report that a port got an event. Signed-off-by: Harry van Haaren --- Note most of the changes here are unit-test changes to add a statistic to the PMD. The actual "useful code" is a mere handful of lines in a lot of noise.. could split into 2 patches? --- drivers/event/sw/sw_evdev.h | 1 + drivers/event/sw/sw_evdev_scheduler.c | 12 ++++++++++++ drivers/event/sw/sw_evdev_selftest.c | 27 ++++++++++++++------------- drivers/event/sw/sw_evdev_xstats.c | 6 +++++- 4 files changed, 32 insertions(+), 14 deletions(-) diff --git a/drivers/event/sw/sw_evdev.h b/drivers/event/sw/sw_evdev.h index 5ab6465c83..5dfa4508b3 100644 --- a/drivers/event/sw/sw_evdev.h +++ b/drivers/event/sw/sw_evdev.h @@ -259,6 +259,7 @@ struct sw_evdev { uint64_t sched_no_iq_enqueues; uint64_t sched_no_cq_enqueues; uint64_t sched_cq_qid_called; + uint64_t sched_last_iter_bitmask; uint8_t started; uint32_t credit_update_quanta; diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c index c78f687446..3ee1188be0 100644 --- a/drivers/event/sw/sw_evdev_scheduler.c +++ b/drivers/event/sw/sw_evdev_scheduler.c @@ -566,6 +566,8 @@ sw_event_schedule(struct rte_eventdev *dev) rte_service_component_attr_set(sw->service_id, RTE_SERVICE_ATTR_USEFUL_WORK_LAST_ITER, work_done); + uint64_t cqs_scheds_last_iter = 0; + /* push all the internal buffered QEs in port->cq_ring to the * worker cores: aka, do the ring transfers batched. */ @@ -585,6 +587,7 @@ sw_event_schedule(struct rte_eventdev *dev) &sw->cq_ring_space[i]); port->cq_buf_count = 0; no_enq = 0; + cqs_scheds_last_iter |= (1ULL << i); } else { sw->cq_ring_space[i] = rte_event_ring_free_count(worker) - @@ -604,4 +607,13 @@ sw_event_schedule(struct rte_eventdev *dev) sw->sched_min_burst = sw->sched_min_burst_size; } + /* Provide stats on what eventdev ports were scheduled to this + * iteration. If more than 64 ports are active, always report that + * all Eventdev ports have been scheduled events. + */ + if (likely(sw->port_count < 64)) { + sw->sched_last_iter_bitmask = cqs_scheds_last_iter; + } else { + sw->sched_last_iter_bitmask = UINT64_MAX; + } } diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c index e4bfb3a0f1..7dd35cb22e 100644 --- a/drivers/event/sw/sw_evdev_selftest.c +++ b/drivers/event/sw/sw_evdev_selftest.c @@ -873,15 +873,15 @@ xstats_tests(struct test *t) int ret = rte_event_dev_xstats_names_get(evdev, RTE_EVENT_DEV_XSTATS_DEVICE, 0, xstats_names, ids, XSTATS_MAX); - if (ret != 6) { - printf("%d: expected 6 stats, got return %d\n", __LINE__, ret); + if (ret != 7) { + printf("%d: expected 7 stats, got return %d\n", __LINE__, ret); return -1; } ret = rte_event_dev_xstats_get(evdev, RTE_EVENT_DEV_XSTATS_DEVICE, 0, ids, values, ret); - if (ret != 6) { - printf("%d: expected 6 stats, got return %d\n", __LINE__, ret); + if (ret != 7) { + printf("%d: expected 7 stats, got return %d\n", __LINE__, ret); return -1; } @@ -959,7 +959,7 @@ xstats_tests(struct test *t) ret = rte_event_dev_xstats_get(evdev, RTE_EVENT_DEV_XSTATS_DEVICE, 0, ids, values, num_stats); - static const uint64_t expected[] = {3, 3, 0, 1, 0, 0}; + static const uint64_t expected[] = {3, 3, 0, 1, 0, 0, 4}; for (i = 0; (signed int)i < ret; i++) { if (expected[i] != values[i]) { printf( @@ -975,7 +975,7 @@ xstats_tests(struct test *t) 0, NULL, 0); /* ensure reset statistics are zero-ed */ - static const uint64_t expected_zero[] = {0, 0, 0, 0, 0, 0}; + static const uint64_t expected_zero[] = {0, 0, 0, 0, 0, 0, 0}; ret = rte_event_dev_xstats_get(evdev, RTE_EVENT_DEV_XSTATS_DEVICE, 0, ids, values, num_stats); @@ -1460,7 +1460,7 @@ xstats_id_reset_tests(struct test *t) for (i = 0; i < XSTATS_MAX; i++) ids[i] = i; -#define NUM_DEV_STATS 6 +#define NUM_DEV_STATS 7 /* Device names / values */ int num_stats = rte_event_dev_xstats_names_get(evdev, RTE_EVENT_DEV_XSTATS_DEVICE, @@ -1504,8 +1504,9 @@ xstats_id_reset_tests(struct test *t) static const char * const dev_names[] = { "dev_rx", "dev_tx", "dev_drop", "dev_sched_calls", "dev_sched_no_iq_enq", "dev_sched_no_cq_enq", + "dev_sched_last_iter_bitmask", }; - uint64_t dev_expected[] = {NPKTS, NPKTS, 0, 1, 0, 0}; + uint64_t dev_expected[] = {NPKTS, NPKTS, 0, 1, 0, 0, 4}; for (i = 0; (int)i < ret; i++) { unsigned int id; uint64_t val = rte_event_dev_xstats_by_name_get(evdev, @@ -1518,8 +1519,8 @@ xstats_id_reset_tests(struct test *t) } if (val != dev_expected[i]) { printf("%d: %s value incorrect, expected %" - PRIu64" got %d\n", __LINE__, dev_names[i], - dev_expected[i], id); + PRIu64" got %ld\n", __LINE__, dev_names[i], + dev_expected[i], val); goto fail; } /* reset to zero */ @@ -1542,11 +1543,11 @@ xstats_id_reset_tests(struct test *t) } }; -/* 48 is stat offset from start of the devices whole xstats. +/* 49 is stat offset from start of the devices whole xstats. * This WILL break every time we add a statistic to a port * or the device, but there is no other way to test */ -#define PORT_OFF 48 +#define PORT_OFF 49 /* num stats for the tested port. CQ size adds more stats to a port */ #define NUM_PORT_STATS 21 /* the port to test. */ @@ -1670,7 +1671,7 @@ xstats_id_reset_tests(struct test *t) /* queue offset from start of the devices whole xstats. * This will break every time we add a statistic to a device/port/queue */ -#define QUEUE_OFF 90 +#define QUEUE_OFF 91 const uint32_t queue = 0; num_stats = rte_event_dev_xstats_names_get(evdev, RTE_EVENT_DEV_XSTATS_QUEUE, queue, diff --git a/drivers/event/sw/sw_evdev_xstats.c b/drivers/event/sw/sw_evdev_xstats.c index 02f7874180..1b0ad68414 100644 --- a/drivers/event/sw/sw_evdev_xstats.c +++ b/drivers/event/sw/sw_evdev_xstats.c @@ -17,6 +17,7 @@ enum xstats_type { /* device instance specific */ no_iq_enq, no_cq_enq, + sched_last_iter_bitmask, /* port_specific */ rx_used, rx_free, @@ -57,6 +58,8 @@ get_dev_stat(const struct sw_evdev *sw, uint16_t obj_idx __rte_unused, case calls: return sw->sched_called; case no_iq_enq: return sw->sched_no_iq_enqueues; case no_cq_enq: return sw->sched_no_cq_enqueues; + case sched_last_iter_bitmask: return sw->sched_last_iter_bitmask; + default: return -1; } } @@ -177,9 +180,10 @@ sw_xstats_init(struct sw_evdev *sw) */ static const char * const dev_stats[] = { "rx", "tx", "drop", "sched_calls", "sched_no_iq_enq", "sched_no_cq_enq", + "sched_last_iter_bitmask", }; static const enum xstats_type dev_types[] = { rx, tx, dropped, - calls, no_iq_enq, no_cq_enq, + calls, no_iq_enq, no_cq_enq, sched_last_iter_bitmask, }; /* all device stats are allowed to be reset */