From patchwork Mon Jan 25 03:10:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yu, DapengX" X-Patchwork-Id: 87167 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 392F8A052A; Mon, 25 Jan 2021 04:10:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5E39140DBF; Mon, 25 Jan 2021 04:10:57 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7825E140DAA; Mon, 25 Jan 2021 04:10:55 +0100 (CET) IronPort-SDR: iyciUYdVfBsvNErsR8vOfIsiYrhoTe2kIkZeeDlv2IW+ZoO9CyERbESyL1M8vToMVJ4wOPQ4rV NuVQifN4uh/Q== X-IronPort-AV: E=McAfee;i="6000,8403,9874"; a="166755921" X-IronPort-AV: E=Sophos;i="5.79,372,1602572400"; d="scan'208";a="166755921" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2021 19:10:54 -0800 IronPort-SDR: qZkf754FZZWqBB5KFoGQKoOY2HIM6bAZpPLn8mB4zr6WzjQ+DfxGxR4Wo+/keSo3XMjE2zvjDP aHE2g/QVgCNQ== X-IronPort-AV: E=Sophos;i="5.79,372,1602572400"; d="scan'208";a="387121231" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2021 19:10:52 -0800 From: dapengx.yu@intel.com To: jia.guo@intel.com, haiyue.wang@intel.com, qiming.yang@intel.com Cc: dev@dpdk.org, Dapeng Yu , stable@dpdk.org Date: Mon, 25 Jan 2021 11:10:41 +0800 Message-Id: <20210125031041.429268-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210120092700.105207-1-dapengx.yu@intel.com> References: <20210120092700.105207-1-dapengx.yu@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] net/ixgbe: disable NFS filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dapeng Yu Disable NFS header filtering whether NFS packets coalescing are required or not. This behavior is aligned with ixgbe kernel driver. Fixes: b826efba6de4 ("net/ixgbe: align register setting when RSC is disabled") Fixes: 8eecb3295aed ("ixgbe: add LRO support") Cc: stable@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index cc8f70e6d..2efd054f7 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) /* RFCTL configuration */ rfctl = IXGBE_READ_REG(hw, IXGBE_RFCTL); if ((rsc_capable) && (rx_conf->offloads & DEV_RX_OFFLOAD_TCP_LRO)) - /* - * Since NFS packets coalescing is not supported - clear - * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is - * enabled. - */ - rfctl &= ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS | - IXGBE_RFCTL_NFSR_DIS); + rfctl &= ~IXGBE_RFCTL_RSC_DIS; else rfctl |= IXGBE_RFCTL_RSC_DIS; + /* disable NFS filtering */ + rfctl |= IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS; IXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl); /* If LRO hasn't been requested - we are done here. */