From patchwork Fri Dec 11 17:06:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 85020 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EF81A09EE; Fri, 11 Dec 2020 18:06:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AC62C952; Fri, 11 Dec 2020 18:06:52 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by dpdk.org (Postfix) with ESMTP id A112CBC84 for ; Fri, 11 Dec 2020 18:06:50 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 143so1427205pge.10 for ; Fri, 11 Dec 2020 09:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id; bh=HVNlZ+1mOheZ+Xx3ezvM8i/5qcBzRqMRyAILvZLgbVE=; b=HM/Kdh9/p2aqEjlWJoCRA0U1q89J4nmaaFmWRldOT79twcyPgW4h6DiVM9kd+1fupb 1Ichl41DljjmuH1Pf+5FZnm3z51zHHctNqyoyxdCCbodS3vA9nMMBWj9yFIKi1X6gT0f 10Ai0PLdwnK8dOMnNMIjqmoUYe8QNG4gb4Z+37dYoYBTJojFTyPWyh8fBiBfAly2W/QE qDybuMYJ3tloY84Z3mlRuZRlvboJbLRJ7EffeZN/foh6V+93DuxIOgarcXO3S/zM700Z e3yCBM5jKjjW7GnUFjGk6yGvnSkQbVtg3rcl9pfZSlV7bIlFPEduVLrHyf+H6XgIabrH QURQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HVNlZ+1mOheZ+Xx3ezvM8i/5qcBzRqMRyAILvZLgbVE=; b=Zb/58LR6aIpnjgV23TTi5okRzDNhDlTi/n6teetfgldydtdECjME7+I/cGevkmwE8L Hw4vqbLluX5JmksgQGdenfhqfRLd1NgFDlymxxQhfpnKAK20rblTp4E6eE9SzCf822yK x8bxBo0iC6426JBbl2XEeQpXffWlyCs58xw6v2Z8g7ixkXK3u+OBz+106a9J9zKRhFqI /2goXNg36Tbpc+kXINIiZYHLTS7KdvT9LcknpUpSh095bIzTvobXEbdKtV+J9IqJqzag tI9GP4xjEk6H9Zm/5ac9jCj7J2+H2T1syWDRCv1Vj3+32cBtUENYiwcsXhEoOhOu95K+ kpRQ== X-Gm-Message-State: AOAM530uzm759SoWo535Idn7ba5XmZbuR1VWLCNda1pq4nAe/OyW7cE1 NQzO4b6csYDDOR68YpP6vmA2RdiOxhFP2A== X-Google-Smtp-Source: ABdhPJwqdExce/FGTLpz1RzoLXgTXhnbCE0lbgI+KoQJufzjkQZr8eJe7ZCq88Ihdm46jnf/3WAMaw== X-Received: by 2002:a63:4956:: with SMTP id y22mr12521078pgk.266.1607706408349; Fri, 11 Dec 2020 09:06:48 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id z20sm10386138pjq.16.2020.12.11.09.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 09:06:47 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Andrew Boyer , anatoly.burakov@intel.com, stable@dpdk.org Date: Fri, 11 Dec 2020 09:06:15 -0800 Message-Id: <20201211170615.32827-1-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] eal: don't log uninitialized string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Our Coverity scan pointed out that path[] is never initialized. The official DPDK Coverity has not reported this so there is no public CID for it. Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") Cc: anatoly.burakov@intel.com Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- lib/librte_eal/common/eal_common_fbarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c index 1220e2bae..6ce89af83 100644 --- a/lib/librte_eal/common/eal_common_fbarray.c +++ b/lib/librte_eal/common/eal_common_fbarray.c @@ -83,11 +83,10 @@ get_used_mask(void *data, unsigned int elt_sz, unsigned int len) static int resize_and_map(int fd, void *addr, size_t len) { - char path[PATH_MAX]; void *map_addr; if (eal_file_truncate(fd, len)) { - RTE_LOG(ERR, EAL, "Cannot truncate %s\n", path); + RTE_LOG(ERR, EAL, "Cannot truncate fd %d\n", fd); return -1; }