From patchwork Wed Nov 18 11:45:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84317 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47562A04E6; Wed, 18 Nov 2020 12:45:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C547C872; Wed, 18 Nov 2020 12:45:41 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 561F25947; Wed, 18 Nov 2020 12:45:38 +0100 (CET) IronPort-SDR: NgtJABtJC4/XwM44rpkDO1ZUxn8/0qH+qU1M9zGfKlGJ8JoLJN7Gtoh6gRJc/FxnH5pMuBdn3Q mhVu36mc7rKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876058" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876058" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:37 -0800 IronPort-SDR: yf3y8Pcl7H3u76ahnFjh7dDRi5dB3hSy1aX+KJoDOqXkvSgUb4Mybu1Bj8m9eBWQRycS0n0C94 3pUgXnIb0hww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313099" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:36 -0800 From: Ferruh Yigit To: Maryam Tahhan , Reshma Pattan , Roman Korynkevych , Harry van Haaren Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:19 +0000 Message-Id: <20201118114525.99053-2-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" '_filters' is compared twice, second one will be always false, removing it using the message more relevant to the '_filters'. Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- app/proc-info/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index d743209f0d..35e5b596eb 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -420,11 +420,9 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len, } else if ((type_end != NULL) && (strncmp(cnt_name, "flow_", strlen("flow_"))) == 0) { if (strncmp(type_end, "_filters", strlen("_filters")) == 0) - strlcpy(cnt_type, "operations", cnt_type_len); + strlcpy(cnt_type, "filter_result", cnt_type_len); else if (strncmp(type_end, "_errors", strlen("_errors")) == 0) strlcpy(cnt_type, "errors", cnt_type_len); - else if (strncmp(type_end, "_filters", strlen("_filters")) == 0) - strlcpy(cnt_type, "filter_result", cnt_type_len); } else if ((type_end != NULL) && (strncmp(cnt_name, "mac_", strlen("mac_"))) == 0) { if (strncmp(type_end, "_errors", strlen("_errors")) == 0) From patchwork Wed Nov 18 11:45:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84318 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 978ACA04E6; Wed, 18 Nov 2020 12:46:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED466C8CC; Wed, 18 Nov 2020 12:45:43 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9D4DE5947; Wed, 18 Nov 2020 12:45:40 +0100 (CET) IronPort-SDR: T7E4skyl+jt0CoGqkguLPXOabcx2EHExI+1cgk0RUKFI1/sbEM+tGRhWv477uPzwk6wb0qTRMD XeCmp3Fmxydw== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876061" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876061" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:40 -0800 IronPort-SDR: 61IvArz9KogZDohY+K2KEotiwo/uxZoFbErGa9Q0oxQsaCv/ucChd9GBePIkbXO83OPVbXOaTL 40lRxENHhwmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313123" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:38 -0800 From: Ferruh Yigit To: Maryam Tahhan , Reshma Pattan , Kuba Kozak Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:20 +0000 Message-Id: <20201118114525.99053-3-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/7] app/procinfo: fix negative check on unsigned variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'parse_xstats_ids()' return 'int'. The return value is assigned to 'nb_xstats_ids' unsigned value, later negative check on this variable is wrong. Adding interim 'int' variable for negative check. Fixes: 7ac16a3660c0 ("app/proc-info: support xstats by ID and by name") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- app/proc-info/main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 35e5b596eb..c11fe25af4 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -301,14 +301,13 @@ proc_info_parse_args(int argc, char **argv) } else if (!strncmp(long_option[option_index].name, "xstats-ids", MAX_LONG_OPT_SZ)) { - nb_xstats_ids = parse_xstats_ids(optarg, + int ret = parse_xstats_ids(optarg, xstats_ids, MAX_NB_XSTATS_IDS); - - if (nb_xstats_ids <= 0) { + if (ret <= 0) { printf("xstats-id list parse error.\n"); return -1; } - + nb_xstats_ids = (uint32_t)ret; } break; default: From patchwork Wed Nov 18 11:45:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84319 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 733D4A04E6; Wed, 18 Nov 2020 12:46:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4A48C902; Wed, 18 Nov 2020 12:45:46 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 43B65C8CC; Wed, 18 Nov 2020 12:45:43 +0100 (CET) IronPort-SDR: 5E3YzCg1nQrIaY6A08YsfUc1QQZBnO5FbxfH9xXCtfohOcux3RVlQAVjIsf/fpDt1l90SBuIYK qgAu3muPi6eA== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876064" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876064" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:42 -0800 IronPort-SDR: GAnN0wHJdjeZpscW4syskshCEp3dybPMpkx+bjep7Ilcq3kEQ66od2oKr7mTtGaYNOowq2tGB3 A1TMARBtD96Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313140" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:41 -0800 From: Ferruh Yigit To: Maryam Tahhan , Reshma Pattan , John McNamara , Vipin Varghese Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:21 +0000 Message-Id: <20201118114525.99053-4-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 3/7] app/procinfo: remove suspicious sizeof X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The intention with the "sizeof(0)" usage is not clear, but the 'stats' already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' in application. Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- app/proc-info/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c11fe25af4..dc5cc92209 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1207,7 +1207,6 @@ show_crypto(void) display_crypto_feature_info(dev_info.feature_flags); - memset(&stats, 0, sizeof(0)); if (rte_cryptodev_stats_get(i, &stats) == 0) { printf("\t -- stats\n"); printf("\t\t + enqueue count (%"PRIu64")" From patchwork Wed Nov 18 11:45:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84320 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E755A04E6; Wed, 18 Nov 2020 12:47:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AC5DC90A; Wed, 18 Nov 2020 12:45:49 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 74EA8C90A; Wed, 18 Nov 2020 12:45:46 +0100 (CET) IronPort-SDR: WIZ8XUBMQ7ZScWh2E5CMCcX9eAyHnWqh3TYfVCWZf20iisi84fi+fMLlkriTXNDiLH/nxilWDr QQ13rsmA9pTg== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876070" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876070" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:46 -0800 IronPort-SDR: IDP/v0at4RQ4Jz3WVadvDkji15xlD/qjHiGOME3WzNM8SSIYrisCEom7oSiAAJK/4Z6LPc2pH9 Yv1InGcE1TUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313158" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:43 -0800 From: Ferruh Yigit To: Maryam Tahhan , Reshma Pattan , Vipin Varghese , John McNamara Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:22 +0000 Message-Id: <20201118114525.99053-5-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 4/7] app/procinfo: remove useless assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'flag' is initialized to '0' but it is overwritten later, moving the declaration where it is used and initialize with actual value. Fixes: 0101a0ec6217 ("app/procinfo: add --show-mempool") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- app/proc-info/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index dc5cc92209..b891622ccb 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1264,8 +1264,6 @@ show_ring(char *name) static void show_mempool(char *name) { - uint64_t flags = 0; - snprintf(bdr_str, MAX_STRING_LEN, " show - MEMPOOL "); STATS_BDR_STR(10, bdr_str); @@ -1273,8 +1271,8 @@ show_mempool(char *name) struct rte_mempool *ptr = rte_mempool_lookup(name); if (ptr != NULL) { struct rte_mempool_ops *ops; + uint64_t flags = ptr->flags; - flags = ptr->flags; ops = rte_mempool_get_ops(ptr->ops_index); printf(" - Name: %s on socket %d\n" " - flags:\n" From patchwork Wed Nov 18 11:45:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84321 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A46C7A04E6; Wed, 18 Nov 2020 12:47:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63DE3C91E; Wed, 18 Nov 2020 12:45:51 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 400C1C90E; Wed, 18 Nov 2020 12:45:48 +0100 (CET) IronPort-SDR: 8f7yHJk7YB4xXZ0qLukelbqGRUhpo5QbLA6B9OuTH4UHLo+vpeGBsNZytkQF3SWzQFSzo5akdD flA3qLlXOTWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876072" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876072" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:47 -0800 IronPort-SDR: 0iLi3s+ESdBjuBY/wvXgU5jGkyHA5hJffv/BchpZdAW4CU/y7lh+gu0fDVQhGRLg3PVwwcA1Ph 3UC+DqiUwhPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313168" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:46 -0800 From: Ferruh Yigit To: Juhamatti Kuusisaari Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:23 +0000 Message-Id: <20201118114525.99053-6-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 5/7] net/pcap: remove local variable shadown outer one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'ret' is already defined in the function scope, removing the 'ret' in the block scope. Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: juhamatti.kuusisaari@coriant.com --- drivers/net/pcap/rte_eth_pcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 4930d7d382..dd9ef33c85 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -1324,7 +1324,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev, /* phy_mac arg is applied only only if "iface" devarg is provided */ if (rx_queues->phy_mac) { - int ret = eth_pcap_update_mac(rx_queues->queue[0].name, + ret = eth_pcap_update_mac(rx_queues->queue[0].name, eth_dev, vdev->device.numa_node); if (ret == 0) internals->phy_mac = 1; From patchwork Wed Nov 18 11:45:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84322 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B421BA04E6; Wed, 18 Nov 2020 12:47:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8F43C92A; Wed, 18 Nov 2020 12:45:52 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8918CC922; Wed, 18 Nov 2020 12:45:50 +0100 (CET) IronPort-SDR: LN34yup6h9Dqzyzv7Vsl2xK2Ogxl6AvJ14aZuTd9a9tLejm3RHAm6UQI1Sh2/4x3sHvs6RF73+ Z0n33rgBTOtg== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876074" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876074" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:49 -0800 IronPort-SDR: jcVHGKs0SobJAEm6v5/djZ0L53p1HKVT++Fuoj0L16sNhTSkyV2vBm37zrGyAT4hEyp3wWS1Ol SRhux2IS/EIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313182" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:48 -0800 From: Ferruh Yigit To: Ciara Loftus , Qi Zhang , Xiaolong Ye Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:24 +0000 Message-Id: <20201118114525.99053-7-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 6/7] net/af_xdp: remove useless assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Assignment of function parameter 'umem' removed. Fixes: f0ce7af0e182 ("net/af_xdp: remove resources when port is closed") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 2c7892bd7e..7fc70df713 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -840,7 +840,6 @@ xdp_umem_destroy(struct xsk_umem_info *umem) #endif rte_free(umem); - umem = NULL; } static int From patchwork Wed Nov 18 11:45:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84323 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AAA3A04E6; Wed, 18 Nov 2020 12:48:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AED28C940; Wed, 18 Nov 2020 12:45:56 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 48536C932; Wed, 18 Nov 2020 12:45:53 +0100 (CET) IronPort-SDR: HDOaDgM4n6TNY3z3xpbevmdf6VLub3sBwEu48p2eEeeACUUlG1L6NRMeXRyfnjGWC5pQa9tGqK ERJB+i4q5dFw== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876078" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876078" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:52 -0800 IronPort-SDR: clhl+ZfUsYSuqX8TvLErwoSXX4xNIvfg01u+HFrrVNhYldUvFauK9cS7mnZ78jK1+5lMiFRf8G gCcbaQElfx1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313202" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:50 -0800 From: Ferruh Yigit To: Ajit Khaparde , Somnath Kotur , Venkat Duvvuru , Randy Schacher , Peter Spreadborough Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:25 +0000 Message-Id: <20201118114525.99053-8-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 7/7] net/bnxt: fix redundant return X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Removing useless 'return' statement. Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand Acked-by: Ajit Khaparde --- Cc: peter.spreadborough@broadcom.com --- drivers/net/bnxt/tf_core/tf_em_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/tf_em_common.c b/drivers/net/bnxt/tf_core/tf_em_common.c index ad92cbdc75..c96c21c2e9 100644 --- a/drivers/net/bnxt/tf_core/tf_em_common.c +++ b/drivers/net/bnxt/tf_core/tf_em_common.c @@ -307,7 +307,6 @@ tf_em_page_tbl_pgcnt(uint32_t num_pages, { return roundup(num_pages, MAX_PAGE_PTRS(page_size)) / MAX_PAGE_PTRS(page_size); - return 0; } /**