From patchwork Mon Nov 16 14:41:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 84243 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AB5AA04B5; Mon, 16 Nov 2020 15:42:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E3F1323E; Mon, 16 Nov 2020 15:42:27 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 22836F94 for ; Mon, 16 Nov 2020 15:42:23 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AGEeE6k028642 for ; Mon, 16 Nov 2020 06:42:22 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=pfpt0220; bh=PEWEZj2QJPI8csz5nRawZtWJPlefDoprHB1aFBxv7fc=; b=jsTnQ0/5IO7RZTvMlU3hUbVBaay09v7DmaX52pyIugzrkYoaqa3RKdeVAKfLcTV988ZK WAHgUK1yv7TtqqToO0orM+hk/TtCyW1LaKgNGfnP2hxTpyqHzYkOiY35m0khjETJQVJa Lw942SZ+e6FWlFzbNartomffk/hj0QFuzFunUnr+Cb/ArMPV1Ebiv9NBMAcMG5zBlzJ3 UQ9aYiFv91KB2BQ/Xffbaw/DDyiDb15poCEcb9S8nNwy6A9lTweq1TcvSXUDC66uav7q GGz5b8IO4/5BGvdL6IohH0sQlqnfwEYnPbU40820ThAMt9LhFBc2KVkqIEZazInW6aqf 1g== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 34tdftwkyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 16 Nov 2020 06:42:21 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 Nov 2020 06:42:20 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 16 Nov 2020 06:42:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSrWjDJ27rQxZOzO90zsxAIW9BYskm0uu8XjFvmKkAA0Ab/BUD1RAV/6OjmtkXLc/iT07QiArlIaRxLkedhq+URDHZ7g4jSV3nqYS/XFKSFc6rmDf1GrVFRm9yC1Ve2FeD6slEarWIvrq7eG9pEMXMjAYKrxAZwYS0iwV2onnmQ/zjtQlCuFVzkz32BBVQeWg2O8G2Pn0B3kJvaaKjdAQtXlfKpimmXhvkwEltvkNA6n4MPBhIBGyXaspx0gxOBD5CPs8fBhtAGPlIRiY8Xsf0L0nsiRfKdU8GJVsTd4VrXVASni6Q7HzPyLa9I7HTwE2YIQfHjXAHw9WgvQeXmhLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PEWEZj2QJPI8csz5nRawZtWJPlefDoprHB1aFBxv7fc=; b=BprZzNnAdk2B/WjXo3XaNwqOTmY8Lxue0SYaKTr56hxB8bfhBjh1NTPOWD7/W7cdkA+tSHqUDioSfxC4+E88JTi5RnOUptiOZJ56/x+AEJqlhdr/qCV2UmvZTTjJm5FseZLxaEqoge7dOTVP9ToG5fiEz1dV9hiaEkZTgOmBFaBT9ZwMtLsH2LofcTMDH4TaW5O+oS0kZ02IoGp+MbwYQu4AbOmUd14ZhtoqdcNZxlQ8gVcUujS3E35lukKpVH60tthuDLLsdgI2F0EbtkiF8yJnvlhxGvk2AU40/CUuxXIQf6P75yhanOnh4XdjEEXYDM4Gi15bSgSOnBtjAtz9oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PEWEZj2QJPI8csz5nRawZtWJPlefDoprHB1aFBxv7fc=; b=d5xR9enwNLLLSONoyaX7wTK6J+5F+QUEAZm+x1AW9wQcvdyskHq/ZLrlaIeN8HGYTyJAGLc5w/TpkXO+gqA309kUUxD4Nke22LhiY0eVnjWOxGlW5Fas5S7VmMqDAFA9DcThVENgFWOSGy6mP8hDaeCOjUhDndU/KN5UA7UC7pU= Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MWHPR18MB1231.namprd18.prod.outlook.com (2603:10b6:320:2b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Mon, 16 Nov 2020 14:42:17 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3564.028; Mon, 16 Nov 2020 14:42:17 +0000 From: Harman Kalra To: Jerin Jacob , Nithin Dabilpuram CC: , Harman Kalra Date: Mon, 16 Nov 2020 20:11:55 +0530 Message-ID: <20201116144155.148634-1-hkalra@marvell.com> X-Mailer: git-send-email 2.18.0 X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BM1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::18) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (1.6.215.26) by BM1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25 via Frontend Transport; Mon, 16 Nov 2020 14:42:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36341693-7b68-4623-d011-08d88a3dd078 X-MS-TrafficTypeDiagnostic: MWHPR18MB1231: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UQdhqtux4CXNjVm047Qwuci9WnJOUxuOOvi85KTKX5LF28Mdb5WWic4VR9s7Nc4kSR19axauup6UetwXBlSzQB8E3xySUC3QiGOIxNlNYrVBj5OetoKY1CmM7NukYzTxsK/Tx6+zfkw77wXt6Nc8RRRWwbvjmTbVg1TG/lZX6wPIu+QX/YBMvhqSSKY5xMdF8bZ6WWLsSiaOEEe3d8HSwULu2fo2SWNX2HpafJF3GMsupiqWH6Ck9pA+wJr6S509dMMufI9k4DvOlr1q+mR6olj4cIQNHwuNCVjdQLjx3m3X+sF8fstMGq0TP87PEcjxfKCSfh654a5OaziQhOKgFcEhcojhJN6pR2OlRwwJjV1byvO+HdjA4OzRKM6krPmhuXFiSe9CTMJxStSrfFf5NuyVynso2zfGJXxFSZEpuLc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(6486002)(478600001)(4326008)(107886003)(1076003)(36756003)(2616005)(16526019)(66946007)(66556008)(956004)(6506007)(186003)(5660300002)(66476007)(83380400001)(2906002)(8676002)(26005)(6666004)(1006002)(86362001)(110136005)(316002)(69590400008)(8936002)(6512007)(52116002)(6636002)(36456003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: TedqoDEeoJb7TStsn00Yhxk4RUx6+14d3mIMizYt9HteRCJiDEQ+RIuxBg/b5GVYxDZd7ZWymF4MrLvEZOPsiMIUFsFYs5hwI8I+u8J34oZP/pALUdmfPXUE/EXf+Gtqq7h5jhDkd/qQ+MO+h5qwMXrAQx/5l6WO/Tf2MbuVMulqlM0ToCOAtIoXpChu3f9YFHzeyfUR5S0h6pENa3GERrBcE83etqyiKAW5rusDV7Nud9zTUwX1KENd4sihRMCqWc2/K1ND7jj8XCxA3n293pCAWbVsVo9iZrv+n/VxPTv/vNXyHAgV9qGbP1wiglh20YnYjW9SqYg0NOReUC2Zj2cducod5OglR29qVqQnSLsNxu7fmjc0xwMCHwp60UeV+ip6XWLNUiakJxh/ABb3Vq+DLrIKlhv6hl/sGuObPCLOl7FL33I9P2STM1OatUtBX+LGjU1zpttJtwveA5f/uWhF4blHHUAFFHvMA7zJSRGKCoq2Qf5qQEqQ7sXuinMKyn8Kj3Ahfioz7aK+k9tvfMGRleMOQOuPw32Re4PsD+z0+VxsWJ31KpMylORP2RamhbKaRzo7Zr3tEr3ZrJYrtzSRNFmgyAn2vq237ooqXFI+P5qmDP26oUShTJk+pBPUwqsKBGnEUCPfhKf++mcFShrAnYCLJDu9hSx7guJfT4giTZAQyLpZ3YWlOqiMcZb8gwKUqseuoGyhfkUSn4+tdcr7QlzEdr1F4aewZOOL7qzbukJ5jbiZAAvYNG8CaUc4+krvyW6Jf8JGWdZjEAe0ZlXUZOInW3WR8bUhhLw0iFaBQhuhUp6PEqYroMB5PkgcL2nT3oB/xiFhjjifdNr27V2tCXn2Qcz+dGULH2Tn9BEMdLACf0svqkhETRztl0v4IPZVxikqEgL0Z26vf8JePw== X-MS-Exchange-CrossTenant-Network-Message-Id: 36341693-7b68-4623-d011-08d88a3dd078 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 14:42:17.1487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A12Uw7C8jVdCUjXqjh9OSN16Ys3unOVt5F9qrgPHgqAy41LFQhWPOHFONYMbrZwaXhMWmZwjspQ+EH+fcEgaZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1231 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-16_08:2020-11-13, 2020-11-16 signatures=0 Subject: [dpdk-dev] [PATCH] common/octeontx2: fix msix offset structure fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Syncing the data types of msix offset mbox response structure fields wrt rvu_pfvf structure as in msix offset mbox handler, respective block LFs response field is initialised with rvu_pfvf and mismatch in the data types of respective fields may lead to issues. This mismatch in data types resulted in a bug where no sso msix offsets are returned. For 256 SSO hwgrps, 256 msix offsets are required, but since num of sso lf field (rsp->sso) in response structure is u8 and is initialised with same field in pfvf structure viz u16, value 256 corresponds to 0 hence no sso_msixoff. Similar mbox changes are required in kernel side also which are available in marvell SDK version SDK-11.0. Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response definition") Signed-off-by: Harman Kalra Acked-by: Jerin Jacob --- drivers/common/octeontx2/otx2_mbox.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h index 9a1e8a7ea..f6d884c19 100644 --- a/drivers/common/octeontx2/otx2_mbox.h +++ b/drivers/common/octeontx2/otx2_mbox.h @@ -90,7 +90,7 @@ struct mbox_msghdr { #define OTX2_MBOX_RSP_SIG (0xbeef) /* Signature, for validating corrupted msgs */ uint16_t __otx2_io sig; -#define OTX2_MBOX_VERSION (0x0009) +#define OTX2_MBOX_VERSION (0x000a) /* Version of msg's structure for this ID */ uint16_t __otx2_io ver; /* Offset of next msg within mailbox region */ @@ -454,17 +454,17 @@ struct msix_offset_rsp { struct mbox_msghdr hdr; uint16_t __otx2_io npa_msixoff; uint16_t __otx2_io nix_msixoff; - uint8_t __otx2_io sso; - uint8_t __otx2_io ssow; - uint8_t __otx2_io timlfs; - uint8_t __otx2_io cptlfs; + uint16_t __otx2_io sso; + uint16_t __otx2_io ssow; + uint16_t __otx2_io timlfs; + uint16_t __otx2_io cptlfs; uint16_t __otx2_io sso_msixoff[MAX_RVU_BLKLF_CNT]; uint16_t __otx2_io ssow_msixoff[MAX_RVU_BLKLF_CNT]; uint16_t __otx2_io timlf_msixoff[MAX_RVU_BLKLF_CNT]; uint16_t __otx2_io cptlf_msixoff[MAX_RVU_BLKLF_CNT]; - uint8_t __otx2_io cpt1_lfs; - uint8_t __otx2_io ree0_lfs; - uint8_t __otx2_io ree1_lfs; + uint16_t __otx2_io cpt1_lfs; + uint16_t __otx2_io ree0_lfs; + uint16_t __otx2_io ree1_lfs; uint16_t __otx2_io cpt1_lf_msixoff[MAX_RVU_BLKLF_CNT]; uint16_t __otx2_io ree0_lf_msixoff[MAX_RVU_BLKLF_CNT]; uint16_t __otx2_io ree1_lf_msixoff[MAX_RVU_BLKLF_CNT];