From patchwork Thu Nov 12 15:29:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 84063 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84363A09D3; Thu, 12 Nov 2020 16:30:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0CA85937; Thu, 12 Nov 2020 16:30:06 +0100 (CET) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 296B65928 for ; Thu, 12 Nov 2020 16:30:05 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id e21so4439815pgr.11 for ; Thu, 12 Nov 2020 07:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=TVe4wTo+U9oFfKW5bams5VnwUVPKYUBhF13094GbKgs=; b=Y2P2BpNw/UBTq9UHjNago5SQrBPNw7hfC5eFFqBV//vDlhfv7wTFjEdk3Hn/saEcxy G+tXAEec+45lMPYB3E9/YftqaAW0xfa5mm26MKeVZHg2eucqv2hTF1mrDPaMlcFPbIU2 Q+sufQ0p57BClYPeKznVXTX3b5oAKYAYucc1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=TVe4wTo+U9oFfKW5bams5VnwUVPKYUBhF13094GbKgs=; b=j0pTXyn3Op2wZzHrv3tPr18RBy/RoOKxHTs/QzfIDjdIm68pX516VtHdojszUM4iZ+ 2xSqEAi3W5/UeryxzwkrvXDDFh0FXrq2H6r/jcX/2Zw2mAiy8DZ8e5b0j/2KZfhDQIhS P1qfhjUQ0CU851RqdlcjZDzJmy4cYGTE3I7dxaqlk1XEfUGGSwSKrZzOWLaJhIN+Fugv l3bcJOgJfaEColMa9u34jxWz6oFfyTwx2+mXL/wIpwMgHV9+xlqRP6wCyDXfx7kQanQs ZhmlAZRjxiIH5snZNlA/o0OfGIbPME6CT8W18XCMuztH+uk8fG26iTwv0++rXs6ZllSr b2tg== X-Gm-Message-State: AOAM531IfrPisJuk4XiXrmNQH+NArunfBtVxxMGQkaOED1yxvMMVWY+m ihsGdij6Q5wpkPSjAWfrgX/l/ctNeyqRmjtzkww3ns5znXdZWV0JwpC3q3k5FmYUvrbIr71Fi/0 lubwQcqfJd7/76zjAys+XwsC+KqpCIioW0yyhAvWSz92gzy71TezvL7AVSOednuf4uw== X-Google-Smtp-Source: ABdhPJx5t9Adnngl9eLw/R+4ju2DkLVCkkUjDOWrPDMBvAGI1JeiT4sYAcVKtYpycseL0nt+ip3CmQ== X-Received: by 2002:a17:90a:c085:: with SMTP id o5mr10643186pjs.18.1605195003012; Thu, 12 Nov 2020 07:30:03 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y8sm6890561pfe.41.2020.11.12.07.29.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2020 07:30:02 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Mike Baucom , stable@dpdk.org Date: Thu, 12 Nov 2020 07:29:45 -0800 Message-Id: <20201112152945.99066-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] [PATCH] net/bnxt: fix incorrect assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Mike Baucom Use comparison operator instead of incorrectly using the assignment operator. Coverity issue: 363566 Coverity issue: 363577 Fixes: 42c40f8902f7 ("net/bnxt: consolidate template table processing") Cc: stable@dpdk.org Signed-off-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c index 29643232d8..429e7fcfee 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c +++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c @@ -2522,7 +2522,7 @@ ulp_mapper_tbls_process(struct bnxt_ulp_mapper_parms *parms, uint32_t tid) tbls = ulp_mapper_tbl_list_get(parms, tid, &num_tbls); if (!tbls || !num_tbls) { BNXT_TF_DBG(ERR, "No %s tables for %d:%d\n", - (parms->tmpl_type = BNXT_ULP_TEMPLATE_TYPE_CLASS) ? + (parms->tmpl_type == BNXT_ULP_TEMPLATE_TYPE_CLASS) ? "class" : "action", parms->dev_id, tid); return -EINVAL; } @@ -2569,7 +2569,7 @@ ulp_mapper_tbls_process(struct bnxt_ulp_mapper_parms *parms, uint32_t tid) return rc; error: BNXT_TF_DBG(ERR, "%s tables failed creation for %d:%d\n", - (parms->tmpl_type = BNXT_ULP_TEMPLATE_TYPE_CLASS) ? + (parms->tmpl_type == BNXT_ULP_TEMPLATE_TYPE_CLASS) ? "class" : "action", parms->dev_id, tid); return rc; }